Yury Selivanov added the comment:
http://hg.python.org/cpython/rev/72dba0d11235
changeset: 89263:72dba0d11235
user:Yury Selivanov
date:Tue Feb 18 18:41:13 2014 -0500
summary:
asyncio.transports: Make _ProactorBasePipeTransport use _FlowControlMixin
Yury Selivanov added the comment:
And this one:
http://hg.python.org/cpython/rev/5202aca8a673
changeset: 89261:5202aca8a673
user:Victor Stinner
date:Tue Feb 18 22:07:56 2014 +0100
summary:
Issue #20625: Fix compilation issue
Changes by Yury Selivanov :
--
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issue20682>
___
___
Python-bugs-list mai
Yury Selivanov added the comment:
Looking at a man page for getsockname on Mac OS X (10.9):
BUGS: Names bound to sockets in the UNIX domain are inaccessible; getsockname()
returns a zero-length address.
If you are not on macos: http://www.manpages.info/macosx/getsockname.2.html
Yury Selivanov added the comment:
Minor stuff:
changeset: 89267:2b0e65df8821
tag: tip
user:Yury Selivanov
date:Tue Feb 18 22:27:48 2014 -0500
files: Lib/asyncio/events.py Lib/asyncio/protocols.py
Lib/asyncio/selector_events.p
description:
asyncio: Fix spelling
Yury Selivanov added the comment:
changeset: 89268:2e8a142dbccc
tag: tip
user:Yury Selivanov
date:Tue Feb 18 22:56:15 2014 -0500
files: Lib/asyncio/base_events.py Lib/asyncio/subprocess.py
Lib/test/test_asyncio/t
description:
asyncio: pep8-ify the code
Yury Selivanov added the comment:
> Perhaps, but if they request cherry-picking for revisions after 2e8a142dbccc,
> skipping 2e8a142dbccc will make the cherry-picking a lot harder.
Yes, it may make it harder, it's probably better to merge it (no functional
changes in it).
I now
Yury Selivanov added the comment:
changeset: 89270:186f6f56f4bc
tag: tip
user:Yury Selivanov
date:Wed Feb 19 11:10:52 2014 -0500
files: Lib/asyncio/transports.py Lib/test/test_asyncio/test_transports.py
description:
asyncio: WriteTransport.set_write_buffer_size
Yury Selivanov added the comment:
Nick, thanks for writing this patch!
> That's probably OK though - previously those wouldn't report signatures at
> all.
I honestly don't think it is OK. I think we should stick to the behaviour of
old 'getfullargspec' cons
Yury Selivanov added the comment:
Thanks, Nick. Do you want me to commit the patch?
(Larry will x-ray the patch before including it in 3.4rc2)
--
___
Python tracker
<http://bugs.python.org/issue20
Yury Selivanov added the comment:
> My only question: do they need to be independent flags? ISTM that they're
> always either both True or both False.
I'd keep them independent solely to make the code easier to read/audit. As, for
instance, a combined argument won't m
Yury Selivanov added the comment:
Committed in 65fb95578f94
.. forgot to add the issue # in the commit message :(
--
___
Python tracker
<http://bugs.python.org/issue20
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20684>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Larry, please consider cherry-picking this in 3.4.0.
The main motivation to have this in 3.4.0 is to avoid introducing a backwards
incompatible change in inspect.getfullargspec() and inspect.getargspec()
semantics.
changeset: 89284:65fb95578f94
user
Yury Selivanov added the comment:
Issue #20688 to track cherry-picking this into 3.4.0
--
___
Python tracker
<http://bugs.python.org/issue20684>
___
___
Python-bug
Yury Selivanov added the comment:
> I think in 3.5 it may actually make sense to expose these as options
> (perhaps with different names), so yeah, I think separate flags is
> reasonable.
+1 on thinking about exposing your 'follow_wrapper_chains' option in 3.5.
I
New submission from Yury Selivanov:
In the issue #20684, Nick had an idea of exposing 'follow_wrapper_chains'
option to the public API. This might be actually very useful.
--
assignee: yselivanov
messages: 211668
nosy: larry, ncoghlan, yselivanov
priority: normal
severi
Changes by Yury Selivanov :
--
assignee: docs@python
components: Documentation
nosy: docs@python, gvanrossum, haypo, larry, yselivanov
priority: release blocker
severity: normal
status: open
title: asyncio.docs: Document subprocess_exec and subprocess_shell
type: enhancement
versions
New submission from Yury Selivanov:
(I'd document this myself, but I lack the experience of working with these
functions)
--
___
Python tracker
<http://bugs.python.org/is
New submission from Yury Selivanov:
Patch is attached, please review.
--
assignee: yselivanov
components: Documentation
files: asyncio_docs_streams_01.patch
keywords: patch
messages: 211681
nosy: gvanrossum, haypo, larry, yselivanov
priority: release blocker
severity: normal
stage
Yury Selivanov added the comment:
Some documentation.
changeset: 89291:58fd64e55b29
tag: tip
user:Yury Selivanov
date:Wed Feb 19 20:58:44 2014 -0500
files: Doc/library/asyncio-eventloop.rst
description:
asyncio.docs: Document Error Handling API and
Yury Selivanov added the comment:
> *sigh* okay. Including 2e8a142dbccc from last night, that's eight new
> revisions to cherry-pick in one day. I really hope this is slowing down.
It is slowing down. I think we now only have some documentation u
Yury Selivanov added the comment:
> ok.
Great, thanks Larry!
--
___
Python tracker
<http://bugs.python.org/issue20688>
___
___
Python-bugs-list mailing list
Un
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20668>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
> Please wait until after 3.4 release. Not critical.
I'll assign this to myself to commit this after 3.4.
--
assignee: -> yselivanov
___
Python tracker
<http://bugs.python.
New submission from Yury Selivanov:
This is a proxy issue for https://code.google.com/p/tulip/issues/detail?id=136
--
assignee: haypo
messages: 211740
nosy: gvanrossum, haypo, yselivanov
priority: normal
severity: normal
stage: committed/rejected
status: open
title: asyncio: Implement
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20704>
___
___
Python-bugs-list
Yury Selivanov added the comment:
NEWS updates:
changeset: 89305:db749f0c6567
tag: tip
user:Yury Selivanov
date:Thu Feb 20 13:59:14 2014 -0500
files: Misc/NEWS
description:
Misc/NEWS: Add some missing news items re asyncio
Yury Selivanov added the comment:
Relevant commits: 549f451aa4c3 and dbf13a7d3987
--
___
Python tracker
<http://bugs.python.org/issue20704>
___
___
Python-bug
Changes by Yury Selivanov :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Yury Selivanov added the comment:
Again, documentation update.
changeset: 89306:1c35d3114ea1
tag: tip
user:Yury Selivanov
date:Thu Feb 20 14:10:02 2014 -0500
files: Doc/library/asyncio-stream.rst
description:
asyncio.docs: Improve documentation of Streams. Issue
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20706>
___
___
Python-bugs-list
New submission from Yury Selivanov:
Codereview: https://codereview.appspot.com/66430046/
--
assignee: yselivanov
messages: 211751
nosy: gvanrossum, haypo, yselivanov
priority: normal
severity: normal
status: open
title: asyncio.docs: Fix wording in 'this method returns a coro
Yury Selivanov added the comment:
Hopefully, the last one from me ;) Again, some documentation updates.
Thank you, Larry, for accepting these last minute fixes.
changeset: 89308:cd23d0c3f850
tag: tip
user:Yury Selivanov
date:Thu Feb 20 16:20:44 2014 -0500
files
Changes by Yury Selivanov :
--
nosy: +asvetlov
___
Python tracker
<http://bugs.python.org/issue20694>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Patch is attached, please review.
--
keywords: +patch
Added file: http://bugs.python.org/file34156/asyncio_subp_docs_01.patch
___
Python tracker
<http://bugs.python.org/issue20
Changes by Yury Selivanov :
Added file: http://bugs.python.org/file34160/asyncio_subp_docs_02.patch
___
Python tracker
<http://bugs.python.org/issue20694>
___
___
Pytho
Changes by Yury Selivanov :
Added file: http://bugs.python.org/file34161/asyncio_subp_docs_03.patch
___
Python tracker
<http://bugs.python.org/issue20694>
___
___
Pytho
Yury Selivanov added the comment:
Larry, I think you can use undocumented and private (but still heavily tested)
'inspect._signature_internal(skip_bound_arg=False)', instead of signature.
That will give you a Signature object with 'self' parameter always included.
And i
Yury Selivanov added the comment:
(The thing with my proposal, is that pydoc will handle everything that
'inspect.signature' supports + it's behaviour won't change at all)
--
___
Python tracker
<http://bug
Yury Selivanov added the comment:
I don't think we should touch 'inspect.isbuiltin' at this stage.
Please consider my proposal instead.
--
___
Python tracker
<http://bugs.pyt
Yury Selivanov added the comment:
> Rather, I'm proposing to fix a bug in ismethod.
Oh, sorry, that's what I meant. I don't think it's good to fix it either.
But please hold on, I think I found a bug in inspect.signature.
--
___
Yury Selivanov added the comment:
Indeed, here it is: #20711
--
___
Python tracker
<http://bugs.python.org/issue20710>
___
___
Python-bugs-list mailing list
Unsub
New submission from Yury Selivanov:
current behaviour:
>>> import inspect
>>> import os
>>> inspect.getfullargspec(os.stat)
FullArgSpec(args=['module', 'path'], varargs=None, varkw=None, defaults=None,
kwonlyargs=['dir_fd&
Yury Selivanov added the comment:
> So why is it necessary (and a release blocker) to fix a bug in
> inspect._signature_fromstr, but a terrible idea to fix a bug in
> inspect.ismethod?
I was actually writing a comment, when I received this on my email ;) Let me
explain my poin
Changes by Yury Selivanov :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue20711>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20694>
___
___
Python-bugs-list
Yury Selivanov added the comment:
Last bit of documentation from me.
I, personally, don't have any more changes in mind, so this one is probably the
last from me on the asyncio front in this thread.
changeset: 89312:ec3a70ef759d
tag: tip
user: Yury Selivanov
date:
Yury Selivanov added the comment:
> I think that's a bad API, it should be agnostic about the implementation
> language.
Agree.
Re #20711: Please take a look at the patch I wrote. It's your code I modified,
you know it and the __text_signature__ quirks be
Yury Selivanov added the comment:
Updated patch. The entire test suite pass.
--
Added file: http://bugs.python.org/file34169/sig_bound_02.patch
___
Python tracker
<http://bugs.python.org/issue20
Yury Selivanov added the comment:
Thanks Larry!
> I bet you want this cherry-picked
Very much so! I'll create a new issue.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.pyth
New submission from Yury Selivanov:
Larry, please consider cherry-picking 2000c27ebe80.
Another bug in newly renovated 'inspect.getfullargspec()', this time with
module-level builtins. Would be great if it supports them well in 3.4.
changeset: 89314:2000c27ebe80
tag:
Changes by Yury Selivanov :
--
keywords: -3.4regression
___
Python tracker
<http://bugs.python.org/issue20715>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Looks good to me. Those unit tests give some confidence ;)
--
___
Python tracker
<http://bugs.python.org/issue20710>
___
___
Yury Selivanov added the comment:
With this patch 'help' now correctly renders classmethods, yay
--
___
Python tracker
<http://bugs.python.org/issue20710>
___
__
Yury Selivanov added the comment:
Stefan,
I committed one more fix in signature -- now cython
functions should be finally supported.
I'm not sure if Larry accepts this in 3.4.0 though,
but I'll create an issue for that.
--
___
Python trac
New submission from Yury Selivanov:
Another tweak in signature. Fixes #17159 once and for all (and will save Stefan
from adding ugly hacks in Cython).
I'm not sure if it is a release blocker or can wait till 3.4.1; all I can say
is that the change is relatively simple, as it shouldn
Yury Selivanov added the comment:
I'm closing this issue. Please do not reopen it, and create a new one if
necessary.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
New submission from Yury Selivanov:
There is no reason for Signature objects to be not picklable.
Patch is attached (it will require merging #19573 before).
--
assignee: yselivanov
files: sig_picklable_01.patch
keywords: patch
messages: 211903
nosy: larry, ncoghlan, yselivanov
priority
Yury Selivanov added the comment:
Thanks, Larry!
--
___
Python tracker
<http://bugs.python.org/issue20724>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
> For extra points, you could test with all protocol versions (from 0 to
> HIGHEST_PROTOCOL).
Good idea, see the second patch.
--
Added file: http://bugs.python.org/file34186/sig_picklable_02.patch
___
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20739>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
Added file: http://bugs.python.org/file34217/sig_picklable_03.patch
___
Python tracker
<http://bugs.python.org/issue20726>
___
___
Python-bug
Yury Selivanov added the comment:
Fixed in 19674. Closing this one.
--
nosy: +yselivanov
resolution: -> out of date
status: open -> closed
superseder: -> Add introspection information for builtins
___
Python tracker
<http://bug
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue19903>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
assignee: -> yselivanov
___
Python tracker
<http://bugs.python.org/issue17373>
___
___
Python-bugs-list mailing list
Unsubscrib
Yury Selivanov added the comment:
Is this still an issue?
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue14367>
___
___
Python-bugs-list m
Changes by Yury Selivanov :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue20763>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20763>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue20765>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +larry, ncoghlan, yselivanov
___
Python tracker
<http://bugs.python.org/issue20786>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
Larry, I think the problem is that
>>> property.__delete__.__text_signature__
'(instance, /)'
but should be something like '($self, instance, /)'.
What do you think?
--
Changes by Yury Selivanov :
--
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issue20786>
___
___
Python-bugs-list mai
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20791>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Larry, Nick, what do you think?
I'd like this to be fixed in 3.4.0...
--
___
Python tracker
<http://bugs.python.org/is
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20807>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
assignee: -> yselivanov
nosy: +larry, ncoghlan, yselivanov
___
Python tracker
<http://bugs.python.org/issue20817>
___
___
Py
Changes by Yury Selivanov :
--
assignee: -> yselivanov
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue20816>
___
___
Python-bugs-list mai
Yury Selivanov added the comment:
Why are you trying to get signature of 'datetime.datetime.today.__call__'?
__call__ in this case is a generic python object -- method-wrapper. It is used
to make a classmethod. And the signature that getargspec is returning for it is
correct.
-
Changes by Yury Selivanov :
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue20828>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20786>
___
___
Python-bugs-list
New submission from Yury Selivanov:
http://hg.python.org/cpython/rev/c9861ec8754c
changeset: 89461:c9861ec8754c
user:Yury Selivanov
date:Sun Mar 02 12:25:27 2014 -0500
summary:
Issue #20786: Fix signatures for dict.__delitem__ and property.__delete__
--
assignee
Yury Selivanov added the comment:
Mike, this is now fixed. I've created an issue for tracking of getting this fix
in 3.4.0: #20829.
Thanks for finding this bug!
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
OK, I see.
I'd recommend you to take a look how inspect.signature is implemented in 3.3 or
3.4 (and maybe backport it to python 2 and use the new API).
To quickly fix your code, I'd suggest the following modifications:
_WrapperDescriptor = type(typ
Yury Selivanov added the comment:
Can we instead re-engineer asyncio logging to have logger calls in a separate
thread?
I.e. `logger` is a proxy object, that puts logging calls in a queue, and there
would be another thread to block on the queue and do the actual logging. This
way it won&#
Yury Selivanov added the comment:
> If you really need network logging you should be able to configure a handler
> that puts things in a queue whose other end is serviced by an asyncio task.
> There should be no need to mess with the type of the logger object.
It's something t
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue20855>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue13936>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Larry, so do you think we can have this one cherry-picked?
--
___
Python tracker
<http://bugs.python.org/issue20829>
___
___
Changes by Yury Selivanov :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue20894>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue28782>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Wow, Martin, this is a very interesting one. Thanks so much for tracking this
down and reducing the test case.
So far this doesn't seem to be related to async/await: the interpreter stack
seems to enter some strange state under some conditions, and
Yury Selivanov added the comment:
> f_lasti being -2 has always been my preference, lasti.patch lgtm
How about we commit pygen_yf.patch to 3.6 and whatever else in 3.7?
lasti.patch is too invasive for 3.6 at this point, -1 for it in
Yury Selivanov added the comment:
LGTM
--
___
Python tracker
<http://bugs.python.org/issue28782>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Nick, your patch LGTM. I'd only add to the getargspec section that
getfullargspec is usually a drop-in replacement (I've yet to see code where
it's not the case).
--
___
Python tracker
<http
Yury Selivanov added the comment:
While I don't think that merging more than 256 dicts is a common task, the code
does become much simpler. LGTM.
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
-1; we have too many opcodes already. Let's not complicate the code if there's
no performance improvement.
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.o
New submission from Yury Selivanov:
Right now, Python 3.6b4 happily accepts the following:
>>> f'{10:02\N{LATIN CAPITAL LETTER X}}'
'0A'
>>> f'{10:02X}'
'0A'
I think that the first line should not be accepted (as we n
Yury Selivanov added the comment:
Also this inconsistency: we already don't accept escaped letters after `!`:
>>> f'{min!\N{LATIN SMALL LETTER R}}'
File "", line 1
SyntaxError: f-string: invalid conversion c
1901 - 2000 of 3098 matches
Mail list logo
