Yury Selivanov added the comment:
New patch - pep362.8.patch
One big change (Guido's request) - No more AttributeErrors on missing
Parameter.default of Signature.return_annotation. They now will be set to
Parameter.empty & Signature.empty correspondingly.
--
Added f
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15008>
___
___
Python-bugs-list
New submission from Yury Selivanov :
With this patch 'contextlib.ExitStack.callback(callback, *args, **kwds)' will
validate that the passed callback actually accept the passed '*args' and
'**kwds'.
P.S. If this patch comes through - I'll create two mor
Yury Selivanov added the comment:
Éric, yes, please close it.
--
nosy: +Yury.Selivanov
___
Python tracker
<http://bugs.python.org/issue8916>
___
___
Python-bug
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue15185>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
(my previous message edit: no support for 'atexit' - it's implemented in C)
--
___
Python tracker
<http://bugs.pyt
Yury Selivanov added the comment:
Larry, Brett,
I compiled the documentation from the PEP (attached as inspect.pep362.1.patch).
Please take a look and feel free to add/edit.
--
keywords: +patch
Added file: http://bugs.python.org/file26410/inspect.pep362.1.patch
Changes by Yury Selivanov :
--
nosy: -Yury.Selivanov
___
Python tracker
<http://bugs.python.org/issue15151>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
The new patch version (inspect.pep362.2.patch) includes more examples and
includes recommendations to use the Signature Object instead of
'inspect.getfullargsspec'. Please review.
--
Added file: http://bugs.python.org/file26419/inspec
Yury Selivanov added the comment:
New patch version - inspect.pep362.3.patch
I decided to put the new doc section above the "Classes and functions". The new
section is now called "Introspecting callables with Signature Object". Aside
from that everything is the same
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue15397>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue11816>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Benjamin: http://bugs.python.org/issue15151
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue15008>
___
___
Yury Selivanov added the comment:
Thanks a lot for the patch update, Andrew! Please let me glance over it once
again today/tomorrow before you commit it.
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue15627>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Thank you, Andrew.
One thing: can you please change:
> Print all keyword-only arguments without default values:
to
> Example: print all keyword-only arguments without default values:
?
--
___
Python t
Yury Selivanov added the comment:
Can you close this one? It's already merged.
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
I'll open another issue and will attach a patch.
--
___
Python tracker
<http://bugs.python.org/issue14167>
___
___
Pytho
Yury Selivanov added the comment:
OK.
Attaching the patch. Please review.
--
Added file: http://bugs.python.org/file27280/finally_doc_patch.patch
___
Python tracker
<http://bugs.python.org/issue14
Yury Selivanov added the comment:
see the issue 14167
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue16028>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
thanks!
--
___
Python tracker
<http://bugs.python.org/issue14167>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
I don't know why, but it seems that the bug reappeared in 3.3.
Examples:
1. --- (python 3.4 from repo)
yury@sxair ~/dev/py/python (master) $ ./python.exe
Python 3.4.0a0 (default, Oct 5 2012, 15:08:35)
[GCC 4.2.1 Compatible Apple Clan
Yury Selivanov added the comment:
Brett, can we patch 3.3 too? (in 3.3.1 version?)
--
___
Python tracker
<http://bugs.python.org/issue15111>
___
___
Python-bug
New submission from Yury Selivanov:
This patch adds a dropdown to python documentation top toolbar:
https://dl.dropbox.com/u/21052/python/p3_doc_dd.png
This patch version is for python 3.3 & 3.4 docs theme, but I can quickly make
patches for 3.2-style and below.
JavaScript that moni
Changes by Yury Selivanov :
--
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue16331>
___
___
Python-bugs-list mailing list
Unsubscri
Yury Selivanov added the comment:
> What happens if the module doesn't exist in a previous version or if it has a
> different name?
As I said in the first message:
"""
2) Before making a redirect, is checks that the doc page exists for the
selected python version,
Yury Selivanov added the comment:
> 1) mapping new/renamed/delete files between versions;
I think that this dropdown is mostly like to be used to switch between somewhat
recent python versions, like '3.2' -> '3.3', '2.7' -> '3.3', and not betwee
Yury Selivanov added the comment:
> I mostly want to switch between 2.x and 3.x, and several modules got renamed
> between these versions. There are also new modules on each release (5 new
> ones in 3.3).
To make that work we'll need to have a modules mapping between 2nd and
Yury Selivanov added the comment:
Eric,
I'm not sure what we should do with #8040. I searched for the existing issue
before creating a new one, but obviously failed. Should we just close #8040
and point it to #16331?
--
___
Python tracker
Yury Selivanov added the comment:
Eric, Ezio,
This one has a patch attached with a relevant discussion & review, so I'd close
#8040.
But if you guys decide to close this one and switch to #8040 - i'm fine.
--
___
Python
Yury Selivanov added the comment:
Eric, Ezio,
I'd like to make the version dropdown to be configurable. The question is--I
can add an option (set to False by default) to conf.py. Will you have a way to
override it on the 'docs.python.org'?
--
no
Yury Selivanov added the comment:
> If the issue with patch is closed as duplicate, the patch should be attached
> to the superseder.
Attached now. Although, please don't use it. I'll upload an updated version
soon.
> The patch looks awfully long for such a simpl
Yury Selivanov added the comment:
Attaching a new patch, with all previous issues resolved.
Version dropdown can be enabled by the new 'pydoc_versionswitcher' config
property (False by default).
Please review and test (I've done lots of testing by injecting the JS on live
p
Yury Selivanov added the comment:
Adding 'py2_version_switch.patch' patch. Applies on 2.7
--
Added file: http://bugs.python.org/file27738/py2_version_switch.patch
___
Python tracker
<http://bugs.python.
Changes by Yury Selivanov :
Added file: http://bugs.python.org/file27739/py3_2_version_switch.patch
___
Python tracker
<http://bugs.python.org/issue8040>
___
___
Pytho
Yury Selivanov added the comment:
Adding 'py3_2_version_switch.patch'. Applies on 3.2
Both patches (for 2.7 & 3.2) are almost the same as the original patch.
Conflicts were trivial.
--
___
Python tracker
<http://bugs.pyt
Yury Selivanov added the comment:
And 'py3_version_switch.2.patch' is for 3.3/master.
--
___
Python tracker
<http://bugs.python.org/issue8040>
___
___
Changes by Yury Selivanov :
--
versions: +Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue8040>
___
___
Python-bugs-list mailing list
Unsub
Yury Selivanov added the comment:
Found a bug: documentation pages have two toolbars - top and bottom, and as I
hadn't noticed the latter, I used a placeholder with #id. This is now fixed.
I'm attaching a new version of patch: 'py3_version_switch.3.patch'.
I also have upd
Yury Selivanov added the comment:
> Attaching a simplified version of the patch.
I'm OK, but you actually reduced the functionality with saving those 500 bytes.
In 'py3_version_switch.3.patch', JS sets the current selected option text to
show the the *full* release number.
Yury Selivanov added the comment:
Georg,
Are you sure you've attached the right one? I don't see a change in the
version_switch.js...
--
___
Python tracker
<http://bugs.python.
Yury Selivanov added the comment:
Looks good, let's commit it? ;)
--
___
Python tracker
<http://bugs.python.org/issue8040>
___
___
Python-bugs-list m
Yury Selivanov added the comment:
Maybe it's a good idea to modify `url_re` from
/\.org\/(py3k|dev|((release\/)?\d\.\d[\w\d\.]*))\//
to
/\.org\/(\d|py3k|dev|((release\/)?\d\.\d[\w\d\.]*))\//
To be prepared for PEP 430.
--
___
Python tr
Yury Selivanov added the comment:
Ezio,
Georg's modification introduced one more bug:
1. Documentation for py2 seems to be missing DOCUMENTATION_OPTIONS.RELEASE
2. DOCUMENTATION_OPTIONS.VERSION is in a wrong format for the rest of the
script, i.e. 3.3.0 and not 3.3. Before, in my ve
Yury Selivanov added the comment:
I think we should also apply patch for 2.6, right?
--
___
Python tracker
<http://bugs.python.org/issue8040>
___
___
Python-bug
Yury Selivanov added the comment:
And last bit - are you sure we shouldn't add the switch for 2.5?
--
___
Python tracker
<http://bugs.python.org/i
Yury Selivanov added the comment:
And if you guys can - please re-run the docs generation script manually... As
it's showing an incorrect version everywhere.
Thanks!
--
___
Python tracker
<http://bugs.python.org/i
Yury Selivanov added the comment:
It seems that the docs site has old jquery - 1.4, and current JS script uses
$.get, which got support for 'error' callbacks only in 1.5
So right now, if a URL doesn't exist for the version the user is about to
switch to, it just fails with a
Yury Selivanov added the comment:
(I'd fix it myself if I could ;)
--
___
Python tracker
<http://bugs.python.org/issue8040>
___
___
Python-bugs-list m
Changes by Yury Selivanov :
--
nosy: +vinay.sajip, yselivanov
___
Python tracker
<http://bugs.python.org/issue20918>
___
___
Python-bugs-list mailing list
Unsub
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue18931>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Why there is no 'review' link for the new patch?
--
___
Python tracker
<http://bugs.python.org/issue18931>
___
___
Yury Selivanov added the comment:
Still no review link. Somehow you managed to upload the first patch correctly.
Does the new one apply cleanly on the default branch?
--
___
Python tracker
<http://bugs.python.org/issue18
Changes by Yury Selivanov :
--
nosy: -yselivanov
___
Python tracker
<http://bugs.python.org/issue20739>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
If nobody has any objections on this, I'm going to commit this in 3.5 soon.
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
Guido, good idea. Committed.
--
___
Python tracker
<http://bugs.python.org/issue20668>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
Fixed for 3.4.1 and 3.5.
Thank you Jeremiah!
--
___
Python tracker
<http://bugs.python.org/issue20816>
___
___
Python-bugs-list m
Yury Selivanov added the comment:
Fixed for 3.4.1 and 3.5.
Thanks for the contribution!
--
___
Python tracker
<http://bugs.python.org/issue20817>
___
___
Pytho
Yury Selivanov added the comment:
So... should we expose two keyword only parameters for
Signature.from_callable() and signature():
- 'follow_wrapped=True' to follow __wrapped__ chains;
- 'keep_bound_arg=False' to skip/inc
New submission from Yury Selivanov:
There is a small detail in the current Signature class implementation, in
regards to how partial signatures are treated. Consider the following example:
def foo(a, b): pass
foo_partial = functools.partial(foo, 'spam')
Now, the si
Yury Selivanov added the comment:
@Nick:
> Oops: already bound positional-*only* arguments should be hidden.
Hm, good catch. I'm not sure we currently do this. I'll check if this needs to
be fixed (in 3.4.1 too).
> I'm +0 on new types to clean that up if necessary, but
Yury Selivanov added the comment:
@Nick:
Agreed on positional-only stuff.
> If arguments bound by position disappear from the signature, and those
> bound by keyword are mapped to keyword-only parameters with a default, we
> should get a valid and accurate signature.
But what about m
Yury Selivanov added the comment:
@Nick: oh, it took me some time to realize that your suggestion to transform
positional-or-keyword to keyword-only parameters is correct. If we do this, we
no longer need '_partial_kwarg' hack. I'll work on the p
Yury Selivanov added the comment:
@Nick:
Ouch... I'm halfway through the implementation, and it seems like your idea
isn't going to work.
Example (from unittest):
def foo(a=1, b=2, c=3): pass
_foo = partial(foo, a=10, c=13)
Now, the signature for "_foo", wit
Yury Selivanov added the comment:
@R. David:
Yes, thank you, David. Too bad I haven't seen your last messages before I
started working on the patch...
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
> First, I think this is a bug in partial, so I think we need to decide what,
> if anything, to do about that first, before we decide if signature needs to
> compensate for it or not.
Agree. Although, it looks like it's not something that partia
Yury Selivanov added the comment:
> Although, it looks like it's not something that partial is doing, it seems
> like this call logic is implemented somewhere way deeper.
Forget about what I said.
Yes, it's a "bug" in partial. Fixing it, will require having the
Yury Selivanov added the comment:
> Oh, wait, it *does* have a usable signature. It's just that all the
> *subsequent* positional-or-keyword parameters also have to be marked as
> keyword-only.
Interesting idea. I'll incorporate this l
Yury Selivanov added the comment:
Please review the attached patch.
Here's the new partial signature semantics:
foo(a, b, /, c, d, *args, e)
partial(foo, 10) -> (b, /, c, d, *args, e)
partial(foo, 10, c=11) -> (b, /, *, c=11, d, e)
partial(foo, 10, 20, 30) ->
Yury Selivanov added the comment:
Any comments on the patch?
--
___
Python tracker
<http://bugs.python.org/issue21117>
___
___
Python-bugs-list mailing list
Unsub
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue21117>
___
___
Python-bugs-list
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20334>
___
___
Python-bugs-list
Yury Selivanov added the comment:
Hm... Can we also commit this to 3.3?
--
___
Python tracker
<http://bugs.python.org/issue21209>
___
___
Python-bugs-list mailin
Yury Selivanov added the comment:
> 3.3 is in security-fix only mode.
Yeah, but this is a core language bug. I believe some people may be stuck on
3.3 with broken 'yield from' for whatever reason, which will cause hard to find
bugs in 3.3 compatible libraries (like asyncio/tulip)
Yury Selivanov added the comment:
Guido: please take a look at the patch "corowrapper_01.patch".
--
Added file: http://bugs.python.org/file34832/corowrapper_01.patch
___
Python tracker
<http://bugs.python.o
Changes by Yury Selivanov :
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue21209>
___
___
Python-bugs-list
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue21217>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
Please see the corowrapper_02.patch. I've removed the version check, now it's
much simpler.
--
Added file: http://bugs.python.org/file34850/corowrapper_02.patch
___
Python tracker
<http://bugs.python.o
Yury Selivanov added the comment:
I don't like this idea. inspect module is about introspection, and not about
interpreting its results. I'd keep this function in pydoc and document it if
there is noticeable demand for it.
--
___
Pyth
Yury Selivanov added the comment:
> [...] CoroWrapper.send() signature is different from a real generator's
> send() method, but I think that send() to a coroutine is an internal detail
> anyway [...]
Yeah, and since it's used in debug mode only, I think we should be safe.
Changes by Yury Selivanov :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue21209>
___
___
Python-bugs-list
Yury Selivanov added the comment:
Guido, I'm feeling a bit uncomfortable with the patch I pushed. I think we
should adjust the solution, to avoid having arguments to 'gen.send' packed in
two nested tuples. Please take a look at the new patch (corowrapper_03.patch).
It adds
Changes by Yury Selivanov :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue21235>
___
___
Python-bugs-list mailing list
Unsubscribe:
Yury Selivanov added the comment:
How about we deprecate with a warning getfullargspec(); deprecate getargspec()
in docs only (in 3.6 we'll fully deprecate all function parameters API except
Signature)?
--
___
Python tracker
Yury Selivanov added the comment:
> I should check, but I think that Python create a tuple for you if you don't
> pass directly a tuple, so it's not very different.
That's what I thought, but still, better to have the code clearly expressing
what it does, th
Yury Selivanov added the comment:
I'd +1 for:
1. Deprecating getfullargsspec in docs;
2. Deprecating getargspec in docs and code (since it's an ancient and outdated
API)
Brett?
--
___
Python tracker
<http://bugs.python.o
Yury Selivanov added the comment:
Apart from one nit, the patch is looking good.
Also, could you please sign the contributor agreement, as described here:
https://docs.python.org/devguide/coredev.html#sign-a-contributor-agreement
--
___
Python
Changes by Yury Selivanov :
--
assignee: -> yselivanov
___
Python tracker
<http://bugs.python.org/issue1764286>
___
___
Python-bugs-list mailing list
Un
Yury Selivanov added the comment:
Claudiu: I'll take a look at your patch, thanks!
--
___
Python tracker
<http://bugs.python.org/issue21217>
___
___
Pytho
Yury Selivanov added the comment:
David:
> The precedent has already been set by the 'cleandoc' function, I think. This
> one seems to go right along with that one.
What do you think if we keep the function in pydoc module, but document it and
make it public? I agree,
Changes by Yury Selivanov :
--
nosy: +vinay.sajip, yselivanov
___
Python tracker
<http://bugs.python.org/issue21245>
___
___
Python-bugs-list mailing list
Unsub
Yury Selivanov added the comment:
Nick, good catch. OK, let's just deprecate it in the docs for 3.5, so people
(hopefully) will not write new code with it.
--
___
Python tracker
<http://bugs.python.org/is
Yury Selivanov added the comment:
I had plans to copy some documentation from python docs to asyncio docstrings.
I'll try to do this sometime this week. Thanks for reminding us about the issue!
--
assignee: -> yselivanov
nosy: +gvanrossum, haypo, ys
Yury Selivanov added the comment:
> My bad. But I think docstrings should NOT be just copies of the separate
docs.
I agree. I didn't want to blindly copy them, but rather use existing
documentation as guidance & baseline.
--
___
Py
Yury Selivanov added the comment:
OK, since it's two-and-a-half votes against one, let's do this. I'll do the
final review of the patch and commit it.
--
___
Python tracker
<http://bugs.pyt
Yury Selivanov added the comment:
The current patch proposes to add inspect.splitdoc(obj), instead of
pydoc.splitdoc(doc). The former takes an object, extracts documentation out of
it, and returns a tuple. The latter, just splits the passed doc string.
If you want this function in inspect
Yury Selivanov added the comment:
> In the inspect module, I think all the functions take a object and not a
string, it's the reason why I included the code of pydoc.getdoc() into
inspect.splitdoc().
I understand. But you also do inspect.getdoc or inspect.getcomments, which I
don&
Yury Selivanov added the comment:
> Are you agree with that, or there is a good way for this kind of
improvement?
Having a unittest to check if a deprecated functionality is removed in the
future versions was Brett's idea, and I like it. So I think it's good to do the
same here.
Yury Selivanov added the comment:
I'd keep the name ("splitdoc"), and let it receive a string. But let's hear
what Eric & David think about it.
--
___
Python tracker
<http:/
Changes by Yury Selivanov :
--
nosy: +yselivanov
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue21288>
___
___
Python-bug
1501 - 1600 of 3135 matches
Mail list logo
