Xiang Zhang added the comment:
New changeset 95b4da2be4aeb74ee46ddece71f2075b32915c60 by Xiang Zhang in branch
'3.6':
bpo-30378: Fix the problem that SysLogHandler can't handle IPv6 addresses
(#1676) (#1903)
https://github.com/python/cpython/commit/95b4da2be4aeb74ee46ddece7
Xiang Zhang added the comment:
New changeset 3ef3bcbe38e1913119c3022ca470d06908eeda3c by Xiang Zhang in branch
'2.7':
bpo-30378: Fix the problem that SysLogHandler can't handle IPv6 addresses
(#1904) (#1676)
https://github.com/python/cpython/commit/3ef3bcbe38e1913119c3022ca
Xiang Zhang added the comment:
Thanks calcheng for your report and Vinay for the review.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.6, Python 3.7
___
Python tracker
<http://bug
Xiang Zhang added the comment:
Hi Jiri, thanks for your PR. But at least we need a corresponding test and an
entry in Misc/NEWS to complete the patch. Also, if your name is not in
Misc/ACKS, please add it. :-)
--
nosy: +xiang.zhang
___
Python
Xiang Zhang added the comment:
New changeset aead53b6ee27915de248b07de509529174aaad21 by Xiang Zhang (Johan
Liu) in branch 'master':
bpo-30245: Fix possible overflow when organize struct.pack_into error message
(#1682)
https://github.com/python/cpyt
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xiang Zhang added the comment:
Looking at the code and the previous issue #22928, CRLF immediately followed by
a tab or space (obs-fold: CRLF 1*( SP / HTAB )) is a valid part of a header
value so the regex deliberately ignore them.
So it looks right to me the url given doesn't raise the
Xiang Zhang added the comment:
Actually the docs says "This attribute is available when using the buffered I/O
classes from the io module", which means it's not always available since it
depends on an inner field set or not.
It's just like Python code:
>>> class
Xiang Zhang added the comment:
Looking at the code and doc it seems it's by design. But it's good or not
remains in question. The related discussion about the more general problem
behind this issue is
https://groups.google.com/d/msg/python-ideas/Kou5cYGjGQ8/oXEixwgiDwAJ. T
Xiang Zhang added the comment:
We have moved our code hosting to GitHub, would you mind turn your patch into a
GitHub PR first Wonsup?
--
___
Python tracker
<http://bugs.python.org/issue29
Xiang Zhang added the comment:
The problem is utf16 decoder almost always assumes that two bytes decodes to
one unicode character, so when allocating memory, it assumes (bytes_number+1)/2
unicode slots is enough, there is even a comment in the code. And in
Change by Xiang Zhang :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue32583>
___
___
Python-bugs-list mailing list
Un
Xiang Zhang added the comment:
Another way to crash:
>>> import codecs
>>> def replace_with_longer(exc):
... exc.object = b'\xa0\x00' * 100
... return ('\ufffd', exc.end)
...
>>> codecs.register
codecs.register( c
Xiang Zhang added the comment:
I write a draft patch, without tests yet. I'll add them later. Reviews are
appreciated. I also check the Windows codepage equivalent and encoders, look to
me they don't suffer the problem.
--
keywords: +patch
stage: needs patch -> patch
Xiang Zhang added the comment:
Hi Pablo, it would be nice. But for #17799, I don't know actually which part
should be fixed, doc or code? I think it's better to consult gurus on
python-dev mail list.
--
___
Python tracker
<https://bu
Xiang Zhang added the comment:
Hi Guido. Looking at the implementation, it seems pdb ignores c_call not by
relying on the interpreter, but bdb takes no action when encountering C events.
Yeah, even bdb wrongly expects C events will be triggered for settrace. [1]
And what if some debuggers
New submission from Xiang Zhang :
test_codeccallbacks.test_mutatingdecodehandler is introduced in
e78178e2c05ec2bb628b70a8b5422bb4dae63343. Obviously it should test against both
test.replacing and test.mutating but it tests test.replacing twice.
--
components: Tests
keywords: easy
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5112
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32618>
___
___
Python-
Xiang Zhang added the comment:
New changeset 370d04d1dcca50a52d59f40aff4d11434f71df6b by Xiang Zhang in branch
'master':
bpo-32618: Fix test_mutatingdecodehandler not testing test.mutating (#5269)
https://github.com/python/cpython/commit/370d04d1dcca50a52d59f40aff4d11
Xiang Zhang added the comment:
New changeset 6abbf14a876ee1e04d1493bb27025f2f0aa56430 by Xiang Zhang (Miss
Islington (bot)) in branch '3.6':
bpo-32618: Fix test_mutatingdecodehandler not testing test.mutating (GH-5269)
(#5285)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 131fd7f96c619bc7eaea956e45c6337175f4b27f by Xiang Zhang (Pablo
Galindo) in branch 'master':
bpo-17799: Explain real behaviour of sys.settrace and sys.setprofile (#4056)
https://github.com/python/cpyt
New submission from Xiang Zhang :
As the title, the new PyTrace_OPCODE event is not documented in C API doc yet.
--
assignee: docs@python
components: Documentation
messages: 310588
nosy: docs@python, ncoghlan, pablogsal, xiang.zhang
priority: normal
severity: normal
status: open
title
Change by Xiang Zhang :
--
pull_requests: +5145
___
Python tracker
<https://bugs.python.org/issue17799>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
pull_requests: +5146
___
Python tracker
<https://bugs.python.org/issue17799>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset fd844efa9c31e1f00e04b07940875b9dacff3d77 by Xiang Zhang in branch
'3.6':
bpo-17799: Explain real behaviour of sys.settrace and sys.setprofile (GH-4056)
(#5298)
https://github.com/python/cpython/commit/fd844efa9c31e1f00e04b07940875b
Xiang Zhang added the comment:
New changeset e64a47b37d0c592fd162b2f51e79ecfd046b45ec by Xiang Zhang in branch
'2.7':
bpo-17799: Explain real behaviour of sys.settrace and sys.setprofile (GH-4056).
(#5299)
https://github.com/python/cpython/commit/e64a47b37d0c592fd162b2f51e79ec
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
pull_requests: +5170
___
Python tracker
<https://bugs.python.org/issue32583>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
type: -> behavior
versions: +Python 3.7 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue27931>
___
___
Python-bugs-lis
New submission from Xiang Zhang :
Ordered builtin dict is the rule in 3.7, the tutorial part about dict[1] needs
updating.
[1] https://docs.python.org/3.7/tutorial/datastructures.html#dictionaries
--
assignee: docs@python
components: Documentation
messages: 310737
nosy: docs@python
Xiang Zhang added the comment:
Thanks for reminding, Martin.
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> Dict order is now guaranteed, so add tests and doc for it
___
Python tra
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5204
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset 60da99b8e2f7bf497569ae4d6c218866575729bf by Xiang Zhang in branch
'master':
bpo-32532: Improve documentation of settrace and setprofile (#5359)
https://github.com/python/cpython/commit/60da99b8e2f7bf497569ae4d6c2188
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5205
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32649>
___
___
Python-
New submission from Xiang Zhang :
The meaning of arg for PyTrace_Line and PyTrace_CALL is wrong, it is not always
NULL but always Py_None.
--
assignee: docs@python
components: Documentation
messages: 310865
nosy: docs@python, xiang.zhang
priority: normal
severity: normal
status: open
New submission from Xiang Zhang :
I find one line[1] is weirdly commented out. But I don't think profile here is
any different with trace. In 2.7, this line is not commented out and the change
happens in b94767ff, fixing clang warnings.
--
messages: 310866
nosy: brett.c
Xiang Zhang added the comment:
Sorry, forget links, it's
https://github.com/python/cpython/blob/master/Python/ceval.c#L3528 , and the
commit is b94767ff44edf5d461d7cb1c8eb5160f83886358.
--
___
Python tracker
<https://bugs.python.org/is
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5206
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32687>
___
___
Python-
Xiang Zhang added the comment:
New changeset 9ed0aee27c249dada410a22fff4325a4a61df36d by Xiang Zhang in branch
'master':
bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation
(#5361)
https://github.com/python/cpython/commit/9ed0aee27c249dada410a22fff4325
Xiang Zhang added the comment:
New changeset 854f0424de389f023b375dfd0b50c34dea29e8f8 by Xiang Zhang (Miss
Islington (bot)) in branch '3.6':
bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation
(GH-5361) (GH-5377)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 745e9de7dd9d237d54e92d6e4b469e916fb0352b by Xiang Zhang (Miss
Islington (bot)) in branch '2.7':
bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation
(GH-5361) (GH-5378)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Xiang Zhang :
test_threading.test_set_and_clear fails in AppVeyor CI. But seems it not stable
since rerun succeeds. See
https://ci.appveyor.com/project/python/cpython/build/3.6build11314/job/ussor83yaglx5whb.
FAIL: test_set_and_clear (test.test_threading.EventTests
Xiang Zhang added the comment:
Ahh, I figure out that the line is useless and can't affect any logic then. So
the analyzer is right! Sorry for the bother Brett.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
Change by Xiang Zhang :
--
pull_requests: +5238
___
Python tracker
<https://bugs.python.org/issue32688>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Done.
--
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue32688>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
New changeset 997478eb797b31bd724135ca17781d1cf4b89cfa by Xiang Zhang in branch
'master':
bpo-32688: Make why the line is commented out clear (GH-5405)
https://github.com/python/cpython/commit/997478eb797b31bd724135ca17781d
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Xiang Zhang :
A simple snippet:
import threading
def func():
while True:
print(1,2,3,4,5,6,7,8,9,10)
t1 = threading.Thread(target=func)
t2 = threading.Thread(target=func)
t1.start()
t2.start()
Running this snippet and Ctrl-C raises FatalError
Xiang Zhang added the comment:
It's 3.6 and 3.7. The dir name in traceback doesn't matter.
--
___
Python tracker
<https://bugs.python.org/issue32719>
___
__
New submission from Xiang Zhang :
>>> import codecs
>>> f = codecs.open('/tmp/a', 'w', errors='replace')
>>> f.errors
'strict'
Passing errors to codecs.open without encoding doesn't work. Can't get th
Change by Xiang Zhang :
--
title: codecs.open -> codecs.open silently ignores argument errors
type: -> behavior
___
Python tracker
<https://bugs.python.org/i
Xiang Zhang added the comment:
I don't understand Josh. Looking from the code only when *passing* encoding
binary mode is forced, although in the comment it's saying always.
>>> f = codecs.open('/tmp/a', 'w')
>>> f
For example I want to use &#
Xiang Zhang added the comment:
New changeset 2c7fd46e11333ef5e5cce34212f7d087694f3658 by Xiang Zhang in branch
'master':
bpo-32583: Fix possible crashing in builtin Unicode decoders (#5325)
https://github.com/python/cpython/commit/2c7fd46e11333ef5e5cce34212f7d0
Change by Xiang Zhang :
--
pull_requests: +5285
___
Python tracker
<https://bugs.python.org/issue32583>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset ea94fce6960d90fffeeda131e31024617912d231 by Xiang Zhang in branch
'3.6':
[3.6] bpo-32583: Fix possible crashing in builtin Unicode decoders (GH-5325)
(#5459)
https://github.com/python/cpython/commit/ea94fce6960d90fffeeda131e31024
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
Honestly speaking I am not interested in Python3. I think codecs.open will be
deprecated one day in Python3 and Victor has raised it long ago. See #8796.
And in Python2, codecs.open is still in use. errors could still function when
you are writing, encoding
Xiang Zhang added the comment:
New changeset ab328756d7fd969ee4882458b07892dff135013c by Xiang Zhang (Stéphane
Wirtel) in branch 'master':
bpo-32722: Remove useless example in the Classes tutorial (#5446)
https://github.com/python/cpython/commit/ab328756d7fd969ee4882458b07892
Xiang Zhang added the comment:
I treat it as an enhancement so only merge it into 3.8. Thanks Soothsayer for
the report and Stéphane for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.4, Python 3.
Xiang Zhang added the comment:
This part needs editing too, the text and example.
https://docs.python.org/3/library/stdtypes.html#dictionary-view-objects
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue32
Xiang Zhang added the comment:
In my mind I don't think here is any problem. The code
val = PyBytes_FromStringAndSize (NULL, 20);
Py_SIZE(val) = 0;
doesn't create a zero length bytes object. A resizing I think should always
means reorganizing the internal representation, includin
Xiang Zhang added the comment:
Nice. The only question I have is this is a bugfix or enhancement? Current code
seems won't cause any problem but just allocates more memory than needed.
--
stage: patch review -> commit review
___
Python
Xiang Zhang added the comment:
One thing to note is the behaviour seems fit implementation detail. POSIX
doesn't requires this for both mmap and msync, it's optional:
The mmap( ) function may fail if:
[EINVAL] The addr argument (if MAP_FIXED was specified) or off is not a
multi
New submission from Xiang Zhang :
New changeset 2b77a921e6a4dee236047ac8d69cf9f915916fdc by Xiang Zhang in branch
'master':
bpo-29803: remove a redandunt op and fix a comment in unicodeobject.c (#660)
https://github.com/python/cpython/commit/2b77a921e6a4dee236047ac8d69cf9
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.or
New submission from Xiang Zhang :
I see people wrongly write non-str objects in __all__ and the error message for
this case is simply a AttributeError which doesn't reveal the cause directly.
>>> from test import *
Traceback (most recent call last):
File "", line 1,
Xiang Zhang added the comment:
s/AttributeError/TypeError
--
___
Python tracker
<https://bugs.python.org/issue32932>
___
___
Python-bugs-list mailing list
Unsub
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5624
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
New submission from Xiang Zhang :
rot13 codec does a str translate operation. But it doesn't check the input type
and then the error message would be quite confusing, especially for bytes:
>>> codecs.encode(b'abc', 'rot13')
Traceback (most recent call last):
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5643
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32943>
___
___
Python-
Change by Xiang Zhang :
--
nosy: +lemburg
___
Python tracker
<https://bugs.python.org/issue32943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I would like the error message improved. The Python message is obviously much
better than the C message. It sends the cause to your eyes. Different messages
issued from similar statements are confusing. And due to the non-ideal message
is generated by C, the
New submission from Xiang Zhang :
Inspired by https://github.com/python/cpython/pull/5511, zlib module in Python
lacks some constants exposed by C zlib library, and some constants are not
documented.
--
assignee: docs@python
components: Documentation, Library (Lib)
messages: 313053
Xiang Zhang added the comment:
New changeset 3e197c7a6740d564ad52fb7901c07d5ff49460f5 by Xiang Zhang (Alexey
Izbyshev) in branch 'master':
bpo-32903: Fix a memory leak in os.chdir() on Windows (GH-5801)
https://github.com/python/cpython/commit/3e197c7a6740d564ad52fb7901c07d
Xiang Zhang added the comment:
New changeset aa40f92240adea7067c3add8e09cec09dcf24d7f by Xiang Zhang (Alexey
Izbyshev) in branch '2.7':
[2.7] bpo-32903: Fix a memory leak in os.chdir() on Windows (GH-5801). (#5947)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 6ae75d9d1221459ab18c2599e42fcc45f9f65617 by Xiang Zhang (Miss
Islington (bot)) in branch '3.7':
bpo-32903: Fix a memory leak in os.chdir() on Windows (GH-5801) (#5945)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue29890>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5755
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32969>
___
___
Python-
Change by Xiang Zhang :
--
type: enhancement ->
versions: +Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue32969>
___
___
Python-
Change by Xiang Zhang :
--
nosy: +eric.snow, vstinner, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue33005>
___
___
Python-bugs-list mailin
Xiang Zhang added the comment:
New changeset bc3f2289b9007396bfb7f986bee477b6176c1822 by Xiang Zhang in branch
'master':
bpo-32969: Expose some missing constants in zlib and fix the doc (GH-5988)
https://github.com/python/cpython/commit/bc3f2289b9007396bfb7f986bee477
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
pull_requests: +5783
___
Python tracker
<https://bugs.python.org/issue27683>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> ipaddress documentation errors
___
Python tracker
<https://bugs.python
Xiang Zhang added the comment:
Ahh, I also find some errors here in ipaddress doc and opened
https://github.com/python/cpython/pull/6021 to fix them.
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python, xiang.zhang
versions: +Python 3.7, Pyt
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +5821
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Xiang Zhang :
--
assignee: -> xiang.zhang
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue30249>
___
___
Python-
Xiang Zhang added the comment:
New changeset c10b288f345aaef66d2c844924b9a576f9ea4f8b by Xiang Zhang in branch
'master':
bpo-30249: Improve struct.unpack_from() error messages (GH-6059)
https://github.com/python/cpython/commit/c10b288f345aaef66d2c844924b9a5
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
Looks to me it's because the KeyboardInterrupt breaks
`_wait_for_thread_shutdown` and reproduces the situation in #23309. @Antonie,
do you think anything worth to improve here? Otherwise I'll take this as design.
--
nosy: +pitrou
versions: +
Xiang Zhang added the comment:
Thanks for the reminding, I already forget this. I'll do it night.
--
___
Python tracker
<https://bugs.python.org/is
Xiang Zhang added the comment:
Revising the patch, register() is fixed by feature in #32227. So I will only
fix dispatch() in 3.7 and 3.8, the whole patch to 3.6.
--
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issue27
Change by Xiang Zhang :
--
pull_requests: +5877
___
Python tracker
<https://bugs.python.org/issue27984>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
pull_requests: +5878
___
Python tracker
<https://bugs.python.org/issue27984>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
pull_requests: +5882
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32227>
___
___
Python-bugs-list mai
Xiang Zhang added the comment:
It's all right.
--
___
Python tracker
<https://bugs.python.org/issue27984>
___
___
Python-bugs-list mailing list
Unsubscr
401 - 500 of 1629 matches
Mail list logo
