Xavier de Gaye added the comment:
This new patch skips the second test when hard links fail on the platform under
test.
--
Added file: http://bugs.python.org/file46269/test_distutils_2.patch
___
Python tracker
<http://bugs.python.org/issue29
Xavier de Gaye added the comment:
can_symlink() is needed by test_posixpath and other tests, new patch.
--
Added file: http://bugs.python.org/file46271/test_distutils_3.patch
___
Python tracker
<http://bugs.python.org/issue29
Xavier de Gaye added the comment:
The changes made in issue #28174 fix the problem for the Android x86 platform
and for the armv7 platform at Android API level 24, but the problem is still
there on the armv7 platform at Android API level 21
Xavier de Gaye added the comment:
Skipping those tests on Android has already been proposed with the existing
patches in this issue.
The reason why the changes made by issue 28174 fix only partly the problem
should be understood.
--
___
Python
Xavier de Gaye added the comment:
Current status:
---
Available using the pyona build system [1]:
* Cross compilation of Python for a given Android API level and architecture
with android-ndk-r13b.
* Cross compilation of third party extension modules (currently as a patch
Xavier de Gaye added the comment:
PEP 538 [1] coerces the C locale to UTF-8 by setting the locale environment
variables (LC_ALL, LANG). The PEP has an implementation at issue 28180 as
pep538_coerce_legacy_c_locale_v3.diff, and the patch fixes test_nonascii when
run on the Android emulators
Xavier de Gaye added the comment:
pep538_coerce_legacy_c_locale_v3.diff fixes issue 28997 on Android (api 21 and
24). This issue is raised because there is an inconsistency between Python on
Android that considers the locale encoding to be always UTF-8 and GNU Readline
that does not accept
Xavier de Gaye added the comment:
> I think we should wait for the resolution of PEP 538 and of issue 28684
s/issue 28684/issue 28180/
--
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
issue #28180: sys.getfilesystemencoding() should default to utf-8
--
dependencies: +sys.getfilesystemencoding() should default to utf-8
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
With input-readline.v3.patch, test_builtin runs with success on Android api 21.
With pep538_coerce_legacy_c_locale_v4.diff that implements PEP 538 in issue
28180, and with input-readline.v3.patch modified to have 'readline_enc
Xavier de Gaye added the comment:
Please try:
make CFLAGS_NODIST=-std=gnu99
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue29267>
___
___
Pytho
Xavier de Gaye added the comment:
The rationale supporting this change is sound and the patch LGTM.
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue29
Xavier de Gaye added the comment:
> On Android, setlocale(CATEGORY, "") does not look for the locale environment
> variables (LANG, ...) but sets the 'C' locale instead
FWIW the source code of setlocale() on bionic (Android libc) is at
https://android.googlesource.co
Xavier de Gaye added the comment:
See also msg286365.
--
nosy: +xdegaye
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
I have left some comments on Rietveld after a partial code review.
IMO for reasons of repeatability and easier maintenance [1], all the tests
should be run with the pty set in a known mode, whether canonical or raw, and a
test involving pty.spawn() should
Changes by Xavier de Gaye :
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue29400>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xavier de Gaye added the comment:
> About performances: it's fine to add anything to maybe_call_line_trace(), it
> cannot impact performances when tracing is not used.
I do not agree, Python debuggers are already really really slow. They should
not have to process 'instructi
Xavier de Gaye added the comment:
> The motivation for this suggestion was that for tracers that *are* interested
> in instructions, it *might* be simpler to get two calls, one of 'line', and
> one of 'instruction'. Maybe it's a bad idea though.
Thanks
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue28833>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29180>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29181>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29184>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29185>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue29176>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue27640>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Xavier de Gaye :
--
assignee: xdegaye ->
___
Python tracker
<http://bugs.python.org/issue26855>
___
___
Python-bugs-list mailing list
Unsubscrib
Xavier de Gaye added the comment:
> This wasn't fixed because _decimal didn't build before issue26846 lands.
This is misleading, the problem went unnoticed when not linking with '-lm'
because:
* The _decimal extension module builds without any warning.
* test_decimal doe
Xavier de Gaye added the comment:
With the following module named dlsym.py, the command 'python dlsym.py log10'
produces the same successful output on linux and on Android API 21 (when
_decimal is not explicitly linked with libm.so, i.e.without changeset
b60b46ad8751):
'Th
Xavier de Gaye added the comment:
> Perhaps test_decimal should fail for CPython if _decimal can't be imported.
This is not a problem specific to _decimal, the same problem exists for
third-party extension modules, for example pyephem
(https://github.com/brandon-rhodes/pyephem/issues/
Changes by Xavier de Gaye :
--
pull_requests: +92
___
Python tracker
<http://bugs.python.org/issue20210>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xavier de Gaye added the comment:
The PR https://github.com/python/cpython/pull/132 implements the support of the
*disabled* marker in a Setup file as suggested by Martin.
--
versions: +Python 3.7 -Python 3.5
___
Python tracker
<h
Xavier de Gaye added the comment:
> I've improved the patch and submitted it as PR 159. Now on Android:
This is confusing. Android NDK r14 has not been released yet.
We do not develop CPython for platform beta releases.
Unified headers, the reason for your proposed change, are only in
Xavier de Gaye added the comment:
Closing this issue as 'later'.
Chi Hsuan Yen, I am still interested by your answers to my questions.
--
resolution: -> later
stage: -> resolved
status: open -> closed
___
Python tracker
<
Xavier de Gaye added the comment:
> For me it's good to fix things as soon as possible.
The problem here is that you are attempting to push a change through a PR
without providing the other core developers with important information. You
should at least have given a reference to iss
Xavier de Gaye added the comment:
> I'm not familiar with CPython conventions. Sorry if reopening an issue is
> impolite.
IMO asking if it's ok to reopen this issue by using the word 'impolite' is a
clear reference to the fact that Stefan had told you previously tha
Xavier de Gaye added the comment:
Please use one single PR only when the tests are focused on a single topic and
can be collected in their own class. When the tests are focused on breakpoints
for example.
--
nosy: +xdegaye
___
Python tracker
<h
Xavier de Gaye added the comment:
> CPython's support for Android targets only stable releases of the official
> NDK.
As the NDK is seeing many changes in the recent past and near future
(deprecation of the support of gcc in favor of clang, Unified Headers, nearly
all the NDK scri
Xavier de Gaye added the comment:
> Note that there is a bug in find_function() (it opens a file with default
> encoding).
Please open an issue.
--
___
Python tracker
<http://bugs.python.org/i
Xavier de Gaye added the comment:
On a 'call' trace event, the bdb dispatch_call() function returns None when
there is nothing to trace in this function (no breakpoints). With the changes
made by the patch in ceval.c, the costly maybe_call_line_trace() function is
not called on ea
Xavier de Gaye added the comment:
See also issue 24565.
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue26779>
___
___
Python-bugs-list mailin
Changes by Xavier de Gaye :
Added file:
http://bugs.python.org/file43191/test_lru_cache_threaded-x86-printf.txt
___
Python tracker
<http://bugs.python.org/issue26
Changes by Xavier de Gaye :
Added file:
http://bugs.python.org/file43192/test_lru_cache_threaded-armv7-printf.txt
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
pycond_timedwait_2.patch prints the delta time in microseconds when deadline is
in the past. Running the patch with the following command:
python -m test -m test_lru_cache_threaded -v test_functools
gives these results:
a) natively:
deadline is never in
New submission from Xavier de Gaye:
When a trace function set by sys.settrace() returns None, tracing of the
current scope should stop, but this feature is not implemented (issue 11992).
Currently f_trace is never set to Py_None. Setting f_trace to Py_None in
trace_trampoline() when the trace
Xavier de Gaye added the comment:
This patch fixes the TypeError.
New issue 27218: improve tracing performance with f_trace set to Py_None.
--
Added file: http://bugs.python.org/file43198/none_f_trace.patch
___
Python tracker
<http://bugs.python.
Xavier de Gaye added the comment:
The ro.kernel.qemu property is set to 1 on an Android emulator and 0 otherwise.
I think it should be added to the list. On some threading tests where the
switch interval is set to one microsecond, it is necessary to set the switch
interval to a higher value
Xavier de Gaye added the comment:
The problem can be fixed by changing the switch interval to a higher value when
the test is run on an Android emulator. Issue 26855 can provide a way to know
when this is the case through the value of the ro.kernel.qemu property.
--
dependencies
Xavier de Gaye added the comment:
The patch is simpler since android/api-level.h is now included in pyport.h by
changeset 09af54099973.
--
Added file: http://bugs.python.org/file43234/posixmodule_3.patch
___
Python tracker
<http://bugs.python.
Xavier de Gaye added the comment:
Agreed, and it is not part of the versioning scheme either.
--
___
Python tracker
<http://bugs.python.org/issue26855>
___
___
Xavier de Gaye added the comment:
Yes, those changes incorrectly assume that the source directory and the build
directory are always different (using VPATH). Alex patch LGTM, this other patch
overwrites the graminit.[ch] files, not sure if this is better.
--
Added file: http
New submission from Xavier de Gaye:
Building Python with clang and ccache produces about 200 'parentheses-equality'
warnings with the message:
warning: equality comparison with extraneous parentheses
[-Wparentheses-equality]
It seems that clang does not recognize that these
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xavier de Gaye :
--
assignee: -> xdegaye
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issue26862>
___
___
Python-bugs-
New submission from Xavier de Gaye:
==
FAIL: test_compile_path (test.test_compileall.CompileallTests)
--
Traceback (most recent call last):
File "/home/x
New submission from Xavier de Gaye:
This is with ncurses 6.0.
$ ./python -m test -v -u curses -m test_module_funcs test_curses
== CPython 3.6.0a2+ (default:e3bb87952c62, Jun 15 2016, 08:24:47) [GCC 6.1.1
20160501]
== Linux-4.6.1-2-ARCH-x86_64-with-arch little-endian
== hash algorithm
New submission from Xavier de Gaye:
Not sure if this is relevant, I am using:
readline 6.3
ncurses 6.0
The test runs fine when run alone, with the 8991930 random seed:
$ ./python -bb -E -Wd -m test -r -w -uall --randseed 8991930
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xavier de Gaye :
--
versions: +Python 2.7, Python 3.5
___
Python tracker
<http://bugs.python.org/issue27323>
___
___
Python-bugs-list mailing list
Unsub
New submission from Xavier de Gaye:
This is with ncurses 6.0.
When running the test suite with:
./python -bb -E -Wd -m test -r -w -uall
test_curses fails as reported in issue 27323 and when the test runner re-runs
test_curses in verbose mode at the end to test for a transient error, it
Xavier de Gaye added the comment:
Thanks for the review Pamela, indeed self.vfs is not defined.
The patched test_unittest runs without failure because the list_dir() nested
function is never called. It is also never called in the un-patched version.
Actually the un-patched
Xavier de Gaye added the comment:
> the list_dir() nested function is never called
Verifying that load_tests is called is the purpose of this test. In this case
should_recurse is false in _find_tests() and os.listdir() is not invoked by
this method.
This new patch does not use vfs
Xavier de Gaye added the comment:
issue #23968: rename the platform directory from plat-$(MACHDEP) to
plat-$(PLATFORM_TRIPLET)
--
___
Python tracker
<http://bugs.python.org/issue26
Changes by Xavier de Gaye :
--
dependencies: +rename the platform directory from plat-$(MACHDEP) to
plat-$(PLATFORM_TRIPLET)
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
The same problem occurs when cross-compiling for Android and running
test_sysconfig and test_distutils.
Some other points:
* The generation of the platform directory breaks the support of read only
source trees. The files of this directory are not tracked by
Xavier de Gaye added the comment:
> The same problem occurs when cross-compiling for Android and running
> test_sysconfig and test_distutils.
This is misleading. Actually, test_sysconfig and test_distutils do not fail
when run from the source tree, but fail on an installed python, wh
Xavier de Gaye added the comment:
issue #22724: byte-compile fails for cross-builds
--
dependencies: +byte-compile fails for cross-builds
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
The byte-compiling for cross-builds fails because PYTHON_FOR_BUILD defined in
configure, sets PYTHONPATH with the directory of the newly built extension
modules shared libraries and because PYTHON_FOR_BUILD is used to run
compileall.py in the Makefile
Xavier de Gaye added the comment:
Regeneration of the platdir files needs to be aware of the value of sysroot
[1]. For example on Android cross-builds, sysroot must be set to the path of
the headers and libraries for the targeted Android API level corresponding to a
version of the Android
Xavier de Gaye added the comment:
Johannes, what are the values of CONFIG_ARGS and libdir in the config.log of
your Linux SuSE.
--
nosy: +xdegaye
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
> On Android cross-builds, it should be possible to reproduce the failure when
> the build system and the host system have the same PLATFORM_TRIPLET
I confirm that this is the case. The following backtrace is produced when
cross-building and inst
New submission from Xavier de Gaye:
Cross-building the 3.6 source with PYTHON_FOR_BUILD using archlinux python
3.5.1 as found in PATH, fails with:
_PYTHON_PROJECT_BASE=/home/xavier/src/android/pyona/build/python3.6-android-21-x86
_PYTHON_HOST_PLATFORM=linux-x86
PYTHONPATH=/home/xavier/src
Xavier de Gaye added the comment:
Adding -E to PYTHON_FOR_BUILD fixes the x86_64 install because in my Android
cross-build setup, the native interpreter is built from the same source tree as
the cross-build. However, currently the interpreter used for the cross-build
may be any interpreter
Xavier de Gaye added the comment:
With this patch, cross-building the 3.6 source with only python 3.5.1 on the
PATH, produces the following configure error:
checking for python interpreter for cross build... configure: error:
python3.6 interpreter not found
--
keywords: +patch
New submission from Xavier de Gaye:
Expose the Android API level that python was built against, in
sys.implementation as _android_api.
Purposes:
* Identify the platform as Android.
* Allow detecting a mismatch with the runtime sdk version returned by
platform.android_ver() (issue 26855
Xavier de Gaye added the comment:
Patch added.
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file43610/android_api.patch
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
issue #27442: expose Android API level in sys.implementation
--
dependencies: +expose Android API level in sys.implementation
___
Python tracker
<http://bugs.python.org/issue26
Xavier de Gaye added the comment:
> I don't think sys.implementation is a good place to contain the information
> of the underlying platform.
Quite the opposite, the ndk API level gives an information about the
implementation of the currently running Python interpreter sayin
Xavier de Gaye added the comment:
@Ned
The information that the interpreter is an Android built, is needed in issue
16353 [1][2]. In msg266135, the corresponding patch adds the 'is_android'
attribute to the already bloated sys module. I had thought then about using
sysconfig.get_
Xavier de Gaye added the comment:
Well, issue 16353 has been entered upon attempting to fix issue 16255 (see
msg173477).
So an alternative exists. Issue 16353 could be closed as 'wont't fix'. The
list of locations where '/bin/sh' is hard coded in the standard library
Xavier de Gaye added the comment:
A patch to expose the Android API level in sysconfig.get_config_vars().
--
components: +Library (Lib) -Interpreter Core
title: expose Android API level in sys.implementation -> expose the Android API
level in sysconfig.get_config_vars()
Added f
Xavier de Gaye added the comment:
With configure run as './configure CC="$(CC)" ...' and when CC is set to:
CC = clang --sysroot=$(SYSROOT) -target $(TARGET) -gcc-toolchain
$(GCC_TOOLCHAIN)
and building for armv7 on android-21, then configure runs $CPP as:
checking for CPP
Xavier de Gaye added the comment:
According to issue 27453, do this minor change in the patch: s/$CC -E/$CPP
$CPPFLAGS.
--
___
Python tracker
<http://bugs.python.org/issue27
Xavier de Gaye added the comment:
Integrating Python into AOSP does not make sense. The patch can be changed with
s/ANDROID_API/ANDROID_API_LEVEL.
--
___
Python tracker
<http://bugs.python.org/issue27
Xavier de Gaye added the comment:
New patch incorporating the substitutions to '$CPP $CPPFLAGS' and
ANDROID_API_LEVEL.
--
stage: patch review -> commit review
Added file: http://bugs.python.org/file43636/android_api_3.patch
___
Python t
Changes by Xavier de Gaye :
--
title: Fix cross-compilation with Android NDK and Clang -> $CPP invocation in
configure must use $CPPFLAGS
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Xavier de Gaye added the comment:
New patch that gets rid of the changes in configure made by my version of
autoconf. This version is 2.69 though, i.e. the same as the generated configure
file that is under control of mercurial in the default branch.
--
assignee: -> xdegaye
st
Xavier de Gaye added the comment:
I think the way the condition was written previously is more expressive, so
the patch does not change that. The 'not' here expresses the fact that in the
shell syntax, the condition is true when the test returns 0 [1], but we still
want to expres
Xavier de Gaye added the comment:
In sysconfig.parse_config_h(), the variables in pyconfig.h that have a
commented-out '#undef' line are set to 0. Fortunately, there is no Android API
level 0.
Checking '== 0' ensures that autoreconf has been run to add '#und
Xavier de Gaye added the comment:
> Are you generating the patch using "hg diff"? I don't see the base revision
> in your patch, and so there is no [Review] link on your patch.
I am using 'hg diff' with ~/.hgrc set to 'git = on' and this time, naivel
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
@Berker
This does not work for me.
I found an old discussion [1] on the git format problem with Rietveld. The
thread diverges rapidly toward another subject, "submitting a branch instead of
a patch to the issue tracker" but comes back to the origin
Xavier de Gaye added the comment:
> I suggest to push the change without the unit test.
Agreed.
--
___
Python tracker
<http://bugs.python.org/issue27442>
___
_
Xavier de Gaye added the comment:
Thanks Berker and Stefan for your help on 'hg diff --git'. Yes Stefan, maybe
your patch has a [review] button because Rietveld found that your patch applied
cleanly against the head of the default branch at the time you have submitted
it, so it c
Changes by Xavier de Gaye :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xavier de Gaye added the comment:
New patch using the changes made in issue 27442.
--
dependencies: -android: add platform.android_ver()
keywords: +needs review -patch
stage: -> patch review
title: add is_android in test.support to detect Android platform -> add the
'
Changes by Xavier de Gaye :
--
assignee: -> xdegaye
___
Python tracker
<http://bugs.python.org/issue27027>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Xavier de Gaye:
'/bin/sh' is hard-coded in few places in the test suite, but the Android shell
is at '/system/bin/sh', see msg266084.
--
assignee: xdegaye
components: Tests
messages: 270044
nosy: xdegaye
priority: normal
severity: normal
stage
Changes by Xavier de Gaye :
--
dependencies: +add the 'is_android' attribute to test.support
___
Python tracker
<http://bugs.python.org/issue27472>
___
___
Xavier de Gaye added the comment:
issue #27472: add the 'unix_shell' attribute to test.support
--
dependencies: +add the 'unix_shell' attribute to test.support
___
Python tracker
<http://bug
Xavier de Gaye added the comment:
> The list of locations where '/bin/sh' is hard coded in the standard library:
I have entered issue 27472.
--
___
Python tracker
<http://bugs.pytho
1001 - 1100 of 1614 matches
Mail list logo
