Thomas Wouters added the comment:
Checked in a slightly newer version.
--
resolution: accepted -> fixed
status: open -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
New submission from Thomas Wouters:
test_smtplib fails because asyncore uses bytes(data) where data may be
bytes or str or some undefined type. The attached patch fixes it to the
extend that test_smtplib works again (plus a small fix in test_smtplib
itself.) I'm not sure if this is the
Thomas Wouters added the comment:
Checked in.
--
resolution: accepted -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Thomas Wouters added the comment:
I agree, but the change wasn't actually mine. I merely adjusted the
already-implemented strategy to the fact that bytes(str) no longer
works. I think the original change was Jeremy H's.
__
Tracker <[EMAIL PROT
Thomas Heller added the comment:
This is an experimental patch (solaris.patch). Can you please proofread
it and try it out on the solaris machine?
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1777530>
__
Thomas Heller added the comment:
Martin, here is a patch (solaris-2.patch), hopefully according to your
comments.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1777530>
_In
Thomas Herve added the comment:
object.c is already inconsistent about tabs and space :). It may be
better to fix it in the commit, not to clutter the patch. But I can
provide a new patch if necessary.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
New submission from Thomas Lee:
The current implementation of str.join requires that the parameters
passed to it be string/unicode values. A suggestion to allow it to
accept parameters of any type came up in PEP 3100. Implemented for
Unicode using the attached patch.
It would be trivial to add
Thomas Lee added the comment:
Oh and an example of usage:
# before the patch
', '.join([str(x) for x in [1, 2, 3]])
# after the patch
', '.join([1, 2, 3])
__
Tracker <[EMAIL PROTECTED]>
<htt
Thomas Heller added the comment:
Can someone please test the patch and report back? -- Thanks
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1777530>
_
__
Thomas Herve added the comment:
I think it could be solved both the same way: if tuple repr is wrong,
there are probably some other repr code that is wrong too, so fixing
PyObject_Repr is safer.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Thomas Lee added the comment:
Sure - I'll get onto that. Should have another patch up later tonight.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1145>
__
__
Thomas Lee added the comment:
Updated patch:
* unneeded PyUnicode_FromObject call removed (I thought this was
necessary, but the original author appears to be using it for an INCREF)
* documentation now fits into 80 chars
* return values from PyObject_Unicode and PyObject_FromObject checked
Thomas Heller added the comment:
Fixed in SVN: trunk rev 58155, release25-maint rev 58158.
Thanks.
--
resolution: -> fixed
status: open -> closed
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Thomas Heller added the comment:
Would you like to prepare a patch? I have no idea how the return values
of gestalt.gestalt("sysv") and platform.release() relate to each other...
--
nosy: +theller
__
Tracker <[EMAIL PROTECTED]>
<htt
Thomas Heller added the comment:
On the mac where I have access to platform.release() returns the string
'8.10.0'. gestalt.gestalt("sysv") returns 0x1049. Your patch does not
look correct to me.
__
Tracker <[EMAIL PROTECTED]>
<htt
Thomas Heller added the comment:
This patch looks better. However, the 'os.uname()' function seems to
return the information that we need; so I updated the patch to use this
instead. Can you please proofread it (osx.patch) ?
__
Tracker <[EMAIL PROT
Thomas Lee added the comment:
Is there anything else you need from me for this one Guido?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1145>
__
___
Python-bugs-
New submission from Thomas Lee:
Initial patch attached.
--
components: Interpreter Core
files: bytes-unicode-return-false-r1.patch
messages: 56284
nosy: thomas.lee
severity: normal
status: open
title: PEP 3137 patch: make PyBytes/PyUnicode ==/!= comparisons return False
type: rfe
Thomas Lee added the comment:
Revised patch - originally misinterpreted what was required here.
bytes() == str() now returns False, bytes() != str() now returns True.
--
title: PEP 3137 patch: make PyBytes/PyUnicode ==/!= comparisons return False ->
PEP 3137 patch: PyBytes/PyUnic
New submission from Thomas Lee:
The main patch - while exactly what is needed to make str8/str equality
checks return False - breaks a bunch of tests due to PyString_* still
being used elsewhere when it should be using PyUnicode.
The second patch modifies structmember.c to use PyUnicode_* where
Changes by Thomas Lee:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1263>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/op
Thomas Lee added the comment:
Oops - use unicode-string-eq-false-r3.patch, not
unicode-string-eq-false-r2.patch.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1263>
__Index: Objects/uni
Thomas Heller added the comment:
IMO os.uname() is preferable.
Committed as SVN rev 58415 in trunk.
Thanks.
--
assignee: -> theller
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Thomas Lee added the comment:
Hack to make Python/codecs.c use Unicode strings internally. I recognize
the way I have fixed it here is probably not ideal (basically ripped out
PyString_*, replaced with a PyMem_Malloc/PyMem_Free call) but it fixes
10-12 tests that were failing with my earlier
New submission from Thomas Heller:
I needed two logging handlers in my application, one notifiying the user
of errors, the other writing errors to a logfile. So I created a custom
subclass of logging.Formatter and redefined the formatException() method
that returned a summary of the exception
Thomas Heller added the comment:
> > This is tough. On the one hand you are right that different classes that
> > have different formatException() methods aren't treated correctly; on
> > the other hand I think the caching is important for other cases where
> > t
Thomas Heller added the comment:
I think that a warning or an example in the docs would be nice, but I
have no time to make a patch for that.
--
resolution: -> wont fix
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://
Thomas Heller added the comment:
Guido van Rossum schrieb:
> Looks good to me. I can check it in if Thomas is okay with that (or if
> he remains silent long enough :-).
Looks good to me too. Please check it in if you have time ;-)
__
Tracker <[EMAIL
Thomas Heller added the comment:
Looking again, I found a bug in the patch.
In the function _get_args(), the local variable 'name' was
changed from 'char *' to 'PyObject *'. In line 2995, it is
passed to PyErr_Format with a '%s' format code:
Thomas Heller added the comment:
Here's the bugfix - is it correct?
Added file: http://bugs.python.org/file8603/_ctypes.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1319>
__Index: Modules/
Thomas Heller added the comment:
Committed as rev 58642.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1319>
__
___
Python-bugs-list mailing list
Unsubs
Thomas Heller added the comment:
Maybe I should give up the idea to define the ffi_type_... types myself.
Committed as rev 58655. Thanks.
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Thomas Heller added the comment:
I'm unsure how to proceed with this.
Replacing the copy of libffi in the ctypes sources - I'm very afraid to
do that. It has it's own configure system, written by someone else.
Then it has several changes from various people for Python,
Thomas Heller added the comment:
In the branches_ctypes-branch I hacked setup.py to always use an
installed libffi if one is found. Then I triggered the trunk buildbots
which failed or crashed before in some c_longdouble tests; the tests
worked ok on them (ppc Debian unstable, and S-390 Debian
Thomas Heller added the comment:
I meant branches/ctypes_branch, of course.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1292>
__
___
Python-bugs-list
Thomas Heller added the comment:
I have now made --with-system-ffi default to "yes" for Linux/alpha*,
Linux/arm*, Linux/ppc*, and Linux/s390* machines. If you think it is
needed for mips machines also please add this - there's no buildbot
where I can c
Changes by Thomas Conway:
--
components: Library (Lib)
nosy: drtomc
severity: normal
status: open
title: toxml generates output that is not well formed
type: behavior
versions: Python 2.5
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
New submission from Thomas Conway:
The attached script yields a non-well-formed xml document.
Added file: http://bugs.python.org/file8692/bug.py
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1390>
__
Thomas Conway added the comment:
Either it is a bug in the DOM implementation, which should reject
comments containing -->, a bug in toxml() which should refuse to
serialize unserializable documents, or it is a bug in the documentation.
cheers,
Tom
__
Trac
Thomas Heller added the comment:
./python Lib/test/regrtest.py -R:: test_ctypes does not report a leak,
so I think there is no leak.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Thomas Heller added the comment:
> $ ./python Lib/test/regrtest.py -R:: test_ctypes
> test_ctypes
> beginning 9 repetitions
> 123456789
> .
> test_ctypes leaked [-33, 0, 0, 0] references, sum=-33
> 1 test OK.
> [101762 refs]
Thomas Conway added the comment:
Hi Martin,
You write:
It's not a bug in toxml, which should always serialize the
DOM tree if possible.
Right! In this case it is *not* possible. The generated serialization is
not a well formed XML document.
Having just consulted the DOM tech
Thomas Conway added the comment:
Hi Martin,
toxml() is not part of the DOM, so it could be changed to throw an
exception.
However, I suggest doing nothing, for the moment - I've posted to the
dom mailing list at w3, so I'll see what wisdom we get from its members.
c
Thomas Conway added the comment:
The W3 guys had some information that helps.
The DOM3 Core specification contains the following
No lexical check is done on the content of a comment and it is
therefore possible to have the character sequence "--"
(double-hyphen) in the content
Thomas Conway added the comment:
FWIW, the DOM guys considered mandating a check in createComment, but
decided that the performance penalty was too great. I'm not sure I
agree with them, but there you have it.
Here are links to my query about the issue:
http://lists.w3.org/Archives/Publi
Thomas Conway added the comment:
I think the specification is reasonably clear: createComment may not
throw an exception. The serializer must throw an exception. (Personally,
I think they have it round the wrong way - every time you write a
serializer you have to write code to do the check; if
New submission from Thomas Heller:
This patch uses the windows widechar apis for os.environ. In this way,
environment variables that use umlauts can be accessed.
--
components: Interpreter Core, Windows
files: posixmodule.c.diff
keywords: patch, py3k
messages: 57265
nosy: theller
Thomas Heller added the comment:
Committed as rev 58916.
The getpath.c, sys.path, and sys.argv issues is much more difficult to
fix IMO.
If you write a testcase for THIS issue (os.environ), I'll start thinking
on them. No promises, though.
--
assignee: -> theller
resolution:
Thomas Heller added the comment:
Christian Heimes schrieb:
> Neal, Thomas, what do you think about the patch? Your knowledge of the
> Windows API is greater than mine. Is the duplicate_socket() function ok?
> I don't want to apply a patch I don't fully understand.
>
Thomas Herve added the comment:
1315 is a duplicate of this, and I end up with a very similar solution.
--
nosy: +therve
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Thomas Herve added the comment:
The real bug is in fact in add_callers, where it concatenates tuples
instead of adding the values. I'll try to write a test this week-end if
nobody beats me to it.
The attached is against current trunk.
--
nosy: +therve
Added file: http://bugs.pytho
Thomas Herve added the comment:
Oh I didn't see, but this one should probably closed as duplicate of 1269.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1315>
__
_
Thomas Herve added the comment:
Here's my patch against trunk, with one test. Please review!
--
versions: +Python 2.6
Added file: http://bugs.python.org/file8806/1269.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Thomas Herve added the comment:
Ping to close this?
--
nosy: +therve
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1117670>
_
___
Python-bugs-
Thomas Heller added the comment:
Christian Heimes schrieb:
> > New submission from Christian Heimes:
> >
> > The problem is in _ctypes.c:create_comerror() around line 4620.
The code tries to populate a dict with methods and finally pass them to
PyErr_NewException("
Thomas Heller added the comment:
> Greg Couch added the comment:
>
> Turns out callproc.c forgot to include after
> which conditionally includes alloca.h. So it's a one-line fix.
>
This would not work. is a file private to libffi;
when Python is configured to use th
Thomas Holmes added the comment:
I got a bit distracted and I think had some questions on the review. I will go
back over the state of this patch and get some feedback to you tonight or
tomorrow evening.
--
___
Python tracker
<h
New submission from Thomas Jarosch :
Hi,
attached patch fixes a file descriptor leak on error.
Best regards,
Thomas Jarosch
--
components: Extension Modules
files: cpython-fix-file-descriptor-leak.patch
keywords: patch
messages: 144588
nosy: thomas.jarosch
priority: normal
severity
New submission from Thomas Kluyver :
When using sqlite3 with the Turkish locale, cursor.lastrowid is not accessible
after an insert statement if "INSERT" is upper case.
I believe that the cause is that the detect_statement_kind function [1] calls
the locale-dependent C function tolo
Thomas Kluyver added the comment:
What form does the test need to be in? There's a script at the redhat bug I
linked that demonstrates the issue. Do I need to turn it into a function? A
patch for the existing test suite?
--
type: beh
Thomas Kluyver added the comment:
Thanks, Antoine. Should I still try to write a regression test for it?
--
___
Python tracker
<http://bugs.python.org/issue13
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file23388/7db732ac6796.diff
___
Python tracker
<http://bugs.python.org/issue12344>
___
___
Python-bugs-list m
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file23390/1bb1132840e6.diff
___
Python tracker
<http://bugs.python.org/issue12344>
___
___
Python-bugs-list m
Thomas Holmes added the comment:
Still working with Éric to determine the proper behavior of
get_reinitialized_commands. Latest patch is known incorrect but a step closer
to our destination.
--
___
Python tracker
<http://bugs.python.
Thomas Holmes added the comment:
It's quite alright. Thanks for finishing it up. I realize I ended up a by out
of my depth with regards to packaging's internals and the nuance involved in
this fix. Thanks for all the help.
--
___
Pyth
New submission from Thomas Guettler :
In changeset fe6be0426e0d the format() method was changed. Unfortunately it
does not catch all unicode decode errors.
I think line 482 of logging/__init__.py should be modified:
to this (add 'replace'):
s = s + record.exc_t
Changes by Thomas Guettler :
Added file: http://bugs.python.org/file23486/unicodedecodeerror-in-logging.py
___
Python tracker
<http://bugs.python.org/issue13232>
___
___
Thomas Guettler added the comment:
I attached a testcase (unicodedecodeerror-in-logging.py). If the
filesystemencoding is UTF-8 and the source code is encoded in latin1, then the
logging fails. It happens because there is a German umlaut in the comment
behind 1/0.
I added 'replace&#x
Thomas Kluyver added the comment:
A couple of things to note:
- This was with the Python 3.1 implementation of 2to3 - the problem doesn't
appear with the Python 3.2 version.
- The import statement in question was inside a method definition. I wonder if
the extra two dots correspond t
Changes by Thomas Kluyver :
--
nosy: +takluyver
___
Python tracker
<http://bugs.python.org/issue9969>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Thomas Wouters :
The addition of the _posixsubprocess module in 3.2 introduced a change of
behaviour when passing an empty dict (or other false value besides None) as env:
python3.1 -c 'import subprocess; print(subprocess.Popen(["env"], env={},
stdout=
Changes by Thomas Holmes :
--
nosy: +Thomas.Holmes
___
Python tracker
<http://bugs.python.org/issue11873>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Thomas Holmes :
--
nosy: +thomas.holmes
___
Python tracker
<http://bugs.python.org/issue12449>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Thomas Holmes :
--
nosy: +thomas.holmes
___
Python tracker
<http://bugs.python.org/issue8501>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Thomas Holmes :
--
nosy: +thomas.holmes
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Holmes added the comment:
I setup a proxy and it seems to be working properly. This is on win7 x64
professional using Python 2.7.1
I didn't using any sniffing software but if I broke the proxy the code broke.
When I enabled the proxy it started working again. My proxy log also
New submission from Thomas Guettler :
from email.header import decode_header
decode_header('=?iso-8859-1?B?QW5tZWxkdW5nIE5ldHphbnNjaGx1c3MgU_xkcmluZzNwLmpwZw==?=')
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib64/python2.6/email/header.py&quo
Thomas Guettler added the comment:
This happens on Python3:
root@ubuntu1004devel64:~# python3
Python 3.1.2 (r312:79147, Sep 27 2010, 09:57:50)
[GCC 4.4.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
&g
Thomas Guettler added the comment:
I received this email. Here is the creator:
X-Mailer: CommuniGate Pro MAPI Connector 1.52.53.10/1.53.10.1
--
___
Python tracker
<http://bugs.python.org/issue12
Changes by Thomas Holmes :
--
nosy: +thomas.holmes
___
Python tracker
<http://bugs.python.org/issue5342>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Thomas Holmes :
--
assignee: tarek
components: Distutils2
nosy: alexis, eric.araujo, tarek, thomas.holmes
priority: normal
severity: normal
status: open
title: Uninstall has disabled windows tests
versions: Python 3.3
___
Python tracker
New submission from Thomas Holmes :
Functions test_uninstall.test_uninstall and test_uninstall.test_remove_issue
were disabled for win32. Upon enabling them they generated failures.
I have worked up a patch that refactors a packaging.Distribution function
_get_records from using a generator
Changes by Thomas Holmes :
--
keywords: +patch
Added file: http://bugs.python.org/file22588/f333cd40cd56.diff
___
Python tracker
<http://bugs.python.org/issue12
Changes by Thomas Holmes :
Removed file: http://bugs.python.org/file22588/f333cd40cd56.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bug
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file22589/dd470b122f32.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bugs-list m
Changes by Thomas Holmes :
Removed file: http://bugs.python.org/file22589/dd470b122f32.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bug
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file22590/dcd66ae649b1.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bugs-list m
Changes by Thomas Holmes :
Removed file: http://bugs.python.org/file22590/dcd66ae649b1.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bug
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file22591/dcd66ae649b1-2.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bug
Thomas Holmes added the comment:
The output in my initial message is the output of the tests with them enabled
but pre database.py patch. Once the patch is applied all packaging tests that
run on my system pass.
I was 50/50 on whether or not to use the internal function and I just sort of
Thomas Holmes added the comment:
Oh and thank you very much for your input. My apologies for the initial 9
e-mail spam when I created the issue, I bumbled the remote HG repository patch
generation :)
--
___
Python tracker
<http://bugs.python.
Thomas Holmes added the comment:
I have made the change you suggested, creating a new list and simply amending
to minimize the diff. This new patch has been attached.
I looked through the rest of database.py and did not see any other generators
that appeared to erroneously hold a file handle
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file22612/6e15ba060803.diff
___
Python tracker
<http://bugs.python.org/issue12504>
___
___
Python-bugs-list m
Thomas Holmes added the comment:
bdist does not appear to be enabled in 3.3 development branch, is this correct?
--
___
Python tracker
<http://bugs.python.org/issue12
Thomas Holmes added the comment:
I have made a patch based on your suggestions made to higery, Éric. I have two
questions:
1) In Distributions.get_reinitialized_command should the reinitialization of
the subcommands also get passed the kwargs? Unfortunately my understanding of
the (sub
Changes by Thomas Holmes :
Added file: http://bugs.python.org/file22615/d863f392c094.diff
___
Python tracker
<http://bugs.python.org/issue12344>
___
___
Python-bugs-list m
Thomas Holmes added the comment:
I was having a separate difficulty with bdist. Apparently -m packaging.run and
pysetup3 run don't perform identically, but that isn't relevant for this bug.
Regarding bdist, I got bdist_wininst to work but I had to modify the code in
place, it did n
Thomas Holmes added the comment:
> See also three comments about style on
> http://bugs.python.org/review/8668/diff2/2845:3011/7845
I'm not sure I follow? The patch I attached does not violate the style
guidelines that you indicate in the comments. The only failing I
Changes by Thomas Holmes :
--
nosy: +thomas.holmes
___
Python tracker
<http://bugs.python.org/issue12537>
___
___
Python-bugs-list mailing list
Unsubscribe:
101 - 200 of 1791 matches
Mail list logo
