Change by Tal Einat :
--
keywords: +patch
pull_requests: +7059
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33748>
___
___
Python-
Tal Einat added the comment:
See #33770, which will make recognizing and handling this case straightforward.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue27
Tal Einat added the comment:
It is more a correction than a clarification.
After looking through the module some more, I'm considering using
binascii.Incomplete for this case, since it seems appropriate enough that it's
worth using it rather than adding another, separate
Tal Einat added the comment:
Code using only a2b_base64() would likely not be expecting this exception.
We have at least one such example in the stdlib: decode_b() in
Lib/email/_encoded_words.py (which needs to be fixed regardless; see #27397
Tal Einat added the comment:
PR is ready with an improved exception message and raising binascii.Incomplete
rather than binascii.Error. A final review would be welcome!
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Tal Einat :
--
keywords: +patch
pull_requests: +7205
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue27397>
___
_
Tal Einat added the comment:
New changeset 1b85c71a2136d3fa6a1da05b27b1fe4e4b8ee45e by Tal Einat in branch
'master':
bpo-33770: improve base64 exception message for encoded inputs of invalid
length (#7416)
https://github.com/python/cpython/commit/1b85c71a2136d3fa6a1da05b27b1fe
Tal Einat added the comment:
New changeset 4ab4695388fb9ec03a14d93e90ce50d832a920ec by Tal Einat in branch
'master':
bpo-33748: fix tests altering sys.path and sys.modules (GH-7433)
https://github.com/python/cpython/commit/4ab4695388fb9ec03a14d93e90ce50
Tal Einat added the comment:
Is this a bug? Are passwords containing non-ASCII characters supposed to be
supported? If so, which encoding should be assumed for the password? Since it
needs to be base64-encoded, it must be encoded into bytes.
--
nosy: +taleinat
Tal Einat added the comment:
Moving the linecache check up before the two others seems like a simple and
safe optimization. On the other hand, I'm not sure calling getmodule() before
checking if the file exists would be faster in many cases.
Pankaj, could you also include the script yo
Tal Einat added the comment:
We definitely need an expert to weigh in on this.
--
nosy: +giampaolo.rodola
___
Python tracker
<https://bugs.python.org/issue33
Change by Tal Einat :
--
keywords: +patch
pull_requests: +7209
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue33573>
___
_
Tal Einat added the comment:
PR ready for review.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue33573>
___
___
Python-bugs-list mailin
Tal Einat added the comment:
The change is not entirely backward-compatible, so not back-porting before 3.7
seems good to me. IMO this should be closed.
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue24356>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +7245
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue1529353>
___
___
Python-
Tal Einat added the comment:
New PR ready for review.
I've updated the code for recent master and cleaned up the deprecation warnings
from the tests.
--
versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8 -Python 3.4
___
Python tr
Tal Einat added the comment:
I suggest that we close this issue. IMO the potential benefit is too small
relative to the work required, and the interest is too low.
--
___
Python tracker
<https://bugs.python.org/issue2
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue1927>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue24403>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Since this is a small enhancement proposal that is not sure to be approved, and
there has been no followup for years, I vote to close this.
--
___
Python tracker
<https://bugs.python.org/issue24
Tal Einat added the comment:
Thanks for the warm welcome, Terry :)
> 3.5 only gets security fixes.
Yup, my mistake.
> 'Large text' has two meanings: long lines and lots of lines. [...]
Squeezer handles both long lines and/or large numbers of lines.
> As the co
Tal Einat added the comment:
I ended up fixing this independently of #33770.
AFAIK this should just work with 3.6.
--
___
Python tracker
<https://bugs.python.org/issue27
Tal Einat added the comment:
Cheryl, thanks for testing this and writing up your thoughts!
There is certainly much room for improvement.
Since it seems that you and Terry like the approach, I'll start working on the
tooltips as Terry asked, and wait for more input from him before begi
Tal Einat added the comment:
New changeset c3f55be7dd012b7e92901627d0b31c21e983ccb4 by Tal Einat in branch
'master':
bpo-27397: Make email module properly handle invalid-length base64 strings
(#7583)
https://github.com/python/cpython/commit/c3f55be7dd012b7e92901627d0b31c
Tal Einat added the comment:
New changeset 7b82281c80d0064559866afe92f19cae5978c841 by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-27397: Make email module properly handle invalid-length base64 strings
(GH-7583) (GH-7664)
https://github.com/python/cpyt
Tal Einat added the comment:
New changeset 63dd1f70c1aa57494802c9b68f9db4918620fc8f by Tal Einat (Miss
Islington (bot)) in branch '3.6':
bpo-27397: Make email module properly handle invalid-length base64 strings
(GH-7583) (GH-7665)
https://github.com/python/cpyt
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
I've started work on this. My progress can be followed on the bpo-33839 branch
on my GitHub repo: https://github.com/taleinat/cpython/tree/bpo-33839
--
___
Python tracker
<https://bugs.python.org/is
Tal Einat added the comment:
IMO both approaches sound better than the existing implementation. Better to
choose one than to do nothing.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue25
Change by Tal Einat :
--
keywords: +patch
pull_requests: +7296
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue33839>
___
_
Tal Einat added the comment:
The refactoring is done, manual testing with the htests works, and I've added
automated tests with ~92% code coverage.
Terry, I'd be happy for your review!
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
Attaching coverage report for tooltip.py.
The uncovered lines are required to avoid exceptions when closing a windows
with a tooltip shown. These are not currently reproduced by test_tooltip.py
because my attempts to exercise them in automated tests have all
Tal Einat added the comment:
Once the ToolTip is ready, I'll begin working on this.
Summarizing what appear to be agreed-upon changes to be made (keeping original
numbering for reference):
1. Avoid expanding large output accidentally / too easily. Current suggestions
are expanding pa
Tal Einat added the comment:
Additional feature discussion:
> 10. The button for 'a'*1 says '(nn lines)'. It should say '(1
> chars)' or '(1 line, 1 chars)'.
IMO that's too much, it leads to "information overload"
Tal Einat added the comment:
It would be extremely helpful to have some test cases that actually work for
users but fail with smtplib. So far we have no actual examples, likely due to
these being passwords.
> Note: it is definitely the case, regardless of what the RFC says, that bin
Tal Einat added the comment:
My main laptop is currently Windows 10, I use it for most CPython work.
I also have PCs running OSX, Ubuntu and Windows 7.
Terry, let me know what and when you'd like me to run on which OSs, and I'll
g
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue24145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue20341>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue24009>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
So 3.8 then, or should this be closed?
FWIW I'm -1. IMO this should be a code recipe somewhere, no need for it to be
in the stdlib.
--
___
Python tracker
<https://bugs.python.org/is
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue20187>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue20177>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue20181>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
IMO we should create new issues for AC conversion of the collections and random
modules (assuming they haven't been converted yet), and close this issue.
--
___
Python tracker
<https://bugs.python.org/is
Tal Einat added the comment:
> And yes, by binary passwords I mean that the module needs to support being
> passed a bytes-like object as the password, since clearly there are servers
> "in the wild" that support non-ascii passwords and the only way to be sure
> one c
Tal Einat added the comment:
I found the Thunderbirg bugzilla issues where they appear to have dealt
precisely with this issue (for a variety of protocols, including SMTP):
https://bugzilla.mozilla.org/show_bug.cgi?id=312593
--
___
Python tracker
Tal Einat added the comment:
This specifically seems relevant:
> In order for Thunderbird to be standards-compliant-enough to interoperate
> with standards-compliant servers, it should use UTF-8 for the SASL PLAIN
> mechanism regardless of the underlying protocol (IMAP, POP and SM
Tal Einat added the comment:
There's also some discussion there (from 3 years ago) of possibly needing to
fall back to ISO-8859-1 to work with MS Exchange, despite the standards saying
UTF-8 should be used. It's unclear to me whether that's ac
Tal Einat added the comment:
>From reading the aforementioned discussion on Thunderbird's issue tracker,
>ISTM that encoding with UTF-8 is the way to go.
--
___
Python tracker
<https://bugs.python.
Tal Einat added the comment:
> What do you think of changing 'ToolTip' to 'Tooltip'?
+1, I'll change it.
> TclError from widget.destroy suggests that we *might* be able to cleanup
> better.
The try/except clauses which are hard to test are used sin
Tal Einat added the comment:
>> TclError from widget.destroy suggests that we *might* be able to cleanup
>> better.
> Any suggestions for a better cleanup mechanism?
(Following up my own question with another question...)
Would it be better to check self.winfo_exists() ins
Tal Einat added the comment:
> I [...] would like the popups to respond keyboard (Tab) focus changes as well
> as mouse movement focus changes.
Should tooltips also be shown automatically when the keyboard focus is on a
widget? Using the same delay as for the mouse hover, perhaps?
Tal Einat added the comment:
> I just merged 2nd PR for #33907.
I've merged master into the PR branch for this issue and fixed the merge issues.
--
___
Python tracker
<https://bugs.python.org
Tal Einat added the comment:
>> If so, should it be possible for two tooltips to be shown at once, one for
>> the mouse hover and one for the keyboard focus?
> If we have different popup contents, I think 1 at a time would be fine.
Consider the following example: A window w
Change by Tal Einat :
--
pull_requests: +7450
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
keywords: +patch
pull_requests: +7449
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue32568>
___
_
Tal Einat added the comment:
>> Also sizehint=0 was rejected before
>> 2fb9ae9dfc5a6830d902332ba93b13387e292ddb. Now it is accepted.
Please note that by "Now it is accepted" I meant in the current codebase,
before PR 7840. In this regard, that PR changes nothing.
G
Change by Tal Einat :
--
pull_requests: +7470
___
Python tracker
<https://bugs.python.org/issue32568>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
keywords: +patch
pull_requests: +7498
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33951>
___
___
Python-
New submission from Tal Einat :
The issue occurs when running the following on Windows 10 Pro 64-bit on the
latest master branch (ea737751b10fff752aafed0231e8a02b82ba365d):
python -m test -ugui -m test_highlight_target_text_mouse test_idle
(This test failed for perhaps an unrelated reason on
Tal Einat added the comment:
You can know that the semaphore tracker is running by sending it an invalid
command and seeing the error written to stderr. The semaphore tracker either
inherits sys.stderr from the parent process (if possible) or uses its own.
This is a bit of a hack, but
Tal Einat added the comment:
A possible concrete example: Capturing sys.stdout and/or sys.stderr for
testing, as in test.support.captured_output.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue33
Tal Einat added the comment:
For the "no-op" we'll need a way to know that it was processed. To that end,
I'd make the semaphore tracker recognize a new command e.g. "PING", upon which
it would write something e.g. &
Tal Einat added the comment:
New changeset a8ddf85a84364d2c660e6670a7e06621993d1fdc by Tal Einat (Andrés
Delfino) in branch 'master':
bpo-33943: Add references in the docs for logging.basicConfig (GH-7858)
https://github.com/python/cpython/commit/a8ddf85a84364d2c660e6670a7e066
Change by Tal Einat :
--
versions: +Python 3.5
___
Python tracker
<https://bugs.python.org/issue33943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 66d77d8af8f7c3ebd604ad1e802b8e5006d79d8f by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-33943: Add references in the docs for logging.basicConfig (GH-7858)
(GH-7900)
https://github.com/python/cpyt
Change by Tal Einat :
--
pull_requests: +7507
___
Python tracker
<https://bugs.python.org/issue33943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 73848e028de58e7fb2b38bddb1638ca2323561a9 by Tal Einat (Miss
Islington (bot)) in branch '3.6':
bpo-33943: Add references in the docs for logging.basicConfig (GH-7858)
(GH-7899)
https://github.com/python/cpyt
Change by Tal Einat :
--
pull_requests: +7508
___
Python tracker
<https://bugs.python.org/issue33943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset aa770b7096c004abdf3c27bc361d6b60a4b668af by Tal Einat in branch
'2.7':
[2.7] bpo-33943: Add references in the docs for logging.basicConfig (GH-7858)
(GH-7902)
https://github.com/python/cpython/commit/aa770b7096c004abdf3c27bc361d6b
Tal Einat added the comment:
New changeset 4a6e746079441d18c30e3c4d014f106faaf7792f by Tal Einat (Andrés
Delfino) in branch 'master':
bpo-33952: Fix typo in str.upper() documentation (GH-7898)
https://github.com/python/cpython/commit/4a6e746079441d18c30e3c4d014f106faaf7792f
-
Tal Einat added the comment:
Thanks for the PR, Andrés! Merged and backported.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<https://bugs.python
Change by Tal Einat :
--
pull_requests: +7511
___
Python tracker
<https://bugs.python.org/issue33952>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 80f1a908a87e55c318776fb8e6f8c21d8a8664ef by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-33952: Fix typo in str.upper() documentation (GH-7898) (GH-7903)
https://github.com/python/cpython/commit/80f1a908a87e55c318776fb8e6f8c2
Tal Einat added the comment:
New changeset ac5a6e35ef4a73846136804fff924760ec67ebbd by Tal Einat (Miss
Islington (bot)) in branch '3.6':
bpo-33952: Fix typo in str.upper() documentation (GH-7898) (GH-7904)
https://github.com/python/cpython/commit/ac5a6e35ef4a73846136804fff9247
Tal Einat added the comment:
New changeset 78209734a0ecd1567f819d95314b1c7c9b26f48a by Tal Einat in branch
'2.7':
[2.7] bpo-33952: Fix typo in str.upper() documentation (GH-7898) (GH-7905)
https://github.com/python/cpython/commit/78209734a0ecd1567f819d95314b1c
Tal Einat added the comment:
Thanks for the PR, Andrés! Merged and backported.
--
___
Python tracker
<https://bugs.python.org/issue33952>
___
___
Python-bug
Tal Einat added the comment:
New changeset fdd6e0bf18517c3dc5e24c48fbfe890229fad1b5 by Tal Einat in branch
'master':
bpo-33573: docs to suggest median() alternatives for non-numeric data (GH-7587)
https://github.com/python/cpython/commit/fdd6e0bf18517c3dc5e24c48fbfe89
Tal Einat added the comment:
New changeset 150cd3cb272021e9a2d865dd28486b00199fe77d by Tal Einat (Miss
Islington (bot)) in branch '3.7':
[3.7] bpo-33573: docs to suggest median() alternatives for non-numeric data
(GH-7587) (GH-7906)
https://github.com/python/cpyt
Tal Einat added the comment:
New changeset 8fd8cfa369fe4b6d6ac430cd28ead32717df7bee by Tal Einat (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-33573: docs to suggest median() alternatives for non-numeric data
(GH-7587) (GH-7907)
https://github.com/python/cpyt
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
When ready, should this (and other AC conversions) be backported to the
relevant 3.x branches?
--
___
Python tracker
<https://bugs.python.org/issue31
Tal Einat added the comment:
New changeset 0cdf5f42898350261c5ff65d96334e736130780f by Tal Einat in branch
'master':
bpo-32568: make select.epoll() and its docs consistent (#7840)
https://github.com/python/cpython/commit/0cdf5f42898350261c5ff65d96334e
Tal Einat added the comment:
New changeset 0cdf5f42898350261c5ff65d96334e736130780f by Tal Einat in branch
'master':
bpo-32568: make select.epoll() and its docs consistent (#7840)
https://github.com/python/cpython/commit/0cdf5f42898350261c5ff65d96334e
Change by Tal Einat :
--
pull_requests: -7450
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -7634
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg320775
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list m
Change by Tal Einat :
--
pull_requests: +7636
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +7635
___
Python tracker
<https://bugs.python.org/issue32568>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset fd1c092bb9fee46d8d543710973c69a0e93a697a by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-32568: make select.epoll() and its docs consistent (GH-7840) (GH-8024)
https://github.com/python/cpyt
Tal Einat added the comment:
New changeset fd1c092bb9fee46d8d543710973c69a0e93a697a by Tal Einat (Miss
Islington (bot)) in branch '3.7':
bpo-32568: make select.epoll() and its docs consistent (GH-7840) (GH-8024)
https://github.com/python/cpyt
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset db7ac30ef52ce35a4ead1bc1b9f0dd5331ed9779 by Tal Einat in branch
'3.6':
[3.6] bpo-32568: make select.epoll() and its docs consistent (GH-7840) (GH-8025)
https://github.com/python/cpython/commit/db7ac30ef52ce35a4ead1bc1b9f0dd
Tal Einat added the comment:
New changeset db7ac30ef52ce35a4ead1bc1b9f0dd5331ed9779 by Tal Einat in branch
'3.6':
[3.6] bpo-32568: make select.epoll() and its docs consistent (GH-7840) (GH-8025)
https://github.com/python/cpython/commit/db7ac30ef52ce35a4ead1bc1b9f0dd
Tal Einat added the comment:
Nick's abstract example LGTM as well.
--
___
Python tracker
<https://bugs.python.org/issue33468>
___
___
Python-bugs-list m
Tal Einat added the comment:
New changeset 6dc57e2a20c5beb99e8bf5eb04cc836d53fa9aee by Tal Einat in branch
'master':
bpo-31938: Convert selectmodule.c to Argument Clinic (GH-4265)
https://github.com/python/cpython/commit/6dc57e2a20c5beb99e8bf5eb04cc83
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg320779
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list m
Change by Tal Einat :
--
pull_requests: -7637
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
801 - 900 of 1452 matches
Mail list logo