Tal Einat added the comment:
New changeset ede0b6fae20290bf22b6ee1b9a1e1179d750f360 by Tal Einat in branch
'master':
bpo-20182: AC convert Python/sysmodule.c (GH-11328)
https://github.com/python/cpython/commit/ede0b6fae20290bf22b6ee1b9a1e11
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332828
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list m
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332827
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list m
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Tal Einat :
IDLE usually wraps call-tips to 85 characters. However, for functions without
a doc-string, this formatting is skipped. This is an issue for functions with
long signatures, e.g. due to having many arguments or due to having default
values with long repr-s
Change by Tal Einat :
--
assignee: -> taleinat
components: +IDLE
nosy: +terry.reedy
stage: -> needs patch
type: -> behavior
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
Hi Dan,
Your report is unrelated to this Squeezer-related issue, but thanks for
reporting it! I've created a new issue for what you've reported, see #35641.
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
I'm marking this as easy.
Whoever works on this should make sure to add a new test case for this bug.
--
assignee: taleinat ->
keywords: +easy
___
Python tracker
<https://bugs.python.org
Change by Tal Einat :
--
pull_requests: -10814
___
Python tracker
<https://bugs.python.org/issue35641>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -10814, 10815, 10816
___
Python tracker
<https://bugs.python.org/issue35641>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: -10814, 10815
___
Python tracker
<https://bugs.python.org/issue35641>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Perhaps "expected" and "observed" or "detected"?
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue35500>
___
__
Change by Tal Einat :
--
pull_requests: -10554
___
Python tracker
<https://bugs.python.org/issue35525>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -10554, 10555
___
Python tracker
<https://bugs.python.org/issue35525>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset e9a044ec16989bd4b39763c0588c17200a925350 by Tal Einat (Harmandeep
Singh) in branch 'master':
bpo-35525: Correct the argument name for NNTP.starttls() (GH-11310)
https://github.com/python/cpython/commit/e9a044ec16989bd4b39763c0588c17
Change by Tal Einat :
--
pull_requests: -10818
___
Python tracker
<https://bugs.python.org/issue35525>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -10818, 10819
___
Python tracker
<https://bugs.python.org/issue35525>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -10818, 10819, 10822
___
Python tracker
<https://bugs.python.org/issue35525>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: -10818, 10819, 10821, 10822
___
Python tracker
<https://bugs.python.org/issue35525>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
pull_requests: -10831
___
Python tracker
<https://bugs.python.org/issue35641>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -10830, 10831
___
Python tracker
<https://bugs.python.org/issue35641>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Thanks for the report, Dan!
Thanks for the fix, Emmanuel!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Tal Einat :
--
pull_requests: +10892
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -10893
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10892, 10893
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10892, 10893, 10894
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: -10894
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Thanks Serhiy! The compiler doesn't warn about that on Windows.
See PR GH-11444 with a fix.
--
___
Python tracker
<https://bugs.python.org/is
Tal Einat added the comment:
New changeset 1cffd0eed313011c0c2bb071c8affeb4a7ed05c7 by Tal Einat (Alexey
Izbyshev) in branch 'master':
bpo-34512: Document platform-specific strftime() behavior for non-ASCII format
strings (GH-8948)
https://github.com/python/cpyt
Change by Tal Einat :
--
pull_requests: -11135
___
Python tracker
<https://bugs.python.org/issue34512>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -11135, 11137
___
Python tracker
<https://bugs.python.org/issue34512>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -11135, 11137, 11139
___
Python tracker
<https://bugs.python.org/issue34512>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 39a33e99270848d34628cdbb1fdb727f9ede502a by Tal Einat in branch
'master':
bpo-35196: Optimize Squeezer's write() interception (GH-10454)
https://github.com/python/cpython/commit/39a33e99270848d34628cdbb1
Tal Einat added the comment:
> The test rely on a specific font name and specific font size: maybe this
> specific font is not available.
Can you help by checking this? Is there another font known to be universally
available?
> Instead of skipping the test, would it make same
Tal Einat added the comment:
> What if the old and the new font have the same width?
The font is set to Courier 10 in the test's setup, and it is then set to
Courier 20 by the test before calling reload(). The zero character should
certainly not have the same width in both cases.
I
Tal Einat added the comment:
Indeed, a PR for this should include a test that weakrefs work.
--
___
Python tracker
<https://bugs.python.org/issue35701>
___
___
Change by Tal Einat :
--
pull_requests: +11272
___
Python tracker
<https://bugs.python.org/issue35730>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +11272, 11273, 11274
___
Python tracker
<https://bugs.python.org/issue35730>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: +11272, 11273
___
Python tracker
<https://bugs.python.org/issue35730>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
The recently merged PR GH-10454 significantly reduced the overhead of
Squeezer's write() interception. The overhead should now be entirely
insignificant.
IMO that deals with the "... and is slow" part of this issue. We've still to
dec
Tal Einat added the comment:
This is due to the test using a 50ms delay on hover, and checking "immediately"
after generating an "" event that it hasn't triggered yet. Note that
this isn't actually "immediately": The Tk root's update() is ca
Tal Einat added the comment:
In my opinion, everything here is relatively minor compared to some other
current issues with IDLE, e.g. some of those mentioned by Raymond Hettinger in
his comments on #35196.
That being said, a few comments:
> E1. Add 'Expand' at the top of the
Change by Tal Einat :
--
pull_requests: -11816, 11817
___
Python tracker
<https://bugs.python.org/issue35500>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -11816
___
Python tracker
<https://bugs.python.org/issue35500>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: -11816, 11817, 11818
___
Python tracker
<https://bugs.python.org/issue35500>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
Karthikeyan, what do you think of the suggestions by Terry and myself to
achieve alignment by replacing the word "Actual" with a longer alternative,
such as "Observed" or "Received"?
--
Tal Einat added the comment:
After more thought, I agree that it isn't worth changing the current wording
from "Actual" to something else.
--
___
Python tracker
<https://bugs.pyt
Tal Einat added the comment:
> Is there any update on this? Will this be fixed in the next release?
There was progress made as described on this issue, but there is yet work to be
done, and no-one seems to be taking this upon themselves at the moment.
I agree that it would be great to h
Tal Einat added the comment:
Susan, I agree that similarly improving the failure message for
assert_called_with would be good.
I find the final "Not called" line unclear, though. Perhaps something like the
following:
AssertionError: expected call not found.
Expected: mock(
Tal Einat added the comment:
Thanks everyone for seeing this through!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 6cd658b1a5cb2413230dbc2d9395d20498be8518 by Tal Einat in branch
'master':
bpo-34203: FAQ: improve wording of paragraph about 2.x vs. 3.x (GH-9821)
https://github.com/python/cpython/commit/6cd658b1a5cb2413230dbc2d9395d2
New submission from Tal Einat :
In 2fb9ae9dfc5a6830d902332ba93b13387e292ddb, select.epoll() was changed to
reject sizehint=-1, despite that still being documented as the default value.
Would it be possible to reverse this change, making -1 a special value
signaling select.epoll() to use
Tal Einat added the comment:
Also see discussion in GitHub PR 4265 for #31938.
--
___
Python tracker
<https://bugs.python.org/issue32568>
___
___
Python-bug
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue20827>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue17535>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue18875>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue21880>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue6858>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue24412>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue11437>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue694339>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue21787>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue1350>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue21696>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue6143>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue22083>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue31810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Id be happy to update the itertools patch.
I haven't been following AC work for quite a while. I would expect this to
entail:
1. applying the patch to the master branch
2. merging any conflicts
3. running the clinic.py script again
4. review the outpu
Tal Einat added the comment:
I'd be happy to update the patches.
I asked for a bit of clarification on what this entails in msg304931 on issue
#20180, once that's clear I'll do the same for these patches and create PRs.
--
___
Tal Einat added the comment:
What about islice? Does AC now support complex enough signatures to support it?
If not, should I leave the comment as is?
--
___
Python tracker
<https://bugs.python.org/issue20
Tal Einat added the comment:
As far as I can tell, with the creation of a separate clinic/itertools.c.h, the
typedefs etc. need to be moved to the top of the file so that the #include can
come after the typedefs and before the rest of the code which references clinic
output. Is this indeed
Change by Tal Einat :
--
pull_requests: +4087
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue20180>
___
___
Python-bugs-lis
Tal Einat added the comment:
See PR 4117 on GitHub with the itertools AC conversion.
--
___
Python tracker
<https://bugs.python.org/issue20180>
___
___
Python-bug
Tal Einat added the comment:
I can't say I agree that the performance here is practically insignificant.
This will affect the startup time of Python process, and adding even 10% to
that in some cases is significant.
In some of the larger codebases I've worked on, even simple scr
Tal Einat added the comment:
I understand that there is a workaround. I'm just thinking about the many
existing large codebases where re-writing thousands of imports because of this
is unlikely to be done, yet having somewhat longer process launch times would
be surprising and unw
Tal Einat added the comment:
Regarding the select module, the existing patch moves typedefs and object type
declarations to the top of the file with the #include clinic/selectmodule.c.h
statement can come afterwards. Should I keep it this way, or instead move the
method list and type
Change by Tal Einat :
--
pull_requests: +4139
___
Python tracker
<https://bugs.python.org/issue20180>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
To enable progressing with this in smaller steps, I created PR 4170 which
converts only itertools.groupby and the intertnal _grouper with minimal
required changes.
--
___
Python tracker
<https://bugs.python.
Tal Einat added the comment:
I have a complete, up-to-date AC conversion of Modules/selectmodule.c ready on
a branch in my GitHub CPython fork:
https://github.com/taleinat/cpython/tree/bpo-20182_AC_selectmodule
I haven't created a PR because there's currently an issue with the
New submission from Tal Einat :
I'm converting Modules/selectmodule.c.h as part of issue #20182.
After converting the code and running Tools/clinic/clinic.py, compilation is
failing on Windows due to the following block *not* being generated by in the
Modules/clinic/selectmodule.c.h
Change by Tal Einat :
--
keywords: +patch
pull_requests: +4199
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31926>
___
___
Python-
Tal Einat added the comment:
See PR 4230.
--
___
Python tracker
<https://bugs.python.org/issue31926>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
See issue #31926 and PR 4230 regarding the aforementioned argument clinic bug
and a fix for it.
--
___
Python tracker
<https://bugs.python.org/issue20
Change by Tal Einat :
--
pull_requests: +4215
___
Python tracker
<https://bugs.python.org/issue31926>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
As the author of all of the updated patches, I wouldn't mind opening new issues
separately for each of the remaining modules. Actually I would prefer it :)
--
___
Python tracker
<https://bugs.python.org/is
New submission from Tal Einat :
Continuing the work begun as part of issue #20182, this is regarding the
Argument Clinic conversion of Modules/selectmodule.c.h.
I have a complete conversion ready and will create a PR momentarily.
--
components: Argument Clinic
messages: 305514
nosy
Change by Tal Einat :
--
pull_requests: +4229
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
See issue #31938 regarding Modules/selectmodule.c.
--
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bug
Tal Einat added the comment:
See PR 4265.
--
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
keywords: +patch
pull_requests: +4228
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31938>
___
___
Python-
Tal Einat added the comment:
I'm not sure that the current concept of return converters in AC is can be used
for specifying return value annotations.
For example, what if I want to annotate the return value type with using a
return converter?
Another example: The current doc-strin
Tal Einat added the comment:
Argument Clinic currently doesn't support input parameter type annotations
either, though for this it has more relevant information in many cases.
I think it would be a great boon for AC to enable declaring type annotations,
both for input parameters an
Tal Einat added the comment:
My apologies, I seem to have been the source of the confusion. I misunderstood
your original meaning.
--
___
Python tracker
<https://bugs.python.org/issue31
Change by Tal Einat :
--
keywords: +patch
pull_requests: +7040
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue33770>
___
_
Tal Einat added the comment:
A base64-encoded string's length can only have a remainder of 0, 2 or 3, but
never 1. This is why the padding you get when encoding can only be '=' or '=='
but never '==='.
--
nosy: +taleinat
___
Tal Einat added the comment:
Oops: when I wrote "length can only have a remainder of ..." I meant remainder
upon division by 4.
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
They're not the same.
When the encoded string's length modulu 4 is 2 or 3, there just need to be (at
least) 2 or 1 padding characters ('=') for decoding to be successful, due to
our decoder being rather strict. Less strict decoders ma
Tal Einat added the comment:
It seems that adding a directory to sys.path is the intended behavior of
`loader.discover()`. Should the test be restoring sys.path back to it original
value when it's done?
Also, shouldn't this test (and some others) be restoring sys.modules when
th
Tal Einat added the comment:
Would an exception message as following be acceptable? "Invalid base64-encoded
string: length cannot be 1 more than a multiple of 4"
--
___
Python tracker
<https://bugs.python.o
701 - 800 of 1452 matches
Mail list logo
