Tal Einat added the comment:
> perhaps we can make the stack viewer always work
Well, perhaps not "always", e.g. probably not while user code is running.
--
___
Python tracker
<https://bugs.pytho
Tal Einat added the comment:
New changeset e8acc865a3f112b98417f676c897ca6ec2dac2c7 by Tal Einat (Andrey
Doroschenko) in branch 'master':
bpo-38351: Modernize email examples from %-formatting to f-strings (GH-17162)
https://github.com/python/cpyt
Tal Einat added the comment:
Thanks for the PR, Andrey!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Tal Einat :
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue17642>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset 645005e947c13c4a0706310a2a46112bf63cadc0 by Tal Einat (Andrey
Doroschenko) in branch 'master':
bpo-38724: Implement subprocess.Popen.__repr__ (GH-17151)
https://github.com/python/cpython/commit/645005e947c13c4a0706310a2a4611
Tal Einat added the comment:
Thanks for the suggestion Ram, and thanks for PR Andrey!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
The PR looks pretty good, but the question is whether we want to break
backwards compatibility in the name of correctness.
In this case, the silent buggy behavior of keeping the (mod 256) of the value
seems worth fixing to me.
--
nosy: +taleinat
Tal Einat added the comment:
See also issue33046 specifically suggesting auto-removal of trailing whitespace
on saving a file, as per Raymond's second suggestion here. It has a PR which
seems about ready to go.
I see that as the simplest approach to this issue, both in ter
Change by Tal Einat :
--
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue38722>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
I don't see why this should be considered a security issue.
This should likely have been done when io.open_code() was initially added, but
now that 3.8 is out, I don't think backporting this would be wise.
--
nosy: +taleinat
type: security ->
Tal Einat added the comment:
Thanks Steve! I hadn't realized that we'd made such a declaration WRT opening
of code files in general. In that case, this is certainly at least a bug fix,
and should be backported.
--
type: enhancement -> security
versions
Tal Einat added the comment:
Thanks for reporting this, Dominic!
Thanks for the PR, Jason!
--
___
Python tracker
<https://bugs.python.org/issue38722>
___
___
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
Thanks for the clarification Steve! I've backported this to 3.8.
--
___
Python tracker
<https://bugs.python.org/issue38722>
___
___
Tal Einat added the comment:
Alright, so let's push through the existing PR for rejecting such octal escapes
in byte strings.
We'll also need another PR for raising a deprecation warning for such octal
escapes in strings.
--
keywords: +eas
Tal Einat added the comment:
New changeset be5c79e0338005d675a64ba6e5b137e850d556d1 by Tal Einat (Federico
Bond) in branch 'master':
bpo-38821: Fix crash in argparse when using gettext (GH-17192)
https://github.com/python/cpython/commit/be5c79e0338005d675a64ba6e5b137
Tal Einat added the comment:
Thanks for the report and the PR with a fix, Federico!
As discussed on in the PR comments, the PR did not include tests since there
are currently no tests for argparse i18n. Please create a new issue for that,
referencing this one
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
Hi Florian! We'd be happy to have you do this, please go ahead.
When you have a PR ready, you're welcome to request my review.
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
Good catch on this, Zackery!
For anyone readying this, Serhit posted a minimal reproducer in a PR comment,
and the PR now adds a test for this.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg357336
___
Python tracker
<https://bugs.python.org/issue38384>
___
___
Python-bugs-list m
Tal Einat added the comment:
Good catch on this, Zackery!
For anyone readying this, Serhiy posted a minimal reproducer in a PR comment,
and the PR now adds a test for this.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Tal Einat :
--
versions: +Python 3.7, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38524>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
New changeset 1bddf890e595a865414645c6041733043c4081f8 by Tal Einat (Florian
Dahlitz) in branch 'master':
bpo-38524: document implicit and explicit calling of descriptors' __set_name__
(GH-17364)
https://github.com/python
Change by Tal Einat :
--
pull_requests: +16886
pull_request: https://github.com/python/cpython/pull/17406
___
Python tracker
<https://bugs.python.org/issue38
Tal Einat added the comment:
New changeset 02519f75d15b063914a11351da30178ca4ceb54b by Tal Einat in branch
'master':
bpo-38524: clarify example a bit and improve formatting (GH-17406)
https://github.com/python/cpython/commit/02519f75d15b063914a11351da3017
Tal Einat added the comment:
Ido, I don't see why this should be closed. The suggestion is good and the PR
is good. I'm only waiting for the CLA signing to be worked through to merge the
PR.
--
___
Python tracker
<https://bu
Tal Einat added the comment:
Thanks for the suggestion hongweipeng!
Thanks for the PR Florian, and congratulations on your first contribution to
the project! May it be the first of many.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Tal Einat added the comment:
Thanks for the report Rémi and for the PR Ido!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Tal Einat :
The "Credits" document in the "About" dialog could use some updating. It fails
to mention Saimadhav Heblikar's important work during GSoC 2014 as well as
Terry J. Reedy's tireless work over the past few years which has helped keep
Tal Einat added the comment:
It seems to me that this would follow the same argument as in issue #18111: The
real issue is that there's no good way to check if an arbitrary iterable is
empty, unlike with sequences. Currently, callers need to wrap with try/except
to handle empty iter
Change by Tal Einat :
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue34732>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
The uuid module is likely used on a huge variety of operating systems and
hardware; I feel making UUID.__init__() reject values which it accepted until
now would unnecessarily break existing code. While raising an exception in
__init__ seems more natural and
Tal Einat added the comment:
Simply removing the argument would be backwards-incompatible.
Unless someone can show via a code search that this is never used in practice,
we may want to consider deprecating this argument before removing it.
--
nosy: +taleinat
versions: +Python 3.9
Tal Einat added the comment:
New changeset c33bdbb20cf55b3a2aa7a91bd3d91fcb59796fad by idomic in branch
'master':
bpo-37970: update and improve urlparse and urlsplit doc-strings (GH-16458)
https://github.com/python/cpython/commit/c33bdbb20cf55b3a2aa7a91bd3d91fcb59796fad
-
Tal Einat added the comment:
Ido Michael's PR GH-16458, which I've just merged, addresses the issues brought
up here regarding the doc-strings.
>From the discussion it seems that the documentation of these functions should
>be updated as well. I'll leave this issue open
Tal Einat added the comment:
Good catch, Stefen!
This seems like we forgot to update multiprocessing.get_all_start_methods()
when making the change to make "spawn" the default on macOS. I suggest updating
it accordingly.
--
keywords: +newcomer friendly
nosy: +tale
Tal Einat added the comment:
Please do, Ananthakrishnan!
--
___
Python tracker
<https://bugs.python.org/issue6083>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
New changeset d4331c56b4f6fe6f18caf19fc1ecf9fec14f7066 by alclarks in branch
'master':
bpo-9495: avoid confusing chained exception in argparse test (GH-17120)
https://github.com/python/cpython/commit/d4331c56b4f6fe6f18caf19fc1ecf9fec14f7066
-
Tal Einat added the comment:
Thanks for the PR, Alex!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.3, Python 3.4
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
I'm not convinced there is enough real need for this to justify implementing
and supporting it.
Using shared memory wouldn't be possible with built-in Python objects; one
would have to use a special-purpose library for this, or perhaps use something
l
Tal Einat added the comment:
Thanks for the fix, Ido!
--
nosy: +taleinat
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
I tend to think that we should avoid discrepancies with a simple Python
command-line shell by default, and in this case I am not convinced that there
is a good reason for a divergence in behavior.
I'd be happy to look into debugging this issue in the nex
Tal Einat added the comment:
Indeed.
--
___
Python tracker
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue39330>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Your fix LGTM, Victor.
--
___
Python tracker
<https://bugs.python.org/issue28009>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
It seems that select() does indeed support arbitrary iterables through the use
of PySequence_Fast().
The commit where this was introduced, by Brett Cannon from 2003
(62dba4c2775adfb5a5a97ca012a3ab00c4e28597), doesn't seems to have intended this
t
Tal Einat added the comment:
Saaheer, could you please run IDLE by opening a command window (Run -> cmd.exe)
or PowerShell, then running `python -m idlelib`? Then when this happens, please
check the command / PowerShell window to see whether an error message and/or
traceback has appea
Tal Einat added the comment:
Looks pretty good to me. I've been working on IDLE since... 2003/2004,
beginning with a private fork of IDLE-fork. I began actually contributing to
the main CPython version of IDLE in 2005.
--
___
Python tr
Tal Einat added the comment:
Saaheer, it seems like you have things from older versions of IDLE in your IDLE
config file (in your .idlerc directory). Specifically, the built-in extensions
have all been converted to be integral parts of IDLE, and must be removed from
your configuration file
Tal Einat added the comment:
It seems pretty clear to me that we should simply update the docs as suggested.
If nobody chimes in about this within a week, I intend to merge the PR
(GH-16832) with the small fixes I've suggested
Change by Tal Einat :
--
nosy: -taleinat
___
Python tracker
<https://bugs.python.org/issue40383>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset b809717c1ead26b4e3693b8a5505dd8f8f666f08 by Tzanetos Balitsaris
in branch 'master':
bpo-40331: Increase test coverage for the statistics module (GH-19608)
https://github.com/python/cpython/commit/b809717c1ead26b4e3693b8a5505dd
Tal Einat added the comment:
Tzanetos, thanks for the report, PR, patience iterating through several rounds
of code review comments, and overall great work!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
_
Tal Einat added the comment:
Steven, the conversation happened in the GitHub PR comments. The PR went
through multiple iterations of code review, by both Kyle Stanley and myself,
and I even waited an extra couple of weeks to see if anyone had any more
comments before merging it...
Perhaps
Tal Einat added the comment:
I can reproduce this behavior on macOS as well, so this doesn't seem to be
Windows-specific.
This does not happen with other apps in general, so it is not normal behavior
for apps.
Testing with a minimal tkinter app (see code below) gives similar behavio
Tal Einat added the comment:
I closed the PR but IMO this issue should remain open.
I am changing the title, though, since this is not actually Windows-specific.
--
___
Python tracker
<https://bugs.python.org/issue40
Change by Tal Einat :
--
stage: resolved -> needs patch
status: closed -> open
title: IDLE: preserve clipboard on closure on Windows -> IDLE: preserve
clipboard on closure
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 6e1eec71f59c344fb23c7977061dc2c97b77d51b by Irit Katriel in
branch 'master':
bpo-42116: Fix inspect.getsource handling of trailing comments (GH-23630)
https://github.com/python/cpython/commit/6e1eec71f59c344fb23c7977061dc2
Tal Einat added the comment:
Thank you for reporting this, Noureddine Hamid!
Thanks for the PR, Irit!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 2e0760bb2edb595050aff82f236cd32b44d3dfb3 by Irit Katriel in
branch 'master':
bpo-17735: inspect.findsource now raises OSError when co_lineno is out of range
(GH-23633)
https://github.com/python/cpyt
Tal Einat added the comment:
New changeset d1f07419c7560ed3ba52ba4f667f4eec9b5fe95d by Miss Islington (bot)
in branch '3.9':
bpo-17735: inspect.findsource now raises OSError when co_lineno is out of range
(GH-23633)
https://github.com/python/cpyt
Tal Einat added the comment:
Thanks for reporting this, Kyle!
Thanks for the PR, Irit!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg382632
___
Python tracker
<https://bugs.python.org/issue40452>
___
___
Python-bugs-list m
Tal Einat added the comment:
New changeset 069560b1171eb6385121ff3b6331e8814a4e7454 by Irit Katriel in
branch 'master':
bpo-34463: Make python tracebacks identical to C tracebacks for SyntaxErrors
without a lineno (GH-23427)
https://github.com/python/cpyt
Change by Tal Einat :
--
keywords: +newcomer friendly
___
Python tracker
<https://bugs.python.org/issue43075>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Looking into this further, this seems to be an issue in tkinter rather than
with tcl/tk. Running `wish a.tcl` with the following simple script does leave
its text in the clipboard:
pack [text .t]
.t insert 1.0 "Test text"
clipboard clear
clipboard app
Tal Einat added the comment:
Note that Tcl/Tk once had exactly the same issue on Windows, and they added
specific code to "render" to the clipboard upon exit if the current app is the
"clipboard owner".
https://core.tcl-lang.org/tk/tktview/732662
This was fixed her
Tal Einat added the comment:
Indeed, you've got that pretty much correct. The call chain is:
Tk.__init__
_tkinter_create_impl (called as _tkinter.create() from Python)
Tkapp_New
Tkapp_New does a lot of things. In particular, it calls Tcl_CreateInterp and
later Tcl_AppInit. Tcl_Ap
Tal Einat added the comment:
During finalization, TkFinalizeThread would call DeleteWindowsExitProc
(registered via TkCreateThreadExitHandler). This in turn is set as a
thread-exit handler via Tcl_CreateThreadExitHandler upon the first call to
TkCreateThreadExitHandler.
Now we're out
Tal Einat added the comment:
Indeed, adding a simple _tkinter.destroy() method which invokes Tcl_Finalize,
and calling it in the Tk.destroy() method, makes copied text remain available
after closing IDLE!
I did the above to test my hypothesis, but I'm not sure it would be a proper
Tal Einat added the comment:
epaine, if you'd like to create a new PR based on these findings, I'd be happy
to review it!
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
Regarding multiple Tk instances, IMO we should try the straightforward solution
first: Tcl/Tk has its own mechanisms for handling per-interpreter state, so we
may not actually need to handle any of this ourselves.
Regarding the title of this issue, it is indeed
Tal Einat added the comment:
Attaching the changes I made while testing as a patch file.
--
Added file: https://bugs.python.org/file49173/tkinter-clipboard-on-exit.patch
___
Python tracker
<https://bugs.python.org/issue40
Tal Einat added the comment:
New changeset 372ee27d4958302dac7ad6a8711f6fd04771b2e6 by Jakub Stasiak in
branch 'master':
bpo-38580: Document that select() accepts iterables, not just sequences
(GH-16832)
https://github.com/python/cpython/commit/372ee27d4958302dac7ad6a8711f6f
Tal Einat added the comment:
Nothing further is required; I've merged the PR. Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10
___
Python tracker
<https://bugs.pyth
Tal Einat added the comment:
This seems to simply be a misunderstanding: urlunparse() and urlunsplit()
intentionally do not do any encoding of their components.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
_
Change by Tal Einat :
--
pull_requests: +19682
pull_request: https://github.com/python/cpython/pull/20424
___
Python tracker
<https://bugs.python.org/issue38
Change by Tal Einat :
--
pull_requests: +19684
pull_request: https://github.com/python/cpython/pull/20426
___
Python tracker
<https://bugs.python.org/issue38
Tal Einat added the comment:
New changeset 3f215f35bdb9d666f5a692fc60f800da1bb1e4a9 by Tal Einat in branch
'3.7':
[3.7] bpo-38580: Document that select() accepts iterables, not just sequences
(GH-16832)
https://github.com/python/cpython/commit/3f215f35bdb9d666f5a692fc60f800
Tal Einat added the comment:
New changeset e3e800f3d28881cc9de38cd9bcbcf8fbdea238a6 by Tal Einat in branch
'3.8':
[3.8] bpo-38580: Document that select() accepts iterables, not just sequences
(GH-16832)
https://github.com/python/cpython/commit/e3e800f3d28881cc9de38cd9bcbcf8
Change by Tal Einat :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue39244>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset db098bc1f05bd0773943e59f83489f05f28dedf8 by idomic in branch
'master':
bpo-39244: multiprocessing return default start method first on macOS (GH-18625)
https://github.com/python/cpython/commit/db098bc1f05bd0773943e59f83489f
Tal Einat added the comment:
Thanks for fixing this, Ido!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
This seems to be at least partly intentional: When waiting for user input, IDLE
starts a nested Tk mainloop (!), which is stopped by the end-of-line handler.
It seems to me that this is what is causing displaying other outputs to be
delayed
Tal Einat added the comment:
Can someone talk about the reasoning behind the nested Tk mainloop? I haven't
managed to find anything useful in code comments and such. Guido?
--
___
Python tracker
<https://bugs.python.org/is
Change by Tal Einat :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue37824>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Sorry this hasn't been followed up. I think this would best be discussed a bit
on the Python-Ideas mailing list. Please send an email there suggesting this
feature, and link to the discussion thread in the mailing list archives
Tal Einat added the comment:
I agree that the line numbers should be less prominent.
Terry, why not change the the default? ISTM we should strive to have good
default colors, they are what most users use and see.
I also think we should improve the dark theme, but that's a separate
Tal Einat added the comment:
I'm -1 on making this change. Frankly, I think there are many better modern
alternatives to ConfigParser, and I think we should avoid complicating it any
further.
--
nosy: +taleinat
___
Python tracker
&
Tal Einat added the comment:
AFAICT from following the discussion, the decision is to hold off on a few
deprecations which were causing most of the breakage. However, this does not
appear to include xml.etree.cElementTree. Since that has currently been removed
in the 3.9 branch, we should
Tal Einat added the comment:
(Also, please note that the "master" branch is now for version 3.10; PRs for
version 3.9 should be based on the "3.9" branch, and the pull request made for
that branch too.)
--
___
Py
Tal Einat added the comment:
(My mistake! This should be done from/against the master branch, and then
back-ported to 3.9, as usual.)
--
___
Python tracker
<https://bugs.python.org/issue40
Tal Einat added the comment:
Ah, thanks for the update Christian, I must have misunderstood your intentions.
So should the deprecation note be removed in the "master" branch for 3.10?
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
Terry, kudos for getting back to this!
Let me make a PR for this, it will make reviewing and testing easier.
--
___
Python tracker
<https://bugs.python.org/issue21
Tal Einat added the comment:
> You solution is to add a new parameter to __init__ only used by 'flash'. I
> would rather replace 'mustclose' with mode = 'tip', 'flash', or 'close'. I
> believe that Stopatindex could be revised
Change by Tal Einat :
--
pull_requests: +19955
pull_request: https://github.com/python/cpython/pull/20753
___
Python tracker
<https://bugs.python.org/issue21
Tal Einat added the comment:
I've created a PR against current master based on the patch, see GH-20753.
--
___
Python tracker
<https://bugs.python.org/is
Change by Tal Einat :
--
components: -Library (Lib)
___
Python tracker
<https://bugs.python.org/issue19670>
___
___
Python-bugs-list mailing list
Unsubscribe:
301 - 400 of 1452 matches
Mail list logo
