Steve Dower added the comment:
New PR:
https://bitbucket.org/larry/cpython350/pull-requests/19/issue-24917-time_strftime-buffer-over-read
--
___
Python tracker
<http://bugs.python.org/issue24
Steve Dower added the comment:
I wasn't able to repro the crash at all, even with the debugging flags that
make this sort of issue more prominent. It relies on a very precise layout of
multiple objects in memory, or possibly a specific sequence of
allocations/deallocations, as well
Steve Dower added the comment:
Good enough for me.
--
___
Python tracker
<http://bugs.python.org/issue24917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
subprocess with shell=True turns it into a "cmd.exe /C "start chrome.exe ...""
type command, which means the arguments will use shell parsing (e.g. > for
redirection, & for multiple commands, etc.)
"start" in cmd.exe beha
Steve Dower added the comment:
To be more specific, with patch 1 applied:
subprocess.call("start file a&b>x", shell=True)
is equivalent to typing the following at a command prompt:
start file a & b > x
That is, "start file a" and then do "b", redi
Steve Dower added the comment:
Oh, and the "start" is necessary because, while the Windows kernel can only
resolve "chrome.exe" if it appears on PATH, the Windows shell has some other
ways to resolve it.
By using ShellExecute (via 'start' or startfile), we can l
Steve Dower added the comment:
Correct.
os.startfile uses ShellExecute
(https://msdn.microsoft.com/en-us/library/windows/desktop/bb762153.aspx), which
is the same API that the shell uses for the 'start' command. So by using
os.startfile we get the same behaviour, but we're c
Steve Dower added the comment:
Rollback.
I'm not 100% confident in patch 1 (too many things I can't predict) and with
only a week it probably won't get enough testing to flush out other surprises.
--
___
Python tracker
<http
Steve Dower added the comment:
I guess now I've been that definitive I'll go make you a PR :)
If someone (perhaps Brandon?) is willing to thoroughly validate patch 1 we
might be able to consider it for 3.5.1 (the only API change is to startfile() -
the webbrowser API is already ther
Steve Dower added the comment:
PR is:
https://bitbucket.org/larry/cpython350/pull-requests/20/issue-25005-backout-fix-for-8232-because/diff
--
___
Python tracker
<http://bugs.python.org/issue25
Steve Dower added the comment:
Here's an alternate patch I proposed on #25005 before we decided to back out
the change.
The problem is that subprocess.call() with shell=True is unsafe because we
don't escape shell operators (such as &, <, >, |).
The fix in this patch
Steve Dower added the comment:
Try doing:
hg up -r 4e329892817c1eed81aafd14e82b8ef23b45a6e6
hg import --no-commit http://bugs.python.org/file40384/25005_1.patch
That *should* apply it where I originally made it from. I'll do the same and
rebase the patch agains
Steve Dower added the comment:
New patch against 3.6.
--
Added file: http://bugs.python.org/file40393/8232_1.patch
___
Python tracker
<http://bugs.python.org/issue8
Steve Dower added the comment:
The C part of the patch adds an extra argument to startfile to accept the
arguments. You'll need to rebuild Python to test the change completely - it's
no longer just a pure Python change.
--
___
Python trac
Steve Dower added the comment:
Let me experiment today with a few of the proposals I posted in the other
thread and get back to you.
I suspect someone will need to ship vcruntime.dll, and I'd rather it was the
extension.
--
___
Python tr
Steve Dower added the comment:
Go for it.
--
___
Python tracker
<http://bugs.python.org/issue25022>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Sorry Larry.
I'll fix it.
--
assignee: -> steve.dower
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.
Steve Dower added the comment:
I'll fix it on #25029. This thread is already too long for my liking.
--
resolution: -> fixed
status: open -> closed
superseder: -> MemoryError in test_strptime
___
Python tracker
<http://bugs.pyth
Steve Dower added the comment:
Kind-of... We use the same flags I described in my blog[1] so that we don't
have any version-specific dependencies.
You should (might) see /MT in the build logs, but then we replace most of the
static CRT with the dynamic (but versionless) one. The vers
Steve Dower added the comment:
@eryksun - that's exactly what I've just done :)
Unfortunately, I don't have a _locale module, so I can't do Victor's test.
Attached my patch in case Victor is around to test it.
--
keywords: +patch
Added file: http://bugs.pyt
Steve Dower added the comment:
It shouldn't be - locale state is in the shared part of the CRT. That is one of
the reasons I was keen to move to this model (everyone seems to think that
FILE* is the only problem with mixing CRT ver
Steve Dower added the comment:
Attached a fix for distutils that will include the required vcruntime DLL with
the extension.
This is purely Python source code and only needs to be patched on the build
machine.
I have tested with a numpy build from source (setup.py bdist_wheel) and it
works
Steve Dower added the comment:
vcruntime140.dll *is* a system library when installed properly, and if someone
installs VCRedist then all the bundled ones should be ignored. Over time, I
expect to see extensions appear that depend on vcruntime150.dll rather than
140.dll, so it won't alwa
Steve Dower added the comment:
Thanks. I'll submit a PR for 3.5.0 later tonight - can't seem to clone Larry's
repo successfully at work for some reason.
--
___
Python tracker
<http://bugs.pyt
Steve Dower added the comment:
PR at
https://bitbucket.org/larry/cpython350/pull-requests/21/issue-25029-memoryerror-in-test_strptime/diff
--
___
Python tracker
<http://bugs.python.org/issue25
Steve Dower added the comment:
Okay, here's a proposal:
We bundle vcruntime140.dll with Python's normal install, so it's always there
and extensions that use it do not need to ship anything.
When distutils._msvccompiler is used to build an extension with a *different*
vers
Steve Dower added the comment:
New patch. Mostly build and installer changes, but the
distutils/_msvccompiler.py is also part of it.
I've run a full build and done basic testing with a full test run going now,
but I don't have a clean machine handy to try it without the full CRT in
Steve Dower added the comment:
Probably should, since the fix that caused it was in for rc3. There's no
section for 3.5.0 final yet though (that's my excuse, anyway :) )
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
FYI: we're making a new release (right now!) with the patch applied, that
should go out tomorrow.
If anyone spots anything important in the patch, I still really want to hear
about it, but hopefully having something installable means we'll get at le
Steve Dower added the comment:
Only thing I'd add is that the extra tag is optional (on Windows at least), and
Python will happily import extensions without it. But extensions with a
mismatched tag won't be loaded.
--
___
Python trac
Steve Dower added the comment:
It may be worth it. What I'd rather have people do is to install using the
regular installer and include both debug symbols and debug binaries. This will
put it in a registered location that can be auto detected (I have written a
template for Visual Studio
Steve Dower added the comment:
This is an issue with 3.4.3 only, and I suspect it was something funny in the
build config that should just work with 3.4.4 - adding Martin to make sure.
Basically, the upgrade code in the 32-bit installer was (I think) the code used
for dev snapshots. Both
Steve Dower added the comment:
Done.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
There's no dot before the debug marker on Windows. Otherwise, looks good to me.
Thanks for writing this up.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Steve Dower:
If you run the installer without UI and without specifying an installation
path, it will not install. For example:
C:\> python-3.5.0rc4-amd64-webinstall.exe /passive
The workaround is to specify TargetPath:
C:\> python-3.5.0rc4-amd64-webinstall.exe /p
Steve Dower added the comment:
Adding Larry, as this either needs a fix or a prominent release note for 3.5.0
(or we document the bug in the docs).
I *think* the fix will be fairly simple and constrained entire to one file.
Should have something ready later today.
--
nosy: +larry
Changes by Steve Dower :
--
nosy: +takluyver
___
Python tracker
<http://bugs.python.org/issue25071>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Patch attached.
PR for 3.5.0 at:
https://bitbucket.org/larry/cpython350/pull-requests/25/issue-25071-windows-installer-should-not/diff
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file40439/25071_1.pa
Steve Dower added the comment:
I hope so too :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Steve Dower:
If you already have Python 3.5.0b4 or later installed and you go to install a
later version, it starts with an "Upgrade" page.
If you hit customize from the page, then Back, you end up at the original
Install page. You should be at the Cust
Steve Dower added the comment:
I don't understand what you did and what the result was from that thread.
* What options did you select when installing 3.5?
* What other Python versions did you have? What options were used to install
them?
* Where was py.exe before installing 3.5?
* Ca
Steve Dower added the comment:
Yeah, it's basically impossible to manage PATH automatically. You've probably
installed 3.5 just for yourself while 3.4 is installed for all users. In this
case, 3.5 will always lose because Windows puts user paths after system paths.
You could mod
Steve Dower added the comment:
Thanks for pointing this out. I'll take a look before 3.5.1.
--
title: Please revert the Windows Installer swithch to micro type. -> Windows
Installer uses small font
___
Python tracker
<http://bugs
Steve Dower added the comment:
Actually, what DPI setting are you using? With new UI, it's possible that we're
not scaling the same way as before.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
Doesn't it? It's supposed to...
--
___
Python tracker
<http://bugs.python.org/issue25102>
___
___
Python-bugs-l
Steve Dower added the comment:
Maybe errno needs to be explicitly cleared before calling strftime or else
we're seeing someone else's EINVAL?
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
(In the C code I mean, not in the test.)
--
___
Python tracker
<http://bugs.python.org/issue25092>
___
___
Python-bugs-list mailin
Steve Dower added the comment:
Just the main log file from the initial install is enough if there's no log for
the launcher. It probably means the initial setup startup deselected it for
some reason.
--
___
Python tracker
<http://bugs.py
Steve Dower added the comment:
Yep, as part of the upgrade detection we're choosing not to install the
launcher. Not sure whether that's because of a bug or a previous install on
your machine, but I'll take a closer look.
--
assignee:
Steve Dower added the comment:
I guess when I said I'd done "exactly" what you suggested I misread that
part... whoops.
This is a pretty nasty bug to workaround... do we have any way for a user to
clear errno from their own code?
--
___
Steve Dower added the comment:
I get that part.
Is there a way people can set errno to zero from Python code? Or do we need to
ship 3.5.1 already?
--
___
Python tracker
<http://bugs.python.org/issue25
Steve Dower added the comment:
I'm not worried about preserving it - strftime is supposed to be a very thin
wrapper around the underlying strftime.
I think David's right and we'll be shipping 3.5.1 pretty soon regardless
(though a lot of the issues seem to be due to chang
Steve Dower added the comment:
Right, it's just doing the single pass.
You're proposing making a slow part of the install three times slower, correct?
Just to confirm :)
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
IIRC there's an existing issue for this. (Or it may have just been mentioned in
a "things that don't work when you're not root" list on an issue.)
--
___
Python tracker
<http:
Steve Dower added the comment:
That is indeed what happened. The resource file for the launcher was not
updated (or the update got lost... I was fairly sure I did it)
Attached patch fixes it.
--
assignee: -> steve.dower
keywords: +patch
stage: -> patch review
Added file
Changes by Steve Dower :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue24872>
___
___
Python-bugs-
Changes by Steve Dower :
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file40466/25102_1.patch
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
Patch attached. I haven't been able to repro the issue locally without the fix,
but it seems indisputably correct behavior.
We could also skip most of the function for an empty format string and save
ourselves a lot of work. That would avoid the ambi
Steve Dower added the comment:
(The fix is indisputably correct, is what I meant.)
--
___
Python tracker
<http://bugs.python.org/issue25092>
___
___
Python-bug
Steve Dower added the comment:
We don't check errno on any other platform.
--
___
Python tracker
<http://bugs.python.org/issue25092>
___
___
Python-bugs-l
Steve Dower added the comment:
Confirmed. I have a trivial fix coming to restore the requestedExecutionLevel.
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
The decision cannot reasonably be reversed now - this sort of passionate
feedback was really needed during the alphas to have any impact. I'm sorry you
didn't feel the need to participate in Python's development, as this extra
feedback would h
Steve Dower added the comment:
Arguably it's because of the platforms that don't reliably set errno. (I don't
know exactly which those are, but I'm not about to enable it everywhere right
now. If someone else wants to do it and deal with the fal
Changes by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue25092>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
If you could provide more information, that would be helpful.
In particular, there may be some entries in the Event Log around the time you
were trying to install 3.5, if nothing popped up at all. There may also be log
files in your %TEMP% directory
Steve Dower added the comment:
Good catch, none of the bdist_wininst command is really needed. I'll drop it.
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org
Changes by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue25085>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
True, those files aren't needed in the embeddable distro.
Terry - you're right, if someone chooses to install Tcl/Tk/idle then they'll
get the tests for them as well, regardless of their test suite selection. Since
we're not really talking
Steve Dower added the comment:
Yeah, this was just me forgetting to enable eol when I last recreated my build
machine. It's on now, so the next release will be fine.
--
resolution: -> not a bug
status: open -> closed
___
Python tra
Steve Dower added the comment:
The file associations are actually part of the launcher, which *technically* is
independent of the Python install it is bundled with. So it doesn't have any
references to the Python install directory, and double-clicking Python files
with shebang lines will
Steve Dower added the comment:
Yeah, changing the item description is a good suggestion.
It basically doubles the size of the download to include everything all at once.
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.pyth
Steve Dower added the comment:
It was changed to be consistent with the PEP 397 launcher (and the launcher was
actually updated to match the registry key directly, rather than special-casing
the "-32" suffix).
The original naming ("3.5") can't be used because you can&
Changes by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue25081>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue25125>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
Can you try executing the following command (fix the paths as necessary, but
leave all the quotes where they are):
"C:\Program Files (x86)\Python 3.5\python.exe" -m idlelib "C:\test.py"
That's what should be launched by the menu, w
Steve Dower added the comment:
Done. As this is (meant to be) a purely informational/diagnostic module, seems
like a good idea to fix every version we're supporting in any way.
--
assignee: -> steve.dower
resolution: -> fixed
stage: -> resolved
status: open
Steve Dower added the comment:
The problem here is probably that installing the CRT update required a restart
(see the line below from the log), but we didn't interrupt installation to make
you restart before continuing.
>From the first log file:
[0A68:0EC8][2015-09-14T05:54:24]i319:
Steve Dower added the comment:
Well, I made this happen once, but not a second time. That's better than most
setup issues I get to deal with :)
Still working on it - will post when I figure it out.
--
assignee: -> steve.dower
___
Python
Steve Dower added the comment:
I don't have any XP machines handy, but I'll see if I can at least get an early
termination from the installer rather than broken UI.
IIRC, Larry was against having prominent warnings about unsupported platforms
on the download page, but with python
Steve Dower added the comment:
I'm going to look into having the launcher's MSI stay behind when the bundle is
removed, so it will have to be uninstalled separately. It can already be
installed separately, though there isn't a really easy way to get the installer
so you can do
Steve Dower added the comment:
This is caused by the same configuration as issue 25166, so I'm closing this
one as a duplicate.
--
resolution: -> duplicate
status: open -> closed
superseder: -> Windows AllUsers installation places uninstaller i
Steve Dower added the comment:
Just an incorrect variable reference in the localization file. Should be easy
enough to fix (if the variable is initialized at the start of installation...)
--
assignee: -> steve.dower
___
Python tracker
&l
Steve Dower added the comment:
Might be too much of a breaking change for 3.5.1 - what do the other Windows
guys think about making them both "Python 3.5" (or "Python 3.5-32" in the
per-user case, to avoid conflicting w
Steve Dower added the comment:
Burn is always started in the per-user scope so that we can do per-user
installs without elevating, but it looks like we need to manually change this
once we know it's an all-users install.
--
assignee: -> ste
Changes by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Steve Dower :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
Did you check the checkbox on the front page?
The checkbox that says "Install launcher for all users" only installs the
launcher for all users, which is recommended for compatibility with Python 3.4
or 2.7 (which would otherwise override the launche
Changes by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25213>
___
Changes by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25081>
___
Changes by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25086>
___
Changes by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25126>
___
Steve Dower added the comment:
The change is for two issues. I now filter out "Lib\*\test" and "Lib\*\tests"
for this one, and bdist_wininst.py and *.exe for #25086. I believe that's what
the suggestions were - the regular installer (that we've been discus
Steve Dower added the comment:
Windows Updates may do something different here. I'd guess it's added to a
queue and will be installed on next restart, probably based on something it
detected as being in use, or maybe just because it's a server OS (or possibly
both - typically
Steve Dower added the comment:
Not sure yet :)
There are a lot of undocumented (or not-yet-documented) APIs accessible from
the bootstrap app and I haven't gone through them yet - see
https://github.com/wixtoolset/wix3/tree/develop/src/libs, probably dutil.
It may also be something th
Steve Dower added the comment:
None of them are statically linked, and we looked into that for 3.5 and it had
other issues, so we went fully dynamically linked.
This is either an issue specific to your machine, or a Vista issue (we didn't
get a lot of testing done on Vista).
Installin
Steve Dower added the comment:
Good question on the extra "Python" directory - I don't recall exactly why that
was there, but I suspect it was for consistency with something - probably
{userbase} from sysconfig.
Also, thanks for catching the user scheme difference. We shou
Steve Dower added the comment:
msvcr140.dll does not exist and was never released. I'm not sure what you've
installed, but it seems to be the wrong thing.
I'm familiar with the compiler options and we are using the correct ones. If
you want to change them, you should build you
Steve Dower added the comment:
In your original post you refer to the "famous
api-ms-win-crt-runtime-l1-1-0.dll problem" - I am not aware of this problem, so
you will need to provide more context on what is actually not working for you.
Dependency Walker doesn't know how to res
Steve Dower added the comment:
Ah, I misread that part. Will have to look deeper, but I'm not actually sure
that shortcuts are supposed to support the same operations (though if it shows
up, I guess it should work).
--
___
Python tracker
5001 - 5100 of 5794 matches
Mail list logo
