[issue38089] Make macOS tests optional on Azure Pipelines

2019-09-10 Thread Steve Dower
Steve Dower added the comment: New changeset cdce233f61349d029640b2dd2c0403e502050e39 by Steve Dower (Miss Islington (bot)) in branch '3.8': bpo-38089: Move Azure Pipelines to latest VM versions and make macOS tests optional (GH-15851) https://github.com/python/cpyt

[issue37574] Mention spec_from_loader() in Finder.find_spec() docs.

2019-09-10 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-10 Thread Steve Dower
Steve Dower added the comment: What does pip use it for? Applying the below change avoids the exception, but produces \\.\nul as the result, which may or may not be any better. diff --git a/Lib/ntpath.py b/Lib/ntpath.py index 1d22d5f1dc..becfa20a83 100644 --- a/Lib/ntpath.py +++ b/Lib

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-10 Thread Steve Dower
Change by Steve Dower : -- nosy: +eryksun ___ Python tracker <https://bugs.python.org/issue38081> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38089] Make macOS tests optional on Azure Pipelines

2019-09-10 Thread Steve Dower
Steve Dower added the comment: New changeset 6a494e77fc20543dcc33c1299b46ee6433d80019 by Steve Dower in branch '3.7': bpo-38089: Move Azure Pipelines to latest VM versions and make macOS tests optional (GH-15851) https://github.com/python/cpyt

[issue38089] Make macOS tests optional on Azure Pipelines

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15540 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15899 ___ Python tracker <https://bugs.python.org/issu

[issue37993] os.path.realpath on Windows resolves mapped network drives

2019-09-11 Thread Steve Dower
Steve Dower added the comment: I'm closing this as not a bug. It's a few steps deep, but DefineDosDeviceW() [1] specifies that it creates junctions, and while it's not necessarily obvious how to get from SUBST to that page, Wikipedia managed it [2]. And I don't think

[issue37445] Some FormatMessageW() calls use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS

2019-09-11 Thread Steve Dower
Steve Dower added the comment: Thanks, Zackery! -- ___ Python tracker <https://bugs.python.org/issue37445> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37445] Some FormatMessageW() calls use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS

2019-09-11 Thread Steve Dower
Steve Dower added the comment: New changeset 289c5ea7737e44e3b150532b3498e3d3d4c70d99 by Steve Dower (Zackery Spytz) in branch '2.7': bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls (GH-15822) https://github.com/python/cpyt

[issue10466] locale.py resetlocale throws exception on Windows (getdefaultlocale returns value not usable in setlocale)

2019-09-11 Thread Steve Dower
Steve Dower added the comment: issue37945 is a duplicate and has more up-to-date information on it, so I'm going to close this one even though it's older. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -&g

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-11 Thread Steve Dower
Steve Dower added the comment: Thanks for the report! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37945] test_locale failing

2019-09-11 Thread Steve Dower
Steve Dower added the comment: FYI I just closed issue10466 as a duplicate (even though that one's been around longer, this issue has more relevant information on it). -- ___ Python tracker <https://bugs.python.org/is

[issue37769] Windows Store installer should warn user about MAX_PATH

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +1 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15914 ___ Python tracker <https://bugs.python.org/issu

[issue37769] Windows Store installer should warn user about MAX_PATH

2019-09-11 Thread Steve Dower
Steve Dower added the comment: I don't know that it's a great idea, but I did PR 15914 just to see how an additional message on OSError would look. -- stage: patch review -> ___ Python tracker <https://bugs.pytho

[issue36518] Avoid conflicts when pass arbitrary keyword arguments to Python function

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37326] Windows LICENSE.txt do not contain libffi license

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15562 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15921 ___ Python tracker <https://bugs.python.org/issu

[issue37326] Windows LICENSE.txt do not contain libffi license

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issu

[issue33010] os.path.isdir() returns True for broken directory symlinks or junctions

2019-09-11 Thread Steve Dower
Steve Dower added the comment: Fixed in 3.8 by changes to os.stat implementation. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36862] Add Visual Studio 2019 support to PCBuild/env.bat

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36862> ___ ___

[issue36672] A compiler warning in winreg.SetValue()

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue36634> ___ ___ Python-

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15564 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15924 ___ Python tracker <https://bugs.python.org/issu

[issue37326] Windows LICENSE.txt do not contain libffi license

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36315] Unable to install Python 3.7.2

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36315> ___ ___

[issue16296] Patch to fix building on Win32/64 under VS 2010

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue9782] _multiprocessing.c warnings under 64-bit Windows

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue9784] _msi.c warnings under 64-bit Windows

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue1559298] test_popen fails on Windows if installed to "Program Files"

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/

[issue14094] ntpath.realpath() should use GetFinalPathNameByHandle()

2019-09-11 Thread Steve Dower
Steve Dower added the comment: As of 3.8, it (sort of) does. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35898] The TARGETDIR variable must be provided when invoking this installer

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35898> ___ ___

[issue35705] libffi support is not there for windows on ARM64

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35981] shutil make_archive create wrong file when base name contains dots at end

2019-09-11 Thread Steve Dower
Steve Dower added the comment: We can fix this - trailing dots before an extension are supported. Probably the best fix is to defer the "abspath" call until after the extension has been added (or apply "abspath" to the directory and then put the base name back on).

[issue33166] os.cpu_count() returns wrong number of processors on specific systems

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15584 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15949 ___ Python tracker <https://bugs.python.org/issu

[issue32592] Drop support of Windows Vista in Python 3.8

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15586 pull_request: https://github.com/python/cpython/pull/15951 ___ Python tracker <https://bugs.python.org/issue32

[issue33166] os.cpu_count() returns wrong number of processors on specific systems

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- versions: +Python 3.9 -Python 3.7 ___ Python tracker <https://bugs.python.org/issue33166> ___ ___ Python-bugs-list mailing list Unsub

[issue32592] Drop support of Windows Vista and 7 in Python 3.9

2019-09-11 Thread Steve Dower
Steve Dower added the comment: I'll at least make a start by updating the minimum API version. -- title: Drop support of Windows Vista in Python 3.8 -> Drop support of Windows Vista and 7 in Python 3.9 versions: +Python 3.9 -Python 3.8 __

[issue38114] Exclude pip.ini from Nuget package

2019-09-11 Thread Steve Dower
New submission from Steve Dower : The pip.ini intended for store packages is being included in the nuget package. We should not do that. -- assignee: steve.dower components: Windows keywords: 3.8regression messages: 351900 nosy: paul.moore, steve.dower, tim.golden, zach.ware priority

[issue38114] Exclude pip.ini from Nuget package

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15597 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15964 ___ Python tracker <https://bugs.python.org/issu

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35592] Not able to use Python 3.7.2 due to SSL issue

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35592> ___ ___

[issue35795] test_pkgutil test_zipapp fail in AMD64 Windows7 SP1 3.x and AMD64 Windows7 SP1 3.7 buildbots

2019-09-11 Thread Steve Dower
Steve Dower added the comment: Have we seen this recently? Should we just close this? -- ___ Python tracker <https://bugs.python.org/issue35795> ___ ___ Pytho

[issue35253] Linker warning LNK4281

2019-09-11 Thread Steve Dower
Steve Dower added the comment: I don't remember exactly when, but this is fixed. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.pyth

[issue38114] Exclude pip.ini from Nuget package

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- assignee: steve.dower -> stage: resolved -> needs patch versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/i

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
New submission from Steve Dower : The py.exe launcher cannot locate installations from the Store (unless you have no other installations on your machine, which is unlikely). -- assignee: steve.dower components: Windows messages: 352107 nosy: paul.moore, steve.dower, tim.golden

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15648 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16025 ___ Python tracker <https://bugs.python.org/issu

[issue37609] support "UNC" device paths in ntpath.splitdrive

2019-09-12 Thread Steve Dower
Steve Dower added the comment: For clarity, given Eryk's examples above, both "\\?\UNC\" and "//?/UNC/" are okay (as are any combination of forward and backslashes in the prefix, as normalization will be applied for any except the "\\?\" versio

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
Steve Dower added the comment: I added an "exe_display" override for listing paths, since the full path to the store app is not supposed to be used by users (it's different from sys.executable) and is only going to work when the shorter name is on PATH anyway (due to a limita

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
Steve Dower added the comment: Sample output after this change (some paths elided): Installed Pythons found by ...\py.exe Launcher for Windows (venv) C:\...\env\Scripts\python.exe * -3.8-64python3.8.exe -3.7-32-32 C:\Python37_x86\python.exe -3.7-64C

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
Steve Dower added the comment: Ah, good catch, I didn't notice that. Because those are special cases, we should strip it off the version string. One day when we implement PEP 514 properly then they'll come back (and we'll probably drop the -64 suffix for consisten

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
Steve Dower added the comment: New changeset ed93a8852d120c5a3606720edc723bf5aa6a1fc2 by Steve Dower in branch 'master': bpo-38133: Allow py.exe launcher to locate installations from the Microsoft Store (GH-16025) https://github.com/python/cpyt

[issue38133] py.exe cannot locate Store package

2019-09-12 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38149] sys.audit() is called multiple times for glob.glob()

2019-09-13 Thread Steve Dower
Change by Steve Dower : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue38149> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38149] sys.audit() is called multiple times for glob.glob()

2019-09-13 Thread Steve Dower
Steve Dower added the comment: Provided it's called with different arguments each time (which it is), there isn't a problem here. Audit hooks are supposed to be informative, not definitive (that is, you almost always need to take the surrounding context into consideration, which i

[issue38149] sys.audit() is called multiple times for glob.glob()

2019-09-13 Thread Steve Dower
Steve Dower added the comment: > when added sys.audit() for glob.glob(), should not it be added for > Path.glob() too? And for os.walk()? Sure, those would make sense. They all go via scandir() which has its own event too (and will do for each directory), but being able to see that i

[issue38098] Special Characters Don't Work When Using Virtual Environment

2019-09-13 Thread Steve Dower
Change by Steve Dower : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue38

[issue38098] Special Characters Don't Work When Using Virtual Environment

2019-09-13 Thread Steve Dower
Steve Dower added the comment: Thanks Spandan This doesn't reproduce trivially for me, so I suspect there is some difference in the venv. Could you run "pip list" in both the venv and with it deactivated and share the output? There are some packages that modify how cons

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

2019-09-13 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15718 pull_request: https://github.com/python/cpython/pull/16098 ___ Python tracker <https://bugs.python.org/issue38

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

2019-09-13 Thread Steve Dower
Steve Dower added the comment: I posted a second PR with the rest of the change, as it'd be good to get this in before the next 3.8 release. -- versions: -Python 3.7 ___ Python tracker <https://bugs.python.org/is

[issue38092] environment variables not passed correctly using new virtualenv launching in windows and python3.7+

2019-09-13 Thread Steve Dower
Steve Dower added the comment: Thanks for the report and partial patch! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-15 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15766 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16156 ___ Python tracker <https://bugs.python.org/issu

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-15 Thread Steve Dower
Steve Dower added the comment: I added another PR with the additional error codes listed by Eryk Sun. Theoretically we should be able to test most of them, but I haven't written those tests, and I'm not sure they'd prove enough to be worth the extra code. ntpath.realpath is

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15788 pull_request: https://github.com/python/cpython/pull/16178 ___ Python tracker <https://bugs.python.org/issue38

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Steve Dower added the comment: I've published the sources and binaries for Windows - will get to updating the 3.9/3.8/3.7 branches later today unless someone else does first (should just require version number changes). -- ___ Python tr

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Steve Dower added the comment: New changeset d8903416d223d01e23dfa8bffe48b1428d90d202 by Steve Dower in branch '2.7': bpo-38117: Updates bundled OpenSSL to 1.0.2t (GH-16178) https://github.com/python/cpython/commit/d8903416d223d01e23dfa8bffe48b1

[issue38186] Use FindFirstFile in ntpath.realpath() when access is denied

2019-09-16 Thread Steve Dower
New submission from Steve Dower : There remains a case in ntpath.realpath() where a (handled) ERROR_ACCESS_DENIED or ERROR_SHARING_VIOLATION will break out of traversing a series of paths. However, in this case (in os.stat(), for example), we could request the real name of the file from the

[issue38186] Use FindFirstFile in ntpath.realpath() when access is denied

2019-09-16 Thread Steve Dower
Steve Dower added the comment: See issue38081 and PR 16156 for related discussion and changes. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15792 pull_request: https://github.com/python/cpython/pull/16184 ___ Python tracker <https://bugs.python.org/issue38

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Steve Dower added the comment: New changeset 3ab73f6bbf4ff66e7ace3c4eab25461b5c7d71d4 by Steve Dower in branch 'master': bpo-38117: Update bundled Windows OpenSSL to 1.1.1d (GH-16184) https://github.com/python/cpython/commit/3ab73f6bbf4ff66e7ace3c4eab2546

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15794 pull_request: https://github.com/python/cpython/pull/16186 ___ Python tracker <https://bugs.python.org/issue38

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-16 Thread Steve Dower
Steve Dower added the comment: New changeset 89b8933bb537179f81003928786c5cc6183af591 by Steve Dower in branch 'master': bpo-38081: Add more non-fatal error codes for ntpath.realpath (GH-16156) https://github.com/python/cpython/commit/89b8933bb537179f81003928786c5c

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

2019-09-16 Thread Steve Dower
Change by Steve Dower : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue38081> ___ ___ Pyth

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Steve Dower added the comment: New changeset 76d8fb771659a5574604bf78eb2ee090f5c337cc by Steve Dower in branch '3.7': bpo-38117: Update bundled Windows OpenSSL to 1.1.1d (GH-16184) https://github.com/python/cpython/commit/76d8fb771659a5574604bf78eb2ee0

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

2019-09-16 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38224] Windows embeddable distribution doesn't ship headers

2019-09-19 Thread Steve Dower
Steve Dower added the comment: The embeddable distro is meant to be a "redistributable" for end-user machines, rather than a development kit. "Build" and "distribution" are two clearly separated tasks (at least on Windows), and so they have different dependencie

[issue38239] test_gdb fails on AMD64 Fedora Stable LTO 3.8 and AMD64 RHEL8 LTO 3.x: Unexpected gdb output

2019-09-21 Thread Steve Dower
Steve Dower added the comment: Shouldn't this test be suppressed on LTO builds? #0 builtin_id (self=, v=) at Objects/longobject.c:1113 builtid_id isn't in longobject.c, so this is incorrect debug information. The test expects to find it in bltinmodule.c: re.match(r'.*#0

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Steve Dower
Steve Dower added the comment: Closing as a duplicate of issue35941 -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> ssl.enum_certificates() regression ___ Python tracker <https://bugs.python

[issue38239] test_gdb fails on AMD64 Fedora Stable LTO 3.8 and AMD64 RHEL8 LTO 3.x: Unexpected gdb output

2019-09-23 Thread Steve Dower
Steve Dower added the comment: Greg seems to have done LTO related things in the past, maybe he knows? (All my PGO contributions only apply to Windows :) ) -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38

[issue38234] The value of Py_SetPath is not used to populate the configuration

2019-09-23 Thread Steve Dower
Steve Dower added the comment: Why are we keeping the DLL path around at all? It should only be being used in 1-2 places during path calculation. -- nosy: +steve.dower ___ Python tracker <https://bugs.python.org/issue38

[issue38234] The value of Py_SetPath is not used to populate the configuration

2019-09-23 Thread Steve Dower
Steve Dower added the comment: > _PyPathConfig_Init() initializes _Py_dll_path global variable which is only > used by _Py_CheckPython3(). Ah okay, maybe I'll take the time later on (in a separate issue) to get rid of it fully. We may as well load python3.dll at startup anywa

[issue36632] test_multiprocessing_forkserver: test_rapid_restart() leaked a dangling process on AMD64 FreeBSD 10-STABLE Non-Debug 3.x

2019-09-24 Thread Steve Dower
Steve Dower added the comment: Hey Davin - could this be related to the new tests/restart support we added at the sprints? -- nosy: +davin, steve.dower ___ Python tracker <https://bugs.python.org/issue36

[issue38239] test_gdb fails on AMD64 Fedora Stable LTO 3.8 and AMD64 RHEL8 LTO 3.x: Unexpected gdb output

2019-09-24 Thread Steve Dower
Steve Dower added the comment: Um, okay then. The test already includes this: if ((sysconfig.get_config_var('PGO_PROF_USE_FLAG') or 'xxx') in (sysconfig.get_config_var('PY_CORE_CFLAGS') or '')): raise unittest.SkipTest("test_gdb is not

[issue32592] Drop support of Windows Vista and 7 in Python 3.9

2019-09-26 Thread Steve Dower
Steve Dower added the comment: There shouldn't be any annoyance to users, as nobody should be using Windows 8 anymore (the update to 8.1 was free and difficult to avoid). Updating to NTDDI_WINBLUE is fine, but not essential. Nothing about that flag has a real impact until we need or wa

[issue38160] Add a "PyInterpreterState *" field to PyTypeObject.

2019-09-26 Thread Steve Dower
Steve Dower added the comment: > Does it mean that a type A created in interperter 1 can be seen/accessed from > interpreter 2? No, but it means that a type A *knows* that it was created in interpreter 1 without relying on the current thread local storage. What it does wit

[issue38326] Concerns with the last minute changes to the PEP 587 API

2019-09-30 Thread Steve Dower
Steve Dower added the comment: (Continuing from the email thread, so read that for context if you haven't) Binary compatibility of an embedding-only struct is totally unnecessary, as posted on the thread. There's no feasible way to embed cross-Python versions on any platform, so

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread Steve Dower
Steve Dower added the comment: The bug was probably exposed due to a change in path initialization (there's been a few changes here recently ;) ) that stopped normalising prefix. You can see that sys.executable in your dumped path has additional "." in the path, and that&#

[issue35360] Update SQLite to 3.28 in Windows and macOS installer builds

2019-09-30 Thread Steve Dower
Steve Dower added the comment: Please file a new issue -- ___ Python tracker <https://bugs.python.org/issue35360> ___ ___ Python-bugs-list mailing list Unsub

[issue38324] [Windows] test_locale and test__locale failures on Windows

2019-09-30 Thread Steve Dower
Steve Dower added the comment: This is a known issue (forgetting the number right now) - Linux-style locales don't work on Windows, and so there's a normalization function that has to be completely rewritten. Also, since these seem to be on your own machine, I'm guessing your

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread Steve Dower
Steve Dower added the comment: > I checked why sys.executable is not normalized in the the "appx build". > PC\python_uwp.cpp calls set_process_name() which sets PyConfig.executable and > the path is not normalized. If PyConfig.executable is set explicitly, the >

[issue38322] Azure Pipelines: appx tests fail: init_fs_encoding: failed to get the Python codec of the filesystem encoding

2019-09-30 Thread Steve Dower
Steve Dower added the comment: Either way, the paths in the latest tests [1] seem to be fine, and they all passed, so I don't think this is a release blocker anymore. Thanks, Victor! [1]: https://dev.azure.com/Python/cpython/_build/results?buildId=52024&view=logs&j=c8a71634-e

[issue38343] Version name in PC/layout read incorrectly for RC

2019-10-01 Thread Steve Dower
New submission from Steve Dower : I noticed that when the nuget.org packages published for 3.8.0rc1, they were given the version "3.8.0". 3.7.5rc1 was okay because it's still using the old approach to setting the version. This needs to be fixed before any more RCs are releas

[issue38343] Version name in PC/layout read incorrectly for RC

2019-10-01 Thread Steve Dower
Change by Steve Dower : -- nosy: +lukasz.langa ___ Python tracker <https://bugs.python.org/issue38343> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38343] Version name in PC/layout read incorrectly for RC

2019-10-01 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +16118 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16527 ___ Python tracker <https://bugs.python.org/issu

[issue38343] Version name in PC/layout read incorrectly for RC

2019-10-01 Thread Steve Dower
Steve Dower added the comment: New changeset b9a8b8296cd7be22f8b5bf92af686a788c47c7bf by Steve Dower in branch 'master': bpo-38343: Fixes version handling for nuget packages (GH-16527) https://github.com/python/cpython/commit/b9a8b8296cd7be22f8b5bf92af686a

[issue38343] Version name in PC/layout read incorrectly for RC

2019-10-01 Thread Steve Dower
Steve Dower added the comment: I already republished correctly-versioned files and unlisted the wrong ones (as well as contacting support to see whether they can delete them completely so they don't impact the final release). The change above fixes the issue. It will need cherry-pickin

[issue38343] Version name in PC/layout read incorrectly for RC

2019-10-01 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-02 Thread Steve Dower
Steve Dower added the comment: Should be a straightforward fix (replace the "else" with "if not defined..."), but since it slipped through testing we probably want a regression test in test_venv as well. (+RM for the 3.8 regression) -- keywords: +3.8regression

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-02 Thread Steve Dower
Steve Dower added the comment: Adding this to the end of test_unicode_in_batch_file seems to be sufficient to cause the test to fail: self.assertEqual(err.strip(), '') Potentially we should add that additional check throughout this test module, but I don't think that

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-02 Thread Steve Dower
Steve Dower added the comment: Also adding Ned - this made it into 3.7 as well. -- nosy: +ned.deily versions: +Python 3.7 ___ Python tracker <https://bugs.python.org/issue38

<    1   2   3   4   5   6   7   8   9   10   >