Steve Dower added the comment:
I do like this fix, and I'm sorry I didn't get to reviewing it before beta 1
was released - can we consider this something to fix for 3.5 or do we need to
slip it until 3.6?
--
___
Python trac
Steve Dower added the comment:
It's more recent, but still only a doc change.
What's the description of the change you're referring to?
--
___
Python tracker
<http://bugs.pyt
Steve Dower added the comment:
Given I can't generate the file any other way that will be compatible for
everyone, unless someone contributes a fix I'm going to stop shipping these
files and let people generate them using whatever tools they have.
If anyone wants to suggest instruc
Steve Dower added the comment:
Did it fail for 3.3, 3.4 AND 3.5? Or was it not clear which version they were
having trouble with?
3.5 is so different from earlier versions I'd be very surprised for this kind
of failure to be the
Steve Dower added the comment:
That looks good to me, I'll get it merged in when I'm at my desk.
--
___
Python tracker
<http://bugs.python.org/issue8232>
___
__
Steve Dower added the comment:
The fix for issue23199 "broke" 32-bit mingw because nobody agrees which fork of
mingw should be supported.
Before the next releases I intend to remove the lib completely and add a
"libpython.txt" file in its place with commands or tools t
Steve Dower added the comment:
Ah, I misread msg244875 and thought it was still requiring different tools.
I'll add that option in for the next release then, and if there are still
issues I'll come back to removing the libraries.
--
Steve Dower added the comment:
Can you run the following command and then post the log.txt file it generates:
msiexec /l*vx log.txt /i
--
___
Python tracker
<http://bugs.python.org/issue24
Steve Dower added the comment:
msvcrt isn't the right version, it just happens to load. It's actually an old,
basically unsupported version.
The problem would seem to be that Python 2.7 does not activate its activation
context before loading msvcrt90 via ctypes. Eryksun (nosied - h
Steve Dower added the comment:
Python needs to be recompiled to use a different CRT, and that will break all
existing extension modules (.pyd's). That said, in some situations it is the
right answer, typically because existing extension modules would be broken
anyway, but I don't
Steve Dower added the comment:
python.exe already has the manifest it needs, but it can't be embedded into
python27.dll - it has to go into the exe file. That's why Python can't make it
so that msvcr90.dll is loaded.
Depending on what you're using it for, the C Runtime ma
Steve Dower added the comment:
Ah, it can go into the DLL, and it's already there. The problem may be that
there is conflicting information about which resource ID -
https://msdn.microsoft.com/en-us/library/aa374224(v=vs.90).aspx says it should
be 1 while your link says 2.
python27.dl
Steve Dower added the comment:
About the only possible solution here would be to special case ctypes to detect
msvcr90 as a parameter (later versions of the CRT don't need it) and also
whether another activation context already exists. We could also document the
need for a complete man
Steve Dower added the comment:
> i'm not following why it's a special case, or why later versions wouldn't
> have the same problem?
The Microsoft C Runtime 9.0 required an activation context to allow multiple
versions to load side by side. This turned out to be more troub
Steve Dower added the comment:
If it existed in 3.4 then we can only alias it now and not fix it. 3.5 and 3.6
can have the fix.
--
___
Python tracker
<http://bugs.python.org/issue8
Steve Dower added the comment:
That's what I thought, but I wasn't 100% sure it wasn't moved/rewritten in the
patch and was on my phone so I didn't check :)
--
___
Python tracker
<http://bu
Steve Dower added the comment:
I'll close this as fixed, but feel free to speak up if you spot anything else
that needs fixing.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python
Steve Dower added the comment:
The 3.4 RM is already nosied - what say you, sir?
--
___
Python tracker
<http://bugs.python.org/issue8232>
___
___
Python-bug
Steve Dower added the comment:
Fairly sure webbrowser.py is stand-alone enough that you could redist it with
your package easily enough. None of the rest of the stdlib should depend on the
internals, AFAIK.
--
___
Python tracker
<h
Steve Dower added the comment:
Sure, you can do that. You can also copy-paste it into your project to get the
same effect.
--
___
Python tracker
<http://bugs.python.org/issue8
Steve Dower added the comment:
> python-3.5b2 is linked against the newly introduced 'universal CRT', that is
> without any doubt a SYSTEM LIBRARY. However, heap memory managment functions
> and other functions are linked against VCRUNTIME140.dll instead of the
> ucr
Steve Dower added the comment:
> i assume he's coordinating the crt versions? apparently a lot of people use
> these.
So do I :) He's definitely got access to the correct compiler versions, so I'm
sure he's using them (via distutils/setuptools, which will always t
Steve Dower added the comment:
> Steve, since you haven't closed this issue, have you considered my suggestion
> to export _Py_ActivateActCtx and _Py_DeactivateActCtx for use by C extensions
> such as _ctypes.pyd? These functions are better than manually creating a
> context
New submission from Steve Dower:
It's possible to statically link the vcruntime140.dll dependency without
statically linking the entire CRT, which will save us from having to
redistribute the file (meaning the entire CRT dependency is now system
components).
Patch to follow, and I'
Changes by Steve Dower :
--
keywords: +patch
Added file: http://bugs.python.org/file39742/24476_1.patch
___
Python tracker
<http://bugs.python.org/issue24
Steve Dower added the comment:
There may be some potential issues when hosting Python in a C++ app built with
a later version of MSVC, since vcruntime140.dll is predominantly initialization
and exceptions for C++. I can't think of anything specific here though, and it
seems likely tha
Steve Dower added the comment:
> it's the move to the universal CRT that mitigates the worst of the "don't mix
> C runtimes" issues, rather than this specific change?
Correct
--
___
Python tracker
<http
Changes by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
Attached a patch to set the component IDs in the 3.4 installer to match the
ones we're using for 3.5 and later. This should prevent downgrading of the
launcher in future releases, though it's not strictly the "right" way to do
this. (Nosi
Steve Dower added the comment:
Presumably it's from the C implementation of lru cache
--
___
Python tracker
<http://bugs.python.org/issue24478>
___
___
Pytho
Steve Dower added the comment:
The current patch should do that for all-user installs of 3.5, but those aren't
the default. There's no sensible way to detect per-user installs.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
That's two separate questions:
> Is it possible to get the license issues resolved
AFAICT they are resolved. Go ahead and copy the relevant code from setuptools.
> get this fixed in 2.7.11
Why do you need/want to build without
Changes by Steve Dower :
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue23246>
___
___
Python-bugs-list
Steve Dower added the comment:
Finally got back to looking at this, and since %f works against MSVC 14.0 I'm
just going to remove the part of the test that is currently failing and close
this issue.
--
___
Python tracker
<http://bugs.py
Steve Dower added the comment:
Feel free to fix up msi.py as much as it needs. I don't particularly understand
it - I just run it :)
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
I'll try out the changes when I get a bit of time today or tomorrow and decide
then what I'll do.
msi.py doesn't actually build the projects AFAIK, so it's probably okay. It
might try to read them
Steve Dower added the comment:
Looks like the required install configuration is:
* VS 2008 + VS 2010, or
* VS 2008 + VS 2013 or later + Windows SDK 7.1
The SDK is at http://www.microsoft.com/en-us/download/details.aspx?id=8279 and
contains MSVC10 and platform toolset files for both VC9 and 10
Steve Dower added the comment:
32-bit build was fine (VS 2013 + SDK 7.1 + VS 2008), but something has gone
funny with the 64-bit. Need to go AFK for a bit now, but I'll try and figure
that out later today.
--
___
Python tracker
Steve Dower added the comment:
64-bit build didn't work (couldn't find ws2_32.lib) until I ran the SDK
Configuration utility and selected v6.0A as the default SDK. This may be
because I forgot to explicitly select the 64-bit compilers when I initially
installed VS 2008, but it'
Steve Dower added the comment:
I'll give it a shot tomorrow. Haven't done it before (not even sure I have the
svn.p.o permissions). Do I still need Perl for this?
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
There was an email, though I don't remember whether it was a detailed one.
I'll take notes as I work through it and write something up or contribute them
to whoever is writing.
--
___
Python trac
Steve Dower added the comment:
I assume we use svn+ssh:// for this? I can't ssh into svn.python.org with my
usual key, so I'm guessing it needs to be set up on there.
Who is best to contact about that?
--
___
Python tracker
<http://bu
Steve Dower added the comment:
The advantage of svn for externals is that nobody needs the history and most
people don't need a full enlistment. A hg setup should probably be one repo per
project per version, and I'm not sure that'
Steve Dower added the comment:
See #17797
--
resolution: -> duplicate
status: open -> closed
superseder: -> Visual C++ 11.0 reports fileno(stdin) == 0 for non-console
program
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
I've emailed Benjamin, but I'm not sure when he was getting back. If I'm
blocked on this then I guess Zach will have to do it again.
I got as far as building and testing for 3.5 without any issues. But if I can't
check in to the repository t
Steve Dower added the comment:
Yep, Benjamin added it about half an hour ago :)
Should have this done fairly soon.
--
___
Python tracker
<http://bugs.python.org/issue24
Steve Dower added the comment:
Just spotted that. How about I kick off 3.5 and 2.7 with the old build files to
test and you get 3.6 and 2.7 new?
--
___
Python tracker
<http://bugs.python.org/issue24
Steve Dower added the comment:
Agreed. Build and obviously related tests are fine.
--
___
Python tracker
<http://bugs.python.org/issue24432>
___
___
Python-bug
Steve Dower added the comment:
Sure, I'll get it.
--
___
Python tracker
<http://bugs.python.org/issue24432>
___
___
Python-bugs-list mailing list
Unsubscr
Changes by Steve Dower :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
Eh, why bother. I don't remember if the fix is in for 3.5.0b3, but I'll vouch
that the compiler build with the fix does exist and will be used for 3.5, so
this should just be closed (again).
--
stage: -> resolved
status: o
Steve Dower added the comment:
I don't see any crash in that log, though the importlib tests appeared to time
out.
Assert messages appear on the buildbots because they use debug builds and we
don't suppress them completely. Provided the tests keep running without
failure, it
Changes by Steve Dower :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue24181>
___
___
Python-bugs-list mailing list
Un
Steve Dower added the comment:
Last time this came up the solution was either "hg purge" or "make distclean",
I don't remember which worked.
timemodule.c should already be built with Py_BUILD_CORE set in CFLAGS, but
apparently it's possible for that settin
New submission from Steve Dower:
The Windows installer attempts to load one of the public facing API sets to
detect the current CRT version. However, on Windows 10, these DLLs are not
directly loadable.
We should probably just load ucrtbase.dll directly for the version check
New submission from Steve Dower:
If you have Python 3.5.0b2 installed and run the Python 3.5.0b3 installer, it
will upgrade correctly, but gives no indication that it will remove the old one.
We should default to an upgrade using the same settings as the previous
installation when one exists
Steve Dower added the comment:
Making this a release blocker - the installer changes required here are
probably big enough that I really don't want the last beta going out without
them (or alternatively, the rc to be the first time they get tried).
--
priority: normal ->
Steve Dower added the comment:
Looks like there's also a problem with Modify being performed by a different
user than the one who installed last. Need to come up with a way to properly
detect installed features, which should fix both
Steve Dower added the comment:
Committed a fix, but apparently messed up linking back to the issue:
https://hg.python.org/cpython/rev/60eb61d6fdb4
https://hg.python.org/cpython/rev/877f47ca3b79
--
resolution: -> fixed
stage: -> resolved
status: open -&g
Steve Dower added the comment:
You should start by posting this to python-list or StackOverflow, and I'd
suggest including code that can actually be run - it's far more precise than
pseudocode.
(Functions and modules get used a lot. It's far more likely there's a bug i
Steve Dower added the comment:
Doesn't touch anything significant outside the installer, so I just committed
it. Feel free to read over the change and comment here if you want, but we
unfortunately won't get complete testing of this until rc1.
I added some helpers for faking o
New submission from Steve Dower:
Lib/uuid.py includes the following code that runs on import:
import ctypes, ctypes.util
# The uuid_generate_* routines are provided by libuuid on at least
# Linux and FreeBSD, and provided by libc on Mac OS X.
for libname in ['uuid
Steve Dower added the comment:
Patch is against Python 3.5, but uuid.py is identical in all versions and the
change should be applied to all four branches.
--
keywords: +patch
Added file: http://bugs.python.org/file39927/24634_1.patch
___
Python
Steve Dower added the comment:
> For 2.7, Windows won't be able to find msvcr90.dll without an activation
> context, but that's just an ERROR_MOD_NOT_FOUND OS error.
Actually, it finds the DLL fine and the DLL terminates the entire process when
it fails to detect an ac
Steve Dower added the comment:
> ctypes could activate this context before calling LoadLibrary.
That would break anyone else who's manually managing their own activation
context around ctypes. At best we could expose functions to enable Python's
activation context (which I'
Steve Dower added the comment:
It's a deliberate exclusion, I just haven't gotten to all the documentation yet
(mostly because I still expect things to change).
My idea was that packages would be deployed statically alongside the embedded
distribution rather than going into a sit
Steve Dower added the comment:
Also have a read of https://docs.python.org/3.5/using/windows.html and see
whether it will suit your needs. I need to hear feedback on this, as we're
running short on time to make drastic changes if they are necessary.
I too automate installation of a
Steve Dower added the comment:
Or we could define _timezone on those platforms that don't have the underscore.
I'm not hugely fussed either way. We need to fix this though.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
That's probably an option, though it would break extensions that use `timezone`
expecting it to work. But it seems like any change is going to cause that.
I prefer defining _Py_timezone, since at least we can offer something that is
portable for all Pytho
Steve Dower added the comment:
It's not, but "#include " in any extension will make it available for
you, so it's very likely that extensions have simply used it without adding
their own conditional compilation for the various interpretations of whether
timezone is standa
Steve Dower added the comment:
Agreed. However, I also don't want extensions to stop building because of a
change we make. But since that's inevitable here, let's go with Zach's original
suggestion and use a name that won't conflict. (IIRC, I originally put the
#if
Steve Dower added the comment:
> 1. This should be more prominently documented.
Very true. I'll get a link to the updated docs page in there.
> 2. passing /? should list the available kay-value arguments.
Should be doable. I've mostly been holding off until I stop changing th
Steve Dower added the comment:
I was going to guess it was timemodule.c.
You need to "make distclean" or "hg purge" to clean up your repo. This seems to
be some sort of gcc/configure issue. So far everyone else who has seen this has
fixed it by
Steve Dower added the comment:
Yeah, I need to clearly document that you are responsible for installing the C
Runtime yourself.
My current theory is that embedding applications will also require the CRT (at
least those that intend to load python3.dll or python35.dll directly), and so
it
Steve Dower added the comment:
That's exactly the use case, and I might "borrow" your summary for the docs
that I'll eventually write for it because you've summed it up really well.
My biggest worry right now is that people will treat it as a portable install
and r
Steve Dower added the comment:
Afraid it's not possible - that error comes from the loader, so we haven't had
a chance to run anything yet.
One option would be to put some sort of readme into the zip, but that seems to
be optimising for the wrong behavior. If I were legitimately
Steve Dower added the comment:
Apparently you've installed SVN differently and you're calling svn.bat (or
svn.cmd) instead of svn.exe.
Adding call there should not cause a problem for people who have svn.exe, but
Alex, I suggest you try running "where svn" to make s
Changes by Steve Dower :
--
components: -2to3 (2.x to 3.x conversion tool), Benchmarks, Build,
Cross-Build, Demos and Tools, IO, Installation, Interpreter Core, Library
(Lib), Tests, Unicode, Windows, XML, email
nosy: -steve.dower
___
Python
Steve Dower added the comment:
Are you being promoted for administrative privileges? Unfortunately there's no
way around requiring them to install the C Runtime update, so if you are
blocked from applying Windows Updates to your machine unfortunately there's no
good way a
Steve Dower added the comment:
Sorry to do that to you Larry, though I have done extra testing on these
changes (hence the fake version support) so I'm confident they work, just not
yet 100% confident the user experience is going to be co
Steve Dower added the comment:
So I've done some quick research but don't have a lot of time. You're getting
error code 0x80240017 from wusa.exe, which is trying to install a Windows
Update.
This thread looks like it may have some solutions on it:
http://answers.microsoft.co
Steve Dower added the comment:
I'm not against adding the support (to 3.6), though I'd be interested in what
the workarounds are and whether it'd be more useful as an example (e.g. "here's
how to support a special build step" vs. "all special build steps nee
Steve Dower added the comment:
I agree, and I know that backwards compatibility is a very high priority
especially now that SQLite is shipping as part of Windows 10. While we *could*
take a dependency on this binary (winsqlite3.dll, for those who have it), I
don't think it's ac
Steve Dower added the comment:
Technically it says that it will work until VS 2015 is released (which happened
last Monday), but the statement certainly should be clarified now. I'll do it.
I'm still waiting to hear what options will be available for installing the
compilers without
Steve Dower added the comment:
Updating to 3.8.11.0 now.
--
___
Python tracker
<http://bugs.python.org/issue19450>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
Dev guide has been updated. I assume it'll flow through to the website
eventually, though that hasn't happened yet.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Py
Steve Dower added the comment:
Looks like Python 2.7 is still on SQLite 3.6.21, so the RM (Benjamin) will have
to make a call on whether we take the upgrade.
--
___
Python tracker
<http://bugs.python.org/issue19
Steve Dower added the comment:
Reopening this because we need to update distutils to pass the same options or
built wheels won't work on machines where the full VC runtime isn't installed.
--
resolution: fixed ->
stage: resolved ->
status
Steve Dower added the comment:
Did the behavior change for 3.4 after the updates? It seems unlikely.
Zach's right: we need a test to formally state the expectations here.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
If you download and install the VC++ Redistributable from
http://www.microsoft.com/en-us/download/details.aspx?id=48145 then we won't try
and run the code that is failing in our installer.
If the previous installer fails then you have a configuration err
Steve Dower added the comment:
I'd rather have our own test pyd that shows a minimal repro of the behavior.
Requiring pywin32 for running one test is excessive, won't reveal the issue (if
it exists) on other platforms, and is not necessarily going to help someone
debug the issue
Steve Dower added the comment:
3.5 won't work without 2999226 at all, so ignore that. It's the C runtime.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
It's possible, but that isn't solvable or testable by removing the update. To
solve that we need a test and then fix the bug.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
I don't know either. Below I've pasted the part of your log that shows the
error and error code - you should contact your support department or (better)
search the internet for that error code:
[173C:0C0C][2015-07-30T01:45:21]i301: Applying execu
Steve Dower added the comment:
That's exactly what is needed (though it still won't affect command prompts
that are already open).
The 3.5+ installer does it, so this only affects 2.7 and 3.4.
--
versions: +Python 3.4
___
Python trac
Steve Dower added the comment:
What are the expected benefits from changing? Just a higher resolution? I'm not
sure that's worth anything if it's inaccurate.
--
___
Python tracker
<http://bugs.pyt
Steve Dower added the comment:
Correct. I'll fix this on Monday or Tuesday this week.
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org
Steve Dower added the comment:
Until then, if you find and install the VC distributable for VS 2015 then
you'll have the files you need. On my phone now so I don't have the link handy
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
Rather than change the tcl and tk project files (which is not as easy as
updating the Python projects - I spent an hour trying), I've added the
vcruntime DLL to the MSI with tkinter.
Distutils has already been updated to not include it any more, and I r
Steve Dower added the comment:
Looks like the patchcheck section also has a "PCBuild/python.exe" that should
be fixed.
Are the previous commenters satisfied with the fixes?
--
___
Python tracker
<http://bugs.python.o
4801 - 4900 of 5794 matches
Mail list logo