Steve Dower added the comment:
You're right. I moved that code from buildrelease.bat, which definitely
requires hg.
PC/build.bat should not fail if hg can't be found. You'll just end up with an
empty sys._mercurial/sys.version after building.
--
assignee:
Steve Dower added the comment:
You've described it correctly.
> The problem is that the warning should be emitted only for users that use
> incorrect API. But it shouldn't be emitted for users that use just 3.2 API
This is why I suggested #warn and not #error. It's okay
Steve Dower added the comment:
Running "python -v" might show what the last thing it tried to do before
exiting was.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
Sounds good. Don't focus on ease of implementation, BTW. The post and eventual
PEP need to cover the benefits, risks and alternatives more than anything else.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
You mean the history within Python? That's extremely strange.
Have you reported this to the git bash folks? We'll probably need someone who
understands what their shell is actually doing to make any pro
Steve Dower added the comment:
pyreadline is probably the problem. Try uninstalling or updating it.
--
___
Python tracker
<http://bugs.python.org/issue29
Steve Dower added the comment:
Thanks. I finally got a chance to look at these logs - apologies for taking
some time.
It looks like some of the installs succeeded and others were then trying to
modify the existing installation (I *think* this is why the unattend.xml file
had no effect
Changes by Steve Dower :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Steve Dower :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.5
___
Python tracker
<http://bugs.python.or
Changes by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue29033>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
Any comment from the SSL experts?
--
___
Python tracker
<http://bugs.python.org/issue28747>
___
___
Python-bugs-list mailin
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29060>
___
___
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28675>
___
___
Steve Dower added the comment:
I applied to 3.6 and default. If anyone is motivated enough to apply to 2.7,
feel free.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
Apologies for the delayed response - I haven't been going through bugs recently.
If you're still having trouble, please try uninstalling and then running the
commands above. After that, try reinstalling. (Those are uninstall commands
that should fix t
Changes by Steve Dower :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29037>
___
___
Steve Dower added the comment:
I believe this is out of date now, but if you have similar issues with the
final release, feel free to respond to this thread again.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
_
Steve Dower added the comment:
oselljr - are you still having this trouble with 3.5.2?
--
___
Python tracker
<http://bugs.python.org/issue26631>
___
___
Python-bug
Steve Dower added the comment:
Gabriel - did that solution work for you? If not, can you install and provide
all the Python logs from %TEMP%?
--
___
Python tracker
<http://bugs.python.org/issue28
Changes by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Steve Dower added the comment:
Tracking purposes mainly, so someone outside the interpreter state can tell
when it's no longer there. Making interpreter states weak-referencable would
have a similar effect, and could very well use this id if we didn't need the
Steve Dower added the comment:
That's an issue with TLS initialisation, not thread IDs. It's easily solved by
defining an "uninitialized" value (e.g. 0) and an "invalid" value (e.g. -1).
Interpreter states are in a linked list, so you can traverse the list to find
Steve Dower added the comment:
Does SCCM support dependency provider keys? If so, Python 3.6.0 and 3.5.3 and
later will set one of these (see issue28846), which should make it easier to
detect the whole bundle. Previous versions of 3.5 used a random GUID here.
I managed to reproduce the issue
Steve Dower added the comment:
> Wouldn't this break the main property of IDs, the uniqueness?
If we bump it up to a 64-bit ID then it'll be no worse than how we track all
dict mutations.
--
___
Python tracker
<http://bugs.pytho
Steve Dower added the comment:
The only real advantage of adding a native unit testing framework here is to
avoid having to start/destroy _testembed[.exe] multiple times during the test
run. But given the nature of these tests is highly environmental, I don't think
we can reasonably avo
Steve Dower added the comment:
I suspect curses could be updated to fully support Windows, even without the
VT100 mode (all the functionality has existed for years, just through a
different interface). It really just needs someone to take on the project, and
there are already better options
Steve Dower added the comment:
I fully expect subinterpreters to have a serious role in long running
applications like web servers or other agents (e.g. cluster nodes), so I'd
rather just bite the bullet and take 64-bits now so that we can completely
neglect reuse issues. Otherwise we
Steve Dower added the comment:
Is platform.architecture() the right way to determine what platform you're
targeting? This will tell you the current OS, but typically you want to know
the architecture of the Python process (since you often run 32-bit processes on
64-bit Windows). If you
Steve Dower added the comment:
Only as certain as anyone else in the general public - I don't have any special
information besides what has been published.
Since it's been published for the specific intent of helping 3rd parties plan
their own deprecation cycles, I think it's
Steve Dower added the comment:
Patch committed without modification. I'll keep an eye on the buildbots just in
case, though I may end up going offline before they get to this changeset.
--
assignee: -> steve.dower
stage: -> co
Steve Dower added the comment:
> IIRC, ANSI is somewhat incompatible with sending random binary gibberish to
> the screen, as people accidentally do with TYPE sometimes :) But the random
> binary gibberish may contain ANSI control sequences... That's why I'm
> negative
Changes by Steve Dower :
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29014>
___
___
Python-bugs-list
Steve Dower added the comment:
Any reason we can't make gmtoff a time_t instead of an int?
If we're going to truncate values to get rid of the warnings, I'd like to also
see either proof that it will never exceed the size of an int (which may be a
simple comment, but it
Changes by Steve Dower :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28592>
___
___
Python-bugs-
Changes by Steve Dower :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28781>
___
___
Python-bugs-
Steve Dower added the comment:
In Python 3, this passes a wchar_t* string, but printf('%s') expects a char*
string.
You may want to start by looking at the tutorial at
https://docs.python.org/3/tutorial/index.html to get a feel for what builtins
are available. Using ctypes is fairl
Steve Dower added the comment:
Though if you do really want to use the (very) old msvcrt DLL rather than the
proper functionality, calling cdd.msvcrt.wprintf will behave as you expect, or
prefixing the strings with b (e.g. b"Testing") will pass it as bytes rather
than wchar_t.
But
Steve Dower added the comment:
Buildbots are happy, so I'm calling this done. Jumping straight to getopt is
overengineering right now in my opinion, but if there's a need for it with a
future test we can consider it then.
--
resolution: -> fixed
stage: commit revie
Steve Dower added the comment:
Ah, I was thinking of platform.machine().
--
___
Python tracker
<http://bugs.python.org/issue29124>
___
___
Python-bugs-list mailin
Steve Dower added the comment:
Interesting. I don't suppose you could find all the log files in your %TEMP%
directory, put them in a zip file and attach them here? There may be some clue
as to why this happened - it's certainly meant to clean everything up when you
uninstall (excep
Steve Dower added the comment:
LGTM. Though as you say, it's probably easiest for one of us to go through each
branch and use VS to get it right. I think both of those projects were added
from other operating systems, so updating the sln wouldn't be so easy.
I'll get to i
Steve Dower added the comment:
This is a bug in Visual Studio, not Python.
There is an RC release of the Python support with a fix for this bug is
available at https://github.com/Microsoft/PTVS on the releases page, and an
actual update will appear in notifications within a couple of weeks
Steve Dower added the comment:
I'm fairly sure dllexport implies noinline, and it certainly does for the
exported function (but maybe PGO will inline it within the module? hard to
know). In any case, I agree with keeping it private as it's purely about
optimization.
Do you have a
Steve Dower added the comment:
More user choice here is actually an incredibly huge burden. Managing file
associations across a range of versions, many of which can no longer be
updated, is hard enough without offering options. Not to mention the extra user
interface required.
Personally
Steve Dower added the comment:
If you import os first then that's acceptable and we should document it more
clearly. Try calling enable before importing os.
I wouldn't be surprised if os is imported automatically, in which case we need
to figure out some alternate caching mechanis
Steve Dower added the comment:
I discussed installers on my blog at http://stevedower.id.au a while back.
There are some other options linked from there, and also rationale for why
things are how they are.
--
___
Python tracker
<h
Steve Dower added the comment:
"msiexec /a" does not install anything - it converts the MSI into a source
layout for lazy network installs. It is, and always has been, completely
unsupported as an approach to installing Python, and we are under no obligation
to maintain it.
Copy-p
Steve Dower added the comment:
The last time I saw collected data on usage (based on Visual Studio users),
there was no clear majority of "number of interpreter versions", but 3 was the
most common (2 and 4 were roughly equal, 5 and 6 were more popular than 1).
The nesting als
Steve Dower added the comment:
Ah, you're using the full installer, which has the non-debug versions embedded
and therefore does not ever need to download them.
If you start from the web installer, it will download the MSIs for the
non-debug components as well. But as I said, you&
Steve Dower added the comment:
Then we do in fact need to make os.fsencode/fsdecode either stop caching the
encoding completely, or figure out a way to reset the cache when that function
is called.
--
___
Python tracker
<http://bugs.python.
Steve Dower added the comment:
Windows doesn't use the fs encoding at all until Python code requests/provides
something in bytes. Except for the caching in fsencode/fsdecode, there's no
problem setting it once at the start of your program (and it can only be set
once - there'
Steve Dower added the comment:
Does running with -v provide any more hints?
I'm also interested in whether the alphas work when you don't have a full
install on the same machine. PC/getpathp.c changed for b1. But that's probably
less important.
Perhaps runpy just never m
New submission from Steve Dower:
If a python._pth file includes a blank line, it gets treated as '\n' which is
then appended to the directory and used as an entry in sys.path.
Empty lines should be ignored completely.
--
components: Windows
messages: 285809
nosy:
Steve Dower added the comment:
I just tried it and it makes no difference.
Omitting the "._pth" file seems to fix it, but apart from issue29326 (benign)
sys.path is fine.
Still digging, but don't worry about testing on
Steve Dower added the comment:
Found it in Modules/main.c in RunMainFromImporter():
/* argv0 is usable as an import source, so put it in sys.path[0]
and import __main__ */
sys_path = PySys_GetObject("path");
if (sys_path == NULL) {
PyErr_SetString(PyExc_Ru
Steve Dower added the comment:
I'd say it definitely qualifies as a bug fix, even in 3.5 (which repros),
assuming we don't break any existing APIs in the process.
--
versions: +Python 3.5
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
The fix for this issue is needed in PC/getpathp.c as this is a special feature
in path generation on Windows.
I'm not aware of any such issue with .pth files - the underscore in ._pth is
deliberate.
--
___
P
Steve Dower added the comment:
Thanks for checking that.
I don't think it's worth retaining the cache on Windows in the face of the
broken behaviour. Any real-world case where a lot of paths are being encoded or
decoded is also likely to involve file-system access which will
Steve Dower added the comment:
How?
--
___
Python tracker
<http://bugs.python.org/issue29241>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Steve Dower added the comment:
I don't care enough to argue about it with you. Let's just fix the API as soon
as we can and apologize to people who hit inconsistencies in earlier versions.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
I haven't had a chance to try the patch (underpth_blank_lines.diff) or apply
it, but it looks right.
If one of the other core devs gets to apply this before I do, feel free.
Alexey, you don't need to sign a CLA for this fix, but if you're going
Steve Dower added the comment:
Speaking as a "regular user" who just ran into this, my main concern is that
PathLike paths get used properly. For filenames being passed back out, if I
really want them to be Path objects, I'll wrap them in Path() anyway.
Please don't let
Steve Dower added the comment:
I'm okay with this patch. We move closer to being right without degrading the
normal case, and I don't think the edge cases are important (and the behavior
in those cases will be acceptable).
With a couple of tests to make sure the path comparisons
Steve Dower added the comment:
Might be worth checking if this is resolved with issue29079, which is already
in for 3.6.1.
--
___
Python tracker
<http://bugs.python.org/issue29
Steve Dower added the comment:
At the point this code is running, it doesn't matter. The path doesn't exist,
so trimming irrelevant segments from it will just cause a few extra iterations
through resolve until we clear out enough of the absent segments to find
something that
Steve Dower added the comment:
Thanks, this is the same as issue25166.
In short, we need a significant update to the WiX framework before this can be
enabled, and so far the core WiX developers are not interested in doing it.
I've been working on a patch, but it's actually fairly c
Steve Dower added the comment:
I assume this is because Idle is doing "import code" somewhere and picking up
your file instead of the real one.
Renaming the file to not conflict with the standard library is an immediate
workaround, but perhaps Idle should do some sys.path protect
Steve Dower added the comment:
I consider this another vote against putting the check box on the front page of
the installer, rather than a positive vote for any particular change.
There's no way to miss the screen with the real checkbox when you are modifying
the install, and modifying
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29443>
___
___
Steve Dower added the comment:
Merging this in now, along with a few other patches. This is the test I'm
adding, in case anyone spots any problems with it before I push (copied from
the test for pure-ASCII bytes):
@unittest.skipIf(sys.getfilesystemencoding() != &
Changes by Steve Dower :
--
assignee: -> steve.dower
stage: needs patch -> commit review
___
Python tracker
<http://bugs.python.org/issue29416>
___
___
Pyth
Changes by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
Committed, but I'll leave this open for a bit in case anyone wants to comment
on the commit.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org
Changes by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
That change fixes overwriting sys.path[0], the new logic is essentially:
try:
sys_path0 = sys.path[0]
except:
sys.path.append(argv0)
else:
if sys_path0:
sys.path.insert(0, argv0)
else:
sys.path[0] = argv0
I'm leaving this ope
Steve Dower added the comment:
Taking another look at the patch, I'm not real keen on the C/LDFLAGS section. I
think if we want to support setting these, we should fully override the default
settings (otherwise you can't specify certain options that are in the
defaults), and avoid
Steve Dower added the comment:
It's straightforward to detect path->narrow == NULL and raise instead of
crashing. We can also trivially check path->wide on Windows and raise with a
more specific error.
Given it's already fixed for 3.6.0 and there's only one more binary
Steve Dower added the comment:
I think there's something else going on with your install, as I do these
frequently and they work fine (modulo issue25166).
Can you grab all your log files from your %TEMP% directory and attach them
here? I'm keen to see what the installer is tryin
Steve Dower added the comment:
Without logs showing what went wrong, there's nothing we can fix.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Steve Dower added the comment:
Looks like the "need to check Win7" part was actually important... there are
buildbot failures from this. I *think* they only require test handling updates.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
Okay, seems like Windows 7 GetFullPathName on conin$ and conout$ returns the
path appended to the current directory, and you need to specify the full name
as "conin$" or "conout$" to access the console - otherwise you have a file by
that name
Steve Dower added the comment:
> If Python on Windows changed to ship python3.exe and python37.exe alongside
> python.exe, then it might be worth revisiting this discussion
Agreed, though if we started including versioned executables wouldn't that
resolve this issue naturally? (
Steve Dower added the comment:
That test looks good for me, and I verified it on both Win7 and Win10.
(Hopefully we don't have any Win8.1 edge cases in here...)
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
Steve Dower added the comment:
What's your actual command? And what output is it producing? Without those,
we've got no hope of guessing what is going on here.
Nothing in subprocess should have changed because of my PEPs, other than
decoding bytes passed as arguments (which I
Steve Dower added the comment:
You can also use the nuget packages (search on nuget.org for Python). These are
intended to be used is scripted standalone setups, such as CI systems. I've
been using them as part of most of my build systems recently. They support
distutils and pip (not ve
Steve Dower added the comment:
Readline is also a common culprit when it's crashing out at the interactive
prompt. Try either uninstalling or upgrading any packages that may include a
readline module.
--
___
Python tracker
<http://bugs.py
Steve Dower added the comment:
We may just want to copy the values from the enum if there are different
versions when they were introduced. But if that's not a problem, adding the
MS_WINDOWS check is better than defining new macros.
--
___
P
Steve Dower added the comment:
My vote would be to make the tests not presume anything about line endings, to
the point of converting test files on the fly to be sure.
I'm mostly free today (in a different city with nothing to do), so if my hotel
internet will let me SSH to github then
Steve Dower added the comment:
> Does Git support per-file settings like the svn:eol-style property in
> Subversion or .hgeol in Mercurial?
The .gitattributes file seems to be full of glob patterns, so I assume a full
file path will work.
However, that doesn't help with tarballs.
Steve Dower added the comment:
This is now blocking all releases for all versions.
I'll try and make some time to update the Windows build scripts and project
files, but if someone else gets there first feel free to post a PR.
--
nosy: +benjamin.peterson, larry, steve.dower
pri
Steve Dower added the comment:
I'm okay with including a html readme in the installer, but it has to be fully
self-contained with no separate images or style sheets, and can't have any
dependencies on reaching the network (until the user clicks a link, obviously).
My concern
Steve Dower added the comment:
The ._pth file is certainly not meant to cover beginner scenarios. But with
that list of paths you should get almost exactly the same sys.path by default.
Modifying a module's __path__ will only affect that module (and imports via
that module), whereas sys
Steve Dower added the comment:
There's a few reasons why you haven't heard a reply. First among them is that
we're all volunteers with limited free time, and second is that we just
migrated to github and all that free time is being consumed right now.
Python 2.7 is only rec
Steve Dower added the comment:
I see absolutely no reason to use other projects on github as precedent here,
as the developers have likely not made an explicit decision and are just
shipping files that they already have. Github may be the home of our
development now, but most users don't
Steve Dower added the comment:
The semantics of the ._pth file won't be changing to accommodate security
vulnerabilities, sorry. Add a sitecustomize.py file to modify sys.path if you
want that behavior.
--
___
Python tracker
Steve Dower added the comment:
> an alternative standalone Python interpreter
It's a convenient way to avoid having your standard library hijacked by
registry keys installed by the regular interpreter.
However, if it detects "Lib\os.py" or "python36.zip" a
Steve Dower added the comment:
> starting with python-3.6.1rc
Works with 3.6.0. The only relevant changes in 3.6.1 are to skip empty lines in
the ._pth file, and to avoid overwriting sys.path[0] arbitrarily.
--
___
Python tracker
&l
Steve Dower added the comment:
The contents of the struct is just being big enough to reach the point where it
is passed by reference rather than by value.
This issue is pointing out that it should be a reference to a temporary copy of
the struct, so that if the called function modifies the
Steve Dower added the comment:
Depending on why the pip install failed, we may still have registered that it
was installed. IIRC, we only trigger the install on a state change, which
wouldn't happen in repair. That deserves its own bug (though maybe this one
will suffice if we figure ou
Steve Dower added the comment:
Okay. Unless someone volunteers to write a Windows specific one, I'll make the
change to the installer to leave it out.
Anyone know how far the change has been backported?
--
___
Python tracker
4301 - 4400 of 5794 matches
Mail list logo