Steve Dower added the comment:
I forgot to initialize the result object in readlink() on Windows, and so when
we hit the failure path it returns garbage. Attempting to DECREF that garbage
fails.
The call to readlink() fails in the Store app because sys.executable is not a
readable link. It
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15328
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/15663
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 993ac92418839427d4068d6ae8e618b06b5d9294 by Steve Dower in branch
'master':
bpo-38020: Fixes crash in os.readlink() on Windows (GH-15663)
https://github.com/python/cpython/commit/993ac92418839427d4068d6ae8e618
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
nosy: +Marcus.Smith, dstufft, ncoghlan, paul.moore, pradyunsg
___
Python tracker
<https://bugs.python.org/issue38028>
___
___
Pytho
Steve Dower added the comment:
> Maybe macOS on Azure is running slower and we should just increase the
> timeout?
(Aside, why don't the macOS buildbots have a tag saying that? Took me ages to
find them...)
I doubt it's running 6-7x slower. More likely something is ca
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue38030>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15341
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15681
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 772ec0fad57412daa53d16d7019b6b2fe6e94942 by Steve Dower in branch
'master':
bpo-38030: Fix os.stat failures on block devices on Windows (GH-15681)
https://github.com/python/cpython/commit/772ec0fad57412daa53d16d7019b6b
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
stage: patch review -> backport needed
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I triggered automatic backports to see how they go. Doesn't necessarily mean
we'll merge them without looking more closely, but may as well check out what
our automated tools suggest.
--
___
Python track
Steve Dower added the comment:
Potentially an IDLE issue, if valid but incorrect code is causing it to break.
Sean, we'll need you to provide step-by-step instructions (including copies of
any files you are using) to see the problem ourselves, otherwise there's no way
we can he
Steve Dower added the comment:
New changeset 71ea688d662a74ddf39a3874e06c73e58df55c02 by Steve Dower (Ngalim
Siregar) in branch 'master':
bpo-11953: Extend table of Windows WSA* error codes (GH-15004)
https://github.com/python/cpython/commit/71ea688d662a74ddf39a3874e06c73
Change by Steve Dower :
--
pull_requests: +15395
pull_request: https://github.com/python/cpython/pull/15741
___
Python tracker
<https://bugs.python.org/issue11
Steve Dower added the comment:
New changeset a6563650c835d50f7302971a5b145e94f9d0dc68 by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-37445: Include FORMAT_MESSAGE_IGNORE_INSERTS in FormatMessageW() calls
(GH-14462)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset e223ba13d8d871ee58570dfca4e82a591189cc2f by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-32587: Make winreg.REG_MULTI_SZ support zero-length strings (#13239)
https://github.com/python/cpython/commit/e223ba13d8d871ee58570dfca4e82a
Steve Dower added the comment:
I'm going to merge and backport this all the way to 3.7. Adding a publicly
accessible dict for use in Python code should be 3.9 only.
--
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
New changeset 19052a11314e7be7ba003fd6cdbb5400a5d77d96 by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-37705: Improve the implementation of winerror_to_errno() (GH-15623)
https://github.com/python/cpython/commit/19052a11314e7be7ba003fd6cdbb54
Steve Dower added the comment:
Declaring this out-of-scope for 2.7, unless someone wants to insist (and
provide a PR).
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
versions: -Python 2.7
___
Pytho
Steve Dower added the comment:
This introduced a new warning:
c:\projects\cpython\pc\winreg.c(775): warning C4267: '-=': conversion from
'size_t' to 'int', possible loss of data
[C:\Projects\cpython\PCbuild\pythoncore.vcxproj]
I'll fix it (after I&
Steve Dower added the comment:
Going to say this doesn't qualify for 2.7 (unless someone insists and provides
a PR), given the lack of reports that anything is actually impacted.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9 -Python 3.3
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
New changeset eb02196bd95ea12fcccff3960f36601596811570 by Steve Dower in branch
'3.8':
bpo-11953: Extend table of Windows WSA* error codes (GH-15004)
https://github.com/python/cpython/commit/eb02196bd95ea12fcccff3960f3660
Steve Dower added the comment:
Okay, this is definitely an ordering issue in
Tools/msi/bundle/bootstrap/PythonBootstrapApplication.cpp
Fixing most of the options is easy - just a case of moving
LoadOptionalFeatureStates() a few lines up - but Install_launcher is set much
later. I should be
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15412
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15759
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 3a0ddbcdfcbc0f4372905fabf81e093f1b043e99 by Steve Dower in branch
'master':
bpo-37283: Ensure command-line and unattend.xml setting override previously
detected states in Windows installer (GH-15759)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +15419
pull_request: https://github.com/python/cpython/pull/15766
___
Python tracker
<https://bugs.python.org/issue32
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Thanks for the simpler patch. I'm happier taking that one, given we know the
rest of the code already works.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset ed70129e15ea028469145111044a4349960a4e6f by Steve Dower (neonene)
in branch 'master':
bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632)
https://github.com/python/cpython/commit/ed70129e15ea0284691451110
Change by Steve Dower :
--
pull_requests: +15425
pull_request: https://github.com/python/cpython/pull/15771
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
Fixed, assuming the backports merge okay.
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
This will be fixed in the next release. Thanks for the report!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Closing now, as we're just waiting on the backports to clear CI.
Thanks for your contributions!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python t
Steve Dower added the comment:
New changeset 5d695b6b7bcccf5f028cdacd986096de15bc0ca6 by Steve Dower in branch
'3.8':
bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632)
https://github.com/python/cpython/commit/5d695b6b7bcccf5f028cdacd9
Steve Dower added the comment:
New changeset e3c59a75279b0df4e7553d6f0031e202de434e43 by Steve Dower (Alan
Yee) in branch 'master':
bpo-38059: Using sys.exit() over exit() in inspect.py (GH-15666)
https://github.com/python/cpython/commit/e3c59a75279b0df4e7553d6f0031e2
Steve Dower added the comment:
Thanks! This helps people who use the "-S" option.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs
Steve Dower added the comment:
Yes, even as a struct member name (at least in the definition), the C
preprocessor will substitute a macro. It sounds like Qt defines a macro
"slots", and so the definition of the struct will be broken.
Unfortunately, this would be a more signific
Steve Dower added the comment:
New changeset b3b48c81f09d1472010937f1331c5a208a2a2d48 by Steve Dower (Zeth) in
branch 'master':
bpo-37876: Tests for ROT-13 codec (GH-15314)
https://github.com/python/cpython/commit/b3b48c81f09d1472010937f1331c5a208a2a2d48
--
nosy: +s
Steve Dower added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 65366bc8bdc4716ebc361e622590b45a6e5aef07 by Steve Dower (Anthony
Sottile) in branch 'master':
bpo-20490: Improve circular import error message (GH-15308)
https://github.com/python/cpython/commit/65366bc8bdc4716ebc361e622590b4
Change by Steve Dower :
--
pull_requests: +15444
pull_request: https://github.com/python/cpython/pull/15791
___
Python tracker
<https://bugs.python.org/issue20
Steve Dower added the comment:
Thanks for the patch, Anthony!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Given the potential compatibility impact (small chance of third-party
extensions relying on function aliasing), I'd like to see an update to
Docs/whatsnew/3.9.rst as well.
Also the suggested change to the NEWS entry is good. I don't think this one
s
Steve Dower added the comment:
New changeset 09090d04ef8d2f4c94157b852d3d530a51e13d22 by Steve Dower (Orivej
Desh) in branch 'master':
bpo-37649: Fix exec_prefix check (GH-14897)
https://github.com/python/cpython/commit/09090d04ef8d2f4c94157b852d3d530a51e13d22
--
nosy: +s
Steve Dower added the comment:
Thanks! Great catch
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 915cd3f0696cb8a7206754a8fc34d4cd865a1b4a by Steve Dower
(Christian Heimes) in branch 'master':
bpo-35941: Fix performance regression in new code (GH-12610)
https://github.com/python/cpython/commit/915cd3f0696cb8a7206754a8fc34d4
Change by Steve Dower :
--
pull_requests: +15454
pull_request: https://github.com/python/cpython/pull/15803
___
Python tracker
<https://bugs.python.org/issue35
Change by Steve Dower :
--
pull_requests: +15455
pull_request: https://github.com/python/cpython/pull/15804
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
I suspect this code is a repro - it certainly locks up the host process
reliably enough.
Perhaps if we unblock multiprocessing in the context of a crashed worker then
it'll show what the underlying errors are?
import os
from multiprocessing import Pool
Steve Dower added the comment:
New changeset 2d5594fac21a81a06f82c3605318dfa96e72398f by Steve Dower in branch
'3.8':
bpo-20490: Improve circular import error message (GH-15308)
https://github.com/python/cpython/commit/2d5594fac21a81a06f82c3605318df
Steve Dower added the comment:
New changeset b4fb2c29f34c322855ab6be72b491930cf508f64 by Steve Dower in branch
'3.7':
bpo-35941: Fix performance regression in SSL certificate code (GH-12610)
https://github.com/python/cpython/commit/b4fb2c29f34c322855ab6be72b4919
Change by Steve Dower :
--
assignee: -> mdk
keywords: +patch
pull_requests: +15475
resolution: -> fixed
stage: -> patch review
status: open -> closed
pull_request: https://github.com/python/cpython/pull/15739
___
Python tra
New submission from Steve Dower :
Imitation repro:
import os
from multiprocessing import Pool
def f(x):
os._exit(0)
return "success"
if __name__ == '__main__':
with Pool(1) as p:
print(p.map(f, [1]))
Obviously a process may crash for various othe
Steve Dower added the comment:
Filed as issue38084
I recommend not investigating this issue any further until that one is resolved.
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset fdd17abc51e363ab19d248375d717512b8b26966 by Steve Dower in branch
'3.8':
bpo-35941: Fix performance regression in SSL certificate code (GH-12610)
https://github.com/python/cpython/commit/fdd17abc51e363ab19d248375d7175
Steve Dower added the comment:
That's 3.7 and later dealt with. Apparently this needs a backport to 2.7 still,
so I'll leave the bug open.
--
stage: patch review -> backport needed
versions: -Python 3.7, Python 3.8
___
Python tr
Change by Steve Dower :
--
resolution: -> out of date
stage: needs patch -> resolved
status: pending -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Tests in test_ntpath that go via the actual file system (e.g. via realpath())
need to allow for the case of the path potentially changing.
--
assignee: steve.dower
components: Windows
messages: 351636
nosy: paul.moore, steve.dower, tim.golden
New submission from Steve Dower :
Because we are only looking for the VC141 redistributable, if we only have
VC142 available then we won't find it.
We should expand the glob() call to allow VC14?\vcruntime140.dll.
--
assignee: steve.dower
components: Distutils, Windows
mes
New submission from Steve Dower :
Avoid blocking PRs because of random macOS failures (such as in issue37245).
Also reduce the timeout.
--
assignee: steve.dower
components: Build
messages: 351639
nosy: steve.dower
priority: normal
pull_requests: 15496
severity: normal
status: open
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15498
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15849
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15499
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15850
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15500
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15851
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset a511c7a4961a684db1f8d0ed438822d87d7d3dcf by Steve Dower (Pablo
Galindo) in branch 'master':
bpo-38090: Fix reference leak in ceval.c (GH-15848)
https://github.com/python/cpython/commit/a511c7a4961a684db1f8d0ed438822
Steve Dower added the comment:
Thanks Pablo!
--
___
Python tracker
<https://bugs.python.org/issue38090>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
pull_requests: +15504
pull_request: https://github.com/python/cpython/pull/15857
___
Python tracker
<https://bugs.python.org/issue38
Change by Steve Dower :
--
pull_requests: +15505
pull_request: https://github.com/python/cpython/pull/15858
___
Python tracker
<https://bugs.python.org/issue38
Change by Steve Dower :
--
pull_requests: +15506
pull_request: https://github.com/python/cpython/pull/15859
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
New changeset 009ef2955d91e04f62a7159a1c7ddaddbfedc3b6 by Steve Dower (Jeroen
Demeyer) in branch 'master':
bpo-37913: document that __length_hint__ can return NotImplemented (GH-15383)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +15507
pull_request: https://github.com/python/cpython/pull/15860
___
Python tracker
<https://bugs.python.org/issue37
Change by Steve Dower :
--
pull_requests: +15509
pull_request: https://github.com/python/cpython/pull/15862
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 0d7e6a6d2d9e564d670efb6e3705598846de188d by Steve Dower in branch
'3.7':
bpo-38087: Fix case sensitivity in test_pathlib and test_ntpath (GH-15850)
https://github.com/python/cpython/commit/0d7e6a6d2d9e564d670efb6e370559
Steve Dower added the comment:
New changeset 0fccd4ab5b2238b6340901dd0023a1a157852792 by Steve Dower in branch
'3.7':
bpo-38088: Fixes distutils not finding vcruntime140.dll with only v142 toolset
installed (GH-15849)
https://github.com/python/cpyt
Steve Dower added the comment:
Yeah, very strange that. I can only assume that it's launching the venv
redirector directly, rather than the real sys.executable, and we aren't ever
calling set_executable() with the real one anymore.
Dropping this into Lib/multiprocessing/spawn
Change by Steve Dower :
--
pull_requests: +15510
pull_request: https://github.com/python/cpython/pull/15863
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset a39a4c7439ed09069e619c10d30a6d0ec9332d1a by Steve Dower in branch
'master':
bpo-37913: Link to NotImplemented from new docs (GH-15860)
https://github.com/python/cpython/commit/a39a4c7439ed09069e619c10d30a6d
Steve Dower added the comment:
New changeset 206e4c3d3547b024935ea9655f960061dffbb80f by Steve Dower in branch
'3.8':
bpo-38087: Fix case sensitivity in test_pathlib and test_ntpath (GH-15850)
https://github.com/python/cpython/commit/206e4c3d3547b024935ea9655f9600
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 45bc3928e232603a97451dea3106d824b0f7a392 by Steve Dower (Miss
Islington (bot)) in branch '3.8':
bpo-38090: Fix reference leak in ceval.c (GH-15848)
https://github.com/python/cpython/commit/45bc3928e232603a97451dea3106d8
Steve Dower added the comment:
New changeset ed99bb9ca68b37cfaec3629afa67d70289f3ffc7 by Steve Dower in branch
'3.8':
bpo-37913: document that __length_hint__ can return NotImplemented (GH-15383)
https://github.com/python/cpython/commit/ed99bb9ca68b37cfaec3629afa67d7
Steve Dower added the comment:
New changeset c3d679fd398f42a2e489fbe3dab17fac1fb2439c by Steve Dower (Dmitry
Shachnev) in branch 'master':
bpo-37504: Fix documentation build with texinfo builder (GH-14606)
https://github.com/python/cpython/commit/c3d679fd398f42a2e489fbe3dab17f
Steve Dower added the comment:
New changeset aa3b629a09bfcdf26cdfbbf7d6445ae333c0d44d by Steve Dower in branch
'3.7':
bpo-37913: document that __length_hint__ can return NotImplemented (GH-15383)
https://github.com/python/cpython/commit/aa3b629a09bfcdf26cdfbbf7d6445a
Steve Dower added the comment:
New changeset 2ed0ac6bf17d599bc246c513c32710c154e50a64 by Steve Dower (Miss
Islington (bot)) in branch '3.8':
bpo-38088: Fixes distutils not finding vcruntime140.dll with only v142 toolset
installed (GH-15849)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 313f80192a7396ea3e5ab107175afe4c5a017ab8 by Steve Dower (Miss
Islington (bot)) in branch '3.8':
bpo-37504: Fix documentation build with texinfo builder (GH-14606)
https://github.com/python/cpython/commit/313f80192a7396ea3e5ab107175afe
Steve Dower added the comment:
Thanks for the report and the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Windows is definitely affected, and you can run the repro in my first post to
check other platforms.
--
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
New changeset 756eb849d7d968f0a0924fa33b68c62831e8884e by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-37913: document that __length_hint__ can return NotImplemented (GH-15383)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
> hmm I assume _PyDict_GetItemId has different reference semantics?
Pretty sure it's the same. Perhaps we don't have any test coverage for that one?
--
___
Python tracker
<https://bugs.pytho
Steve Dower added the comment:
Closing this as we've resolved it elsewhere. Thanks for the contribution!
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
New changeset 2ec70102066fe5534f1a62e8f496d2005e1697db by Steve Dower (Jordon
Xu) in branch 'master':
bpo-37752: Delete redundant Py_CHARMASK in normalizestring() (GH-15095)
https://github.com/python/cpython/commit/2ec70102066fe5534f1a62e8f496d2
Steve Dower added the comment:
Thanks for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 9cbb97b29eac4b23e916a3233f26b60ac69e335b by Steve Dower
(jdkandersson) in branch 'master':
bpo-37574: Mention helper functions for find_spec documentation (GH-14739)
https://github.com/python/cpython/commit/9cbb97b29eac4b23e916a3233f26b6
Steve Dower added the comment:
The difference is that launching sys._base_executable *without*
__PYVENV_LAUNCHER__ set (because env is not being passed) should lose you
access to anything installed into the venv. You may also need to import
something from the venv in order to see the issue
Change by Steve Dower :
--
pull_requests: +15529
pull_request: https://github.com/python/cpython/pull/15888
___
Python tracker
<https://bugs.python.org/issue38
401 - 500 of 5794 matches
Mail list logo
