Change by Steve Dower :
--
keywords: +patch
pull_requests: +7987
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34225>
___
___
Py
New submission from Steve Dower :
_msvccompiler reads the INCLUDE and LIB environment variables when building and
adds each directory to the command line. However, if any of these end with
os.sep (specifically, '\'), then it will escape the quoting and break the
entire command.
Steve Dower added the comment:
New changeset 5473f061f518aef5367a535999a407305fb12aff by Steve Dower in branch
'master':
bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash.
(GH-8464)
https://github.com/python/cpython/commit/5473f061f518aef5367a535999a407
Change by Steve Dower :
--
pull_requests: +8001
___
Python tracker
<https://bugs.python.org/issue34225>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/issue22062>
___
___
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue1100942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue22062>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 0041d721a6f6b312ef762838d390fc4d64cf5e3a by Steve Dower (Andrés
Delfino) in branch '3.6':
[3.6] bpo-5978: Document that profiling needs cmd/function to return (GH-8515)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue8145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue33289>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue34088>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 8fe9eed937cb69b5e26ac6e36a90b5360eb11277 by Steve Dower (Dong-hee
Na) in branch 'master':
bpo-33476: Fix _header_value_parser when address group is missing final ';'
(GH-7484)
https://github.com/p
Steve Dower added the comment:
Sorry, I meant the docs after the patch. Before, it's fine.
--
___
Python tracker
<https://bugs.python.org/issue30974>
___
___
Steve Dower added the comment:
I think the docs are too specific about the mechanism used here - if we
document *how* it works then we may not be able to make it work correctly (with
a different mechanic) on a different platform.
--
nosy: +steve.dower
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue30974>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 50326927465c3f5c6c0168fc43310c8e97db0a47 by Steve Dower (Elena
Oat) in branch 'master':
bpo-24356: Specify which Python binary will be used with venv (GH-6589)
https://github.com/python/cpython/commit/50326927465c3f5c6c0168fc43310c
Change by Steve Dower :
--
pull_requests: +8043
___
Python tracker
<https://bugs.python.org/issue24356>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue33601>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: -easy
___
Python tracker
<https://bugs.python.org/issue13474>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 83b449d754f4da3be107b508392ef5180f105c8b by Steve Dower in branch
'3.7':
bpo-24356: Specify which Python binary will be used with venv (GH-6589)
https://github.com/python/cpython/commit/83b449d754f4da3be107b508392ef5
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset a71fed0b7596f1c11a2fa6c1b7311157148f5f9f by Steve Dower (Berker
Peksag) in branch 'master':
bpo-8145: Improve isolation_level documentation (GH-8499)
https://github.com/python/cpython/commit/a71fed0b7596f1c11a2fa6c1b73111
Steve Dower added the comment:
New changeset 8f6a7e100d68fddc9fb98f5cbdf1981994360407 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash.
(GH-8464)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 94972d50bda19000bce498bd2c5ace6be9bec711 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
bpo-8145: Improve isolation_level documentation (GH-8499)
https://github.com/python/cpython/commit/94972d50bda19000bce498bd2c5ace
Change by Steve Dower :
--
pull_requests: +8060
___
Python tracker
<https://bugs.python.org/issue8145>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset c3af73d580888b4d444264e79dce6ec0818522cd by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-30237: Output error when ReadConsole is canceled by CancelSynchronousIo.
(GH-7911)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 28bbbdabb1e3601047530febac1b05b7b89dc65e by Steve Dower in branch
'3.6':
bpo-30237: Output error when ReadConsole is canceled by CancelSynchronousIo.
(GH-7911)
https://github.com/python/cpython/commit/28bbbdabb1e3601047530febac1b05
Steve Dower added the comment:
New changeset b7fd73896db5666020e382c010b8da900260ede4 by Steve Dower (Stéphane
Wirtel) in branch 'master':
bpo-34231: PYTHONBREAKPOINT is not documented on python --help (GH-8475)
https://github.com/python/cpython/commit/b7fd73896db5666020e382c010b8da
Change by Steve Dower :
--
pull_requests: +8062
___
Python tracker
<https://bugs.python.org/issue34231>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 3dc8cdf56d056fb7722061ac3b3863e8a385b8de by Steve Dower in branch
'3.7':
bpo-8145: Improve isolation_level documentation (GH-8499)
https://github.com/python/cpython/commit/3dc8cdf56d056fb7722061ac3b3863
Steve Dower added the comment:
New changeset 6332de10c7ff703d7f9cef62969aa68e7d28d075 by Steve Dower in branch
'3.7':
bpo-34231: PYTHONBREAKPOINT is not documented on python --help (GH-8475)
https://github.com/python/cpython/commit/6332de10c7ff703d7f9cef62969aa6
Steve Dower added the comment:
Maybe you could describe what it looks like when it restarts? Or take a
screenshot and share it so we can see what is happening?
--
assignee: -> terry.reedy
components: +IDLE
nosy: +terry.reedy
___
Python trac
Steve Dower added the comment:
Thanks.
There is at least one other log file in the same location as the one you
attached - the log with "core_JustForMe" in the name is what I need to keep
diagnosing this problem.
--
components: +Windows
nosy: +paul.moore, tim.golden,
Steve Dower added the comment:
New changeset d2e902e4fb304f27e4a72356efbc1fc26be3935d by Steve Dower (Franz
Wöllert) in branch 'master':
bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544)
https://github.com/python/cpython/commit/d2e902e4fb304f27e4a72356efbc1f
Change by Steve Dower :
--
pull_requests: +8066
___
Python tracker
<https://bugs.python.org/issue31047>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue34267>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Steve Dower :
--
keywords: +patch
pull_requests: +8068
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34267>
___
___
Py
Steve Dower added the comment:
I have no intention of changing how encodings work in 2.7. Use codecs.open if
you want to specify text IO encoding.
Someone else may be willing to look at it.
--
___
Python tracker
<https://bugs.python.
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue34283>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
> A quick follow-up commit can happen if one uses the web editor to edit more
> than one file
I hadn't thought of that one. Hopefully they'll just fix their bug though :)
I spent a bit of time at the EuroPython sprints making the changes to qui
Steve Dower added the comment:
New changeset b0bf51b32240369ccb736dc32ff82bb96f375402 by Steve Dower in branch
'3.6':
bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544)
https://github.com/python/cpython/commit/b0bf51b32240369ccb736dc32ff82b
Steve Dower added the comment:
No particular reason. Just needs to be added to EXCLUDE_FILE_FROM_LIBRARY in
Tools/msi/make_zip.py
--
___
Python tracker
<https://bugs.python.org/issue34
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
If libffi already has support and just needs to be updated in CPython, then
sure. I thought we'd finished extracting it, but Zach posted aPR link above
that apparently still needs finishing.
However, if libffi doesn't have the support yet then you&
Steve Dower added the comment:
As this is a fail-fast and not an uncontrolled crash, I vote to close as
wontfix.
This only applies to security-fix versions, and it is not exploitable.
--
___
Python tracker
<https://bugs.python.org/issue19
Steve Dower added the comment:
Serhiy is exactly right, but to emphasise, the best way to do paths now is to
use argument clinic with its path_t type. On Windows, .narrow is a flag that
indicates whether you should PyUnicode_FSEncode() any results before returning
them, and .wide is always
Steve Dower added the comment:
I've pushed the new sources for the Windows build, and am about to do the new
binaries.
If someone else gets to updating the references in the CPython repo before I
do, that's fine by me.
--
___
Pyth
Steve Dower added the comment:
Yeah, it definitely shouldn't be a backslash there. The @ isn't my invention,
but last time someone questioned it I couldn't find any public examples, so it
may be an internal Microsoft thing? I'm not totally attached to it, but if you
Steve Dower added the comment:
I agree. We should definitely document it as a change, but I don't think
there's anything useful you can do in the case of a flush failing anyway, so it
seems unlikely that anyone could depend on the return value.
Returning None for success and ex
Change by Steve Dower :
--
keywords: +patch
pull_requests: +8250
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34405>
___
___
Py
Change by Steve Dower :
--
pull_requests: +8251
___
Python tracker
<https://bugs.python.org/issue34405>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset eeca87cf3ce5b866dbb210548e23ee91ec5411f2 by Steve Dower in branch
'3.6':
bpo-34405: Updated to OpenSSL 1.0.2p for Windows builds. (GH-8776)
https://github.com/python/cpython/commit/eeca87cf3ce5b866dbb210548e23ee
Steve Dower added the comment:
New changeset 864a892af38afefb0a0464af298cf09d2e1195f7 by Steve Dower in branch
'master':
bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (GH-8775)
https://github.com/python/cpython/commit/864a892af38afefb0a0464af298cf0
Steve Dower added the comment:
Are those bugs? On Windows, they are spelled with that casing (and while NTFS
is case-insensitive, it *is* case-preserving).
Whatever package you have used for cross-compiling may have renamed them
(similarly Shlwapi.h). In which case, perhaps you could
Steve Dower added the comment:
> Stop relying to case insensitive filesystem makes sense to me.
If this is the case, then we need to normalise the casing to match the actual
files (which are mixed-case, not lowercase). You just broke this with your PR :)
So which is it? Do we match
Steve Dower added the comment:
> whatever might be the 'right' solution, it's always an advantage to
> have a consistent codebase.
Not when you are consistently wrong, it's not.
Let's figure out the right answer here before making many changes to the
codebas
Steve Dower added the comment:
Have you posted to their mailing list to ask why they use different casing from
the official SDK and whether they would consider supporting both (via symlink,
presumably)?
I think it would be strange for CPython to add a style rule for a non-supported
toolset
Steve Dower added the comment:
> The current situation is that 100% of the windows includes are lowercase and
> allow cross compilation.
Please be precise with what you are saying - the "current situation" is only so
because you proposed changes and got them merged without p
Steve Dower added the comment:
One other thing, I have come across some CI configurations recently where TEMP
is not the best choice (e.g. when it's a mount point in a VM/container). It
seems likely that at some point we'll centralize the "working directory" for
the test
Change by Steve Dower :
--
nosy: +eric.snow, vstinner
___
Python tracker
<https://bugs.python.org/issue34408>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: +easy
versions: -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/issue34365>
___
___
Python-bugs-list m
Steve Dower added the comment:
As someone who has written MSDN samples, I'll spoil the secret and let you know
that there's no consistency there, so you can find examples to prove either
direction ;)
I wasn't expecting expertise or research. I was only expecting a description
Steve Dower added the comment:
Can you be more precise about which versions are affected and any other system
configuration you have (firewalls, network security software, enterprise
configs, etc.)?
I have been using pip quite happily on 1803, so it's certainly not widespread
enou
Steve Dower added the comment:
Can you please provide the full set of logs for the Python 3.7 install?
(They'll be in %TEMP%, and there will be quite a number of them.)
--
versions: +Python 3.7
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
Also, if you could provide some instructions on how to validate the issue you
are reporting. Right now, I'm not even sure what you are seeing that is the
problem.
--
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
Would you consider adding your test suite into the regression tests as well?
Right now, this is a well known issue on all platforms, but there is no clear
universal solution. If your approach works well for all platforms and does not
adversely impact any of
Steve Dower added the comment:
New changeset 216b745eafa7cd4a683a8405dcfbd7f5567f504c by Steve Dower
(Przemysław Spodymek) in branch 'master':
bpo-33635: Handling Bad file descriptor in Path.is_file and related. (GH-8542)
https://github.com/python/cpyt
Steve Dower added the comment:
Unfortunately, I don't have any better suggestion than trying to get your
company policy changed :(
The "clean room" feature of our installer is not configurable (and also not in
our code, so we can't change it without going through the ups
Steve Dower added the comment:
We're totally okay with you using a different installer if you want. We know
and trust Anaconda, and while they do things differently, if that model works
for you then it'll be fine.
Python 3.7 shouldn't need any registry settings or environme
Steve Dower added the comment:
Agreed with not putting platform-specific details everywhere, but in this case
we can probably have a generic wording for "Blocks for `timeout` seconds as
best as is available on the current operating system".
It is a general problem across all ti
Steve Dower added the comment:
New changeset aada63b20ec64bbfc4f2fb0718fc563eedbdd36a by Steve Dower (Brendan
Gerrity) in branch 'master':
bpo-34062: Add missing launcher argument and make behavior consistent between
short and long arguments (GH-8827)
https://github.com/pyth
Steve Dower added the comment:
Thanks, Brendan!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
It looks like you have some sort of network protection software that is not
allowing the installer to download certain files.
Try running the installer with the "/layout [directory]" option to pre-download
all the files you need from a machine that
Steve Dower added the comment:
Works on VSTS build. I suspect AppVeyor is caching files between builds, but
I'm not familiar enough with the configuration to fix that.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset 3876af4f7c2ef87db6d2d83efc229955968926dd by Steve Dower (Brendan
Gerrity) in branch 'master':
bpo-34565: Change a PC/launcher.c comment to accurately describe valid major
versions. (GH-9037)
https://github.com/python/cpyt
Steve Dower added the comment:
Woo! Thanks Raymond!
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue34637>
___
___
Python-bugs-list mailin
Change by Steve Dower :
--
pull_requests: +8639
___
Python tracker
<https://bugs.python.org/issue34405>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Have a look in the Tools/msi directory. The "build.bat" and "buildrelease.bat"
files will generate the installers and other packages (note that you may need
.NET 3.5 enabled on your machine).
You may also be able to use the make_zip.py scr
Steve Dower added the comment:
I'd still rather put the redefinitions in our files that need it, and leave end
users untouched.
--
___
Python tracker
<https://bugs.python.org/is
New submission from Steve Dower :
Thanks, David!
I'm partway through most of these changes (as well as some other improvements)
in my PR at https://github.com/python/cpython/pull/9210/files, so if it's all
the same to you, I'll make sure I've covered everything you&#x
Steve Dower added the comment:
Co-opting this bug for my own PR, that will include these changes as well as
generating JUnit-format test results and publishing them in Azure Pipelines
builds.
--
assignee: -> steve.dower
components: +Build, Tests
title: VSTS builds should use
Change by Steve Dower :
--
pull_requests: +8734
___
Python tracker
<https://bugs.python.org/issue34582>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
In that case, you are asking for a new feature development that we have
previously decided is not in the best interests for us to provide (in that it
leads to more upgrade and installation issues than a more controlled
installer). If you are prepared to write
Steve Dower added the comment:
It looks like _contextvars has both its own project and is also built as part
of pythoncore.vcxproj.
However, _contextvars.vcxproj is not in PCbuild.sln, which means when you build
through Visual Studio (rather than with build.bat via pcbuild.proj), you don&#
Steve Dower added the comment:
Shouldn't need VS for this change (updating the SLN file generally does need
it). I'm happy to do it though.
In case someone else gets to it before me:
* delete _contextvars.vcxproj and remove all references from PCbuild and
Tools/msi
* add _c
Steve Dower added the comment:
Ned - I don't think this is necessarily a release blocker, as we've been
shipping it for a long time, but it would be nice if we can hold 3.7.1rc1 just
long enough to get it in (provided Christian jumps in and says he'll get the
last minor conc
Steve Dower added the comment:
New changeset c6fd1c1c3a65217958b68df3a4991e4f306e9b7d by Steve Dower in branch
'master':
bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158)
https://github.com/python/cpython/commit/c6fd1c1c3a65217958b68df3a4991e
Change by Steve Dower :
--
pull_requests: +8789
___
Python tracker
<https://bugs.python.org/issue32533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 1a107eea8e91e50c5c9025e945c78eb1aa9b874d by Steve Dower in branch
'3.6':
bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158)
https://github.com/python/cpython/commit/1a107eea8e91e50c5c9025e945c78e
Steve Dower added the comment:
New changeset 6750922f8d3428d84a016c34d6fcd99659e8610c by Steve Dower in branch
'master':
bpo-34267: Update find_python.bat to use 3.7 if available (GH-8552)
https://github.com/python/cpython/commit/6750922f8d3428d84a016c34d6fcd9
Steve Dower added the comment:
Any reason to not take the current patch for our vendored copy and give it some
exposure at least on platforms that rely on it (maybe just Windows)? I don't
see any reason to wait on another group to "release" it when we need to
manually appl
Steve Dower added the comment:
There's also the view that it'll be easier to justify upstreaming a patch if
it's been released and tested in a separate app. We require that all the time
for Python patches, so why should we expect other projects to be different?
We're
Steve Dower added the comment:
I took a quick look at the patch and the main issue I see is the use of the
MAX_PATH constant. We encourage people to disable this limit where possible, so
using dynamic allocation where we need to reduce the path will be a better way
to avoid this function
Steve Dower added the comment:
New changeset d0f49d2f5085ca68e3dc8725f1fb1c9674bfb5ed by Steve Dower in branch
'master':
bpo-34582: Adds JUnit XML output for regression tests (GH-9210)
https://github.com/python/cpython/commit/d0f49d2f5085ca68e3dc8725f1fb1c
Steve Dower added the comment:
That executable doesn't appear to be in a virtual environment - you should be
running C:\TEMP\venv\abcd\Scripts\python.exe
Does that resolve your problem?
--
___
Python tracker
<https://bugs.python.org/is
3901 - 4000 of 5794 matches
Mail list logo
