Steve Dower added the comment:
This is implemented and merged now. I'll leave it to core-workflow to decide
whether and when to make the builds required and/or reduce use of
Travis/AppVeyor.
--
resolution: -> fixed
stage: patch review -&g
Steve Dower added the comment:
Merged as part of the VSTS PR (it was needed to fix some tests on the Windows
build machine)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bug
Steve Dower added the comment:
New changeset 631753fcc5e88bbbad402933e77295675cfe1fee by Steve Dower (Miro
Hrončok) in branch 'master':
bpo-33559: Document changed repr of exceptions (GH-6943)
https://github.com/python/cpython/commit/631753fcc5e88bbbad402933e77295675cfe1fee
-
Steve Dower added the comment:
It's worth documenting. I'll merge the next PR with the attribution.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
New changeset 54fc49737a6a79f6e2ece16e22b233858b836567 by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-33559: Document changed repr of exceptions (GH-6943) (GH-6950)
https://github.com/python/cpython/commit/54fc49737a6a79f6e2ece16e22b233
Steve Dower added the comment:
New changeset fb9dd8915314d857161de89fcbbb041f2b49fc22 by Steve Dower (Miro
Hrončok) in branch 'master':
bpo-33559: Attribute changed repr of exceptions (GH-6954)
https://github.com/python/cpython/commit/fb9dd8915314d857161de89fcbbb04
Steve Dower added the comment:
> * is there more computers for the tests on VSTS?
I don't know what Travis is giving us, but Microsoft has provided 20 concurrent
builds. They also seem to be more powerful machines, though some caching
features are missing and many builds seem to ta
Steve Dower added the comment:
> I don't think there's a way to make certain checks like VSTS be optional and
> not show up with a red cross on Github
Most of the failures I've seen have been reproducible, so I suspect they're due
to race conditions that
Steve Dower added the comment:
GitHub has broken CSS everywhere right now :) Their oauth page doesn't show
scroll bars either, which means you can't get to the "authorise" button if
you're in more than a couple of organisations.
--
_
Steve Dower added the comment:
I guess that means there is an invalid date comparison going on to detect when
the file has changed. This file doesn't change often, so it's easy to miss :)
All the critical builds should forcibly rebuild it, so this isn't urgent, but
I'll t
Steve Dower added the comment:
Okay, I'll take a look now.
--
___
Python tracker
<https://bugs.python.org/issue33614>
___
___
Python-bugs-list mailing list
Steve Dower added the comment:
Considering we didn't change anything in the sources, I wouldn't expect it to
be fixed.
It doesn't have to block 3.7 if Ned's okay with it, but I'd like to keep this
open and fix the build scripts.
--
resolution: fixed -&g
Change by Steve Dower :
--
keywords: +patch
pull_requests: +6794
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +6800
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset e97ba4c690613d734843db218aeedce2f0e5937f by Steve Dower in branch
'master':
bpo-33614: Ensures module definition files for the stable ABI on Windows are
correctly regenerated. (GH-7165)
https://github.com/python/cpyt
Steve Dower added the comment:
Thanks! I guess we were getting lucky in the past, as that error could have
shown up for any number of reasons...
--
___
Python tracker
<https://bugs.python.org/issue33
Change by Steve Dower :
--
pull_requests: +6804
___
Python tracker
<https://bugs.python.org/issue33614>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue29392>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
I *believe* this change will prevent the issue in the future, so marking this
as fixed. But I wasn't able to reproduce it locally, so there may be something
funny about either the file system or the version of MSBuild on the buildbots
that caused it t
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Already fixed in GH-7169, GH-7176 and GH-7177 (which I apparently typo'd "bpo"
in the commit message, so they didn't link up properly here).
--
resolution: -> fixed
status: open -> closed
Steve Dower added the comment:
Already fixed in GH-7169, GH-7176 and GH-7177
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x
___
Py
Change by Steve Dower :
--
components: +Windows -Demos and Tools
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<https://bugs.python.org/issue33
Steve Dower added the comment:
New changeset 3d3e66c2daebd8e6b18944eac7546168c0006c78 by Steve Dower (Andrés
Delfino) in branch 'master':
bpo-33673: Install python-docs-theme even if Sphinx is already installed
(GH-7163)
https://github.com/python/cpyt
Steve Dower added the comment:
Thanks Larry for merging the backports!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
assignee: -> steve.dower
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 8c1ad0c4f69390fded09012e1ed5242c45753bb4 by Steve Dower (Andrés
Delfino) in branch 'master':
bpo-33670: Expose Sphinx errorlevel (GH-7156)
https://github.com/python/cpython/commit/8c1ad0c4f69390fded09012e1ed524
Steve Dower added the comment:
New changeset 3e51a3d5927c680d5410ff11ff8d5e5bb9ffb1e7 by Steve Dower in branch
'master':
bpo-32878: Adds documentation for st_ino on Windows (GH-5764)
https://github.com/python/cpython/commit/3e51a3d5927c680d5410ff11ff8d5e
Change by Steve Dower :
--
pull_requests: +6825
___
Python tracker
<https://bugs.python.org/issue32878>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue33673>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
Thanks for the contribution! Looks like the automatic backport to 2.7 won't
work, so someone will have to do one manually. I'm happy to hit merge on a PR
(whoever does it, make sure you follow the backport naming rules in the PR
template).
-
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 325320d5f5a4480a6f4f92dcf86b9dbb7eb5c791 by Steve Dower in branch
'3.6':
bpo-32878: Adds documentation for st_ino on Windows (GH-5764) (GH-7190)
https://github.com/python/cpython/commit/325320d5f5a4480a6f4f92dcf86b9d
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Please create a new issue. This one is closed.
--
___
Python tracker
<https://bugs.python.org/issue29326>
___
___
Python-bug
Steve Dower added the comment:
New changeset 5583ef4777452e79278de80755d403f1c5b7781d by Steve Dower (Andrés
Delfino) in branch '2.7':
[2.7] bpo-33670: Expose Sphinx errorlevel (GH-7156). (GH-7201)
https://github.com/python/cpython/commit/5583ef4777452e79278de80755d403
Steve Dower added the comment:
Thanks!
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
New changeset 05f1c8902c78dce66aed067444e2b973221bae2b by Steve Dower (Andrés
Delfino) in branch 'master':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
https://github.com/python/cpyt
Steve Dower added the comment:
The python._pth file generated for the embeddable distribution includes ".",
which allows you to import from the dist directory. The blank line should be
ignored.
If you want to misuse the embeddable distribution by not restricting its search
pat
Steve Dower added the comment:
If your ._pth includes `import site`, then including a blank line in a
`anything.pth` file should add the entry.
Alternatively, if you can add "import sys; sys.path.insert(0, '')" to the start
of your code that depends on i
Steve Dower added the comment:
The uploaded binary is compiled with PGO enabled (and trained on most of the
test suite). I'll check it out - hopefully we don't need to do anything drastic
and can get away with either a compiler update or disabling optimizations on a
singl
Steve Dower added the comment:
Ned, FYI
--
nosy: +ned.deily
priority: normal -> release blocker
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
A crash in the test suite should be fixed, especially since we have protection
against this crash (and a test that validates it).
In this case, apparently the stack allocation for each frame of r_object grew
and now there isn't room for 2000 calls (the
Steve Dower added the comment:
I need to stop working on this right now, but here's the locals layout in a
normal release build in r_object:
@rdi @rdip = 0x0034`655ea3d0
0034`65403f60 @rsp+0x0080 v = 0x000
Steve Dower added the comment:
FYI, I posted the problem at
https://developercommunity.visualstudio.com/content/problem/265778/pgo-generates-large-stack-frame.html
(I _think_ it's public).
Until then, it's probably best to reduce the recursion limit. Going to a depth
of 1000
Steve Dower added the comment:
Are we sure we haven't actually regressed something here and it's actually
taking more resources? I can't tell from this discussion if it's memory CPU,
disk or time that we're hitting problems.
I'll have to look at the VSTS b
Change by Steve Dower :
--
pull_requests: +7027
___
Python tracker
<https://bugs.python.org/issue33720>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Ned - PR 7401 fixes the crash at the cost of reducing the permitted recursion
depth in marshal.
Your call whether we take this fix or disable PGO, but I'd much rather take
this fix (PGO has full-interpreter effects whereas this is very narrow). When I
Steve Dower added the comment:
New changeset 2a4a62ba4ae770bbc7b7fdec0760031c83fe1f7b by Steve Dower in branch
'master':
bpo-33720: Reduces maximum marshal recursion depth on release builds. (GH-7401)
https://github.com/python/cpython/commit/2a4a62ba4ae770bbc7b7fdec076003
Steve Dower added the comment:
Thanks. I merged, and miss-islington is backporting it. I guess at this stage
you're manually cherry-picking into your own 3.7 branch for release? I'll merge
for 3.7.1 though.
--
___
Python track
Steve Dower added the comment:
Thanks. Agreed this should stay open, but it is blocked on a compiler fix.
--
___
Python tracker
<https://bugs.python.org/issue33
Steve Dower added the comment:
I'd already started discussing this with the VSTS team, it seems to be a bug on
their side.
The "build not retained" state just means it'll get cleaned up after seven
days. People with login access can mark a build to be kept permanently,
Steve Dower added the comment:
Did you have a previous install? It looks like it is registered but somehow you
don't have the ability to replace it.
If you're comfortable with using regedit.exe, you could try renaming
SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{9d1b786e
Steve Dower added the comment:
Right. This build failed to start, which is why there's only one section on the
left hand side (normally you'll see all the build steps there, and clicking on
them will show their logs).
I think it'll be an internal race condition. I'll pas
Steve Dower added the comment:
Just anything. I often put "deleteme" in as a reminder. Once you've got it all
working you can delete it, but for now you just want the installer to be able
to make a key with that name.
--
___
Steve Dower added the comment:
Hmm... okay, we might just need to delete it completely then.
--
___
Python tracker
<https://bugs.python.org/issue33779>
___
___
Steve Dower added the comment:
Okay, I guess there's some configuration (or corruption) on your machine that's
interfering here. I've seen similar things before on IT-managed workstations.
Can you try deselecting the "Install launcher for all users" option and
Steve Dower added the comment:
I'm okay to add it to the manifest for both in 3.8, along with a What's New
entry.
High DPI screens are very common though, and adding it to existing releases
won't allow existing apps or frameworks to account for the change. I don't want
Steve Dower added the comment:
Yep, that should be fine.
If you want to add it to the winapi module rather than use ctypes that's fine
too.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset 0e5f901508dea6437dc9ee89b434feca721d45be by Steve Dower (Andrés
Delfino) in branch 'master':
bpo-33831: Make htmlview run again (GH-7628)
https://github.com/python/cpython/commit/0e5f901508dea6437dc9ee89b434fe
Change by Steve Dower :
--
pull_requests: +7256
___
Python tracker
<https://bugs.python.org/issue33831>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
There's no option to omit ctypes, though I am aware of some custom builds of
Python that exclude it. I don't think you need to worry about those being used
for IDLE (but of course the general policy of the stdlib not relying on ctype
Steve Dower added the comment:
Hopefully there aren't that many more fixes needed to this scripts - you've
done a great job clearing up the issues!
Any reason not to merge right now? I notice your commit message simply reads
"
Steve Dower added the comment:
New changeset 42ca8367ceb59021bbf5e5fb4fd0268d3411c0a4 by Steve Dower (Andrés
Delfino) in branch '2.7':
bpo-33845: Update Doc\make.bat on 2.7 to bring it on par to master version
(GH-7667)
https://github.com/python/cpyt
Steve Dower added the comment:
Merged!
We don't normally change the name (except to update the GH-7667 reference at
the end), but once there's more than one commit GitHub will use the PR title
instead of the commit message.
--
assignee: -> steve.dower
resolution: -
Steve Dower added the comment:
For the NEWS entry, I'd suggest putting "Library" for the category and use your
commit message for the text at the end.
You should also fill out the CLA form posted in your PR by the bot. While we
*can* overlook it for very simple changes, best
Steve Dower added the comment:
New changeset b36b0a3765bcacb4dcdbf12060e9e99711855da8 by Steve Dower
(ValeriyaSinevich) in branch 'master':
bpo-33663: Convert content length to string before putting to header (GH-7754)
https://github.com/python/cpyt
Steve Dower added the comment:
What about existing code that assumes the GIL is already held?
Also, your patch addresses many more situations than raised here, most of which
are unnecessary (GetProcAddress and GetModuleHandle don't block in the way that
LoadLibrary and FreeLibrar
Steve Dower added the comment:
Congratulations on your first contribution, Valeriya! Let us know when you find
something else you'd like to work on (you can add my name to the "Nosy List" on
the bug and it'll get my attention).
--
resolution: -> fi
Steve Dower added the comment:
Yeah, just after posting I remembered that the blocker is the loader lock and
not filesystem/arbitrary code.
Still, "I don't think" isn't sufficient to justify making the change in 3.7 or
earlier. If we can show that properly working c
Steve Dower added the comment:
Considering all we can do is pass the reports onto the team (which I've been
doing), there's no point repeatedly opening new issues for the same problem.
--
resolution: -> duplicate
superseder: -> VSTS Windows-PR
Change by Steve Dower :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33915>
___
___
Python-bugs-list
Steve Dower added the comment:
It appears to be a known issue when a PR is retriggered (due to new commits)
early enough in the CI run. I haven't got any info about when it'll be fixed.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
This is by design. If you want to install packages into a directory that
includes the embeddable zip, you'll need either the matching full install of
Python or the Nuget package and use the "--target" argument to pip to put the
packages in your
Steve Dower added the comment:
Oh, and issue24960 is not the same. That one is related primarily to having the
entire standard library in a zip file. That may be the case for the embeddable
distro, but the embeddable distro is also not intended to support installing
packages itself, so it
Steve Dower added the comment:
There's a command to generate that file though I forget what it is. The
embeddable distro does not support installation, though it may work sometimes
(it's still the same Python binaries).
Try going to nuget.org, search for Python and install on
Steve Dower added the comment:
For Windows it would be best (though slower) to pass the paths through
os._getfinalpathname before comparison. Detecting that function is an easy way
to get the platform right, too.
Unfortunately, the MSDN docs don't make clear that the VSN can be mod
Steve Dower added the comment:
The benchmark may not be triggering that much work. NFKC normalization only
applies for characters outside of the basic Latin characters (0-255).
I ran the below benchmarks and saw a huge difference. Granted, it's a very
degenerate case with collections
Steve Dower added the comment:
> outside of the basic Latin characters (0-255)
This should be (0-127). The Latin characters in 128-255 are considered extended
ones, and may be decomposed by normalization.
--
___
Python tracker
<
Steve Dower added the comment:
Also please include your sys.version. It is possible to launch Windows
applications from WSL, which means we need to know if you ran the Linux version
or the Windows version (though it sounds like it was a Linux version which
means MS_WINDOWS is not defined
Steve Dower added the comment:
New changeset 9b9d58f0d88b338eb8d2ae0da5cd91d60d1b0e39 by Steve Dower (Thomas A
Caswell) in branch 'master':
bpo-31546: Fix input hook integration (GH-7978)
https://github.com/python/cpython/commit/9b9d58f0d88b338eb8d2ae0da5cd91
Steve Dower added the comment:
New changeset 9d92524c11def666a78ff57a9603a9ad6142418a by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-31546: Fix input hook integration (GH-7978)
https://github.com/python/cpython/commit/9d92524c11def666a78ff57a9603a9
Steve Dower added the comment:
We'll need you to attach the logs and try rebooting, as described earlier in
this thread.
--
___
Python tracker
<https://bugs.python.org/is
Change by Steve Dower :
--
nosy: +davin, pitrou
___
Python tracker
<https://bugs.python.org/issue33997>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I agree.
I don't think we deliberately changed anything here. Possibly the sphinx theme
has some CSS that doesn't work well in IE, so that should be the starting point
for someone to look.
--
___
Pyth
Steve Dower added the comment:
It's pretty annoying when HTML Help doesn't properly handle your screen scaling
settings (guessing my new screenshot looks like gladman's).
I'd love to have a new HTML Help program for our docs that could handle this
better, but there&#
Steve Dower added the comment:
Let's try adding that screenshot again...
--
Added file: https://bugs.python.org/file47662/NarrowCHM.png
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
> I want to deprecate chm because it uses legacy HTML ...
Agreed, but not without a replacement.
--
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
1. What do you mean by "listed twice"? I see 32-bit and 64-bit copies, but
that's expected as they may show different modules.
2. We don't control HTML Help Reader's memory, so that's not an option
unfortunately. We also don'
Steve Dower added the comment:
Thanks for writing that second PR, Serhiy! I'd already spotted that as the
likely fix on our side, though I do want to complete the investigation into why
MSVC generated unnecessarily sparse frames. But that is basically an internal
discussion for me to f
Steve Dower added the comment:
I added the backport to 3.7 label to your PR, as I want to restore the marshal
stack depth limit in 3.7.1.
--
___
Python tracker
<https://bugs.python.org/issue33
Steve Dower added the comment:
Not sure, though I have thought about it a bit. And as with the embeddable
package, I wouldn't want it finding a global install anyway. So this probably
isn't an issue. (I'm pretty sure I also changed the version string to be
statically initia
Steve Dower added the comment:
It's deliberate (and documented, IIRC). You should include the C and C++
runtimes in your application installer.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python t
Steve Dower added the comment:
The "for example" line is the fix, it really is very simple. That said, we have
no automatic validation for the launcher, and coming up with a good set of
manual tests to check it is certainl
Steve Dower added the comment:
Amin, it looks like you are trying to upgrade an all-users install of an
earlier version of Python 3.7 (one of the betas?) to a just-for-me install.
If you know which older version you have installed, or you can find it in
Programs and Features, I'd su
Steve Dower added the comment:
The behavior is correct, so the documentation needs fixing.
Which page has that example on it? Is it assuming that you only have 3.1
installed?
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@pyt
Steve Dower added the comment:
> wmic cpu ...
This is the WMI solution we are trying to avoid.
But then again, if it's solely for our tests, perhaps the best way to approach
this is to start a Python thread that periodically runs this command?
I also haven't seen it suggested
Steve Dower added the comment:
> It would probably be simpler to change the policy and allow (at least some)
> some third party libs in cPython's test suite. =)
I'm actually totally okay with this, as I'd really like to have JUnit XML
output from the test suite, which
Steve Dower added the comment:
New changeset ce75df3031c86b78311b1ad76c39c0b39d7d7424 by Steve Dower
(ValeriyaSinevich) in branch 'master':
bpo-30237: Output error when ReadConsole is canceled by CancelSynchronousIo.
(GH-7911)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +7877
___
Python tracker
<https://bugs.python.org/issue30237>
___
___
Python-bugs-list mailing list
Unsubscribe:
3801 - 3900 of 5794 matches
Mail list logo
