Change by Steve Dower :
--
assignee: -> terry.reedy
components: +IDLE
nosy: +terry.reedy
___
Python tracker
<https://bugs.python.org/issue31663>
___
___
Py
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue31663>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue31662>
___
___
Pyth
Steve Dower added the comment:
New changeset d6201cb0e865dad116ffe46e5ea3d02e8eeb42c1 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-31662: Fix typos in uploadrelease.bat script (#3858)
https://github.com/python/cpython/commit/d6201cb0e865dad116ffe46e5ea3d0
Steve Dower added the comment:
We may just need to special case some well known exception codes for MSVC and
the CLR, though if they're handled we may be dumping on the first chance and
not the second chance handling.
If I get a chance to dig into the docs and code I'll take a look
Steve Dower added the comment:
Agreed, and the underlying cause is also linked to the registration being wrong
in some other ways.
The fix requires rearchitecting the installer again, though less dramatically
than last time. Won't happen for3.6.4, but we might get 3.7.
--
ver
Change by Steve Dower :
--
keywords: +patch
pull_requests: +3871
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 2084b30e540d88b9fc752c5bdcc2f24334af4f2b by Steve Dower in branch
'master':
bpo-31523: Reliability improvements to the Windows build files (#3900)
https://github.com/python/cpython/commit/2084b30e540d88b9fc752c5bdcc2f2
Steve Dower added the comment:
New changeset 051295a8c57cc649fa5eaa43526143984a147411 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-31523: Reliability improvements to the Windows build files (GH-3900)
(#3902)
https://github.com/python/cpyt
Steve Dower added the comment:
Build artifacts (static libraries, in this case) are not compatible, but the
built binaries are.
This may be a reasonable argument for not updating distutils's support in minor
versions (and I'm totally happy to just stop updating distutils period
Steve Dower added the comment:
> How about giving priority to VS 2015
That would be the fix, but it's not worth releasing an immediate 3.6.4 IMHO and
by the time 3.6.4 comes about it could be more pain to change back than to
leave it. That's the balance I'm thinking
Steve Dower added the comment:
No, but if we need to do 3.6.4 quickly for another reason, let me know and I'll
make this change.
It only affects people who are trying to share intermediate build files (which
for MSVC purposes, includes static libraries) between their 3.6.2 and 3.6.3
b
Steve Dower added the comment:
Haven't had a chance to test this, but I suspect our change should depend on
what happens when a C++ exception is actually unhandled.
In this case, the following sequence has occurred:
* exception is raised
* debug event is raised (if a debugger is att
Steve Dower added the comment:
Okay, just tested taking out the C++ handler and it goes straight to an error
report. Not ideal, especially since the error is logged against "python.exe"
and "ucrtbase.dll" (which is going to make my life harder when reviewing the
submitted
Steve Dower added the comment:
> Is it possible to be asked to be called as the last handler ...
Unfortunately not, since the stack-based handlers always come after the vector
handlers, and C++ handlers written using try/catch will always be stack-based.
It may be interesting
Steve Dower added the comment:
"OSError: [Errno 0] Error" typically means that OpenSSL failed due to a Windows
error, but we assumed it failed due to a POSIX error and so read the wrong
error number (errno instead of GetLastError()).
It's worth testing with Python 3.7.0a1, sin
Steve Dower added the comment:
> The commit for this bug (720f0cf580e2) introduces encoding and errors
> arguments but doesn't actually document what the values of these should be
Do you mean it doesn't document that they take the normal encoding/errors
arguments that all the
Steve Dower added the comment:
Really, this is just an alias for universal_newlines in Popen.__init__. So we
add the parameter and:
+if text:
+universal_newlines = True
self.universal_newlines = universal_newlines
And 99% of the change is making it clear in the docs why we
Steve Dower added the comment:
> just an alias
Which I recognise is in the bug title. My point is that the enhancement itself
is less relevant than the rationale and the documentation.
Without a doc patch, there's really nothing to discuss here other than
duplicating APIs (
Steve Dower added the comment:
Can you try moving the installer exe to its own (empty) directory before
running it?
The correct file is on the server (I just redownloaded and verified), so the
most likely cause is that you ran a /layout at some point in the past and are
getting that file
Steve Dower added the comment:
FWIW, all your assumptions about how it should work are correct. If you don't
know how the files got there instead of a randomly generated temporary path,
then I don't know either. /layout is the only time we download anything to a
non-temp
Steve Dower added the comment:
Are you able to install .NET 3.5 on the Windows 10 machine? This is basically a
requirement for the VC9 toolset (it's compatible with .NET 2.0 so should fulfil
that requirement).
--
___
Python tracker
&
Steve Dower added the comment:
I don't remember exactly how VS 2008 handled the installation, but it likely
wasn't designed with Windows 8 in mind :)
I believe since Windows 8, the Windows Features approach is the correct way to
install it, and I'm not even sure you can down
Steve Dower added the comment:
Duplicate of issue23246. AFAIK, nothing has changed since then.
The PR in its current form is not acceptable - there is a totally reliable
registry key for finding the compiler, which is better than guessing a path.
See the code in setuptools (and also make the
Steve Dower added the comment:
The fix is simple, just need someone to do a PR. (I might get to it eventually,
but I'm working on other things right now.)
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
And yes, I think this is fine for 3.6.
--
___
Python tracker
<https://bugs.python.org/issue31546>
___
___
Python-bugs-list mailin
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
The installed item entries on Windows (since some recent update, I believe)
only display "Uninstall" and do not let you select "Modify".
This is because we enabled the setting that used to display "Uninstall/Modify"
as a single
Change by Steve Dower :
--
keywords: +patch
pull_requests: +4240
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +4242
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31609>
___
___
Python-
Change by Steve Dower :
--
assignee: -> steve.dower
versions: +Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue31609>
___
___
Python-
Steve Dower added the comment:
New changeset aed08562220974b5c67371b908f23caa1be07e38 by Steve Dower in branch
'master':
bpo-31609: Fixes quotes in PCbuild/clean.bat (#4280)
https://github.com/python/cpython/commit/aed08562220974b5c67371b908f23c
Steve Dower added the comment:
New changeset 0d2a9088d16826343344b04461c8be44b4008710 by Steve Dower in branch
'master':
bpo-31944: Fixes build and Modify button (#4278)
https://github.com/python/cpython/commit/0d2a9088d16826343344b04461c8be
Steve Dower added the comment:
New changeset 40708cc7d2361518a2784afedf495eafcc099de5 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
bpo-31944: Fixes build and Modify button (GH-4278) (#4284)
https://github.com/python/cpython/commit/40708cc7d2361518a2784afedf495e
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset f4443562345130c991fded3dc3b02b94aee0f362 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
bpo-31609: Fixes quotes in PCbuild/clean.bat (GH-4280) (#4285)
https://github.com/python/cpython/commit/f4443562345130c991fded3dc3b02b
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
assignee: -> steve.dower
stage: -> needs patch
type: -> compile error
versions: +Python 3.6
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +4260
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 30f4fa456ef626ad7a92759f492ec7a268f7af4e by Steve Dower in branch
'master':
bpo-31957: Fixes version detection. (#4298)
https://github.com/python/cpython/commit/30f4fa456ef626ad7a92759f492ec7
Steve Dower added the comment:
New changeset a6ffec2e88437ed4fecb10cb359cf2fb64781e9a by Steve Dower (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-31957: Fixes version detection. (GH-4298) (#4300)
https://github.com/python/cpython/commit/a6ffec2e88437ed4fecb10cb359cf2
Steve Dower added the comment:
Not sure how much we can do about this, but you may want to try with Python
3.7. Eric and Nick have been working on streamlining startup, which includes a
lot of work (thanks Eric!) to remove static variables.
Don't expect a fix in Python 3.6 for this
Steve Dower added the comment:
I don't think the refleak handling would detect leaks across
PyInitialize/PyFinalize calls anyway.
Really, we probably just need to loop Initialize/Finalize a few hundred times
and measure the memory usage of the process before/after. That will handle a
Steve Dower added the comment:
New changeset fd0fa67464f75cebca67cd14d050476a0c73bd53 by Steve Dower
(native-api) in branch 'master':
bpo-31691: Specify where to find build instructions for the Windows installer
(#4426)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset c02307e9634583d3f2660e46b5200bf0b282695a by Steve Dower
(native-api) in branch '2.7':
bpo-31691: Specify how to build installer in Windows (#4430)
https://github.com/python/cpython/commit/c02307e9634583d3f2660e46b5200b
Steve Dower added the comment:
Thanks for the PR!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> crash
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
New changeset 0a6158ca392adfdfbeb7eb43d8d8109c02b00d23 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
bpo-31691: Specify where to find build instructions for the Windows installer
(GH-4426) (#4431)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset c69611990365ae2f2efffd191de0aba9ee98d95c by Steve Dower
(native-api) in branch '3.6':
bpo-31691: Specify where to find installer build instructions for Windows
(#4427)
https://github.com/python/cpyt
Steve Dower added the comment:
SetUnhandledExceptionFilter could be a good option.
I suspect the difference between that and AddVectorContinueHandler are because
of the weird prioritization of the two types of handler, and are probably not
significant enough to worry about here
Steve Dower added the comment:
> Got the same issue with the 3.6 installer
You've got a different issue, but I can't tell what it is without all of the
logs. Can you look in your %TEMP% directory for the file you attached, and then
also include those with th
Steve Dower added the comment:
Those examples look fine to me
--
___
Python tracker
<https://bugs.python.org/issue32122>
___
___
Python-bugs-list mailin
Steve Dower added the comment:
I'm not sure there will be any good fix for this. We might be able to coerce
proper utf-8 output from Sphinx, and if it also adds the encoding tags required
by whatever ancient version of Internet Explorer is used then it should be fine
It's likely ju
Steve Dower added the comment:
Does this only affect Python 3.5? We're highly unlikely to take a fix for that
version.
This code was rewritten for 3.6, so it wouldn't surprise me if there is no
longer an issue.
--
nosy: +larry
___
Pyth
Change by Steve Dower :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue32280>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
nosy: +ncoghlan
___
Python tracker
<https://bugs.python.org/issue32280>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
If you can't compile, security fixes aren't worth anything. And while we don't
support XP, the v140_xp toolset is in more of a grey area. There are real ways
you could be forced into using it besides targeting XP.
Max - I'd rather just rem
Steve Dower added the comment:
I changed the default Windows SDK version at some point, because it was falling
back to v8.1 and we really ought to use v10. It auto-detects all the v10
versions, so I'm guessing you haven't got any of them installed right now.
The dev guide ju
Steve Dower added the comment:
Strange, that should have been installed.
Do you see rc.exe anywhere in "C:\Program Files (x86)\Windows Kits\10"? If not,
might need to repair the SDK you just installed. It shouldn't be a separate
option from anythin
Steve Dower added the comment:
Is there one in x86 as well? Perhaps it isn't finding x64 tools properly (I've
seen this once or twice in the past with VS 2015, but I think it was fixed at
some point)
--
___
Python tracker
<https://bu
Steve Dower added the comment:
It shouldn't be any different, but what about PCBuild/build.bat?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I thought we'd special cased the v14 toolset already.
This should be an update to the Python code in distutils that selects the
filename based on compiler version.
--
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
Are you using a normal command prompt or the Visual Studio one? Totally clean
environment should work fine these days, but I suspect there's an environment
variable affecting something.
"set" to show everything that is set, remove any personal i
Steve Dower added the comment:
This is the bit that needs fixing
https://github.com/python/cpython/blob/master/Lib/distutils/command/bdist_wininst.py#L340
bv = '.'.join(CRT_ASSEMBLY_VERSION.split('.', 2)[:2])
if bv == '14.11':
Steve Dower added the comment:
Happy for someone else to do it. I won't have time this week - too much going
on at work.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
It has been resolved in master, so we just need to backport
PCbuild/python.props to get it in earlier branches.
--
___
Python tracker
<https://bugs.python.org/issue32
Steve Dower added the comment:
The more interesting part is the relative directory and how often is it
resolved? Can you change a program's imports by inducing it to change its
working directory immediately after startup (or before any lazy imports)? If
so, we should resolve it to a
Steve Dower added the comment:
> A compromise would be to refuse to start on "python3 -I directory" to remain
> secure
What would that achieve, considering that "python3 -I directory/__main__.py"
would let you start with exactly the same sys.path?[*]
The only c
Steve Dower added the comment:
Please don't rush this in, at least for Windows. I deliberately decided to keep
the included pyd files untagged for a reason, and need to recall what that was.
(It might be in the issue when we added the tags.)
Considering a .pyd file linking ag
Steve Dower added the comment:
Apparently Tk has something in its e_capi.c file that does not work with the
latest SDK (I guess they're redefining macros).
In master, we use prebuilt binaries, which is why this is not a problem. But
we'll either need to fix Tk's sources or ba
Steve Dower added the comment:
Totally okay with this in theory, but wanted to clarify that the linked PR is
really just taking advantage of removing the guarantee?
That is, the change isn't necessary to remove the requirement.
--
___
P
Steve Dower added the comment:
Which libraries break? And which version of Windows are you running on?
If TCP_KEEPCNT was only added recently (perhaps in an SDK update) then it may
not really be available on all versions.
(+Ned for awareness of the regression - not sure we need to respin
Steve Dower added the comment:
Good to know. As I said on the other issue, Windows won't load extension
modules built for a different version anyway unless they use the stable ABI, so
there's no real reason these flags need to be binary compatible between 3.x
Steve Dower added the comment:
Yeah, I updated the build machine before doing 3.6.4rc1 (I never update between
rc and final releases). I'm intrigued to see why it breaks libraries though -
typically unsupported enum values like this are silently ignored on older
Windows ver
Steve Dower added the comment:
Yes, I recognise that the change happened. I don't understand what breaks as a
result.
You said it breaks "many libraries" - can you name some of them and provide
sample code?
--
___
Python
Steve Dower added the comment:
Okay, so it looks like we don't have any prior art to conditionally omit
constants from _socket based on OS level, and nothing in the setsockopt() doc
suggests that it may fail like this.
So we either need to explicitly exclude this symbol on Windows (at
Steve Dower added the comment:
I agree that explicitly normalizing in PC/getpathp.c is the correct approach.
As far as I'm aware, GetModuleFileNameW(NULL) can never fail other than a
buffer that is too small, so that whole function can probably be simplified to
abort if it happens and
Change by Steve Dower :
--
stage: -> needs patch
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue32457>
___
___
Python-
Steve Dower added the comment:
Have you confirmed that's a problem? There are new compatibility promises that
did not exist for earlier versions of the runtime, but that does not mean there
are no bugs.
--
___
Python tracker
&
New submission from Steve Dower :
There's enough instability due to using the proper UCRT installer (e.g.
issue25546, issue25954, also others not reported on bpo) and good enough
install base that we can simplify things by just installing it locally on
machines that require it.
This may
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
superseder: -> Change Windows install to applocal UCRT
___
Python tracker
<https://bugs.python
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
superseder: -> Change Windows install to applocal UCRT
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
It is standard procedure for us to stop producing binary releases when a
version switches to security-only mode. The burden on our volunteers would
become overwhelming otherwise.
If you'd like to propose a change to this policy, start by posting on
python
Change by Steve Dower :
--
keywords: +patch
pull_requests: +4986
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue29911>
___
___
Python-
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +4984, 4985
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +4984
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
This will be fixed by the change for 3.7, and it's enough of an edge case for
3.6 that I'm okay with not fixing it.
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
superseder: -> Change Windo
Change by Steve Dower :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The change to make OpenSSL a separate DLL (on Windows, at least, which is all I
really care about) means this function is available via ctypes. That's good
enough for me, so I'll close this.
--
resolution: -> out of date
stage: patch revie
Steve Dower added the comment:
New changeset af11a15c586e980a157c04ee60b6e33dc7228f3f by Steve Dower (Max
Bélanger) in branch 'master':
bpo-32282: Remove unnecessary check for `VersionHelpers.h` in `socketmodule.c`
on Windows
https://github.com/python/cpyt
Steve Dower added the comment:
The PR is ready, but I'll leave this open for a few days in case anyone wants
to comment.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Technically yes, though I think at this stage it will be very few machines that
end up with our copy, and users can patch their own system using Windows Update
even if we've installed a copy. Particularly for our user base, where I suspect
most pre-Win10 P
Steve Dower added the comment:
In your TEMP directory there will be at least one other log file near the one
you attached. Could you also include those?
I wonder if the space at the start of your user name is a problem...
--
___
Python tracker
Steve Dower added the comment:
All correct. I believe venv is fine, as it copies all DLLs, but virtualenv is
more selective and will need to be updated.
--
___
Python tracker
<https://bugs.python.org/issue32
Steve Dower added the comment:
New changeset d135f20ae8887acc7716561bc8f4c7eb6d58d24c by Steve Dower in branch
'master':
bpo-32507: Change Windows install to include app-local UCRT (#5119)
https://github.com/python/cpython/commit/d135f20ae8887acc7716561bc8f4c7
Steve Dower added the comment:
Missed the a4 cutoff, but it'll be in 3.7.0b1.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
New submission from Steve Dower :
In Lib/tempfile.py, we currently look at some non-standard Windows-specific
locations to find potential TEMP directories, but we should also look in the
more common user and system ones.
--
assignee: steve.dower
components: Windows
messages: 316868
Steve Dower added the comment:
New changeset e5f41d2f1e0b8b8e61d5fa427c19bd1ea90fd9a3 by Steve Dower in branch
'master':
bpo-33522: Enable CI builds on Visual Studio Team Services (#6865)
https://github.com/python/cpython/commit/e5f41d2f1e0b8b8e61d5fa427c19bd
Change by Steve Dower :
--
pull_requests: +6595
___
Python tracker
<https://bugs.python.org/issue33522>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 8965d75c90e80b6983b36f3ae9601d6a257d782b by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-33522: Enable CI builds on Visual Studio Team Services (GH-6865) (GH-6926)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 0d8f83f59c8f4cc7fe125434ca4ecdcac111810f by Steve Dower in branch
'3.6':
bpo-33522: Enable CI builds on Visual Studio Team Services (GH-6865) (GH-6925)
https://github.com/python/cpython/commit/0d8f83f59c8f4cc7fe125434ca4ecd
3701 - 3800 of 5794 matches
Mail list logo
