Steve Dower added the comment:
I took another look at this and it's still unclear whether it's worth the
performance loss.
Perhaps moving fsencode and fsdecode (almost) entirely into C would be a better
approach? That shouldn't send us backwards at all, and all they really do
Steve Dower added the comment:
We confirmed offline that it's not a bug.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5540
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Turns out this is a trivial typo in the test, so I stole the issue from Greg
and pushed a PR.
--
assignee: gregory.p.smith -> steve.dower
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5542
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32878>
___
___
Python-
Change by Steve Dower :
--
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue32556>
___
___
Python-bugs-list mailing list
Un
Steve Dower added the comment:
Sounds good to me
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> Windows: subprocess debug assertion on failure to execute the
process
___
Python tra
Steve Dower added the comment:
New changeset 6240917b773b52f8883387b9e3a5f327a4372068 by Steve Dower in branch
'master':
bpo-32409: Ensures activate.bat can handle Unicode contents (GH-5757)
https://github.com/python/cpython/commit/6240917b773b52f8883387b9e3a5f3
Steve Dower added the comment:
New changeset a3d6c1b23b8a49b5003fdbd115d3598fe3d4c4bf by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-32409: Ensures activate.bat can handle Unicode contents (GH-5765)
https://github.com/python/cpython/commit/a3d6c1b23b8a49b5003fdbd115d359
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 8e149ff481acbb3889c825b8bf7b10aa191f09a7 by Steve Dower (Miss
Islington (bot)) in branch '3.6':
bpo-32409: Ensures activate.bat can handle Unicode contents (GH-5766)
https://github.com/python/cpython/commit/8e149ff481acbb3889c825b8bf7b10
Steve Dower added the comment:
What is the definition of FUNCTION_CALL_MODE? And if it is anything other than
"stdcall", change "ctypes.windll" to "ctypes.cdll" and try again.
You should also consider posting this to python-list, as it is almost certainly
a
Steve Dower added the comment:
New changeset 23ad6d0d1a7a6145a01494f4f3913a63d1f0250c by Steve Dower in branch
'master':
bpo-32556: nt._getfinalpathname, nt._getvolumepathname and nt._getdiskusage now
correctly convert from bytes. (GH-5761)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 48e8c82fc63d2ddcddce8aa637a892839b551619 by Steve Dower in branch
'master':
bpo-32457: Improves handling of denormalized executable path when launching
Python (GH-5756)
https://github.com/python/cpyt
Steve Dower added the comment:
Yay, more work...
(btw Zach, nothing stopping you from putting the sources up for me :) I just
need to hit the buttons to make the build.)
--
___
Python tracker
<https://bugs.python.org/issue32
Change by Steve Dower :
--
pull_requests: +5594
___
Python tracker
<https://bugs.python.org/issue32457>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I'm already most of the way through doing the sources this time - just running
into ssh/GitHub troubles getting them online.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Still working on this - X11 and the WinSDK aren't playing nicely together. I
might need a special build configuration to build this, or to submit fixes (and
apply patches) to Tk.
--
___
Python tracker
&
Steve Dower added the comment:
New changeset 1d3c518c5ecbd78478738f068f4f035f81f035f9 by Steve Dower in branch
'3.6':
bpo-32457: Improves handling of denormalized executable path when launching
Python (GH-5756) (#5818)
https://github.com/python/cpyt
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5600
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32901>
___
___
Python-
Steve Dower added the comment:
The sources are just the original sources, so they could be useful on other
platforms too.
The build on cpython-bin-deps is obviously only useful on Windows.
--
___
Python tracker
<https://bugs.python.org/issue32
Steve Dower added the comment:
New changeset efa6c762268d68985f3012234f62ea9e5ced8b7c by Steve Dower in branch
'master':
bpo-32901: Update Tcl and Tk versions to 8.6.8 (GH-5823)
https://github.com/python/cpython/commit/efa6c762268d68985f3012234f62ea
Steve Dower added the comment:
Windows is complete - leaving this open for Ned to resolve when the Mac
installers are done.
--
___
Python tracker
<https://bugs.python.org/issue32
Steve Dower added the comment:
You mean build? Or use?
Can you share build logs?
--
___
Python tracker
<https://bugs.python.org/issue32928>
___
___
Python-bug
Steve Dower added the comment:
If you think it should be working, go ahead and use the Report a Problem tool
in VS to let the team know about the PowerShell module. There might be a case
that isn't handled properly in their code that they can fix (obviously they
don't know/care
Steve Dower added the comment:
New changeset 19e7d48ce89422091f9af93038b9fee075d46e9e by Steve Dower
(animalize) in branch 'master':
bpo-32394: Remove some TCP options on old version Windows. (GH-5523)
https://github.com/python/cpython/commit/19e7d48ce89422091f9af93038b9fe
Steve Dower added the comment:
New changeset 1278c21f5234477aab21531773d65ca7ebd1b81f by Steve Dower
(animalize) in branch '3.6':
[3.6] bpo-32394: Remove some TCP options on older version Windows. (GH-5585)
https://github.com/python/cpython/commit/1278c21f5234477aab21531773d65c
Steve Dower added the comment:
Agreed. I've merged these (and Miss Islington should get the 3.7 backport when
CI completes)
--
resolution: -> fixed
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.
Change by Steve Dower :
--
assignee: -> steve.dower
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Make sure all your Windows updates are installed, reboot if necessary, and try
again.
I believe this is the error that occurs when another installation is ongoing,
and Windows Update is about the only tool likely to be installing something
without telling you
Steve Dower added the comment:
Since I took the time to do a brain dump of my thinking here, feel free to
review/contribute to https://github.com/zooba/PyLauncher/wiki
Note that the code in that repo doesn't match the wiki page, and while I think
it's good code I do now think it&#
Steve Dower added the comment:
Yes, it'll have significant side effects. The default file encoding on Windows
is your configured code page (1252, in your case), and there's no good way
around that default. The easiest immediate fix is to re-encode that file
yourself.
Perhaps wha
New submission from Steve Dower :
On February 27th, 2018, the Python Security Response team was notified of a
buffer overflow issue in the os.symlink() method on Windows. The issue affects
all versions of Python between 3.2 and 3.6.4, including the 3.7 beta releases.
It will be patched for
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5756
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33001>
___
___
Python-
Change by Steve Dower :
--
pull_requests: +5757
___
Python tracker
<https://bugs.python.org/issue33001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +5758
___
Python tracker
<https://bugs.python.org/issue33001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +5759
___
Python tracker
<https://bugs.python.org/issue33001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 6921e73e33edc3c61bc2d78ed558eaa22a89a564 by Steve Dower in branch
'master':
bpo-33001: Prevent buffer overrun in os.symlink (GH-5989)
https://github.com/python/cpython/commit/6921e73e33edc3c61bc2d78ed558ea
Steve Dower added the comment:
New changeset baa45079466eda1f5636a6d13f3a60c2c00fdcd3 by Steve Dower in branch
'3.6':
[3.6] bpo-33001: Prevent buffer overrun in os.symlink (GH-5989) (GH-5990)
https://github.com/python/cpython/commit/baa45079466eda1f5636a6d13f3a60
Steve Dower added the comment:
Patches are merged, except for the ones that belong to @Larry.
Thanks again Alexey for the final round of feedback!
--
nosy: +larry
___
Python tracker
<https://bugs.python.org/issue33
Steve Dower added the comment:
This is the intentional design of the embedded distribution. You need to update
the ._pth file to include the directories that have files that are part of your
app - it's not meant for running random scripts, that's the job of the normal
distribu
Steve Dower added the comment:
I just hit this myself (and embarrassingly, I recently touched this code
everyone and forgot to fix this).
Hopefully I get a chance to get to it, but patches are certainly welcome and
I'll happily aim to get them into 3.6 onwards.
--
versions: +P
Steve Dower added the comment:
(That said, I didn't try again 3.7, so it may already be fixed there. But since
we're still fixing problems with 3.6, we should do that one too.)
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
FYI, the CVE number for this issue is CVE-2018-1000117.
--
title: Buffer overflow vulnerability in os.symlink on Windows -> Buffer
overflow vulnerability in os.symlink on Windows (CVE-2018-1000117)
___
Python trac
Steve Dower added the comment:
Thanks, Victor!
--
___
Python tracker
<https://bugs.python.org/issue33001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 3b20d3454e8082e07dba93617793de5dc9237828 by Steve Dower (Alexey
Izbyshev) in branch 'master':
bpo-33016: Fix potential use of uninitialized memory in nt._getfinalpathname
(#6010)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +5795
___
Python tracker
<https://bugs.python.org/issue33016>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
We should look at merging this, though we need a few things to be done first
(anyone can jump in and do these, doesn't have to be Eryk):
* patch needs to be converted to a GitHub PR
* we should use unique names within %TEMP% to avoid conflicts between
New submission from Steve Dower :
Most Win32 API calls are made within Py_BEGIN_ALLOW_THREADS blocks, as they do
not access Python objects and so we can release the GIL.
However, in general, error handling occurs after the Py_END_ALLOW_THREADS line.
Due to the design of the Win32 API, the
Steve Dower added the comment:
> GetLastError() docs officially scare us
I believe this is a case where the docs were updated from intended/correct
behavior to actual behavior, which happens from time to time and is never
clearly marked.
As I say, they are _supposed_ to leave the er
Steve Dower added the comment:
> Before take_gil() knows whether it has to do any work
I thought we had a check for when the GIL was not even initialized, but that
doesn't seem to exist in master any more.
Preserving GetLastError() at the same place we do errno is probably sufficient
Steve Dower added the comment:
New changeset 32efcd13069a89abf007373274ee1bc0909d1996 by Steve Dower in branch
'3.6':
bpo-33016: Fix potential use of uninitialized memory in nt._getfinalpathname
(GH-6032)
https://github.com/python/cpython/commit/32efcd13069a89abf007373274ee1b
Steve Dower added the comment:
Leaving this open for commit review (and buildbots) for a little while, but
then I'll close it if we're all good.
--
assignee: -> steve.dower
stage: patch review -> commit review
___
Python
Steve Dower added the comment:
Arran - I think yours is a different issue. There should be some other log
files near the one you shared that I'll need to see to find what's going wrong.
Can you zip up all the Python ones and attach
Steve Dower added the comment:
Andrew - you can search for some module names in the nosy list to add the
designated people for them. The components list doesn't include all of them
(perhaps it should?).
--
___
Python tracker
&
Steve Dower added the comment:
We should probably prefer to force ASCII with explicit escapes (ideally named
escapes, rather than codepoints). I'm not sure how to make Sphinx/docutils do
that, but presumably it could be our own extension that handles the problematic
characters people a
Steve Dower added the comment:
Arran - I think you have something else going wrong with your machine. There is
nothing we do to cause multiple installs to start at the same time, and if
rebooting does not help then I have to assume you have some permanently corrupt
state.
Have you installed
Steve Dower added the comment:
Given basically every other file operation on Windows XP will also break on
this file, I don't think it's worth us fixing in 2.7.
If it occurs on Python 3.6 on Windows 7, we can consider it. But considering
how well known this limitation is (and the w
Steve Dower added the comment:
Yeah, very strange that only some MSIs are being affected by this error. They
no doubt have something in common.
If by clean boot you mean reinstalling Windows, then yes, that fixes most
issues, but it is pretty drastic :)
I don't actually have any
Steve Dower added the comment:
I'd like to see this as well, but just to set expectations, it can't be any
earlier than 3.8 at this stage (for upstream support), and we need access to
some real hardware to regularly run tests on.
That said, most of the changes you describe are on
New submission from Steve Dower :
If you host Python in another program, it's likely that sys.executable is not
pointing to a normal Python interpreter. This can cause libraries such as
multiprocessing to fail when they try to launch the interpreter again. Worse,
it may have launched
Steve Dower added the comment:
Looking at the docs https://docs.python.org/3/library/sys.html#sys.executable
maybe we only need to clarify that it's not None only if it provides the normal
command line? Then file bugs against all the libraries that don't work when
it
Steve Dower added the comment:
I recommend and use it without trouble, but then I rarely defer imports to
worker threads.
Barry may have some ideas, but I think this really shouldn't be difficult to
do. importlib is pretty extensible, and it's not difficult to read from a
Steve Dower added the comment:
I believe these are both out of support, but the installer should be showing an
error still.
If you look at recently created files in %TEMP% you may see some logs that will
provide more information. The best resolution however is likely to require
upgrading
Steve Dower added the comment:
I more meant that because of the EOL for that version of Windows, we don't have
support at all in that version of Python. So while we try to have helpful
failure messages, ultimately we aren't obliged to do anything useful at all,
and it sounds like t
Change by Steve Dower :
--
pull_requests: +6158
___
Python tracker
<https://bugs.python.org/issue33184>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +6159
___
Python tracker
<https://bugs.python.org/issue33184>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset b1dc07509f78b354e83f5f4a902f1ff80c7bb05d by Steve Dower in branch
'master':
bpo-33184: Update Windows installer to OpenSSL 1.1.0h (GH-6463)
https://github.com/python/cpython/commit/b1dc07509f78b354e83f5f4a902f1f
Steve Dower added the comment:
New changeset 1672c2fbae6128ee4717e08c4e65a0ab99a02a02 by Steve Dower in branch
'3.6':
bpo-33184: Update Windows installer to OpenSSL 1.0.2o (GH-6464)
https://github.com/python/cpython/commit/1672c2fbae6128ee4717e08c4e65a0
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +6173
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33148>
___
___
Python-
Change by Steve Dower :
--
pull_requests: +6174
___
Python tracker
<https://bugs.python.org/issue32185>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +6175
___
Python tracker
<https://bugs.python.org/issue33184>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
The 2.7 backport was merged by Benjamin into his release branch, which is why
the PR shows "closed".
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pyt
Steve Dower added the comment:
The attached files should work on Python 3.4. Feel free to use them.
--
___
Python tracker
<https://bugs.python.org/issue19
Steve Dower added the comment:
Looks okay, but I wonder whether the implementation of PyMUTEX_UNLOCK should
return something other than zero? What is it meant to return?
--
___
Python tracker
<https://bugs.python.org/issue33
Steve Dower added the comment:
Feel free to start creating patches so we can get an idea of what the changes
would look like. Hopefully it's not that dramatic.
Be very careful making performance claims without benchmarks to back it up, and
ideally against multiple sets of hardware (MS
Steve Dower added the comment:
We don't have a roadmap, just volunteers. When someone is sufficiently
motivated to work on it, it will happen. (You're welcome to try and motivate
people with reason, pleading, money and/or abuse, though I don't recommend the
last one :) Mon
Steve Dower added the comment:
Can't we just fix the cast? We shouldn't have to do heap allocations for this.
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
New changeset d518d8bc8d5dac1a1270612f424d33e0e5afc2b5 by Steve Dower (Oren
Milman) in branch 'master':
bpo-21983: Fix a crash in ctypes.cast() when passed a ctypes structured data
type (GH-3859)
https://github.com/python/cpyt
Change by Steve Dower :
--
assignee: -> steve.dower
stage: patch review -> backport needed
versions: +Python 3.8 -Python 3.4
___
Python tracker
<https://bugs.python.org/i
Steve Dower added the comment:
The backport to 2.7 needs some help. I can't do it on my laptop for the next
week, but I'll try to get to it eventually. Feel free to get there first.
--
versions: +Python 3.6
___
Python track
Steve Dower added the comment:
In this case, we know the behaviour is okay and the warning is wrong. We should
suppress the warning around the offending line, rather than adding significant
code that may introduce genuine bugs.
--
___
Python
New submission from Steve Dower :
We have been provided with https://python.visualstudio.com/cpython and a
measure of build machines to help us run continuous integration builds. The
benefits are more reliable builds (especially Mac and Windows) and higher
parallelism than our current
Steve Dower added the comment:
Ah okay, fair enough. Knowing that, I'll take another look at the PR. I'd
really like to simplify this as much as possible to avoid risk of regression.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
I'm okay with the PR as it stands, especially the parts that affect GitHub and
appveyor, as those are almost certainly using case sensitive comparisons.
It's definitely not easier to update the case of a file that is in git, and
doing so will very li
Changes by Steve Dower :
--
pull_requests: +3738
___
Python tracker
<https://bugs.python.org/issue31170>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue31569>
___
Steve Dower added the comment:
Let me hop in my time machine and fix that for you:
https://github.com/python/cpython/pull/3425
(FWIW, I think it makes *much* more sense for setuptools to fix this by simply
forking all of distutils and never looking back. But since we don't live in
that
Changes by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue31595>
___
___
Changes by Steve Dower :
--
resolution: -> fixed
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
If you install VS 2017 and select the "Python native development" option as
described in the dev guide, you get the correct compilers (plural) for Python
3.5 onwards. The build.bat file (specifically, the find_msbuild.bat helper)
will choose the corre
Steve Dower added the comment:
Correct, this is expected behavior.
If you want your system to be secure *and* to modify default settings, you have
to take full responsibility for that. You can't rely on other tools to have
secure non-default settings (they should have secure *de
Steve Dower added the comment:
Sounds like a good idea.
I hope that sys.path initialization is documented as well for POSIX as it is
for Windows, as that will make this a simple "for X, click here; for Y, click
here" patch. Otherwise, someone will need to figure out exactly what
Steve Dower added the comment:
The only difference between your two tests is the install tool, and neither
setuptools nor wheel bugs are tracked here.
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Pytho
Steve Dower added the comment:
The difference is on startup in how they generate sys.path entries.
Skip the install step and directly run the library in a clean virtual
environment, so that no .pth or .egg files are in use. If the difference still
occurs, show that it also occurs on a recent
Steve Dower added the comment:
I don't really care, since you're comparing multiple unsupported technologies,
but my guess is that the egg install injects the library much earlier on
sys.path, which avoids most of the relatively expensive file s
Steve Dower added the comment:
Thanks. It is indeed trivial, so I'll merge and backport it.
--
___
Python tracker
<https://bugs.python.org/issue31662>
___
___
Steve Dower added the comment:
New changeset efb560eee28b6b2418e1231573ca62574d6dc07b by Steve Dower (Anselm
Kruis) in branch 'master':
bpo-31662: Fix typos in uploadrelease.bat script
https://github.com/python/cpython/commit/efb560eee28b6b2418e1231573ca62
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> backport needed
versions: -Python 3.5
___
Python tracker
<https://bugs.python.or
3601 - 3700 of 5794 matches
Mail list logo
