Steve Dower added the comment:
Glad to hear it.
Hopefully as we redesign the embedding initialization APIs this kind of problem
will become easier to solve (it's certainly one of my concerns with the current
API).
--
resolution: -> not a bug
stage: -> resolved
s
Steve Dower added the comment:
> Being 'runtime' rather than 'buildtime' seemed more precise - tests that
> are not meant to be build-time dependent use run-time status while
> leaving sys.platform for concerns that are directly related to builds
This is a good
Steve Dower added the comment:
More precisely, the default Python install for Windows does not include
versioned executables.
If you install Python 3.7 from the Microsoft Store then you will get them,
though it's not identical to the full development kit you'll get from
python.o
Steve Dower added the comment:
Are you sure you don't have the 32-bit version of Python and the 64-bit version
of those packages?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Where are you running the embedded Python from, and how have you configured it
to include the packages?
Is your install in Program Files from the full installer? Or have you extracted
the embeddable distro there
Steve Dower added the comment:
New changeset 62dfd7d6fe11bfa0cd1d7376382c8e7b1275e38c by Steve Dower (Paul
Monson) in branch 'master':
bpo-35920: Windows 10 ARM32 platform support (GH-11774)
https://github.com/python/cpython/commit/62dfd7d6fe11bfa0cd1d7376382c8e
Steve Dower added the comment:
Changing every API to take the context parameter would bring us into alignment
with the JavaScript VMs.
I'm working on a project that embeds a few of these, as well as Python, and our
thread management is much worse than their context parameter. Though I
Steve Dower added the comment:
> I could also see use cases for *also* configuring warnings process-wide but
> that could be handled separately if actually desired.
Beyond "warning configuration is inherited by new interpreters", I don't see
any reason to have proce
Steve Dower added the comment:
Marking as a release blocker and adding RM. The 3.8 branch now contains
breaking API changes to these functions that we have to resolve before the next
release (or revert while deciding how to handle the change) - PR 12701 has been
merged.
--
keywords
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue36751>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
My bad, there were PR changes that GitHub didn't show me. As you were
--
nosy: -lukasz.langa
priority: release blocker -> normal
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
Nope, I was right the first time. The FullArgSpec tulle has changed indexes,
and formatargspec has additional (undocumented) arguments.
Since formatargspec is deprecated, it should probably just not change.
The FullArgSpec tuple might have to become a concrete
Steve Dower added the comment:
It still happens because nobody has proposed a patch to specially handle this
one particular error code. The earlier messages explained why we can't do
formatting on error messages.
If this one is particularly common, then it's best for it to be
Steve Dower added the comment:
Yes, it's due to that. I guess we need to do netloc.rpartition(':') like we
currently do for '@' in _checknetloc.
Promoting to release blocker and security issue to match the original issue. I
can't get to this today, but I
Steve Dower added the comment:
> My proposal was to raise an exception if the input function has positonal
> arguments
Counter-proposal - just report them as regular position-or-name arguments.
Users of inspect are most likely to be IDEs or editors getting information to
present to
New submission from Steve Dower :
Not all console configurations can correctly render smart quotes in help()
text. See the "Æ" in "superclass's" below.
When building for pydoc-topics, it would be ideal to disable smart quotes. (I'm
assuming from issue
Steve Dower added the comment:
> mismatch in encodings
Also likely. I haven't looked into how pydoc does its rendering, but certainly
Python 3.7 on Windows should be able to print regular Unicode.
Perhaps it's not going through stdout fo
Change by Steve Dower :
--
keywords: +patch
pull_requests: +12940
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36742>
___
___
Py
Steve Dower added the comment:
I found the time to get the first patch. Hopefully backports to 3.6 and 3.7 are
easy, but I think 2.7 will take manual steps.
Chihiro Ito - if you have other test scenarios, it would be great if you could
try them out with the fix in PR 13017. It should be
Steve Dower added the comment:
New changeset d537ab0ff9767ef024f26246899728f0116b1ec3 by Steve Dower in branch
'master':
bpo-36742: Fixes handling of pre-normalization characters in urlsplit()
(GH-13017)
https://github.com/python/cpython/commit/d537ab0ff9767ef024f26246899728
Change by Steve Dower :
--
pull_requests: +12947
___
Python tracker
<https://bugs.python.org/issue36742>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
> I suggested creating a new issue to fix the calls that omit this flag.
Right, that's a separate issue that is easily fixed (and backported, IMHO).
Though I suspect that we've not used the flags in those ones because we think
we *can* proper
Steve Dower added the comment:
New changeset 98a4dcefbbc3bce5ab07e7c0830a183157250259 by Steve Dower in branch
'2.7':
bpo-36742: Fixes handling of pre-normalization characters in urlsplit()
(GH-13017)
https://github.com/python/cpython/commit/98a4dcefbbc3bce5ab07e7c0830a18
Steve Dower added the comment:
I'll leave the 3.6 backport in Ned's hands and close this issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs
Steve Dower added the comment:
Yes, you're right. I'll do that port as well.
--
___
Python tracker
<https://bugs.python.org/issue36742>
___
___
Change by Steve Dower :
--
pull_requests: +12961
___
Python tracker
<https://bugs.python.org/issue36742>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I think Neil is right, though I believe we'll have a clear enough internal
boundary that we should only rarely have to maintain TSS for the sake of legacy
callers. The build option should just turn off the entire legacy API, which
would also make it easi
Steve Dower added the comment:
So pydoc_topics.py is an auto-generated file, which means we need to fix the
generator as well if we decide to go that route.
However, I suspect there's a problem somewhere else causing the console output
to not go through stdout correctly. I'm no
New submission from Steve Dower :
I suspect this is related to the fix for issue30485, but haven't fully debugged
it.
In PC/layout/support/appxmanifest.py, I have code that looks up an existing
element and adds it if missing:
def find_or_add(xml, element, attr=None, always_add=
Steve Dower added the comment:
Here is a test case that fails on 3.8.0a4 and succeeds on 3.7.3:
def test_find_attribute_with_empty_ns(self):
NS = "http://effbot.org/ns";
element = ET.fromstring(f"""""")
self.assertIsNotNone(e
New submission from Steve Dower :
Implement PEP 578
--
assignee: steve.dower
messages: 341819
nosy: christian.heimes, steve.dower
priority: normal
pull_requests: 13091
severity: normal
stage: patch review
status: open
title: Implement PEP 578
type: enhancement
versions: Python 3.8
Steve Dower added the comment:
New changeset 39889864c09741909da4ec489459d0197ea8f1fc by Steve Dower (Brian
Quinlan) in branch 'master':
bpo-26903: Limit ProcessPoolExecutor to 61 workers on Windows (GH-13132)
https://github.com/python/cpython/commit/39889864c09741909da4ec489459d0
Steve Dower added the comment:
The XP/Vista change is just context - we don't have to worry about OS that old
any more.
If we remove the functools.partial call, does that help?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Updating the title to actually reflect the issue - Zackery, could you update
your PR and NEWS entry?
I just spent way too long looking for a MoveFileEx call that doesn't exist,
because this isn't actually about doing things on reboot :)
For tests,
Steve Dower added the comment:
This PR has stalled because of errors raised by TLS 1.3
It seems that there may be a difference between sockets on Windows being
non-blocking by default and other platforms being blocking by default. However,
we think that is probably just causes TLS 1.3
Change by Steve Dower :
--
pull_requests: +13237
___
Python tracker
<https://bugs.python.org/issue35926>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset fb7e7505ed1337bf40fa7b8b68317d1e86675a86 by Steve Dower (Paul
Monson) in branch 'master':
bpo-35926: Add support for OpenSSL 1.1.1b on Windows (GH-11779)
https://github.com/python/cpython/commit/fb7e7505ed1337bf40fa7b8b68317d
Steve Dower added the comment:
New changeset 67ff6a103a1184b572750c30e231968c963e72f8 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Windows ARM32 buildbot changes (GH-12917)
https://github.com/python/cpython/commit/67ff6a103a1184b572750c30e23196
Steve Dower added the comment:
Going to leave this in commit review for a bit, in case hitting merge suddenly
flushes out some reviews :)
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +13261
___
Python tracker
<https://bugs.python.org/issue35926>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Can you clarify how you are setting your proxy configuration and how Python is
finding out about it?
Also, which libraries are you using?
As far as I'm aware, Python itself does nothing special to load proxy settings
from normal Windows configuration.
Steve Dower added the comment:
requests is a third-party library, so if they're finding your settings you
probably need to report it to them.
urllib2 is only part of Python 2.x. Do you have a repro with urllib on Python 3?
--
___
Python tr
Steve Dower added the comment:
Paul - looks like there's a timeout being hit due to lack of output. Any ideas?
https://buildbot.python.org/all/#/builders/203/builds/6
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset aa73841a8fdded4a462d045d1eb03899cbeecd65 by Steve Dower in branch
'3.7':
bpo-35926: Add support for OpenSSL 1.1.1b on Windows (GH-11779)
https://github.com/python/cpython/commit/aa73841a8fdded4a462d045d1eb038
Steve Dower added the comment:
Where is that code? Presumably in distutils, and yet distutils has worked just
fine for the 3.5 and 3.6 releases.
Perhaps you can clarify the bug report into something we can understand and
investigate? That only thing in that thread I see that matches your
Steve Dower added the comment:
Almost seems like an unwinnable race here. We need to collect the error numbers
before reacquiring the GIL (which could change some of them), but then if we
update the object after getting the lock back we could still have raced with
another thread.
Perhaps we
Steve Dower added the comment:
A little bit. You're trying to build with mingw32? Do they support linking
against the UCRT?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
The CRT isn't a simple DLL anymore, and MinGW isn't a fully supported compiler
either. You're going to be best to work with the people behind mingwpy to get
it working, as there really isn't anything we can do on our end (though I do
what I
Steve Dower added the comment:
How is this an improvement over loading the DLL explicitly? Even if subpackages
require the file, your top level __init__.py will run before they are loaded
and it can import a pyd that's known to be next to the file or it can
LoadLibrary the contents of
Steve Dower added the comment:
The more details you reveal, the less I want it to be an officially supported
pattern :)
Perhaps you actually want an import hook? Brett can confirm, but I believe you
can overwrite __loader__ in a package and change how submodules are loaded.
--
nosy
Steve Dower added the comment:
This sounds like a good idea to me - feel free to contribute your PR.
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue32
Steve Dower added the comment:
I understood the proposal just fine, and I understand the problems involved and
appreciate why the ideal isn't sufficient here.
The import hook was my proposal to let you only preload DLLs when the extension
module is being loaded, rather than having to
Steve Dower added the comment:
I am very okay with it not being Python's responsibility to do this.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
The import hook could theoretically modify the search path before and after
loading the module, though that could make debugging a real pain.
I was also thinking of just having an explicit list of DLLs to load, rather
than inspecting the binary. Per-module
Steve Dower added the comment:
That looks like recompilation (or at least how recompilation would look if
you'd been granted permission). Assuming you can recompile the binary, you
could rename the dependency and regenerate the import library so that you can
link directly against th
New submission from Steve Dower :
The _findvs module I added for distutils has added load-time dependencies on
the ole32 and oleaut32 DLLs.
To reduce startup time, we should move _findvs into its own .pyd (unless I hear
a better suggestion, I like "distutils._findv
Steve Dower added the comment:
Actually, I'd prefer not dropping it into the Lib directory, so probably
DLLs/_distutils_findvs.pyd is the way to go.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Looks like you have a prerelease version of the CRT on your machine. Try
finding and installing the latest Visual C++ 2017 Redistributables from
Microsoft.
A newer version would have been installed by Python but since it wasn't I
assume you have some
Steve Dower added the comment:
I don't think it's too late (and I don't think this counts as a feature either,
so the b1 deadline doesn't apply), but the patch would need to include an
update to What's New as well as the usual stuff.
--
_
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue32588>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5074
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +5075
___
Python tracker
<https://bugs.python.org/issue32588>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
The only changes necessary in the installer should be in
PythonBootstrapperApplication.cpp to make it an error when run on pre-Win7 OS.
The pattern is already there, and the string references are in
Tools/msi/bundle/Default.wxl
If you don't get to it, rea
Steve Dower added the comment:
New changeset 2507e29a9e4e9dcac6eab46546bd3d34a69342ba by Steve Dower in branch
'master':
bpo-32588: Move _findvs into its own module and add missing _queue module to
installer (#5227)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset ccf7f05c5d3fdea89d857e775d2c6371f3e15b4a by Steve Dower in branch
'3.6':
[3.6] bpo-32588 Move _distutils_findvs into its own module (GH-5227) (#5228)
https://github.com/python/cpython/commit/ccf7f05c5d3fdea89d857e775d2c63
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Arguably, a WindowsPath instance only represents the *path* and not the file
located by the path. So the programmer has to take just as much responsibility
as if they were using plain strings, except there are some conveniences added
to make those strings
Steve Dower added the comment:
(FWIW, I don't think your "security" argument is going to be very convincing,
as this problem has been around for far too long to be treated as suddenly
urgent. But up to you.)
My fear is that if PureWindowsPath stops handling the >90% of c
Steve Dower added the comment:
> I think all programmers expect that if x == y, then they refer to the same
> file. This is not true currently.
Perhaps, but you could equally say that they expect that if x != y then they
refer to different files, which is also not true. So do we optimi
Steve Dower added the comment:
Just tested something that I'd assumed and it turned out I was wrong:
>>> p1 = PureWindowsPath(r"C:\a\b\..\c")
>>> p2 = PureWindowsPath(r"C:\a\c")
>>> p1 == p2
False
>>> p1, p2
(PureWindowsPath(&
Steve Dower added the comment:
>From the log file, all I can tell is that it failed to open the file
>containing information about ongoing installs. At a guess, another install was
>running (maybe failed?) and didn't clean up properly.
Rebooting should generally resolve that.
Steve Dower added the comment:
To fix this, we need to make Idle its own .exe file with an AppId and properly
registered icon. Right now, it's just a .pyw file running in Python, and so
things like pinning icons or file associations won't work cleanly.
--
type
Steve Dower added the comment:
1 is correct. I don't see the contradiction - maybe you could purpose a
rewording? (Perhaps it currently relies on the knowledge that the site module
finds and processes .pth files? -S will also suppre
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5233
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32699>
___
___
Python-
Steve Dower added the comment:
New changeset 15ea3a6a320623328530e5d8da5b83c75766180b by Steve Dower in branch
'master':
bpo-32699: Improves doc for .pth files in presense of a ._pth file (#5399)
https://github.com/python/cpython/commit/15ea3a6a320623328530e5d8da5b83
Steve Dower added the comment:
Hopefully that's enough of a clarification.
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
versions: +Py
Steve Dower added the comment:
I like Kamil's suggestion.
--
___
Python tracker
<https://bugs.python.org/issue32394>
___
___
Python-bugs-list mailing list
Steve Dower added the comment:
It's an assert, so it only affects debug builds - releases are not impacted.
I'm guessing there's a test that spawns a subprocess and doesn't initialize it
properly for tests (specifically the part where we disable as
Steve Dower added the comment:
Yep, this was part of the plan. Just hasn't happened yet (it probably requires
a significant rewrite of the launcher which nobody has volunteered to do or
found the time for).
I thought I had another open bug on this too... if someone finds it, feel fre
Change by Steve Dower :
--
resolution: -> out of date
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Nice. Think you can turn that into a pull request on GitHub?
--
___
Python tracker
<https://bugs.python.org/issue32394>
___
___
Steve Dower added the comment:
Yes, adding the member back will put you back in the broken state, but there's
nothing we can do to stop it.
Thanks for the PR - I'll take a look, and if I'm able to log into GitHub on my
phone
Steve Dower added the comment:
PR looks good to me. Unfortunately without SMS (I'm travelling) I can't get
into my account from my phone, so if someone else wants to add the backport
tags (3.7 and 3.6) and finish it then feel free.
--
versions: +Python 3.7,
Change by Steve Dower :
--
nosy: +davin, pitrou
___
Python tracker
<https://bugs.python.org/issue32759>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
In this case I like the flags disappearing on older versions, just as they
would if you built CPython on a version of Linux that didn't have the flags.
The problem is that the Windows SDK always defines enum values for all Windows
versions even if yo
Steve Dower added the comment:
Oh, and checking Windows version is hard. Better for us to get it right than
every single library to risk getting it wrong. (The code used in the second PR
is not right - there are IsWindowsVersion* macros that are better
Steve Dower added the comment:
This is the same as issue25166
It can't be fixed easily (Wix doesn't actually support this), but I have some
ideas that have been looking okayish. Still hoping to get it to work fully for
3.7, but as it affects the installer we may not have enoug
Steve Dower added the comment:
More likely it's set to use the WINDOWS subsystem and the allocates the console
when it detects you've passed --help.
Is this the regular build of SVN or from one of the GUI tools?
--
___
Python track
Steve Dower added the comment:
The patch looks good, but the rest of the code for this looks horrible(and
potentially a security risk)... maybe we ought to take this fix for now but
prioritise replacing this whole function with a C implementation or at least a
better search for the ipconfig
Steve Dower added the comment:
This is a big feature request, as our current installer technology is
specifically designed for ease of upgrading between minor versions (e.g.
3.6.3->3.6.4). We would need to completely rewrite our installers.
If you want to avoid the installers completely
Steve Dower added the comment:
> The problem is independent of word length.
There should be no problem installing 3.6.4 of one architecture and 3.6.3 of
the other at the same time. I myself do this all the time with every version of
Python. You can't do it if they are the same arch
Change by Steve Dower :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue32457>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5534
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Eryk's solution seems to be best, so I'll add that.
--
assignee: -> steve.dower
versions: +Python 3.8
___
Python tracker
<https://bugs.pytho
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5535
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
resolution: -> works for me
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue32566>
___
___
Change by Steve Dower :
--
keywords: +patch
pull_requests: +5539
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
assignee: -> steve.dower
stage: patch review -> needs patch
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/i
3501 - 3600 of 5794 matches
Mail list logo
