[issue36408] Tkinter multi-processing performance, Linux 10-25 times faster than Windows 10

2019-03-25 Thread Steve Dower
Steve Dower added the comment: Windows only allows a single thread to access Win32 GUI elements at a time, and I'm fairly sure whichever part of Tcl/Tk/Tkinter is responsible for this makes sure it happens. So if you're throwing lots of UI updates at the UI thread, then yeah, you

[issue36426] exec() issue when used inside function

2019-03-25 Thread Steve Dower
Steve Dower added the comment: This is currently by design, which means 3.8 is likely the only viable place it can change. It's also not Windows specific so I removed that component (people may remove themselves from nosy). But +Nick, since I know he has some interest in making l

[issue36435] multiprocessing crashes in Python 3.7.3 on Windows

2019-03-26 Thread Steve Dower
Steve Dower added the comment: If you make the change suggested in the error text, does it fix it? (It could be clearer, but your module needs to only run its code when __name__=="__main__" instead of every time it gets imported.) --

[issue36085] Enable better DLL resolution

2019-03-26 Thread Steve Dower
Steve Dower added the comment: Since there's no chance of getting old SQL Server fixed, I think we should just merge it without the SetDefaultDllDirectories change. Any comments, questions or more feedback on the PR? -- ___ Python tracker &

[issue36441] Cannot create venv with debug binaries installed

2019-03-26 Thread Steve Dower
Steve Dower added the comment: Thanks! Two issues here: * symlink_or_copy doesn't verify that the source file exists after rewriting the path * Tools/msi/lib/lib_files.wxs doesn't include the debug launchers -- ___ Python track

[issue36441] Cannot create venv with debug binaries installed

2019-03-26 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +12511 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36441> ___ ___ Py

[issue36441] Cannot create venv with debug binaries installed

2019-03-27 Thread Steve Dower
Steve Dower added the comment: New changeset 4a9a505d6f2474a570422dad89f8d1b344d6cd36 by Steve Dower in branch 'master': bpo-36441: Fixes creating a venv when debug binaries are installed. (#12566) https://github.com/python/cpython/commit/4a9a505d6f2474a570422dad89f8d1

[issue36245] PCBuild/build.bat errors, probably from space characters in paths

2019-03-27 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +12534 stage: backport needed -> patch review ___ Python tracker <https://bugs.python.org/issue36245> ___ ___ Python-

[issue36245] PCBuild/build.bat errors, probably from space characters in paths

2019-03-27 Thread Steve Dower
Steve Dower added the comment: I did the 2.7 backport, and also fixed two more instances in that file. Pretty sure my automerges won't work without a core dev review, so if someone wants to hit Approve and/or Merge for me, feel

[issue36245] PCBuild/build.bat errors, probably from space characters in paths

2019-03-27 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +12535 ___ Python tracker <https://bugs.python.org/issue36245> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

2019-03-27 Thread Steve Dower
Steve Dower added the comment: So an important aspect of the "fix" is that this message only appears after the fix has been applied. Anyone running into this locally has already updated those files, and just needs to "git add -u" to include them in their next commit. (Un

[issue36085] Enable better DLL resolution

2019-03-27 Thread Steve Dower
Steve Dower added the comment: I implemented the feature Eryk was asking for, as it's also by far the easiest way to test the add_dll_directory function. So now ctypes.CDLL (and subclasses) have a `winmode` argument that gets turned directly into LoadLibraryEx flags (changing `mode`

[issue36245] PCBuild/build.bat errors, probably from space characters in paths

2019-03-27 Thread Steve Dower
Steve Dower added the comment: New changeset bb89aa24cf71f9874d1d26f3a2440fefa0b6bbcc by Steve Dower in branch '2.7': bpo-36245: Avoid problems when building in a directory containing spaces. (GH-12241) https://github.com/python/cpython/commit/bb89aa24cf71f9874d1d26f3a2440f

[issue36245] PCBuild/build.bat errors, probably from space characters in paths

2019-03-27 Thread Steve Dower
Steve Dower added the comment: New changeset b95a79c928fc4a6135d91c0c553cb2a63cf15140 by Steve Dower in branch 'master': bpo-36245: Fix more empty environment variable checks (GH-12592) https://github.com/python/cpython/commit/b95a79c928fc4a6135d91c0c553cb2

[issue36245] PCBuild/build.bat errors, probably from space characters in paths

2019-03-27 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35941] ssl.enum_certificates() regression

2019-03-28 Thread Steve Dower
Steve Dower added the comment: New changeset d93fbbf88e4abdd24a0a55e3ddf85b8420c62052 by Steve Dower (kctherookie) in branch 'master': bpo-35941: Fix ssl certificate enumeration for windows (GH-12486) https://github.com/python/cpython/commit/d93fbbf88e4abdd24a0a55e3ddf85b

[issue36441] Cannot create venv with debug binaries installed

2019-03-28 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

2019-03-29 Thread Steve Dower
Steve Dower added the comment: New changeset 3396d1e0ca858065c5bb7e5a9737be6ffc4028f7 by Steve Dower (Jeroen Demeyer) in branch 'master': bpo-36448: mention 'make regen-all' in error message (GH-12585) https://github.com/python/cpython/commit/3396d1e0ca858065c5bb

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

2019-03-29 Thread Steve Dower
Steve Dower added the comment: Merged. It doesn't need a backport - the target audience is CI users who will see this on master first. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> compile error versi

[issue36085] Enable better DLL resolution

2019-03-29 Thread Steve Dower
Steve Dower added the comment: So symlinking didn't work (Python is too clever for that these days ;) ), but straight copying the exe and required DLLs is fine. It puts python.exe, python38.dll and vcruntime140.dll (properly discovered of course) into a temp directory, puts _sqlite

[issue35947] Update libffi_msvc to current version of libffi

2019-03-29 Thread Steve Dower
Steve Dower added the comment: New changeset 32119e10b792ad7ee4e5f951a2d89ddbaf111cc5 by Steve Dower (Paul Monson) in branch 'master': bpo-35947: Update Windows to the current version of libffi (GH-11797) https://github.com/python/cpython/commit/32119e10b792ad7ee4e5f951a2d89d

[issue36085] Enable better DLL resolution

2019-03-29 Thread Steve Dower
Steve Dower added the comment: New changeset 2438cdf0e932a341c7613bf4323d06b91ae9f1f1 by Steve Dower in branch 'master': bpo-36085: Enable better DLL resolution on Windows (GH-12302) https://github.com/python/cpython/commit/2438cdf0e932a341c7613bf4323d06

[issue36085] Enable better DLL resolution

2019-03-29 Thread Steve Dower
Steve Dower added the comment: Leaving this in commit review for a couple of days, then I'll close. -- stage: patch review -> commit review ___ Python tracker <https://bugs.python.org

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: Acknowledging the buildbot failure at https://buildbot.python.org/all/#builders/12/builds/2181 I'll try and take a look today. Apparently Windows 8 has a slightly different understanding of the flags used in ctypes tests? -- nosy: +pablogsal, vst

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +12564 stage: commit review -> patch review ___ Python tracker <https://bugs.python.org/issue36085> ___ ___ Python-

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: Pushed a potential fix, assuming there's something weird going on with relying on cwd rather than full paths (I know there's some weirdness here when paths get too long, for example). Zach - this is one of your buildbots. Can we trigger a run from

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-30 Thread Steve Dower
Steve Dower added the comment: New changeset e724152796a5a41544f52054506c6c2248242a5d by Steve Dower (Paul Moore) in branch 'master': bpo-36010: Add venv to the nuget distribution (GH-12367) https://github.com/python/cpython/commit/e724152796a5a41544f52054506c6c

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: Guess the link in the devguide needs fixing... I'm out for the next few hours but will give it a go when I'm back. -- ___ Python tracker <https://bugs.python.o

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: Thanks for the info, David! I guess the update isn't part of SP1. I'll add a check to the installer and update the note in What's New. Eryk - my thought on CWD was that the new process was not starting in the correct directory, which can some

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-30 Thread Steve Dower
Steve Dower added the comment: New changeset 3e78c7c30553baf72b7eb6fe3384d88fff549906 by Steve Dower (Miss Islington (bot)) in branch '3.7': bpo-36010: Add venv to the nuget distribution (GH-12367) https://github.com/python/cpython/commit/3e78c7c30553baf72b7eb6fe3384d8

[issue36010] Please provide a .zip Windows release of Python that is not crippled/for embedding only

2019-03-30 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +12568 ___ Python tracker <https://bugs.python.org/issue36085> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: I attached a build of the updated installer to PR 12636 (it's too big to attach here) in case anyone can help me test. It should block right at the start if you don't have the update, or else it'll go to the usual screen. The message just says &

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: New changeset ac19d9652799412404aef6b357a01057df34e005 by Steve Dower in branch 'master': bpo-36085: Add additional load flag to ensure DLL loads successfully (GH-12633) https://github.com/python/cpython/commit/ac19d9652799412404aef6b357a010

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: > any chance at a 32-bit version of the installer Done (on the PR). Thanks! -- ___ Python tracker <https://bugs.python.org/issu

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: New changeset 79da388a4016e24c4258dcc62cd0fa9dde0acb5b by Steve Dower in branch 'master': bpo-36085: Add installer check for KB2533625 (GH-12636) https://github.com/python/cpython/commit/79da388a4016e24c4258dcc62cd0fa

[issue36085] Enable better DLL resolution

2019-03-30 Thread Steve Dower
Steve Dower added the comment: Thanks, David. I looked at the log quickly and it's what I expected, so I'll merge the PR and start advertising the change. Thanks everyone! -- ___ Python tracker <https://bugs.python.o

[issue36085] Enable better DLL resolution

2019-04-01 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36216] CVE-2019-9636: urlsplit does not handle NFKC normalization

2019-04-03 Thread Steve Dower
Steve Dower added the comment: You need a "u" prefix on some of your strings or they're probably being immediately decomposed. The result of urlsplit should be unicode on Python 2 for a Unicode input, and yours are not. -- ___

[issue36535] Windows build failure when use the code from the GitHub master branch

2019-04-05 Thread Steve Dower
Steve Dower added the comment: We added a new dependency. Run a build using PCbuild/build.bat and it will download it for you. Then building through VS should work again. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36529] Python from WindowsStore: can't install package using "-m pip"

2019-04-06 Thread Steve Dower
Steve Dower added the comment: Yeah, right now you need to also pass --local when you use -m (the bundled pip.exe does this automatically). Your user account does not have permission to install into the global site directory. Once we update the bundled pip I can add a site-specific

[issue36557] Python (Launcher)3.7.3 CMDLine install/uninstall

2019-04-08 Thread Steve Dower
Steve Dower added the comment: Pass /passive to have it automatically close at the end, or /quiet to avoid popping up a window at all. Can you clarify what you mean by launcher? There are a couple different things you could be talking about and I don't want to give you the wrong a

[issue31512] Add non-elevated symlink support for dev mode Windows 10

2019-04-09 Thread Steve Dower
Steve Dower added the comment: New changeset 0e10766574f4e287cd6b5e5860a1ca75488f4119 by Steve Dower (Vidar Tonaas Fauske) in branch 'master': bpo-31512: Add non-elevated symlink support for Windows (GH-3652) https://github.com/python/cpython/commit/0e10766574f4e287cd6b5e5860a1ca

[issue31512] Add non-elevated symlink support for dev mode Windows 10

2019-04-09 Thread Steve Dower
Steve Dower added the comment: Done -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32451] python -m venv activation issue when using cygwin on windows

2019-04-12 Thread Steve Dower
Steve Dower added the comment: It probably just needs a gitattributes fix so it doesn't get converted when cloned to make the release build. This is assuming that in all these cases people are installing Python for Windows and trying to use it from a non-Windows shell (both WSL and C

[issue36614] Popen output on windows server 2019

2019-04-12 Thread Steve Dower
Steve Dower added the comment: As we haven't done anything special for WS2019 yet, this is a change in Windows (or whatever tool is outputting the text). You could report it to Microsoft. I don't know the best way to report bugs in Windows Server though, but most people with it ha

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-12 Thread Steve Dower
Steve Dower added the comment: New changeset b015fc86f7b1f35283804bfee788cce0a5495df7 by Steve Dower (Kingsley M) in branch 'master': bpo-36549: str.capitalize now titlecases the first character instead of uppercasing it (GH-12804) https://github.com/python/cpyt

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-12 Thread Steve Dower
Steve Dower added the comment: Thanks! I'm a big fan of this change :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.pyth

[issue36602] Recursive directory list with pathlib.Path.iterdir

2019-04-12 Thread Steve Dower
Steve Dower added the comment: Having spent more time than I'm proud of recursing through directories, I'd be happy enough with a convenience function that has sensible defaults. If I want breadth-first recursion (and I often do), I'll write it myself. I have a slight prefere

[issue36601] signals can be caught by any thread

2019-04-12 Thread Steve Dower
Steve Dower added the comment: Looks like Guido added the original code about 25 years ago. Since he removed himself from the other thread during that discussion, I'm going to assume he's not interested in thinking about it any more. As the original comment says, it's a ha

[issue36552] Replace OverflowError with ValueError when calculating length of range objects > PY_SIZE_MAX

2019-04-12 Thread Steve Dower
Steve Dower added the comment: We should at least have consistent error messages: >>> class O: ... def __len__(self): ... return 2**100 ... >>> o=O() >>> len(o) Traceback (most recent call last): File "", line 1, in OverflowError: cannot fit 'i

[issue36513] Add support for building arm32 nuget package

2019-04-12 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36509] Add iot layout for windows iot containers

2019-04-12 Thread Steve Dower
Steve Dower added the comment: New changeset f4e5661e85ac41c987165246d2b33f363cd01e34 by Steve Dower (Paul Monson) in branch 'master': bpo-36509: Add iot layout for Windows IoT containers (GH-12663) https://github.com/python/cpython/commit/f4e5661e85ac41c987165246d2b33f

[issue35925] test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL 1.1.1a)

2019-04-12 Thread Steve Dower
Steve Dower added the comment: This is still failing regularly - any progress? Do we need to skip tests? -- nosy: +steve.dower ___ Python tracker <https://bugs.python.org/issue35

[issue36609] activate.ps1 in venv for Windows should encoded with BOM

2019-04-12 Thread Steve Dower
Steve Dower added the comment: Seems reasonable. The most reliable way to do this will be to override the copy function for this file in venv and write it out with "utf-8-sig" encoding. There are many ways that git will break things like this, so I wouldn't trust it to

[issue21110] Slowdown and high memory usage when adding a new module in embedded Python 3.4 on 64bit Windows

2019-04-12 Thread Steve Dower
Steve Dower added the comment: Never heard of it, but perhaps there are some preprocessor checks for Windows that assume you are using MSVC and not gcc? We don't support compilers other than MSVC on Windows, but if someone has a fix for this I'm happy to c

[issue25361] Is python-3-5-0.exe compiled with SSE2 instrutions? If so should we mention this?

2019-04-12 Thread Steve Dower
Steve Dower added the comment: For 3.8 we support as far back as Win7 SP1 with the update for secure DLL loading, neither of which require SSE2. So we should hold this for 3.9 when we drop Win7 completely. -- ___ Python tracker <ht

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-12 Thread Steve Dower
Steve Dower added the comment: What is missing? It looks like everything on Serhiy's list was done. -- ___ Python tracker <https://bugs.python.org/is

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-12 Thread Steve Dower
Steve Dower added the comment: Oh, apart from the What's New section. But this looks enough like a bugfix (previous behaviour "wasn't capitalizing my name correctly" - new behaviour "now capitalizes my name correctly") that it's hardly cri

[issue36614] Popen output on windows server 2019

2019-04-12 Thread Steve Dower
Steve Dower added the comment: > I guess Popen is using some OS library or environment that has changed in > WS2019. Yep, which is why the report should go to those responsible for WS2019. If they say it's an intentional change and users are supposed to work around it themselv

[issue33922] [Windows] Document the launcher's -64 suffix

2019-04-12 Thread Steve Dower
Steve Dower added the comment: New changeset 1e2ad6c275d2b09e76b7cbba7281d5a125a593c1 by Steve Dower (mrh1997) in branch 'master': bpo-33922: Adding documentation for new "-64" suffix of Python launcher (GH-7849) https://github.com/p

[issue30291] Allow windows launcher to specify bit lengths with & without minor version

2019-04-12 Thread Steve Dower
Steve Dower added the comment: New changeset 1e2ad6c275d2b09e76b7cbba7281d5a125a593c1 by Steve Dower (mrh1997) in branch 'master': bpo-33922: Adding documentation for new "-64" suffix of Python launcher (GH-7849) https://github.com/p

[issue30485] Element.findall(path, dict) doesn't insert null namespace

2019-04-14 Thread Steve Dower
Steve Dower added the comment: I don't recall where I got the empty string from, but it's certainly what I've used there for a while. Maybe it's required in register_namespace() to set the default namespace? -- ___ Py

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

2019-04-15 Thread Steve Dower
Steve Dower added the comment: Basically everyone has that directory in their PATH - we'd be hearing a lot more issues if it were a consistent bug. Can you share the full contents of your activate.bat file? And if it's okay, your full PATH variable (before and after running ac

[issue36634] venv: activate.bat fails for venv with parentheses in PATH

2019-04-16 Thread Steve Dower
Steve Dower added the comment: We should be able to use alternate characters in the SET call, or just drop the quotes completely. In theory they make sense, but there's no trailing whitespace to worry about here. -- ___ Python tracker &

[issue36649] Windows Store app install registry keys have incorrect paths

2019-04-17 Thread Steve Dower
Steve Dower added the comment: Can you get me the *exact* Windows version number you're using? I added those to work around a bug where keys were being incorrectly trimmed, and that format seemed to evaluate to nothing correctly, but perhaps that bug has been fixed in t

[issue36649] Windows Store app install registry keys have incorrect paths

2019-04-17 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +12792 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36649> ___ ___ Py

[issue36649] Windows Store app install registry keys have incorrect paths

2019-04-17 Thread Steve Dower
Steve Dower added the comment: Great, thanks. I have a fix in PR, but I'm going to do a "real" build to check. My machine is running a beta build, unfortunately, so I can't validate it against the older version. Might ping you for some help with that. -- v

[issue36649] Windows Store app install registry keys have incorrect paths

2019-04-17 Thread Steve Dower
Steve Dower added the comment: New changeset 4c3efd9cd07194b5db2a60ae5951134cda8b69db by Steve Dower in branch 'master': bpo-36649: Remove trailing spaces for registry keys when installed via the Store (GH-12865) https://github.com/python/cpyt

[issue36638] typeperf.exe is not in all skus of Windows SKUs

2019-04-17 Thread Steve Dower
Steve Dower added the comment: New changeset 264a0b40b030fc0ff919b8294df91bdaac853bfb by Steve Dower (Paul Monson) in branch 'master': bpo-36638: Fix WindowsLoadTracker exception on some Windows versions (GH-12849) https://github.com/python/cpyt

[issue36071] Add support for Windows ARM32 in ctypes/libffi

2019-04-17 Thread Steve Dower
New submission from Steve Dower : New changeset 11efd79076559cc6e4034bb36db73e5e4293f02d by Steve Dower (Paul Monson) in branch 'master': bpo-36071 Add support for Windows ARM32 in ctypes/libffi (GH-12059) https://github.com/python/cpython/commit/11efd79076559cc6e4034bb36db73e

[issue36638] typeperf.exe is not in all skus of Windows SKUs

2019-04-17 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue36071] Add support for Windows ARM32 in ctypes/libffi

2019-04-17 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue36646] os.listdir() got permission error in Python3.6 but it's fine in Python2.7

2019-04-17 Thread Steve Dower
Steve Dower added the comment: This is weird. Are you able to tell us anything about how L: is mounted or what it's pointing at? Do you know if it's SMB or similar, or if there are symlinks or similar? -- ___ Python track

[issue36652] Non-embedded zip distribution

2019-04-18 Thread Steve Dower
Steve Dower added the comment: Also see the packages on nuget.org, which are essentially just zip files (with metadata and installation tools available). -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Please provide a .zip Window

[issue36658] Py_Initialze() throws error 'unable to load the file system encoding' when calling Py_SetPath with a path to a directory

2019-04-18 Thread Steve Dower
Steve Dower added the comment: This is probably a documentation failure more than anything else. We're in the middle of redesigning initialization though, so it's good timing to contribute this feedback. The short answer is that you need to make sure Python can find the Lib

[issue36649] Windows Store app install registry keys have incorrect paths

2019-04-18 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-04-18 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +12802 ___ Python tracker <https://bugs.python.org/issue33608> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-20 Thread Steve Dower
Steve Dower added the comment: It'll probably be mbcs or oem encoding. Certainly not UTF-8 -- ___ Python tracker <https://bugs.python.org/issue36670> ___ ___

[issue36518] Avoid conflicts when pass arbitrary keyword arguments to Python function

2019-04-21 Thread Steve Dower
Steve Dower added the comment: No, now there is syntax that anyone using built in functions will have already learned I see no reason to create another way to solve the problem. -- ___ Python tracker <https://bugs.python.org/issue36

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-04-21 Thread Steve Dower
Steve Dower added the comment: If the code page is set to UTF-8 then mbcs will still be the right encoding :) -- ___ Python tracker <https://bugs.python.org/issue36

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset 56ed86490cb8221c874d432461d77702437f63e5 by Steve Dower (Zackery Spytz) in branch 'master': bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687) https://github.com/python/cpython/commit/56ed86490cb8221c874d43246

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

2019-04-22 Thread Steve Dower
Steve Dower added the comment: Thanks Zackery! I've merged this main part of the fix (though it requires a manual backport to 2.7). As it's a buffer overrun, I've sent it back to 3.6 as well. Eryk - thanks for the additional detail. I wonder whether it would be just as easy

[issue36672] A compiler warning in winreg.SetValue()

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset 34366b7f914eedbcc33aebe882098a2199ffaf82 by Steve Dower (Zackery Spytz) in branch 'master': bpo-36672: Fix a compiler warning in winreg.SetValue() (GH-12882) https://github.com/python/cpython/commit/34366b7f914eedbcc33aebe882098a

[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset 264490797ad936868c54b3d4ceb0343e7ba4be76 by Steve Dower in branch 'master': bpo-33608: Normalize atomic macros so that they all expect an atomic struct (GH-12877) https://github.com/python/cpython/commit/264490797ad936868c54b3d4ceb034

[issue36678] duplicate method definitions in Lib/test/test_dataclasses.py

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset be372d73b4c59026134a7e722ece34367c3bd3b6 by Steve Dower (Windson yang) in branch 'master': bpo-36678: Rename duplicate tests in test_dataclasses (GH-12899) https://github.com/python/cpython/commit/be372d73b4c59026134a7e722ece34

[issue36682] duplicate method definitions in Lib/test/test_sys_setprofile.py

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset 007d0b0188a16273a5850d89857ecef97c1f4595 by Steve Dower (Windson yang) in branch 'master': bpo-36682: Rename duplicate tests in test_sys_setprofile (GH-12895) https://github.com/python/cpython/commit/007d0b0188a16273a5850d89857ece

[issue36683] duplicate method definition in Lib/test/test_utf8_mode.py

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset f51dd4feb0794b7659f281173da9d8a04317d134 by Steve Dower (Windson yang) in branch 'master': bpo-36683: Rename duplicate test_io_encoding to test_pyio_encoding (GH-12896) https://github.com/python/cpyt

[issue36681] duplicate method definition in Lib/test/test_logging.py

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset 3d6f61edb8a6161148b3cf3eeb291408cc91154a by Steve Dower (Windson yang) in branch 'master': bpo-36681: Remove duplicate test_regression_29220 function (GH-12894) https://github.com/python/cpython/commit/3d6f61edb8a6161148b3cf3eeb2914

[issue36678] duplicate method definitions in Lib/test/test_dataclasses.py

2019-04-22 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36680] duplicate method definition in Lib/test/test_importlib/test_util.py

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset c442b1c486db5cb0aa589b43f73385d9cc5706e3 by Steve Dower (Windson yang) in branch 'master': bpo-36680: Rename duplicate test_source_from_cache_path_like_arg function (GH-12893) https://github.com/python/cpyt

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

2019-04-22 Thread Steve Dower
Steve Dower added the comment: New changeset d437012cdd4a38b5b3d05f139d5f0a28196e4769 by Steve Dower (Windson yang) in branch 'master': bpo-36679: Rename duplicate test_class_getitem function (GH-12892) https://github.com/python/cpython/commit/d437012cdd4a38b5b3d05f139d5f0a

[issue36682] duplicate method definitions in Lib/test/test_sys_setprofile.py

2019-04-22 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36683] duplicate method definition in Lib/test/test_utf8_mode.py

2019-04-22 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36679] duplicate method definition in Lib/test/test_genericclass.py

2019-04-22 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36681] duplicate method definition in Lib/test/test_logging.py

2019-04-22 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue18564] Integer overflow in the socket function parsing a Bluetooth address

2019-04-22 Thread Steve Dower
Steve Dower added the comment: According to a couple of scanf docs I found, the '%x' format expects to write into unsigned int*, just as we already do. So it shouldn't be possible to overflow there. The following line (or-ing all the values and checking that it's less th

[issue36680] duplicate method definition in Lib/test/test_importlib/test_util.py

2019-04-22 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36624] cleanup the stdlib and tests with regard to sys.platform usage

2019-04-22 Thread Steve Dower
Steve Dower added the comment: I like this, though I don't like using the platform module here and would prefer sys.platform to be canonical (until there's a need to differentiate - e.g. some tests coming for Windows ARM32 will need to be more specific). In general, I'd like

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

2019-04-22 Thread Steve Dower
Steve Dower added the comment: Declaring this done - Ned can take the backport to 3.6 if/when he feels like it. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

<    30   31   32   33   34   35   36   37   38   39   >