Steve Dower added the comment:
The problem is that if we add lots of new constants in 3.7.3, code written in
that version very easily becomes incompatible with 3.7.2 and earlier. So we
don't like making changes like that.
If we know which ones are "normally" defined on Linux
Steve Dower added the comment:
I like having the functions you added to parse argv into config, and I like
that they are separate from setting sys.argv.
Might it be better to go the other way and deprecate calling Main *without*
Initialize? That's easy to fix in Programs/python.c
Steve Dower added the comment:
RE making UnixMain public, I'd rather the core runtime require a known
encoding, rather than trying to detect it. We should move the call into the
detection logic into Programs/python.c so that embedders have to opt-in to
detection (many embedding scen
Steve Dower added the comment:
The problem with improving the generic error message is that we then build a
platform limitation into Python and if a later version of Windows fixes it then
Python needs to make another fix.
As Eryk said on the other issue, this may be because the current
New submission from Steve Dower :
URLs encoded with Punycode/IDNA use NFKC normalization to decompose characters
[1]. This can result in some characters introducing new segments into a URL.
For example, \uFF03 is not equal to '#' under direct comparison, but normalizes
to '#
Change by Steve Dower :
--
keywords: +patch
pull_requests: +12196
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
> If you want to force the usage of UTF-8, you can opt-in for UTF-8 mode: call
> putenv("PYTHONUTF8=1") before Py_UnixMain() for example.
I'm not talking about forcing UTF-8, I'm talking about *assuming* it (and
letting "someo
Steve Dower added the comment:
There are two features here, let's be clear about what we're removing.
* extending sys.path with static (perhaps relative) directories
* arbitrary code execution (following "import " statements)
Only Barry wants to remove the first one, and
Steve Dower added the comment:
New changeset 16e6f7dee7f02bb81aa6b385b982dcdda5b99286 by Steve Dower in branch
'master':
bpo-36216: Add check for characters in netloc that normalize to separators
(GH-12201)
https://github.com/python/cpython/commit/16e6f7dee7f02bb81aa6b385b982dc
Change by Steve Dower :
--
pull_requests: +12203
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +12205
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +12207
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: +patch
pull_requests: +12208
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36108>
___
___
Py
Change by Steve Dower :
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue36108>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue10009>
___
___
Steve Dower added the comment:
I guess we need a "skipInLinuxVenv", since it works fine on Windows :)
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
It's there now (and about to move to 1.1.1b :) )
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue24322>
___
___
Steve Dower added the comment:
For the dependency you'll need to modify the bootstrapper to manually enforce
checkbox selection. It'll also need to force the variable at planning time to
support command line installs, so the checkbox is really just to help prevent
users fro
Steve Dower added the comment:
Eryk - I've got the PR ready as far as I'm concerned. Have you had a look to
see if you're happy with its logic for these cases?
--
___
Python tracker
<https://bugs.pyt
Steve Dower added the comment:
I'm on this. I'll make a new (or possibly complete replacement) for @skipInVenv
that is @requireVenvCreate, since that's the common piece that doesn't work in
a venv (except on Windows).
--
assignee: -> steve.dowe
Steve Dower added the comment:
> Elaborate please, as it sounds like you're simply dismissing my usecase.
I'm suggesting that to enable this functionality at startup, the
user/application should have to do something like executing code or setting
PYTHONSTARTUP.
What I'm
Steve Dower added the comment:
> I don't think there would be an alternative to how these tools function if
> this feature were removed.
Right now, maybe, which is why we haven't just removed it :)
The point of the discussion is to say "this functionality is irrepla
Steve Dower added the comment:
Here's a trivial workaround for the import hook problem:
Assume we have "my_module.foo", and the import hook enables importing foo files.
Instead of just shipping "my_module.foo", you ship "my_module.py" and
"_my_modu
Steve Dower added the comment:
New changeset daad2c482c91de32d8305abbccc76a5de8b3a8be by Steve Dower in branch
'3.7':
bpo-36216: Add check for characters in netloc that normalize to separators
(GH-12201)
https://github.com/python/cpython/commit/daad2c482c91de32d8305abbccc76a
Steve Dower added the comment:
New changeset e37ef41289b77e0f0bb9a6aedb0360664c55bdd5 by Steve Dower in branch
'2.7':
bpo-36216: Add check for characters in netloc that normalize to separators
(GH-12201)
https://github.com/python/cpython/commit/e37ef41289b77e0f0bb9a6aedb0360
Steve Dower added the comment:
New changeset 2f8f56499c20af70ff5037fdbc5d738e56d9eab0 by Steve Dower in branch
'master':
bpo-36108: Avoid failing the build on race condition in clean (GH-12217)
https://github.com/python/cpython/commit/2f8f56499c20af70ff5037fdbc5d73
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +12210
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35978>
___
___
Py
Change by Steve Dower :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
New changeset bf94cc7b496a379e1f604aa2e4080bb70ca4020e by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074)
https://github.com/python/cpyt
Steve Dower added the comment:
Thanks for the patch! Once the backports merge, I (or someone else) will close
the issue.
--
___
Python tracker
<https://bugs.python.org/issue36
Change by Steve Dower :
--
pull_requests: +12213
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +12214
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Nonetheless, it's still something that we could support better. If telling
someone to set PYTHONSTARTUP is too hard, then we can design another way that
can work well without relying on a barely documented (mis)feature.
As one idea, we could add a w
Steve Dower added the comment:
> You mean extra junk like .pth files? I don't see the difference between a .py
> file and a .pth file, except I can’t opt out of .pth files.
And you get multiple lines of code, and syntax highlighting, and linting, and
all the other goodness i
Steve Dower added the comment:
We updated the build to be properly code signed, but the CDN may still be
caching the old release.
Nothing has changed except the signature on the installer (Python 2 binaries
have never been signed). I'll run a CDN purge to try and clear
Steve Dower added the comment:
I redownloaded and confirmed that the files are correct.
Benjamin - the MD5 for the 32-bit installer didn't get updated. It should be
912428345b7e0428544ec4edcdf70286 (as in my updated email I sent).
--
___
P
Steve Dower added the comment:
This issue is now assigned CVE-2019-9636
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-9636
--
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
Since the checks are all against empty strings, perhaps we can use "IF NOT
DEFINED PYTHON" instead? That should work as well, I think, and it'll save us
from problems in the future if someone puts "
Change by Steve Dower :
--
components: +Build
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue36245>
___
___
Python-bugs-list m
Steve Dower added the comment:
Confirmed. Neither was compromised, the only change was that the previous MSI
did not have an embedded Authenticode signature.
I didn't even rebuild the MSI, tbh. I went back to my (secure, controlled)
build machine and signed it man
Steve Dower added the comment:
> A missed print statement in the 2.7 patch is causing the tests to fail.
How does that cause tests to fail? Is it going to stderr? Or just causing an
error.
--
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
In the absence of any other comments, here's my proposal.
* call SetDefaultDllDirectories() in Py_Main (i.e. not when embedded) to ensure
secure search paths are always used
* ensure LoadLibrary when used in ctypes or importing will use the correct flags
Steve Dower added the comment:
> That will require rewriting many scripts and packages that use ctypes or cffi
> to load DLLs. It would also break DLLs that internally rely on modifying PATH
> for a delayed load, though I hope that's uncommon. I think it's easier for
&g
Steve Dower added the comment:
I like the patch, but I'm not sure all the tests are properly preserving the
real value of USERPROFILE.
Modifying this value could have a real impact on the rest of the process, so we
should be very careful to undo it regardless of test result. (Modifying
Change by Steve Dower :
--
pull_requests: +12272
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Thanks. Just posted a PR that puts the print behind a verbose flag (on Python 3
it uses subtest so that we see which character caused the failure).
If that doesn't work for whatever reason, I'll just leave it out and hope that
we never have to d
Steve Dower added the comment:
Great, thanks for checking! I'll merge.
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
New changeset 25ec4a45dcc36c8087f93bd1634b311613244fc6 by Steve Dower (Anthony
Sottile) in branch 'master':
bpo-36264: Don't honor POSIX HOME in os.path.expanduser on Windows (GH-12282)
https://github.com/python
Steve Dower added the comment:
I agree. Unfortunately, the operating system does not provide this information.
The best I can offer is to run Process Monitor [1] and watch its logs. It
should show the paths it attempts to access.
[1]: http://technet.microsoft.com/en-us/sysinternals/bb896645
Steve Dower added the comment:
Since I just dug enough to find it, the best way to diagnose problems with
dependent DLLs not being found is probably to run Process Monitor [1] while
doing the import and checking its logs. It should show the paths that were
attempted to be accessed.
[1
Steve Dower added the comment:
Yep. Done
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
> If we're going ahead with this, it's worth a mention in whatsnew
Good call. I'll do it
--
___
Python tracker
<https://bugs.
Change by Steve Dower :
--
pull_requests: +12273
___
Python tracker
<https://bugs.python.org/issue36264>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Presumably the issue is in the test and not the main change itself.
Is this another case where Linux can't run venv tests inside a venv?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
If it's fixed by not printing to the console, then it must be a refleak in
print. Or perhaps in the test failure/repeat.
That PR is going to be merged as soon as AppVeyor finishes, so nothing to worry
about
Steve Dower added the comment:
> Guido intentionally added support for HOME in ntpath.expanduser way back in
> Python 1.5 (circa 1997), and now we're removing it over 20 years later.
Wouldn't be the first thing to be removed :)
--
__
Steve Dower added the comment:
It may also be that the directory exists already - the previous test explicitly
removes it before calling create().
--
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
Maybe you can just call builder.create_configuration() from the test and pass
in enough context that it doesn't have to create a real venv? That would also
make the test faster.
--
___
Python tracker
&
Steve Dower added the comment:
> The alternative ...
Is what I proposed in the first place. Adding the SetDefaultDllDirectories call
to Py_Main (that is, NOT for embedders) is to ensure consistency throughout the
process. It'll only affect extension module dependencies that do t
Steve Dower added the comment:
Closing due to no response.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Closing due to no response
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Actually, CFFI is probably going to be most affected. Who do we know from that
project who should be nosied on this?
--
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
New changeset 507bd8cde60ced74d13a1ffa883bb9b0e73c38be by Steve Dower in branch
'2.7':
[3.7] bpo-36216: Only print test messages when verbose (GH-12291)
https://github.com/python/cpython/commit/507bd8cde60ced74d13a1ffa883bb9
Steve Dower added the comment:
It's different from ctypes because I can update ctypes as part of this change :)
The reason it matters is that it's basically a wrapper around LoadLibrary, and
that's what is going to change here. Hopefully we won't cause too much trou
Steve Dower added the comment:
Hah, I typo'd the commit message and marked it as 3.7 instead of 2.7. Oh well.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
New changeset 8ef864d50fb847cf15d5717c0db04fd60fb13d8d by Steve Dower in branch
'master':
bpo-36264: Updates documentation for change to expanduser on Windows (GH-12294)
https://github.com/python/cpython/commit/8ef864d50fb847cf15d5717c0db04f
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The PR looks good to me.
Are you able to test this test running from in a venv? I'm not at all clear why
it would work there when the others fail (there's another issue looking at
this, since it's only Linux that doesn't support venv-in
Change by Steve Dower :
--
keywords: +patch
pull_requests: +12275
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36174>
___
___
Py
Steve Dower added the comment:
New changeset 26c910c59c47bdef4220c34e66c45a625bda5e56 by Steve Dower in branch
'master':
bpo-36174: Update nuget authoring for new license field. (GH-12300)
https://github.com/python/cpython/commit/26c910c59c47bdef4220c34e66c45a
Steve Dower added the comment:
I'll do the 2.7 backport later (hopefully tomorrow, maybe?). Need to spin up my
build machine for it.
We currently don't include the license directly in the 2.7 nuget packages, so
there's a slightly bigger chance required (hopefully only a line
Change by Steve Dower :
--
keywords: +patch
pull_requests: +12277
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36085>
___
___
Py
Steve Dower added the comment:
Yeah, that failure on Windows is due to not correctly detecting a venv made
from a build tree, rather than a venv from a proper install. I have a fix for
that in the other bug. If it got that far, it means it used the correct prefix
path, so it'll be
Steve Dower added the comment:
PR has been posted, but it's incomplete (docs, news, etc.)
And unfortunately longer than I'd hoped, since we have to use GetProcAddress
for these function on Windows 7 still (even if it has the required update), but
since it's coming from ker
Steve Dower added the comment:
You mean like this:
>>> import _ssl
Traceback (most recent call last):
File "", line 1, in
ImportError: DLL load failed: The specified module could not be found.
Should include "_ssl" somewhere in the message? That's easy
Change by Steve Dower :
--
pull_requests: +12286
___
Python tracker
<https://bugs.python.org/issue36174>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset ce5c7a93d47e07327d19dfb47a967f1b18b7d6e8 by Steve Dower in branch
'2.7':
bpo-36174: Update nuget authoring for new license field. (GH-12300)
https://github.com/python/cpython/commit/ce5c7a93d47e07327d19dfb47a967f
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Okay, in that case we're just adding `shortname` into the formatted `message`
in _PyImport_FindSharedFuncptrWindows in Python/dynload_win.c
I've marked this as "easy (C)" as it seems like a good first contribution for
someone.
-
Steve Dower added the comment:
Yeah, someone still has to send a PR :)
--
keywords: +easy
stage: -> needs patch
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
> :-) I assume as we're at rc1, it's too late for 3.7.3, but it could be aimed
> at 3.7.4. I might try to have a look at it if no-one else does.
If Ned's okay with cherry-picking the change I have no problems with
taking it still. It&#x
Steve Dower added the comment:
For this one you're probably waiting on me to get time. I try to find an hour
or two each week, depending on what releases are going on, but it can be a
little unpredictable.
Zachary could also review and merge if he gets time first. I don't think an
Steve Dower added the comment:
The change in the PR should be all that's necessary - the props file you are
referring to is for end-users to integrate a Python build into their
application (where I still assume they don't want venvs, and if they do there's
already a pr
Steve Dower added the comment:
> I ran Tools/nuget/build.bat manually, and the resulting file didn't have
> lib\venv in it (I opened it in 7-zip, I don't know how to install a local
> nuget file...).
Huh, Tools/nuget/make_pkg.proj doesn't use the preset for some r
Steve Dower added the comment:
In your %TEMP% directory, there should be at least one more log file (probably
only one other) alongside the one you attached. It will have "core_JustForMe"
in the title. Could you find and attach this file? It has the actual cause of
the e
Steve Dower added the comment:
We just return the result of GetComputerNameEx [1] here - we don't use WMI at
all (and given the complexities, we are not going to start).
Are you able to provide any more information? In particular, if the
documentation for GetComputerNameEx (below) help
Steve Dower added the comment:
I think we'll be keeping Win7 with the KB.
However, we've discovered in the PR that changing the default DLL lookup may
cause Python to crash when accessing HKEY_PERFORMANCE_DATA (which fails to
delay-load a DLL). This occurs because accessin
Steve Dower added the comment:
It looks like something on your system "cleaned up" the installer while it was
still running. Sometimes this can be AV or system policies, but there's nothing
we can fix in the installer for it.
Here are some things you can try (one at a time):
Steve Dower added the comment:
Yeah, this is a dup of issue35941. I'm not sure why the contributor withdrew
their PR, but it seems that is what happened.
--
components: +Windows
nosy: +paul.moore, tim.golden, zach.ware
resolution: -> duplicate
stage: -> resolved
s
Change by Steve Dower :
--
assignee: steve.dower ->
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue35941>
___
___
Pyth
Steve Dower added the comment:
Fixed for 3.7 and master.
If it needs to go into 2.7 then someone will need to backport it manually.
--
stage: patch review -> backport needed
versions: -Python 3.4, Python 3.5, Python 3.6
___
Python tracker
<
Steve Dower added the comment:
New changeset 7ee88bf3e59493137a775368165c5c5fe1ed7f46 by Steve Dower (Jess) in
branch 'master':
bpo-36245: Avoid problems when building in a directory containing spaces.
(GH-12241)
https://github.com/python/cpyt
Steve Dower added the comment:
Doesn't seem to be anything to fix upstream here.
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<https://bugs.python.
Steve Dower added the comment:
New changeset 8bba81fd55873148c65b7d0e6a6effbd63048c76 by Steve Dower in branch
'master':
bpo-35978: Correctly skips venv tests in venvs (GH-12220)
https://github.com/python/cpython/commit/8bba81fd55873148c65b7d0e6a6eff
Steve Dower added the comment:
I don't know about your other PRs, and I don't deny they may have been
neglected for some time, but you only allowed 12 hours on this one between
receiving a review and closing it. Our team of volunteers have limited time
(typically 0-8 hours/week)
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I added some logging for the AppVeyor build at
https://ci.appveyor.com/project/python/cpython/builds/23258953
Looks like the offending DLLs are:
- perf-MSSQL$SQL2017-sqlctr14.0.1000.169.dll
- perf-MSSQL$SQL2016-sqlctr13.1.4474.0.dll
Since the events are pulled
3301 - 3400 of 5794 matches
Mail list logo
