Change by Steve Dower :
--
pull_requests: +10953, 10954, 10955
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue35596>
___
_
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Azure Pipelines can now support container jobs:
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=vsts&tabs=yaml
I experimented with enabling a manylinux1 build a while back, which should now
be able to use identical s
Steve Dower added the comment:
New changeset 872bd2b57ce8e4ea7a54acb3934222c0e4e7276b by Steve Dower in branch
'master':
bpo-35596: Use unchecked PYCs for the embeddable distro to avoid zipimport
restrictions (GH-11465)
https://github.com/python/cpyt
Steve Dower added the comment:
This is now resolved, and only through modifying the build scripts. Which means
I can take the existing build and republish a fixed embeddable package without
needing a new release.
Unless Ned would prefer a complete release
Steve Dower added the comment:
I know how to purge the CDN cache, so that's not an issue. And there's no good
reason to leave the old one up.
Perhaps we can just add a note to the download page and I'll post on a couple
of lists? This is basically a product recall, and th
Steve Dower added the comment:
I can add a .post1 into the version number in the zip file? Still want to take
the old one down though, and if anyone is using any sort of script to get this
file then it'll be just as annoying for the link to be broken as getting a
broken dow
Steve Dower added the comment:
I can add ".post1" to the version number in the file name, but I'd still want
to take down the broken one. And anyone who's generating the download URL will
get a broken link, which IMO is just as bad as a broken download w
Steve Dower added the comment:
This doesn't appear to be Windows-specific or related to our test suite, so I
updated the tags and added the unittest experts.
--
nosy: +ezio.melotti, michael.foord, rbcollins
___
Python tracker
&
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue35687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Agreed. My plan is to just replace the precompiled ZIP file of the standard
library in the embeddable package with one with PYCs missing the "check source"
bit that the old zipimport rejects. It's as simple as a 1 line change in a
supporti
Steve Dower added the comment:
I've updated the files and sent Ned the info needed to confirm and update the
download page.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Excellent catch! Are you interested in creating a PR?
Also, I don't recall whether we are handling multiple installs or not, but if
we are not I would rather explicitly list the products that may include
compilers than using "*" (since there
Steve Dower added the comment:
Adding my comment from the PR review:
Dealing with leading/trailing whitespace could get interesting here. All the
other values can be trimmed at both ends, while this one (currently) must have
one space removed from the start.
Perhaps we should insert the
Steve Dower added the comment:
The patch won't work on my machine - "chrome[.exe]" is not on my PATH:
>>> import shutil
>>> shutil.which("chrome")
>>> import webbrowser
>>> webbrowser.register("chrome", N
Steve Dower added the comment:
The "8232_1.patch" patch on #8232 implements a registry-based lookup (including
for Chrome) that will be far more reliable than the current process's
environment. So it's not a direct duplicate, but the proposed fix will resolve
Steve Dower added the comment:
New changeset 6aedfa6b9ac324587f64133c23757a66a8f355bb by Steve Dower
(antektek) in branch 'master':
bpo-34855: Fix EXTERNALS_DIR build variable for Windows (GH-11177)
https://github.com/python/cpython/commit/6aedfa6b9ac324587f64133c23757a
Change by Steve Dower :
--
keywords: +patch
pull_requests: +11010
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35683>
___
___
Py
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +11010, 11011
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch, patch
pull_requests: +11010, 11011, 11012
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
The tests mostly fail in the PGO run because they are highly sensitive to the
source tree layout. We've never fixed them because they aren't that important
to the PGO run - failure cases help with training - and the real tests pass
fine under
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Your tests actually went the other way. This one puts a trailing space after
the prompt and expected it to be there in the file, but also ensured that
exactly one space was added at the start.
self.assertEqual(context.prompt, '(My p
Steve Dower added the comment:
Defining new training sets for PGO would be a new job (that you could volunteer
to do if you like). The test suite is convenient because when you clone our
GitHub repository, it's already there. Another training suite would have to be
installed somehow as
Steve Dower added the comment:
> It is true that I worry about failing tests during PGO training because they
> stop me from compiling Python -with- PGO.
They shouldn't prevent you from compiling with PGO... even if they cause Python
to crash, you should be able to compile still
Steve Dower added the comment:
One other aspect of this may be the confusion that ensues when changing the
setting doesn't change the prompt when you activate it.
It would be possible (though not necessarily trivial) to update the activate
scripts to read the prompt from the file, tho
Steve Dower added the comment:
You can provide this new default as a command line option when invoking the
script (--pgo-job, IIRC), which should satisfy the occasional need to do this.
I would rather keep the default quieter so that the build does not take as long
(though I guess there is
Steve Dower added the comment:
I posted on the numpy thread: Most likely the DLL is failing to load, which the
importer returns as "not found" (as it falls back on other search mechanisms
and doesn't retain the error). I suggested loading it directly with ctypes to
see if t
Steve Dower added the comment:
In issue 22759 there was some logic applied for which errors to forward rather
than hide.
I'm inclined to agree that this one should be hidden, but it may have to be
done by checking the winerror field rather than the exception type, since
Steve Dower added the comment:
It's broken, but unused. And the entire section needs fixing before it can be
used, which necessitates fixing this function. So issue 29871 covers this
sufficiently (though I'll post a link back to this one for the added context on
this partic
Steve Dower added the comment:
On issue 35562 Jeff posted a deeper analysis of the issue in TIMEDWAIT. That
will need fixing along with the other regressions before we can enable these.
--
nosy: +je...@livedata.com
___
Python tracker
<ht
Steve Dower added the comment:
No progress, but I like the extra defines idea best (directly in
socketmodule.c, not in a public header file). That's the easiest way to close
the gap between (apparently) real constants used on Windows and the
preprocessor defines (apparently) used else
Steve Dower added the comment:
Pathlib doesn't necessarily directly follow os on its error handling - adding
Antoine for comment.
Passing strict=False to resolve() should be able to handle an invalid name like
that. If not, I propose that we change it so that it does.
--
Steve Dower added the comment:
> use AddDllDirectory, (which is as accessable as os.environ['PATH'] but is not
> considered a security risk so far)
The parenthical is incorrect. The user-specified DLL search directory is
separate from PATH, and both appear in the default
Steve Dower added the comment:
I have made the changes I suggested (though correctly...), but ultimately we
need to create our own Docker image suitable for running these tests.
So for now, I'm proposing in my PR to make most of the change, as well as a few
other Pipelines/test-re
Steve Dower added the comment:
Reminder to myself (or permission for anyone else) to merge this. My phone
won't let me actually click the github merge button, unfortunately, but this
seems good to go.
--
___
Python tracker
&
Steve Dower added the comment:
There is one buildbot
(https://buildbot.python.org/all/#builders/40/builds/1524) that started
randomly failing unrelated tests with this change - usually one of zipapp,
pkgutil, or zipimport. I don't have any idea what the relationship here is,
unles
Steve Dower added the comment:
Good catch! I'm surprised we don't have any tests for this, but I guess we
don't really create any virtual environments in our test suite. A shame nobody
hit it during RC.
I don't actually know the best fix for this. The venv python.exe sc
Steve Dower added the comment:
You can't create symlinks on Windows without additional user permissions, and
the old method of copying most of the binaries was slow and made DLL hell
worse, as well as simply not working with the Windows Store model that does not
let random executables
Steve Dower added the comment:
> We need a way to allow multiprocessing to spawn the real python.exe instead
> of the launcher executable that's set as sys.executable.
Got to a computer and had just reached the same conclusion.
Given the environment is inherited, it&#
Steve Dower added the comment:
The first idea makes sense, but because of how we've already architected things
(and the direction we're trying to rearchitect things) it isn't really that
feasible.
The second idea could be good. It isn't that hard to make globally named
Steve Dower added the comment:
> So I think "breaking if environment variables are not inherited" is a less
> severe failure mode than this issue is.
ISTR that having sys.executable point to a path outside of sys.prefix breaks
the site module in some way, so that would m
Steve Dower added the comment:
> I would prefer a -X command-line option, such as "VIRTUAL_ENV".
> multiprocessing could propagate this option to worker processes.
Right, so would I, but it needs to be propagated basically everywhere (unless
"everywhere" all defe
Steve Dower added the comment:
We already compile 32-bit CPython without PGO on Windows, so I don't think
there's anything to do here apart from record the issue.
It's very likely that 3.8 will finally get an updated libffi, which should deal
with this completely (or f
Steve Dower added the comment:
New changeset 28f6cb34f602b9796987904a607dceaf2e4a9e78 by Steve Dower in branch
'master':
bpo-35683: Improve Azure Pipelines steps (GH-11493)
https://github.com/python/cpython/commit/28f6cb34f602b9796987904a607dce
Change by Steve Dower :
--
pull_requests: +11438
___
Python tracker
<https://bugs.python.org/issue35683>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +11438, 11439
___
Python tracker
<https://bugs.python.org/issue35683>
___
___
Python-bugs-list mailing list
Unsub
Change by Steve Dower :
--
pull_requests: +11438, 11439, 11440
___
Python tracker
<https://bugs.python.org/issue35683>
___
___
Python-bugs-list mailing list
Unsub
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue35804>
___
___
Steve Dower added the comment:
I recently added (and even more recently fixed) the "--tempdir" option for
libregrtest, so that can be used to specify a temporary location for *most*
tests. Some still ignore that setting (notably distutils), but it's a starting
point.
I a
Steve Dower added the comment:
New changeset 128efcade63480b5860a6d045a41ba4abf5eea2f by Steve Dower in branch
'3.7':
bpo-35683: Improve Azure Pipelines steps (GH-11493)
https://github.com/python/cpython/commit/128efcade63480b5860a6d045a41ba
Steve Dower added the comment:
As mentioned above, those changes are other improvements that were worth
taking, and about half of the required manylinux1 changes. But we probably need
to maintain our own manylinux image for building/running CPython tests, if we
want to do it. The existing
Steve Dower added the comment:
> How about making the py[w].exe launcher unset __PYVENV_LAUNCHER__ whenever it
> runs a registered version explicitly?
I think this is a good idea, though it can be unset unconditionally. If we're
in a virtual environment, then it will run the i
Steve Dower added the comment:
FWIW, a symlink should be able to launch the Store Python - the problem with
the old approach was it never tried to launch the original Python, but only
load it's DLLs which won't work (maybe there's a way to enable the app context,
but t
Steve Dower added the comment:
It might be worth adding a summary of that to the porting notes, but I think
the actual impact will be minimal. Launching processes by relative path has
been a bad decision for long enough now that I'd expect it to be rare, and the
Scripts directory l
Steve Dower added the comment:
I think that snippet may have to change to accommodate the multiprocessing
issue, where we need to stop replacing sys.executable with the venv launcher
and have it point to the base python.exe (and then anyone launching
sys.executable needs to preserve
Change by Steve Dower :
--
keywords: +patch
pull_requests: +11497
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +11497, 11498
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch, patch
pull_requests: +11497, 11498, 11499
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +11500
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +11500, 11501
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch, patch
pull_requests: +11500, 11501, 11502
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset adad9e68013aac166c84ffe4e23f3a5464f41840 by Steve Dower in branch
'master':
bpo-35811: Avoid propagating venv settings when launching via py.exe (GH-11677)
https://github.com/python/cpython/commit/adad9e68013aac166c84ffe4e23f3a
Steve Dower added the comment:
New changeset 4e02f8f8b4baab63f927cfd87b401200ba2969e9 by Steve Dower in branch
'master':
bpo-35797: Fix default executable used by the multiprocessing module (GH-11676)
https://github.com/python/cpython/commit/4e02f8f8b4baab63f927cfd87b4012
Steve Dower added the comment:
I realised while doing the fix that changing sys.executable to point to the
"real" python.exe would break scenarios that involve generating scripts. All of
those have been relying on sys.executable launching the venv, which would break
if we change
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
You should have a set of log files in your %TEMP% directory. Their names will
start with Python and end in .log. If you could collect these into a zip file
and post them here, that would be very helpful
Steve Dower added the comment:
Thanks. You should have some more log files - I'm particularly interested in
the one with "3.7.2" and "core_JustForMe" in the filename, as that is the one
that failed.
Also, did you notice that you have 64-bit 3.7.0 and 32-bit 3.7.2?
New submission from Steve Dower :
The change to pull the redirector executables as part of scripts was... perhaps
too clever. There exists code out there that uses EnvBuilder to create
environments _without_ copying scripts, which now results in an environment
that does not include
Steve Dower added the comment:
Actually, it seems like venv symlinks are so far from working that they haven't
worked (on Windows) since 3.5 or possibly earlier.
I'm just going to make that option ignored and mark it as such i
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +11548, 11549
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +11548
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35854>
___
___
Py
Change by Steve Dower :
--
keywords: +patch, patch, patch
pull_requests: +11548, 11549, 11550
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
No, removing it was accidental. But when I tried it myself with a few regular
installs of 3.5 and later, none of them updated sys.path correctly, and all of
them resolved the links in the loader (or perhaps the shell?).
I hadn't activated the environment
Steve Dower added the comment:
Okay, testing more thoroughly on 3.5, symlinks are fine from the console but
not via Explorer.
Personally, I dislike that double-clicking python.exe is different from running
it from the command line, but so be it. I'll add a note to the docs that
Steve Dower added the comment:
New changeset a1f9a3332bd4767e47013ea787022f06b6dbcbbd by Steve Dower in branch
'master':
bpo-35854: Fix EnvBuilder and --symlinks in venv on Windows (GH-11700)
https://github.com/python/cpython/commit/a1f9a3332bd4767e47013ea787022f
Steve Dower added the comment:
Hi Shiva, sorry for not noticing your PR earlier.
I have one question for Eryk, who may be able to answer more easily than I can:
do we need to initialize cbSize before calling GetStartupInfoW()?
The docs[1] don't seem to suggest it, and I can't l
Steve Dower added the comment:
Sorry for the delay on this. I've approved the PR and restarted the CI systems
to make sure it's all okay.
I agree that many of these cases no longer have to dynamically load the
functions, but that should be fixed separately.
--
versions
Steve Dower added the comment:
New changeset 05e922136a3286893bd489a8f2ecfa0dba4da368 by Steve Dower
(native-api) in branch 'master':
bpo-33316: PyThread_release_lock always fails (GH-6541)
https://github.com/python/cpython/commit/05e922136a3286893bd489a8f2ecfa
Change by Steve Dower :
--
stage: patch review -> backport needed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.org/issue33316>
___
___
Py
Steve Dower added the comment:
I resolved some conflicts and will merge this once CI completes.
If the backport to 2.7 isn't automatic then it may wait until someone else
comes in to do it.
--
assignee: loewis -> steve.dower
versions: +Python 3.7, Python 3.8 -Python 3.4, Py
Steve Dower added the comment:
Among other things, the version of the C runtime you were using on that old
system probably has its own set of bugs that have since been resolved.
Thanks for reporting the issue, though!
--
resolution: -> fixed
stage: patch review -> resolved
Steve Dower added the comment:
New changeset 2de576e16d42ce43698d384d0dd46ba6cf165424 by Steve Dower (Tzu-ping
Chung) in branch 'master':
bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one
character (GH-4517)
https://github.com/python/cpyt
Steve Dower added the comment:
As expected, the 2.7 backport needs more work.
Leaving this open for anyone who wants to handle it. I'll happily click merge
for you if CI passes.
--
stage: patch review -> backport needed
___
Python tracker
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
New changeset 4860f01ac0f07cdc8fc0cc27c33f5a64e5cfec9f by Steve Dower (Tony
Roberts) in branch 'master':
bpo-33895: Relase GIL while calling functions that acquire Windows loader lock
(GH-7789)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Great, thanks. I'll go ahead and merge.
--
___
Python tracker
<https://bugs.python.org/issue32560>
___
___
Python-bugs-list m
Change by Steve Dower :
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset b82bfac4369c0429e562a834b3752e66c4821eab by Steve Dower (Mark
Becwar) in branch 'master':
bpo-29734: nt._getfinalpathname handle leak (GH-740)
https://github.com/python/cpython/commit/b82bfac4369c0429e562a834b3752e
Steve Dower added the comment:
We certainly shouldn't be calling CloseHandle on a parameter like this anyway,
so the change looks good to me.
However, I notice that we don't necessarily preserve GetLastError() throughout
here, so perhaps we ought to consider changing the re
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +11654
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34691>
___
___
Py
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +11654, 11655
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch, patch
pull_requests: +11654, 11655, 11656
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue34691>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
New changeset 4c70d9f79c9b371990c8e054ccde53f7ff15946b by Steve Dower in branch
'master':
bpo-34691: Compile _contextvars module into main Python library (GH-11741)
https://github.com/python/cpython/commit/4c70d9f79c9b371990c8e054ccde53
Steve Dower added the comment:
This scenario should work, as running the other venv's redirector will update
the variable.
The nearly identical report in issue35873 is apparently launching "default"
Python, but presumably without clearing the variable. Since I can't tell
Change by Steve Dower :
--
keywords: +patch
pull_requests: +11664
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35299>
___
___
Py
3001 - 3100 of 5794 matches
Mail list logo
