Steve Dower added the comment:
New changeset 253209149389e6793a052034e1f2d97691086f18 by Steve Dower in branch
'3.7':
[3.7] bpo-34977: Add Windows App Store package (GH-10245)
https://github.com/python/cpython/commit/253209149389e6793a052034e1f2d9
Steve Dower added the comment:
Making the release experimental as part of the next 3.7 update was approved by
Ned (over email), so I merged the build. As soon as we snap for the RC I'll
kick off an update and make the store page public, and hopefully can promote it
enough to get eyes
Change by Steve Dower :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mai
Steve Dower added the comment:
Okay, so apparently the buildbots are still building with VS 2015, and not VS
2017.
I'll add a check for the new executable and repush. This was caused solely by
the new code and not by any of the changes to existing
Steve Dower added the comment:
No, it just automates something that's been manual for a while. Installing VS
2017 on build bots is still a manual process ;)
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
We haven't done RC yet - why is pushing this now so bad? Most of the change is
purely additive and does not modify the code base, the rest is Windows-only or
tests.
I'll add checks for outdated build machines, but there has to be a release of
Change by Steve Dower :
--
pull_requests: +10263
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +10264
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
>> We haven't done RC yet - why is pushing this now so bad?
> I reverted your change because it broke all Windows buildbots, and we have a
> policy to revert a change if buildbots turn red and no fix can be found in 2
> hours
I don't
Change by Steve Dower :
--
pull_requests: +10265
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +10266
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I'm getting the cpython-source-deps repo updated now, and will do the Windows
updates shortly after.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Thanks Terry, great questions.
> I want this to be and remain an added alternative rather than a replacement
> of the current installer directly available on python.org. Can you assure us
> that the latter are not going away?
Absolutely. Th
Steve Dower added the comment:
> The first thing I'll note is that I'm not aware of any documentation
> on the Windows Store installer, and how it works.
Right now, correct.
> How will the Windows Store install work alongside the PSF one?
It will go into PATH under t
Steve Dower added the comment:
> How will the Windows Store install work alongside the PSF one?
Oh, and since I didn't mention it in my direct answer, the Store install goes
to a totally different location (per machine, no elevation required), as do
packages installed u
Steve Dower added the comment:
Bin and source dependency repos are updated - just needs the project updates
now and testing.
--
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
> In general, I don't think we've done that great a job of publicising
> the various install options on Windows - we still get pip users trying
> to install packages into the embedded distribution, which they are
> using as if it were a
Steve Dower added the comment:
It looks like you're not able to download the debug symbol packages from your
machine. This may be a network issue or perhaps a totally disconnected machine?
If you run setup with the "/layout [directory]" option on a machine with
internet acce
Steve Dower added the comment:
Instrumentation is not the same thing as profiling, and this one is certainly
not intended for performance. That said, simply importing it shouldn't impact
anyone else's performance either, and since six imports this, fixing it will
have a pretty br
Steve Dower added the comment:
> In which case, let's have a placeholder note in the docs, saying that
> the Windows Store installer exists, but it's experimental and may have
> unexpected interactions with other tools that expect a standard Python
> install. Users tr
Steve Dower added the comment:
Did you see my comment about converting the version numbers to System.Version
before comparing? (I didn't know it could be done the first time I looked :) )
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
If you weren't conflating profiling and instrumentation then your original
comment makes no sense.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
(Sorry, page submitted while I was still typing for some reason.)
... Instrumentation for everything other than time is unaffected, so if you
didn't mean to conflate them, then no there is no impact on the documented use.
Yes, moving mimetypes.init t
Steve Dower added the comment:
> I agree that makes no sense at all.
I have to admit I have no idea what you're trying to argue or suggesting as an
alternative. Could you try clearly explaining the change you'd rather see to
Steve Dower added the comment:
So, you're suggesting doing a lazy mimetypes.init() on Windows and not on the
others? There's no reason to have such a semantic difference between platforms,
and since the whole point of mimetypes.init() is to avoid initializing on
import, it make
Steve Dower added the comment:
New changeset f46eccd0ffe65333035c3820886295b71c41ab6e by Steve Dower (Jeremy
Kloth) in branch 'master':
bpo-35433: Properly detect installed SDK versions (GH-11009)
https://github.com/python/cpython/commit/f46eccd0ffe65333035c3820886295
Change by Steve Dower :
--
pull_requests: +10293
___
Python tracker
<https://bugs.python.org/issue35433>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Thanks for being thorough. I've merged the change now.
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.p
Steve Dower added the comment:
Not making this change for Python 3.6, as that apparently breaks with the
latest SDK (seen in the Pipelines build). So we'll leave 10.0.15063.0 as the
maximum version for that - it's about to go into security mode anyway, and we
don't rely on an
Steve Dower added the comment:
Thanks for the extra info! I think the registration is put in there during
install in case the PC restarts part way through, but it doesn't have to hang
around after install is complete. Your explanation makes sense, and is a good
reason to disable anti
Steve Dower added the comment:
I'm just waiting on Victor to sign off on PR 11029 (or someone else to do it)
so I can merge it and rebase PR 11027.
Hopefully then someone will review it today so that we don't have to hold up
3.7.2rc1
Steve Dower added the comment:
Okay, I'll merge the first part now so I can rebase the main one and
*hopefully* someone will be willing to review it now it's smaller. Otherwise, I
think we're best to go with buildbots and all the testing I've already done.
This is my sol
Steve Dower added the comment:
New changeset 1c3de541e64f75046b20cdd27bada1557e550bcd by Steve Dower in branch
'master':
bpo-34977: Use venv redirector instead of original python.exe on Windows
(GH-11029)
https://github.com/python/cpython/commit/1c3de541e64f75046b20cdd27bada1
Steve Dower added the comment:
New changeset b264c609853eae9dbb45c6dbee11e84ae3927e88 by Steve Dower in branch
'3.7':
[3.7] bpo-34977: Use venv redirector instead of original python.exe on Windows
(GH-11029)
https://github.com/python/cpython/commit/b264c609853eae9dbb45c6dbee11e8
Steve Dower added the comment:
New changeset f04cc5fc0d2f644cccb57543aae487ee30091924 by Steve Dower (Jeremy
Kloth) in branch '3.6':
[3.6] bpo-35433: Properly detect installed SDK versions (GH-11009)
https://github.com/python/cpython/commit/f04cc5fc0d2f644cccb57543aae487
Change by Steve Dower :
--
resolution: -> fixed
status: open -> closed
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/issue35433>
___
__
Steve Dower added the comment:
Paul (and anyone else) - the below link should go directly to just the commit
with the docs update. I did a slight rearrangement of the install docs to make
the options clearer, and wrote up *just* enough info on nuget to help people
use it right (I hope
Change by Steve Dower :
--
keywords: +patch
pull_requests: +10320
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35401>
___
___
Py
Change by Steve Dower :
--
pull_requests: +10321
___
Python tracker
<https://bugs.python.org/issue35401>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I'm also looking at it, so please don't revert it just yet.
I just installed 10.0.15063 onto my dev machine to test another 3.6 fix and it
worked fine, so perhaps there's an option that is off here?
--
re
Steve Dower added the comment:
Both io.h and stddef.h are from the UCRT, which *may* go through a different
detection process than the rest of the WinSDK. That might be the cause.
The "didn't find any supported SDKs" behavior is to try and use the earliest,
which should fa
Steve Dower added the comment:
So before the change, the 16299 SDK wasn't being detected either, but perhaps
the 10240 one was? That had some known issues in the debug UCRT, which is why
the version gets printed out towards the end of the build.
The only thing I can think of would b
Steve Dower added the comment:
Thanks, Paul. Appreciate it :)
Doing a final call before I hit merge in an hour or so. Right now:
* full release build works
* full test pass on all CI + custom buildbots work
* prior test package made it to the store
* docs clearly show it may change again
Any
Steve Dower added the comment:
New changeset 0cd6391fd890368ea1743dac50c366b42f2fd126 by Steve Dower in branch
'master':
bpo-34977: Add Windows App Store package (GH-11027)
https://github.com/python/cpython/commit/0cd6391fd890368ea1743dac50c366
Steve Dower added the comment:
New changeset 4824385fec0a1de99b4183f995a3e4923771bf64 by Steve Dower in branch
'master':
bpo-35401: Update Windows build to OpenSSL 1.1.0j (GH-11088)
https://github.com/python/cpython/commit/4824385fec0a1de99b4183f995a3e4
Steve Dower added the comment:
New changeset 309d7207f691b3eaa988d2293b9d023943982a9f by Steve Dower in branch
'3.6':
bpo-35401: Updates Windows build to OpenSSL 1.0.2q (GH-11089)
https://github.com/python/cpython/commit/309d7207f691b3eaa988d2293b9d02
Change by Steve Dower :
--
pull_requests: +10323
___
Python tracker
<https://bugs.python.org/issue35401>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 0e4ad88ff8956d9289ab0a1314636ac15b374459 by Steve Dower in branch
'3.7':
bpo-34977: Add Windows App Store package (GH-11027)
https://github.com/python/cpython/commit/0e4ad88ff8956d9289ab0a1314636a
Steve Dower added the comment:
New changeset 3c8bd22b8f0d7f57261b9d3c90e56447cd5acf94 by Steve Dower in branch
'2.7':
bpo-35401: Updates Windows build to OpenSSL 1.0.2q (GH-11089)
https://github.com/python/cpython/commit/3c8bd22b8f0d7f57261b9d3c90e564
Change by Steve Dower :
--
pull_requests: +10324
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Luckily, just noticed that I introduced a bug as part of splitting up the
original PR into two.
It wasn't going to have an impact until the package was properly installed from
the store, but without the proper directory resolution in there (since the
var
Steve Dower added the comment:
New changeset d5a6a389d492c5e3d7933bafbd5252fd86ac4d49 by Steve Dower in branch
'master':
bpo-34977: Remove unused preprocessor definition (GH-11092)
https://github.com/python/cpython/commit/d5a6a389d492c5e3d7933bafbd5252
Steve Dower added the comment:
I pushed the raw Tcl and Tk sources for 8.6.9.0 to cpython-source-deps, but it
looks like we need some patches to be able to build on Windows (the X11 headers
#define some names that the Windows headers want to use as struct members).
So far I've need
Steve Dower added the comment:
Looks like Tix needs similar updates, since it imports the Tk headers. Perhaps
it'll be easier to undef immediately after the X11\X.h include? Assuming the
values aren't actually being used anywhere.
--
Steve Dower added the comment:
Probably. I'm 99% sure it's a problem with the latest build tools, and nothing
to do with Python. Though I haven't checked out whether we're injecting any
compile time flags that may be causing extra things to be included - I have no
idea
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I have another idea - what if we checked self.extensions_map for overrides but
otherwise just called mimetypes.guess_type(path) in the guess_type method? That
would be the same behaviour as initializing it lazily, but we don't have to
worry about initial
Steve Dower added the comment:
Setting DefaultWindowsSdkVersion to 10.0.15063.0 seems to work for the Python
3.7 and 3.8 builds.
Unless there's a security reason (which I don't believe there is), there's no
need to worry about 3.6.
--
version
Change by Steve Dower :
--
pull_requests: +10377
___
Python tracker
<https://bugs.python.org/issue35402>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset f8e9bd568adf85c1e4aea1dda542a96b027797e2 by Steve Dower in branch
'master':
bpo-35402: Update Windows build to use Tcl and Tk 8.6.9 (GH-11146)
https://github.com/python/cpython/commit/f8e9bd568adf85c1e4aea1dda542a9
Steve Dower added the comment:
New changeset 77824ef6e50e8a47a0b57df2d9f3b48bffd414ac by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-35402: Update Windows build to use Tcl and Tk 8.6.9 (GH-11146)
https://github.com/python/cpython/commit/77824ef6e50e8a47a0b57df2d9f3b4
Steve Dower added the comment:
You're right, this is doing something weird on master as well.
I'll take a look when I get a chance, but if anyone else wants to dive in feel
free.
In both cases, the doc file cannot be opened. Marking this as a release blocker
and adding RM to t
Steve Dower added the comment:
SQLite updates and changes for us almost always get stuck on someone being
willing to verify that nothing has broken (and stand by their analysis).
Without an active expert (I just nosied ghaering in case they are around), I'm
not confident to make this c
Steve Dower added the comment:
I did a quick look and couldn't find anything obvious in logs while building,
so I guess the next step is to try taking out those new index entries to figure
out which one causes the problem.
(Adding Serhiy for awareness, not necessarily trying to nominat
Steve Dower added the comment:
That option is only for the py.exe launcher and not the whole installation
(notice the target path is still under C:\Users).
Having an updated image would be fine, though the only difference should be the
version number. If you can provide a similar sized
Steve Dower added the comment:
It looks like generally the ' entity does not work in the CHM index -
there should be b' and u' entries as well, but they show up as b and u (whereas
b" and u" are fine).
Substituting ' seems to work fine, but I had to do that
Steve Dower added the comment:
I've got an alternate PR to do the fixup in an extension, as well as fixing two
other minor build problems for docs (on Windows).
--
___
Python tracker
<https://bugs.python.org/is
Change by Steve Dower :
--
pull_requests: +10459
___
Python tracker
<https://bugs.python.org/issue35482>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
It looks like display scaling, which you'll need to disable for this. The UI
for the installer is slightly aware of scaling, but not enough to resize
multiline elements automatically.
--
___
Python tracker
&
Change by Steve Dower :
--
pull_requests: +10501
___
Python tracker
<https://bugs.python.org/issue35482>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
The 3.6 PR is blocked from merging, so looking to Ned to resolve.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The change in PR 880 looks fine to me. I dislike defining names without a Py
prefix in public headers.
And PRs are not where we do general discussion or ping for attention. Make sure
the nosy list includes the relevant experts (in this case probably me) and
Steve Dower added the comment:
Sounds fine to me.
Any particular reason to put it in signal rather than os/posixmodule? If it's
just to avoid treating os/posixmodule like a dumping ground for C89/POSIX
APIs... well... too late :) I say keep dumping them there. But I don't have
Steve Dower added the comment:
That implementation will require some more of our usual macros around the call
itself (for GIL and invalid values), and maybe clinicisation, as well as more
through tests, which are probably going to be the hardest part.
Nathaniel - were you planning to do
Steve Dower added the comment:
They should set it, and it will be read in PCbuild/python.props which has the
"correct" name (I forget what it is right now and am not looking it up on my
phone)
--
___
Python tracker
<https://bu
Steve Dower added the comment:
Have you tried a proper install as well? Could you do that to rule out any
problem on your machine?
Are you repackaging anything as part of your app, or are you just testing the
package first and getting this error?
It looks like you're running fro
Steve Dower added the comment:
Okay, this looks like a zipimport issue. When I extract the "python37.zip" file
containing the stdlib and reference the directory it works fine. But no matter
what I do to the ZIP I can't get it to run.
It seems that zipimport either can'
Change by Steve Dower :
--
keywords: +patch
pull_requests: +10594
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch
pull_requests: +10594, 10595
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch, patch, patch
pull_requests: +10594, 10595, 10596
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Thanks for the extra info, and for confirming that 3.6.8 isn't affected (I
hadn't tried that you, so you saved me some work :) )
This is definitely a new zipimport regression in 3.7.2. Thanks for the report.
--
keywords: +3.7regression -pa
Change by Steve Dower :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Fatal Python error: initfsencoding: unable to load the file
system codec zipimport.ZipImportError: can't find
Steve Dower added the comment:
None of the code you linked is defined on Windows at all, so it can't be that.
Are any stat checks done when there's only a .pyc to import? Could it be
deciding that the .pyc is out of date and then failing to f
Steve Dower added the comment:
We need Ned's approval to fix anything in 3.6 now. Typically we do consider
build issues, and this one is fairly innocent (the affected code should only be
used on Windows, but the import may trigger elsewhere).
I'd be happy to take a patch to use lo
Steve Dower added the comment:
I think we're okay to increase the minimum version on the active branches.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I took a closer look at the diff since 3.7.1, and I'm not seeing anything
either. I suspect we need to step through zipimport/importlib and figure out
exactly where it rejects the .pyc files in th
Steve Dower added the comment:
Yes, we've established that zipimport is rejecting .pyc files now, but we need
to dig through it to figure out why. I haven't had time yet, but if someone
else can then don't wait for me.
--
___
Steve Dower added the comment:
That patch will break the case where the launcher *is* present, which is why it
was changed. If you're sure the launcher won't be present under Scripts/nt,
then that patch is okay. You'll probably need to add code to also copy
python37.dll and v
Steve Dower added the comment:
The installed venv seems to be okay, so I'm going to assume it's something
about your own build.
Now I realise I haven't ever tried virtualenv against 3.6 or later... no idea
what state that's in.
--
__
Steve Dower added the comment:
It should just build directly from venv[w]launcher.vcxproj, though you'll need
to rename venv[w]launcher.exe to python[w].exe (otherwise they'd conflict in
the build directory).
--
___
Python track
Steve Dower added the comment:
There's an existing issue for this somewhere - we've tried a couple times to
switch over and run into various issues. I'm not in a place to find it right
now, but worth looking.
--
___
Python
Steve Dower added the comment:
To be more clear, the fix is literally Python 3 and the str/bytes change.
You've discovered one of the reasons that was necessary.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I'd rather leave it specified as it is in PEP 11, though perhaps specifying it
explicitly in the release schedule PEPs would be helpful? Up to release
managers.
--
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
New changeset fbf50683b3a2301097d5cd48bc68b530c1e1720f by Steve Dower (Gregory
Szorc) in branch 'master':
bpo-35642: Remove asynciomodule.c from pythoncore.vcxproj (GH-11410)
https://github.com/python/cpython/commit/fbf50683b3a2301097d5cd48bc68b5
Steve Dower added the comment:
Looks like zipimport in 3.7 always rejected CHECKED_HASH pycs, while in 3.8 it
always accepts them (or runs it through a validation process that passes them
when the source file doesn't exist - I only confirmed by testing a build, not
by walking throug
Steve Dower added the comment:
And I assume now that the reason it broke in 3.7.2 is because the pyc mode for
the embeddable distro changed. Which means the right place for tests is in a
separate build that uses properly laid out Python rather than testing in the
source tree (like what I
Steve Dower added the comment:
New changeset e61cc481e02b758c8d8289163102c236d0658a55 by Steve Dower
(chrullrich) in branch 'master':
bpo-35374: Avoid trailing space in hhc file name if found on PATH. (GH-10849)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +10953, 10954
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue35596>
___
___
Py
Change by Steve Dower :
--
pull_requests: +10953
stage: test needed -> patch review
___
Python tracker
<https://bugs.python.org/issue35596>
___
___
Python-
2901 - 3000 of 5794 matches
Mail list logo
