Steve Dower added the comment:
The buildbots have already successfully built, so I'm declaring this and
issue30916 resolved.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http:
Steve Dower added the comment:
> use the preexisting convention of the HOST_PYTHON envvar that was used prior
> to the recent merged PRs
Is that an actual convention? I didn't see any other references, so I figured
Zach had
Steve Dower added the comment:
Hmm... looks like there's another way to fail I didn't account for that goes
down a different path in the batch file. I'll try being less clever.
--
___
Python tracker
<http://bugs.pyt
Changes by Steve Dower :
--
pull_requests: +2804
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
assignee: zach.ware -> steve.dower
resolution: fixed ->
stage: resolved -> commit review
status: closed -> open
___
Python tracker
<http://bugs.python
Steve Dower added the comment:
Yeouch, it's been causing AppVeyor builds to get stuck, and then they time out
after an hour.
Luckily mine is up next in a minute or so, so I'll try to merge quickly and
avoid anyone else getting held up.
I also restored HOST_PYTHON in the PR, as a fa
Steve Dower added the comment:
Ah, there's also a nuget.org outage affecting AppVeyor (but not me because I'm
in Italy and so connecting to the EU mirror automatically) -
https://appveyor.statuspage.io/
When that recovers it should be fine again. The workaround for those without
py
Steve Dower added the comment:
New changeset 5feda33a35d9413e2073411b848dc49d94c57497 by Steve Dower in branch
'master':
bpo-30450: Fix logic for retrying nuget.exe download (#2744)
https://github.com/python/cpython/commit/5feda33a35d9413e2073411b848dc4
Changes by Steve Dower :
--
pull_requests: +2809
___
Python tracker
<http://bugs.python.org/issue30540>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Zach - did this get backported to 2.7 or 3.5? It doesn't look like it.
--
stage: commit review -> backport needed
___
Python tracker
<http://bugs.python.org
Changes by Steve Dower :
--
pull_requests: +2810
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
pull_requests: -2809
___
Python tracker
<http://bugs.python.org/issue30540>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset e99d3a52a50b3f836fb9fb88f317aacddd494858 by Steve Dower in branch
'3.6':
[3.6] bpo-30450: Improved logic for obtaining dependencies (#2751)
https://github.com/python/cpython/commit/e99d3a52a50b3f836fb9fb88f317aa
Steve Dower added the comment:
I have a separate PR out that fixes this one, just waiting on Zach to review
(but since it only touches the more obscure release files, it's rare for anyone
but me to have an opinion).
The script is supposed to take the build path rather than the archite
Steve Dower added the comment:
The nuget package doesn't suffer from this - why not? Should you have been
using the full layout rather than the embedding layout?
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
That's the PR I meant (on phone today, so navigating gh is out). If you look
through history you'll see it's mostly a revert of a revert, at least for that
script.
--
___
Python tracker
<http
Steve Dower added the comment:
The "op_slot == 96" looks suspicious - how is this value actually supposed to
be calculated?
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
New changeset e7bc7aac3d4a7d92aa5913006b0198820882ca59 by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Fix a warning in Python/getargs.c (#2890)
https://github.com/python/cpython/commit/e7bc7aac3d4a7d92aa5913006b0198
Changes by Steve Dower :
--
pull_requests: -2894
___
Python tracker
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
That buildbot has recovered with other changes, so I'm closing this.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Steve Dower added the comment:
New changeset 679b566622ec811c5e5d580f6a538f7a43006e05 by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Fix some Windows x64 compiler warnings (#2492)
https://github.com/python/cpython/commit/679b566622ec811c5e5d580f6a538f
Steve Dower added the comment:
New changeset 5cff6379797967faabbb834a9eb154c3f0839489 by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Fixed _ssl module warnings (#2495)
https://github.com/python/cpython/commit/5cff6379797967faabbb834a9eb154
Steve Dower added the comment:
New changeset a80e985c493d2ab9df0832c99d9ddb798d2e66cf by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c (#2904)
https://github.com/python/cpyt
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30222>
___
___
Steve Dower added the comment:
Correct. This is already in newer installers.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
The embeddable ZIP is not an "install" - it's a tool for including in your own
application.
Run the actual installer and try again, or use the package on nuget.org if you
need to achieve zero system impact (which it sounds like you don't
Steve Dower added the comment:
Sounds like the right fix. We should increase the maximum path length though,
since 3.6 and later can work with much longer paths on Win10 through normal
APIs and without prefix.
--
___
Python tracker
<h
Steve Dower added the comment:
Please file separate bugs for each of your concerns, and ensure Python 3.6/3.7
and 2.7 are separate as these are fundamentally different installers and will
have different bugs.
Other versions will not be changed at this point.
--
resolution
Steve Dower added the comment:
Can you link to those guidelines please? Microsoft release plenty of software
with version numbers over 256.
Also, since people already rely on the current scheme, we'd need a very
compelling reason to break them. I don't believe you've mad
Steve Dower added the comment:
There's an existing bug for the registration going to the wrong place. It
requires changes to the Wix toolset to resolve. No need to conflate it with
this issue.
As far as I can tell, the problem here is just the version string displayed in
Program
Steve Dower added the comment:
This probably means that your system failed to install the C Runtime, but not
badly enough that it actually reported an error.
First try rebooting, and if that doesn't work then search for the VisualC++
2015 Redistributable installer and run
Steve Dower added the comment:
This issue is about A.
B has a separate issue. C will not be changed. Please don't bother bringing
them up again here, it's just a distraction.
--
components: +Installation
priority: normal -> low
type: behavior -> enhancement
versi
Changes by Steve Dower :
--
title: Windows Installer Product Version 3.6.2150.0 Offset By 0.0.150.0 ->
Windows Installer Product does not include micro version in display name
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
The prebuilt binaries have not, and the OpenSSL change has functional
implications and should not be (unless someone wants to make the security
justification, but right now I think it's a theoretical rather than an actual
benefit). The TclTk build could be
Steve Dower added the comment:
Looking at your log, you clearly have some sort of configuration blocking
installers or else corruption somewhere on your system. There really isn't
enough information available for me to be able to tell.
Perhaps you have a virus scanner running that is blo
Changes by Steve Dower :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue31148>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
Okay, if that's the way you want to go. Be aware that the old MSI code is gone
though, so rebuilding it will not be trivial. Though if you do, there are a few
people who would find it more convenient, so you may be able to enlist help
maintaining it (we d
Steve Dower added the comment:
Your final file layout needs to match any of our standard ones. On my phone now
so I'm not going to write them all out (will do it later if you need), but you
need to put your .exe in the same location as the python.exe for the runtime
you're using (o
Steve Dower added the comment:
It also breaks .zip file distribution, which I'm fairly sure we do explicitly
support by virtue of having "python36.zip" in sys.path by default. And the
".pyc-only in a zip file" distribution is *totally* busted :) (and also
offici
Steve Dower added the comment:
> when we changed installers was that when we also fixed the
> security/permissions problems with the install dir
Yes, but the permissions issue here isn't the install directory - it is
probably the TEMP directory or some other system restriction. It&
Steve Dower added the comment:
Perhaps the more important question is whether 2to3 really needs to dynamically
generate a list of fixers or if that should have been stopped due to YAGNI.
There are only a few modules in the stdlib, and it doesn't seem to support
proper namespace package
Steve Dower added the comment:
The general requirements of an installer are:
* runs without any preinstalled prerequisites
* does not install anything permanent until the user says so (Visual Studio
breaks this rule :( )
* installs all required prerequisites
* install on all supported operating
Steve Dower added the comment:
Yu Zhigang - can you post your install logs from the failed install? You'll
notice in my last message I said that I added some extra logging.
However, it sounds like you have a certain system option set that essentially
breaks paths passed between non-admi
Steve Dower added the comment:
This commit added *a lot* of warnings -
http://buildbot.python.org/all/builders/AMD64%20Windows10%203.x/builds/1056
Most are of the form:
warning C4133: 'function': incompatible types - from 'volatile uintptr_t *'
to 'volatile int
Steve Dower added the comment:
Burn bundles are part of Wix, but it's the part you don't like :)
If you just want a single MSI, you won't want a bundle. But you will have to
leave out nearly half of the features I listed because they simply are not
poss
Steve Dower added the comment:
We don't. Semicolons are not valid path characters, so you can't have them in a
single path (unless you're deliberately trying to break your entire machine...)
--
___
Python tracker
<http://bugs.pyt
Steve Dower added the comment:
There are no more binary installers for 3.5, so updating the target versions.
I have some ideas about how to do this and will hopefully get time at the dev
sprints to try them out.
--
stage: -> needs patch
type: -> behavior
versions: +Pyth
Steve Dower added the comment:
The idea interests me from a theoretical point of view, but then I did my PhD
in that field. I don't believe it's a practical solution, if only because you
would need to manually generate the result in order to validate before
releasing, and that&
Changes by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<http://bugs.python.org/issue31260>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset de50360ac2fec81dbf733f6c3c739b39a8822a39 by Steve Dower (Oren
Milman) in branch 'master':
bpo-29741: Update some methods in the _pyio module to also accept integer
types. Patch by Oren Milman. (#560)
https://github.com/python/cpyt
Changes by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29741>
___
Steve Dower added the comment:
util is a submodule of importlib, and so it should always be imported before
using it.
Other platforms may import it for various other reasons, but that is not part
of the API. You should fix it by typing (note that the first line is different
from yours
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue31172>
___
___
New submission from Steve Dower:
The newer MSVC (v141) is available and reliable, and theoretically binary
compatible with v140. This means we can update both Python 3.6 and 3.7 to build
with it.
Testing for this should include:
* pythoncore with v141 and remainder with v140
* Python with
Changes by Steve Dower :
--
pull_requests: +3339
___
Python tracker
<http://bugs.python.org/issue31340>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
You're right, though I disagree with the fix as that would cause the process
filename to be ignored.
A correct fix would check whether the name has been set explicitly and if so,
either use it as-is (if absolute) or get the actual name and use its dire
Steve Dower added the comment:
People are working on PEP 432 this week at the sprints, so yeah, it's likely.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
New changeset 5fcd5e64eec9ed67613b8fe7356fb8288151ceba by Steve Dower in branch
'master':
bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017)
(#3311)
https://github.com/python/cpython/commit/5fcd5e64eec9ed67613b8fe7356fb8
Changes by Steve Dower :
--
pull_requests: +3393
___
Python tracker
<http://bugs.python.org/issue31340>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
stage: needs patch -> backport needed
___
Python tracker
<http://bugs.python.org/issue31340>
___
___
Python-bugs-list mai
Steve Dower added the comment:
New changeset fd645ec6f5696e841e6d49075f9fd81e54e74d91 by Steve Dower in branch
'3.6':
[3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio
2017) (GH-3311) (#3386)
https://github.com/python/cpyt
Steve Dower added the comment:
Note that this should not change anything for 3.6, but enables using VS 2017 to
build. If you only have VS 2015 then it will use that, and I've enabled
AppVeyor for both to make sure we keep it that way.
3.7 will also build with either, but there isn'
Steve Dower added the comment:
I already have a fix in a pending PR for this. Don't have the number handy, but
will link it later today.
--
assignee: -> steve.dower
stage: -> patch review
type: -> compile error
___
Python
Steve Dower added the comment:
New changeset 05f01d85257d0f3409c7335aaf0bf6a6da7eecb7 by Steve Dower in branch
'master':
bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler (#1632)
https://github.com/python/cpython/commit/05f01d85257d0f3409c7335aaf0bf6
Changes by Steve Dower :
--
pull_requests: +3422
___
Python tracker
<https://bugs.python.org/issue30389>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 76006f285a7e146484d9296597d1d0ace778f992 by Steve Dower in branch
'3.6':
[3.6] bpo-30389 Adds detection of VS 2017 to distutils._msvccompiler GH-1632
(#3425)
https://github.com/python/cpython/commit/76006f285a7e146484d9296597d1d0
Changes by Steve Dower :
--
keywords: +patch
pull_requests: +3448
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31392>
___
___
Py
New submission from Steve Dower:
As per usual
--
assignee: christian.heimes
components: SSL, Windows, macOS
messages: 301673
nosy: christian.heimes, ned.deily, paul.moore, ronaldoussoren, steve.dower,
tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Upgrade
New submission from Steve Dower:
Because we wait so long between errors occurring and being reported,
information about the Windows error code (WSAGetLastError) has already been
lost.
We should capture all the info sooner.
--
assignee: steve.dower
components: SSL
messages: 301733
Changes by Steve Dower :
--
keywords: +patch
pull_requests: +3455
___
Python tracker
<https://bugs.python.org/issue31400>
___
___
Python-bugs-list mailin
Changes by Steve Dower :
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org/issue31400>
___
___
Python-bugs-list mai
Steve Dower added the comment:
New changeset b84bcc48ae31c385fe480c08c05d95212ef7fcdc by Steve Dower in branch
'master':
bpo-31392: Update SSL build for 1.1.0 (#3448)
https://github.com/python/cpython/commit/b84bcc48ae31c385fe480c08c05d95
Steve Dower added the comment:
I fixed the ref leak during the sprints but forgot to tag this issue in the PR.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
This is by design. You should not be using the ._pth file for anything other
than initializing sys.path.
If you want to run code at startup, consider using sitecustomize.py or a
regular .pth file, all of which will be imported when you include "import site
Steve Dower added the comment:
This is a problem with 3.5 and later running on Windows 8.1 or earlier without
all Windows Updates being installed.
It can happen for two reasons:
* not using the official installer (most common)
* random failure in the official installer (rare)
Installing
Steve Dower added the comment:
I don't have time right this second to write it all up, but I did so in the
past at https://docs.python.org/3/using/windows.html#finding-modules
Hopefully the answer you need is somewhere in that. Module search paths are
complicated (but eric.snow is goi
New submission from Steve Dower:
This is basically a note to myself to go and fix these things when I have time
(before 3.7a2):
* split upload steps so we can fail on real failures
* fail immediately if gpg2 step fails
* purge and retry if download fails
--
assignee: steve.dower
Steve Dower added the comment:
Also:
* build releases to versioned subdirectories of Py_IntDir when it is set
--
___
Python tracker
<https://bugs.python.org/issue31
Steve Dower added the comment:
You're right, we're missing this section of code:
if (PyOS_InputHook != NULL)
(void)(PyOS_InputHook)();
Since we just call it and ignore anything it does, it should be safe enough to
add it immediately before the ReadConsoleW call (
Steve Dower added the comment:
(Belongs inside Parser/myreadline.c in the _PyOS_WindowsConsoleReadline
function)
--
___
Python tracker
<https://bugs.python.org/issue31
Steve Dower added the comment:
If you look in your %TEMP% directory, there should be more log files near the
one you attached (most of the filename will be the same).
Could you zip them up and attach all of them here? I think there's some
information in one of the others that I'll n
Steve Dower added the comment:
AFAICT, the best logic is this:
if os.path.normcase(os.getcwd()) == os.path.normcase(sys.prefix):
os.chdir(get_default_location(sys.platform))
The only complexity is likely to be that "Documents" is localized on Windows,
and SHGetFolderPathW [1
Steve Dower added the comment:
New changeset c8fe9ccf7bfbcf9a2cb48e3b6abacf6ec0e5e58d by Steve Dower (Brendan
Gerrity) in branch 'master':
bpo-34532: Fixed exit code for py.exe list versions arg (GH-9039)
https://github.com/python/cpython/commit/c8fe9ccf7bfbcf9a2cb48e3b6abacf
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
For people watching the bug, this is ready for review.
Most of the change is adding a "layout" script (roughly the equivalent of "make
install" for Windows, but with more flexibility to generate different
structures, precompile stuff, e
New submission from Steve Dower :
Importing http.server triggers mimetypes.init(), which can be fairly expensive
on Windows (and potentially other platforms?) due to having to enumerate a lot
of registry keys.
Instead, SimpleHTTPRequestHandler.extensions_map can be a dict with just its
Steve Dower added the comment:
You're welcome to it - I deliberately left it for someone else to work on,
though I'm happy to review and merge.
The visible change of making this lazy is that if someone reads from the dict,
it'll be missing system-specified content types (
Change by Steve Dower :
--
pull_requests: +9932
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I'm going to declare that this is a bug in distutils not correctly setting
INCLUDE and LIB values when building in a source directory. When this is fixed,
there will be no need to copy pyconfig.h anywhere, and the installer build will
be fine.
(And it s
Steve Dower added the comment:
Thanks for the ping (I don't see GitHub notifications - I get 1000s per day and
it's not feasible to read them).
I left one more comment on the PR, but then it's good to go!
--
___
Python
Steve Dower added the comment:
Could we have used function overloading to handle the different types? Rather
than reintroducing the macro for the sake of the cast?
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
If anyone would like to try this out early, here's some instructions for a
build I just made.
Enable sideloading apps on your machine (see
https://docs.microsoft.com/en-us/windows/uwp/get-started/enable-your-device-for-development
- may already be
Steve Dower added the comment:
Ah, you're right, it's only C++. My bad.
--
___
Python tracker
<https://bugs.python.org/issue35059>
___
___
Python-b
Steve Dower added the comment:
For my own reference, some issues I found installing this package on a clean
machine:
* requires Developer Mode (until I get the sccd file signed - just sideloading
is not sufficient)
* requires vcruntime140.dll to be included in the package (workaround is to
Steve Dower added the comment:
For my own reference, some issues I found installing this package on a clean
machine:
* requires Developer Mode (until I get the sccd file signed - just sideloading
is not sufficient)
* requires vcruntime140.dll to be included in the package (workaround is to
Change by Steve Dower :
--
Removed message: https://bugs.python.org/msg330453
___
Python tracker
<https://bugs.python.org/issue34977>
___
___
Python-bugs-list m
Steve Dower added the comment:
Yep, good catch. That should be EXTERNALS_DIR in PCbuild/find_python.bat.
--
components: +Windows
keywords: +easy
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
versions: +Python 3.6, Python 3.7
___
Python
Steve Dower added the comment:
Updated testing instructions - this one should work with just sideloading
permissions I think.
iwr
"https://dev.azure.com/Python/8e426817-76c0-4b99-ba9e-a48a1e4bd5db/_apis/build/builds/34760/artifacts?artifactName=appx&api-version=5.0-preview.5&
Steve Dower added the comment:
Looks good to me. I can't apply tags from my phone, apparently, so someone else
will have to merge and mark the backport versions.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset 468a15aaf9206448a744fc5eab3fc21f51966aad by Steve Dower in branch
'master':
bpo-34977: Add Windows App Store package (GH-10245)
https://github.com/python/cpython/commit/468a15aaf9206448a744fc5eab3fc2
2801 - 2900 of 5794 matches
Mail list logo
