Change by Steve Dower :
--
keywords: +patch
pull_requests: +14886
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15150
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
> recommend we change "install launcher" to "install py launcher" to be
> explicit.
To be clear, you mean we change "Install launcher for all users" to "Install py
launcher for all users"? You get the launcher b
Steve Dower added the comment:
Duplicate of issue28576
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Uninstalling Py352 x86 with /uninstall option does not remove
prepended paths
___
Python tra
Steve Dower added the comment:
I have nothing to contribute here. Tim's right.
(I would love Python to have infinite precision float by default...)
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Only half serious ;)
I'd settle for "reliable, consistent and easy to explain rounding", which is
unfortunately not what IEEE 754 provides (unless you assume significant amounts
of CS background that most Python users do not have). But the
Steve Dower added the comment:
New changeset 1fab9cbfbaf19a7bc79cef382136fcf9491e3183 by Steve Dower in branch
'master':
bpo-37734: Fix use of registry values to launch Python from Microsoft Store app
(GH-15146)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 87ce9588ceb4b4dd625913344844390f0b991b0c by Steve Dower in branch
'master':
bpo-37778: Fixes the icons used for file associations to the Microsoft Store
package (GH-15150)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +14897
pull_request: https://github.com/python/cpython/pull/15165
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 0378d98678f3617fd44d9a6266e7c17ebce62755 by Steve Dower in branch
'master':
bpo-37734: Remove unnecessary brace escapes in PC/layout script (GH-15165)
https://github.com/python/cpython/commit/0378d98678f3617fd44d9a6266e7c1
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Going to leave this open in commit review for now. I believe this will
significantly improve the reliability, but depending on which Windows bugs
people run into there may still be more things we can do.
--
stage: patch review -> commit rev
Steve Dower added the comment:
There's no difference in the implementation between them, so unless you see
that the command line approach works but the GUI does not, they are going to be
exactly the same bug (and probably against either Windows or Wix, rather than
CPython, but I haven&
Steve Dower added the comment:
> The alternative would be, if there was a "Windows-specific tests" test
> module, we could have put a test for this situation in there
Maybe test___all__?
--
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
Or better yet (since my last suggestion was bad), add a second test class to
test_crypt
try:
import crypt
IMPORT_ERROR = None
except ImportError as ex:
crypt = None
IMPORT_ERROR = str(ex)
@skipIf(crypt)
class TestWhyCryptDidNotImport(TestCase
Steve Dower added the comment:
Yes. support.import_module is going to raise a skip when the module can't be
imported, but we want to handle ImportError differently.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Sure. You can post a new PR with the same bug number (and it won't need a NEWS
file this time).
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset ed70a344b5fbddea85726ebc1964ee0cfdef9c40 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181)
https://github.com/python/cpython/commit/ed70a344b5fbddea85726ebc1964ee
Steve Dower added the comment:
Guessing it needs an extra header file that is implicitly included in the
Windows headers?
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
I can't see anything specific in that log file, but if you can provide the
"Python 3.7.4 (32-bit)_20190804181255_000_core_JustForMe.log" file, that should
be able to help.
(For others who may have to triage these in the future, the main thing
Steve Dower added the comment:
Here's an example of someone hitting this issue:
https://stackoverflow.com/q/56974927
--
___
Python tracker
<https://bugs.python.org/is
Change by Steve Dower :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue32912>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Steve Dower :
The IO_REPARSE_TAG_APPEXECLINK was introduced for aliases to installed UWP apps
that require activation before they can be executed.
Currently these are in an unusual place as far as Python support goes - stat()
fails where lstat() succeeds, but the lstat
Change by Steve Dower :
--
nosy: +eryksun
___
Python tracker
<https://bugs.python.org/issue37834>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14955
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15231
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 732775d6be8062e72cf4995d5a9db0170e22c233 by Steve Dower (Derek
Keeler) in branch 'master':
bpo-37354: Make Powershell Activate.ps1 script static to allow for signing
(GH-14967)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +14958
pull_request: https://github.com/python/cpython/pull/15235
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 0c64b57e0155c333b7c96ec2af009c1388cd5d31 by Steve Dower (Miss
Islington (bot)) in branch '3.8':
[3.8] bpo-37354: Make Powershell Activate.ps1 script static to allow for
signing (GH-14967)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 3e34a25a7a5c9ea2c46f2daeeb60f072faa5aaa1 by Steve Dower in branch
'master':
bpo-37354: Sign Activate.ps1 for release (GH-15235)
https://github.com/python/cpython/commit/3e34a25a7a5c9ea2c46f2daeeb60f0
Steve Dower added the comment:
Thanks, Derek!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Added an update with a new stat field (st_reparse_tag) so that we can tell them
apart, which also means I can add a test for readlink.
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
Thanks Eryk for your valuable response :)
> readlink() and is_link() should be reserved for POSIX symlinks, i.e. only
> IO_REPARSE_TAG_SYMLINK.
I'm okay with that reasoning. Honestly, the only real problem I've seen is in
applica
Steve Dower added the comment:
I just updated to the latest 3.6 commit and listobject.c doesn't even use
clinic in this branch.
Serhiy is probably right - this is a workspace issue.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
We recently tried switching the GIL implementation on Windows by changing the
setting you refer to. It didn't work, so we didn't keep the change, but I don't
recall the details - likely the same issue you bring up here.
I don't have the othe
New submission from Steve Dower:
Due to how installation of Visual Studio 2017 has changed, it's very possible
to end up with a valid install of the build tools without vcvarsall.bat being
valid.
We only require MSBuild.exe to build, so we should find that tool and invoke
it, rather
Changes by Steve Dower :
--
pull_requests: +2302
___
Python tracker
<http://bugs.python.org/issue30687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 40a23e88994aca92c83c8e84ab8b8cdc11d7ec54 by Steve Dower in branch
'master':
bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on
vcvarsall.bat (#2252)
https://github.com/python/cpyt
Changes by Steve Dower :
--
pull_requests: +2329
___
Python tracker
<http://bugs.python.org/issue30687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
pull_requests: +2330
___
Python tracker
<http://bugs.python.org/issue30687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 06d6e3d0bb5b8a3d3105289034953a8014356a0b by Steve Dower in branch
'3.6':
bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on
vcvarsall.bat (#2252) (#2280)
https://github.com/python/cpyt
Steve Dower added the comment:
Zach, I just spotted this build log, that appears to have failed to download
nuget.exe:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.6/builds/339/steps/compile/logs/stdio
Guessing the bot is only succeeding because it currently has all the
Steve Dower added the comment:
New changeset 2c899ccffda92a7f3d4e7a01f14a666504db07b5 by Steve Dower in branch
'3.5':
bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on
vcvarsall.bat (#2252) (#2281)
https://github.com/python/cpyt
Steve Dower added the comment:
Ned - this has been merged into 3.6 branch and the buildbots look good.
Feel free to move the NEWS item around and/or cherrypick into 3.6.2 at your
leisure.
--
nosy: +ned.deily
___
Python tracker
<h
Changes by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
To clarify (because I never trust test output for this), your install has \n
line endings everywhere instead of \r\n?
--
___
Python tracker
<http://bugs.python.org/issue30
Steve Dower added the comment:
So the pickle issues were because the .gitattributes file changed multiple
times since the last release but the files were not modified, so git did not
fix them in my build repo. This should cover random and 2to3.
Most of the stdlib is correct CRLF.
XML should
Changes by Steve Dower :
--
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org/issue30716>
___
___
Python-bugs-list mailing list
Un
Steve Dower added the comment:
For the next build, test_codecencodings_iso2022, test_random, test_sax and
test_tools should all pass, as the .gitattributes file excludes those files
from conversion. I'm still in favour of hardening the tests.
test_pcbuild_rc should be skipped. I don&#x
Changes by Steve Dower :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue30716>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I wonder if the custom action to run _ensurepip isn't running as admin... that
would be the only thing I can think of.
Can you try running the installer with:
msiexec /l*vx log.txt /i path_to.msi
Then attach the generated log.txt file? We might be able t
Steve Dower added the comment:
What is the impact of this error? I know of people who are relying on the
manifest who have not raised any issue, so perhaps it isn't actually that
important?
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
The relevant lines are just above the ones you posted, but I can't view the
attachment from my phone so I'll have to look later.
Seems like the custom action is running as the original user and not admin.
This should just be a flag on the command, th
Steve Dower added the comment:
You're going to get build failures without the C++ tooling anyway, and msbuild
should find previous installs that are compatible.
What is your system setup that causes this failure when you expect su
Steve Dower added the comment:
I suspect that should be filed as a bug against VS 2017 - I'll do that when I
get to work on Monday.
Our workaround should be to check for that targets file and keep searching if
it's not found.
Your best workaround is to start the build from t
Steve Dower added the comment:
Unless you've got an example of this causing actual issues, it should only go
into 3.7.
All platforms supported by Windows guarantee atomicity for aligned,
pointer-sized reads and writes, but there appear to be memory fencing semantics
in here too. I
Steve Dower added the comment:
> Would there be any interest of implementing them for MSVC/ARM as well
Sure, since you're there. It's not easy to test, but I know people who are
doing it, so it'll get noticed eventually.
Maybe there's some sort of stress test we can
Steve Dower added the comment:
The bug is MSBuild 15.0 should be able to locate earlier versions of VC, even
if you haven't installed it for VS 2017.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
There are *many* more fixes required than just these. We're not prepared to
take the changes into 2.7 at this stage, and we don't want to encourage people
to think that MSVC 14.0 or later are supported when we know that it's
incomplete.
I'
Steve Dower added the comment:
We tried it at one point, but it made very little difference because we don't
use the Windows heap for most allocations. IIRC, replacing Python's optimised
allocator with the LFH was a slight performance regression, but I'm not sure
the benchmark
Steve Dower added the comment:
New changeset 5b8f972e093157cc55185841db9ad33fa332a641 by Steve Dower (Steve
(Gadget) Barnes) in branch 'master':
bpo-30362 : Add list options to launcher. (#1578)
https://github.com/python/cpython/commit/5b8f972e093157cc55185841db9ad3
Steve Dower added the comment:
New changeset 5b8f972e093157cc55185841db9ad33fa332a641 by Steve Dower (Steve
(Gadget) Barnes) in branch 'master':
bpo-30362 : Add list options to launcher. (#1578)
https://github.com/python/cpython/commit/5b8f972e093157cc55185841db9ad3
Steve Dower added the comment:
Thanks, Steve!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
New changeset 9f3bdcb643623e07497af2fc35f0496c2302f1be by Steve Dower (Segev
Finer) in branch 'master':
bpo-23451: Fix socket deprecation warnings in socketmodule.c (#2318)
https://github.com/python/cpython/commit/9f3bdcb643623e07497af2fc35f049
Steve Dower added the comment:
There is only one deprecation warning left in current builds:
..\Modules\expat\xmlparse.c(796): warning C4996: 'getenv': This function or
variable may be unsafe. Consider using _dupenv_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS.
Steve Dower added the comment:
New changeset 7526cadd64566725ffc56071a7208828a46ddbd8 by Steve Dower (Segev
Finer) in branch 'master':
bpo-30726: Also fix pyexpat.vcxproj (#2375)
https://github.com/python/cpython/commit/7526cadd64566725ffc56071a72088
Steve Dower added the comment:
How far back does it need to be ported? Just to 3.5?
--
stage: -> backport needed
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
It doesn't even fix a warning - only suppresses it. Since there is no behavior
change at all, I'm not inclined to backport any further than is trivial.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
It's certainly exploitable for remote code execution if user data allows
embedded nulls (can you URL encode %00?). The fixes look fine and shouldn't
cause any new issues, though I thought that fsencode() already rejected
embedded nulls - maybe I
Steve Dower added the comment:
There's nothing that needs to block the release as far as I'm concerned. The
main fix was that I needed a fresh clone on my build machine to pick up the
gitattribute changes.
The other bug is still open to enhance some tests and skip one in the rel
Steve Dower added the comment:
I wouldn't be opposed to seeing it tried again, but I have no strong opinion. I
don't think this is a major performance bottleneck right now.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
> I like decreasing the number of warnings. It helps to detect new warnings,
> and so to prevent bugs.
The approach used to suppress this warning will also suppress other warnings
that might be fixable. Hard to say it's definitely a good thing i
Steve Dower added the comment:
I hope you notice I'm not against this particular change. I'm just voicing a
general belief that suppressing an entire category of warnings for a whole
project is not necessarily an improvement.
In future, and when applied to our own project files, ex
Steve Dower added the comment:
Arguably it isn't even against the documented behavior, since a component
starting with a slash an absolute path.
I'd be in favor of preserving the drive when encountering a component starting
with a separator. Not sure of the value in changing the b
Steve Dower added the comment:
> since a component starting with a slash *is not* an absolute path.
--
___
Python tracker
<http://bugs.python.org/issu
New submission from Steve Dower:
To save time and improve reliability while building CPython, we should
pre-build and sign OpenSSL and Tcl/Tk binaries and make it a binary dependency.
Our slightly-patched sources will still be available, and it will be relatively
easy for people to download
Changes by Steve Dower :
--
pull_requests: +2753
___
Python tracker
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30251>
___
___
Steve Dower added the comment:
@Zach - FYI, this will make it unnecessary to run prepare_ssl.bat when checking
in updated sources. Rather, this script now requires Perl to do the entire
build, so we don't have to have any difference between our source bundle and
the original OpenSS
Steve Dower added the comment:
Sure, but then I'll resolve it as rejected :)
The solution does not need an install target. That's not the point - we have
separate projects and scripts for that.
--
___
Python tracker
<http://bu
Steve Dower added the comment:
There's absolutely no risk of ignoring later parameters or raising a ValueError
here, so please don't let those cloud the discussion.
The behaviour of Python 3.6 seems to be correct for every case except:
>>> os.path.join("C:\\dir
Steve Dower added the comment:
New changeset c40ad03bf2693b4af539978f1274e57b85367547 by Steve Dower (Segev
Finer) in branch 'master':
bpo-30731: python.manifest fix (#2328)
https://github.com/python/cpython/commit/c40ad03bf2693b4af539978f1274e5
Changes by Steve Dower :
--
pull_requests: +2765
___
Python tracker
<http://bugs.python.org/issue30731>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset d8e522f7cf8d59993acae9409b6af0ee9a35038f by Steve Dower in branch
'3.6':
bpo-30731: python.manifest fix (#2328) (#2699)
https://github.com/python/cpython/commit/d8e522f7cf8d59993acae9409b6af0
Changes by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.7
___
Python tracker
<http://bugs.python
Steve Dower added the comment:
Fair point. I was thinking of how chdir handles it, but of course that's
relative to the cwd on D, so the rest of the path on C is ignored. D:dir2 is
correct.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
Zach opted out of reviewing right now, so I went ahead and pushed my builds to
the GitHub repos so that AppVeyor can run.
It built and ran fine (which I'm not surprised about), but it was only 1-2
minutes faster on AppVeyor (which I _am_ surprised about).
Steve Dower added the comment:
New changeset 68d663cf85d1ac5eaf83482eed39c0a6f8093601 by Steve Dower in branch
'master':
[bpo-30916] Pre-build OpenSSL and Tcl/Tk for Windows (#2688)
https://github.com/python/cpython/commit/68d663cf85d1ac5eaf83482eed39c0
Steve Dower added the comment:
The buildbot failures currently being blamed on issue30916 are actually due to
this issue - we actually need Python 3.6 on these machines in order to download
the new externals, and they don't have it and we can't get it via
Steve Dower added the comment:
The buildbot failure blamed on this issue is actually due to issue30450 - it's
the first time we've added a new external, and so the inability to download
Python via Powershell on Windows 7 is the problem
Changes by Steve Dower :
--
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Steve Dower :
--
pull_requests: +2797
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
My PR adds a small script to use requests.get/urlretrieve with any version of
Python to get nuget.exe.
Theoretically, we *could* use this to download everything, but I'd rather
minimize our exposure to insecure downloads for machines that don't alr
Steve Dower added the comment:
The best response is to notify Bitdefender so they can fix their signatures.
Python is commonly used in malware, and so some parts of it are often
misidentified as unique to some detected virus. By reporting the name of the
virus and providing the actual file to
Steve Dower added the comment:
New changeset 588836d3e646c2bcb3473cda7c5f6a1e0ff2c2e9 by Steve Dower in branch
'master':
bpo-30450: Adds alternate download approach for nuget.exe (#2737)
https://github.com/python/cpython/commit/588836d3e646c2bcb3473cda7c5f6a
Steve Dower added the comment:
Compilation still fails, as some of the buildbots don't have py.exe either.
At this stage, our choices are either to fix the buildbots, most easily by
copying py.exe into PATH, or to check nuget.exe (4MB) into the source
repository. (I guess we can cover
Steve Dower added the comment:
We can't assume git.exe is available either (build from sdist/hggit/.zip),
though I guess we can also use it as a fallback. At least on the buildbots
it'll be there.
--
___
Python tracker
<http://bu
Steve Dower added the comment:
> we used to mandate the presence of a svn install
And we regretted that so much that we changed away from it :)
When discussing this changeover plan, Zach and I decided we needed a fallback
requiring only OS dependencies. In this case, the Powershell depende
Steve Dower added the comment:
> How do you get CPython source code if git is not available?
Go to GitHub and click the "Download" button, or select any sdist from our
downloads page, or use Mercurial+hggit, or Dulwich directly, or a mirror/fork
on any VCS you like. There are p
Changes by Steve Dower :
--
pull_requests: +2799
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Unfortunately, "install " is often a blocking requirement for many
developers (typically the ones who get paid well to do this), so I'd rather
have no requirements.
Currently we achieve this if PowerShell is up to date or Python+py.exe are
ins
Steve Dower added the comment:
New changeset efa26bcd5085279fc4e9ae96d052272a5214c2bd by Steve Dower in branch
'master':
bpo-30450: Fall back to git.exe if no Python is found. (#2739)
https://github.com/python/cpython/commit/efa26bcd5085279fc4e9ae96d05227
2701 - 2800 of 5794 matches
Mail list logo
