Steve Dower added the comment:
New changeset 7a430109b983806c57babf229c60d0245d0b541c by Steve Dower (Miss
Islington (bot)) in branch '3.8':
bpo-37590: Remove redundant docs of PyEval_EvalFrameEx (GH-14765)
https://github.com/python/cpython/commit/7a430109b983806c57babf229c60d0
Steve Dower added the comment:
The commit to master succeeded, but we missed the bpo number in the message,
which is why it didn't appear here.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
> Steve, there is a problem in both lines of this suggestion.
The only problem is that you ran from your own build. Once running from an
installed layout (which you can now easily generate with `python.bat PC\layout
--preset-default --copy `), the compari
Steve Dower added the comment:
> NameError: name 'get_default_location' is not defined
Also, this was a hypothetical function that you would implement in IDLE to
determine whatever the default location ought to be. I'm personally happy to
stay out of that pa
Steve Dower added the comment:
Guess we need a real Sphinx expert to help out here.
Somehow we need to get explicit backlinks, but I couldn't figure out how to
resolve them normally through an extension. If we can do that, this will
probably go
Steve Dower added the comment:
Marco has a newer patch with better performance that we came up with at the
sprints, but apparently it hasn't been pushed yet. Hopefully he'll get that up
soon and we can review it instead - the current PR wasn't as reliably good as
initial te
Steve Dower added the comment:
Yep, thanks for the ping!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Can we have a newer bundled version of pip for 3.8/3.9?
In particular, I'd really like to be able to use the new location for a pip.ini
inside of sys.prefix, as it will fix the problems with "python3 -m pip" on
Windows when obtained from th
Steve Dower added the comment:
Oh that's a nasty issue... but it sounds like you're reaching some kind of
agreement.
3.8b3 is scheduled for this week, so perhaps we can take the current release
for now and then update it when you make the next release?
(Also Pradyun, would you
Steve Dower added the comment:
Maybe we need to finally make shlex.split() at least be consistent with
list2cmdline() on Windows so it can round-trip, perhaps with a "windows=True"
parameter.
I don't think it's unreasonable to aim for round-tripability. That is
Steve Dower added the comment:
New changeset 5380def8269b24a8a3bc46396373a1dc91b1dd1a by Steve Dower (Pradyun
Gedam) in branch 'master':
bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934)
https://github.com/python/cpyt
Steve Dower added the comment:
Leaving this open until 3.8b4 in case we want to take another update.
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Steve Dower :
Currently we set PIP_USER environment variable in the pip.exe redirector, which
is not ideal. Now that we have the latest release of pip, we can use a pip.ini
file to set the option by default.
--
assignee: steve.dower
components: Windows
messages
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14711
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14939
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 123536fdab7b8def15c859aa70232bc55ec73096 by Steve Dower in branch
'master':
bpo-37672: Switch Windows Store package to use pip.ini for user mode (GH-14939)
https://github.com/python/cpython/commit/123536fdab7b8def15c859aa70232b
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Guessing this is a new warning in pip?
Can we just disable the cache explicitly for these tests? Or should we
reconfigure the buildbot to suppress the warning.
--
nosy: +Marcus.Smith, dstufft, ncoghlan, paul.moore, pradyunsg, steve.dower
Steve Dower added the comment:
New changeset c4cda4369f4b8f33082890d16dfc364a90658ef6 by Steve Dower (Bill
Collins) in branch 'master':
bpo-37641 preserve relative file location in embeddable zip (GH-14884)
https://github.com/python/cpython/commit/c4cda4369f4b8f33082890d16dfc36
Steve Dower added the comment:
Could you please nosy yourself on the other issue and help us address it then?
The only change was upgrading pip, and the error is just a new warning message,
but unless someone knows how bad it is then we'll "fix" it by ignori
Steve Dower added the comment:
Actually, we're already ignoring this message, but now it includes "WARNING: "
at the start and doesn't match the existing regex. So we can just continue to
ignore it.
--
___
Python tracker
<
Change by Steve Dower :
--
pull_requests: +14728
pull_request: https://github.com/python/cpython/pull/14960
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset b1eb20e68e30c8ab128f9d63d622f0a8b49dcf34 by Steve Dower in branch
'master':
bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960)
https://github.com/python/cpython/commit/b1eb20e68e30c8ab128f9d63d622f0
Steve Dower added the comment:
Hey Ned, would you like a bundled pip update for 3.7? We haven't gone that far
back.
--
nosy: +ned.deily
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Resolved by issue37672 (because I didn't find this issue when I was looking for
it, so I created a new one)
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Switch Windows Store package to use pip.
Steve Dower added the comment:
This appears to be completely resolved now, but if it's not, please ping with
the details and we'll reopen.
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http
Steve Dower added the comment:
This code has been significantly rewritten since this bug, and I believe it's
no longer an issue.
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python t
Change by Steve Dower :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue34011>
___
___
Pyth
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14734
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14966
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I made a fake 3.8.0 installer and made the screenshot, so we'll only backport
it to 3.8. I think 3.7 is fine with what it has.
--
versions: +Python 3.8, Python 3.9 -Python 3.7
___
Python tracker
&
Steve Dower added the comment:
New changeset 9d9893a1c85e07f7369c848acb0aed3b8fe6c3af by Steve Dower in branch
'master':
bpo-35524: Update Windows installer image in docs (GH-14966)
https://github.com/python/cpython/commit/9d9893a1c85e07f7369c848acb0aed
Change by Steve Dower :
--
pull_requests: +14738
pull_request: https://github.com/python/cpython/pull/14969
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
New changeset 886e66d111b6b865e582d8cc7974d5c0b398da99 by Steve Dower in branch
'3.8':
bpo-35524: Update Windows installer image in docs (GH-14966)
https://github.com/python/cpython/commit/886e66d111b6b865e582d8cc7974d5
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 91e49575095ca16d1b67dd8822deeb7885e421da by Steve Dower (Derek
Keeler) in branch 'master':
bpo-32910: Remove implementation detail in venv documentation. (GH-14968)
https://github.com/python/cpython/commit/91e49575095ca16d1b67dd8822deeb
Steve Dower added the comment:
I just ran this on Windows and noticed that there is no data for _msi.pyd,
winsound.pyd or _sqlite3.pyd.
The first two don't matter - we should just suppress PGO on those projects to
avoid the warnings (add a false property). That's a
note to myse
Change by Steve Dower :
--
pull_requests: +14753
pull_request: https://github.com/python/cpython/pull/14985
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
I also added test_bz2 and test_lzma into the PGO profile, as the extension
modules for those on Windows were barely being covered (they get imported,
apparently, but that seems to be it).
--
___
Python tracker
Steve Dower added the comment:
> What matters there is compiling the underlying lzma, bz2, and sqlite3
> libraries with PGO. that isn't done as part of our build system.
On Windows they are linked in as source files, which is why it matters for us.
On platforms where we rel
Steve Dower added the comment:
Thanks for approving my PR, Greg!
--
___
Python tracker
<https://bugs.python.org/issue36044>
___
___
Python-bugs-list mailin
Steve Dower added the comment:
> What 3.7.3 does is to skip calling _Py_set_inheritable for all files of type
> FILE_TYPE_CHAR
It sounds like we should probably revert to the middle ground, and skip
_raising the error_ if _Py_set_inheritable for files of type FILE_TYPE_CHAR.
As
Steve Dower added the comment:
I just chatted with Derek about this, and while we identified some potential
regressions (previously we were injecting str(prompt) into Activate.ps1, and
now we're showing repr(prompt)), I don't think they're widely used.
For example, if you
Steve Dower added the comment:
While you're testing patches, can you try this version too?
Py_UCS4 c = 0, minc = 0x20;
for (next = end; next < len; next++) {
c = PyUnicode_READ(kind, buf, next);
if (c == '"' || c == '
Steve Dower added the comment:
Oh, we also need to capture "next"... but then again, since the success case is
far more common, I'd be okay with scanning again to find it.
--
___
Python tracker
<https://bugs.pyt
Change by Steve Dower :
--
stage: -> needs patch
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue36670>
___
___
Python-
Steve Dower added the comment:
> compiler stores the `c` to stack every time
The disassembly we looked at didn't do this, so it may just be certain
compilers. Perhaps we can actually use the register keyword to help them out? :)
Here's a slightly altered one that doesn't
New submission from Steve Dower :
The next update to Windows will prevent launching executables from within the
package install folder, and require you to launch from the user's local symlink
to the executable (see issue37369).
Currently, the only value we can put into the registry
Steve Dower added the comment:
So far we've figured out that using the full installed path will work fine (by
design) if you have enabled the matching alias. So essentially, if Python is on
your PATH, you can also launch it using the full path.
I'm trying to convince them that
New submission from Steve Dower :
We currently do not provide the standard access type constants anywhere,
despite providing some of the specific access type flags (e.g. in `winreg`):
#define DELETE (0x0001L)
#define READ_CONTROL (0x0002L
Steve Dower added the comment:
The "for all users" checkbox you refer to only applies to the launcher, which
is why it is immediately alongside the option to install the launcher (and
above the comment about the launcher).
The "Install for all users" option on the f
Change by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36680>
___
Change by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36683>
___
Change by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36678>
___
Change by Steve Dower :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36681>
___
Steve Dower added the comment:
Most of those examples would break today if run on Windows, though
(AttributeError). So they'd just continue to break, probably with a different
error (I'm not clear what happens if we specify SOCK_DGRAM with this change).
Having an undocumented fie
Steve Dower added the comment:
Thanks for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.8
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 8fbece135d7615e836a845ca39223097046c8b8b by Steve Dower (Greg
Bowser) in branch 'master':
bpo-36590: Add Bluetooth RFCOMM and support for Windows. (GH-12767)
https://github.com/python/cpython/commit/8fbece135d7615e836a845ca392230
Steve Dower added the comment:
Sorry for being slow to review, I just added a few more comments on the PR and
I think we're nearly done.
--
versions: +Python 3.9 -Python 3.6
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Sorry for the slow reply.
> immediately begin removing Python - no prompt will be displayed
This is meant to imply that no *confirmation* prompt will be displayed before
uninstall starts. Documentation patches are welcome :)
> tell me something about p
Steve Dower added the comment:
If we reduce our chunk size below INT_MAX, then we avoid the issue entirely.
Our logic for hitting the middle of a multibyte character is fine (perhaps
fixed since this issue was opened?), there's just a weird edge case at 2 GiB in
the API call.
As a
Change by Steve Dower :
--
assignee: -> steve.dower
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue36311>
___
___
Python-bugs-list mai
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14828
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/15083
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
This has been implemented.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.5
___
Python tracker
<https://bugs.python.org/issue20523>
___
___
Python-bug
Steve Dower added the comment:
New changeset 7ea9a85f132b32347fcbd2cbe1b553a2e9890b56 by Steve Dower (Timothy
Hopper) in branch 'master':
bpo-20523: pdb searches for .pdbrc in ~ instead of $HOME (GH-11847)
https://github.com/python/cpython/commit/7ea9a85f132b32347fcbd2cbe1b553
Change by Steve Dower :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Change by Steve Dower :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33779>
___
___
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue35058>
___
___
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue34562>
___
___
Change by Steve Dower :
--
assignee: steve.dower ->
stage: patch review -> backport needed
versions: -Python 3.6, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/i
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33617>
___
___
Pyth
Steve Dower added the comment:
I updated this section in a separate issue.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue34470>
___
___
Steve Dower added the comment:
New changeset 8e568ef266a2805f9a6042003723d9c050830461 by Steve Dower (Timo
Furrer) in branch 'master':
bpo-30974: Change os.path.samefile docstring to match docs (GH-7337)
https://github.com/python/cpython/commit/8e568ef266a2805f9a6042003723d9
Steve Dower added the comment:
I'm not personally thrilled about it being documented like this, but it's
certainly how the current documentation reads. Consistency is better until we
get motivated enough to fix all of it.
Thanks for the patch!
--
stage: patch review -
Steve Dower added the comment:
Still needs a 2.7 backport if someone would like to do it.
--
___
Python tracker
<https://bugs.python.org/issue30974>
___
___
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue31534>
___
___
Change by Steve Dower :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue34142>
___
___
Python-bugs-list mailing list
Unsub
Change by Steve Dower :
--
resolution: -> out of date
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/
Steve Dower added the comment:
Sorry about forgetting this - this is an issue with certain security
configurations where variables are not passed across the Administrator boundary
properly (and the subinstallers are automatically elevated to Administrator).
If you right click the installer
Change by Steve Dower :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33220>
___
___
Change by Steve Dower :
--
resolution: -> wont fix
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue31612>
___
___
Steve Dower added the comment:
Closing this as out of date, but if you're still watching Zero, make sure you
aren't browsing the __pycache__ directory instead of the source directories. We
definitely ship sources with all of our distributions.
--
resolution: -> out
Steve Dower added the comment:
Marking this easy/newcomer friendly.
This should catch the ModuleNotFoundError raised when _crypt is missing and
raise a more informative ImportError saying that crypt is unsupported.
All the other modules that are missing are native extension modules that are
Steve Dower added the comment:
> I think it's possible that there is code that detects whether AF_UNIX is an
> attribute on socket or not and does something different on Windows, but I
> haven't seen an example of it so far.
One of the test suites linked above had a
Steve Dower added the comment:
At least the first five can be used to open keys with even less rights than
default, which can sometimes be necessary for keys with obscure ACLs.
Having the constants present is also helpful when rendering a text view.
Perhaps _winapi is the best place? It
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
All I can add is these are the steps:
https://github.com/python/cpython/blob/master/.azure-pipelines/macos-steps.yml
The Linux steps use xvfb, but the macOS steps do not. And we don't do anything
at all to install Tcl/Tk on the build
Steve Dower added the comment:
Short of adding a popup into Python itself the first time you run it (and would
that include if you run "pip" first?), we don't have any ability to extend the
installer.
We could reduce the "local-packages/Python37/site-packages&
Steve Dower added the comment:
That sounds good to me, though you may want to propose the error message here
first so we can get the wording right - probably not everyone will be watching
github PR.
It probably makes sense to raise a different error message on platforms where
we do expect
Steve Dower added the comment:
It looks like the best solution here may be to rename the bundled executables
to "python3.8.exe" etc. rather than "python.exe".
We will still keep the "python.exe" alias, and sys.executable won't change
(it'll still p
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14882
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15146
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
`sys.platform` is the value that reflects how Python was compiled -
`sys.platform == 'win32'` means compiled for Windows. And since this issue is
related to compilation, it makes the most sense to use sys.
(`os.name` is also based on compilation, but
Steve Dower added the comment:
> Can I submit my PR now?
Sure, though if others want to weigh in on wording they should feel free to do
it here.
> I forgot to ask about tests? I see there is test_crypt.py under Lib\test. Do
> you have any thoughts on how to test this?
It should
New submission from Steve Dower :
No Logo element is specified in the FileTypeAssociation element, and so files
get a different icon from the regular installer.
See
https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/appxmanifestschema/element-1-logo
--
assignee: steve.dower
2601 - 2700 of 5794 matches
Mail list logo
