Steve Dower added the comment:
> With this fixed, and the PyCode_New -> PyCode_New + PyCode_WithPosArgs fix
> from bpo-37221 merged, then that long tail will get another few years of
> life, and will start emitting deprecation warnings for the part that's
> actually
Steve Dower added the comment:
Thanks! Well spotted.
--
___
Python tracker
<https://bugs.python.org/issue37316>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
New changeset 08286d52b29de604a4b187bf1f0d4209e39c926c by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152)
https://github.com/python/cpyt
New submission from Steve Dower :
We should also (see whether we should) add audit hooks for the following
modules:
* configparser
* crypt
* ensurepip
* ftplib
* glob
* http
* imaplib
* nntplib
* pdb
* poplib
* runpy
* shutil
* smtpd
* smtplib
* socketserver
* sqlite3
* telnetlib
* webbrowser
New submission from Steve Dower :
Since .pth files may contain executable code, we should open them using
io.open_code().
--
messages: 346230
nosy: christian.heimes, steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
title: Use io.open_code for .pth files
Change by Steve Dower :
--
pull_requests: +14112
pull_request: https://github.com/python/cpython/pull/14289
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset f8dd77d36067fd7be614edde1e5e9e7467c450dc by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Fix -u parameters for ARM32 tests (GH-14280)
https://github.com/python/cpython/commit/f8dd77d36067fd7be614edde1e5e9e
Steve Dower added the comment:
New changeset 6c7947713a40851e123493ca0fe8f2791d7ed2a6 by Steve Dower in branch
'3.8':
bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152)
https://github.com/python/cpython/commit/6c7947713a40851e123493ca0fe8f2
Change by Steve Dower :
--
pull_requests: +14113
pull_request: https://github.com/python/cpython/pull/14290
___
Python tracker
<https://bugs.python.org/issue36
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset f5690925df897cf45818bf944b28d13f37b9f8ca by Steve Dower in branch
'master':
bpo-37351: Removes libpython38.a from standard Windows distribution (#14276)
https://github.com/python/cpython/commit/f5690925df897cf45818bf944b28d1
Change by Steve Dower :
--
pull_requests: +14122
pull_request: https://github.com/python/cpython/pull/14298
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset f3e38ec7f014557296f6cc7b60a33d65faad1716 by Steve Dower in branch
'3.8':
bpo-36511: Fix -u parameters for ARM32 tests (GH-14280)
https://github.com/python/cpython/commit/f3e38ec7f014557296f6cc7b60a33d
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue37364>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14123
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14299
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14125
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14301
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset fa23bd286fb7719bd7601da0b713457589f5536f by Steve Dower in branch
'3.8':
bpo-37351: Removes libpython38.a from standard Windows distribution (GH-14276)
https://github.com/python/cpython/commit/fa23bd286fb7719bd7601da0b71345
Steve Dower added the comment:
PR 14301 has at least a few hooks for most of the modules above.
I think xmlrpc deserves some, but it is not as immediately obvious where to put
them as for the other modules. smtpd also still needs looking at
Steve Dower added the comment:
> Also, just one question: how could python -m pip work but not pip? What are
> the differences in them?
To answer this, "pip" on its own is essentially like writing the full path to a
specific python.exe and passing "-m pip". If th
Steve Dower added the comment:
New changeset 60419a7e96577cf783b3b45bf3984f9fb0d7ddff by Steve Dower in branch
'master':
bpo-37363: Add audit events for a range of modules (GH-14301)
https://github.com/python/cpython/commit/60419a7e96577cf783b3b45bf3984f
New submission from Steve Dower :
All audit events are marked in the docs with the ".. audit-event::
" syntax.
We should automatically collate these into a single table and generate a new
doc page as part of docs build.
--
assignee: docs@python
components: Documentatio
Steve Dower added the comment:
FWIW, I tried looking into how we can prevent or detect monkeypatching of
"sys.audit", and the answer seems to be that we need to define a custom type
for the sys module and for sys.__dict__.
I'm not prepared to do that yet, and IMHO there ar
Steve Dower added the comment:
Fixing --compiler=mingw32 is left for another bug, if anyone is so motivated.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Awesome! I was just making a start on this too, and it looks like we were doing
nearly identical work. Happy to let you keep going on it!
Some things that I thought would be worth doing:
* combine equivalent events (warn if names match but arguments are
Steve Dower added the comment:
I took your code and made some improvements:
https://github.com/python/cpython/compare/master...zooba:bpo37390
In particular, I added the backlinks from the table (but unfortunately they all
go to the line of text we generate for the ..audit-event directive
Steve Dower added the comment:
New changeset 7fd2ba354ec2304743ffd9ba620e07d113532264 by Steve Dower
(animalize) in branch 'master':
bpo-35360: Update Windows builds to use SQLite 3.28.0 (GH-14179)
https://github.com/python/cpython/commit/7fd2ba354ec2304743ffd9ba620e07
Change by Steve Dower :
--
pull_requests: +14171
pull_request: https://github.com/python/cpython/pull/14354
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
New changeset 0fc14b373398767b4323a7bc2c2310b6218c5b74 by Steve Dower
(animalize) in branch '2.7':
bpo-35360: Update Windows builds to use SQLite 3.28.0 (GH-14182)
https://github.com/python/cpython/commit/0fc14b373398767b4323a7bc2c2310
Steve Dower added the comment:
> According to serge_sans_paille: if ``self->b_ptr`` contains pointer, the
> ``memcpy`` creates sharing, and this is dangerous: if a ``__del__`` happens
> to free the original pointer, we end up with a dangling reference in
> ``new_ptr``. As fa
Steve Dower added the comment:
New changeset 8bd2872adbbc7ed5dd0a7593193c52431ae34c8d by Steve Dower
(animalize) in branch 'master':
bpo-25361: Enable SSE2 instructions for Windows 32-bit build (GH-12438)
https://github.com/python/cpython/commit/8bd2872adbbc7ed5dd0a7593193c52
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 9fc720e5e4f772598013ea48a3f0d22b2b6b04fa by Steve Dower (David K.
Hess) in branch 'master':
bpo-4963: Fix for initialization and non-deterministic behavior issues in
mimetypes (GH-3062)
https://github.com/python/cpyt
Steve Dower added the comment:
Sorry for the delays!
I've merged into master. The backports (3.7, 3.8) are going to need some help,
so I'll take a look at them soon unless someone else gets there first.
--
stage: needs patch -> backport needed
versions: +Python 3.
Change by Steve Dower :
--
pull_requests: +14191
pull_request: https://github.com/python/cpython/pull/14376
___
Python tracker
<https://bugs.python.org/issue4
Change by Steve Dower :
--
pull_requests: +14190
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/14375
___
Python tracker
<https://bugs.python.org/iss
Steve Dower added the comment:
> Should PCbuild/pyproject.vcxproj explicitly import python.props which defines
> it?
It already does :)
This is more likely because the previous build on that buildbot crashed(?) or
because it was aborted during test_multiprocessing:
Steve Dower added the comment:
We should also remove that deprecation warning, as PEP 528 (or was it PEP 529)
undeprecated bytes paths.
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 25fbe33b92cd938e809839feaa3fda97e6ad0980 by Steve Dower in branch
'3.8':
bpo-4963: Fix for initialization and non-deterministic behavior issues in
mimetypes (GH-14375)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 2a99fd911ebeecedbb250a05667cd46eca4735b9 by Steve Dower in branch
'3.7':
bpo-4963: Fix for initialization and non-deterministic behavior issues in
mimetypes (GH-14376)
https://github.com/python/cpyt
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pytho
Steve Dower added the comment:
> I suggest to close the issue and see if the bug comes back.
You opened it, so sure :)
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The handle can deliberately live beyond the process, but it does not have to.
If it is closed early then the kernel object will be freed when no handles
remain, which will be at process exit.
So it's a classic __exit__/__del__ case, where both are need
Steve Dower added the comment:
Definitely just an oversight. Thanks for fixing this!
I think it can go to 3.8 as well. Thoughts?
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
It's probably worth at least a post to python-dev to expand the audience, but
unless someone speaks up with some really good reason why they must update to
Python 3.10 without updating their own code then let's deprecate it.
FWIW, even with th
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14218
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14406
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I think my PR is ready. I had to go through and update all the audit-event tags
that existed, since the argument parsing in Sphinx didn't work the way I first
thought it did, but now we can provide a back reference manually (or let it
auto-generate one t
Steve Dower added the comment:
Okay, this definitely used to work, but now it's broken for me too.
What version of Windows are you on (copy-paste from cmd.exe's ver command)?
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
This seems to be a change in Windows at some point, as it still works on one of
my other PCs. I've pinged some colleagues to find out what might have happened,
but it definitely looks like the lack of Read+Execute permission is working
correctly now :(
Steve Dower added the comment:
This looks like because you have Qt installed in one environment and not the
other, so when matplotlib imports it pyinstaller decides to include it.
You'll have to report this to pyinstaller. It's nothing to do with core Python.
--
Steve Dower added the comment:
In any case, it's definitely pyinstaller and not CPython. Please report it on
their issue tracker.
--
status: open -> closed
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
So I have a fix for 3.9 for this, I believe (involves making
sys.base_executable configurable via PyConfig and overriding it and
config->home when we know we're inside an app container).
For 3.8 I can apply the same fix and make sys.base_executable pu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14244
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14428
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 44f91c388a6f4da9ed3300df32ca290b8aa104ea by Steve Dower in branch
'master':
bpo-37390: Add audit event table to documentations (GH-14406)
https://github.com/python/cpython/commit/44f91c388a6f4da9ed3300df32ca29
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
pull_requests: +14266
pull_request: https://github.com/python/cpython/pull/14450
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset db4d7ddb012ef8f087a8eb2a5b8a672d04a48e1a by Steve Dower in branch
'3.7':
bpo-37369: Fixes path for sys.executable when running from the Microsoft Store
(GH-14450)
https://github.com/python/cpython/commit/db4d7ddb012ef8f087a8eb2a5b8a67
Change by Steve Dower :
--
pull_requests: +14273
pull_request: https://github.com/python/cpython/pull/14456
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset ed4657bd28432ace671a9e6ae38a3d485c69213d by Steve Dower in branch
'3.7':
bpo-37369: Fix venv and test symlinking (GH-14456)
https://github.com/python/cpython/commit/ed4657bd28432ace671a9e6ae38a3d
Change by Steve Dower :
--
pull_requests: +14278
pull_request: https://github.com/python/cpython/pull/14461
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset db4eb2c57dbfca402a539184c966c449cb1aa8e3 by Steve Dower in branch
'3.7':
bpo-37369: Fix path handling when python.exe is used as a symlink (GH-14461)
https://github.com/python/cpython/commit/db4eb2c57dbfca402a539184c966c4
Steve Dower added the comment:
New changeset 9048c49322a5229ff99610aba35913ffa295ebb7 by Steve Dower in branch
'master':
bpo-37369: Fix initialization of sys members when launched via an app container
(GH-14428)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +14284
pull_request: https://github.com/python/cpython/pull/14467
___
Python tracker
<https://bugs.python.org/issue37
Change by Steve Dower :
--
pull_requests: +14285
pull_request: https://github.com/python/cpython/pull/14468
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset ac14632c756fec561e4b868b8793334bd7b22241 by Steve Dower in branch
'master':
bpo-37369: Fixes crash when reporting fatal error (GH-14468)
https://github.com/python/cpython/commit/ac14632c756fec561e4b868b879333
Steve Dower added the comment:
New changeset 323e743d4879f1cd861d0b252775797fb7938755 by Steve Dower in branch
'3.8':
bpo-37369: Fix initialization of sys members when launched via an app container
(GH-14467)
https://github.com/python/cpython/commit/323e743d4879f1cd861d0b25277579
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
> I'm not sure of the purpose of sys._base_executable. Maybe open a separated
> issue to make the attribute public? I'm not sure if multiprocessing (for
> example) should use it, or if sys.executble should be used.
Yeah, it's a bit more
Steve Dower added the comment:
Unfortunately, we don't control that path - it comes from a parameter
substitution.
I'll have to see whether there's another parameter we can use. All of this
stuff is in undocumented territory
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue37369>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
This is fixed now, right? The buildbots seem happy at least. I'll close.
--
assignee: -> vstinner
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pytho
Steve Dower added the comment:
You use this by getting the file descriptor/fileno for an open file, and then
testing whether it's a file or not:
>>> f=open("python.bat")
>>> f.fileno()
3
>>> import os
>>> os.path.isfile(3)
True
T
Change by Steve Dower :
--
title: AF_UNIX is now supported in Windows -> Enable AF_UNIX support in Windows
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +14337
pull_request: https://github.com/python/cpython/pull/14524
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
The page is not generating correctly at
https://docs.python.org/dev/library/audit_events.html
Adding the documentation team, where hopefully someone will know what needs
poking.
--
nosy: +eric.araujo, ezio.melotti, mdk, willingc
resolution: fixed
Steve Dower added the comment:
New changeset e226e83d36dfc7220d836fb7a249ce18e70cb4a6 by Steve Dower in branch
'master':
bpo-37363: Add audit events on startup for the run commands (GH-14524)
https://github.com/python/cpython/commit/e226e83d36dfc7220d836fb7a249ce
Steve Dower added the comment:
I can't repro this. It looks like Doc/makefile#L196 passes -Ea which ought to
deal with any old files (and it certainly does on my Ubuntu machine), so it's
likely not that.
The table contents is simply not in the file on docs.p.o, so I guess there&#x
Steve Dower added the comment:
All that's left here right now is some xmlrpc events, unless we can think of
any more stdlib modules that should have them?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
For the record, I am 100% in favor of deprecating and removing bdist_wininst
and bdist_msi from distutils as soon as possible, as they are maintenance
burdens and bdist_wininst in particular often attracts AV false positives.
setuptools is welcome to either do
Steve Dower added the comment:
Your PR is against 3.6 - is that intentional?
--
resolution: fixed ->
stage: resolved ->
status: closed -> open
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Yeah, at some point we had to add an initialization check to the audit calls
because of the tuple, so it essentially became a subinterpreter event but not
the main one.
But I thought the dtrace call happened before that check? Looking through the
linked
Steve Dower added the comment:
Yeah, I'd rather not do this level of validation in Python.
If Windows decides to reject or automatically correct this, fine, but Python is
just being a thin layer over the operating system here. We shouldn't try and
prevent things that the
Steve Dower added the comment:
> I'm pretty sure there is code in the wild that expects /
> python.exe to be the Python executable (when you're not in a virtual
> environment) ... for example, when getting
> sys.prefix from the registry (um, I don't think that&#
Steve Dower added the comment:
Heh, and I was so sure I'd copy pasted the right number after getting it wrong
so often.
Just tag it against this bug.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Anyone from the docs team have any ideas here? We're going to present on this
at EuroPython tomorrow and it'd be great to be able to point people at the docs.
--
___
Python tracker
<https://bu
Steve Dower added the comment:
Presumably this is linked to issue37515 (why not just repurpose that one?), but
I'm inclined to think this is okay provided:
* if the operation succeeds, no error/message is displayed
* if the operation fails, we only update the error message if one o
Steve Dower added the comment:
Passing a NULL format string there means the same as passing NULL to
PyObject_CallFunction(func, NULL) - no arguments, which results in an empty
tuple being passed to the hooks.
Perhaps in the early cases we can pass NULL instead of a tuple? Maybe even
assert
Change by Steve Dower :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue37587>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I believe this is acceptable to include in 3.8, provided it makes sense for
3.9, so I added the backport tag on the PR.
That said, I'm not making any comment on whether it's appropriate at all :)
For Windows we found some ways to reduce the stac
Change by Steve Dower :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue36261>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
New changeset 8efade91b12a13102a09a3856179021e579da5e9 by Steve Dower (Carl
Bordum Hansen) in branch 'master':
bpo-36261: Improve example of the preamble field in email docs (GH-14751)
https://github.com/python/cpyt
Steve Dower added the comment:
Merged, and I am assuming the backports will merge fine too. Thanks for the
patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bug
Steve Dower added the comment:
New changeset 6b929580eb018cfef386db7f7f66b3a58532eada by Steve Dower (Michele
Angrisano) in branch 'master':
bpo-37571: Add 'b' to prevent the TypeError exception. (GH-14721)
https://github.com/python/cpython/commit/6b929580eb018cfef386
Change by Steve Dower :
--
pull_requests: +14559
pull_request: https://github.com/python/cpython/pull/14764
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 68c74d05c1fdaf59d8711431884af975ac2ac5f8 by Steve Dower in branch
'master':
bpo-37571: Remove extra space in ctypes docs (GH14764)
https://github.com/python/cpython/commit/68c74d05c1fdaf59d8711431884af9
Steve Dower added the comment:
Thanks for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I agree. This isn't important information for the documentation anyway.
--
nosy: +steve.dower
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset 52c8c090870c4e45dc48d1991d7ef7de2e40b2a8 by Steve Dower (Paul
Monson) in branch 'master':
bpo-37553: SendfileUsingSendTest tests timeout too short for Windows ARM32
(GH-14716)
https://github.com/python/cpyt
Steve Dower added the comment:
Looking at PR 14702, I would much rather update what `-m test --pgo` does than
make this exclusive to Makefile.
Back when we added the --pgo flag, the intent was always to move toward an
equivalently good profile, but for practical reasons we settled at the
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
2501 - 2600 of 5794 matches
Mail list logo
