Steve Dower added the comment:
Assuming you installed pip using the installer, repair should bring it back.
Do you still have installer logs? They would be in %TEMP% and start with
"python". We'll need at least the main log and the pip log, but if you want to
just zip them al
Steve Dower added the comment:
Thanks! Interestingly, it seems like it ought to have re-run, but
decided not to. I wonder if there's been some change to how Windows
Installer deals with using registry keys to control custom actions?
Unfortunately, MSI is an incredibly complicated inst
Steve Dower added the comment:
Thanks for the ping. I'll try and check in later this week to finish it up.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
> I did not have the latest installed which is Win10SDK_10.0.18362, therefore
> it did trigger that original error in msg387518.
Did you have any other version installed? It should include one by
default, which is why we don't mention it i
Steve Dower added the comment:
This seems like a good change to me. Making sure that the implementation is
easily patchable sounds like a good plan, though I don't have any specific
suggestions on what would be best.
--
nosy: +steve.
Steve Dower added the comment:
> FYI, in Windows 10, deleting files and directories now tries a POSIX delete
Yeah, FWIW, I haven't been able to get clear guidance on what I can/cannot
publicly announce we've done in this space. But since you've found it I guess I
ca
Steve Dower added the comment:
I'm not sure we ever meant for LoadLibrary("python3.dll") to actively load the
concrete python3X.dll. The APIs are the same, so you can (should) LoadLibrary
the one that you want.
It's when you use static imports in extensions that it
Steve Dower added the comment:
Yeah, but in that scenario, it is just as good to LoadLibrary("python39.dll")
and use it as if it was LoadLibrary("python3.dll") because the interaction
model is identical.
The only reason to load python3.dll explicitly is if you are not
Steve Dower added the comment:
Sorry, I can't help. My employer has strict rules about reviewing GPL code like
that in your linked repository.
I'd suggest checking your thread management in native code. Each new thread
created in Python will create a new native thread, and t
Steve Dower added the comment:
We already have a separate recursion limit for debug builds on Windows, so it's
probably best all around to reduce that (if it's only recursion tests that are
failing). That way, we won't forget to fix up debugging later if/when we
Steve Dower added the comment:
Hmm, yeah, it seems like the debug-specific definition has gone. Wonder when
that happened.
In that case, go ahead and revert, but I'd suggest doing it by just removing
the new Py_DEBUG condition rather than undoing all the changes. Should be
nothing
Steve Dower added the comment:
So somehow Windows made a rebuild *without* having to touch
kernel32.dll, which is fairly impressive.
That version number comes from kernel32.dll, because there's no good way
to get the build number via an API and also avoid compatibility settings
lying
Steve Dower added the comment:
For modifying an environment variable, please clone the entire path MSI and use
an Environment element to update it. Should be a little simpler than that one,
because it's a constant.
I'm always very hesitant to modify system-wide (or user-wide) set
Steve Dower added the comment:
The reason to avoid the GetVersion API is that certain automatic
compatibility modes will lie about what the version number is, and
people complained that it was wrong (kind of like this complaint ;) ).
Reading the version from a system DLL bypasses that risk
Steve Dower added the comment:
Maybe as a global setting, the better thing to copy is the button at the end of
installation that offers to change the long path policy?
That would give a bit more room that a checkbox to explain what is being set
and what the implications are, which will help
Steve Dower added the comment:
Jason, this issue and the associated PR are out of date and should not be
merged.
The PR also only affects completely unused code, so it has no value whatsoever
being in CPython. I don't really care too much about the unused code, but I
will *insist* o
Steve Dower added the comment:
To clarify my position on this (as the PEP author):
* audit hooks added *after* initialization (including via the Python API) are
not intended for security, but for logging/debugging, and so bypasses are not
considered security issues
* audit hooks added
New submission from Steve Dower :
I heard [1] that rtree support would be very useful in SQLite. We should see
whether enabling it is safe/easy/cheap and then do it.
1: https://twitter.com/Jamieallencook/status/1368221499794976775?s=20
--
components: Build, Library (Lib), Windows
Change by Steve Dower :
--
nosy: +ghaering
___
Python tracker
<https://bugs.python.org/issue43440>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Thanks, Pablo! Nice patch.
This can be backported, btw. New audit events are allowed to be added in minor
releases (they just cannot be changed).
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<ht
Steve Dower added the comment:
New changeset 31818e98d3b845d815e9caf2a3d330341bdc1b33 by Erlend Egeberg
Aasland in branch 'master':
bpo-43440 : Enable SQLite R*Tree support for windows builds (GH-24797)
https://github.com/python/cpython/commit/31818e98d3b845d815e9caf2a3d330
Steve Dower added the comment:
Perfect, thanks!
Callbacks are a bigger ask, but I don't have any fundamental opposition to
them. Probably worth opening a new issue, as it'll affect all platforms (I
assume).
And yeah, the setup.py in the CPython repo doesn't impact any of the
Steve Dower added the comment:
New changeset 8c862e51248c5ebfec787badec88eb58c9267e1e by Zackery Spytz in
branch 'master':
bpo-39631: Fix file association MIME type in the Windows installer (GH-20205)
https://github.com/python/cpython/commit/8c862e51248c5ebfec787badec88eb
Steve Dower added the comment:
New changeset 711f9e180a48baba62301735b7f1a58ef0d0e93a by Minmin Gong in branch
'master':
bpo-40677: Define IO_REPARSE_TAG_APPEXECLINK explicitly (GH-20206)
https://github.com/python/cpython/commit/711f9e180a48baba62301735b7f1a5
Steve Dower added the comment:
Actually, now that I've gone and hit merge, I've changed my mind about the NEWS
entry. I'll add it.
--
___
Python tracker
<https://bugs.pyt
Steve Dower added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +19517
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20226
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +19518
pull_request: https://github.com/python/cpython/pull/20227
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
If someone remembers where the other "shebangs on Windows don't make sense"
issue is, I think we can close this one in favour of that.
Though it's also an important point for issue40667 - if "python.exe" becomes
the launcher,
Steve Dower added the comment:
> To avoid this, process() can set a flag based on the image name that prevents
> calling maybe_handle_shebang().
Or the other solution, which is stop treating "usr/bin/env" as "search PATH" -
I'm sure there's another iss
Steve Dower added the comment:
New changeset 92327a9913150f5bb55b2727a2c5d50f9b7b6e55 by Steve Dower in branch
'master':
bpo-39631: Adds NEWS entry (GH-20227)
https://github.com/python/cpython/commit/92327a9913150f5bb55b2727a2c5d5
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Sorry, Windows 7 is no longer supported in Python 3.9. You'll need to update,
ideally to Windows 10, but if you want to stay on Windows 8.1 then I believe
that one's supported until Python 3.10.
--
resolution: -> not a bug
stage: ->
Steve Dower added the comment:
It looks fine to me, but we probably want to clearly document it as
unsupported/likely to change between releases/etc., especially since it's
relying on an assumption that we want to change (one static runtime per
pr
Change by Steve Dower :
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 448325369ff73011d34d6c3a493014fe3ead8843 by Rotuna in branch
'master':
bpo-23082: Better error message for PurePath.relative_to() from pathlib
(GH-19611)
https://github.com/python/cpython/commit/448325369ff73011d34d6c3a493014
Steve Dower added the comment:
I think we can safely say this is by design (I know Jason got his backport
working).
> Understood. However, this statement assumes the "correct path" is the most
> precise path to resolve the target. If you instead define "correct pat
Steve Dower added the comment:
> how could one write the `cmd.exe` `dir` command using Python?
I haven't checked, but if the dir command resolves the entire symlink chain
rather than one step at a time, you'd use realpath (though that seems unlikely,
tbh).
Failing that, yo
Steve Dower added the comment:
After thinking this through some more, I don't think this solves the problem,
but only changes it. And we're better off leaving things as they are than just
moving them around.
--
resolution: -> rejected
stage: patch review -> resol
Steve Dower added the comment:
I've checked and merged the cpython-source-deps update. (For everyone's info, I
downloaded the sources myself and checked hashes/etc. as per normal, even
though I eventually merged the PR and tagged i
Steve Dower added the comment:
> import subprocess
> subprocess._cleanup = lambda: None
--
___
Python tracker
<https://bugs.python.org/issue37380>
___
___
Steve Dower added the comment:
There are non-binding CI tests run with Github Actions (post-merge) that test
from a layout, and last I checked they were all passing. Nobody is really
monitoring it but me though, as it isn't a buildbot.
The Windows installer also runs pip and IDLE
Steve Dower added the comment:
That's correct, though I thought PEP 528 and 529 applied earlier than that?
Around 3.6, I thought.
Feel free to make a doc update though. That reference is definitely out of date.
--
___
Python tracker
&
Steve Dower added the comment:
Python now decodes bytes back into a str when used as a path, so the behaviour
is identical.
Someone else might feel comfortable doing the patch, I didn't mean to imply
that you had to. Only that it is a valid fix and won't be a was
Steve Dower added the comment:
New changeset c897bbdb284c3780ef6cec8a3870935a6bb7 by Zackery Spytz in
branch 'master':
bpo-40831: Remove an incorrect statement in the Windows docs (GH-20570)
https://github.com/python/cpython/commit/c897bbdb284c3780ef6cec8a38
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Can anyone confirm that you've got an active code page of something other than
1252 ("standard" US English)? I'm not able to reproduce this easily, and I
wonder if it's because of that setting.
Easiest way to check is in
Steve Dower added the comment:
> Let's promote ePub and PDF instead.
Find a good viewer we can bundle with the installer with equivalent
search/index functionality and we can consider it.
More realistically, including the docs as unbundled HTML files and relying on
the default br
Change by Steve Dower :
--
keywords: +patch
pull_requests: +19934
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20724
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue40861>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
We either need someone to contribute a fix to
sphinxcontrib\htmlhelp\templates\project.hhp (bearing in mind that this *must*
be optional, as it breaks search), or write code to patch the generated file
between generation and use (which is probably hard).
And
Steve Dower added the comment:
New changeset 3a3a30c5a4622e18be9f7e4a239dc9e0d7c8054c by Steve Dower in branch
'master':
bpo-40861: Enable optimizations when building liblzma (GH-20724)
https://github.com/python/cpython/commit/3a3a30c5a4622e18be9f7e4a239dc9
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Currently, it's just stored as global state in signalmodule.c and forgotten
about. It probably needs to become module state, and the signal module needs
better initialization/shutdown.
--
components: Windows
messages: 371036
nosy: eric
New submission from Steve Dower :
In time.sleep on Windows, if the WaitForSingleObject call fails, the call
returns success. It essentially looks like the timeout was 0.
Errors should be highly unlikely, as the event object is leaked (see
issue40912), but if they _do_ occur, we should raise
Steve Dower added the comment:
That was a *big* patch to importlib.resources... And newly defined and
standardised protocols? That seems like a lot to bring in without having gone
through a PEP anyway, despite the minor bug that has drawn attention to it.
I don't think backports shou
Steve Dower added the comment:
add_dll_directory can be safely used within your library, so if you have any
.py files that will be imported first (such as your package __init__.py), you
can add it then. The safest way is to use something like:
with os.add_dll_directory(THE_DIR):
import
Steve Dower added the comment:
We can close it. bdist_msi isn't recommended for any reason, and cx_Freeze
isn't ours.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs
Steve Dower added the comment:
The current "using" doc page is way too in-depth, but I'm actually okay with
the idea of having a "Did you mean to launch Python? Press 'Start' and type
'Python' to find it" message on the Modify page of the instal
Steve Dower added the comment:
Thanks for confirming that reality aligns with the documentation.
> when doing the same and passing `shell=True` to the POpen() call, there is no
> such initial folder in the lookup
Correct, because a fully qualified path to cmd.exe is used, and cmd
Steve Dower added the comment:
Yeah, I'll get onto it now.
--
___
Python tracker
<https://bugs.python.org/issue40164>
___
___
Python-bugs-list mailing list
Steve Dower added the comment:
Thanks. Your PR will start to work once I've done the updated build, so don't
worry about the failure right now.
OpenSSL updates require build manager involvement, so it's blocked on me :)
--
___
Steve Dower added the comment:
... equally happy without an explicit test in anything that's only prerelease
right now.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
You could test this by getting the event and CloseHandle-ing it. A function to
do this could be added to _testcapimodule. It'd have to run in its own process,
but we have (a few) helpers around for this.
Given the concerns, I don't think we should c
Steve Dower added the comment:
Okay, new sources and build are up, so I retriggered the PR. If it's all good,
I'll merge and backport.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
New changeset 80d827c3cb041ae72b9b0572981c50bdd1fe2cab by Srinivas Reddy
Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) in branch 'master':
bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +20034
pull_request: https://github.com/python/cpython/pull/20841
___
Python tracker
<https://bugs.python.org/issue40
Change by Steve Dower :
--
pull_requests: +20033
pull_request: https://github.com/python/cpython/pull/20840
___
Python tracker
<https://bugs.python.org/issue40
Steve Dower added the comment:
> If WaitForSingleObjectEx fails, do you think the system error code should be
> raised as an OSError?
It's invalid (and unfixable) internal state, so perhaps SystemError makes the
most sense? There's no point catching it in most cases.
Or sin
Steve Dower added the comment:
New changeset 7e57c367d65f3d0219978b465dc00da15ae3724c by Steve Dower in branch
'3.8':
bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834)
https://github.com/python/cpython/commit/7e57c367d65f3d0219978b465dc00d
Steve Dower added the comment:
New changeset 617af99312ca36ad5a08db764858caf11c92a2c0 by Steve Dower in branch
'3.7':
bpo-40164: Update Windows OpenSSL to 1.1.1g (GH-20834)
https://github.com/python/cpython/commit/617af99312ca36ad5a08db764858ca
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Łukasz can add a note to the release page, I believe.
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue40
Steve Dower added the comment:
Is there any reason for TkDND to be optional apart from the rest of Tkinter? If
not, your installer changes are probably fine, but why not combine the two and
just treat it as part of the Tcl/Tk build? (Primarily for Windows, I'd guess.
Not sure how t
Steve Dower added the comment:
Hi Miika
Please create a new issue.
It would also be helpful if you gave us some idea of what your username looks
like, even if you change it a bit to hide it from the internet. The most common
cause of this error is spaces or non-ASCII characters in your
Steve Dower added the comment:
Thanks for the change. It looks good, though I would like to have a NEWS entry
for this so that people can find that we made a deliberate change to this DLL.
I'd also like to do some manual testing to make sure that we aren't going to
break any ob
Steve Dower added the comment:
Looks good. Let's rename PYTHON_DLL_NAME to ORIGINAL_FILENAME, since it took me
10 minutes to figure out that that's how it's used...
We'll backport this one to 3.9 before RC. No NEWS file required.
--
v
Steve Dower added the comment:
Looks good, but I'll want to manually test this, as it's not covered by
automated tests. (If you happen to know how to test drag-drop of multiple files
and non-MBCS filenames in Explorer, would love to have some tests, but given
the low churn on t
Steve Dower added the comment:
New changeset 6eab52ffadb2836adb59d0578c84d247f05e19b1 by Ammar Askar in branch
'3.8':
bpo-39699: Remove accidentally committed test change (GH-21089)
https://github.com/python/cpython/commit/6eab52ffadb2836adb59d0578c84d2
Steve Dower added the comment:
It depends on your application. Almost all of these are exposed directly, so
you will be vulnerable if your application uses them in the way described by
the CVE.
I'm not familiar enough with the vulnerabilities in question to tell you for
sure, and I
Steve Dower added the comment:
New changeset fe2a48c605d98ac02ab2b9593cb87ce364aeae2d by Nikita Nemkin in
branch 'master':
bpo-41089: Filters and other issues in Visual Studio projects (GH-21070)
https://github.com/python/cpython/commit/fe2a48c605d98ac02ab2b9593cb87c
Change by Steve Dower :
--
pull_requests: +20256
pull_request: https://github.com/python/cpython/pull/21090
___
Python tracker
<https://bugs.python.org/issue41
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
Thanks!
--
___
Python tracker
<https://bugs.python.org/issue41089>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 4efc3360c9a83d5891f27ed67b4f0ab7275d2ab4 by Nikita Nemkin in
branch 'master':
bpo-41054: Simplify resource compilation on Windows (GH-21004)
https://github.com/python/cpython/commit/4efc3360c9a83d5891f27ed67b4f0a
Steve Dower added the comment:
New changeset 47cd931a61146793faa44e01516bf07b0c23380c by Steve Dower in branch
'3.9':
bpo-41089: Filters and other issues in Visual Studio projects (GH-21070)
https://github.com/python/cpython/commit/47cd931a61146793faa44e01516bf0
Steve Dower added the comment:
New changeset 2c6e4e91c5a4d3f25908108f4ed32aba936df70c by Nikita Nemkin in
branch 'master':
bpo-41039: Simplify python3.dll build (GH-20989)
https://github.com/python/cpython/commit/2c6e4e91c5a4d3f25908108f4ed32a
Steve Dower added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
SGTM. Thanks for the PR!
--
___
Python tracker
<https://bugs.python.org/issue41094>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
New changeset bbf36e8903f8e86dcad8131c818e122537c30f9e by Nikita Nemkin in
branch 'master':
bpo-41070: Simplify pyshellext.dll build (GH-21037)
https://github.com/python/cpython/commit/bbf36e8903f8e86dcad8131c818e12
Steve Dower added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 33b79b11b891adea5a916df8e3779505b37aabe7 by Nikita Nemkin in
branch 'master':
bpo-41038: Fix non-ASCII string corruption in Win32 resource files (GH-20985)
https://github.com/python/cpython/commit/33b79b11b891adea5a916df8e37795
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
I'm going to have to spend more time to analyse this (later), but it seems like
Windows deciding not to update the directory's data structures (containing the
st_mtime retrieved by scandir) as long as the file is still open.
I suspect the answe
Steve Dower added the comment:
Does it make the most sense for us to make .flush() also do an implicit
.fsync() (when it's actually a file object)?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Okay, so it sounds like there's a class of files where we can't rely on the
FindFileData having the right values. But we get enough information to be able
just suppress the caching behaviour for those, right?
Basically, my criteria for fixing t
Steve Dower added the comment:
> We're faced with the choice between either always calling the real lstat, or
> just documenting that files with hard links will have stale information if
> the file was updated using another link.
That's an easy choice: we document it.
Steve Dower added the comment:
Those are all good ideas, but using os.stat(d) instead of d.stat() is shorter,
more reliable, more compatible, and already works.
There's no middle ground where DirEntry can be faster, because it's already
using that middle ground. All the discussi
Steve Dower added the comment:
> I understand that LoadLibraryExW() must not be attempted if _Py_dll_path is
> empty, or if Py_GetPrefix() is empty. Am I right?
More likely those should never be empty. Perhaps sys.prefix is optional, but
the DLL path is the current executing modul
2001 - 2100 of 5794 matches
Mail list logo
