Change by Steve Dower :
--
pull_requests: -24264
___
Python tracker
<https://bugs.python.org/issue38222>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 9f0b3a9c8eedf694377d8638365fb9f385daa581 by Miss Islington (bot)
in branch '3.8':
bpo-38822: Check specifically for a drive, not just a colon (GH-25540)
https://github.com/python/cpython/commit/9f0b3a9c8eedf694377d8638365fb9
Steve Dower added the comment:
New changeset 28575923a9ee40928a9d00a7ed997a6f6a09b8d1 by Miss Islington (bot)
in branch '3.9':
bpo-38822: Check specifically for a drive, not just a colon (GH-25540)
https://github.com/python/cpython/commit/28575923a9ee40928a9d00a7ed997a
Steve Dower added the comment:
New changeset 019e9e816882f5c43c4b833f81844b8299e815fd by Steve Dower in branch
'master':
bpo-43538: Add extra arguments to os.startfile (GH-25538)
https://github.com/python/cpython/commit/019e9e816882f5c43c4b833f81844b
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 3513d55a617012002c3f82dbf3cec7ec1abd7090 by Steve Dower in branch
'master':
bpo-43607: Fix urllib handling of Windows paths with \\?\ prefix (GH-25539)
https://github.com/python/cpython/commit/3513d55a617012002c3f82dbf3cec7
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 52e9031fbd23c10668badc2a72ee5c203d6902c7 by Miss Islington (bot)
in branch '3.9':
bpo-43284: Update platform.win32_ver to use _syscmd_ver instead of
sys.getwindowsversion() (GH-25500)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset e92d1106291e5a7d4970372478f2882056b7eb3a by Miss Islington (bot)
in branch '3.8':
bpo-43607: Fix urllib handling of Windows paths with \\?\ prefix (GH-25539)
https://github.com/python/cpython/commit/e92d1106291e5a7d4970372478f288
Steve Dower added the comment:
Left some minor suggestions on the PR, but wanted to copy this comment here as
well:
I wonder if it's worth returning the connection object when it's created
(through a new event in module.c) and then reference it in these events? That
can then
Steve Dower added the comment:
Thanks for the PR, kj! Left a suggestion for you, but otherwise it should solve
the problem nicely.
--
___
Python tracker
<https://bugs.python.org/issue40
Steve Dower added the comment:
Thanks for finishing up that patch.
And yes, we add a ".0" in case we need to patch the sources ourselves.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Pyt
Steve Dower added the comment:
I agree with Eryk, this is not an issue with the supported C runtime.
mingw-w64 has supposedly been working on UCRT support (it may even be working
already?), and that is what will be necessary. We certainly aren't going to try
and runtime detect thi
Steve Dower added the comment:
New changeset 5e437fb872279960992c9a07f1a4c051b4948c53 by Segev Finer in branch
'master':
bpo-30555: Fix WindowsConsoleIO fails in the presence of fd redirection
(GH-1927)
https://github.com/python/cpython/commit/5e437fb872279960992c9a07f1a4c0
Steve Dower added the comment:
Thanks for persisting with this change.
Looks like backports will have to be manual, and I'm not going to get to them
today myself, but if someone else wants to do it then feel free.
I'm pretty sure this won't have any (negative) visible impa
Steve Dower added the comment:
Yeah, along those lines. I believe the event is ".../result" in other places,
just to be clear that it's not a function with that name.
Also, don't forget to clean up when returning early from the connected event.
We don't want to leak
Steve Dower added the comment:
I'm happy with the PR as it stands now. Anyone else have an opinion?
--
nosy: +eryksun, steve.dower
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I'm not convinced this is a good change, mainly for the reasons Serhiy
mentioned (and others have mentioned when I've spoken with them privately).
What would you do with your custom subclass if home() did not have this
argument?
--
nosy: +s
Steve Dower added the comment:
New changeset 425434dadc30d96dc1c0c628f954f9b6f5edd2c9 by Ken Jin in branch
'master':
bpo-40432: Use python 3.8 or higher to compile CPython on Windows (#25389)
https://github.com/python/cpython/commit/425434dadc30d96dc1c0c628f954f9
Steve Dower added the comment:
Yeah, that's all reasonable.
But why wouldn't we go the other way and say "getting a user directory for a
different user is not supported and all existing ways to do it are now
deprecated"?
I know you think that's not a relevant argu
Steve Dower added the comment:
New changeset 7244c0060dc3ef909f34b0791c3e7490b0340d5e by Erlend Egeberg
Aasland in branch 'master':
bpo-43762: Add audit events for loading of sqlite3 extensions (GH-25246)
https://github.com/python/cpython/commit/7244c0060dc3ef909f34b0791c3e74
Steve Dower added the comment:
Thanks for the PR!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Stagg added the comment:
Please may you add a test that uses "io.BytesIO()" as the filename argument.
BytesIO() objects do not have a 'name' attribute
--
nosy: +stestagg
___
Python tracker
<https://bug
Steve Dower added the comment:
I've pushed the new sources and retriggered the PR (a bit messily, because I
tagged/labelled the wrong version number initially, but it's there now). So if
it all passes then we're good from my POV.
--
___
Steve Dower added the comment:
New changeset e3bf179642a3445fb079454f382b93d0177f5012 by Shreyan Avigyan in
branch 'master':
bpo-43864: Silence deprecation warning in test_importlib.test_module_found and
test_importlib.test_module_not_found (GH-25656)
https://github.com/pyth
Change by Steve Dower :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue43864>
___
___
Python-bugs-list
Steve Dower added the comment:
New changeset bf0c7c0147b73738cac63eb27ef48430284ff121 by Erlend Egeberg
Aasland in branch 'master':
bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641)
https://github.com/python/cpython/commit/bf0c7c0147b73738cac63eb27ef484
Steve Dower added the comment:
New changeset 7f7cfc41185b651be9cb4d2759c40c3abf738485 by Erlend Egeberg
Aasland in branch '3.8':
[3.8] bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641)
https://github.com/python/cpython/commit/7f7cfc41185b651be9cb4d2759c40c
Steve Dower added the comment:
New changeset 5cadcec5ecf6f95cc771e509ad98c3e3533b32bb by Erlend Egeberg
Aasland in branch '3.9':
[3.9] bpo-43492: Upgrade Windows installer to use SQLite 3.35.5 (GH-25641)
https://github.com/python/cpython/commit/5cadcec5ecf6f95cc771e509ad98c3
Steve Dower added the comment:
Thanks for the backports!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
pull_requests: -24359
___
Python tracker
<https://bugs.python.org/issue42957>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: -24360
___
Python tracker
<https://bugs.python.org/issue42957>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I think the test failures cascade, and some state is not being cleaned up. I'm
trying to work through them now, but if someone else is as well, do say so and
I'll find something else to do.
--
___
Pyth
Change by Steve Dower :
--
keywords: +patch
pull_requests: +24366
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25675
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
What does os.rename do on Linux? Does it just overwrite existing files by
default?
--
___
Python tracker
<https://bugs.python.org/issue43
Steve Dower added the comment:
New changeset c1a9535989cc7323099725503519a17f79d083f5 by Steve Dower in branch
'master':
bpo-43955: Handle the case where the distutils warning has already been
triggered (GH-25675)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset baecfbd849dbf42360d3a84af6cc13160838f24d by Barney Gale in branch
'master':
bpo-43757: Make pathlib use os.path.realpath() to resolve symlinks in a path
(GH-25264)
https://github.com/python/cpython/commit/baecfbd849dbf42360d3a84af6cc13
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +easy
___
Python tracker
<https://bugs.python.org/issue43847>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I'm also seeing (and annoyed by) this.
Do we need to do anything more than suppress the error? If we're just failing
to notify the event loop that we're closing because the loop is gone, does the
notification even matter?
--
nos
Steve Dower added the comment:
Any reason this couldn't be in sitecustomize.py? Either by poking values into
sysconfig directly (for back-compat) or we train sysconfig to look inside
sitecustomize for a well-known name.
--
nosy: +steve.
Steve Dower added the comment:
I think Eryk's point is that the behaviour is correct, and it's unfortunate
that certain tools use realpath() when they don't actually mean it (I've been
bitten by this too with pytest).
Presumably you want to replace r
Steve Dower added the comment:
New changeset 9a2c2a9ec3140b6c54c9ef9d994311f114128ee3 by Ryan Hileman in
branch 'master':
bpo-42800: add audit hooks for f_code and tb_frame (GH-24182)
https://github.com/python/cpython/commit/9a2c2a9ec3140b6c54c9ef9d994311
Steve Dower added the comment:
Sure, I can do that.
--
___
Python tracker
<https://bugs.python.org/issue42800>
___
___
Python-bugs-list mailing list
Unsub
Change by Steve Dower :
--
pull_requests: +24427
pull_request: https://github.com/python/cpython/pull/25736
___
Python tracker
<https://bugs.python.org/issue42
Steve Dower added the comment:
New changeset 87655e2cf58c543914ea05ebe5a0377441da1ef2 by Steve Dower in branch
'master':
bpo-42800: Rename AUDIT_READ to PY_AUDIT_READ (GH-25736)
https://github.com/python/cpython/commit/87655e2cf58c543914ea05ebe5a037
Change by Steve Dower :
--
pull_requests: +24428
pull_request: https://github.com/python/cpython/pull/25737
___
Python tracker
<https://bugs.python.org/issue42
Steve Dower added the comment:
The 3.9 backport is a bit different from what's in master, so would appreciate
someone double-check it. It should go back to 3.8 just fine.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
> The problem is with Python debugger and third-party tools - we can't make
> changes there.
You can report the issue to them, though. They may not realise that they're
using realpath() in scenarios when their users do not want links to be res
Steve Dower added the comment:
Yes, let's move it into the init function.
--
___
Python tracker
<https://bugs.python.org/issue43434>
___
___
Python-bugs-l
Steve Dower added the comment:
Hi Marwan
If you look in your %TEMP% directory for the log file you attached, you'll find
some more similar log files. Could you attach those as well? One of them will
have the actual issue in it.
--
___
P
Steve Dower added the comment:
New changeset c96cc089f60d2bf7e003c27413c3239ee9de2990 by Erlend Egeberg
Aasland in branch 'master':
bpo-43434: Move sqlite3.connect audit events to sqlite3.Connection.__init__
(GH-25818)
https://github.com/python/cpyt
Steve Dower added the comment:
We could get this one in after beta 1 anyway, but sure, it's in.
The backports are going to have to be manual, I suspect...
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs
Steve Dower added the comment:
This is the full error message (and sorry I just saw that you put it on
pastebin in the first post).
MSI (s) (18:04) [13:13:04:342]: SECREPAIR: Hash Database:
C:\Windows\Installer\SourceHash{1C17C2CE-B315-4C1C-885A-E37181C7368E}
MSI (s) (18:04) [13:13:04:342
Steve Dower added the comment:
Thanks, Erlend! Appreciate how quickly you got onto that, and the quality of
your work.
--
___
Python tracker
<https://bugs.python.org/issue43
Steve Dower added the comment:
New changeset cbb7b9ed4a6069a2cb2e2f809926c2cfa332a493 by Erlend Egeberg
Aasland in branch 'master':
bpo-43434: Clean up sqlite3.connect() after GH-25818 (GH-25823)
https://github.com/python/cpython/commit/cbb7b9ed4a6069a2cb2e2f809926c2
Steve Dower added the comment:
New changeset ad73d1657ca3591b1dd1d15bb80ce83ca7fc3223 by Erlend Egeberg
Aasland in branch '3.9':
bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__
(GH-25818)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 10665ac37313560fe87460cf4a5c26677049bf62 by Erlend Egeberg
Aasland in branch '3.8':
bpo-43434: Move sqlite3.connect audit events to sqlite3.Connection.__init__
(GH-25818)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset bb2f3ff7a8f0c3565ccc1946dba7e09a3f7dc209 by Steve Dower in branch
'3.9':
bpo-42800: Add audit events for f_code and tb_frame (GH-24182)
https://github.com/python/cpython/commit/bb2f3ff7a8f0c3565ccc1946dba7e0
Steve Dower added the comment:
> Making sysconfig look at sitecustomize seems like the wrong approach.
I mean, you're literally customizing the site, so having it be done from
sitecustomize doesn't seem terribly wrong. But I agree, I'd rather see the code
in sitecustomi
Steve Dower added the comment:
Yes, I saw some of the latest changes in the PR.
My biggest concern is with the bare "import _vendor_config", which I'd prefer
to have restricted to a fixed location, rather than being influenced by
environment variables and other options. We
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Correct. It does, however, write to the lookaside space, which Windows will map
back if you access it.
So reading HKLM\Software\Python\PythonCore\3.9 will return all the values that
would be there. It's only enumeration that doesn't work. I've r
Steve Dower added the comment:
The best option for restricting the import while still having it be a Python
import is to find the file (if it's present in the expected location under
sys.whatever), and then use importlib to import it:
https://docs.python.org/3/library/importlib
Steve Dower added the comment:
> I'd rather not have a new option here ...
Perhaps what I'm suggesting here is that I don't see any reason for "sudo pip
install ..." into a distro-installed Python to ever need to work, and would be
quite happy for it to just fail
Steve Dower added the comment:
Would "pip install --user ..." in a Docker container also work, though?
Presumably all the filesystem paths are being redirected anyway, so is there a
difference?
(My assumption is that "--user" would essentially become the default if
Steve Dower added the comment:
> "pip install as root" will need to continue to work and thus distros
> need to get a way to make sure that it doesn't corrupt the system
> installed packages
Excuse my ignorance, but does "as root" imply that there's
Steve Dower added the comment:
>> The best option for restricting the import while still having it be a Python
>> import is to find the file (if it's present in the expected location under
>> sys.whatever), and then use importlib to import it:
>> http
Steve Dower added the comment:
The return type of a ctypes function is set by whoever is accessing it. If that
is you, then you should do:
ctypes.windll.kernel32.VirtualAlloc.restype = ctypes.c_void_p
If it's not you, can you point out which code is getting this wrong? ctypes
defaul
Steve Dower added the comment:
Looks like it was always getting lucky in the past, as sys.path requires
strings, and the "path" argument here is an alternative to it. The cache was
definitely not working as intended.
So while it's not clearly documented anywhere (other t
Steve Dower added the comment:
To be clear, I'll get to this when I can, but if someone else wants to write
the fix I'm happy to review and merge. Don't wait for me to do this one just
because I'm assigned.
--
versions: +Python 3.11
__
Steve Dower added the comment:
> I can reproduce it on latest master running on Linux.
Interesting. Perhaps my actual change was to cause it to raise an error
earlier (outside of a handler)? Which would mean that the Path object
was always failing before, just silently.
Arguably we sho
Steve Dower added the comment:
It's almost certainly due to that change, though I'd be interested to see a
more realistic repro.
For the repro shown, you really ought to be clearing the importer cache as well
when you remove a search path (as implied by chdir with a relati
Steve Dower added the comment:
Yeah, you're probably right. That effect was not noticed when implementing it.
We should update the fix in 3.9 and 3.8 to limit it to .pyd's on Windows to
protect against the security risks, but leave other import types loaded with
relative paths
Steve Dower added the comment:
Fundamentally I don't have an issue with the audit hook. My only concern would
be if there's anything that an application may do to _respond_ to a stall (e.g.
is this valuable for applying backpressure? etc.)
If it's purely diagnostic, and
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue44076>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I still don't think the patch goes anywhere near far enough to be useful.
Most likely we should preface that section with a "we recommend using a
third-party build backend for your package, such as ... and refer to
packaging.python.org for
Change by Steve Dower :
--
keywords: +patch
pull_requests: +24675
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26025
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 23822e2c654e950bcfa563e27b99bcb46187ac8b by Steve Dower in branch
'3.9':
bpo-44070: No longer eagerly makes import filenames absolute, except for
extension modules (GH-26025)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +24678
pull_request: https://github.com/python/cpython/pull/26028
___
Python tracker
<https://bugs.python.org/issue44
Change by Steve Dower :
--
pull_requests: +24679
pull_request: https://github.com/python/cpython/pull/26029
___
Python tracker
<https://bugs.python.org/issue44
Steve Dower added the comment:
New changeset b4884083aed9bfec22c4da0e0223ad6a04a4bef2 by Steve Dower in branch
'3.9':
bpo-44070: Clarify NEWS message to specify the version when the behaviour was
introduced (GH-26029)
https://github.com/python/cpyt
Change by Steve Dower :
--
pull_requests: +24692
pull_request: https://github.com/python/cpython/pull/26052
___
Python tracker
<https://bugs.python.org/issue44
Steve Dower added the comment:
Thanks for the patch!
I don't think this meets the 3.8 bar now, but if Łukasz wants it then it should
be easy.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
>> Usually this error occurs due to PATH conflicts.
>
> Python 3.8 and above does not use PATH when importing extension modules
For this issue, the PATH conflict would be that "pip" and "python" refer to
different Python inst
Steve Dower added the comment:
I didn't mean to change it. Maybe bpo did it automatically?
There are a few ways to get multiple Python installs that could lead to
launching the wrong one through PATH. --user is one of the least likely.
--
status: open ->
Change by Steve Stagg :
--
nosy: +stestagg
___
Python tracker
<https://bugs.python.org/issue44184>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Stagg added the comment:
I've found that it's reproducible if you run flake8 on a file that just
contains:
`a.b`
whereas:
`a`
and
`a(b)`
don't seem to trigger the error.
The object being cleaned up when the segfault appears, seems to be a subcl
Steve Stagg added the comment:
I got the same result from a bisect:
11159d2c9d6616497ef4cc62953a5c3cc8454afb
--
___
Python tracker
<https://bugs.python.org/issue44
Steve Stagg added the comment:
So, for me, the single line from 11159d that causes the problem is this:
pprint.py:
import dataclasses as _dataclasses
Obviously importing dataclasses here is having some side-effect
--
___
Python tracker
<ht
Steve Dower added the comment:
> I've found that it's reproducible if you run flake8 on a file that just
> contains: `a.b`
ISTR there were some changes made to assigning attributes on AST classes
recently? I forget who did them, but I remember discussing it during the
s
New submission from Steve Dower :
Python on Windows currently has no values in sysconfig to locate the lib files
for building. Though these are very predictable (for now), it would be nice to
have them in the same place as for other platforms.
I propose defining the following config vars in
Steve Dower added the comment:
Should actually be:
LIBPL=Path(sysconfig.get_config_var("installed_base")) / "libs"
--
___
Python tracker
<https://bug
Steve Dower added the comment:
Thanks! This is a great idea.
I'd prioritise adding support to the Store app first, as that's easier to
manage (we're not having to modify files owned by other apps outside of our
install directory). But no reason we couldn't extend the
Steve Dower added the comment:
I can't reproduce these on my own (Windows) machine either.
Looking at the output, I think the tests are just going to be inherently
flakey. It's not testing the specific scenario directly enough, and relying
heavily on implicit synchronization.
W
Steve Dower added the comment:
> But 3.9 and 3.8 are not failing on test_ssl, so do something has clearly
> changed. Are the failing tests new?
They're flakey in the sense that they're not failing reliably, when they
clearly should be :)
If something changed about how
Steve Dower added the comment:
Thanks, Eric.
Anyone may feel free to create and release their own MSI distro of CPython. I
don't even mind if you use the binaries from our releases, as those are signed
and your users will be able to know that they aren't modified (it's a li
901 - 1000 of 6138 matches
Mail list logo
