Steve Dower added the comment:
For the next build, test_codecencodings_iso2022, test_random, test_sax and
test_tools should all pass, as the .gitattributes file excludes those files
from conversion. I'm still in favour of hardening the tests.
test_pcbuild_rc should be skipped. I don&#x
Changes by Steve Dower :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue30716>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I wonder if the custom action to run _ensurepip isn't running as admin... that
would be the only thing I can think of.
Can you try running the installer with:
msiexec /l*vx log.txt /i path_to.msi
Then attach the generated log.txt file? We might be able t
Steve Dower added the comment:
What is the impact of this error? I know of people who are relying on the
manifest who have not raised any issue, so perhaps it isn't actually that
important?
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
The relevant lines are just above the ones you posted, but I can't view the
attachment from my phone so I'll have to look later.
Seems like the custom action is running as the original user and not admin.
This should just be a flag on the command, th
Steve Dower added the comment:
You're going to get build failures without the C++ tooling anyway, and msbuild
should find previous installs that are compatible.
What is your system setup that causes this failure when you expect su
Steve Dower added the comment:
I suspect that should be filed as a bug against VS 2017 - I'll do that when I
get to work on Monday.
Our workaround should be to check for that targets file and keep searching if
it's not found.
Your best workaround is to start the build from t
Steve Dower added the comment:
Unless you've got an example of this causing actual issues, it should only go
into 3.7.
All platforms supported by Windows guarantee atomicity for aligned,
pointer-sized reads and writes, but there appear to be memory fencing semantics
in here too. I
Steve Dower added the comment:
> Would there be any interest of implementing them for MSVC/ARM as well
Sure, since you're there. It's not easy to test, but I know people who are
doing it, so it'll get noticed eventually.
Maybe there's some sort of stress test we can
Steve Dower added the comment:
The bug is MSBuild 15.0 should be able to locate earlier versions of VC, even
if you haven't installed it for VS 2017.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
There are *many* more fixes required than just these. We're not prepared to
take the changes into 2.7 at this stage, and we don't want to encourage people
to think that MSVC 14.0 or later are supported when we know that it's
incomplete.
I'
Steve Dower added the comment:
We tried it at one point, but it made very little difference because we don't
use the Windows heap for most allocations. IIRC, replacing Python's optimised
allocator with the LFH was a slight performance regression, but I'm not sure
the benchmark
Steve Dower added the comment:
New changeset 5b8f972e093157cc55185841db9ad33fa332a641 by Steve Dower (Steve
(Gadget) Barnes) in branch 'master':
bpo-30362 : Add list options to launcher. (#1578)
https://github.com/python/cpython/commit/5b8f972e093157cc55185841db9ad3
Steve Dower added the comment:
New changeset 5b8f972e093157cc55185841db9ad33fa332a641 by Steve Dower (Steve
(Gadget) Barnes) in branch 'master':
bpo-30362 : Add list options to launcher. (#1578)
https://github.com/python/cpython/commit/5b8f972e093157cc55185841db9ad3
Steve Dower added the comment:
Thanks, Steve!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
New changeset 9f3bdcb643623e07497af2fc35f0496c2302f1be by Steve Dower (Segev
Finer) in branch 'master':
bpo-23451: Fix socket deprecation warnings in socketmodule.c (#2318)
https://github.com/python/cpython/commit/9f3bdcb643623e07497af2fc35f049
Steve Dower added the comment:
There is only one deprecation warning left in current builds:
..\Modules\expat\xmlparse.c(796): warning C4996: 'getenv': This function or
variable may be unsafe. Consider using _dupenv_s instead. To disable
deprecation, use _CRT_SECURE_NO_WARNINGS.
Steve Dower added the comment:
New changeset 7526cadd64566725ffc56071a7208828a46ddbd8 by Steve Dower (Segev
Finer) in branch 'master':
bpo-30726: Also fix pyexpat.vcxproj (#2375)
https://github.com/python/cpython/commit/7526cadd64566725ffc56071a72088
Steve Dower added the comment:
How far back does it need to be ported? Just to 3.5?
--
stage: -> backport needed
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
It doesn't even fix a warning - only suppresses it. Since there is no behavior
change at all, I'm not inclined to backport any further than is trivial.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
It's certainly exploitable for remote code execution if user data allows
embedded nulls (can you URL encode %00?). The fixes look fine and shouldn't
cause any new issues, though I thought that fsencode() already rejected
embedded nulls - maybe I
Steve Dower added the comment:
There's nothing that needs to block the release as far as I'm concerned. The
main fix was that I needed a fresh clone on my build machine to pick up the
gitattribute changes.
The other bug is still open to enhance some tests and skip one in the rel
Steve Dower added the comment:
I wouldn't be opposed to seeing it tried again, but I have no strong opinion. I
don't think this is a major performance bottleneck right now.
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
> I like decreasing the number of warnings. It helps to detect new warnings,
> and so to prevent bugs.
The approach used to suppress this warning will also suppress other warnings
that might be fixable. Hard to say it's definitely a good thing i
Steve Dower added the comment:
I hope you notice I'm not against this particular change. I'm just voicing a
general belief that suppressing an entire category of warnings for a whole
project is not necessarily an improvement.
In future, and when applied to our own project files, ex
Steve Dower added the comment:
Arguably it isn't even against the documented behavior, since a component
starting with a slash an absolute path.
I'd be in favor of preserving the drive when encountering a component starting
with a separator. Not sure of the value in changing the b
Steve Dower added the comment:
> since a component starting with a slash *is not* an absolute path.
--
___
Python tracker
<http://bugs.python.org/issu
New submission from Steve Dower:
To save time and improve reliability while building CPython, we should
pre-build and sign OpenSSL and Tcl/Tk binaries and make it a binary dependency.
Our slightly-patched sources will still be available, and it will be relatively
easy for people to download
Changes by Steve Dower :
--
pull_requests: +2753
___
Python tracker
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30251>
___
___
Steve Dower added the comment:
@Zach - FYI, this will make it unnecessary to run prepare_ssl.bat when checking
in updated sources. Rather, this script now requires Perl to do the entire
build, so we don't have to have any difference between our source bundle and
the original OpenSS
Steve Dower added the comment:
Sure, but then I'll resolve it as rejected :)
The solution does not need an install target. That's not the point - we have
separate projects and scripts for that.
--
___
Python tracker
<http://bu
Steve Dower added the comment:
There's absolutely no risk of ignoring later parameters or raising a ValueError
here, so please don't let those cloud the discussion.
The behaviour of Python 3.6 seems to be correct for every case except:
>>> os.path.join("C:\\dir
Steve Dower added the comment:
New changeset c40ad03bf2693b4af539978f1274e57b85367547 by Steve Dower (Segev
Finer) in branch 'master':
bpo-30731: python.manifest fix (#2328)
https://github.com/python/cpython/commit/c40ad03bf2693b4af539978f1274e5
Changes by Steve Dower :
--
pull_requests: +2765
___
Python tracker
<http://bugs.python.org/issue30731>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset d8e522f7cf8d59993acae9409b6af0ee9a35038f by Steve Dower in branch
'3.6':
bpo-30731: python.manifest fix (#2328) (#2699)
https://github.com/python/cpython/commit/d8e522f7cf8d59993acae9409b6af0
Changes by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.7
___
Python tracker
<http://bugs.python
Steve Dower added the comment:
Fair point. I was thinking of how chdir handles it, but of course that's
relative to the cwd on D, so the rest of the path on C is ignored. D:dir2 is
correct.
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
Zach opted out of reviewing right now, so I went ahead and pushed my builds to
the GitHub repos so that AppVeyor can run.
It built and ran fine (which I'm not surprised about), but it was only 1-2
minutes faster on AppVeyor (which I _am_ surprised about).
Steve Dower added the comment:
New changeset 68d663cf85d1ac5eaf83482eed39c0a6f8093601 by Steve Dower in branch
'master':
[bpo-30916] Pre-build OpenSSL and Tcl/Tk for Windows (#2688)
https://github.com/python/cpython/commit/68d663cf85d1ac5eaf83482eed39c0
Steve Dower added the comment:
The buildbot failures currently being blamed on issue30916 are actually due to
this issue - we actually need Python 3.6 on these machines in order to download
the new externals, and they don't have it and we can't get it via
Steve Dower added the comment:
The buildbot failure blamed on this issue is actually due to issue30450 - it's
the first time we've added a new external, and so the inability to download
Python via Powershell on Windows 7 is the problem
Changes by Steve Dower :
--
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Steve Dower :
--
pull_requests: +2797
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
My PR adds a small script to use requests.get/urlretrieve with any version of
Python to get nuget.exe.
Theoretically, we *could* use this to download everything, but I'd rather
minimize our exposure to insecure downloads for machines that don't alr
Steve Dower added the comment:
The best response is to notify Bitdefender so they can fix their signatures.
Python is commonly used in malware, and so some parts of it are often
misidentified as unique to some detected virus. By reporting the name of the
virus and providing the actual file to
Steve Dower added the comment:
New changeset 588836d3e646c2bcb3473cda7c5f6a1e0ff2c2e9 by Steve Dower in branch
'master':
bpo-30450: Adds alternate download approach for nuget.exe (#2737)
https://github.com/python/cpython/commit/588836d3e646c2bcb3473cda7c5f6a
Steve Dower added the comment:
Compilation still fails, as some of the buildbots don't have py.exe either.
At this stage, our choices are either to fix the buildbots, most easily by
copying py.exe into PATH, or to check nuget.exe (4MB) into the source
repository. (I guess we can cover
Steve Dower added the comment:
We can't assume git.exe is available either (build from sdist/hggit/.zip),
though I guess we can also use it as a fallback. At least on the buildbots
it'll be there.
--
___
Python tracker
<http://bu
Steve Dower added the comment:
> we used to mandate the presence of a svn install
And we regretted that so much that we changed away from it :)
When discussing this changeover plan, Zach and I decided we needed a fallback
requiring only OS dependencies. In this case, the Powershell depende
Steve Dower added the comment:
> How do you get CPython source code if git is not available?
Go to GitHub and click the "Download" button, or select any sdist from our
downloads page, or use Mercurial+hggit, or Dulwich directly, or a mirror/fork
on any VCS you like. There are p
Changes by Steve Dower :
--
pull_requests: +2799
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Unfortunately, "install " is often a blocking requirement for many
developers (typically the ones who get paid well to do this), so I'd rather
have no requirements.
Currently we achieve this if PowerShell is up to date or Python+py.exe are
ins
Steve Dower added the comment:
New changeset efa26bcd5085279fc4e9ae96d052272a5214c2bd by Steve Dower in branch
'master':
bpo-30450: Fall back to git.exe if no Python is found. (#2739)
https://github.com/python/cpython/commit/efa26bcd5085279fc4e9ae96d05227
Steve Dower added the comment:
The buildbots have already successfully built, so I'm declaring this and
issue30916 resolved.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http:
Steve Dower added the comment:
> use the preexisting convention of the HOST_PYTHON envvar that was used prior
> to the recent merged PRs
Is that an actual convention? I didn't see any other references, so I figured
Zach had
Steve Dower added the comment:
Hmm... looks like there's another way to fail I didn't account for that goes
down a different path in the batch file. I'll try being less clever.
--
___
Python tracker
<http://bugs.pyt
Changes by Steve Dower :
--
pull_requests: +2804
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
assignee: zach.ware -> steve.dower
resolution: fixed ->
stage: resolved -> commit review
status: closed -> open
___
Python tracker
<http://bugs.python
Steve Dower added the comment:
Yeouch, it's been causing AppVeyor builds to get stuck, and then they time out
after an hour.
Luckily mine is up next in a minute or so, so I'll try to merge quickly and
avoid anyone else getting held up.
I also restored HOST_PYTHON in the PR, as a fa
Steve Dower added the comment:
Ah, there's also a nuget.org outage affecting AppVeyor (but not me because I'm
in Italy and so connecting to the EU mirror automatically) -
https://appveyor.statuspage.io/
When that recovers it should be fine again. The workaround for those without
py
Steve Dower added the comment:
New changeset 5feda33a35d9413e2073411b848dc49d94c57497 by Steve Dower in branch
'master':
bpo-30450: Fix logic for retrying nuget.exe download (#2744)
https://github.com/python/cpython/commit/5feda33a35d9413e2073411b848dc4
Changes by Steve Dower :
--
pull_requests: +2809
___
Python tracker
<http://bugs.python.org/issue30540>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Zach - did this get backported to 2.7 or 3.5? It doesn't look like it.
--
stage: commit review -> backport needed
___
Python tracker
<http://bugs.python.org
Changes by Steve Dower :
--
pull_requests: +2810
___
Python tracker
<http://bugs.python.org/issue30450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Dower :
--
pull_requests: -2809
___
Python tracker
<http://bugs.python.org/issue30540>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset e99d3a52a50b3f836fb9fb88f317aacddd494858 by Steve Dower in branch
'3.6':
[3.6] bpo-30450: Improved logic for obtaining dependencies (#2751)
https://github.com/python/cpython/commit/e99d3a52a50b3f836fb9fb88f317aa
Changes by Steve Ward :
--
nosy: +smheidrich
___
Python tracker
<http://bugs.python.org/issue30618>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Steve Ward :
--
nosy: +planet36 -smheidrich
___
Python tracker
<http://bugs.python.org/issue30618>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I have a separate PR out that fixes this one, just waiting on Zach to review
(but since it only touches the more obscure release files, it's rare for anyone
but me to have an opinion).
The script is supposed to take the build path rather than the archite
Steve Dower added the comment:
The nuget package doesn't suffer from this - why not? Should you have been
using the full layout rather than the embedding layout?
--
___
Python tracker
<http://bugs.python.org/is
Steve Dower added the comment:
That's the PR I meant (on phone today, so navigating gh is out). If you look
through history you'll see it's mostly a revert of a revert, at least for that
script.
--
___
Python tracker
<http
Steve Dower added the comment:
The "op_slot == 96" looks suspicious - how is this value actually supposed to
be calculated?
--
___
Python tracker
<http://bugs.python.o
Steve Dower added the comment:
New changeset e7bc7aac3d4a7d92aa5913006b0198820882ca59 by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Fix a warning in Python/getargs.c (#2890)
https://github.com/python/cpython/commit/e7bc7aac3d4a7d92aa5913006b0198
Changes by Steve Dower :
--
pull_requests: -2894
___
Python tracker
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
That buildbot has recovered with other changes, so I'm closing this.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Steve Dower added the comment:
New changeset 679b566622ec811c5e5d580f6a538f7a43006e05 by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Fix some Windows x64 compiler warnings (#2492)
https://github.com/python/cpython/commit/679b566622ec811c5e5d580f6a538f
Steve Dower added the comment:
New changeset 5cff6379797967faabbb834a9eb154c3f0839489 by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Fixed _ssl module warnings (#2495)
https://github.com/python/cpython/commit/5cff6379797967faabbb834a9eb154
Steve Dower added the comment:
New changeset a80e985c493d2ab9df0832c99d9ddb798d2e66cf by Steve Dower (Segev
Finer) in branch 'master':
bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c (#2904)
https://github.com/python/cpyt
Changes by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30222>
___
___
Steve Holden added the comment:
IIRC sockets can be marked as inheritable or not. It seems to me it would be a
useful enhancement to allow the same determination for the pipes.
--
nosy: +holdenweb
___
Python tracker
<http://bugs.python.
Steve Dower added the comment:
Correct. This is already in newer installers.
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Steve Dower added the comment:
The embeddable ZIP is not an "install" - it's a tool for including in your own
application.
Run the actual installer and try again, or use the package on nuget.org if you
need to achieve zero system impact (which it sounds like you don't
Steve Dower added the comment:
Sounds like the right fix. We should increase the maximum path length though,
since 3.6 and later can work with much longer paths on Win10 through normal
APIs and without prefix.
--
___
Python tracker
<h
Steve Dower added the comment:
Please file separate bugs for each of your concerns, and ensure Python 3.6/3.7
and 2.7 are separate as these are fundamentally different installers and will
have different bugs.
Other versions will not be changed at this point.
--
resolution
Steve Dower added the comment:
Can you link to those guidelines please? Microsoft release plenty of software
with version numbers over 256.
Also, since people already rely on the current scheme, we'd need a very
compelling reason to break them. I don't believe you've mad
Steve Dower added the comment:
There's an existing bug for the registration going to the wrong place. It
requires changes to the Wix toolset to resolve. No need to conflate it with
this issue.
As far as I can tell, the problem here is just the version string displayed in
Program
Steve Dower added the comment:
This probably means that your system failed to install the C Runtime, but not
badly enough that it actually reported an error.
First try rebooting, and if that doesn't work then search for the VisualC++
2015 Redistributable installer and run
Steve Dower added the comment:
This issue is about A.
B has a separate issue. C will not be changed. Please don't bother bringing
them up again here, it's just a distraction.
--
components: +Installation
priority: normal -> low
type: behavior -> enhancement
versi
Changes by Steve Dower :
--
title: Windows Installer Product Version 3.6.2150.0 Offset By 0.0.150.0 ->
Windows Installer Product does not include micro version in display name
___
Python tracker
<http://bugs.python.org/issu
Steve Dower added the comment:
The prebuilt binaries have not, and the OpenSSL change has functional
implications and should not be (unless someone wants to make the security
justification, but right now I think it's a theoretical rather than an actual
benefit). The TclTk build could be
Steve Dower added the comment:
Looking at your log, you clearly have some sort of configuration blocking
installers or else corruption somewhere on your system. There really isn't
enough information available for me to be able to tell.
Perhaps you have a virus scanner running that is blo
Changes by Steve Dower :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue31148>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
Okay, if that's the way you want to go. Be aware that the old MSI code is gone
though, so rebuilding it will not be trivial. Though if you do, there are a few
people who would find it more convenient, so you may be able to enlist help
maintaining it (we d
Steve Dower added the comment:
Your final file layout needs to match any of our standard ones. On my phone now
so I'm not going to write them all out (will do it later if you need), but you
need to put your .exe in the same location as the python.exe for the runtime
you're using (o
Steve Dower added the comment:
It also breaks .zip file distribution, which I'm fairly sure we do explicitly
support by virtue of having "python36.zip" in sys.path by default. And the
".pyc-only in a zip file" distribution is *totally* busted :) (and also
offici
Steve Dower added the comment:
> when we changed installers was that when we also fixed the
> security/permissions problems with the install dir
Yes, but the permissions issue here isn't the install directory - it is
probably the TEMP directory or some other system restriction. It&
Steve Barnes added the comment:
Having done some checks for the practicality of auto documenting library items
with a -m command line usage I have to say that it will not be so simple.
Many of the library items that provide useful functionality, including zipfile
& tarfile, are impleme
New submission from Steve Barnes:
I would like to add to the command line of both tarfile and zipfile interface
some additional options that I believe to be useful.
1. Wildcard filename matching for archiving
2. Recursive archiving (with excludes)
3. Append to archive option
4. Compression
Steve Dower added the comment:
Perhaps the more important question is whether 2to3 really needs to dynamically
generate a list of fixers or if that should have been stopped due to YAGNI.
There are only a few modules in the stdlib, and it doesn't seem to support
proper namespace package
2901 - 3000 of 6138 matches
Mail list logo
