Steve Dower added the comment:
I think Vinay gets to make the call, but I also agree that some sort of error
handling by default makes sense for logging. Especially now that it's (about to
be) easier to override the default.
FWIW, I'd leave the default arguments as None and just
Steve Dower added the comment:
Windows does not have fork, and so the fork functionality is not built into it
(PyOS_AfterFork() is empty).
You will need to report this to mod_wsgi to be able to build without fork
support.
--
resolution: -> third party
stage: -> resolved
Steve Dower added the comment:
You should have a set of log files in %TEMP%. Can you zip those up and attach
them here?
Pip may be failing to install for some reason, and while this ought to be
reported, it is not supposed to cause the entire installation to fail
Steve Dower added the comment:
Isn't the point that device_encoding(FD) gets the encoding of the specified
file? In this case stdout?
It seems odd that chcp doesn't actually update the console code page here, as
that is its entire purpose. Perhaps TextIOWrapper is actually g
Steve Dower added the comment:
Hmm... interesting.
Thanks for the heads-up, I think I know what this may be (there's a conditional
planning stage in the bootstrapper that is probably being skipped on Modify).
I'll take a look when I get a chance.
--
assignee: ->
Steve Dower added the comment:
New changeset 00f6493084c385033fe5574314223217d9a26672 by Steve Dower (Paul
Monson) in branch 'master':
bpo-37288: Fix Windows build when --no-tkinter is specified (GH-14096)
https://github.com/python/cpython/commit/00f6493084c385033fe55743142232
Steve Dower added the comment:
Has anyone tried building with the newer SQLite and confirmed that the tests
and any scenarios they use still work?
We don't currently have a SQLite expert to do these kinds of things.
--
___
Python tracker
&
Steve Dower added the comment:
Thanks, Paul!
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
The canonical source of versions used on Windows is in PCbuild/python.props
I'll pull the 1.1.1c sources into cpython-source-deps and run a build. If all
goes smoothly, we can consider it, but I don't have a huge amount of time for
CPython this week
Change by Steve Dower :
--
pull_requests: +14003
pull_request: https://github.com/python/cpython/pull/14161
___
Python tracker
<https://bugs.python.org/issue34
Steve Dower added the comment:
I haven't fully tested this, but a suitable test using ctypes might look like:
py = ctypes.PyDLL("", handle=sys.dllhandle)
missing = {name for name in EXPECTED_NAMES if not hasattr(py, name)}
# assert &#x
Steve Dower added the comment:
New changeset d8e3a8af775d683c606f3618d04f2be4e97ac3c0 by Steve Dower in branch
'2.7':
bpo-34631: Updated OpenSSL to 1.0.2s in Windows installer (GH-14161)
https://github.com/python/cpython/commit/d8e3a8af775d683c606f3618d04f2b
Change by Steve Dower :
--
pull_requests: +14005
pull_request: https://github.com/python/cpython/pull/14163
___
Python tracker
<https://bugs.python.org/issue34
Steve Dower added the comment:
The tests seem to pass fine for 1.1.1c against master, so I'll merge that and
see if the backport is also okay.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset a268edd6a411480281222b1fdb0f78053434d17f by Steve Dower in branch
'master':
bpo-34631: Updated OpenSSL to 1.1.1c in Windows installer (GH-14163)
https://github.com/python/cpython/commit/a268edd6a411480281222b1fdb0f78
Change by Steve Dower :
--
pull_requests: +14007
pull_request: https://github.com/python/cpython/pull/14165
___
Python tracker
<https://bugs.python.org/issue34
Steve Dower added the comment:
New changeset c28c1358245b9fe42e9559c34eae01befce73a1f by Steve Dower (Miss
Islington (bot)) in branch '3.8':
bpo-34631: Updated OpenSSL to 1.1.1c in Windows installer (GH-14163)
https://github.com/python/cpython/commit/c28c1358245b9fe42e9559c34eae01
Steve Dower added the comment:
I just pushed sources with tag sqlite-3.28.0.0, so now anybody should be able
to submit a CPython PR for it.
--
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
Ned - the 3.7 backport seems to be okay (PR 14165). Do we want it?
--
___
Python tracker
<https://bugs.python.org/issue34
Steve Dower added the comment:
Ah, that's what ctypes.pythonapi is :) I looked at PyDLL first and figured it
out from there.
Should we add a regression test to avoid this happening in the future?
--
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
New changeset 14bac0088271d0a5c428e3468ef94fe7c73e93f7 by Steve Dower in branch
'3.7':
bpo-34631: Updated OpenSSL to 1.1.1c in Windows installer (GH-14163)
https://github.com/python/cpython/commit/14bac0088271d0a5c428e3468ef94f
Steve Dower added the comment:
I'm still seeing this, maybe 1 in 20 builds, so it's semi-random. A new
deadlock, maybe?
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
> If we reintroduce it, why not put it back at its previous place, to provide
> ABI compatibility?
I agree. If compatibility matters here, then we should add new elements at the
end.
> First of all, we longer care about ABI compatibility of PyTypeOb
Steve Dower added the comment:
> Don't confuse *ABI* and *API* compatibility. For *API* compatibility, it
> doesn't matter where we put tp_print.
Don't worry, I'm not. (Though I did blur the lines for the sake of a
tongue-in-cheek reply to your comment. Probably
Steve Dower added the comment:
> Personally, I don't think that your "read of it" in #msg345990 is relevant to
> the discussion of the PR (I don't mean this in a bad way).
It's relevant to the *existence* of the PR, because when you follow through the
rest o
Change by Steve Dower :
--
pull_requests: +14057
pull_request: https://github.com/python/cpython/pull/14219
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 43b97ae15c8cbb8c383314bb75c867d0f2f34376 by Steve Dower in branch
'3.7':
bpo-37156: Fix libssl DLL tag in MSI sources (GH-14219)
https://github.com/python/cpython/commit/43b97ae15c8cbb8c383314bb75c867
Steve Dower added the comment:
If we should put in the workaround for 3.8, how does that make it okay to
remove in 3.9? It's been deprecated since 3.0 already, so if we can't remove it
after eight releases, I don't see how it's consistent to remove it after a
ninth. Onc
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14075
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/14240
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
assignee: -> steve.dower
type: -> compile error
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/i
Steve Dower added the comment:
> Can you give a least an argument of why that's better than putting back
> tp_print at the end?
Minimal change, that's why. If there are compatibility issues with the current
change that we need to fix, then we should make the least inc
Steve Dower added the comment:
New changeset 12f1c726d8328e5e096c35c36901f6d19bc942d3 by Steve Dower in branch
'master':
bpo-37333: Ensure IncludeTkinter has a value (GH-14240)
https://github.com/python/cpython/commit/12f1c726d8328e5e096c35c36901f6
Steve Dower added the comment:
Backport will automerge when it's done.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
New changeset f355069a3337711642c3403429afb9faef93f512 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot
(GH-13454)
https://github.com/python/cpyt
Steve Dower added the comment:
> It will break ABI compatibility in any case where vectorcall is used, while
> my proposal of putting tp_print at the end does not.
ABI compatibility with what? We haven't released vectorcall yet, so it has no
compatibili
Steve Dower added the comment:
> a class compiled with 3.7 could subclass a class compiled with 3.8 which uses
> vectorcall.
This isn't a supported scenario though. The only way to mix extension modules
compiled against different Python versions is to use the limited ABI, whic
Steve Dower added the comment:
> I was trying to tell you that already in msg345969 but you insisted in
> msg345988 that we should support that anyway.
I made a general note that "extremely unlikely" isn't unlikely enough to be an
argument.
You'll notice I didn&
Steve Dower added the comment:
> Note that the PR for the other similar issue #37221 has been accepted for
> merging.
I've already explained why that issue is different (it breaks a compatibility
guarantee; this one changes something that was explicitly deprecated).
Petr'
Steve Dower added the comment:
New changeset a1952122a3a20272e4db9e3c6205009a91c73ccf by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Improve ARM32 buildbot scripts (GH-14251)
https://github.com/python/cpython/commit/a1952122a3a20272e4db9e3c620500
New submission from Steve Dower :
The step of generating a MinGW import library for Python releases is very
rarely used, forces us to take extra build dependencies, and is better handled
by the end-users who need it.
We will drop the libpython38.a file from the main distribution, and update
Steve Dower added the comment:
Realising that this may have an impact on
distutils.cygwincompiler.Mingw32CCompiler, but I can't tell from the source
code how/whether it would pick up the pre-packaged libpython38.a. Does anyone
know?
--
components: +Distutils
nosy: +ds
Steve Dower added the comment:
Turns out that using distutils/setuptools with --compiler=mingw32 is just
doomed to fail when it hits get_msvcr(), which has never been updated for
Python 3.5 onwards.
So I think it's probably safe to assume that this scenario isn't a real thing
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14100
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14276
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
> While Cython may be able to respond within the beta period, scientific
> projects that depend on it may lag longer as rebuilds and releases will need
> to happen on PyPI, conda, and conda-forge. Release versioning is critical in
> the science
Change by Steve Dower :
--
pull_requests: +14102
pull_request: https://github.com/python/cpython/pull/14279
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
New changeset 43615485f1222cd9a94421a96cb7110bb52e1b8b by Steve Dower in branch
'3.8':
bpo-36511: Improve ARM32 buildbot scripts (GH-14251)
https://github.com/python/cpython/commit/43615485f1222cd9a94421a96cb711
Steve Dower added the comment:
Yes, I noticed that they changed with OpenSSL 1.1.1a, but as far as I can tell
we didn't do anything to cause that - our build definition is still the same,
and uses "perl Configure VC-WIN64A-masm && nmake".
Is this causing issues? Or is
Steve Dower added the comment:
FWIW, I agree totally with Petr's analysis.
Jeroen's analysis ignores some points, has technical inaccuracies (nobody can
use a static type compiled for 3.7 with 3.8), and is based on precedents that
do not apply to this situation. (All of which I&#x
Steve Dower added the comment:
One thing to note is that if we sign this file, it'll have to bypass the text
substitution step completely to avoid modifying line endings or encoding. So
there could be code changes in venv too.
This would be a great contribution from a PowerShell expert
Steve Dower added the comment:
> I'm curious what you mean here...
msg345409
--
___
Python tracker
<https://bugs.python.org/issue37250>
___
___
Py
Steve Dower added the comment:
> With this fixed, and the PyCode_New -> PyCode_New + PyCode_WithPosArgs fix
> from bpo-37221 merged, then that long tail will get another few years of
> life, and will start emitting deprecation warnings for the part that's
> actually
Steve Dower added the comment:
Thanks! Well spotted.
--
___
Python tracker
<https://bugs.python.org/issue37316>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
New changeset 08286d52b29de604a4b187bf1f0d4209e39c926c by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152)
https://github.com/python/cpyt
New submission from Steve Dower :
We should also (see whether we should) add audit hooks for the following
modules:
* configparser
* crypt
* ensurepip
* ftplib
* glob
* http
* imaplib
* nntplib
* pdb
* poplib
* runpy
* shutil
* smtpd
* smtplib
* socketserver
* sqlite3
* telnetlib
* webbrowser
New submission from Steve Dower :
Since .pth files may contain executable code, we should open them using
io.open_code().
--
messages: 346230
nosy: christian.heimes, steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
title: Use io.open_code for .pth files
Change by Steve Dower :
--
pull_requests: +14112
pull_request: https://github.com/python/cpython/pull/14289
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset f8dd77d36067fd7be614edde1e5e9e7467c450dc by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Fix -u parameters for ARM32 tests (GH-14280)
https://github.com/python/cpython/commit/f8dd77d36067fd7be614edde1e5e9e
Steve Dower added the comment:
New changeset 6c7947713a40851e123493ca0fe8f2791d7ed2a6 by Steve Dower in branch
'3.8':
bpo-37316: mmap.mmap() passes the wrong variable to PySys_Audit() (GH-14152)
https://github.com/python/cpython/commit/6c7947713a40851e123493ca0fe8f2
Change by Steve Dower :
--
pull_requests: +14113
pull_request: https://github.com/python/cpython/pull/14290
___
Python tracker
<https://bugs.python.org/issue36
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset f5690925df897cf45818bf944b28d13f37b9f8ca by Steve Dower in branch
'master':
bpo-37351: Removes libpython38.a from standard Windows distribution (#14276)
https://github.com/python/cpython/commit/f5690925df897cf45818bf944b28d1
Change by Steve Dower :
--
pull_requests: +14122
pull_request: https://github.com/python/cpython/pull/14298
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset f3e38ec7f014557296f6cc7b60a33d65faad1716 by Steve Dower in branch
'3.8':
bpo-36511: Fix -u parameters for ARM32 tests (GH-14280)
https://github.com/python/cpython/commit/f3e38ec7f014557296f6cc7b60a33d
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue37364>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14123
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14299
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14125
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14301
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset fa23bd286fb7719bd7601da0b713457589f5536f by Steve Dower in branch
'3.8':
bpo-37351: Removes libpython38.a from standard Windows distribution (GH-14276)
https://github.com/python/cpython/commit/fa23bd286fb7719bd7601da0b71345
Steve Dower added the comment:
PR 14301 has at least a few hooks for most of the modules above.
I think xmlrpc deserves some, but it is not as immediately obvious where to put
them as for the other modules. smtpd also still needs looking at
Steve Dower added the comment:
> Also, just one question: how could python -m pip work but not pip? What are
> the differences in them?
To answer this, "pip" on its own is essentially like writing the full path to a
specific python.exe and passing "-m pip". If th
Steve Dower added the comment:
New changeset 60419a7e96577cf783b3b45bf3984f9fb0d7ddff by Steve Dower in branch
'master':
bpo-37363: Add audit events for a range of modules (GH-14301)
https://github.com/python/cpython/commit/60419a7e96577cf783b3b45bf3984f
New submission from Steve Dower :
All audit events are marked in the docs with the ".. audit-event::
" syntax.
We should automatically collate these into a single table and generate a new
doc page as part of docs build.
--
assignee: docs@python
components: Documentatio
Steve Dower added the comment:
FWIW, I tried looking into how we can prevent or detect monkeypatching of
"sys.audit", and the answer seems to be that we need to define a custom type
for the sys module and for sys.__dict__.
I'm not prepared to do that yet, and IMHO there ar
Steve Dower added the comment:
Fixing --compiler=mingw32 is left for another bug, if anyone is so motivated.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Awesome! I was just making a start on this too, and it looks like we were doing
nearly identical work. Happy to let you keep going on it!
Some things that I thought would be worth doing:
* combine equivalent events (warn if names match but arguments are
Steve Dower added the comment:
I took your code and made some improvements:
https://github.com/python/cpython/compare/master...zooba:bpo37390
In particular, I added the backlinks from the table (but unfortunately they all
go to the line of text we generate for the ..audit-event directive
Steve Dower added the comment:
New changeset 7fd2ba354ec2304743ffd9ba620e07d113532264 by Steve Dower
(animalize) in branch 'master':
bpo-35360: Update Windows builds to use SQLite 3.28.0 (GH-14179)
https://github.com/python/cpython/commit/7fd2ba354ec2304743ffd9ba620e07
Change by Steve Dower :
--
pull_requests: +14171
pull_request: https://github.com/python/cpython/pull/14354
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
New changeset 0fc14b373398767b4323a7bc2c2310b6218c5b74 by Steve Dower
(animalize) in branch '2.7':
bpo-35360: Update Windows builds to use SQLite 3.28.0 (GH-14182)
https://github.com/python/cpython/commit/0fc14b373398767b4323a7bc2c2310
Steve Dower added the comment:
> According to serge_sans_paille: if ``self->b_ptr`` contains pointer, the
> ``memcpy`` creates sharing, and this is dangerous: if a ``__del__`` happens
> to free the original pointer, we end up with a dangling reference in
> ``new_ptr``. As fa
Steve Dower added the comment:
New changeset 8bd2872adbbc7ed5dd0a7593193c52431ae34c8d by Steve Dower
(animalize) in branch 'master':
bpo-25361: Enable SSE2 instructions for Windows 32-bit build (GH-12438)
https://github.com/python/cpython/commit/8bd2872adbbc7ed5dd0a7593193c52
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 9fc720e5e4f772598013ea48a3f0d22b2b6b04fa by Steve Dower (David K.
Hess) in branch 'master':
bpo-4963: Fix for initialization and non-deterministic behavior issues in
mimetypes (GH-3062)
https://github.com/python/cpyt
Steve Dower added the comment:
Sorry for the delays!
I've merged into master. The backports (3.7, 3.8) are going to need some help,
so I'll take a look at them soon unless someone else gets there first.
--
stage: needs patch -> backport needed
versions: +Python 3.
Change by Steve Dower :
--
pull_requests: +14191
pull_request: https://github.com/python/cpython/pull/14376
___
Python tracker
<https://bugs.python.org/issue4
Change by Steve Dower :
--
pull_requests: +14190
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/14375
___
Python tracker
<https://bugs.python.org/iss
Steve Dower added the comment:
> Should PCbuild/pyproject.vcxproj explicitly import python.props which defines
> it?
It already does :)
This is more likely because the previous build on that buildbot crashed(?) or
because it was aborted during test_multiprocessing:
Steve Dower added the comment:
We should also remove that deprecation warning, as PEP 528 (or was it PEP 529)
undeprecated bytes paths.
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
New changeset 25fbe33b92cd938e809839feaa3fda97e6ad0980 by Steve Dower in branch
'3.8':
bpo-4963: Fix for initialization and non-deterministic behavior issues in
mimetypes (GH-14375)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 2a99fd911ebeecedbb250a05667cd46eca4735b9 by Steve Dower in branch
'3.7':
bpo-4963: Fix for initialization and non-deterministic behavior issues in
mimetypes (GH-14376)
https://github.com/python/cpyt
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pytho
Steve Dower added the comment:
> I suggest to close the issue and see if the bug comes back.
You opened it, so sure :)
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The handle can deliberately live beyond the process, but it does not have to.
If it is closed early then the kernel object will be freed when no handles
remain, which will be at process exit.
So it's a classic __exit__/__del__ case, where both are need
Steve Dower added the comment:
Definitely just an oversight. Thanks for fixing this!
I think it can go to 3.8 as well. Thoughts?
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
It's probably worth at least a post to python-dev to expand the audience, but
unless someone speaks up with some really good reason why they must update to
Python 3.10 without updating their own code then let's deprecate it.
FWIW, even with th
Change by Steve Dower :
--
keywords: +patch
pull_requests: +14218
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14406
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I think my PR is ready. I had to go through and update all the audit-event tags
that existed, since the argument parsing in Sphinx didn't work the way I first
thought it did, but now we can provide a back reference manually (or let it
auto-generate one t
Steve Dower added the comment:
Okay, this definitely used to work, but now it's broken for me too.
What version of Windows are you on (copy-paste from cmd.exe's ver command)?
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
This seems to be a change in Windows at some point, as it still works on one of
my other PCs. I've pinged some colleagues to find out what might have happened,
but it definitely looks like the lack of Read+Execute permission is working
correctly now :(
Steve Dower added the comment:
This looks like because you have Qt installed in one environment and not the
other, so when matplotlib imports it pyinstaller decides to include it.
You'll have to report this to pyinstaller. It's nothing to do with core Python.
--
2601 - 2700 of 6138 matches
Mail list logo
