Steve Dower added the comment:
New changeset ce3a4984089b8e0ce5422ca32d75ad057b008074 by Steve Dower in branch
'master':
bpo-38597: Never statically link extension initialization code on Windows
(GH-18724)
https://github.com/python/cpython/commit/ce3a4984089b8e0ce5422ca32d75ad
Change by Steve Dower :
--
pull_requests: +18114
pull_request: https://github.com/python/cpython/pull/18759
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
Deleting the files is not the right first step.
First, it needs to be changed to a non-required check.
Then, I can use the web UI to disable it starting.
*Then*, we can remove *some* of the files in the directory. Others are used for
the official release, and
Steve Dower added the comment:
> Who is allowed to do that?
Brett did it the first time. I'm having too much trouble with GitHub right now
to find the current admins.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
There's no PR required. We need to change the required check so when I disable
new builds from running it won't break existing PRs.
As for actually changing the files in the repo, I don't see any hurry there. We
can clean up a few of them, and m
Steve Dower added the comment:
Are you sure the required check isn't just for failures? Surely GitHub is
smarter than requiring checks that it can tell aren't required (as it's their
logic to include/exclude, not ours).
If they're not, I now have many internal conta
Steve Dower added the comment:
Looks like it isn't fixed... https://github.com/python/cpython/pull/18774
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Adding a screenshot here so I can point people at it.
Let's not rush into complicating the build steps yet - AP is basically fine. We
should switch back the required checks (@Brett?)
If anything, let's add a "condition: false" to the macOS
Steve Dower added the comment:
It would make the job definition significantly more complicated, and I don't
want to do that just to work around an issue with github until we've got
positive confirmation that the behaviour is intentional and wo
Change by Steve Dower :
--
pull_requests: +18176
pull_request: https://github.com/python/cpython/pull/18818
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
New changeset 31350f9af09dcff7cf6ff4b0a0a7ea595942372e by Steve Dower in branch
'master':
bpo-39837: Disable macOS tests on Azure Pipelines (GH-18818)
https://github.com/python/cpython/commit/31350f9af09dcff7cf6ff4b0a0a7ea
Steve Dower added the comment:
I've disabled macOS builds on Pipelines, so now they're essentially advisory
through the GitHub Actions build.
I also pinged some contacts about the not-very-useful behaviour of required
checks vs. path filters. So will see what they say.
-
Steve Dower added the comment:
Nope, just that I apparently forgot to merge (or forgot to come back after CI
had finished).
Thanks for the reminder!
--
nosy: -miss-islington
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
New changeset 0911ea5c172264eaefa3efe4a1788159c160920d by Maor Kleinberger in
branch 'master':
bpo-39517: Allow runpy.run_path() to accept path-like objects (GH-18699)
https://github.com/python/cpython/commit/0911ea5c172264eaefa3efe4a17881
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Looks like what was actually applied was changed to PyUnicode_DecodeFSDefault,
which was later changed on Windows to be always UTF-8.
They'll need to be normalised throughout Modules/socketmodule.c (I can't tell
at a quick glance which need upd
Steve Dower added the comment:
If someone wants to do the extra work to use the native Windows socket
functions on Windows instead of the POSIX-ey wrappers, that should happen under
a new issue. This bug is for a regression that we ought to fix back as far as
we can.
--
priority
Steve Dower added the comment:
This is an os.lstat() limitation, nothing to do with pathlib.
I'll defer to Eryk for suggestions here, since he probably knows the right
answer already :) (if not, I'll go do the research to figure out what we're
currently missing).
--
Change by Steve Dower :
--
versions: +Python 3.7, Python 3.9
___
Python tracker
<https://bugs.python.org/issue39920>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
Thanks for the heads-up, I'll take a look.
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org
Change by Steve Dower :
--
keywords: +patch
pull_requests: +18269
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18918
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 2dd41740c97bd77695ddcc590caa7f53e76dc35a by Steve Dower in branch
'master':
bpo-39930: Ensure vcruntime140.dll is included in all Windows packages
(GH-18918)
https://github.com/python/cpython/commit/2dd41740c97bd77695ddcc590caa7f
Change by Steve Dower :
--
pull_requests: +18271
pull_request: https://github.com/python/cpython/pull/18920
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
New changeset eede148296bf3b4578b92ed6a07f2733a0f1c341 by Steve Dower in branch
'3.7':
bpo-39930: Ensure vcruntime140.dll is included in all Windows packages
(GH-18918)
https://github.com/python/cpython/commit/eede148296bf3b4578b92ed6a07f27
Steve Dower added the comment:
Ah, both of those buildbots are running Build Tools. Apparently there's a
different layout for those.
Note that the devguide provides instructions that can't be followed with the
Build Tools - you need VS Community (at least):
https://devguide.
Change by Steve Dower :
--
nosy: +steve.dower
nosy_count: 4.0 -> 5.0
pull_requests: +18272
pull_request: https://github.com/python/cpython/pull/18921
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +18273
pull_request: https://github.com/python/cpython/pull/18921
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
Added a PR to make the failure silent, up until we're building a release
package. That way it'll only bother me, and I can make sure that I have the
right VS install.
--
___
Python tracker
<https://bu
Change by Steve Dower :
--
pull_requests: -18272
___
Python tracker
<https://bugs.python.org/issue39330>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue39330>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset fde44ae6d08d3df79554155b1cf079e73a8fabdd by Steve Dower in branch
'master':
bpo-39930: Convert error to warning for more silent failure (GH-18921)
https://github.com/python/cpython/commit/fde44ae6d08d3df79554155b1cf079
Change by Steve Dower :
--
pull_requests: +18291
pull_request: https://github.com/python/cpython/pull/18938
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
Okay, I think I've got an approach that works even on the apparently
misconfigured installs on the buildbots (and some user machines, if this is the
same underlying issue as issue38597).
I wasn't able to reproduce it though, so I have no idea why
Change by Steve Dower :
--
pull_requests: +18311
pull_request: https://github.com/python/cpython/pull/18962
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
New changeset c05e491a69df3fe0a8be91eeddd330792ada6755 by Steve Dower in branch
'3.7':
bpo-39930: Fix MSBuild detection for Build Tools (GH-18938)
https://github.com/python/cpython/commit/c05e491a69df3fe0a8be91eeddd330
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I think PyUnicode_DecodeMBCS(name, strlen(name), "surrogatepass") captures the
intention better, and is less likely to break in the future (apart from all the
ways it's currently broken :) )
You should be right about the
Steve Dower added the comment:
Yeah, this is on me now. Hopefully we can just pull in the new sources and
they'll be fine, but historically it's taken a couple of days/weeks to get the
issues ironed out.
Unfortunately, I'm still on a flaky internet connection (but only for
Steve Dower added the comment:
Hi Lin, please look me up on Teams and we can chat about this. I haven't heard
about this effort and I'd love to know what you're working on.
---
The last error is because the VS Setup team has never updated their package to
include v1
Steve Dower added the comment:
> Instead of passing `_PyRuntimeState` around everywhere, why not just let it
> disappear in time.
Agreed. It's valuable to pass the thread state, but the runtime state should
only be needed to create a new thread state (and arguably no
Steve Dower added the comment:
I'm now hitting this too, on nearly all the compiled modules in the stdlib. One
example:
building '_codecs_jp' extension
x86_64-my-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse
--sysroot=/opt/my-generic/0.0.1-dev/sysroots/core2-64
Steve Dower added the comment:
Trimmed a bit from setup.py here, but I think this is the cause:
def build_extensions(self):
self.srcdir = sysconfig.get_config_var('srcdir')
self.srcdir = os.path.abspath(self.srcdir)
[SNIP]
# Fix up the au
Steve Dower added the comment:
Perhaps sysconfig needs an overhaul to be able to handle _PYTHON_PROJECT_BASE
properly? I see so many values in there that are taken from the running
interpreter (sys.prefix, for example) that ought to come from the
cross-compilation target. Wouldn't sur
Steve Dower added the comment:
So ultimately this is a major sysconfig design flaw, and it likely requires a
rewrite.
The mix of information sources between _sysconfigdata (even when overriding the
name and PYTHONPATH) and the Makefile, and the order in which you can rely them
to be loaded
Steve Dower added the comment:
Thanks for all that work!
We definitely don't want a noisy build to be merged, but if you submit a PR
with only your most confident suppressions then it'll be easier for us to look
at the others and see which are scary
Steve Dower added the comment:
Is that epic line automatically generated? It didn't work for me for some
reason (was trying to launch the built Python, not the host).
Even so, I got to the point of filling in all those values manually while
testing sysconfig, and while I'm
Steve Dower added the comment:
So it's possible that my first few attempts didn't have a matched build of
Python on the host - the cross-build certainly relies on mixing the installed
runtime with the source stdlib, so that could have been an early cause of
issues. I can only su
Steve Dower added the comment:
The values that are used are (apparently) correct, but most of sysconfig is
not. That's very confusing, and makes it difficult to debug. I'm glad I get to
maintain the *other* monster (MSBuild) :)
I would much rather sysconfig had a single variabl
Steve Dower added the comment:
> I think the patch is wrong. why would you want to differentiate between
> native and cross builds?
Because the multiarch headers are incompatible with my SDK's headers, and
because of the -I ordering they override mine. I tried swapping the orde
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue22497>
___
___
Steve Dower added the comment:
> the multiarch approach allows you to install libraries and headers for many
> architectures in the same installation/chroot
That makes sense, but I'm not using it. So presumably I've added a configure
option that I didn't need (either &q
Steve Dower added the comment:
Go ahead. I think you should create three PRs (docs, tests and code), with only
as many tests in the code PR as are needed to keep it passing.
--
___
Python tracker
<https://bugs.python.org/issue32
Steve Dower added the comment:
Main thing we need is a PR (straightforward) and confirming that the relevant
tests all run. We can use the buildbot fleet to make sure that all supported
platforms have the necessary APIs, but it wouldn't surprise me if there's some
weird edge
Steve Dower added the comment:
Thanks for reporting this.
In future, security issues should be reported *first* through
https://www.python.org/dev/security/
*Do not* request a CVE number until we've reviewed it. It causes unnecessary
stress for our users who actually pay attention to
Steve Dower added the comment:
Sorry for missing the pings! My GitHub notifications are a bit of a black hole.
I'll merge it now.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset 79ceccd1ec6ef7e487da2916f32c6f0d1477bd3d by Zackery Spytz in
branch 'master':
bpo-38410: Properly handle PySys_Audit() failures (GH-16657)
https://github.com/python/cpython/commit/79ceccd1ec6ef7e487da2916f32c6f
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Reminding us on here is helpful (for me, anyway).
I just left a couple of suggestions to make sure we handle all the cases.
It's important when you change or add tests that you make sure the test fails
without your fix - otherwise it might not be testin
Steve Dower added the comment:
There's no guarantee that st_ino will be the same as any other queryable value.
Only that it will (hopefully) be unique on that disk.
stat() on Windows is just an approximation of stat() from POSIX - it's not a
reliable way of reading Window
Steve Dower added the comment:
New changeset 676b105111e2399ed400cd13ab113f9aa891760d by Zackery Spytz in
branch 'master':
bpo-8901: Windows registry path is now ignored with the -E option (GH-18169)
https://github.com/python/cpython/commit/676b105111e2399ed400cd13ab113f
Steve Dower added the comment:
I'm 99% satisfied that this change is the right approach (rather than adding a
new option), but we'll have to wait to hear from beta feedback I think.
My main concern is users who pass -E on the command line to avoid environment
variables, but are re
Steve Dower added the comment:
All seems to be fine now.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Some of the events it was supposed to raise are not being raised.
This is likely my fault for not adding the thorough testing in the test suite
at the time (I'm uncovering them now with a different test suite...)
I'll do a thorough review of this
Change by Steve Dower :
--
keywords: +patch
pull_requests: +18595
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19238
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
In my defense(?), it was working fine everywhere except Windows. And I'm pretty
sure I was working in WSL for this change *shrug*
With the PR, it will match the documentation.
--
___
Python tracker
&
Steve Dower added the comment:
New changeset 63ba5cccf484b9ec23dfbf4cf7ffdc833eda98c3 by Steve Dower in branch
'master':
bpo-40121: Fixes audit event raised on creating a new socket (GH-19238)
https://github.com/python/cpython/commit/63ba5cccf484b9ec23dfbf4cf7ffdc
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
pull_requests: +18624
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/19267
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Thanks, Victor!
--
___
Python tracker
<https://bugs.python.org/issue40121>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 3ef4a7e5a7c29e17d5152d1fa6ceeb1fee269699 by Steve Dower in branch
'master':
bpo-40121: Fix exception type in test (GH-19267)
https://github.com/python/cpython/commit/3ef4a7e5a7c29e17d5152d1fa6ceeb
Steve Dower added the comment:
Or we could remove the path filter on GitHub Actions so that all checks run
even for doc-only changes? Then they can be marked as required.
--
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
I'm seeing some numbers that suggest it's even bigger than 7 million, so you
might be deserving of more! Of course, that bandwidth is a donation, so you'll
have to apply to Fastly ;)
Our MSBuild projects are hand-maintained (often by people
Steve Dower added the comment:
> I don't understand how it's possible that the Ubuntu job passed in the GitHub
> action, but failed in Azure Pipelines.
Random network issues, most likely. Those are about the only flakiness I've
seen in recent times.
The OpenSSL cache s
Steve Dower added the comment:
While you're working on these, the most important comparison to make is against
the binaries from our 64-bit release. We've run PGO on those, and from the
stats shown it optimises almost everything for size already. (You can enable
the same profile
Steve Dower added the comment:
The closing parentheses are needed - a PR would be appreciated for that.
The quotes around a variable reference are unnecessary. At a parser level, it
just changes it from a variable reference to a string literal with
substitutions (unlike most shells, which
Steve Dower added the comment:
Either of those fixes look good. I normally use IO.Path personally, which might
be because it's been around longer, but anything that works on VS 2017 and
later should be fine.
--
___
Python tracker
&
Steve Dower added the comment:
What about renaming the base directory in place? Moving things across drives
doesn't help, and we can't reasonably determine a suitable location for temp
files other than by leaving them wher
Steve Dower added the comment:
New changeset 6e623ff9d251e0ce86e9b18a01bfd6f067079d7a by Chris Martinez in
branch 'master':
bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343)
https://github.com/python/cpython/commit/6e623ff9d251e0ce86e9b18a01bfd6
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I've pushed new binaries for OpenSSL 1.1.1f on Windows. I'll try and to the
rest over the weekend, but if someone else wants to do the PCbuild PR feel free.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
In general, no settings rely on both Platform AND Configuration, so you likely
only need to check one or the other.
Look at PCbuild/pyproject.props for the best examples. IIRC, properties are set
assuming Win32/Release, and then we override those that need to
Steve Dower added the comment:
New changeset 7f70456b92c9ff0bcc4df2a2cec213ab2a897591 by Miss Islington (bot)
in branch '3.7':
bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343)
https://github.com/python/cpython/commit/7f70456b92c9ff0bcc4df2a2cec213
Steve Dower added the comment:
New changeset e6685ad05385f8cb492e8e1c7c07889a94517f55 by Miss Islington (bot)
in branch '3.8':
bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343)
https://github.com/python/cpython/commit/e6685ad05385f8cb492e8e1c7c0788
Change by Steve Dower :
--
keywords: +patch
pull_requests: +18721
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/19359
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2 by Steve Dower in branch
'master':
bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)
https://github.com/python/cpython/commit/a1d4dbdfc78e3aed4c245e1810ef24
Change by Steve Dower :
--
pull_requests: +18723
pull_request: https://github.com/python/cpython/pull/19361
___
Python tracker
<https://bugs.python.org/issue40
Change by Steve Dower :
--
pull_requests: +18724
pull_request: https://github.com/python/cpython/pull/19362
___
Python tracker
<https://bugs.python.org/issue40
Steve Dower added the comment:
New changeset 37126e7bd242bce03f3c4f208d8871edd3febcbe by Steve Dower in branch
'3.8':
bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)
https://github.com/python/cpython/commit/37126e7bd242bce03f3c4f208d8871
Steve Dower added the comment:
New changeset e7a47c23dd25a144ec4afc2db46393818694926f by Steve Dower in branch
'3.7':
bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)
https://github.com/python/cpython/commit/e7a47c23dd25a144ec4afc2db46393
Change by Steve Dower :
--
pull_requests: -18743
___
Python tracker
<https://bugs.python.org/issue40188>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
I wonder why the "install wamerican" didn't go into the script? It should at
least get the same options as in the script to make sure it doesn't break the
install.
Maybe we should make our own mirror of Ubuntu so that we don't hav
Steve Dower added the comment:
More likely there's been another change to the events that are listened to by
multiprocessing, which didn't update the overall limit.
File a new bug, please.
--
___
Python tracker
<https://bu
Steve Dower added the comment:
Maybe something else was installed that put an incompatible _sqlite3.dll on
PATH? Thereby proving the inherent risk of using unsafe DLL load settings :)
If we're not already overriding PATH for the subprocess in this test (should
only need "%
Steve Dower added the comment:
It's probably the sqlite3.dll dependency that's failing, not the _sqlite3.dll
(originally _sqlite3.pyd) one.
The test is verifying that dependent DLLs are loaded correctly. So I assume in
this case the _sqlite3.dll is being loaded, but it's fi
Steve Dower added the comment:
It might also be a "sqlite3_d.dll". Updated build is
https://dev.azure.com/Python/cpython/_build/results?buildId=60787&view=results
--
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
Found it (and it's kind-of us):
Checking C:\Program Files\Amazon\AWSCLIV2\
*** Found at C:\Program Files\Amazon\AWSCLIV2\sqlite3.dll
*** Found at C:\Program Files\Amazon\AWSCLIV2\_sqlite3.pyd
But I'm not sure why that is getting loaded earlier than t
Steve Dower added the comment:
> Do you have a general estimate or rough idea as to how much slower it would
> be in comparison?
It's one sample point, but compare
https://buildbot.python.org/all/#/builders/129/builds/708 to
https://github.com/python/cpython/runs/571497886
Comp
Steve Dower added the comment:
(+Windows tag)
These should use io.open_code() these days anyway, which always opens in 'rb'.
Could you make that change?
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
Change by Steve Dower :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue40255>
___
___
Python-bugs-list mailing list
Unsubscribe:
1601 - 1700 of 6138 matches
Mail list logo
