Stefan Krah added the comment:
> python version: 2.4.3
I'd suggest to try this with Python 2.6 or later. 2.4 and 2.5 are in
security-fix only mode.
--
nosy: +skrah
versions: -Python 2.5
___
Python tracker
<http://bugs.python.or
Stefan Krah added the comment:
FreeBSD/Qemu: ipv6 is ok, but this fails:
==
FAIL: testGetaddrinfo (__main__.GeneralModuleTests)
--
Traceback (most recent call
Stefan Krah added the comment:
> Btw, socket.has_ipv6 documentation should be more clear about the fact
> that having it == True doesn't necessarily mean IPv6 is actually
> supported.
Strange indeed. socket.has_ipv6 checks whether ENABLE_IPV6 was defined at
compile time. But
Stefan Krah added the comment:
> But why is that an attribute of a socket object?
Please pretend I did not write this. ;)
Anyway, getaddrinfo() on FreeBSD/Qemu gives this:
>>> socket.getaddrinfo('localhost', 21)
[(2, 2, 17, '', ('127.0.0.1', 21)
Stefan Krah added the comment:
Committed a conservative version implementing part 1) in r82017 (2.6) and
r82019 (3.1). Part 2) can be enabled by uncommenting a couple of lines in
setup.py.
The buildbots look good, but I'm setting this to 'pending' in case
someone would like par
Stefan Krah added the comment:
Py_CHARMASK should return a non-negative integer. As I understand it:
tokenizer.c:tok_get around line 1368:
while (Py_ISALNUM(c) || c == '_') {
c = tok_nextc(tok);
}
1) tok_nextc(tok) returns EOF (correct).
2) c is an
Stefan Krah added the comment:
You can simulate this on Linux by compiling with:
BASECFLAGS="-funsigned-char"
Then:
Index: Parser/tokenizer.c
===
--- Parser/tokenizer.c (revision 81682)
+++ Parser/tokenizer.c (wo
Stefan Krah added the comment:
Martin v. Löwis wrote:
> > Of course, it is dubious why EOF is not tested separately rather than
> > passing it to Py_ISALNUM(). Micro-optimization? At least a comment
> > should be added.
>
> No, I think this is an error that EOF is
New submission from Stefan Krah :
This feature request is extracted from issue 9020, where Py_CHARMASK(c)
was used on EOF, producing different results depending on whether
__CHAR_UNSIGNED__ is defined or not.
The preferred fix for issue 9020 is to check for EOF before using
Py_CHARMASK, so
Stefan Krah added the comment:
Reopening since test failures are reported on python-dev:
[...]
test_uuid
test test_uuid failed -- Traceback (most recent call last):
File "/private/tmp/Python-2.7rc2/Lib/test/test_uuid.py", line 472, in
testIssue8621
self.assertNotEqual(pa
Stefan Krah added the comment:
It is disputed on http://openradar.appspot.com/radar?id=334401 that
this is an OS bug. If I understand correctly, the test program is
not guaranteed to work if threads are involved. See also:
http://webcache.googleusercontent.com/search?q
Stefan Krah added the comment:
Bill, could you try to add this to the tests and see if they
also fail when you run them standalone?
Index: Lib/test/test_uuid.py
===
--- Lib/test/test_uuid.py (revision 82109)
+++ Lib/test
Stefan Krah added the comment:
Ronald Oussoren wrote:
> Stefan: we already new that, see msg105018.
>
> This issue was closed as fixed because the uuid module contains a workaround
> for this issue (by not using the broken C API on OSX 10.6).
Ok, my comment was partly mean
Stefan Krah added the comment:
Re: EOF checking in Py_ISXXX() for consistency with C functions.
After reflecting on this a bit I think it's ultimately not a good
idea. While it is possible to do the EOF check, the macros would
then take either an int in [EOF, 0-UCHAR_MAX] or a signed/uns
Stefan Krah added the comment:
Patch for ceval.c. If you agree with the macro indentation (starting
in line 815) I can commit it and port it to the other branches.
--
keywords: +patch
nosy: +skrah
Added file: http://bugs.python.org/file17752/trunk-ceval-indent.patch
Stefan Krah added the comment:
Antoine, thanks. ceval.c fixes committed in r82177, r82179, r82181
and r82182.
--
___
Python tracker
<http://bugs.python.org/issue8
New submission from Stefan Krah :
While investigating issue 9020, I noticed that there are several places
where the pyctype.h macros could/should be used.
--
messages: 108505
nosy: eric.smith, skrah
priority: normal
severity: normal
status: open
title: Use macros from pyctype.h
type
Stefan Krah added the comment:
Committed fix in r82191. Thanks Sridhar for tracking this down.
New issues emerging from this one:
1) Simplify Py_CHARMASK: issue 9036
2) Use macros from pyctype.h: issue 9067
Additionally, I noticed that the macros is_potential_identifier* from
py3k
Stefan Krah added the comment:
Antoine Pitrou wrote:
> > Thus,
> > ((unsigned char)((c) & 0xff)) and ((unsigned char)(c)) should produce
> > the same results.
>
> If it's the case, it's probably optimized away by the compiler anyway.
Yes, the asm ou
Stefan Krah added the comment:
> In r61936 the cast was added.
Actually r61987
--
___
Python tracker
<http://bugs.python.org/issue9036>
___
___
Python-
Stefan Krah added the comment:
+1, if the FPU mask is always restored (as I understand, this is the case
now).
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue9
Stefan Krah added the comment:
Mark Dickinson wrote:
> Now that I've finally managed to get gcc 4.4.4 installed on OpenSolaris...
>
> .. I'm still failing to reproduce this bug. :(
>
>
> dicki...@eratosthenes:~/release26-maint$ uname -a
> SunOS eratosthene
Stefan Krah added the comment:
Mark Dickinson wrote:
> I don't *think* this is related to issue 7281. I thought we'd determined that
> that issue
> had nothing to do with copysign itself, and everything to do with what the
> signbit of the
> NaN returned by float(&
Changes by Stefan Krah :
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue9086>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Stefan Krah added the comment:
Mark, gcc-4.4 on Fedora 12 is ok:
[ste...@fedora-amd64 trunk]$ ./python
Python 2.7rc2+ (trunk:82245M, Jun 26 2010, 13:09:14)
[GCC 4.4.3 20100127 (Red Hat 4.4.3-4)] on linux2
Type "help", "copyright", "credits" or "license&qu
Stefan Krah added the comment:
Fedora 12: copysign-bug varies wildly ((GCC) 4.4.3 20100127 (Red Hat 4.4.3-4)):
[ste...@fedora-amd64 trunk]$ gcc -O0 copysign_bug.c -o copysign_bug
[ste...@fedora-amd64 trunk]$ ./copysign_bug
copysign_bug(-0) = 2
copysign_bug(0) = 3
[ste...@fedora-amd64 trunk
Changes by Stefan Krah :
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue9136>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Stefan Krah added the comment:
Mark Dickinson wrote:
> I can't reproduce this on Linux. However, I've seen an informal report of
> something like this happening before. It looks a lot like something
> threading related, but I don't see any threads in what you'
Stefan Krah added the comment:
Still clueless about profile.py, but I think it creates a parallel stack,
and overwriting of locals legitimately occurs in that stack, producing
the Exception.
So it would appear that by design one simply cannot iterate over locals
when using the profile module
Stefan Krah added the comment:
Mark Dickinson wrote:
>
> Mark Dickinson added the comment:
>
> class Context(object):
> def __init__(self):
> for name, val in locals().items():
> setattr(self, name, val)
>
>
> Isn't this dodgy an
Stefan Krah added the comment:
The tracker doesn't handle code when posted by mail. Here's the
code again:
>>> for name, val in locals().items():
... print(locals())
...
{'name': '__builtins__', 'val': , '__builtins__':
, &#
Stefan Krah added the comment:
Mark, the patch looks good. I don't find it ugly, but anyway, here's a
bike shed version. :)
The main point is that I'd like the flags and traps sections to be
set apart visually while compressing the boilerplate.
--
Added file: http://
Stefan Krah added the comment:
Mark, good point about 2.3 compatibility. The unit tests diverge quite a
bit though between 2.5, 2.6 and 2.7.
I like {s: 0 for s in _signals} slightly better here (but I like
dict/list comprehensions in general).
So, the new patch still sets the flags/traps
Changes by Stefan Krah :
Removed file: http://bugs.python.org/file17831/unnamed
___
Python tracker
<http://bugs.python.org/issue9136>
___
___
Python-bugs-list mailin
Stefan Krah added the comment:
In the new patches I reinstated the ternary construct. I think it
would be nice to use dict comprehensions in py3k. People read the
stdlib for guidance, and it would help if ultimately only the most
concise idioms remained in py3k.
If I'm not mistaken,
Changes by Stefan Krah :
Added file: http://bugs.python.org/file17837/issue9136-trunk-3.patch
___
Python tracker
<http://bugs.python.org/issue9136>
___
___
Python-bug
Stefan Krah added the comment:
Éric, I don't think it's that simple. The author still has the copyright,
even if he licensed the files under the contributor agreement.
At the very least you have to leave his name and copyright notice.
--
no
Stefan Krah added the comment:
Alexander, for me the ternary expressions have the advantage that they
take up less vertical space and you have to keep less state in mind.
Mark, I'm sidestepping the dict syntax question and reassign to you :)
--
assignee: skrah -> mark.d
Changes by Stefan Krah :
--
nosy: +roudkerk
resolution: accepted ->
___
Python tracker
<http://bugs.python.org/issue9162>
___
___
Python-bugs-list mai
Stefan Krah added the comment:
I've encountered this a while ago on OpenSolaris. According to the man
page
http://docs.sun.com/app/docs/doc/816-5168/getcwd-3c?a=view
this would be a bug in getcwd():
ERANGE
The size argument is greater than 0 and less than the length of the
pathname
Stefan Krah added the comment:
I agree that there should be a workaround. In py3k the function is
implemented like you suggest.
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/iss
Stefan Krah added the comment:
> There error info is same as Issue7511.
Yes. Issue 7511 will be fixed at some point in distutils2. Closing this
as a duplicate.
--
nosy: +skrah
resolution: -> duplicate
stage: -> committed/rejected
status: open -> close
Stefan Krah added the comment:
I can reproduce this on Ubuntu with Python 2.7 and 3.2.
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue4
Changes by Stefan Krah :
--
title: Problem with tempfile.NamedTemporaryFile on Solaris 10 -> Problem with
tempfile.NamedTemporaryFile
___
Python tracker
<http://bugs.python.org/iss
Stefan Krah added the comment:
[Cc: p...@python.org]
Jesse Noller wrote:
>
> Yes; the copyright has to stay; but the license data can leave afaik.
If R Oudkerk signed the agreement, replacing 'see COPYING.txt' with
'Licensed to PSF under a Contributor Agreement.'
Stefan Krah added the comment:
If I'm not mistaken, the original code was BSD, so in the absence of a
contributor agreement one could include the full BSD license in each
file.
http://pyprocessing.berlios.de/doc/COPYING.html
--
___
Python tr
Stefan Krah added the comment:
Jesse, there's no doubt that you know the original license. :)
I should have been more verbose: My BSD comment was intended for public
consumption. People often think GPL if they see a reference to COPYIN
Stefan Krah added the comment:
The proposed change was for socket_htons() to use ints instead of
unsigned longs. This is the case now, so I'm closing the issue.
--
nosy: +skrah
resolution: -> out of date
stage: unit test needed -> committed/rejected
status: ope
Stefan Krah added the comment:
Yes, it's an issue in py3k. Also, I prefer the behavior of 2.5, but
I'm not sure if that can be changed easily in 2.7.
$ python2.5 -c 'print((1, 2, 3))' > /dev/full
close failed: [Errno 28] No space left on device
$ python2.7 -c 'p
Stefan Krah added the comment:
I'm almost certain that this has been fixed in issue 1544279. Setting
to pending. Brian, if you disagree, you can still respond to this issue.
--
nosy: +skrah
resolution: -> duplicate
stage: unit test needed -> committed/rejected
superseder:
Changes by Stefan Krah :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue1441984>
___
___
Python-bugs-list mailing list
Unsubscri
Stefan Krah added the comment:
It looks like the error is cleared in Python/pythonrun.c, line 321:
if (fout != NULL && fout != Py_None) {
tmp = PyObject_CallMethod(fout, "flush", "");
if (tmp == NULL)
PyErr_Clear();
el
Stefan Krah added the comment:
Confirmed with release27-maint, icc 11.0.
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue7616>
___
___
Python-bug
Stefan Krah added the comment:
Antoine, the patch works well.
--
___
Python tracker
<http://bugs.python.org/issue7616>
___
___
Python-bugs-list mailing list
Unsub
Stefan Krah added the comment:
David, was this fixed in r75702 by any chance? Currently the test is just
skipped in 3.1.
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue7
Stefan Krah added the comment:
Duplicate of issue 7511.
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue9224>
___
___
Python-bugs-list mailin
Stefan Krah added the comment:
Confirmed with 3.1. Raising priority, since it seems to be one of those
bytes/string issues that prevent people from using py3k.
--
nosy: +skrah
priority: normal -> high
___
Python tracker
<http://bugs.pyth
Changes by Stefan Krah :
--
stage: unit test needed -> needs patch
___
Python tracker
<http://bugs.python.org/issue7761>
___
___
Python-bugs-list mai
Stefan Krah added the comment:
I've been looking at this again because of new duplicate reports.
I think we need to distinguish between amd64 and x86_amd64/x86_ia64.
But using arch="x86" as the default parameter would do fine.
Re unit test:
The test will only work if 64-bit
Stefan Krah added the comment:
New version for the patch with a default value for arch.
--
Added file: http://bugs.python.org/file17951/vcvars3.diff
___
Python tracker
<http://bugs.python.org/issue7
Stefan Krah added the comment:
New version of the patch with a default value for arch.
--
Added file: http://bugs.python.org/file17952/vcvars3.diff
___
Python tracker
<http://bugs.python.org/issue7
Changes by Stefan Krah :
--
___
Python tracker
<http://bugs.python.org/issue7511>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/m
Changes by Stefan Krah :
Removed file: http://bugs.python.org/file17952/vcvars3.diff
___
Python tracker
<http://bugs.python.org/issue7511>
___
___
Python-bugs-list mailin
Stefan Krah added the comment:
ipatrol, thanks, I forgot to change ValueError. New patch attached.
--
Added file: http://bugs.python.org/file17959/vcvars4.diff
___
Python tracker
<http://bugs.python.org/issue7
Stefan Krah added the comment:
3.2 is affected as well.
--
___
Python tracker
<http://bugs.python.org/issue7761>
___
___
Python-bugs-list mailing list
Unsub
New submission from Stefan Krah :
In test_bytes Valgrind finds two reads with negative array indices.
test_bytes
==7341== Invalid read of size 1
==7341==at 0x4EDA24: fastsearch (fastsearch.h:143)
==7341==by 0x4F170E: bytearray_find_internal (find.h:42)
==7341==by 0x4F17BD
Changes by Stefan Krah :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue9236>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
New submission from Stefan Krah :
Not sure if this is valid or if there is some internal trickery that Valgrind
isn't aware of. If it's the latter, perhaps an entry to
Misc/valgrind.supp could be added.
test_bug1175396 (__main__.UTF32Test) ... ==26861== Conditional jump or move
Stefan Krah added the comment:
Here's a patch. If PATH_MAX is defined, a static buffer is used. I left
the arbitrary path length version since apparently some systems (HURD)
don't have any limits for PATH_MAX.
In case anyone is mystified how to reproduce the original problem on
O
Stefan Krah added the comment:
> const int iorder[4] = {0, 1, 2, 3};
const isn't possible, iorder is modified later on. Adding the array
dimension did not change anything.
Making everything const (see below) did not change anything either.
I presume that Valgrind regards qq[2] or
Stefan Krah added the comment:
Thanks for having a look at the patch!
Antoine Pitrou wrote:
> I'm not sure I understand the cause of the problem. Does getcwd() fail on
> Solaris when the path length is higher than PATH_MAX, even if you pass a big
> enough buffer?
If the path
Stefan Krah added the comment:
Antoine Pitrou wrote:
> > If you change 1027 to 4098, the test currently fails on Linux, too. I
> > think the only
> > reason why it never failed is that most systems have PATH_MAX=4096.
>
> Ok, then perhaps the test should be fixed?
Stefan Krah added the comment:
Just as a reminder: In 2.x, posix_getcwdu() also uses a buffer of size
1026.
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue9
Stefan Krah added the comment:
OpenBSD has the same getcwd() bug. It was uncovered by raising
current_path_length
to 4099 in test_posix.
Here is a new patch that enables the changed posix_getcwd() function
on Solaris and OpenBSD only. I've tested the patch on Linux, OpenSolaris,
OpenBS
Stefan Krah added the comment:
Antoine, thanks! Committed in release27-maint (r82853).
Zsolt, could you confirm that issue9185-2.patch (or r82853) works for you?
--
___
Python tracker
<http://bugs.python.org/issue9
Stefan Krah added the comment:
In Ubuntu I can build just fine with lt_LT.UTF-8. So perhaps this problem
should be addressed in Gentoo.
--
___
Python tracker
<http://bugs.python.org/issue7
Stefan Krah added the comment:
So you have garbage from stderr in readline_termcap_lib. Since that's
useless anyway (no matter what locale is set), let's check the return
value of os.system().
The attached patch skips readline linkage detection if ldd fails. In
that case, linking wi
Stefan Krah added the comment:
I think this is invalid. Please run:
>>> from subprocess import Popen
>>> Popen("echo $SHELL", executable="/bin/bash", shell=True)
/bin/bash
>>>
--
nosy: +skrah
___
Py
Stefan Krah added the comment:
Isn't just the name of the executable wrong? /bin/bash is
executed all right, but the name is set to "/bin/sh".
Index: Lib/subprocess.py
===
--- Lib/subprocess.py (revision
Stefan Krah added the comment:
Here's a patch with a test case. Without the fix in subprocess.py,
the test prints:
==
FAIL: test_specific_shell (__main__.POSIXProcessTes
Changes by Stefan Krah :
--
keywords: +patch
Added file: http://bugs.python.org/file18016/issue9265.patch
___
Python tracker
<http://bugs.python.org/issue9
Stefan Krah added the comment:
Hm, /bin/sh should actually be removed from the list. It might be a
symlink to csh, for example.
I know this isn't an exhaustive test. If /bin/bash or /bin/ksh don't
exist, the test is skipped. I thought this is good enough, since the
majority of system
Changes by Stefan Krah :
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> Stringlib fastsearch can read beyond the front of an array
___
Python tracker
<http://bugs.pytho
Changes by Stefan Krah :
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue8530>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Stefan Krah added the comment:
Here is a minimal example how to reproduce this issue, extracted from
UTF32LETest.
valgrind --db-attach=yes --suppressions=Misc/valgrind-python.supp ./python
uninitialized.py
It seems that in Lib/codecs.py the equivalent of "\x00".decode('
Stefan Krah added the comment:
Ok, here's a more comprehensive test. Comments:
1) Instead of emulating 'which' one could use find_executable
from distutils.spawn. But this feels wrong.
2) Skip the test if the primary issue cannot be tested.
3) Exercise the test for
Changes by Stefan Krah :
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue1615158>
___
___
Python-bugs-list mailing list
Unsubscribe:
Stefan Krah added the comment:
ldd return value check committed in r82927, r82928, r82929 and r82930.
Thanks for reporting this!
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Stefan Krah added the comment:
Matt, if you still follow this: Does this problem exist in 2.6/2.7/NetBSD?
I think this should be set to pending.
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue1533
Stefan Krah added the comment:
The usage of char in bp_bool will not work if char is unsigned. Hopefully
that is the cause.
--
keywords: +patch
nosy: +skrah
Added file: http://bugs.python.org/file18041/bp_bool.patch
___
Python tracker
<h
Changes by Stefan Krah :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue9277>
___
___
Python-bugs-list mailing list
Unsubscri
Stefan Krah added the comment:
'sizeof y' is obviously wrong now in the memcpy. Next attempt.
--
Added file: http://bugs.python.org/file18043/bp_bool2.patch
___
Python tracker
<http://bugs.python.
Changes by Stefan Krah :
Removed file: http://bugs.python.org/file18041/bp_bool.patch
___
Python tracker
<http://bugs.python.org/issue9277>
___
___
Python-bugs-list mailin
Stefan Krah added the comment:
[Marc-Andre]
> Why not just make the casts in those cases explicit instead of
> using Py_CHARMASK ?
I agree that this would be the cleanest solution. It's harder to get
someone to review a larger patch though.
Antoine, I understood that you woul
Stefan Krah added the comment:
> Now I'm puzzled about why the test passes for ' open
___
Python tracker
<http://bugs.python.org/issue9277>
___
___
Python-bug
Stefan Krah added the comment:
Mark Dickinson wrote:
> > Somewhere along the way native_table is used instead of lilendian_table,
> > so np_bool is called.
>
> Hmm. This doesn't alleviate my confusion. :)
I suppose I sounded a bit like the Oracle of Delphi here. :)
I
Stefan Krah added the comment:
David, thanks for all the comments! - The string/bytes issue was caused
by the fact that p.stdout is only opened in text mode when
universal_newlines=True.
Committed fix in r82971, r82972, r82973 and r82974. I'll close this issue
if all buildbots a
Stefan Krah added the comment:
Thanks for testing! - Fix also backported to release26-maint in r82975.
Closing this one.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Stefan Krah added the comment:
Antoine, thanks! Committed in r82966, r82968, r82969 and r82970.
Could we fix the unicodeobject.c bug on the fly? I think the patch should
do, unless non-ascii digits are supported. But in that case several other
changes would be needed.
--
Added file
New submission from Stefan Krah :
Seemingly random failures in test_logging on 2.6/ubuntu-wide. See:
http://www.python.org/dev/buildbot/builders/AMD64 Ubuntu wide 2.6/builds/777
[fail]
http://www.python.org/dev/buildbot/builders/AMD64 Ubuntu wide 2.6/builds/778
[ok
2601 - 2700 of 3396 matches
Mail list logo
