Change by Mark Shannon :
--
pull_requests: +29287
pull_request: https://github.com/python/cpython/pull/31104
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29288
pull_request: https://github.com/python/cpython/pull/31105
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29291
pull_request: https://github.com/python/cpython/pull/31108
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
Can you reproduce this failure with just Python?
If not, with just cryptography and not tox?
--
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
Qiang Zhang, thanks for fixing this.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Mark Shannon :
https://bugs.python.org/issue45340 and
https://github.com/python/cpython/pull/28802 allowed "virtual" object dicts
(see faster-cpython/ideas#72 for full details).
In order for this to work, we need to keep the insertion order on the values.
T
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +29367
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31191
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset 062460e8fd54e53c9a1a6f175ef49c9d730851b8 by Mark Shannon in
branch 'main':
bpo-46072: Improve LOAD_METHOD stats (GH-31104)
https://github.com/python/cpython/commit/062460e8fd54e53c9a1a6f175ef49c
Change by Mark Shannon :
--
pull_requests: +29368
pull_request: https://github.com/python/cpython/pull/31197
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 4b603f628207b380a8a2f22d7ff5d2dbb0853e2e by Victor Stinner in
branch 'main':
bpo-46670: Remove unused macros in ceval.c (GH-31196)
https://github.com/python/cpython/commit/4b603f628207b380a8a2f22d7ff5d2dbb0853e2e
--
nosy: +Ma
Mark Shannon added the comment:
New changeset 9c979d7afd839abbb080028bdfeb73727e5cf633 by Mark Shannon in
branch 'main':
bpo-46072: Merge dxpairs into py_stats. (GH-31197)
https://github.com/python/cpython/commit/9c979d7afd839abbb080028bdfeb73
Change by Mark Shannon :
--
pull_requests: +29381
pull_request: https://github.com/python/cpython/pull/31211
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 25db2b361beb865192a3424830ddcb0ae4b17318 by Mark Shannon in
branch 'main':
bpo-46675: Allow object value arrays and split key dictionaries larger than 16
(GH-31191)
https://github.com/python/cpyt
Change by Mark Shannon :
--
pull_requests: +29398
pull_request: https://github.com/python/cpython/pull/31228
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset f71a69aa9209cf67cc1060051b147d6afa379bba by Mark Shannon in
branch 'main':
bpo-46072: Output stats as markdown with collapsible sections. (GH-31228)
https://github.com/python/cpython/commit/f71a69aa9209cf67cc1060051b147d
Change by Mark Shannon :
--
title: Improve effeciency of PRECALL/CALL instructions -> Improve efficiency of
PRECALL/CALL instructions
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +29401
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31231
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
pull_requests: +29404
pull_request: https://github.com/python/cpython/pull/31234
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29419
pull_request: https://github.com/python/cpython/pull/31250
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29420
pull_request: https://github.com/python/cpython/pull/31251
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29422
pull_request: https://github.com/python/cpython/pull/31254
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 2cea8c29cf975a8ad7d8c3ff19d1e836c2d54707 by Mark Shannon in
branch 'main':
bpo-46532: Reduce number of memory writes to update call_shape.kwnames.
(GH-31231)
https://github.com/python/cpython/commit/2cea8c29cf975a8ad7d8c3ff19d1e8
Change by Mark Shannon :
--
pull_requests: +29425
pull_request: https://github.com/python/cpython/pull/31259
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset d7a5aca982def155a9255893cefcc1493c127c9c by Brandt Bucher in
branch 'main':
bpo-45923: Add `RESUME_QUICK` (GH-31244)
https://github.com/python/cpython/commit/d7a5aca982def155a9255893cefcc1
Change by Mark Shannon :
--
pull_requests: +29481
pull_request: https://github.com/python/cpython/pull/31324
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29482
pull_request: https://github.com/python/cpython/pull/31326
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 3be1a443ca8e7d4ba85f95b78df5c4122cae9ede by Mark Shannon in
branch 'main':
bpo-46724: Use `JUMP_ABSOLUTE` for all backward jumps. (GH-31326)
https://github.com/python/cpython/commit/3be1a443ca8e7d4ba85f95b78df5c4
Change by Mark Shannon :
--
pull_requests: +29501
pull_request: https://github.com/python/cpython/pull/31352
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
pull_requests: +29503
pull_request: https://github.com/python/cpython/pull/31354
___
Python tracker
<https://bugs.python.org/issue46
New submission from Mark Shannon :
This is getting really annoying.
It takes longer to fix all the heavily coupled and poorly written tests in
test_dis than to make the real changes.
Tiny changes in the calling sequence, or reordering CFGs, cause huge diffs in
the test_dis module.
No one
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +29519
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31369
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
New changeset d4e4ef107a9fea257981d7701f023177b704a44f by Mark Shannon in
branch '3.10':
[3.10] bpo-46724: Use `JUMP_ABSOLUTE` for all backward jumps. (GH-31326)
(GH-31354)
https://github.com/python/cpython/commit/d4e4ef107a9fea257981d7701f0231
Change by Mark Shannon :
--
pull_requests: +29523
pull_request: https://github.com/python/cpython/pull/31373
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
nosy: +brandtbucher, iritkatriel
___
Python tracker
<https://bugs.python.org/issue46760>
___
___
Python-bugs-list mailing list
Unsub
Mark Shannon added the comment:
New changeset c3ce7781e3afe6f2dec5eef8e87fd5a664519ae9 by Saul Shanabrook in
branch 'main':
bpo-46724: Fix dis support for overflow args (GH-31285)
https://github.com/python/cpython/commit/c3ce7781e3afe6f2dec5eef8e87fd5
Mark Shannon added the comment:
New changeset e2c28616ce6c3cdb1013c415125220a0b86b86a1 by Nikita Sobolev in
branch 'main':
bpo-46709: check eval breaker in specialized `CALL` opcodes (GH-31404)
https://github.com/python/cpython/commit/e2c28616ce6c3cdb1013c415125220
Mark Shannon added the comment:
New changeset cf345e945f48f54785799390c2e92c5310847bd4 by Mark Shannon in
branch 'main':
bpo-46329: Change calling sequence (again) (GH-31373)
https://github.com/python/cpython/commit/cf345e945f48f54785799390c2e92c
Change by Mark Shannon :
--
pull_requests: +29595
pull_request: https://github.com/python/cpython/pull/31465
___
Python tracker
<https://bugs.python.org/issue46
New submission from Mark Shannon :
Computing whether an instruction is the first on a line (for tracing) in the
interpreter is complicated and slow. Doing it in the compiler should be simpler
and has no runtime cost.
Currently we decide if the current instruction is the first on a line, by
Mark Shannon added the comment:
New changeset 59585d6b2ea50d7bc3a9b336da5bde61367f527c by Mark Shannon in
branch 'main':
bpo-46329: Streamline calling sequence a bit. (GH-31465)
https://github.com/python/cpython/commit/59585d6b2ea50d7bc3a9b336da5bde
Change by Mark Shannon :
--
pull_requests: +29626
pull_request: https://github.com/python/cpython/pull/31496
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 424023efee5b21567b4725015ef143b627112e3c by Brandt Bucher in
branch 'main':
bpo-46329: Fix test failure when `Py_STATS` is enabled (GH-31511)
https://github.com/python/cpython/commit/424023efee5b21567b4725015ef143
Mark Shannon added the comment:
New changeset 375a56bd4015596c0cf44129c8842a1fe7199785 by Brandt Bucher in
branch 'main':
bpo-45885: Don't un-adapt `COMPARE_OP` when collecting stats (GH-31516)
https://github.com/python/cpython/commit/375a56bd4015596c0cf44129c
Change by Mark Shannon :
--
nosy: +Mark.Shannon
nosy_count: 1.0 -> 2.0
pull_requests: +29655
pull_request: https://github.com/python/cpython/pull/31531
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
We need to decide what to do about dis.
I don't think we should have a `show_cache` option, as the caches are
meaningless junk without quickening (maybe we should drop the CACHE opcode, and
just use zeroes).
Instead we should have a `show_quickened` o
Change by Mark Shannon :
--
pull_requests: +29673
pull_request: https://github.com/python/cpython/pull/31552
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset a52d2528a405c1e2bfeb6470cb3313a5338dc45f by Dennis Sweeney in
branch 'main':
bpo-46823: Implement LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE superinstruction
(GH-31484)
https://github.com/python/cpython/commit/a52d2528a405c1e2bfeb6470cb3313
Mark Shannon added the comment:
New changeset 2a6ece572ca38f989fca66f4c053cb16550bccd4 by Mark Shannon in
branch 'main':
bpo-45107: Specialize `LOAD_METHOD` for instances with dict. (GH-31531)
https://github.com/python/cpython/commit/2a6ece572ca38f989fca66f4c053cb
Mark Shannon added the comment:
Stefan,
f_lineno can be None for some opcodes, but there shouldn't be trace events if
it is.
E.g.
>>> def f():
... try:
... 1/0
... finally:
... pass
...
>>> list(f.__code__.co_lines())
[(0, 2, 1), (2, 4, 2),
Mark Shannon added the comment:
New changeset 0f41aac109c45aa468c432f798947c54d4178b3d by Brandt Bucher in
branch 'main':
bpo-46841: Use *inline* caching for `BINARY_OP` (GH-31543)
https://github.com/python/cpython/commit/0f41aac109c45aa468c432f798947c
Mark Shannon added the comment:
Making this a release blocker, as we really cannot leave this half finished for
the release.
Shouldn't be a problem, as we'll have it done in a week or so.
--
___
Python tracker
<https://bugs.python.o
Change by Mark Shannon :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue46841>
___
___
Python-bugs-list mai
Mark Shannon added the comment:
New changeset c579243eb62d3182c84004cd72dcf6ef59100643 by Irit Katriel in
branch 'main':
bpo-46808: remove NEXT_BLOCK() from compile.c (GH-31448)
https://github.com/python/cpython/commit/c579243eb62d3182c84004cd72dcf6ef59100643
--
nosy: +Ma
Change by Mark Shannon :
--
pull_requests: +29697
pull_request: https://github.com/python/cpython/pull/31575
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 424ecab494d538650ba34937cdd710094ccb2275 by Brandt Bucher in
branch 'main':
bpo-46841: Use inline caching for `UNPACK_SEQUENCE` (GH-31591)
https://github.com/python/cpython/commit/424ecab494d538650ba34937cdd710
Mark Shannon added the comment:
New changeset 4558af5a8f8e56a9b0dc11f6e834c47e0fd05f9e by Mark Shannon in
branch 'main':
bpo-46841: Move the cache for `LOAD_GLOBAL` inline. (GH-31575)
https://github.com/python/cpython/commit/4558af5a8f8e56a9b0dc11f6e834c4
Change by Mark Shannon :
--
pull_requests: +29743
pull_request: https://github.com/python/cpython/pull/31618
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 7820a5897e7762df23bff1cbe749652130654a08 by Brandt Bucher in
branch 'main':
bpo-46841: Use inline caching for `COMPARE_OP` (GH-31622)
https://github.com/python/cpython/commit/7820a5897e7762df23bff1cbe74965
Mark Shannon added the comment:
New changeset c60e6b6ad7aaf9c72035ff9fb1575e2710aeb4b4 by Mark Dickinson in
branch 'main':
bpo-46311: Clean up PyLong_FromLong and PyLong_FromLongLong (GH-30496)
https://github.com/python/cpython/commit/c60e6b6ad7aaf9c72035ff9fb1575e
Mark Shannon added the comment:
New changeset 3b0f1c5a710eff289dc44bec972dbaea353cc54f by Mark Shannon in
branch 'main':
bpo-46841: Use inline cache for `BINARY_SUBSCR`. (GH-31618)
https://github.com/python/cpython/commit/3b0f1c5a710eff289dc44bec972dba
Mark Shannon added the comment:
I've outlined the requirements for a frame stack API at
https://github.com/faster-cpython/ideas/issues/309.
The problem with adding an API for PyFrameObject (beyond simple getters) is
that it makes assumptions about the frame stack that aren't valid
Mark Shannon added the comment:
Is there some way to mark something as not blocking an alpha release, but
blocking a beta release?
Everything is working at the moment, but not so efficiently.
--
___
Python tracker
<https://bugs.python.
Mark Shannon added the comment:
We should be done with this by early next week, if you can wait.
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
assignee: -> Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue46891>
___
___
Python-bugs-list mailing list
Unsubscrib
Mark Shannon added the comment:
Dennis, thanks for bisecting this.
--
___
Python tracker
<https://bugs.python.org/issue46891>
___
___
Python-bugs-list mailin
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +29763
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/31643
___
Python tracker
<https://bugs.python.org/issu
Mark Shannon added the comment:
Good to know, although "deferred blocker" is somewhat vague about when it is
deferred until.
OOI, does it become a "blocker" again once you've done the alpha release, or
what stops it being deferred past the beta
Mark Shannon added the comment:
It's not an UNPACK_SEQUENCE slowdown, it's a silly benchmark ;)
https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_unpack_sequence/run_benchmark.py#L6
What I *think* is happening is that the inline cache takes t
Mark Shannon added the comment:
New changeset 751c9ed801ad1189272ca10f0749bfc9d49b5038 by Mark Shannon in
branch 'main':
bpo-46891: Fix creating a new instance of a module subclass with slots
(GH-31643)
https://github.com/python/cpython/commit/751c9ed801ad1189272ca10f0749bf
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Mark Shannon added the comment:
Ned, is this fixed for you now?
--
___
Python tracker
<https://bugs.python.org/issue46389>
___
___
Python-bugs-list mailin
Change by Mark Shannon :
--
keywords: +patch
pull_requests: +29776
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31658
___
Python tracker
<https://bugs.python.org/issu
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Mark Shannon :
--
pull_requests: +29777
pull_request: https://github.com/python/cpython/pull/31659
___
Python tracker
<https://bugs.python.org/issue46
Change by Mark Shannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46389>
___
Mark Shannon added the comment:
Which debugger? Which version of Python?
Please provide all the steps required to reproduce, otherwise there is little
we can do.
--
nosy: +Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue46
Mark Shannon added the comment:
New changeset 03c2a36b2bd2d4469160d1607619ee144175d753 by Mark Shannon in
branch 'main':
bpo-46903: Handle str-subclasses in virtual instance dictionaries. (GH-31658)
https://github.com/python/cpython/commit/03c2a36b2bd2d4469160d1607619ee
Mark Shannon added the comment:
This is a bit of a tricky one.
The problem is that the line number for an instruction is used for two purposes.
1. To calculate the line number in frame.f_lineno for tracebacks and events
2. By dis to determine which lines are present and where they start.
If
Mark Shannon added the comment:
This is an API change.
I agree that the API is not what it should be, but we can't change it without
breaking an unknown amount of 3rd party code that uses it.
--
nosy: +Mark.Shannon
___
Python tracker
&
Mark Shannon added the comment:
New changeset 586b24d3be1aec5d2568b070a249b4d75e608782 by Brandt Bucher in
branch 'main':
bpo-46841: Fix error message hacks in `GET_AWAITABLE` (GH-31664)
https://github.com/python/cpython/commit/586b24d3be1aec5d2568b070a249b4
Change by Mark Shannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Mark Shannon added the comment:
Why so coarse?
Getting a notification for every change of a global in module, is likely to
make use the use of global variables extremely expensive.
```
var = 0
CONST = 1
def foo(...):
...
```
I may well want to be notified if `foo` or `CONST` gets
New submission from Mark Shannon :
https://github.com/python/steering-council/issues/102 (definitely not PEP 651
;))
We should implement efficient stack checks on those platforms that allow us to
introspect stack extents.
Windows and posix systems allow us to do this.
C allows addresses of
Change by Mark Shannon :
--
stage: resolved ->
___
Python tracker
<https://bugs.python.org/issue46389>
___
___
Python-bugs-list mailing list
Unsubscrib
Mark Shannon added the comment:
Ronald, does PR 31658 fix your issue?
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue46903>
___
_
Mark Shannon added the comment:
I don't think this needs to block the alpha release
--
priority: release blocker -> deferred blocker
___
Python tracker
<https://bugs.python.org
Mark Shannon added the comment:
Please reopen this bug as the fix is wrong.
This fix merely hides the symptoms of _PyType_Lookup returning a dead object,
by calling PyType_Modified() frequently, thus ensuring the type method cache is
almost always invalidated.
This results in a significant
Mark Shannon added the comment:
Absolutely. subtype_dealloc deals with deallocation of subtype
*instances*, not the types themselves.
> Maybe we can try and explore the reference graph again?
This sort of thing is one of the reasons that the cycle GC does not call
any finalisers. Attempt
Mark Shannon added the comment:
What's happening is that the cycle GC calls type_clear to clear the type, but
the method-cache is not invalidated.
I have added a call to PyType_Modified in type_clear (as well as type_set_name
and type_set_qualname, which also modify the type).
Pat
Mark Shannon added the comment:
Beat me to it, Antoine!
Don't forget type_set_name and type_set_qualname.
--
___
Python tracker
<http://bugs.python.org/is
Mark Shannon added the comment:
Antoine Pitrou wrote:
> Antoine Pitrou added the comment:
>
>> I have added a call to PyType_Modified in type_clear (as well as
>> type_set_name and type_set_qualname, which also modify the type).
>
> Can __name__ and __qualname__
New submission from Mark Shannon :
test_clear_dict_in_ref_cycle in test_module only works by coincidence,
if the name of the variable on line 77 is changed from 'a' to 'x', then the
test fails.
This is a result of the arbitrary ordering of removals of values from a modules
Changes by Mark Shannon :
--
nosy: +Mark.Shannon
___
Python tracker
<http://bugs.python.org/issue13703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Mark Shannon added the comment:
What is the mechanism by which the attacker can determine the seeds?
The actual hash value is not directly observable externally.
The attacker can only determine the timing effects of multiple
insertions into a dict, or have I missed something?
> - h
Mark Shannon added the comment:
But that's not the issue we are supposed to be dealing with.
A single (genuinely random) seed will deal with the attack described in
the talk and it is (almost) as fast as using 0 as a seed.
Why make things complicated dealing with a hypothetical pr
Mark Shannon added the comment:
I agree.
+1 for strings. -0 for numbers.
This might cause problems with dict subclasses and the like,
so I'm -1 on this.
--
___
Python tracker
<http://bugs.python.org/is
Mark Shannon added the comment:
Without the context, that last message didn't make much sense.
I agree with Terry that we should copy Perl and Ruby (for strings).
I'm -1 on hash() returning a different value than dict uses internally.
--
Mark Shannon added the comment:
>>> * the method would need to be implemented for all hashable Python types
>> It was already discussed, and it was said that only hash(str) need to
>> be modified.
>
> Really ? What about the much simpler attack on integer hash val
New submission from Mark Shannon :
Attached program fails.
See comments in file for details and possible diagnosis
--
files: binary_op_mimic.py
messages: 117216
nosy: Mark.Shannon
priority: normal
severity: normal
status: open
title: Incorrect semantics of __radd__ method for builtin
Mark Shannon added the comment:
Serhiy, what is the advantage of __import__ being slower?
Not counting the argument clinic generated code, the PR doesn't add any code
and improves the docstring.
--
___
Python tracker
<https://bugs.py
101 - 200 of 1219 matches
Mail list logo
