Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset b0689ae7f9d904bc2126994aedbc552f03479e40 by Serhiy Storchaka in
branch 'master':
bpo-41146: Convert signal.default_int_handler() to Argument Clinic (GH-21197)
https://github.com/python/cpython/commit/b0689ae7f9d904bc2126994aedbc55
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
It depends. pickle is not vulnerable to the kind of error reported in this
issue. If you find some way to crash Python specific to pickle it will likely
be fixed if it is possible without significant performance or memory cost. If
it depends on arbitrary
Serhiy Storchaka added the comment:
Thank you. Indeed, it is a pickle specific crash. Please open a new issue and
I'll provide a fix.
--
___
Python tracker
<https://bugs.python.org/is
Change by Serhiy Storchaka :
--
assignee: -> serhiy.storchaka
components: +Extension Modules -Interpreter Core
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20605
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21458
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
title: Pickle crashes using a crafted datetime object -> Pickle crashes
unpickling invalig NEWOBJ_EX opcode
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
pull_requests: +20616
pull_request: https://github.com/python/cpython/pull/21472
___
Python tracker
<https://bugs.python.org/issue41
Serhiy Storchaka added the comment:
New changeset bbceef6851895135c80e588a55854c1afab46499 by Zackery Spytz in
branch 'master':
bpo-20183: Convert _locale to the Argument Clinic (GH-14201)
https://github.com/python/cpython/commit/bbceef6851895135c80e588a55854c1afab46499
-
Change by Serhiy Storchaka :
--
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue23860>
___
___
Python-bugs-list mailin
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
versions: +Python 3.10 -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue33
Serhiy Storchaka added the comment:
New changeset af4eda46d1538b1da700a86588bdb94b0a4d1ff2 by Zackery Spytz in
branch 'master':
bpo-40150: Fix mismatched argument in RegisterWaitForSingleObject() call
(GH-19686)
https://github.com/python/cpyt
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
CPython is written on C, not C++, so we cannot use std::from_chars.
Note also that to parse a number in JSON we need first to scan the PyUnicode
object character-by-character using PyUnicode_READ() which is slower than just
reading a byte from a memory
Serhiy Storchaka added the comment:
I would raser raise error if the test method returns something suspicious, like
generator or coroutine. Or maybe if it returns anything except None.
--
nosy: +serhiy.storchaka
___
Python tracker
<ht
Serhiy Storchaka added the comment:
It depends on timezone. I guess there was a switch to daylight saving time at
that time and place.
--
nosy: +belopolsky, lemburg, p-ganssle, serhiy.storchaka
___
Python tracker
<https://bugs.python.
Serhiy Storchaka added the comment:
It is also a good idea for linters to catch such kind of errors. It will help
users of older Python versions.
We cannot raise error without deprecation period or add warnings in old
versions because it potentially can break existing code, e.g.:
def
Serhiy Storchaka added the comment:
I am not even sure it was worth to add fast path for "xmlcharrefreplace".
"surrogateescape" and "surrogatepass" are most likely used in performance
critical cases. It is also easy to add support of "ignore" and &qu
Serhiy Storchaka added the comment:
New changeset b4c98ed41e6c959e95b2a6f65c1b728e94039dfd by Serhiy Storchaka in
branch 'master':
bpo-41288: Refactor of unpickling NEWOBJ and NEWOBJ_EX opcodes. (GH-21472)
https://github.com/python/cpython/commit/b4c98ed41e6c959e95b2a6f65c1b72
Serhiy Storchaka added the comment:
New changeset 80a50368c0e4dc9d56af0ce748dea35c9d96d23f by Serhiy Storchaka in
branch 'master':
bpo-41262: Convert memoryview to Argument Clinic. (GH-21421)
https://github.com/python/cpython/commit/80a50368c0e4dc9d56af0ce748dea3
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
In the Web application you need first to generate data (this may involve some
network requests, IO operations, and some data transformations), then format
the page, then encode it, and finally send it to client. I suppose that the
encoding part is minor
Serhiy Storchaka added the comment:
I do not have other benchmarks. memoryview was just one of few builtins which
still use PyArg_ParseTupleAndKeywords() and I know how inefficient it is. Since
Argument Clinic was already used for memoryview.hex() I did not see problems
with converting the
New submission from Serhiy Storchaka :
The proposed PR converts OrderedDict.pop() to Argument Clinic. It makes it 2
times faster.
$ ./python -m pyperf timeit -q --compare-to=../cpython-release2/python -s "from
collections import OrderedDict; od = OrderedDict()" "od.pop(&
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20672
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21534
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
Constructors str(), bytes() and bytearray() were not converted to Argument
Clinic because it was not possible to generate correct signature for them. But
now there is other reason of using Argument Clinic -- it generates more
efficient code for parsing
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20673
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21535
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 6bf3237379b17632db52cb39d181e8bac70173f3 by Serhiy Storchaka in
branch 'master':
bpo-41333: Convert OrderedDict.pop() to Argument Clinic (GH-21534)
https://github.com/python/cpython/commit/6bf3237379b17632db52cb39d181e8
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
nosy_count: 2.0 -> 3.0
pull_requests: +20685
pull_request: https://github.com/python/cpython/pull/21543
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
int.__round__ was not converted to Argument Clinic because it is not impossible
to express a correct signature for it in Python. But now we can at least make
Argument Clinic not producing incorrect signature. And converting to Argument
Clinic has a
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20691
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21549
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
I wrote similar patch for __format__ and got similar tiny speed up. It is
expectable. But I am surprised that you get a difference for conjugate() and
__getnewargs__. It may be a compiler artifact.
In any case the benefit of converting to Argument Clinic
Serhiy Storchaka added the comment:
Yes, you can do this without Argument Clinic, but Argument Clinic allows to
hide the use of unstable private API and cumbersome code under macros and in
generated files.
> That said, it would be great if someone were to work on building-out AC
Serhiy Storchaka added the comment:
New changeset 12f433411bba8a0cdc4f09ba34472745ae9da0d1 by Serhiy Storchaka in
branch 'master':
bpo-41334: Convert constructors of str, bytes and bytearray to Argument Clinic
(GH-21535)
https://github.com/python/cpyt
Serhiy Storchaka added the comment:
New changeset e123012d79121ab543583631bb84c7fc27d06338 by Dong-hee Na in branch
'master':
bpo-41343: Convert methods of complex to Argument Clinic (GH-21550)
https://github.com/python/cpython/commit/e123012d79121ab543583631bb84c7
Serhiy Storchaka added the comment:
New changeset eca2549f5a5048b44ca88b9555f1c62f094e3c12 by Zackery Spytz in
branch 'master':
bpo-41336: Fix the error handling in zoneinfo_new_instance() (GH-21546)
https://github.com/python/cpython/commit/eca2549f5a5048b44ca88b9555f1c6
Serhiy Storchaka added the comment:
New changeset 5a2bac7fe0e7a2b67fd57c7a9176a50feed0d7a0 by Serhiy Storchaka in
branch 'master':
bpo-41342: Convert int.__round__ to Argument Clinic (GH-21549)
https://github.com/python/cpython/commit/5a2bac7fe0e7a2b67fd57c7a9176a5
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
See also issue20180. collections.deque was intentionally not converted to
Argument Clinic, but some of methods were made using more efficient code for
parsing arguments by inlining the code generated by Argument Clinic at that
time.
--
nosy
Change by Serhiy Storchaka :
--
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue41288>
___
___
Python-bugs-list mailing list
Unsubscrib
Serhiy Storchaka added the comment:
Now Argument Clinic generates more efficient (but more cumbersome) code, so
there may be new reasons of using it. Please test the performance of the deque
constructor (deque(), deque(()), deque((), 10), deque((), maxlen=10)), methods
index() and rotate
Serhiy Storchaka added the comment:
This fix touched the unpickling code, and the test crashed during pickling, so
it is not directly related. But it may be some compiler glitch, when changing
one part of code affects compilation of other parts of code. The next run on
the buildbot was
Serhiy Storchaka added the comment:
I missed that the file's attribute newlines can be None if no line separators
were read. It can also be a tuple if mixed newlines are used. I think that
eol_convention should be set to the default value os.linesep in these cases.
I am currently not
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20736
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/21597
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
The tarfile module supports arbitrary compressions by using the stream mode.
You only need to use a third-party library which provides zstd support.
Recent versions of the tar utility has options to explicit support of new
compressions: --lzip, --lzma
Serhiy Storchaka added the comment:
It is expected behavior on Posix system. See
https://pubs.opengroup.org/onlinepubs/9699919799/functions/umask.html
What is the problem?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.
Change by Serhiy Storchaka :
--
resolution: -> not a bug
___
Python tracker
<https://bugs.python.org/issue41375>
___
___
Python-bugs-list mailing list
Un
Serhiy Storchaka added the comment:
I concur with Raymond.
Also, it could not help to caught bugs when you get a string instead expected
bytes object. It may "work" in tests while string is ASCII, but fail miserably
on real-world non-ASCII data.
--
nosy: +serhiy
Serhiy Storchaka added the comment:
It is a duplicate of issue41373 (and the problem is not only with empty files).
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> IDLE: edit/save files created by Wind
Change by Serhiy Storchaka :
--
pull_requests: -20743
___
Python tracker
<https://bugs.python.org/issue41280>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 5.0 -> 6.0
pull_requests: +20750
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21608
___
Python tracker
<https://bugs.p
Change by Serhiy Storchaka :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41395>
___
___
Python-bugs-list mailing list
Unsub
Serhiy Storchaka added the comment:
New changeset b1a87300a06324c9fc7d6553906ed914489465aa by Serhiy Storchaka in
branch 'master':
bpo-41385: Fix test_executable_without_cwd on Windows (GH-21608)
https://github.com/python/cpython/commit/b1a87300a06324c9fc7d6553906ed9
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Serhiy Storchaka :
Currently collections.Counter implements both __eq__ and __ne__ methods. The
problem is that if you subclass Counter and override its __eq__ method you will
need to implement also the __ne__ method. Usually you do not need to implement
__ne__ because
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20768
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21627
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20769
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21628
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
There is the documentation for method __ne__ implementations in classes Set,
Mapping, Header, Charset, Binary, but all these implementations are removed now
and the default implementation of object.__ne__ is used instead.
--
assignee: docs
Serhiy Storchaka added the comment:
warnings.warn(), the function which emits warnings, has the stacklevel
parameter. But how do you provide stacklevel for exceptions?
See also bpo-39725.
--
nosy: +serhiy.storchaka
___
Python tracker
<ht
Serhiy Storchaka added the comment:
I do not think it is a security issue. The crash cannot be triggered by the
user input unless you accept the pickle data from untrusted sources, but in
that case you are in large danger, because you allow executing arbitrary code.
The changes in this
Serhiy Storchaka added the comment:
Thank you for your report (and for all other heroic work for maintaining AIX).
Breaking only one test on AIX looks like a good news.
Do you able to run tests manually? Could you please run the following command?
./python -m test --list-cases -uall
Serhiy Storchaka added the comment:
I think they are not required, but recommended.
>From https://www.python.org/dev/peps/pep-0008/#comments:
You should use two spaces after a sentence-ending period in multi- sentence
comments, except after the final sentence.
>From
Serhiy Storchaka added the comment:
Is it good to provide incorrect information in the documentation? It is a
matter of correctness, not style.
--
___
Python tracker
<https://bugs.python.org/issue41
Serhiy Storchaka added the comment:
The current code returns NotImplemented for non-Counter. If we want to
implement equality comparison with other class we have to override __ne__.
--
___
Python tracker
<https://bugs.python.org/issue41
Serhiy Storchaka added the comment:
There are two errors in test_io, both are not related to AIX.
The first one is in test_fspath_support. It is exposed on non-UTF-8 locales.
AIX by accident use ISO8859-1 locale by default.
The second one is in test_reader_writer_close_error_on_close and
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20781
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21640
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
deque is not a subclass of MutableMapping, so the Liskov substitution principle
is not related here.
deque is not registered as a virtual subclass of MutableMapping and it lacks a
number of MutableMapping methods.
>>> import collec
Serhiy Storchaka added the comment:
>>> issubclass(collections.deque, collections.abc.MutableSequence)
True
>>> sorted(set(dir(collections.abc.MutableSequence)) -
>>> set(dir(collections.deque)))
['__abstractmethods__', '__module__'
Serhiy Storchaka added the comment:
New changeset 67987acd5dc9776f55f4e139e2b3d9e7a6434d9f by Serhiy Storchaka in
branch 'master':
bpo-41401: Fix test_fspath_support in test_io. (GH-21640)
https://github.com/python/cpython/commit/67987acd5dc9776f55f4e139e2b3d9
Serhiy Storchaka added the comment:
Automatic backport does not work due to changes in the test.support module.
Victor, do you mind to backport PR 21640 to 3.9 and 3.8?
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue41
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +20795
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21628
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
pull_requests: -20795
___
Python tracker
<https://bugs.python.org/issue41416>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Serhiy Storchaka :
According to the documentation [1] abstract classes collections.abc.Set and
collections.abc.Mapping provide mixin method __ne__. But implementations of
__ne__ in these classes were removed in 3.4 (see issue21408), so the default
implementation is
Serhiy Storchaka added the comment:
I think that both functions for detecting file type, by name and by content,
are useful in different circumstances. We have similar more specific detection
functions sndhdr and imghdr.
But I am not sure whether it should be a part of the mimetypes module
Serhiy Storchaka added the comment:
If deque does not fully support the MutableSequence interface, should not it be
un-regitered as MutableSequence? Maybe we need other abstract class which would
be parent of MutableSequence and deque?
--
nosy: +stutzbach
Change by Serhiy Storchaka :
--
keywords: +easy
___
Python tracker
<https://bugs.python.org/issue41395>
___
___
Python-bugs-list mailing list
Unsubscribe:
Serhiy Storchaka added the comment:
It is a duplicate of issue39909.
--
nosy: +serhiy.storchaka
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Assignment expression in assert causes SyntaxError
__
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41421>
___
___
Python-bugs-list mailing list
Unsub
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41422>
___
___
Python-bugs-list mailing list
Unsub
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka, yselivanov
___
Python tracker
<https://bugs.python.org/issue41431>
___
___
Python-bugs-list mailin
Serhiy Storchaka added the comment:
+1 for "u ** (-1.0 / alpha)"!
--
___
Python tracker
<https://bugs.python.org/issue41421>
___
___
Python-bugs-l
Serhiy Storchaka added the comment:
This is a duplicate of issue26393 and issue27964.
--
nosy: +serhiy.storchaka
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> random.shuffled
___
Py
Serhiy Storchaka added the comment:
Would not be more useful to add a method to the Thread or frame object to
obtain the topmost handled exception? Then you could iterate all threads or
frames and obtain exceptions together with other useful information.
Note also that it omits exceptions
Serhiy Storchaka added the comment:
Good catch. Yes, when read Python source files you should either open them in
binary mode if reading bytes is enough for use, or open them with
tokenize.open() if we need string data, or use token.detect_encoding() and pass
the result to open
Serhiy Storchaka added the comment:
os.mkdir() is a thin wrapper around syscalls mkdir or mkdirat. Path.mkdir() is
a thin wrapper around os.mkdir(). If you think that the behavior of mkdir
differs from the documentation please file a report in the Linux kernel.
--
nosy
Serhiy Storchaka added the comment:
$ echo 'from typing import NamedTuple; NamedTuple("A")' | ./python -m ast
Module(
body=[
ImportFrom(
module='typing',
names=[
alias(name='NamedTuple')],
l
Serhiy Storchaka added the comment:
No, cached_property is a completely different class.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41
Serhiy Storchaka added the comment:
There are not much things common to property and cached_property.
cached_property does not have attributes fget, fset, fdel. They are both
descriptors, but cached_property is not a data descriptor
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 2.0 -> 3.0
pull_requests: +20964
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21836
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
Good catch! Do you mind to provide a PR for this William?
--
keywords: +easy (C)
nosy: +serhiy.storchaka
stage: -> needs patch
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
Should not such changes be widely discussed on the Python-Dev mailing list
before merging?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41
Serhiy Storchaka added the comment:
Yes, but I think it is worth opening a separate issue.
--
___
Python tracker
<https://bugs.python.org/issue41525>
___
___
Serhiy Storchaka added the comment:
Pydoc uses the backslashreplace error handler for characters not encodable with
the output encoding (see issue21398 and issue23374).
$ LC_ALL=uk_UA.koi8-u ./python -c "help('async')"
[...]
[2] A string literal appearing as the fi
3701 - 3800 of 25874 matches
Mail list logo
