Serhiy Storchaka added the comment:
All these failures point not on some details of appearance, but that the widget
is not rendered at all.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Serhiy Storchaka :
--
nosy: +Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue42562>
___
___
Python-bugs-list mailing list
Unsubscribe:
Serhiy Storchaka added the comment:
Other example is:
>>> import sys
>>> import xml
>>> import xml.__init__
>>> sys.modules['xml']
>>> sys.modules['xml.__init__']
>>> sys.modules['xml'] is sys.modules[
Serhiy Storchaka added the comment:
This is because the code of the main() function is roughly equivalent to
result = next(iter)
for item in iter:
if item > result:
result = item
It can be changed to use "result < item" instead of "item >
Serhiy Storchaka added the comment:
Open it against master.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42470>
___
___
Python-bug
Serhiy Storchaka added the comment:
What is the problem? What real code imports __init__?
--
___
Python tracker
<https://bugs.python.org/issue42564>
___
___
Serhiy Storchaka added the comment:
I prefer PR 19975 to PR 23645. It solves the initial issue and is much simpler.
--
___
Python tracker
<https://bugs.python.org/issue30
Serhiy Storchaka added the comment:
4 of 5 linked questions do not have relation to open(). Half of them are Python
2 specific, and other half is Windows specific and should be fixed in recent
Python releases on new Windows.
--
nosy: +serhiy.storchaka
New submission from Serhiy Storchaka :
It was only used in _asynciomodule.c to implement now removed Task.all_tasks()
method (see issue40967).
--
components: asyncio
messages: 382597
nosy: asvetlov, serhiy.storchaka, yselivanov
priority: normal
severity: normal
status: open
title
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22531
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23664
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
New changeset 8a62887dfb4bb2835048780ad673362f7ee3c7bf by Serhiy Storchaka in
branch 'master':
bpo-42582: Remove asyncio._all_tasks_compat(). (GH-23664)
https://github.com/python/cpython/commit/8a62887dfb4bb2835048780ad67336
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
It is Modules/_posixsubprocess.c.
We still do not have a reproducer, so I am not sure that the code has this
problem.
--
nosy: +serhiy.storchaka
status: pending -> open
___
Python tracker
<
Change by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue42583>
___
___
Python-bugs-list mailing list
Un
Change by Serhiy Storchaka :
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
BTW, CPython does not use UTF-8 and UTF-16 encoding in internal representation
of strings. It uses Latin1, UCS2 and UCS4 (UTF-32).
What benchmarks show? Is your code always faster and how much? If it is slower
for some data, for what data and how much
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 6.0 -> 7.0
pull_requests: +22602
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23744
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
This is known issue, but interesting that the cause of the crash is different
in 3.7-3.8 and 3.9+.
PR 23744 adds recursion checks in the AST validator and optimizer similar to
the checks in the symtable. It should not break any existing code because too
Serhiy Storchaka added the comment:
Actually it may be worth to reuse setup_master() from tkinter.ttk.
But I am not sure what is better: raise error (RuntimeError) if the global
function uses _default_root which is not initialized, or create the root widget
implicitly. Currently
Serhiy Storchaka added the comment:
Searching os.popen in code on GitHub gives around 4.5 millions of results.
Seems that most of them are with literal strings which are very specific to the
program, like
check2 = os.popen('grep "net\.ipv4\.ip_forward" /etc/sysctl.conf
Serhiy Storchaka added the comment:
I am wondering whether we should silence that error in os.close()
unconditionally.
In what circumstances the error is raised? Can it be reproduced on Linux (by
monkey-patching os.rmdir)? What can happen in worst case when the error is
ignored
Serhiy Storchaka added the comment:
Don't haste. I am currently working on a large PR with many tests.
--
___
Python tracker
<https://bugs.python.org/is
Change by Serhiy Storchaka :
--
pull_requests: +22639
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23781
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
There should be no timeouts (because wait_visibility no longer is used in
tests). The fix can introduce new failures (like in issue42507), but it is a
separate issue and may be related to bugs in the implementation of Tk on macOS.
--
resolution
Change by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue24893>
___
___
Python-bugs-list mailing list
Un
Serhiy Storchaka added the comment:
asksaveasfilename is just a wrapper around the tk_getSaveFile Tk command which
is implemented differently on Windows, macOS and X Window. The used widgets
have very different appearance and behavior on different platforms, so there is
no chance to test
Serhiy Storchaka added the comment:
Oh, the fix is not backported yet.
Automatically backporting does not work because of renames in the supporting
test library.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Serhiy Storchaka :
--
pull_requests: +22641
pull_request: https://github.com/python/cpython/pull/23784
___
Python tracker
<https://bugs.python.org/issue42
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22642
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23785
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
resolution: -> third party
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue41349>
___
___
Pyth
Change by Serhiy Storchaka :
--
resolution: -> third party
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue41969>
___
___
Pyth
Serhiy Storchaka added the comment:
Currently, a root window is created implicitly only when you create a Tkinter
or Ttk widget. i.e. things which should be visible to user. When you create
image, variable, or use global utility function like getbool() or mainloop() or
image_types() it
Serhiy Storchaka added the comment:
New changeset 28bf6ab61f77c69b732a211c398ac882bf3f65f4 by Serhiy Storchaka in
branch '3.9':
[3.9] bpo-42318: Fix support of non-BMP characters in Tkinter on macOS
(GH-23281). (GH-23784)
https://github.com/python/cpyt
Serhiy Storchaka added the comment:
This was likely caused by different versions of Tk.
It should be fixed now in issue42328. Style.map() should convert result to
uniform representation on all versions and platforms, and accept input in
different forms. Please check.
--
resolution
Serhiy Storchaka added the comment:
New changeset b9ced83cf427ec86802ba4c9a562c6d9cafc72f5 by E-Paine in branch
'master':
bpo-40219: Lowered ttk LabeledScale dummy (GH-21467)
https://github.com/python/cpython/commit/b9ced83cf427ec86802ba4c9a562c6
Serhiy Storchaka added the comment:
New changeset 5f0fe8ec70120f4586d08978b0911b436f82c421 by Serhiy Storchaka in
branch 'master':
bpo-19733: Re-enable tests for -image option in Tkinter (GH-23785)
https://github.com/python/cpython/commit/5f0fe8ec70120f4586d08978b0911b
Serhiy Storchaka added the comment:
I do not think there is any problem *now*. The type of day is uint8_t, it
cannot be negative.
BTW, why is it uint8_t? Would not be easier to use type int by default? I doubt
that it saves memory or makes the code faster.
--
nosy
Serhiy Storchaka added the comment:
See also issue42189.
--
components: +Library (Lib)
nosy: +jaraco, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42
Serhiy Storchaka added the comment:
I propose to change the type of day to int. It will remove any objections
againsy the range check and make the code less error-prone for integer overflow
and sign loss.
--
___
Python tracker
<ht
Serhiy Storchaka added the comment:
I propose to change types of function parameters and local variables. In any
case the constructor checks the range of parameters, so there is no problem
with packing them into compact structure.
This will help to avoid errors of implicit conversion
New submission from Serhiy Storchaka :
No, it should not.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42665>
___
___
Python-bug
Change by Serhiy Storchaka :
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue42667>
___
___
Python-bugs-list mailin
Serhiy Storchaka added the comment:
> If the escape-result still contains a verbatim newline, why escape this
> character at all?
Because in verbose mode it is ignored. This is why \n and other ASCII
whitespace characters, and '#', which starts a comment, should be escaped.
Serhiy Storchaka added the comment:
I am wondering why 53/22? 5/2 is as good for 8-bytes long -- both gives
21-bytes buffer.
I do not propose to change anything. It is just curiosity.
--
nosy: +serhiy.storchaka
___
Python tracker
<ht
Change by Serhiy Storchaka :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
I added import experts because the issue looks relates to race condition in
import.
Willy, can the issue be reproduced on more modern Python releases (3.8 or 3.9)?
It could help if you provide minimal script which reproduces it.
--
nosy
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 1.0 -> 2.0
pull_requests: +22686
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23825
___
Python tracker
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22687
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23825
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
PR 23825 refactors parsing. There is now a single function for parsing numbers.
It saves around 70 lines of code and makes easy to implement support of full
range of transition hours.
It could be possible to represent transition time as 32-bit offset in
Serhiy Storchaka added the comment:
Modules are already cleared in the reverse order.
Clearing module attributes in the reverse order looks interesting. It increases
chance that modules and other imported names which can be used in __del__ will
be deleted after executing __del__ if the
Serhiy Storchaka added the comment:
I experimented with different approaches last evening. Just changing the order
of clearing the module dict does not help your first example, because the
__main__ module is garbage collected, but its dict is not cleared. Adding
_PyModule_ClearDict() in
Serhiy Storchaka added the comment:
Do you have any benchmarks?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42673>
___
___
Pytho
New submission from Serhiy Storchaka :
zoneinfo uses locale depending functions isalpha(), isdigit(), isalnum() to
parse data. It may be correct when parse the TZ environment variable (although
they do not work with multibytes locale encodings like UTF-8), I think that
parsing the content of
Serhiy Storchaka added the comment:
Loading modules every time without using a cache (sys.modules) can add
significant overhead.
--
___
Python tracker
<https://bugs.python.org/issue42
New submission from Serhiy Storchaka :
The patch is not correct. Its first part negates the correct behavior, its
second part does not affect behavior at all, and all this does not have any
effect on NameError.
This issue looks like a duplication of 42630.
--
resolution
Serhiy Storchaka added the comment:
New changeset 3d569fd6dccf9f582bafaca04d3535094cae393e by Serhiy Storchaka in
branch 'master':
bpo-42630: Improve error reporting in Tkinter for absent default root (GH-23781)
https://github.com/python/cpyt
Change by Serhiy Storchaka :
--
pull_requests: +22718
pull_request: https://github.com/python/cpython/pull/23853
___
Python tracker
<https://bugs.python.org/issue42
Serhiy Storchaka added the comment:
New changeset 87e7a14ee3bd7dc495e51166598453114342d0bf by Serhiy Storchaka in
branch '3.9':
[3.9] bpo-42630: Improve error reporting in Tkinter for absent default root
(GH-23781) (GH-23853)
https://github.com/python/cpyt
Change by Serhiy Storchaka :
--
pull_requests: +22719
pull_request: https://github.com/python/cpython/pull/23854
___
Python tracker
<https://bugs.python.org/issue42
Serhiy Storchaka added the comment:
New changeset 80c445cafbdfb16c4a882e3ff6fe28b471aacdfc by Serhiy Storchaka in
branch '3.8':
[3.8] bpo-42630: Improve error reporting in Tkinter for absent default root
(GH-23781) (GH-23854)
https://github.com/python/cpyt
New submission from Serhiy Storchaka :
Currently simple query windows in Tkinter (such as
tkinter.simpledialog.askinteger()) are placed at position 50 pixels right and
50 pixels below of the top left corner of the parent widget (even if it is not
visible). If the parent is not specified, the
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22721
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23856
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
New changeset 6ad5fd14825fc6039a9684dfdc14f5d12b86e25f by Miss Islington (bot)
in branch '3.9':
bpo-40219: Lowered ttk LabeledScale dummy (GH-21467) (GH-23788)
https://github.com/python/cpython/commit/6ad5fd14825fc6039a9684dfdc14f5
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
It is addressed in issue42630. Now a RuntimeError with relevant error message
is raised when call askinteger() without explicit parent if there is no default
root widget.
Autocreating a top-level root window is not good idea. It pops up an empty
window
Change by Serhiy Storchaka :
--
stage: -> resolved
status: pending -> closed
___
Python tracker
<https://bugs.python.org/issue38661>
___
___
Python-bugs-
Change by Serhiy Storchaka :
--
status: open -> pending
___
Python tracker
<https://bugs.python.org/issue19733>
___
___
Python-bugs-list mailing list
Un
Serhiy Storchaka added the comment:
Thank you for tracking it Ronald. Could this issue be closed now?
--
status: pending -> open
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
Good catch! And it is not only documentation issue now. Since color numbers and
pair numbers use different range checks, this prevents using this function with
pair numbers larger that COLORS (should be accepted up to COLOR_PAIRS-1).
Seems there is also
Change by Serhiy Storchaka :
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Serhiy Storchaka :
==
FAIL: test_new_curses_panel (test.test_curses.TestCurses)
--
Traceback (most recent call last):
File "/home/s
Serhiy Storchaka added the comment:
These changes introduced a regression in test_curses (see issue42694). And I
afraid then introduced regressions in other modules for which there were not
purposed tests.
--
___
Python tracker
<ht
Serhiy Storchaka added the comment:
All NOP bytecodes should be removed. If any is left it is a regression.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42
Serhiy Storchaka added the comment:
Tkinter is just a wrapper around Tcl/Tk. Please report a bug in Tk on the
corresponding bug tracker.
https://wiki.tcl-lang.org/page/How+do+I+report+a+bug+in+Tcl%2C+Tk%2C+...
--
nosy: +serhiy.storchaka
resolution: -> third party
st
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22736
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23874
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
And the first issue was fixed in issue42630.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
I do not think that popping up a root window on first call of Variable() or
getboolean() is a good idea. Issue42630 fixed errors in other way. A root
window is not automatically created for non-graphic objects (like Variable),
instead a RuntimeError with
Change by Serhiy Storchaka :
--
keywords: +easy
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue35728>
___
___
Python-bug
Serhiy Storchaka added the comment:
There should no be any UnicodeDecodeError now. Tkinter on Windows uses now the
UTF-16 encoding with the surrogatepass error handler which should never fail.
Could you please confirm that the issue is gone?
--
status: open -> pend
Serhiy Storchaka added the comment:
And in any case Tkinter is just a wrapper around Tk. If there is a bug it
should be reported on the Tk bug tracker.
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Pytho
Serhiy Storchaka added the comment:
Tkinter is a wrapper around the Tk library. This seems a bug in Tk itself.
Please file report on the corresponding bug tracker.
--
nosy: +serhiy.storchaka
resolution: -> third party
stage: -> resolved
status: open -&g
Serhiy Storchaka added the comment:
Yes, calling functions in Python has some overhead. It is not specific to
random.uniform().
--
nosy: +rhettinger, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42
Serhiy Storchaka added the comment:
I just noticed that "while True:" is now compiled to NOP. It is clearly a
regression which affects performance.
--
___
Python tracker
<https://bugs.python.o
New submission from Serhiy Storchaka :
Currently, standard message boxes in tkinter.messagebox (like showinfo() or
askyesnocancel()) can be called without master or default root window. If
arguments master or parent are not specified and there is no default root
window is still created, the
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22752
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23897
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
If the NOP is outside of the loop, then what is the reason of adding it? You
cannot set a breakpoint on "while True:" which stops on every iteration.
The goal "tracing every line of code" is incompatible with code optimization.
It woul
Change by Serhiy Storchaka :
--
pull_requests: +22758
pull_request: https://github.com/python/cpython/pull/23904
___
Python tracker
<https://bugs.python.org/issue15
Serhiy Storchaka added the comment:
I concur with other core developers. Seems there is no real need for this
feature and the idea was proposed purely to "close a gap". Taking into account
significant cost of implementing and maintaining this feature, I think that it
should no
Serhiy Storchaka added the comment:
New changeset c6c43b28746b0642cc3c49dd8138b896bed3028f by Serhiy Storchaka in
branch 'master':
bpo-42685: Improve placing of simple query windows. (GH-23856)
https://github.com/python/cpython/commit/c6c43b28746b0642cc3c49dd8138b8
Serhiy Storchaka added the comment:
No, it was not fixed. The code object creation was broken, because the code
constructor signature was changed.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue42
Change by Serhiy Storchaka :
--
title: "bogus_code_obj.py" should be removed from "cPython/Lib/test/crashers"
-> Outdated CodeType call in "bogus_code_obj.py"
___
Python tracker
&l
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +22789
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23939
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
There is no longer PyString in Python, only PyUnicode.
There are plans to get rid of PyUnicode_READY(). After removing support of
"legacy" Unicode objects (which will happen in few years), PyUnicode_READY()
will be no longer needed, so all c
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Serhiy Storchaka :
>>> def f(): pass
...
>>> co = f.__code__.replace(co_linetable=b'')
>>> import dis
>>> dis.dis(co)
python: Objects/codeobject.c:1185: PyLineTable_NextAddressRange: Assertion
`!at_end(range)' failed.
A
Serhiy Storchaka added the comment:
New changeset 954a7427ba9c2d02faed32c02090caeca873aeca by Serhiy Storchaka in
branch 'master':
bpo-42734: Fix crasher bogus_code_obj.py (GH-23939)
https://github.com/python/cpython/commit/954a7427ba9c2d02faed32c02090ca
Serhiy Storchaka added the comment:
New changeset bb70b2afe39ad4334a9f3449cddd28149bd628b6 by Serhiy Storchaka in
branch 'master':
bpo-15303: Support widgets with boolean value False in Tkinter (GH-23904)
https://github.com/python/cpython/commit/bb70b2afe39ad4334a9f3449cddd28
Serhiy Storchaka added the comment:
New changeset 675c97eb6c7c14c6a68ebf476c52931c1e5c1220 by Serhiy Storchaka in
branch 'master':
bpo-42721: Improve using simple dialogs without root window (GH-23897)
https://github.com/python/cpython/commit/675c97eb6c7c14c6a68ebf476c5293
3001 - 3100 of 25874 matches
Mail list logo
