Serhiy Storchaka added the comment:
New changeset 9e31b3952f6101ef71ec029481b972169ab0e0f1 by Irit Katriel in
branch 'main':
bpo-41031: Match C and Python code formatting of unprintable exceptions and
exceptions in the __main__ module. (GH-28139)
https://github.com/python/cpyt
Serhiy Storchaka added the comment:
What to do with comprehensions and classes? Corresponding code objects are not
easily accessible and they do not have corresponding function. It would be
difficult to use the locals of the frame with comprehensions.
Maybe use per-module registries of
Serhiy Storchaka added the comment:
Any suggestions for the format of output? Currently PR 28082 formats lines for
subtest skipping, failure or error with a 2-space identation. Lines for
skipping, failure or error in tearDown() or functions registered with
addCallback() do not differ from a
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 4.0 -> 5.0
pull_requests: +26606
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28180
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
Before b3468f79efa45c8adaf86c0b9b797b9b3d4c12a2 the TestResult methods
(addFailure, addError, addSkip, addExpectedFailure, addUnexpectedSuccess) were
called immediately after running the test method. After that change all skips,
failures and errors were
Serhiy Storchaka added the comment:
_STRUCT_TM_ITEMS was always set to 11 since issue25283.
On what platform test_localtime_timezone fails now?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue35
Serhiy Storchaka added the comment:
There are too many issues with TestResult.debug(). It does not call tearDown()
and doCleanups() if the test is skipped, failed or raises other exception
(including errors in cleanup). It does not support skipping decorators. It does
not support the
Serhiy Storchaka added the comment:
By default configparser does not support inline comments. "# percentage sign
'%'" is a part of value. If you want to support inline comments you should pass
the inline_comment_prefixes argument.
But note that it can break parsing e
Serhiy Storchaka added the comment:
I concur with Raymond. Originally it was "instance of cls". It was changed in
issue15542 (6b16d938d6d1ccb443815e20e8812deed274dc09).
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bu
Serhiy Storchaka added the comment:
Go ahead. Fix also other issues in tests:
* All pickling tests should test with all supported protocols, not just with
the default one.
* self.assertTrue(
isinstance(deserialized_sl, shared_memory.ShareableList)
)
assertIsinstance
Serhiy Storchaka added the comment:
New changeset d003a5bd2505a7fa04f50504b68ba8fca67349cd by Hugo van Kemenade in
branch 'main':
bpo-45132 Remove deprecated __getitem__ methods (GH-28225)
https://github.com/python/cpython/commit/d003a5bd2505a7fa04f50504b68ba8fca67349cd
-
Serhiy Storchaka added the comment:
Thank you for your contribution Hugo.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
pull_requests: +26656
pull_request: https://github.com/python/cpython/pull/28236
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
I have not benchmarked PR 28176 yet and do not know whether it have advantages
over PR 27986 and how large. Slower __lenght_hint__ can make list(range(...))
slower for small ranges, but I do not know how small
Serhiy Storchaka added the comment:
New changeset f235dd0784b92824565c4a4e72adc70fa3eab68f by Erlend Egeberg
Aasland in branch 'main':
bpo-38371: Remove deprecated `tkinter` split() method (GH-28237)
https://github.com/python/cpython/commit/f235dd0784b92824565c4a4e72adc7
Serhiy Storchaka added the comment:
What is wrong with this? Is such logic used in the dis module or any other
module outside modulefinder?
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
"{__module__}.{__name__}" is just incorrect reference if __name__ !=
__qualname__. Error messages should always use "{__module__}.{__qualname__}" or
just "{__name__}". I see this as a bug. Fortunately very few code
Change by Serhiy Storchaka :
--
nosy: +christian.heimes, gregory.p.smith
type: -> enhancement
versions: +Python 3.11
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
Expression `A or B` gets you A if A is true.
If you want to catch several types of exception by one "except", use except
with a tuple:
except (ConnectionResetError, ConnectionAbortedError):
--
nosy: +serhiy.storchaka
resolution: -&
Serhiy Storchaka added the comment:
I am currently working on a feature which can be better in these cases that
subTest(). It will allow to reduce the indentation level instead of increasing
it.
--
nosy: +serhiy.storchaka
___
Python tracker
Serhiy Storchaka added the comment:
So (128).to_bytes() will raise an error, right?
I afraid also that it will lead to some programs working correctly only on
platforms with the most common byte order, just because authors are not aware
of byte ordering. Currently the interface forces
Serhiy Storchaka added the comment:
Ah, signed=False by default, so (128).to_bytes() will work. But I still worry
that it can provoke writing more errorprone code.
--
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
>From my experience, the largest cost in importing module (after I/O) is for
>creating classes, especially classes with complex creation code: enums and
>dataclasses (and namedtuples in past, but they were significanly optimized
>since).
Fo
New submission from Serhiy Storchaka :
The proposed PR removes the following unittest features:
* "fail*" and "assert*" aliases of TestCase methods.
* Broken from start TestCase method assertDictContainsSubset().
* Ignored TestLoader.loadTestsFromModule() parameter use_loa
Change by Serhiy Storchaka :
--
nosy: +ezio.melotti, michael.foord, rbcollins
___
Python tracker
<https://bugs.python.org/issue45162>
___
___
Python-bugs-list m
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26688
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28268
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
b'\x1964' is a 3-bytes bytes object.
>>> b = b'\x1964'
>>> len(b)
3
>>> b[0], b[1], b[2]
(25, 54, 52)
What you what to get is b'\x19\x64'. And it is a different writing of b'\x19d&#x
Change by Serhiy Storchaka :
--
pull_requests: +26690
pull_request: https://github.com/python/cpython/pull/28270
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
New changeset 707137b8637feef37b2e06a851fdca9d1b945861 by Henry-Joseph Audéoud
in branch 'main':
bpo-40563: Support pathlike objects on dbm/shelve (GH-21849)
https://github.com/python/cpython/commit/707137b8637feef37b2e06a851fdca9d1b945861
-
Serhiy Storchaka added the comment:
Thank you for your contribution, Hakan, Henry-Joseph.
Sorry, David, there was already a PR, and it was not dead, it just waited for a
coredev review.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Serhiy Storchaka added the comment:
New changeset 17a1b3e63a5db4e581c0ef52751df2314f7249fa by Serhiy Storchaka in
branch 'main':
bpo-45132: Fix the reStructuredText markup error. (GH-28270)
https://github.com/python/cpython/commit/17a1b3e63a5db4e581c0ef52751df2
Serhiy Storchaka added the comment:
Since this change has a user-visible effect a NEWS entry is required. Just copy
it from issue22589.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue44
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 1.0 -> 2.0
pull_requests: +26702
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28286
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
Also, mutating the result of guess_all_extensions() mutated the internal state
of the MimeTypes object and affected the following calls of
guess_all_extensions().
--
stage: patch review ->
versions: +Python 3.10, Python 3.11, Python
New submission from Serhiy Storchaka :
New changeset 5f5b7d0c654488206ac13e27d9a5dcffbd2cc0af by David CARLIER in
branch 'main':
bpo-45163: Haiku build fix. (GH-28269)
https://github.com/python/cpython/commit/5f5b7d0c654488206ac13e27d9a5dcffbd2cc0af
--
nosy: +serhiy
Serhiy Storchaka added the comment:
New changeset 97ea18ecede8bfd33d5ab2dd0e7e2aada205 by Serhiy Storchaka in
branch 'main':
bpo-35474: Fix mimetypes.guess_all_extensions() potentially mutating list
(GH-28286)
https://github.com/python/cpyt
Serhiy Storchaka added the comment:
New changeset 9abd07e5963f966c4d6df8f4e4bf390ed8191066 by Dong-hee Na in branch
'main':
bpo-44987: Speed up unicode normalization of ASCII strings (GH-28283)
https://github.com/python/cpython/commit/9abd07e5963f966c4d6df8f4e4bf39
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45163>
___
___
Serhiy Storchaka added the comment:
This warning is produced by the compiler when it compiles the source code. If
it is already compiled, no compiler is involved.
--
nosy: +serhiy.storchaka
resolution: -> not a bug
stage: -> resolved
status: open -&g
New submission from Serhiy Storchaka :
The main difference between platforms is that the first argument of the foreach
function is int on some platforms and unsigned long on others.
PR 28295 fixes code not only on DragonflyBSD, but on FreeBSD and OpenBSD, where
it is unsigned long. It is a
Serhiy Storchaka added the comment:
The struct module has 4 different modes. By default it uses not only native
byte order, but native sizes and alignments which depend on OS and compiler.
You need to know all these details just to understand the format codes. I think
that the struct module
Serhiy Storchaka added the comment:
In the stdlib, there is only one use of to_bytes() with sys.byteorder (2 in
tests), 16 uses of to_bytes()/from_bytes() with 'little' (22 in tests) and 22
uses with 'big' (33 in tests). So making sys.byteorder the default will help
al
Serhiy Storchaka added the comment:
We recently discussed the RTLO attack on Python sources (sorry, I don't
remember on what resource) and decided that we should do something with this. I
think this is a related issue.
--
___
Python tr
Change by Serhiy Storchaka :
--
components: +Unicode
nosy: +ezio.melotti, serhiy.storchaka, vstinner
type: -> behavior
versions: +Python 3.11 -Python 3.8
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
New changeset 92bf8691fb78f3484bf2daba836c416efedb1d8d by Serhiy Storchaka in
branch 'main':
bpo-43413: Fix handling keyword arguments in subclasses of some buitin classes
(GH-26456)
https://github.com/python/cpyt
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
assignee: -> serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45176>
___
___
Python-bugs-list mailing list
Un
Serhiy Storchaka added the comment:
Perhaps it is because "little" is checked first. One call of
_PyUnicode_EqualToASCIIId() for "little" and two for "big".
--
___
Python tracker
<h
Change by Serhiy Storchaka :
--
nosy: +serhiy.storchaka
nosy_count: 4.0 -> 5.0
pull_requests: +26717
pull_request: https://github.com/python/cpython/pull/28303
___
Python tracker
<https://bugs.python.org/iss
New submission from Serhiy Storchaka :
The proposed PR rewrites the loading of sqlite3 tests. Instead of explicitly
enumerating test modules and test classes in every module, and manually
creating test suites, it uses unittest discover ability. Every new test files
and test classes will be
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26718
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28304
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
See issue45181. Most of this code is gone.
Also, TestLoader has mutable attribute "errors". I am not sure that it is good
idea to share it between unrelated tests.
--
___
Python track
New submission from Serhiy Storchaka :
requires_zlib is a decorator factory which returns a decorator, not a
decorator. It should always be followed by parenthesis. In
Lib/distutils/tests/test_bdist_rpm.py it is used improperly, so the
corresponding tests were never ran
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26719
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28305
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
New changeset 851811f5772c43f72f445e2ce1ac3ea9da951ae3 by Serhiy Storchaka in
branch 'main':
bpo-5846: Do not use obsolete unittest functions. (GH-28303)
https://github.com/python/cpython/commit/851811f5772c43f72f445e2ce1ac3e
Serhiy Storchaka added the comment:
I think it is better to narrow the __getattr__. It can break protocols using
other special methods.
--
nosy: +gvanrossum, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
New changeset 9260e6739865c966c3ec6c5c289e0b96f848403e by Serhiy Storchaka in
branch 'main':
bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)
https://github.com/python/cpython/commit/9260e6739865c966c3ec6c5c289e0b
Serhiy Storchaka added the comment:
New changeset 3e19409d6443c66a6a7d62f58b2bb4e8330e56c4 by Serhiy Storchaka in
branch 'main':
bpo-45181: Simplify loading sqlite3 tests (GH-28304)
https://github.com/python/cpython/commit/3e19409d6443c66a6a7d62f58b2bb4
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Serhiy Storchaka added the comment:
If you can remove context managers in arbitrary order it is no longer a stack.
I think that it is just a wrong tool for your problem. Just maintain a
collection of opened connections. Set or dict can be better that list or deque.
--
nosy
New submission from Serhiy Storchaka :
test.test_ssl.TestEnumerations is not run when run ssl tests. If add it to the
list of test classes it fails:
==
ERROR: test_options (test.test_ssl.TestEnumerations
New submission from Serhiy Storchaka :
Test classes ISOTPTest, J1939Test, BasicUDPLITETest, UDPLITETimeoutTest in
test_socket are not included in the list of test classes and are not run by
regrtest.
--
components: Tests
messages: 401725
nosy: serhiy.storchaka
priority: normal
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26727
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28317
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
PR 28317 makes test classes in test_socket be autocollected instead of
explicitly enumerated. This will save as from similar errors in future.
--
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
I meant that the current __getattr__ breaks deepcopy(). It can break also other
protocols. It already has a list of exceptions, we need to add "__copy__" and
"__deepcopy__" in this list. Or maybe exclude all dunder names by default a
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Serhiy Storchaka :
--
pull_requests: +26734
pull_request: https://github.com/python/cpython/pull/28324
___
Python tracker
<https://bugs.python.org/issue45
Change by Serhiy Storchaka :
--
keywords: +patch
nosy: +serhiy.storchaka
nosy_count: 1.0 -> 2.0
pull_requests: +26765
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28351
___
Python tracker
<https://bugs.p
Serhiy Storchaka added the comment:
But why do you need to execute 'from __future__ import barry_as_FLUFL' in your
interpreter at first place? Don't do this and you would not need to revert its
effect.
--
___
Python
Serhiy Storchaka added the comment:
Yes, [[] looks as the start of a character set containing nested sets (e.g.
"[[a-z]--[p-q]]"). This feature is supported by regex and can be added in
future versions of re, breaking the code which contain such co
Serhiy Storchaka added the comment:
New changeset 1a9ef5798525bbb39a16c8af5c435b97352ee027 by Serhiy Storchaka in
branch 'main':
bpo-44786: Fix a warning in RE in c-analyzer (GH-28351)
https://github.com/python/cpython/commit/1a9ef5798525bbb39a16c8af5c435b
Serhiy Storchaka added the comment:
New changeset 89966f59c2e1d0558f8126458acc7d7ae2a8fef5 by Miss Islington (bot)
in branch '3.10':
bpo-44786: Fix a warning in RE in c-analyzer (GH-28351) (GH-28353)
https://github.com/python/cpython/commit/89966f59c2e1d0558f8126458acc7d
Change by Serhiy Storchaka :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.10
___
Python tracker
<https://bugs.python
Serhiy Storchaka added the comment:
New changeset d897579a80da3f4572d96501c41bec6cacb10d84 by Nikita Sobolev in
branch 'main':
bpo-45185: enables `TestEnumerations` in `test_ssl` (GH-28330)
https://github.com/python/cpython/commit/d897579a80da3f4572d96501c41bec
Serhiy Storchaka added the comment:
Thank you Nikita!
The test was added in issue38659 and was not backported, so it is 3.11 only
issue.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.10, P
New submission from Serhiy Storchaka :
Dangling threads are reported when run test_socket tests which raise SkipTest
in setUp() in refleak mode.
$ ./python -m test -R 3:3 test_socket -m testBCM
0:00:00 load avg: 2.53 Run tests sequentially
0:00:00 load avg: 2.53 [1/1] test_socket
beginning 6
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26775
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28361
___
Python tracker
<https://bugs.python.org/issu
Change by Serhiy Storchaka :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45083>
___
___
Python-bugs-
Change by Serhiy Storchaka :
--
pull_requests: +26789
pull_request: https://github.com/python/cpython/pull/28317
___
Python tracker
<https://bugs.python.org/issue45
Change by Serhiy Storchaka :
--
dependencies: +Dangling threads in skipped tests in test_socket
___
Python tracker
<https://bugs.python.org/issue45187>
___
___
Serhiy Storchaka added the comment:
I do not think that PR 28299 is correct. We want to deprecate these functions
which are implemented in the unittest.loader module, not just names exported to
the unittest module.
--
___
Python tracker
<ht
New submission from Serhiy Storchaka :
Difflib docstrings contain short descriptions of functions and methods defined
in the module and classes. It is redundant because pydoc shows descriptions for
every function and method just few lines below. For example:
| Methods
Change by Serhiy Storchaka :
--
pull_requests: +26797
pull_request: https://github.com/python/cpython/pull/28382
___
Python tracker
<https://bugs.python.org/issue5
Serhiy Storchaka added the comment:
New changeset 7dacb70485a0910eb298c24b4d051720ca56fb91 by Serhiy Storchaka in
branch 'main':
bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361)
https://github.com/python/cpython/commit/7dacb70485a0910eb298c24b4d0517
Serhiy Storchaka added the comment:
Yes, it is a deliberate choice. It is difficult to explain why it was passed
without it -- dues to a specific order of calling tearDown() and callbacks
registered with addCleanup() in different base classes.
Using an event object would fix it too, but
Serhiy Storchaka added the comment:
New changeset f798cef87faeb428bdb9ebf73df1a6146304 by Miss Islington (bot)
in branch '3.10':
bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when
building (GH-28393) (GH-28394)
https://github.com/python/cpyt
New submission from Serhiy Storchaka :
Python/specialize.c: In function ‘load_method_fail_kind’:
Python/specialize.c:878:1: warning: control reaches end of non-void function
[-Wreturn-type]
878 | }
| ^
--
components: Interpreter Core
messages: 402001
nosy: serhiy.storchaka
Change by Serhiy Storchaka :
--
pull_requests: +26815
pull_request: https://github.com/python/cpython/pull/28403
___
Python tracker
<https://bugs.python.org/issue43
Serhiy Storchaka added the comment:
I do not have any particular use case. It was a side effect of unification code
that uses _PyArg_NoKeywords().
--
___
Python tracker
<https://bugs.python.org/issue43
New submission from Serhiy Storchaka :
It can be reproduced when run test.test_socket.J1939Test (omitted in regrtests
now, see issue45187) with Address Sanitizer. See for example
https://github.com/python/cpython/pull/28317/checks?check_run_id=3625390397.
It can be reproduced when run
Change by Serhiy Storchaka :
--
dependencies: +Stack buffer overflow in parsing J1939 network address
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
Running omitted tests exposed some real bugs. See issue45212, issue45228.
--
___
Python tracker
<https://bugs.python.org/issue45
Change by Serhiy Storchaka :
--
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issue45228>
___
___
Python-bugs-list mailin
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26816
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28404
___
Python tracker
<https://bugs.python.org/issu
New submission from Serhiy Storchaka :
Currently regrtest supports two ways of collecting and running tests in module.
1. If the module contains the "test_main" function, regrtest just calls it.
This function usually calls run_unittest() with a list of test classes,
composed manual
Change by Serhiy Storchaka :
--
keywords: +patch
pull_requests: +26817
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28405
___
Python tracker
<https://bugs.python.org/issu
Serhiy Storchaka added the comment:
PR 28405 contains simple changes for 60 test files. It does not cover files
which use complex code for generating list of test classes and running doctests
(because there are subtle differences between running doctests with
run_doctest() and via
Change by Serhiy Storchaka :
--
dependencies: +Some tests in test_socket are not run,
test.test_ssl.TestEnumerations is not run
___
Python tracker
<https://bugs.python.org/issue45
Serhiy Storchaka added the comment:
New changeset 773319545ba60577bc140aa46eac83b360240b7a by Serhiy Storchaka in
branch 'main':
bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404)
https://github.com/python/cpython/commit/773319545ba60577bc140aa46eac83
1701 - 1800 of 25874 matches
Mail list logo
