Change by Senthil Kumaran :
--
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue42782>
___
___
Python-bugs-list mailing list
Un
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue22708>
___
___
Python-bugs-list mai
Change by Senthil Kumaran :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue43332>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
stage: commit review -> resolved
___
Python tracker
<https://bugs.python.org/issue43332>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Hello Pandu,
Thank you for this patch and the explanation. Does client blocking on repeated
challenge from the server (using of while loop) look okay here?
The conversation here indicates to me that it is fine. Is there any
recommendation or
Senthil Kumaran added the comment:
Petr, thank you. Let's treat it as a new issue linked to this.
--
___
Python tracker
<https://bugs.python.org/is
Change by Senthil Kumaran :
--
versions: +Python 3.10 -Python 3.5, Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue40837>
___
___
Pytho
Senthil Kumaran added the comment:
This will be a breaking change to the clients relying on current broken
behavior, setting the fix version to 3.10 (current active).
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue40
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python
Change by Senthil Kumaran :
--
versions: +Python 3.10, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue40471>
___
___
Python-bugs-list m
Change by Senthil Kumaran :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue39314>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Hi All,
On the previous message.
> I plan to address that point raised in this issue and close this ticket.
My intention was to close the bug.
1) The Issue was originally a regression in 3.8, and 3.7, And this been be
resolved.
The change introduced
Senthil Kumaran added the comment:
Michał, for this particular issue, to rely on the expected and consistent
parsing behavior, it might easier to add "scheme" to URLs in the client code.
That will be less confusing IMO. Not sure if __future__ is a good idea.
Personally, I am
Senthil Kumaran added the comment:
Chris, my understanding of the primary objection in your previous post was with
a violation of backward compatibility. It was resolved by reverting.
The 3.9+ changes are useful ones, particularly when well-defined behaviors are
listed for URLs with the
Senthil Kumaran added the comment:
> The problem is: double slashes are perfectly legal in a URI/URL, and for
> reasons I don't understand, they are in use in the wild
And what is the de-facto behavior of browsers, when double URL is used?
As far as I know, the browsers remove th
Senthil Kumaran added the comment:
Hi Tal,
Thank you. To be specific, it is about parsing behavior, specifically urljoin
behavior,
There is no question about the validity of the double-slash in the URL.
If we find a source (like libcurl) which exhibits parsing behavior different
than
Senthil Kumaran added the comment:
I will spend time on this on 12-June or 13-June, 2020.
At the very least, if no changes are required, I will document this for 3.7 and
higher versions.
--
assignee: docs@python -> orsenthil
___
Python trac
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
This is now fixed in all active versions of python. No documentation changes
required for this change.
--
___
Python tracker
<https://bugs.python.org/issue34
Senthil Kumaran added the comment:
> How did you test them?
https://about.google//products/
https://www.google.com///search?q=something
Were redirecting, and collapsing multiple slashes to single.
Now, when I try this on:
> https://en.wikipedia.org/w//index.php?search=foobar+somethin
Senthil Kumaran added the comment:
Hugo, please go ahead and a test for this patch.
--
assignee: -> orsenthil
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
Hugo, I'd welcome such a change.
--
___
Python tracker
<https://bugs.python.org/issue24955>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Hello Maarten,
> Using cgitb, I found out that the webdriver expects the environment variable
> `HTTP_X_URWID_METHOD` to be set. The javascript sets the "X-Urwid-Method"
> header (using XmlHttpRequest), but these are not visible by the C
Senthil Kumaran added the comment:
Irit, yes. Serhiy's patch could be converted to a GitHub PR and it can be
merged.
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/is
Senthil Kumaran added the comment:
Hi James, I will give another look at it tonight or latest by Sunday PST ,
since I was involved in this and PRs. If we can make a decision within this
context, great, otherwise we can open it up to python-dev
On Sat, Oct 17, 2020 at 3:30 PM James Addison
Senthil Kumaran added the comment:
New changeset 16ee68da6e12bb2d79751b32cc37523fe4f4bb48 by Jacob Neil Taylor in
branch 'master':
bpo-38976: Add support for HTTP Only flag in MozillaCookieJar (#17471)
https://github.com/python/cpython/commit/16ee68da6e12bb2d79751b32cc3752
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
> so was this fixed?
Irit, not really. This is adding another hook called "progress hook" in
addition to the "report hook". We need to evaluate if this is really required.
--
status: pending -> open
Senthil Kumaran added the comment:
Yes. The required 'feature' was introduced through
https://github.com/python/cpython/pull/17471/ even as the patches were slightly
different. But keeping https://github.com/python/cpython/pull/17471/ seems fine
and we can close this ticket
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue13294>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Eric - noted the point. :)
--
___
Python tracker
<http://bugs.python.org/issue13294>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
I add -o as a short form for --slow. regrtest was using getopt and this
conflicting option was not caught. I see it is a bug than a feature so the
change is made in 3.2 and 3.3
default: b84f61fdcb4c and 6797e7458ad0
Thanks for catching this bug, Erno Tukia
Senthil Kumaran added the comment:
Here we go! I thought the problem did not exist in py3k, but good that the
tests caught them and we have a fix now.
Thanks for the complete patch, Joonas. I hope it was easy to port the patch to
3k. The encoding part may perhaps be the only thing to careful
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue13766>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Fixed now. Thanks!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue13736>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
title: urlparse.urlunsplit() can't handle relative files (for urllib*.open() ->
Disallow relative files paths in urllib*.open()
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: performance -> behavior
versions: +Python 2.7, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Actually, I saw this as a bug with urllib.urlopen and urllib2 had
exhibited proper behaviour previously. Now, both behaviour will be
consistent now.
But, you are right that an *incorrect* usage of urllib.urlopen would
break in 2.7.2.
If we need to be
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue13856>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for submitting the patch. Couple of comments.
1. This is a new feature, so the patch should be addressed against 3.x.
2. The patch lacks tests and documentation and hence it is not complete.
You could take a look at http/client.py or ssl.py (with
Senthil Kumaran added the comment:
>>> urljoin("http://";, "//somedomain.com")
results in "http://somedomain.com";
So, I wonder if this way to specify the relative url properly and not the
base-url.
The test suite of urlparse tries to follow all th
Senthil Kumaran added the comment:
On Sun, Jan 29, 2012 at 10:48:35PM +, Martin v. Löwis wrote:
> orsenthil: I don't fully understand your question (what kind of "carrying"
> should the clients do);
By that I mean, sending the ca_file and cert_reqs from the client,
Senthil Kumaran added the comment:
On Sun, Jan 29, 2012 at 10:30:45PM +, Antoine Pitrou wrote:
>
> Well, if you are a security expert you can volunteer to maintain a
> trusted certificates' file in the Python repository :) I think
> nobody else amongst us is qualified.
Senthil Kumaran added the comment:
I think, I was using wrong terminology, by 'sending' I meant, 'using' the
ca_file in the client to verify Server's certificates.
--
___
Python tracker
<http:
Senthil Kumaran added the comment:
I am sorry. I see that with context object in 3.x, verification is being done.
The CA certs can be pointed to using load_verify_locations.
As the author had in this patc tothe pass on addition ca_certs and ca_reqs to
wrap_socket in ssl from httplib2. I
Senthil Kumaran added the comment:
On Wed, Feb 08, 2012 at 03:42:16AM +, Eli Bendersky wrote:
> Any objections?
None. The explanation sounds reasonable.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
I have stumbled upon a wrong impression as well by reading the docs, but
usually in the code, I tend to catch the specific Exceptions, like timeout
instead or URLError when it is known. I saw some libraries following similar
pattern too. But that could be
Senthil Kumaran added the comment:
Thanks for patches. This is fixed.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Added suggested changes to the documentation. Thanks.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Stephen - urlencode is responsible for producing the
application/x-www-form-urlencoded format, usually used in the FORMs in the web.
As per the spec, the Space characters are replaced by `+'. -
http://www.w3.org/TR/html4/interact/forms.html#h-17.1
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14072>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
A couple of points to help summarize and to help come to a conclusion.
In the initial message, Stephen pointed out, "it would be desirable to merely
encode spaces using percent encoding".
It seems to me that only in cases where a custom handlin
Senthil Kumaran added the comment:
If I recollect correctly, redirecting a POST request with POST data is not a
recommended thing to do and could be a security hazard. That's why RFC
prohibits it too. It is intentional that urllib2 is not redirecting carrying
along the POST data. Coul
Senthil Kumaran added the comment:
Oh Sorry. I shall fix this by this weekend.
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Here is a section which talks about 3xx redirection
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
10.3 Redirection 3xx
This class of status code indicates that further action needs to be taken by
the user agent in order to fulfill the request
Senthil Kumaran added the comment:
It's an interesting issue. Thanks for the report and patch, Xavier. I am
setting patch to needing review.
--
keywords: +needs review -patch
nosy: +orsenthil
versions: +Python 2.7, Python 3.3
___
Python tr
Senthil Kumaran added the comment:
Hi Jay & Éric,
I understand your points and providing an extra argument seems like an idea
that could be useful to circumvent , what you see as a problem.
The RFC section states that -
"The action required MAY be carried out by the user agen
Senthil Kumaran added the comment:
On Mon, Mar 05, 2012 at 11:15:38AM +, Éric Araujo wrote:
> Ah, so there is a way to achieve it! If Jay is satisfied by this,
> we could add an example of using that in the urllib howto, with the
> appropriate warnings. That would have much less
Senthil Kumaran added the comment:
I am closing this issue as I feel that the requirement may not be addressed by
a change. If there is patch for HowTo, we can tackle that in another issue.
Thank you for contribution.
--
resolution: -> invalid
status: open ->
Senthil Kumaran added the comment:
Couple of points:
1. On your last example, which webserver treats 'L' as part of port number? I
can't of anything.
2. Can you write a "real application" which is listening to beyond 65535? Which
platform would it be?
Current way
Senthil Kumaran added the comment:
I reviewed the patch, built the docs and found it good.
Fixed it in 3d877dee1bde and aaf45928899c
Thanks!
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
versions: -Python 2.7
___
Python t
New submission from Senthil Kumaran :
Opening the this bug following this discussion -
http://mail.python.org/pipermail/docs/2012-March/007829.html
library/re.html
\S
When the LOCALE and UNICODE flags are not specified, matches any non-whitespace
character; this is equivalent to the set
Senthil Kumaran added the comment:
This clarification is specific to Python 2.7.
For Python3, the use of LOCALE flag is explicitly discouraged and
confusing references to it's meaning is not present in the docs.
--
___
Python tracker
Senthil Kumaran added the comment:
Just a minor comment on the patch - It should be %r instead of %s.
-raise TypeError('must be str, not %s' % type(s))
+raise TypeError('must be str, not %r' % type(s))
If there is any test for this, it could b
Senthil Kumaran added the comment:
One at the time - urlretrieve is re-written. Now should add deprecation
warnings to things methods to be deprecated / removed.
--
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
Thanks for the patch, Jeff McNeil. I pushed the patches to 3.2 and 3.3 docs.
Since it is a documentation change (an explaination rather), I did not update
the NEWS.
Thanks again!
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Yes, it is simply a matter of adding warnings.warn in proper classes
and methods. I have started on that, Jeff. No problem. I just wanted
the changes to be two separate commits. Thanks!
--
___
Python tracker
Senthil Kumaran added the comment:
Here is patch which adds DeprecationWarning to URLOpener and (it's subclasses
FancyURLopener) as well as some other Request methods.
The idea would be, in the next release we remove this old URLOpener and it's
subclasses and remove (or make _pr
Senthil Kumaran added the comment:
My concern was with the method get_full_url. I have seen it being
useful in more than one place and it's not just the accessor. Others
are just the accessors and those can be safely removed. When
get_full_url gives the correct url, taking into consider
Senthil Kumaran added the comment:
It should be noted that diff in git supported format is recommended in the
devguide -
http://docs.python.org/devguide/committing.html#minimal-configuration
If it breaks the rietveld integration, then we should not be advising it.
--
nosy
Senthil Kumaran added the comment:
Éric - not really. nonlocal is from python3.x onwards only.
--
___
Python tracker
<http://bugs.python.org/issue14217>
___
___
Yeah, the other option is to fix the tracker-reitveld integration.
(Which I assumed was harder because diff did not give hg info required
for it)
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archi
Senthil Kumaran added the comment:
Closing this based on - msg155387. The upstream bug is "unfortunately" closed
as OLD. We can reopen if this stumble upon this again.
--
resolution: -> invalid
stage: needs patch -> committed/rejected
status
Senthil Kumaran added the comment:
I have rewritten some parts of the documentation, explaining the use of charset
parameter with Content-Type header. Used the suggestions from the previous
patch's review comments too. I see that other parts of the documentation can
be improved furth
Senthil Kumaran added the comment:
To note in the tracker, the original 2.6 code was changed in Issue 2254 and the
relevant changeset is c6c4398293bd
I find, Glenn's suggestion a possibly okay solution for PATH_INFO problem,
keeping in tact the security issue the the previous change
Senthil Kumaran added the comment:
Actually no. I revert back my previous statement. Meddling with splitpath
breaks all the tests.
--
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
I treated this as a regression from 2.6. A cgi url with
/cgi-bin/hello.py/hello/world would have PATH_INFO as '/hello/world'
I saw some apache specs saying that it should be 'hello/world', but I relied on
python2.6's behavior with h
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10487>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
superseder: -> Make CGIHTTPServer capable of redirects (and status other than
200)
___
Python tracker
<http://bugs.python.org/issu
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10485>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Instead of what's new, I think, linking the benchmarks in the docs could be
helpful so that library users can find it they want to. I think, we have
similar performance benchmark links at other places too.
--
nosy: +orse
Senthil Kumaran added the comment:
It's funny, Antoine had raised an issue too. Should see why is this
sporadic failures..
--
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
That's not an error, but in fact a correct statement. Please test it in the
interpreter.
--
nosy: +orsenthil
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
type
Senthil Kumaran added the comment:
On Tue, Apr 03, 2012 at 08:37:35AM +, Ezio Melotti wrote:
>
> Ezio Melotti added the comment:
>
> + hg import --no-commit < mywork.patch
>
> Is the '<' correct here?
No!. It should just be hg import --no-commit mywo
Senthil Kumaran added the comment:
Well, I would like to correct this further and add clarification based on the
current implementation (_sre.c)
The definition of LOCALE Space is this -
#define SRE_LOC_IS_SPACE(ch) (!((ch) & ~255) ? isspace((ch)) : 0)
And the definition of NON_S
Senthil Kumaran added the comment:
Hi David,
I am sorry, I did not notice your second comment in this bug and later when you
closed this, noticed the bug report.
Yes, the default=None but actually pointing to a sentinel value is an odd duck
and I believe the explanation in docs were
Senthil Kumaran added the comment:
I had to carefully review a lot of changes for this. In addition, I did setup a
apache and tested the behaviors too.
Few notes -
- The test for _url_collapse_path_split is not directly helpful, especially
for PATH_INFO. I removed my previous changes I
Senthil Kumaran added the comment:
Hi Antoine,
I saw that check_warnings was commonly used ( and perhaps I had used to earlier
without any problems) and overlooked assertWarns. But I think, it is good to
remove support.check_warnings dependency here and just use assertWarnings. Let
me see
Senthil Kumaran added the comment:
Hello Glenn,
Your suggestions were valid. I have made those changes in the code. Thanks! I
think, we can close this bug now and move over to others.
Thanks,
Senthil
--
status: open -> closed
___
Python trac
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14560>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I am trying to this test this to determine the fault.
--
assignee: -> orsenthil
nosy: +orsenthil
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
In that case, transparent decompression should not be available. (
Request header should not be sent and response wont be compressed).
--
___
Python tracker
<http://bugs.python.org/issue1508
Senthil Kumaran added the comment:
I tested setting cookies with ":" in the cookie name in both firefox and
google-chrome. They both seem to allow and store the cookie with ":" in them.
Firefox sent a request header like this:
Set-Cookie test:value=solution:is:he
Senthil Kumaran added the comment:
Hi Barry,
I stumbled upon this bug when trying to compile Python2.6 from source on Ubuntu
11.10. If this bug report or the related one issue11715 is a problem due to
Ubuntu changes, I think, it is good inform in the download or news page. People
try
Senthil Kumaran added the comment:
Thanks for this engagement and pull requests, Steve.
Thanks for reviews Karthikeyan.
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue36
Senthil Kumaran added the comment:
Hi Victor and Karthikeyan,
Both your analysis are correct.
- This is a legacy interface, present purely for satisfying the old code, when
urlretrieve was advertised as the first/easy to way to use urllib and download
something.
- At this moment, I think
Senthil Kumaran added the comment:
Suggesting the use of context and deprecating `cafile=None, capath=None,
cadefault=False` sounds like a good idea.
--
___
Python tracker
<https://bugs.python.org/issue37
801 - 900 of 1788 matches
Mail list logo
