[issue44360] test_compile killed by SIGKILL on AMD64 Ubuntu 3.x

2021-06-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, this was related to the Linux OOM Killer. The agent went down shortly after this. Either multiple parallel jobs might have led to OOM or something else. I will see if logs provide more information

[issue44360] test_compile killed by SIGKILL on AMD64 Ubuntu 3.x (Linux OOM Killer)

2021-06-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: > Maybe you should give more memory to your worker, or you should spawn less > jobs in parallel It was related to high number of jobs in that particular agent and result in OOM Kill from the Linux kernel - https://pastebin.com/559H4ksa The machi

[issue44359] test_ftplib fails as "env changes" if a socket operation times out in a thread: TimeoutError is not catched

2021-06-11 Thread Senthil Kumaran
Change by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue44359> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29555] Update Python Software Foundation Copyright Year

2021-07-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, closing this. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-07 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: +patch nosy: +orsenthil nosy_count: 3.0 -> 4.0 pull_requests: +26153 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27664 ___ Python tracker <https://bugs.python.org/i

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset ebecffdb6d5fffa4249f9a813f1fc1915926feb5 by Senthil Kumaran in branch 'main': bpo-44830 - Remove the broken Broken Mozilla devguide link. (GH-27664) https://github.com/python/cpython/commit/ebecffdb6d5fffa4249f9a813f1fc1

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-07 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +26155 pull_request: https://github.com/python/cpython/pull/27666 ___ Python tracker <https://bugs.python.org/issue44

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 6a6bcf16370beff2e0d1a034661654d5c335b5ee by Miss Islington (bot) in branch '3.9': bpo-44830 - Remove the broken Broken Mozilla devguide link. (GH-27664) (GH-27665) https://github.com/python/cpyt

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: @Jack, if you review this backport - https://github.com/python/cpython/pull/27666 , I can merge this PR. -- ___ Python tracker <https://bugs.python.org/issue44

[issue45067] Failed to build _curses on CentOS 7

2021-08-31 Thread Senthil Kumaran
New submission from Senthil Kumaran : I verified that ncurses-devel is installed. ./configure is able to verify ncurses checking curses.h usability... yes checking curses.h presence... yes checking for curses.h... yes checking ncurses.h usability... yes checking ncurses.h presence... yes

[issue45067] Failed to build _curses on CentOS 7

2021-09-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: Here is the output of make with relevant lines. CC='gcc -pthread' LDSHARED='gcc -pthread -shared' OPT='-DNDEBUG -g -fwrapv -O3 -Wall' _TCLTK_INCLUDES='' _TCLTK_LIBS='' ./python -E ./setup.p

[issue45067] Failed to build _curses on CentOS 7

2021-09-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: A change like this will be required since these funcs were introduced only recently and nurses shipped with centos was older. % git diff diff --git a/Modules/_cursesmodule.c b/Modules/_cursesmodule.c index 61aaf85522..6fb6c490e6 100644 --- a/Modules

[issue45067] Failed to build _curses on CentOS 7

2021-09-09 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: +patch pull_requests: +26680 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28260 ___ Python tracker <https://bugs.python.org/issu

[issue45067] Failed to build _curses on CentOS 7

2021-09-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: I have created a pull request - https://github.com/python/cpython/pull/28260 Please review this. -- assignee: -> orsenthil versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.pyth

[issue45067] Failed to build _curses on CentOS 7

2021-09-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 794430700defb913512f871b701a888aa730de81 by Senthil Kumaran in branch 'main': bpo-45067 - Verify the version of ncurses for extended color support feature usage. (GH-28260) https://github.com/python/cpyt

[issue45067] Failed to build _curses on CentOS 7

2021-09-09 Thread Senthil Kumaran
Change by Senthil Kumaran : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.9 ___ Python tracker <https://bugs.python.or

[issue40321] urllib.request does not support HTTP response status code 308

2021-10-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset c379bc5ec9012cf66424ef3d80612cf13ec51006 by Jochem Schulenklopper in branch 'main': bpo-40321: Support HTTP response status code 308 in urllib.request (#19588) https://github.com/python/cpython/commit/c379bc5ec9012cf66424ef3d80612c

[issue28533] Remove asyncore, asynchat and smtpd modules

2021-11-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: +1 to these modules removal. One concern I have is when users follow internet examples and look out for these modules or examples. What is the best way to show them the modern usage? - Should Python docs show some example snippet of the most common usage

[issue45795] urllib http client vulnerable to DOS attack

2021-11-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: > Timeout value should not be reset after client receives a data(bytes), > because it can easily be abused to achieve DOS. Interesting. I looked the server example. Does clients like curl have something like th

[issue45795] urllib http client vulnerable to DOS attack

2021-11-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Muhammad, I haven't gotten to this. urllib doesn't maintain a client state during multiple request / response. The code is available here https://github.com/python/cpython/tree/main/

[issue38686] WWW-Authenticate qop="auth,auth-int" rejected by urllib

2019-11-13 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue38686> ___ ___ Python-bugs-list mai

[issue38686] WWW-Authenticate qop="auth,auth-int" rejected by urllib

2019-11-22 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: +Python 3.8 -Python 3.6 ___ Python tracker <https://bugs.python.org/issue38686> ___ ___ Python-bugs-list mailin

[issue38686] WWW-Authenticate qop="auth,auth-int" rejected by urllib

2019-11-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 14a89c47983f2fb9e7fdf33c769e622eefd3a14a by Senthil Kumaran (PypeBros) in branch 'master': bpo-38686: fix HTTP Digest handling in request.py (#17045) https://github.com/python/cpython/commit/14a89c47983f2fb9e7fdf33c769e62

[issue38686] WWW-Authenticate qop="auth,auth-int" rejected by urllib

2019-11-22 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: +Python 3.7 ___ Python tracker <https://bugs.python.org/issue38686> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38686] WWW-Authenticate qop="auth,auth-int" rejected by urllib

2019-11-22 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: +Python 3.9 -Python 2.7, Python 3.7 ___ Python tracker <https://bugs.python.org/issue38686> ___ ___ Python-bugs-list m

[issue38686] WWW-Authenticate qop="auth,auth-int" rejected by urllib

2019-11-22 Thread Senthil Kumaran
Change by Senthil Kumaran : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker <https://bugs.python

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2019-12-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset f82e59ac4020a64c262a925230a8eb190b652e87 by Senthil Kumaran in branch '2.7': [2.7] bpo-27973 - Fix for urllib.urlretrieve() failing on second ftp transfer (#1040) https://github.com/python/cpyt

[issue35411] FTP tests of test_urllib2net fail on Travis CI: 425 Security: Bad IP connecting.

2019-12-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset f82e59ac4020a64c262a925230a8eb190b652e87 by Senthil Kumaran in branch '2.7': [2.7] bpo-27973 - Fix for urllib.urlretrieve() failing on second ftp transfer (#1040) https://github.com/python/cpyt

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2019-12-30 Thread Senthil Kumaran
Change by Senthil Kumaran : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue27973> ___ ___

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2019-12-31 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +17207 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/17774 ___ Python tracker <https://bugs.python.org/issu

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2019-12-31 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the note, Pablo. I am going to check if this patch https://github.com/python/cpython/pull/17774 will solve the Windows buildbot issues. -- stage: patch review -> resolved ___ Python tracker <

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2019-12-31 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Pablo, Is there a way for us to test https://github.com/python/cpython/pull/17774 on a Windows Builder which displayed the post-commit failure? The CI custom-builders seem to be broken for a different reason: https://buildbot.python.org/all/#/builders

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2020-01-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the suggestion, David. I have updated the PR 17774 to use temp_support instead of NamedTemporaryFile. Please review this. -- ___ Python tracker <https://bugs.python.org/issue27

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2020-01-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: Sorry, I have updated it now: https://github.com/python/cpython/pull/17774 (I had pushed to a different branch earlier and it didn't reflect in my PR) -- ___ Python tracker <https://bugs.python.org/is

[issue14132] Redirect is not working correctly in urllib2

2020-01-03 Thread Senthil Kumaran
Change by Senthil Kumaran : -- nosy: -Joony898i title: SEO Services Development & PHP development -> Redirect is not working correctly in urllib2 ___ Python tracker <https://bugs.python.org/

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2020-01-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 5bba60290b4ac8c95ac46cfdaba5deee37be1fab by Senthil Kumaran in branch '2.7': bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the (#17774) https://github.com/python/cpyt

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2020-01-03 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +17245 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/17819 ___ Python tracker <https://bugs.python.org/issu

[issue27657] urlparse fails if the path is numeric

2020-01-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: @James - Originally the issue was considered a revert and the versions were set for the merge, but I certainly recognize the problem when parsing can fail for simple URLs like `localhost:8000` which is very common. Another developer had raised the concerns

[issue17005] Add a topological sort algorithm

2020-01-09 Thread Senthil Kumaran
Change by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue17005> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37970] urllib.parse docstrings incomplete

2020-02-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Ido, there was a change requested by a core-dev, Zachary , on your PR. > Please have a look at PEP 257 for docstring formatting guidelines. https://github.com/python/cpython/pull/16458/files#r353422155 Please let us know if that is addres

[issue27657] urlparse fails if the path is numeric

2020-02-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Lukaz / Ned: I will like to revert the backports done in 3.8 and 3.7. Preferably in 3.8.2 and 3.7.7, so that this undesirable behavior exists only for a single release. I have set this is a release blocker to catch your attention. -- nosy

[issue39603] [security] http.client: HTTP Header Injection in the HTTP method

2020-02-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: Welcome to work on the patch, Amir. * We shouldn't be encoding anything. * Create reject for Unicode control characters and reject the request if the request contains any control character. Write tests for this. It will similar to one of the exa

[issue27657] urlparse fails if the path is numeric

2020-02-16 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: +patch pull_requests: +17902 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/18525 ___ Python tracker <https://bugs.python.org/issu

[issue27657] urlparse fails if the path is numeric

2020-02-16 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +17903 pull_request: https://github.com/python/cpython/pull/18526 ___ Python tracker <https://bugs.python.org/issue27

[issue27657] urlparse fails if the path is numeric

2020-02-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 505b6015a1579fc50d9697e4a285ecc64976397a by Senthil Kumaran in branch '3.7': Revert "bpo-27657: Fix urlparse() with numeric paths (GH-661)" (#18526) https://github.com/python/cpython/commit/505b6015a1579fc50d96

[issue27657] urlparse fails if the path is numeric

2020-02-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset ea316fd21527dec53e704a5b04833ac462ce3863 by Senthil Kumaran in branch '3.8': Revert "[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-16839)" (GH-18525) https://github.com/python/cpython/commit/ea316fd21527dec53e70

[issue27657] urlparse fails if the path is numeric

2020-02-25 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Łukasz, There was a concern raised by python core-devs about behavior in 3.9. I plan to address that point raised in this issue and close this ticket. -- ___ Python tracker <https://bugs.python.org/issue27

[issue39548] Request fails when 'WWW-Authenticate' header for Digest Authentication does not contain 'qop'

2020-02-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 5e260e0fde211829fcb67060cfd602f4b679f802 by Stephen Balousek in branch 'master': bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest Auth (GH-18338) https://github.com/python/cpython/commit/5e260e0fde211829fcb6

[issue39548] Request fails when 'WWW-Authenticate' header for Digest Authentication does not contain 'qop'

2020-02-29 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> orsenthil resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue38976] Add support for HTTP Only flag in MozillaCookieJar

2020-03-30 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue38976> ___ ___ Python-bugs-list mai

[issue40291] socket library support for CAN_J1939

2020-04-29 Thread Senthil Kumaran
Change by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue40291> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10486] http.server doesn't set all CGI environment variables

2020-12-01 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: +patch pull_requests: +22473 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/23604 ___ Python tracker <https://bugs.python.org/issu

[issue10486] http.server doesn't set all CGI environment variables

2020-12-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: I spent some time reviewing and researching the specification. It also says The server is not required to create meta-variables for all the header fields that it receives. And this in issue, open since 2010, we have issue two different set of

[issue5054] CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed

2020-12-01 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> orsenthil versions: +Python 3.10, Python 3.9 -Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker <https://bugs.python.org/iss

[issue5054] CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed

2020-12-04 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +22506 pull_request: https://github.com/python/cpython/pull/23638 ___ Python tracker <https://bugs.python.org/issue5

[issue5054] CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed

2020-12-05 Thread Senthil Kumaran
Change by Senthil Kumaran : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue5054] CGIHTTPRequestHandler.run_cgi() HTTP_ACCEPT improperly parsed

2020-12-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: This was also resolved in 3.10 https://github.com/python/cpython/pull/23638 -- ___ Python tracker <https://bugs.python.org/issue5

[issue18140] urlparse, urlsplit confused when password includes fragment (#), query (?)

2020-12-18 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: +Python 3.10 -Python 2.7, Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue18140> ___ ___ Pytho

[issue18140] urlparse, urlsplit confused when password includes fragment (#), query (?)

2020-12-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Not a bug. The message #msg375109 explains how to quote and unquote the '#' in the password field, and demonstrates how urllib parses it correctly. I guess, it was set to open as a mistake. Closing it again. -- stage: -> resolved

[issue23328] urllib.request fails for proxy credentials that contain a '/' character

2020-12-23 Thread Senthil Kumaran
Change by Senthil Kumaran : -- title: urllib2 fails for proxy credentials that contain a '/' character -> urllib.request fails for proxy credentials that contain a '/' character versions: +Python 3.10 -Python 2.7 ___

[issue41450] OSError is not documented in ssl library, but still can be thrown

2020-12-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is resolved by Issue 31122 and code now raises SSLEOFError instead of OSError. The reason for OSError in the first place was PySSL_SetError function had the following call s->errorhandler(); https://github.com/python/cpython/blob/3.7/Modules/_ss

[issue41450] OSError is not documented in ssl library, but still can be thrown

2020-12-27 Thread Senthil Kumaran
Change by Senthil Kumaran : -- components: +Library (Lib) -Documentation versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue41

[issue23328] urllib.request fails for proxy credentials that contain a '/' character

2020-12-27 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: +patch pull_requests: +22818 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/23973 ___ Python tracker <https://bugs.python.org/issu

[issue23328] urllib.request fails for proxy credentials that contain a '/' character

2020-12-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: https://github.com/python/cpython/pull/23973 will resolve this issue. The issue was localized to _parse_proxy method in urllib2. -- ___ Python tracker <https://bugs.python.org/issue23

[issue1398781] Example in section 5.3 "Pure Embedding" doesn't work.

2020-12-28 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: -easy versions: +Python 3.10 -Python 2.6 ___ Python tracker <https://bugs.python.org/issue1398781> ___ ___ Python-bug

[issue8822] datetime naive and aware types should have a well-defined definition that can be cross-referenced

2020-12-28 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: +Python 3.10 -Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker <https://bugs.python.org/issue8

[issue8481] doc: ctypes no need to explicitly allocate writable memory with Structure

2020-12-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is a not a bug, it asks for parameter types to explained. API documentation reference should provide the guidance. -- nosy: +orsenthil resolution: -> wont fix stage: -> resolved status: open -> closed versions: +Python 3.10 -P

[issue8595] Explain the default timeout in http-client-related libraries

2020-12-28 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: docs@python -> orsenthil versions: +Python 3.10 -Python 2.6, Python 2.7, Python 3.1 ___ Python tracker <https://bugs.python.org/iss

[issue23328] urllib.request fails for proxy credentials that contain a '/' character

2020-12-29 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue23328> ___ ___ Python-bugs-list mailin

[issue23328] urllib.request fails for proxy credentials that contain a '/' character

2020-12-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: Merged in 3.10 - https://github.com/python/cpython/commit/030a713183084594659aefd77b76fe30178e23c8 3.9 - https://github.com/python/cpython/commit/df794406a8803e3d6062af8404d7564833f9af28 3.8 - https://github.com/python/cpython/commit

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-20 Thread Senthil Kumaran
Change by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue42967> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42985] AMD64 Arch Linux Asan 3.x fails: command timed out: 1200 seconds without output

2021-01-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: > IMO we should disable ASAN (handling of signals) at runtime when we trigger a > crash on purpose (ex: faulthandler._sigsegv()). > ASAN_OPTIONS="handle_segv=0". Both sound reasonable. But not sure if they will resolve this crash toug

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: Ken, Please don't close your PR. I will review it. It has a CLA signed which is helpful. On Fri, Jan 22, 2021 at 4:53 AM Ken Jin wrote: > > Ken Jin added the comment: > > Adam, I linked a PR 2 days ago here > https://github.com/pytho

[issue43075] ReDoS in request

2021-01-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: +1. The suggested fix looks good to me. -- ___ Python tracker <https://bugs.python.org/issue43075> ___ ___ Python-bugs-list m

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: Ned, and others watching. In future versions of Python, we can use only "&" based separator. But I am not certain what should be proposed for the older releases of Python. Adam's Patch is a good one to specify explicitly specify th

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-01-30 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <https://bugs.python.org/issue42967> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: Sorry for that, Ned. I will take a decision on this by Saturday (13-Feb). I did some research, but could come way conclusively. I have not heard any opinions (+ves or -ves) on this. This will be a breaking change, so necessary to support it with

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: I meant, "I did some research, but couldn't come away conclusively". -- ___ Python tracker <https://bugs.pyt

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: I finished reviewing this PR https://github.com/python/cpython/pull/24297 With the contexts given in W3C recommendation, Synk.io Security Report and pattern of usage in libraries like werkzeug and bottle, instead of ignoring this and letting this behavior

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Éric, I considered the possibility of bringing it in python-dev, but thought it could be decided in this ticket itself. 1. This was already brought up by multiple Release Managers in Python-dev, and some conversation seems to have happened there previously

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset fcbe0cb04d35189401c0c880ebfb4311e952d776 by Adam Goldschmidt in branch 'master': bpo-42967: only use '&' as a query string separator (#24297) https://github.com/python/cpython/commit/fcbe0cb04d351894

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +23315 pull_request: https://github.com/python/cpython/pull/24528 ___ Python tracker <https://bugs.python.org/issue42

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +23316 pull_request: https://github.com/python/cpython/pull/24529 ___ Python tracker <https://bugs.python.org/issue42

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +23318 pull_request: https://github.com/python/cpython/pull/24531 ___ Python tracker <https://bugs.python.org/issue42

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-14 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +23319 pull_request: https://github.com/python/cpython/pull/24532 ___ Python tracker <https://bugs.python.org/issue42

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset a2f0654b0a5b4c4f726155620002cc1f5f2d206a by Ken Jin in branch 'master': bpo-42967: Fix urllib.parse docs and make logic clearer (GH-24536) https://github.com/python/cpython/commit/a2f0654b0a5b4c4f726155620002cc

[issue42967] [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset c9f07813ab8e664d8c34413c4fc2d4f86c061a92 by Senthil Kumaran in branch '3.9': [3.9] bpo-42967: only use '&' as a query string separator (GH-24297) (#24528) https://github.com/python/cpython/commit/c9f07813ab8e664d

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-02-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is resolved in all version of Python now. Thank you all for your contributions! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed title: [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as

[issue13559] Use sendfile where possible in httplib

2021-02-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Alex, https://bugs.python.org/issue23740 is identified as a dependency on this issue. We will have to resolve that first, and come back to this. And yes, if you contribute on other's patch, both the contributions will be included and appropriately cre

[issue13559] Use sendfile where possible in httplib

2021-02-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, the point number 5. We will have to evaluate if sendfile side-steps and avoids the issues noted in issue23740 -- ___ Python tracker <https://bugs.python.org/issue13

[issue42782] shutil.move creates a new directory even on failure

2021-03-02 Thread Senthil Kumaran
Change by Senthil Kumaran : -- versions: -Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue42782> ___ ___ Python-bugs-list mailin

[issue42782] shutil.move creates a new directory even on failure

2021-03-02 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <https://bugs.python.org/issue42782> ___ ___ Python-bugs-list mai

[issue42782] shutil.move creates a new directory even on failure

2021-03-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 132131b404e06ee1a19b040a1f96cd1118abed0c by Winson Luk in branch 'master': bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001) https://github.com/python/cpython/commit/132131b404e06ee1a19b040a1f96cd

[issue42994] Missing MIME types for opus, AAC, 3gpp and 3gpp2

2021-03-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset 3a87e562ea21a5083e9f168e02e8ec3e6611e167 by Nathan Beals in branch 'master': bpo-42994: Add MIME types for opus, AAC, 3gpp and 3gpp2 (#24287) https://github.com/python/cpython/commit/3a87e562ea21a5083e9f168e02e8ec3e6611e167 -

[issue42994] Missing MIME types for opus, AAC, 3gpp and 3gpp2

2021-03-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the this contribution, Nathan. -- assignee: -> orsenthil resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python

[issue43288] test_importlib failure due to missing skip() method

2021-03-02 Thread Senthil Kumaran
Change by Senthil Kumaran : -- assignee: -> nascheme resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python

[issue43075] ReDoS in request

2021-03-02 Thread Senthil Kumaran
Change by Senthil Kumaran : -- keywords: +easy (C) ___ Python tracker <https://bugs.python.org/issue43075> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42782] shutil.move creates a new directory even on failure

2021-03-03 Thread Senthil Kumaran
Change by Senthil Kumaran : -- pull_requests: +23498 pull_request: https://github.com/python/cpython/pull/24725 ___ Python tracker <https://bugs.python.org/issue42

[issue42782] shutil.move creates a new directory even on failure

2021-03-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: New changeset bf566847f5a97e6ce391f8fb94185ee756cb94a2 by Senthil Kumaran in branch '3.9': [3.9] bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001) (#24725) https://github.com/python/cpyt

[issue42782] shutil.move creates a new directory even on failure

2021-03-03 Thread Senthil Kumaran
Change by Senthil Kumaran : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

<    3   4   5   6   7   8   9   10   11   12   >