Senthil Kumaran added the comment:
SimpleHTTPServer is never meant to be used in production.
I was of the understanding that we already inform users about it in the
documentation, but I do not find any such note. Only in wsgiref's
simple_server.py example, we state that in the module h
Senthil Kumaran added the comment:
Thanks for the report, Pankaj Sharma. Removed in 2.7.11+.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tr
Senthil Kumaran added the comment:
Hi @Berker,
This patch breaks the unit tests. Could you confirm (or reject) this?
Thanks
--
___
Python tracker
<http://bugs.python.org/issue6
Senthil Kumaran added the comment:
The bltin-file-objects was not referenced in pyspecific.py from which this data
was generated. Added it and fixed it.
Verified that it is available in 2.7 now.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status
Senthil Kumaran added the comment:
Please use stackoverflow or python-tutor list to get help on this.
https://mail.python.org/pipermail/tutor/
This is unlikely a problem as you are using replace the send time on new string
object.
--
nosy: +orsenthil
resolution: -> rejected
st
Senthil Kumaran added the comment:
Thanks for patch and the work on Green Tree Snakes, Thomas.
It is a great resource. I agree that a lot could be included directly in stdlib
docs, but till then, as suggested/recommended by Andrew and Ezio, a see also
link is a good addition
Changes by Senthil Kumaran :
--
assignee: -> martin.panter
___
Python tracker
<http://bugs.python.org/issue25940>
___
___
Python-bugs-list mailing list
Un
Senthil Kumaran added the comment:
Here is the patch with the changes suggested by Brett.
Having created this patch, I had second thoughts on this change. Folks who use
pip often, usually use it without any quotes, like `pip install requests`, `pip
install CherryPy`. Pinned down versions are
Senthil Kumaran added the comment:
Here is the patch with the suggested wording.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file41530/Issue23675.patch
___
Python tracker
<http://bugs.python.org/issue23
Changes by Senthil Kumaran :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue23675>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Fixed in all branches for which documentation will be published / updated.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open
Senthil Kumaran added the comment:
This bug report can be closed as the patch, written by me is no longer valid.
The only useful addition it can bring is, exposing the BUFSIZE, but that is
used transparently by the module and I think, it need not be exposed via
documentation
Senthil Kumaran added the comment:
This was an interesting issue. Thanks for the patch, Sean to fix this bug. I
have committed it in 3.5 and 3.6.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versi
New submission from Senthil Kumaran:
A number of old methods in trace module were deprecated in issue10371. They
should be removed in 3.6 release.
--
components: Library (Lib)
messages: 257877
nosy: belopolsky, orsenthil
priority: normal
severity: normal
stage: needs patch
status: open
Senthil Kumaran added the comment:
This patch removes the deprecated apis from 3.6. After getting a review from
one another core dev, I will commit this.
* No doc changes are required as the deprecated apis were not documented.
* README will be added during commit.
--
assignee
Senthil Kumaran added the comment:
Sorry for that. Here is the patch.
--
keywords: +patch
Added file: http://bugs.python.org/file41562/issue26069.patch
___
Python tracker
<http://bugs.python.org/issue26
Senthil Kumaran added the comment:
@Martin, thanks for the review comments. I've addressed this is version 2 of
the patch. I am submitting this change.
--
versions: +Python 2.7, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41563/Issue23675-v2.
Senthil Kumaran added the comment:
Fixed in the active documentation branches 2.7,3.5 and 3.6.
--
assignee: docs@python -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
I reviewed the patch. It looks like the problem is not just with list functions
but with other options too. Like.
$ ./python.exe -m trace -t
$ ./python.exe -m trace -c
$ ./python.exe -m trace -T
Will throw the same error. So, any changes should address all
Senthil Kumaran added the comment:
The patch is correct and will fix the issue. It will require test coverage to
be complete so that we don't land upon similar issues in future.
--
nosy: +orsenthil
stage: -> test needed
versions: +Python 3.5, Python 3.6 -Py
Senthil Kumaran added the comment:
@SilentGhost, I agree with you. I am making the change to use argparse as part
of this issue24649. And this bug could be covered as part of the change to
argparse.
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
Thanks for the review, matrixise. I've submitted this change.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
Hi Berker, could you find the reference for it? It will be helpful to analyze.
IMO, the non-removal of 2.x-> 3.x APIs could be done on a case to case basis.
In this case, issue10371 made the change in (2010) of making the undocumented
public methods
Senthil Kumaran added the comment:
The patch looks good to me. The change is in the error message of the
AssertionError and don't test the error messages of Exceptions in our unittest.
This change is a good usability improvement and I will commit this patch.
--
assignee: -> o
Senthil Kumaran added the comment:
Verified the change and committed.
The new output behavior will be like this.
```
>>> from unittest.mock import Mock
>>> mock = Mock(return_value=None)
>>> for i in range(1, 10):
... mock(i)
...
>>> from unittest.mock
Senthil Kumaran added the comment:
@SilentGhost,
Thanks a lot for the quick turn around of a patch. I have left some review
comments in reitveld. Please address them.
Since this is underlying implementation change in option processing/parsing, it
should only in feature release (3.6).
Thank
Senthil Kumaran added the comment:
Simon, sure. It is just for someone, either commiters or other interested folks
to add the tests on top of your patch. Agree with you that more change is
required to add the required tests.
--
___
Python tracker
Senthil Kumaran added the comment:
Thanks for the contribution. The option handling of trace module is modernized
now.
As berker suggested in one of the review comments, this module could see an
increase in test coverage and we could deal with this as separate ticket.
--
resolution
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue25822>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
Thank you, Swati.
I reviewed and committed your patch. I had to make some minor formatting
changes while keeping an eye for the maintainability of the module and doc
strings.
* Moved all the doc strings up to a single place just below the namespaces are
Senthil Kumaran added the comment:
Thanks for the report. Fixed.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the patch, Upendra Kumar. It's fixed now. Appreciate your taking
care of other args and making the change meaningful.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolve
Senthil Kumaran added the comment:
Thank you for the report. Fixed in the active versions of python (3.5 and 3.6).
3.4 was in security fix mode. Although, it can see important documentation
bug-fixes, this isn't bug-fix as far as 3.4 version is concerned. So, I didn't
make the cha
Senthil Kumaran added the comment:
Thanks for the pointers, Berker. That was very helpful and I will keep in mind
when evaluating other deprecated apis.
For the trace module, I will add this removal information in
Doc/whatsnew/3.6.rst
Senthil Kumaran added the comment:
Thanks for reporting. Fixed.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the review/comment Ezio. Agree with your suggestion and made the
change accordingly.
--
assignee: docs@python -> orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 2.7, Python
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue26134>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@Serhiy, the patch looks good to me. This change is an excellent idea. Please
commit it.
--
assignee: berker.peksag -> serhiy.storchaka
stage: patch review -> commit review
___
Python tracker
Senthil Kumaran added the comment:
Given that we have not received any more reports on users tripping up on this
message, it seems to me that we could just ignore this report and close it.
Thoughts?
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
Thanks for the report and the patch. I have fixed that in 3.5 and 3.6 docs. I
found it reasonable to include the full module path for TimeoutError makeing it
consist with asyncio and multiprocessing TimeoutError.
Also, Error exception is not exposed via
Senthil Kumaran added the comment:
I followed the previous discussions and reviewed the patch. With respect to the
patch, I see few drawbacks in providing links to references like this:
`fcntl <http://pubs.opengroup.org/onlinepubs/009695399/basedefs/fcntl.h.html>`_
`ioctl
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue26150>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for the report. Fixed.
--
assignee: davin -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
type: enhancement -> behavior
version
Senthil Kumaran added the comment:
Thanks for the patch. I had to do some minor clarification like mention view
types apply only to dict and also remove the sentence which mentioned those
equivalent to list(o.values()) and list(o.items()) in the patch.
With those fixed, I have commited the
Senthil Kumaran added the comment:
Thanks. Fixed in
https://hg.python.org/cpython/rev/2b35ef6a9853
https://hg.python.org/cpython/rev/ad5b079565ad
https://hg.python.org/cpython/rev/125d27d9cf9b
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue26779>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for your contribution, Luiz. It's a useful improvement.
Committed to all active branches.
2.7 changeset: 101012:e3ed950ad728
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 2
Senthil Kumaran added the comment:
Hi Hans-Peter,
I agree with Martin's comments and suggestion.
If I understand the suggestion correctly, the only change will be a
documentation change. Isn't it?
Because getproxies_environment() in it's current form already fetches the
l
Senthil Kumaran added the comment:
Luiz,
The original question was about introducing a parameter to override query
string separate ';'.
If we do with enable or disable, then we should provide another option for
query string separator.
The OP provided one example of query string
Senthil Kumaran added the comment:
The patch is committed in changeset 9afe77ad549b.
Thanks for update Brandon. Citing the original source and stating the rationale
for this suggestion was a great addition.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status
Senthil Kumaran added the comment:
no_proxy is applicable to ProxyHandler of the python 3. I've documented this in
the corresponding section.
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
Senthil Kumaran added the comment:
This is fixed in all versions of Python.
Thank you for your contribution, Hans-Peter Jansen.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python track
Senthil Kumaran added the comment:
Serhiy:
I left review comments on the patch too.
I agree to "tightening" of the input arg type in these urlparse functions.
Before we for the next version, I think, it will be helpful to enumerate the
behavior for wrong arg types for these func
Senthil Kumaran added the comment:
Hi Chi Hsuan,
The patch looks good to me. Additional tests for the coverage of this will be
helpful too. Thanks!
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue26
Senthil Kumaran added the comment:
Thanks for raising this issue, Chris Beaumont.
Fixed in 2.7.x
--
nosy: +orsenthil
type: -> behavior
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Thank you for the patch, Chi Hsuan Yen.
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.5
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Thanks for the report, Salvo.
And thank you for the patch, SilentGhost. This is fixed in the active versions
of python.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Senthil Kumaran added the comment:
zope should be http://www.zope.org/
The pythonlabs link could be removed.
The logos at pythonlabs link does not exist. Reference for pythonlab exists in
a humorous form here: http://www.pythonlabs.com/
--
nosy: +orsenthil
Changes by Senthil Kumaran :
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue27042>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
On Mon, May 16, 2016 at 08:40:51PM +, Serhiy Storchaka wrote:
> > zope should be http://www.zope.org/
>
> Isn't this is a different legal entity?
Is it? I don't know. I can find no references to zope.com being
different than zope.org
Senthil Kumaran added the comment:
This is fixed and online docs will reflect it when they get built in their next
build cycle.
Thanks for the report.
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -&g
Senthil Kumaran added the comment:
One patch should be enough, @James. The committer will take care of
porting. Thanks! ( I am yet to completely read the discussion/ review the
patch and I will do that shortly.)
--
___
Python tracker
<h
Senthil Kumaran added the comment:
I agree with the comment made by Oren. Not all instances of finder should be
referenced as generic finder. Some classes and functions are are still PEP 302
specific finder.
In the commit, 3987667bf98f Nick Coghlan modified the following functions to to
use
Senthil Kumaran added the comment:
For 3.5 version of patch, we have bring in some additional changes from
issue26896 which properly clarified finder from importer. These changes are not
required in the default branch.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
This is 3.3 version of patch attached.
--
Added file: http://bugs.python.org/file44383/issue20842-3.3-v5.patch
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
Change committed.
- 3.5 * 103098:ecbad01262c8
- default * 103099:ee58ece83391
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<http://bug
Senthil Kumaran added the comment:
The documentation changes made as part of this issue were applicable to 3.5
branch too.
I had to touch the docs in this area as part of issue20842, and ended up with
two patches one for 3.5 and another 3.6.
I think, it is a good idea to backport the change
Senthil Kumaran added the comment:
Hi Brett, I backported only portions of the patch some this issue that were
applicable to the issue that I was fixing. I will backport remain portions so
that everything will be consistent now.
--
Added file: http://bugs.python.org/file44427
Senthil Kumaran added the comment:
I've updated the patch to use unittest.mock, the removed the old style way of
exercising it.
--
nosy: +orsenthil
Added file: http://bugs.python.org/file44429/issue11551.patch
___
Python tracker
Senthil Kumaran added the comment:
Here is an updated patch that increases the coverage to 100% and has some pep8
style improvements.
shannon-2:issue11551 senthil$ ./python.exe -m test.regrtest test_dummy_thread
Run tests sequentially
0:00:00 [1/1] test_dummy_thread
1 test OK.
Total duration
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue28022>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
This patch fixes this. It makes the documentation consistent with the code.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file44479/103351.patch
___
Python tracker
<http://bugs.python.
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Yes, urllib.request.urlopen needs an update too. It takes those certfile and
keyfile and usage of those could be deprecated in favor of context.
--
___
Python tracker
<http://bugs.python.org/issue28
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue24363>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@Martin, I weight in 'curl's behavior for de-facto things that differ slightly
from standards. It's simply what folks have gotten used to, and sometimes
expect.
@Raymond, unit-tests will be a go
Senthil Kumaran added the comment:
Hi Sohaib,
I will get the proper fix for this issue.
A comment on the patch. Changing the API to `def open(self, fullurl, data=None,
ftp_retrieve=False):` just breaks the abstraction of the open method and may
not be the way to go for this. Any changes
Senthil Kumaran added the comment:
Using logging, instead of sys.stderr would be a welcome change in this module.
--
keywords: +easy, needs review
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue28
Senthil Kumaran added the comment:
The patch looks good to me.
(The test coverage for chrome browser can be improved. But that seems a like a
different change than the current one).
--
assignee: -> orsenthil
nosy: +orsenthil
versions: +Python 3.7 -Python 3.4, Python
Senthil Kumaran added the comment:
Linking __init__.py to /dev/null is very odd. Do you know bazel does that?
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue28
Senthil Kumaran added the comment:
I wanted to ask, Do you know why bazel does that?
--
___
Python tracker
<http://bugs.python.org/issue28425>
___
___
Python-bug
Senthil Kumaran added the comment:
Applying on 2.7 seems alright. Bug fix.
--
___
Python tracker
<http://bugs.python.org/issue24452>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
The patch looks good to me. Thank you, Xiang. I will apply it.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue28
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue28432>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@Sohaib,
Thanks for the ping. Yeah, I will act on it.
Your analysis in msg276795 seems plausible, On the patch itself, I will try to
reproduce this and see if I can avoid introducing this clear_buffer function.
If no other go, then it should just be a
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue27973>
___
___
Python-bugs-list mailing list
Unsubscrib
1701 - 1788 of 1788 matches
Mail list logo
