Senthil Kumaran added the comment:
Thanks for the comments.
Shall come with the tests.
Yes,it currently does not handle chained redirects via cache. I dont know RFC's
stance on it. RFC does not say anything about 301 chained redirects and there
are tricker issues of caching anything
Senthil Kumaran added the comment:
Attaching a non-malformed patch. I had incomplete tests in previous ones and I
removed it by-hand before submitting for review. Something went wrong, I see.
Okay, I get the points you are making. Specifically a request specific object
and then maintaining a
Changes by Senthil Kumaran :
Removed file:
http://bugs.python.org/file15745/urllib2-301-redirection-proper.diff
___
Python tracker
<http://bugs.python.org/issue1755
Changes by Senthil Kumaran :
Removed file:
http://bugs.python.org/file15722/urllib2-301-redirection-CORRECTED.diff
___
Python tracker
<http://bugs.python.org/issue1755
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file8117/liburllib2.patch
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Python-bug
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file8116/test_urllib2-cache.patch
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Pytho
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file8115/urllib2-301-cache.patch
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Pytho
Senthil Kumaran added the comment:
Fixed in revision 77367
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Yes, I indeed, I quickly moved to patch it up in the trunk and did a svn submit
-m "..." I had your big patch for tests in the trunk. I have reverted it for
now and shall fix this one only.
--
___
Pyth
Senthil Kumaran added the comment:
Fixed in revision 77411 for trunk. Will merge it to other branches.
--
versions: +Python 2.6, Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue7
Changes by Senthil Kumaran :
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue7648>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
merged it in other branches: r77413,r77414,r77415.
This fixes the errors in test_trivial tests. Verified on windows.
--
assignee: -> orsenthil
status: open -> closed
___
Python tracker
<http://bugs.p
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue7665>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Just a Note: test_file in py26 had problems with multiple ips in this scenario
(execute test.test_urllib2 from different drive in windows), but not in the
py3k version. I need to verify it py26-maint/trunk
Senthil Kumaran added the comment:
FWIW, it should also be noted that RFC asserts square brackets to be
valid characters in the hostname portion only and that too when it is
a IPv6 url.
In the example given, at the query portion, it should be quoted (or
percent-encoded
Senthil Kumaran added the comment:
On Mon, May 17, 2010 at 01:38:57PM +, Florent Xicluna wrote:
> Committed in r81265 for 2.7.
Thanks. That was interesting. Without resorting to any drastic changes like
use of regex, interesting speed-up seems to have been achieved by
using rsplit and
Changes by Senthil Kumaran :
--
assignee: orsenthil -> flox
resolution: -> fixed
stage: patch review -> committed/rejected
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
HTTP Ref says that Server can send any encoding, if client does not
specify Accept-Encoding header. But if 'identity' is one of the
encoding that server recognizes (?), then it should send it as
identity, which indicates untransformed content.
I a
Senthil Kumaran added the comment:
Fixed it in revision 81279 and other branches.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue8744>
___
___
Python-bugs-list
Senthil Kumaran added the comment:
The functionality provided by urllib.request._urlopener can be accomplished in
a more natural way using build_opener. Historically, _urlopener was there for
urllib and build_opener style came in urllib2.
So, I think, this can be safely be removed from the
Senthil Kumaran added the comment:
Actually, I see certain use-cases of _urlopener in py3k. Most visible one being
urllib.request.urlretrieve and also URLOpener.open which is different from
build_opener way of doing things.
- But still, public exposure of overriding globals to can be removed
Senthil Kumaran added the comment:
Removed in r81283 and r81284.
With respect to the technical details of exposing this functionality for
_urlretrieve and URLOpener.
- users can still do it.
- There is a better way, if the other global _opener be served for the same
purpose, so that
Senthil Kumaran added the comment:
Ashley Sands wrote:
> Is this the right approach?
Follow the process mentioned here:
http://www.python.org/dev/faq/
And create a patch against Docs/library/importlib.rst with the
reference to PEP 3147 included. That is it. Look for other places
where
Senthil Kumaran added the comment:
Here is the proper link:
http://www.cs.princeton.edu/research/techreps/TR-554-97
Fixed those references in the code too.
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
Senthil Kumaran added the comment:
This is a platform specific bug. It is happening only on windows.
BTW, makelink should not have been called for this file, because it
is not a link or symlink, but a regular file.
--
nosy: +orsenthil
___
Python
Senthil Kumaran added the comment:
tarek: Issue2987 has the details on changes made for ipv6 urlparse.
Those can't be backported as it's a feature. I would rather like to see whats
breaking in distutils2.
The url which resulted in this bug in distribute:
"http://www.famf
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
stage: unit test needed -> needs patch
___
Python tracker
<http://bugs.python.org/issue1368368>
___
__
Senthil Kumaran added the comment:
Is the behavior you posted observable on trunk?
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Okay, I see you have mentioned 2.6.5 in the Title.
I will try the following to reproduce this.
1) Try a Basis Auth which is working.
2) Pass an Invalid username/password and see the behavior.
--
___
Python tracker
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue8801>
___
__
Senthil Kumaran added the comment:
I am just reopening this, as per dcj's comment.
--
resolution: fixed -> accepted
status: closed -> open
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
urllib2 is currently catching the socket.error exceptions and presenting the
reason as custom URLError exception. To address this issue, the module should
catch the httplib raised exceptions also and present it.
--
assignee: -> orsenthil
n
Senthil Kumaran added the comment:
please ask help at python-h...@python.org or comp.lang.python
--
nosy: +orsenthil
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
This is fixed in r81636, r81637, r81638, r81637.
Just like the Digest Authentication, the urllib2 will try for 5 times before
failing for any authentication failure ( It won't lead to recursion).
I had a thought that Basic Authentication need not be re
Senthil Kumaran added the comment:
Agree to your concern that doseq parameter is not properly explained.
Fixed in r81645, r81646, r81647 and r81648.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -&g
Senthil Kumaran added the comment:
The point of retry is for auth failure, which can happen due to any reason. It
is not just for a wrong password.
I was thinking just doing a single verification and failing, but did find some
resources (not just browsers) which adopt this approach of retry
Senthil Kumaran added the comment:
There was a fix made in issue8797, which adopts a retry approach before failing
for wrong password. This is present for Basic Auth and Digest Auth, so the
problem wont be faced. Jurjen, do you have any comments before I mark this as
Invalid. I see you have
Senthil Kumaran added the comment:
Okay, so there is another negative vote 5 retries in the basic auth.
But yeah, this bug can be marked duplicate.
--
___
Python tracker
<http://bugs.python.org/issue8
Senthil Kumaran added the comment:
Duplicate of issue8797
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Agree to single retry for Basic Auth. We are just dealing with
BasicAuthentication here, so that's why we did not have in the
HTTPPasswdManager. But, let me consider that viewpoint too.
--
status: closed -&
Senthil Kumaran added the comment:
Fixed in r81687, r81688, r81689 and r81690.
Yes, I see that before the original change was made any chuncked encoding went
through _read_chunked which close the resp before returning. So, here for HEAD,
the resp is closed thus fixing the problem mentioned
Senthil Kumaran added the comment:
I saw the earlier tests was closing it explicitly. Removed that and added a
test which verifies the closed resp obj. Thanks.
--
___
Python tracker
<http://bugs.python.org/issue6
Senthil Kumaran added the comment:
The reason the the password is prompted is because, on 401 authentication
failure, there is a retry logic by default. When the authentication is retried,
it is prompted for username:password using getpass. When using GUI modules it
is desired to override
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue9003>
___
__
Senthil Kumaran added the comment:
Yes, the problem is observed in py3k. Pickle module when used via Interactive
console is trying to import the class as __console__.ClassName and it is
failing to see the __console__ module.
_pickle.PicklingError: Can't pickle : import of
m
Senthil Kumaran added the comment:
On Wed, Jun 16, 2010 at 12:16:38PM +, Éric Araujo wrote:
> Forgot the conclusion: I suspect noone will want to work on that.
Nope, please don't come to that conclusion soon. It is a valid
request. It is not that only maintainers listed will work
Senthil Kumaran added the comment:
Fixed in r82018.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Merged into other branches in r82020, r82022 and r82023.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Yes, it is applicable to 3.1 and 3.2 as well. This is definitely a good to have
performance improvement.
--
nosy: +orsenthil
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue3
Senthil Kumaran added the comment:
Yes, I felt the same way and that is the reason for providing extra
example snippets in the same Documentation. I hope you checked that
one.
--
___
Python tracker
<http://bugs.python.org/issue8
Senthil Kumaran added the comment:
Yes, its valid doc change request. Thought it means the same, the minor
docstring improvement can be done.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue4
Senthil Kumaran added the comment:
The docstring "Make this process the process group leader" is proper for
setpgrp. Fixed in r82047, r82048, r82049 and r82050.
--
resolution: -> fixed
stage: -> committed/rejected
status
Senthil Kumaran added the comment:
Fixed in r82068 and r82069. As mentioned in msg107883, this functionality is
should not be relied upon. It is present for legacy apps. I have added a NEWS
note mentioning that there is a change in behavior (if legacy apps owners can
catch it
Senthil Kumaran added the comment:
On Sat, Jun 19, 2010 at 08:00:55PM +, Shashwat Anand wrote:
> Why on Mac OS X, it should return s.lower() ?
That is is because some file systems on Mac OS X are case-sensitive.
> def normcase(s):
> """Normalize case of pathna
Senthil Kumaran added the comment:
> There is a small mistake in the docs:
Yes there was. Fixed in 82146.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Nice patch. I like the use of new string formating. It can be applied.
BTW, do you think that TODO of s.lower() for MAC OS X should be addressed along
with this. It might require some research as how much of a desirable behavior
it would be
Senthil Kumaran added the comment:
Replacing 'http://localhost' with 'http://127.0.0.1' for this test is fine.
But, urllib.proxy_bypass returning for True for any string, is not correct. In
the code, I see that Proxy Settings from Mac OSX system configuration is
Senthil Kumaran added the comment:
I am +0 on this change. The existing introduction is fine and the
discussion where shallow and deep copy is discussed is more important.
It is okay to assume that the reader is aware of the assignment
operation nature, i.e. it does not create a copy and you
Senthil Kumaran added the comment:
I see that ismount like function on windows is provide by the various
Win32 extensions.
If Windows supported is added to ismount function itself, then it might be
a good idea to have attributes or list_attributes function as well.
But for posix, how will it
Senthil Kumaran added the comment:
You mean "Table of Contents"? The index at the end serves as a
bookmark, right? Also, Table of Contents might add up couple of more
pages to traverse.
--
nosy: +orsenthil
___
Python trac
Senthil Kumaran added the comment:
> Can you post a link to this tutorial here?
Section 9.1 and 9.2 of the docs.python.org/tutorial
It may not be as explicit as you might want it to be, but it does sets
up background that assignments do not copy the obj
Senthil Kumaran added the comment:
I guess, Antoine wanted to point out this:
"Changed in version 2.3: MersenneTwister replaced Wichmann-Hill as the
default generator."
But as the paragraph points out Python did provide non default WichmanHill
class for generating repeatable sequ
Senthil Kumaran added the comment:
There isn't a problem with urllib with respect to threading as such.
There are programs and examples which use this module in multi-threading
environment.
I could not run your app, I am not on Mac, but some of the changes you could
try is:
- N
Senthil Kumaran added the comment:
On Wed, Jun 23, 2010 at 03:46:35PM +, Craig Younkins wrote:
> cgi.escape never escapes single quote characters, which can easily
> lead to a Cross-Site Scripting (XSS) vulnerability. This seems to be
> known by many, but a quick search reveals
Changes by Senthil Kumaran :
--
versions: +Python 3.2 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue1172711>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
I doubt we would care about changing the version number in Python 2.5.
Python 2.5 *might be* only in Security Fix mode and this does not
qualify for a change in Python 2.5. So, just leave it as it is and
don't rely on the version number is in the a
Changes by Senthil Kumaran :
--
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Capitalization is a language property, it is not Python specific. By
Definition, except for first letter every thing else is lower cased.
http://en.wikipedia.org/wiki/Capitalization
So, Python documentation assumes that it is understood (or can referred to
Senthil Kumaran added the comment:
Fixed in r82322 and r82323.
Actually urllib.urlopen.info method return a mimetools.Message instance and a
HTTPMessage instance is used within httplib only. It is more internal purposes
to deal with headers with add_continue like methods is required
Senthil Kumaran added the comment:
Fixed in r82324, r82325, r82326, r82327.
Only the urlunsplit need the docstrings, I added that.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python track
Senthil Kumaran added the comment:
-1 on chdir returning a the directory name.
-1 on having it as context manager.
Both are non-intuitive and may not serve any utility value. This can be
verified by looking the code at the places where these functions are currently
used. Brian also mentions
Senthil Kumaran added the comment:
That was a Documentation mistake. Thanks for pointing out.
Corrected it in revision 82334 and merged to other branches.
--
___
Python tracker
<http://bugs.python.org/issue3
Senthil Kumaran added the comment:
On Mon, Jun 28, 2010 at 04:50:12PM +, anatoly techtonik wrote:
>I also can't see how can I verify you assumptions by looking at the code.
In the python source:
find -name "*.py" | xargs grep 'os.chdir'
gives 143 instance
Senthil Kumaran added the comment:
Yes, I know httplib documentation needs improvement. There is a great deal of
documentation in the module itself. A lot can be .rst'ifed.
--
assignee: georg.brandl -> orsenthil
nosy: +orsenthil
resolution: -> accepted
stage: -> needs
Senthil Kumaran added the comment:
On Mon, Jun 28, 2010 at 08:51:58PM +, ThomasH wrote:
> But the urllib.rst documentation is still flawed:
Fixed now in the r82363. Did a find and grep on all instances of
HTTPMessage and verified that it is only at proper places now.
Thanks for point
Senthil Kumaran added the comment:
This is already handled via namedtuple in the urlparse. All the parts of the
url are available by parsing.
--
resolution: -> out of date
stage: unit test needed -> committed/rejected
status: open -&g
Senthil Kumaran added the comment:
David, Is the stage "unit test needed" proper for this or was it by mistake?
Anatoly, I thought closing this feature request was fine, because I considered
that with namedtuple the desired attributes of url's were obtained as
ParsedTupl
Senthil Kumaran added the comment:
I see no problem in going ahead with the suggestion proposed and the patch.
- I checked with RFC3986 Section 2.5
http://labs.apache.org/webarch/uri/rfc/rfc3986.html#identifying-data
Relevant line:
When a new URI scheme defines a component that represents
Senthil Kumaran added the comment:
Fixed and Committed revision 82510 (py3k) and revision 82511 (release31-maint).
This fixes urlencode issue. parse_qs and parse_qsl can have the same
capabilities. It will be done subsequently (in another commit or issue)
Thanks Dan for the bug report and
Senthil Kumaran added the comment:
Fixed it in r82570.
Hyper linking lowered was leading to something like str.lower ed. So, I simply
left it.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
_
Senthil Kumaran added the comment:
Updated the docstrings in r82573.
--
___
Python tracker
<http://bugs.python.org/issue9091>
___
___
Python-bugs-list mailin
Changes by Senthil Kumaran :
--
title: SMTPHandler does not handle unicode strings -> SMTPHandler in the
logging module does not handle unicode strings
___
Python tracker
<http://bugs.python.org/iss
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue5286>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
There were differing behaviors in the way urllib and urllib2 was handling
certain kind of file:// urls which led to this error. I just made them
consistent with the fix in r82780 and merged into branches. Now, this
Exception won't be thrown at the
Senthil Kumaran added the comment:
I removed the documentation comment in r82785. But the report still holds till
we have a class for handling MSIE Cookies.
--
nosy: +orsenthil
stage: -> needs patch
___
Python tracker
<http://bugs.pyth
Changes by Senthil Kumaran :
--
assignee: georg.brandl -> orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue2202>
___
___
Senthil Kumaran added the comment:
Several changes were already made to urlparse to make it more rfc3986
compliant. Let me recollect what else these patches offer.
--
assignee: gregory.p.smith -> orsenthil
___
Python tracker
&l
Senthil Kumaran added the comment:
A new way for parsing URI. I have not reviewed it even after saying I would
like to, but having the dependency issue resolved, I think it is good to look
at it again, especially if it leads some helpful approaches to parsing IRI.
--
assignee
Senthil Kumaran added the comment:
This might be related to issue2202 as well.
--
assignee: gregory.p.smith -> orsenthil
dependencies: +urllib2 fails against IIS 6.0 (No support for MD5-sess auth)
nosy: +orsenthil
resolution: -> accepted
___
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue4493>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> accepted
stage: unit test needed -> patch review
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue900112>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
I reviewed the patch and we may not go with it.
- There is recent improvements in parsing and the patch does not go well with
it, especially the clear_cache removal.
Also there is a mistake in the patch:
-scheme, url = url[:i].lower(), url[i+1
Senthil Kumaran added the comment:
This was fixed as part of Issue8788. Closing this.
--
resolution: -> duplicate
stage: unit test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Currently this claim will fail:
>>> obj = urlparse.urlparse('http://a/b/c?')
>>> urlparse.urlunparse(obj)
'http://a/b/c'
>>> obj = urlparse.urlparse('http://a/b/c#')
>>> urlparse.urlunparse(obj
Senthil Kumaran added the comment:
Fixed in r82890 and branches. Thanks Mark for bringing these issues out.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Senthil Kumaran added the comment:
No problems observed now. I randomized and ran the tests a couple of times. I
don't know what the scenario was when this was observed, so I will let __ap__
close the issue.
--
nosy: +orsenthil
___
Python tr
Senthil Kumaran added the comment:
The resultant url you get after doing a urlparse is not a Windows PATH, but url
path component. So, when you use in relative manner by doing urljoin, you will
see that the original will get constructed properly.
So, there is really no a problem here
Senthil Kumaran added the comment:
The patch was pretty good. Committed it in r82899 and r82900.
Thanks Eli for the patch & Terry for the review.
--
nosy: +orsenthil
resolution: -> fixed
stage: commit review -> committed/rejected
status: open
1401 - 1500 of 1788 matches
Mail list logo