Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22417>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I addressed Berker Peksag's review comments on Jame's patch, tested the local
building of docs, verified the content and looks.
Committed this in 2.7, 3.4 and 3.5.
Thank you all!
--
assignee: docs@python -> orsenthil
resolution: -
Senthil Kumaran added the comment:
Committed this in 3.5. (Since this is adding an new argument, it should not be
backported to 3.4).
Thank you!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 3.4
_
New submission from Senthil Kumaran:
While working on issue22366, I found a tricky bit of code in:
https://hg.python.org/cpython/file/ca0aa0d89273/Lib/http/client.py#l1295
https://hg.python.org/cpython/rev/1a945fb875bf/
The statement is
if not self._context.check_hostname and self
Senthil Kumaran added the comment:
Except for the minor comments made by Antoine in the review, the patch looks
good to go.
--
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
My worry is not about the timing. I can add it immediately, but are we
convinced on having a new argument (API Change) for 3.4.2 ?
--
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Patch looks good. Will need similar addition in urllib2 and inclusion of tests.
--
nosy: +orsenthil
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Well, the result with loading using json will be same. but without sending
Accept */*. The content-type returned is text/javascript; charset=UTF-8 and
with sending of Accept */* the content-type is set to application/json;
charset=UTF-8 (which is more
Senthil Kumaran added the comment:
I addressed Antoine's comments with the patch and committed it. Thank you!
--
assignee: -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
First thing (and the easiest is), if you find inconsistent casing in
http/server.py itself, then make it consistent in your patch against cpython
default branch (from hg.python.org). Make it Content-Length and Content-Type in
your patch.
Next part is while
Senthil Kumaran added the comment:
I suspect that you have your interpreters confused. (For e.g, I see 3.4 run
against the trunk and the error messages are leading me to believe that 2.7
version in run on 3 code).
Or your local copy is not in right shape.
I tested it on 3.4 and cpython
Senthil Kumaran added the comment:
The buildbots are not showing this error too. I suggest you reset your local
copy with the pristine one from remote, do a make distclean; ./configure; make
and then run the tests.
--
assignee: -> orsenthil
resolution: -> works for me
New submission from Senthil Kumaran:
Reported by John Jeffers on docs mailing list.
https://docs.python.org/3.4/download.html (3.4.2rc1)
Return Error 404 (Your other pages are fine)!
--
messages: 227493
nosy: larry, orsenthil
priority: normal
severity: normal
status: open
title: 3.4
Senthil Kumaran added the comment:
Yes, urllib2 does not have any support for NTML based authentication. And it
is a long pending feature request too.
For 2.7, the best way to handle this might be, instead of crashing on
WWW-Authenticate: Negotiate, which is a valid response from IIS (1). It
Senthil Kumaran added the comment:
Sorry that I did not get involved earlier.
It is difficult to prove any problem with the current behavior and it is
rightly closed. The issue which was originally raised seems to me a cosmetic
one, which won't get exhibited as well.
Here is simple
Senthil Kumaran added the comment:
@Martin. Agree that this should have been backported. I have done that.
Thank you!
--
___
Python tracker
<http://bugs.python.org/issue12
Senthil Kumaran added the comment:
If you could point to RFC which states the list of characters which can be used
as valid query string separators, we can include that list. (Of course in 3.5)
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
And those examples were only in test.
Use of latin-1 to have a literal text for round trip is ok. The patch looks
good to me.
--
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
This is fixed in all active branches (2.7,3,3 and 3.4). I have addressed all
review comments. Thanks.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
The last tracker message msg207926 is applicable to issue #19097 and not here.
Sorry for the confusion.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19
Senthil Kumaran added the comment:
Fixed in:
New changeset a3e49868cfd0 by Senthil Kumaran in branch '3.3':
Issue #19092 - Raise a correct exception when cgi.FieldStorage is given an
http://hg.python.org/cpython/rev/a3e49868cfd0
New changeset 1638360eea41 by Senthil Kumaran in branc
Senthil Kumaran added the comment:
Addressed this in all active branches (2.7, 3.3 and 3.4). Thanks!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
I think, it is simply okay to mention about ResourceWarning being displayed. I
spent something thinking and going into mechanics of how it is displayed may be
an overkill for that line in unittest.rst. I'll make the change and if you see
any fu
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
This is duplicate of Issue1143
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Not actually a bug. The documentation is correct.
Do, random.randint(0,1) a couple of times and you see 1 appearing.
If still not convinced, look into the random.py see that randint(a, b)
actually does a return self.randrange(a, b+1)
--
nosy
Senthil Kumaran added the comment:
It is very difficult to debug with the information you have provided.
The webbrowser.py has indeed undergone some changes, but they are
positive changes and should not break any working behaviour.
For your problem, you might want to mention.
1) Your OS.
2
Senthil Kumaran added the comment:
Fixed that in revision 75166. Even in release26-maint got to chnage it
from env.unset(k) to self.env.unset(k).
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
___
Python tracker
Senthil Kumaran added the comment:
This needs to be changed in python2.6 branch as well. I was hesitant as
barry was making the build. After the branch opens, I shall make the
changes in that and close the issue.
--
nosy: +barry
___
Python tracker
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7043>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Fixed and Committed revision 75253.
Will just wait for windows buildbot to test it before closing.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Committed revision 75254 for release26-maint.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
This bug is bit a tricky case.
Harshad: You might try the "work-around" suggested by Antoine. But that
is just a work-around. not a fix. Add an entry to gconf-editor like any
other. ( google).
The actual bug seems to be with gnome-open which is
Senthil Kumaran added the comment:
AdamN, did you specifically come across a scenario which broke due to
this change? I can understand your concern, in general. The
'non-breaking' existing tests is the one of confidence factor we have in
introducing t
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue6894>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Senthil Kumaran :
>>> help(struct) mentions the functions which use fmt characters.
The builtin help does not mention the fmt characters and their meaning.
One should go online if he has to refer them.
--
keywords: easy
messages: 93709
nosy: orsenthil
prio
Changes by Senthil Kumaran :
--
assignee: -> georg.brandl
components: +Documentation
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Fixed in trunk and Committed revision 75333.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
merged into py3k revision 75334
merged into release-26maint revision 75335.
--
___
Python tracker
<http://bugs.python.org/issue6
Senthil Kumaran added the comment:
merged in release31-maint in revision 75336
Closing the issue.
--
status: open -> closed
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
> Hope this is the right place to report website issues.
Not actually,
http://wiki.python.org/moin/PythonWebsiteCreatingNewTickets
to report a bug or to suggest an enhancement for the python.org
website, please send an e-mail message to
.
If you
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7109>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Can you mention the python --version in which you encountered this issue?
And piece of code which loops indefinitely?
The propagation of timeout to redirects has been fixed with Issue5102.
--
assignee: -> orsenthil
nosy: +orsent
Senthil Kumaran added the comment:
Windows buildbots pass for this test. Closing the issue.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7044>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
In the Issue7044, the reporter has identified the root cause and
possible fix too.
"
In Python 2.6.3 on Mac OS 10.6.1, there is a bug in
lib/python2.6/urllib.py, line 1367. The variable hostIP is used before
it's defined. You can fix it by addi
Senthil Kumaran added the comment:
I am inclined to reject this issue and close it as:
1) Digest Authentication does with urllib2
2) This is specific with some domain, which does not give enough details
to reproduce it.
3) The report is way old (2005).
If there are any new issues with Digest
Senthil Kumaran added the comment:
On Sun, Oct 04, 2009 at 05:39:26PM +, Preston Landers wrote:
> I'm curious what happened with this issue. It says closed+accepted but
> it doesn't appear to be checked in.
If you see the report, the last message indicates that it is chec
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue1673007>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
I have attached a docs patch against the trunk.
Please provide your review comments. If its okay, I can commit it and
have the information (urllib2.rst) for the Python 3k too.
--
assignee: georg.brandl -> orsenthil
keywords: +patch
nosy: +orsent
Senthil Kumaran added the comment:
Thanks for the comments.
Fixed and committed the changes trunk - 75478.
and merged into
release26-maint - 75479.
py3k - r75476
release31-maint - r75477
--
resolution: accepted -> fixed
status: open ->
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7159>
___
___
Python-bugs-list mai
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue5625>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
getproxies is urllib one of the many helper functions that is not
documented in the Documentation files.
I am not sure of a good resolution for this (leave it as such/Document
it/ make it private). I shall look into the test coverage,usage of the
function and
Senthil Kumaran added the comment:
drukker: I verified your patch. Looks fine for changes made to the
subprocess call.
You mentioned: I've also unified the Unix and Windows portions in
run_cgi. Both now use subprocess."
I don't see it in the patch. Was it that you assum
Senthil Kumaran added the comment:
Committed revision 76208 in trunk. Shall look at the output of windows
buildbots and merge the changes to other codelines.
--
___
Python tracker
<http://bugs.python.org/issue1
Senthil Kumaran added the comment:
Committed revision 76209 - release26-maint
Committed revision 76210 - py3k
Committed revision 76211 - release31-maint
Thanks Derk for the patch.
--
resolution: -> fixed
status: open -> closed
___
Python t
Senthil Kumaran added the comment:
Thanks for the notification. Seems I over looked it. Fixed it with the
changes in 76212 (trunk) and 76213 (release26-maint). py3k did not have
this issue.
--
___
Python tracker
<http://bugs.python.org/issue1
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue4683>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
This issue is Invalid. I am sorry that it had be open for so long
without any explanation.
The order in which the handlers are tried does not depend upon the way
http_error_auth_reqed method is coded, but rather on the handler_order.
In urllib2, we have
Senthil Kumaran added the comment:
Interesting issue. RFC 2617 supports the claim. In RFC 2617, section
3.2.2 The Authorization Request Header, we see that nonce-count is
maintained for each particular nonce value and it can used by the server
to verify the replays.
"""
The
Senthil Kumaran added the comment:
Fixed in r76288 (trunk), r76289 (release26-maint), r76290 (py3k) and
r76291(release31-maint). The issue is fixed. I am keeping it open to
remind of the pending tests (HTTPAuthDigest and nonce value check testcase).
--
resolution: accepted -> fi
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue7291>
___
__
Changes by Senthil Kumaran :
--
nosy: +pveloz
___
Python tracker
<http://bugs.python.org/issue7183>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
This bug is not reproducible in trunk, py3k and is not reproducible in
py26 releases too. I tried to hunt down if any changes in the code-line
from py2.5 to py2.6 had effect on the behavior mention (BadStatusLine) ,
but don't see any.
I am closing th
New submission from Senthil Kumaran :
2.x code:
import urllib2
opener = urllib2.build_opener(urllib2.HTTPHandler(debuglevel=1))
2to3 on this would result in:
import urllib.request, urllib.error, urllib.parse
opener = urllib.request.build_opener(urllib2.HTTPHandler(debuglevel=1))
which is
Changes by Senthil Kumaran :
--
components: +2to3 (2.x to 3.0 conversion tool)
___
Python tracker
<http://bugs.python.org/issue7375>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
tjreedy: The reporter's suggestion seems fine. Prepending a 0 does not
seem to be a good idea.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Terry: Oh, sorry. Now I get what you meant by "Prepend O to output
line". That is, Output line from the fib, as part of the patch. The
changes need to be done at 3 places. Section 3.2, twice in S
Senthil Kumaran added the comment:
Yes, I noticed the issue and found the patch to be good as well.
Unfortunate it was pending for a long time.
Fixed and Committed revision 76464 (trunk).
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: ->
Senthil Kumaran added the comment:
merged to 26-maint in revision 76468 and shall merge in py3k too.
--
___
Python tracker
<http://bugs.python.org/issue1488
Senthil Kumaran added the comment:
fixed r76469 (py3k) and r76470(release31-maint). Closing the issue.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue1
Senthil Kumaran added the comment:
HTTP Proxy Authentication works on Windows and has been verified. Under
the situation of failure, we do not enough details. Closing this bug as
out-of-date as the reporter informed it worked on py2.5 and problem was
with py2.4.
--
assignee
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue6452>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
The timeout propagation fixed with Issue5102.
--
resolution: -> duplicate
___
Python tracker
<http://bugs.python.org/iss
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7118>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
urllib and urllib2, by definition, returns a file-like object which
provides a variety of facilities, most common one being a reading the
object to get the content.
What you are asking for is, to read the content, verify if it matches
the Content-Length
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue5596>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
weak method idea seems interesting. I have not used it anytime yet, and
in this case,it seems okay.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7
Senthil Kumaran added the comment:
On Fri, Dec 11, 2009 at 09:40:40AM +, Kristján Valur Jónsson wrote:
> Is there any chance of getting a weakmethod class into the weakref
> module?
This is a separate feature request on weakref module. It may opened
and discussion carried out
Senthil Kumaran added the comment:
This is working as designed.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Fixed and Committed revision 76908 in the trunk.
--
keywords: -needs review
resolution: accepted -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Fixed through reversions r76908, r76909, r76910, r76911
Thanks for the patch, Tatsuhiro Tsujikawa.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I reviewed the patches attached.
- The patch to add Context Manager support for fileinput.py seems good.
It has docs too.
This discussion did not conclude on the need for Context Manager for
StringIO. With py3k having it, it should be good for py2.7 to
Senthil Kumaran added the comment:
Having a HEAD request for urllib2 might be a good idea. I shall use this
patch to add the functionality.
But, having a history support in the urllib2 module is not a good idea
IMO. It is best left to the clients which might use urllib2
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7540>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Here is a discussion and explanation from the submitter on what is meant
by history of requests.
http://mail.python.org/pipermail/python-dev/2007-March/072069.html
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
Thanks for the note, Manuel. Fixed it in revision 77013.
--
___
Python tracker
<http://bugs.python.org/issue7291>
___
___
Pytho
Changes by Senthil Kumaran :
--
assignee: georg.brandl -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7570>
___
___
Python-
Senthil Kumaran added the comment:
Fixed it in r77018 and merges.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Hi Ezio, let us not close the issue. Waiting for David Beazley's patch
is okay or even looking at specific modules pointed out from the point
of str vs bytes interfaces and if any docs can be improved, we can
improve them. If we determine there is none,
Senthil Kumaran added the comment:
I am attaching an updated patch for caching the 301 redirects.
As per RFC 2616:
10.3.2 301 Moved Permanently
...
...references returned by the server, where possible. This response
is cacheable unless indicated otherwise.
So, I have included an
Senthil Kumaran added the comment:
Thanks for the patch, Ned. Fixed in the trunk revision 77058.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Merged the fixes in r77059, r77060 and r77061
I fixed the thishost function to return all ips in py3k.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I dont see the failure on trunk either.
Is it either specific to windows or existed back when the bug was raised?
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue3
Changes by Senthil Kumaran :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue6452>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
> Antoine Pitrou added the Comment:
>
> I have trouble understanding what the patch does. I would expect it to
> cache the ->
Senthil Kumaran added the comment:
Here is the corrected patch for caching the 301 redirections.
* It caches only the redirection not the response.
* It retains cacheable=True kwarg for http_error_301 method. ( I feel, it
should be useful)
* Have made the cached dict as private.
I have
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file15677/urllib2-301-redirection.diff
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Senthil Kumaran added the comment:
Antoine: I got your point. Yes, I was missing the purpose of the redirection
itself and the patch was wrong.
If the 301 is to be cached, the cache map should be maintained at the higher
level in order for the further requests to refer to.
I have created a
1301 - 1400 of 1788 matches
Mail list logo
