Senthil Kumaran added the comment:
The first patch was correct and consistent with how other Exceptions were
closing the socket. Fixed this and thanks for the patch.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> clo
Senthil Kumaran added the comment:
Fixed these. Thanks for the report.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
I believe, repr() is the correct call here. You should know the proper end of
line characters like \n, \r\n which were sent in the request while debugging. A
pretty print here, while look good, might remove that capability and thus may
not add any value in
Changes by Senthil Kumaran :
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16423>
___
___
Python-
Senthil Kumaran added the comment:
Calvin. - I shall act upon old bug. The tricky nature of backwards
compatibility sometimes let's it stale because we can not come t a good
conclusion.
--
nosy: +orsenthil
___
Python tracker
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16450>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Hello Miki Tebeka,
The change requested by this issue (and provided by the patch) is already in
place in 3.3. This was committed as part of issue1673007 has the same behavior
too.
I am closing this as duplicate.
Thank you,
Senthil
--
resolution
Senthil Kumaran added the comment:
Thanks for raising the bug and patch, Berker Peksag.
Fixed in all versions.
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Even though 2.x is in security fix mode, this can be fixed by a overriding the
base class's info method in the HTTPError class and returning the .hdrs
attribute instead of .headers.
--
Added file: http://bugs.python.org/file28273/Issue1571.
Senthil Kumaran added the comment:
Okay. this is fixed in all versions of python. Sorry for the delay.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Fixed in all codelines. Thank you!
--
assignee: -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> Add fixups for encoding problems to wsgiref
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Jeff, Thanks for raising this issue. The aspect of skipping localhost for
proxies in urllib2_localnet tests can be handled in a different way as well,
namely by setting the environment varible NO_PROXY to "*". By this the
skip_proxies in urllib2 re
Senthil Kumaran added the comment:
Fixed in all branches of CPython. Thanks.
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue1674555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
+1 from me as well. I am also adding Eric who might have views on the
customization part which added by him.
--
nosy: +eric.araujo, orsenthil
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
Looks an invalid bug to me as well. request is a socket.socket object and has
shutdown method taking a single argument.
The error pasted in the report leads me to believe if the shutdown_request call
is not thread-safe and it is ending up called shutdown
Senthil Kumaran added the comment:
The patch seems good to me. Please commit it.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
Hello Zachary, What'wrong with referencing :class:`file` for iterable? I find
it as OK. Also if it needs to be corrected, the reference could be made for
:ref:`bltin-file-objects`
Re grammatical fixes, you could point out which were made as with the r
Senthil Kumaran added the comment:
I find, cd Doc easy to remember as well. If make tricks can be used then I
hope readers note it rather than be exposed via Documentation. Chris's
patch is helpful to me, but still I may not vote a +1 for it to be in
Documentation. thanks.
On Sun, Dec 30,
Senthil Kumaran added the comment:
Oh Okay, Thanks! I was checking it against 2.7!
On Tue, Jan 1, 2013 at 11:48 AM, R. David Murray wrote:
>
> R. David Murray added the comment:
>
> senthil: the file type doesn't exist any more in python3.
>
> --
Senthil Kumaran added the comment:
I reviewed the patch. Changes LGTM.
--
___
Python tracker
<http://bugs.python.org/issue16747>
___
___
Python-bugs-list mailin
I think, the the URLs on this page are correct ( or have been corrected
since the opening of this issue) -
http://hg.python.org/devguide/file/20333d160f4e/documenting.rst
If anything needs to be changed, then a patch would be helpful.
On Sat, Dec 29, 2012 at 8:48 AM, Tshepang Lekhonkhobe <
rep...
Looks good in most of the places, but at some places the parenthesis are of
course helpful for cohesiveness, and this can be quite subjective. With
these patches, are you in general removing all instances of parenthesis
when it is not required or also considering for places where parens may
help wh
Senthil Kumaran added the comment:
Should not this be?
*.S) obj=`basename $src .S`.o; cc='$(CC)';; #
The filetype extension .S instead .cpp.
And, I have less know-how on these, but for my understanding how would
non-preprocessed asm files (.s) will be handled? And doc reference t
Senthil Kumaran added the comment:
Thanks for the fix. The patches fixes it. Since this is a bug fix, it should be
backported all the way till 2.7.
--
assignee: -> orsenthil
nosy: +orsenthil
stage: -> commit review
versions: +Python 2.7, Python 3.2, Pyth
Senthil Kumaran added the comment:
Digging a little deeper, make libainstall needs $(BINDIR) because of this
$(INSTALL_SCRIPT) python-config $(DESTDIR)$(BINDIR)/python$(VERSION)-config
*And* that python$(VERSION)-config file refers to the python exe which is
available only after bininstall or
Senthil Kumaran added the comment:
Thanks Benno. I think that making libainstall depend on bininstall is
a right solution too. A nod from devs who have committed changes in
that area may help. Also, I believe that this is a bug fix and should
be ported back upto 2.7. If there are any concerns
Senthil Kumaran added the comment:
Regardless of the topic of merge, the suggested improvements for both idle.rst
and help.txt are great! Thanks for working the patch, Todd.
I am +1 with the changes. If no else has any comments, I can go ahead with
committing this.
--
nosy: +orsenthil
Senthil Kumaran added the comment:
If it does go in, due the RFC requirement, then it would be only in 3.4
(default branch) and the feature may not be backported. Without reading the RFC
section, I have an intuitive -1 for this proposal because the suggestion may be
a corner case rather than
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16904>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I personally think, that the "grey area" of multipart form encoding and trying
to use email's updated features for parsing was holding it, not the tests. This
can be submitted IMO after looking at the "related bugs", I shall do a
Senthil Kumaran added the comment:
I updated the patch addressing Ezio's comments in the review system and also
condensed the tests. This fixes the parse_multipart's byte handling at "some"
level.
The docstring of parse_multipart say that, this should be deprecated in fa
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17069>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Here is he patch against the default that would address this reported issue.
Same would go for other 3.x branches. The 2.7 only can just see the addition of
getcode() documented.
--
assignee: -> orsenthil
keywords: +patch
stage: -> patch
Senthil Kumaran added the comment:
Éric, thanks for the comment. URLopener and FancyURLopener is deprecated, so
that reference to that can be removed from 3.4 (after removing the URLopener
and FancyURLopener class). Rest of the patch can stay the same
Senthil Kumaran added the comment:
I shall go ahead with this change. And when the URLopener and FancyURLopener
removed, all their references in the docs (including this change) will be
removed.
--
___
Python tracker
<http://bugs.python.
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17069>
___
___
Python-bugs-list
Senthil Kumaran added the comment:
The patch looks good and it is correct thing to do IMO. thanks.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17172>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10852>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
There is another option. To have the same behavior like svn keywords
through hg. Having this setting at server hgrc can help.
This will be useful if we have more than one instance of keyword expansion.
[extensions]
keyword=
[keyword]
**/*.man =
[keywordmaps
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17164>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
You will stumble on that message, only if you give help("module
") and note that could be any module in the
PYTHONPATH.
We can change to show the text only if the module is a valid module,
but I think, it is costly do that computation for help text
Senthil Kumaran added the comment:
It should be noted that latest OSX Mountain Lion has caused problems for other
language libraries too (specifically ruby, which I use at work). Ease the
support of correct openssl in OSX may help a long way in all versions of python.
--
nosy
Senthil Kumaran added the comment:
The patch looks good to me. This change is helpful and definitely an
improvement over the existing text. Please go ahead with committing it, Terry.
Thanks.
--
___
Python tracker
<http://bugs.python.org/issue17
Senthil Kumaran added the comment:
I have a slight fear that this patch could be considered as a feature addition
in 2.7 urllib.py, I would like to quell that and ensure that behaviour
expectation is consistent when using urllib or urllib2 and latest
urllib/request.py modules.
Also, tests
Senthil Kumaran added the comment:
Thanks for the patches, Vajrasky and Karl. Fixed in currently active (3.4,3.3
and 2.7) versions of python.
--
assignee: -> orsenthil
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
versions:
Senthil Kumaran added the comment:
I had removed them in all. Something must have gone wrong if still present or I
did a mistake.
changeset: 85594:678e3c0d2d99
parent: 85591:c116b658aede
parent: 85593:14ba90816930
user:Senthil Kumaran
date:Sat Sep 07 11:30:04 2013
Senthil Kumaran added the comment:
Thanks for making these changes (and correcting some of my mistakes), RDM.
They are much better now.
On Sat, Sep 14, 2013 at 10:38 AM, R. David Murray wrote:
>
> R. David Murray added the comment:
>
> You are right, there was a further typo in
Senthil Kumaran added the comment:
Found the patch suitable and had addressed Berker Pesag's review comments too.
Thanks for contributing, Malte Swart and thanks for submitting the contributor
agreement too.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review ->
Senthil Kumaran added the comment:
The patch looks good, but I have doubt in the claim that, this new behavior is
actually a right thing to do.
RDM wrote:
Now, that said, it seems to me that while it is not (apparently) RFC compliant,
query strings do have a natural way to support null
Senthil Kumaran added the comment:
> Georg Brandl added the comment:
>
> I would propose a leading underscore for these methods; they should make it
> clear to the user that the parameter is meant to be "private".
+1 to this proposal.
This style is present with randrange,
Senthil Kumaran added the comment:
Tim Peters added the comment:
> ..., _fast=slow, ...
>
> in an argument list means we endure the slow lookup (of `slow`) only
> once, when the function is first defined. When the function is
> _called_, that binding is available via
Senthil Kumaran added the comment:
Attaching a patch after changing int=int to _int = int and improving the
docstring. Please review the changes to the docstring and see if it will be
helpful.
--
status: closed -> pending
Added file: http://bugs.python.org/file31788/14927.d
Senthil Kumaran added the comment:
Thanks for catching the mistake at _randbelow. Updated patch to fix that and
removed the explanation in the docstring. Not sure if _randbelow should changed
(fully) or not at all. Leaving the change only with _int.
Will wait for Raymond's r
Senthil Kumaran added the comment:
Georg: Thanks for spotting. I feel bad for the mistake. I shall correct it.
--
___
Python tracker
<http://bugs.python.org/issue18
Senthil Kumaran added the comment:
Fixed now. Ascertained myself by doing hg diff -r tip^ -U 10 on local commits
before pushing. :-)
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Hello Dmi,
> I having a snippet to fix that, should I open a new issue for patch?
Please open a new issue.
Thanks!
--
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Thanks for the this change, Jason. Docs could be updated to reflect this change
(using ..versionchanged: directive). Thank you!
--
___
Python tracker
<http://bugs.python.org/issue18
Senthil Kumaran added the comment:
Hi Joshua, I did not setup a php server to test the html form that you
uploaded. We cannot test this in browsers because HTML does not have None as
values, it is simple empty strings and that is correct.
I think that the cost of making this change is higher
Senthil Kumaran added the comment:
I have provided my comments in the review tool. Please check them out.
--
___
Python tracker
<http://bugs.python.org/issue19
Senthil Kumaran added the comment:
FieldStorage("foo", "bar") is invalid because the first argument is supposed to
be file-like object and second one headers. Here we are sending invalid
headers. By
default, if the headers is none, the content-type is urlencoded.
Th
Senthil Kumaran added the comment:
Hi Raymond, Ezio provided some comments on improvements to the patch. Do you
mind if Ezio or I take over task of improvement. Not cause problems != no need
to improve.
TIA.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Hi Guido,
Agree with both your points.
Attaching a patch that fixes this issue.
1. Raises TypeError exception when header is not a Mapping or
email.message.Message type.
2. Asserts for fp.read and fp.readline() to assert that fp, the first argument
to
Changes by Senthil Kumaran :
--
versions: +Python 3.3, Python 3.4 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue19097>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Addressing storchaka's review comments. Here is the updated patch.
--
Added file: http://bugs.python.org/file32021/19092-v2.diff
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
The patch is good. I think, it is better to include this information in
documentation too. Please let me know if this suitable, I shall go ahead
committing this. (With credits to Vajrasky Kok)
--
assignee: -> orsenthil
nosy: +orsenthil
versi
Senthil Kumaran added the comment:
Sounds good.I shall update patch (.rstify the security warning). Thank you!
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19350>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Patch committed in these versions. Thank you!
2.7 -5fda64d39540
3.3 - 06b9a9e75a6c
3.4 - 060d9b2e4d5e
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type:
Changes by Senthil Kumaran :
--
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue19350>
___
___
Python-bugs-list m
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19383>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Attached patch adds the index entry.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file35703/20091.patch
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
Fixed in all active branches.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the review, Mark. Addressed that and committed the changes in
changeset 606a18938476 (3.4)
changeset b4130b2f7748 (3.5)
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +P
New submission from Senthil Kumaran:
issue15588 brought the topic that quopri has ancient methods like encodestring,
decodestring, which a user might expect that will send a string, but instead
has to send bytes.
This needs to be cleaned up.
a) function name should be accurate and represent
Senthil Kumaran added the comment:
The patch was good and captured what was required. I made some minor
modifications and committed it in 3.4 and 3.5
Thanks for the patch, Vajrasky Kok.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch ->
Senthil Kumaran added the comment:
Thanks for the report. Point 2 is definitely a bug (and an overlook by me), I
will fix it.
I think, the url[:2] == '//' check was present for ftp case which supported
file:// protocol. I can't see a clear requirement to change here.
Th
Senthil Kumaran added the comment:
I have addressed the mistake where req.host is self.get_names() was done
instead of req.host in self.get_names() in the first commit as it was an
obvious problem.
I will come up with patch/solution addressing the other behavior mentioned in
this report
Senthil Kumaran added the comment:
This bug has been open for a while and I had lost sight of it. Upon prompted
recently, I dug bit
into history and could think of a good solution.
A brief history.
1. The bug "maximum recursion depth exceeded" when doing Basic Authentication
was
Senthil Kumaran added the comment:
I have backed out my changes. The buildbot failures were new as I could not
reproduce them in my local test on Mac. I will run the buildbot suite on branch
and fix it before committing.
--
___
Python tracker
Senthil Kumaran added the comment:
@Serhiy, yeah, I think the patch attached to issue22165 will fix one of the
buildbot failures. For this issue. there was another one with Broken PIPE which
may need a different fix.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Attached patch looks good to me. If an unittest can be provided for this
situation in test_httpservers.py it will be comprehensive and will be good to
go.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
Looks like we hit with an encoding issue, which is due to way os.fsdecode() and
os.listdir() decode the filenames.
>>> support.TESTFN_UNDECODABLE
b'@test_99678_tmp\xe7w\xf0'
>>> dir_list = os.listdir(self.tempdir)
>>>
Changes by Senthil Kumaran :
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
This is fixed in all active versions (2.7.8+, 3.4.2? and 3.5). Thanks all!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Interesting. I had not noticed these with my run on Mac and neither did
Buildbots report. Looks like explicit closing of wfile do_GET method can be
cause of tis problem.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
It was reproducible on my local machine too. Those errors were present and
somehow escaped me. Thanks for raising this.
Fixed these and tested in my local machine and test_urllib2_localnet was
successful.
--
assignee: -> orsenthil
resolut
Senthil Kumaran added the comment:
With the final review comment addressed, this could go in. Since you have
commit rights, please feel free to commit it. (else, please assign this to me
and I will commit and follow up with the buildbots
Changes by Senthil Kumaran :
--
assignee: -> alex
___
Python tracker
<http://bugs.python.org/issue22366>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
The localhost breaking on your linux system might be due to improper /etc/hosts
or is localhost pointing to an ipv6 address?
That said, I think it is okay to rely on 127.0.0.1 as host for running pydoc
server. I am unsure why the initial check was done only
Senthil Kumaran added the comment:
sys.platform is darwin since OS X 10.5. I am not sure when it's value was
'mac', So effectively the host was localhost on mac systems.
Directly setting the host value to localhost on all platforms may be right
thing to do. Here is a p
Senthil Kumaran added the comment:
2.7 was not affected and it was binding to localhost properly.
Since it is security related issue, I have fixed it in 3.3 as well.
Fix is now present in 3.4 and 3.5
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Senthil Kumaran added the comment:
Reviewed the patch. Looks good to go.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22420>
___
___
Pytho
Senthil Kumaran added the comment:
The patch looks good. Yeah, wsgiref server will see the benefiting of rejecting
long url with 414.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Thanks, fixed in all versions applicable for security release.
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
versions: +Python 2.7, Python 3.3, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue22419>
___
___
Python-bug
1201 - 1300 of 1788 matches
Mail list logo