Senthil Kumaran added the comment:
This is taken care. Rest of documentation improvements could be dealt with in
Issue15430. Thanks, Chris.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Pytho
Changes by Senthil Kumaran :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue15350>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15564>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for raising this issue, Serhiy and thanks for the patch, Daniel. It is
committed now.
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15593>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for the patch, Daniel. Fixed in all versions.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://
Senthil Kumaran added the comment:
Hi Chris & Eli, - Sorry that I missed this issue.
Chris - agree to your rationale. I can see how having self.left and self.right
documented can add value, The diff example was useful. Initially, I did have
some doubts in terms how it could be useful when
Senthil Kumaran added the comment:
As this is not adding any feature, but just an additional clarification to the
existing attribute together with some useful documentation, I believe this can
go in 2.7, 3.2 and 3.3
Please correct me if I am wrong here.
--
versions: +Python 2.7
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15743>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
The patch looks good to me. Thanks Jeff.
--
___
Python tracker
<http://bugs.python.org/issue15743>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
One change. get_method has only been changed not deprecated. Those test cases
should not change and moreover the current change to assert against .method
results in a failure too. get_method would return "GET" when .method is None
Senthil Kumaran added the comment:
I could verify this bug and also looks like a tricky one. Because when we are
sending the cacert (the second time), we create a new HTTPSHandler and then
build the opener again using that handler.
I thought, we can use the existing opener object itself like
Senthil Kumaran added the comment:
Oops. I had not seen Eric and Mattiahs comment to this issue, which
pointed out to the problem. Sorry for not acting on this.
Thanks Georg for adding those module attributes back.
On Fri, Aug 24, 2012 at 9:17 AM, Roundup Robot wrote:
>
> Roundup Robot
Senthil Kumaran added the comment:
On Thu, Aug 30, 2012 at 11:17 AM, mastahyeti wrote:
>
> When parsing a url with urlparse.urlparse, the return type is non-mutable
> (named tuple). This is really inconvenient, because one of the most common
> (imop) use cases for urlparse is to
Senthil Kumaran added the comment:
Okay, this is funny. first info is invoking addinfourl of urllib, which would
return headers. But in urllib2, the headers are self.hdrs
I would side with the documentation that info is advertised method for
HTTPError object. In 2.7, I guess just docs could
Senthil Kumaran added the comment:
Hello Eduardo,
I fail to see the bug in here. Robotparser module is for reading and
parsing the robot.txt file, the module responsible for fetching it
could urllib. robots.txt is always available from web-server and you
can download the robot.txt by any means
Senthil Kumaran added the comment:
Hi Eduardo,
I tested further and do observe some very strange oddities.
On Mon, Sep 10, 2012 at 10:45 PM, Eduardo A. Bustamante López
wrote:
> Also, I'm aware that you shouldn't normally worry about setting a specific
> user-agent to fet
Senthil Kumaran added the comment:
This is a feature request. urlencode tries to prepare the data in the form
items are submitted. It has been like form is list of key,value pairs and
that's what is reflect in the current behavior. That said, I am not -1 if see
if some frameworks ado
Senthil Kumaran added the comment:
2012/9/10 Jesús Cea Avión :
>
> Ping!.
Guess, it is still for 3.4.
--
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Thanks!. Verified the patch, it is fine and can be applied directly on
3.2 and 3.3 branch. Tested it as well. On 2.7, some changes would be
required.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
I shall make the changes 2.7, keeping this open for that.
--
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Python-bugs-list
Changes by Senthil Kumaran :
--
stage: patch review -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Have a look at the ProxyHandler example in the Examples here -
http://docs.python.org/library/urllib2.html#examples
Also, construct the full url properly with urlencoded data as params.
Your report does not give any details of problem.
--
nosy
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15928>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
The patch looks good and is doing the right thing, that is, when the, strict
mode is passed, it fails and without strict mode, it is printing the parsed
list.
--
nosy: +orsenthil
___
Python tracker
<h
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16095>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Personally, I want to do away with all those scheme specific stuff, if we can.
I have tried previously, but failed due to some backwards incompatibility. 3.4
gives a good chance/time to make those changes to get rid of those scheme
specific stuff (again
Senthil Kumaran added the comment:
issue9374 - another related one which should be taken care. Which is simply
reverting this:
http://hg.python.org/cpython/diff/a0b3cb52816e/Lib/urllib/parse.py and
informing in the DOCs that those globals are not available anymore. (But this
should also be
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
+1 to this change. It may be helpful in the cases like issue15991.
--
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
I took the privilege of testing, adding news and docs and committing it.
Thank you!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Senthil Kumaran added the comment:
Only the classes which are marked as deprecated are allowed removed in
the next release.
So the ones which we marked as deprecated in 3.3 can safely go in 3.4.
URLopener and FancyURLopener AFAIR had some dependency/ usage,
deprecating those may require some
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16250>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@Ezio, regarding msg172988. That's embarrassing. It should be fixed soon.
Review on the patch, how about having the strerror and filename from the
exception?
-raise URLError(e.errno, e.strerror, e.filename)
+raise URLError(e.str
Senthil Kumaran added the comment:
Here is the patch which captures both HTTPError and URLError at the open_file
and thus preventing multiple exceptions to be raised ( URLError and next
IOError). This can go in 3.4 and since this is bug, where correct exception is
not being caught and wrong
Senthil Kumaran added the comment:
This one is fixed in 3.4. I can see the previous versions raised IOError
exception and it is not a good idea to change by backporting. But the wrong
arguments on URLError should be fixed tough.
--
___
Python
Senthil Kumaran added the comment:
This patch fixed these URLError wrong invocation issue and adds some tests for
testing those it.
I noticed that some of these were in the dead-end of the code, like checking if
url is not a str (it is always, unwrap makes it a str if otherwise). Those will
Senthil Kumaran added the comment:
The URLError changes gone in as part of fix for issue10836 should give
e.filename and e.reason.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
This is fixed in 3.4. I shall backport to other branches.
--
___
Python tracker
<http://bugs.python.org/issue16250>
___
___
New submission from Senthil Kumaran:
>From the Buildbot failure -
>http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/7573/steps/test/logs/stdio
I remember that we restricted the access for file:// scheme to localhost only
for Windows/Cygwin. In terms of exception raised it
New submission from Senthil Kumaran:
localhost() returns a string and thishost() returns tuple. In
urllib/request.py, for file:// protocol, there is a verification to check to if
the host is in the localhost and check happens:
socket.gethostbyname(host) in (localhost() + thishost())):
This
Senthil Kumaran added the comment:
thanks for the bug-report/patch.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16302>
___
___
Python-bug
Senthil Kumaran added the comment:
The problem is here:
if url[:2] == '//' and url[2:3] != '/' and url[2:12].lower() != 'localhost/':
raise ValueError("file:// scheme is supported only on localhost")
On Unix like systems url[2:3] == '/', th
Senthil Kumaran added the comment:
Serhiy: Yes. I stand corrected. That snippet suggestion was my mistake.
I think, wrapping the test is better than changing the return of localhost. It
would always return a single value. Thanks.
--
___
Python
Senthil Kumaran added the comment:
Fixed in 478cda291bbc
Berker -
with urlopen(tmp_fileurl) as fobj:
self.assertTrue(fobj)
is enough when using context manager as the fobj gets closed automatically at
exiting of context.
Thanks.
--
resolution: -> fixed
status: o
Senthil Kumaran added the comment:
The change in 49de26395d1a addresses the buildbot failure. I have given a run
again.
--
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
The change I had made for fixing the windows buildbot had not fixed it. I am
skipped (1f92315d9568) the test on windows, investigating the reason for
windows behavior and I shall remove the skiptest on windows after fix
Senthil Kumaran added the comment:
Nope, I have backport it to other versions. I shall close it then.
--
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
> Serhiy Storchaka added the comment:
>
>> +tmp_fileurl = 'file://localhost' + tmp_file
>
> tmp_fileurl = 'file://localhost/' + tmp_file.replace(os.path.sep, '/')
Ok, I realized the mistake. &#x
Senthil Kumaran added the comment:
Buildbot still failing, but due to different reason.
PermissionError: [WinError 32] The process cannot access the file because it is
being used by another process:
'c:\\users\\buildbot\\appdata\\local\\temp\\tmpwwvqao'
http://buildbot.pyth
Senthil Kumaran added the comment:
This is fixed in 3.3 and 3.2
3.2 5e71f2712076
3.3 30547e2cd04d
--
resolution: -> fixed
status: open -> closed
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
This is fixed in all versions now.
--
assignee: -> orsenthil
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Buildbot issues are taken care. They are green for while. Tests have been
backported 3.3 and 3.2 as well.
3.2 5e71f2712076
3.3 30547e2cd04d
--
resolution: -> fixed
stage: -> committed/rejected
status: open -&g
Senthil Kumaran added the comment:
This has been backported.
3.2 5e71f2712076
3.3 30547e2cd04d
--
assignee: -> orsenthil
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tr
Senthil Kumaran added the comment:
The suggested patch(s) looks good to me.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue20939>
___
___
Senthil Kumaran added the comment:
Fixed this all active versions. Thanks for the report.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
I am reviewing this patch right now and you will see my action soon. It is
completely and I am reviewing to validating the technical details/fix. Thanks
for patch, Nikolaus.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
I verified the patch and this indeed corrects a nasty bug in sending a wrong
header when doing it a lower level HTTPSConnection to proxy and set_tunnel (bad
term) to the end host..I was worried as why we did not observe this earlier and
it seems to me that
Senthil Kumaran added the comment:
This is fixed in 3.4 and 3.5 (finally). I will port it to 2.7 as well.
--
___
Python tracker
<http://bugs.python.org/issue7
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: test needed -> committed/rejected
versions: +Python 3.5 -Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Oops did not notice. Thanks for catching.
--
___
Python tracker
<http://bugs.python.org/issue21219>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Fixed:
3.5 a85606b6de32
3.4 fb5516cbc522
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: compile error -> behavior
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
It may not just the be the version, but the capabilities. We have ensure that
capabilities are met/added before updated the version. Thanks for filing the
issue.
--
nosy: +orsenthil
___
Python tracker
<h
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue10318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Reading both the RFCs and requirements, I see that this is already taken care.
Note: we are actually have unencoded fragment like # and RFCs talk about
fragments with # character only. If you want the behavior of parse with
urlencoded to match un-urlencoded
Senthil Kumaran added the comment:
Reviewed the issue and correct rollbacks and commits were applied.
This ticket should be closed. Thanks!
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Yes, they indeed are. Thank you!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Hello Evens,
If you can, then please attach a doc to this and we and fix this soon.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
A simple docs patch would definitely help here. Thanks for the bug report.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Sure, here is the information on how to create a patch -
https://docs.python.org/devguide/
It could feel that there are multiple steps, but the process is easy.
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
Which may be sane thing thing do.
So the docs could be made better. Like - the list of browsers specified in env
var BROWSER is tried first before looking at the platform defaults.
--
nosy: +orsenthil
___
Python
Senthil Kumaran added the comment:
I am getting to this late.
>> I don't know whether the file descriptor read is expected to be meaningful
>> for urllib2/urllib.request.
>> Senthil, what do you think?
It should be meaningful no matter what the length is. I am looking
Senthil Kumaran added the comment:
This is the best way I found to reproduce the failure.
I changed the resource to www.example.com and then ran this.
$ ./python.exe -m test -m "*fileno*" -u all -v -F test_urllibnet
--
___
Python trac
Senthil Kumaran added the comment:
This is turning out be trickier than I ever thought.
fileno() returning b'' is just random error. The underlying issue is,
*directly* reading from the fp of the socket() is returning a incomplete output
at all times. The correct way to read the ou
Senthil Kumaran added the comment:
Ned Deily had done the correct analysis in the msg214947 and has this question
-
> I don't know whether the file descriptor read is expected to be meaningful
> for urllib2/urllib.request.
I can see that this test case was for the old behavi
Senthil Kumaran added the comment:
> I'll make another wireshark recording to get more details for me to analyze.
Thank you! That will be useful. Please test it against 3.x version as it has
seen cleanups recently.
--
___
Python tracke
New submission from Senthil Kumaran:
It is undocumented. While fixing a doc issue issue18229 for http.server I
noticed that I referenced that function and when I looked up for the
documentation, it was lacking.
--
assignee: orsenthil
messages: 216494
nosy: orsenthil
priority: normal
Senthil Kumaran added the comment:
Christian , with respect to patch, I agree with the logic (using something
similar to #18879). Does all current unittests succeed with this? (I suspect
not) A unittest for coverage would be helpful.
--
___
Python
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.5 -Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Éric, no preference. I thought this was explicit and if you would like to
change it back to /3/, fine, no problem with me. Just think of any redirection
issue, if we may accidentally stumble upon, that'
Senthil Kumaran added the comment:
Yes. And thanks for the patch. I applied a slight variation of it.
--
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Thanks for the bug report. The documentation has been fixed in the active
versions.
--
versions: +Python 3.4, Python 3.5 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue21
Senthil Kumaran added the comment:
Christian's patch is good.It helps in setting the socket.makefile file
descriptor to a well behaving well file close wrapper and thus will help us
prevent some tricky fd close issues.
I added tests for coverage to ensure that we are asserting the typ
Senthil Kumaran added the comment:
I agree. Having tell on a file descriptor of a URL request is not going to be
of help. You can easily write to a local file and use all the local file
features, if it is things like .tell is desired.
--
resolution: -> not a bug
stage: needs pa
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue18967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
For this bug, I think, section 2.2.4 and section 2.2.5 can be moved to section
13 and inserted between section 13.1 and 13.2 as it seem to be fit in naturally
there.
--
___
Python tracker
<http://bugs.python.
Changes by Senthil Kumaran :
--
nosy: -orsenthil
___
Python tracker
<http://bugs.python.org/issue2052>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
This is fixed in 3.4 and 3.5. I will backport to 2.7 ( I think, it is worth it).
--
resolution: -> fixed
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
I am glad that issues with 3rdparty libs which dependent on the previous wrong
behavior has been resolved.
As indicated previously, I think, it makes sense to have this in 2.7 as well. I
created a patch and tested it 2.7 and it is all good. I plan to commit
Senthil Kumaran added the comment:
This is fixed in 2.7 as well here (changeset 568041fd8090).
We shall close this ticket after @dstufft pulls in the updated pip for 3.4
Thanks!
--
priority: high -> release blocker
versions: +Python 2.7
___
Pyt
Senthil Kumaran added the comment:
I prefer we update the ensurepip in 3.4.1
That will be helpful too since 3.5 has the fix.
--
___
Python tracker
<http://bugs.python.org/issue7
Senthil Kumaran added the comment:
@dstufft - should you commit it in 3.4 branch (since the change is already in
3.5) and then wait for larry's approval or rejection?
--
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I see that all the patches are correct. My only worry is since 3.1,3.2 and 3.3
are in security fix only mode, we may not apply it to those.
2.7, 3.4 and 3.5 ones are okay.
--
nosy: +orsenthil
___
Python tracker
Senthil Kumaran added the comment:
Fixed the follwing changesets.
2.7 b8655be522d4
3.4 e6dce5611dae
3.5 50c9df76bb77
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://
Senthil Kumaran added the comment:
I could not reproduce this in 3.4 / 3.5
[localhost 21643]$ ./python.exe Tools/scripts/pyvenv --upgrade
usage: venv [-h] [--system-site-packages] [--symlinks | --copies] [--clear]
[--upgrade] [--without-pip]
ENV_DIR [ENV_DIR ...]
venv
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue21648>
___
___
Python-bugs-list mailing list
Unsubscribe:
1101 - 1200 of 1788 matches
Mail list logo
