Senthil Kumaran added the comment:
Hello Michael,
Looking a bit deeper into this issue, I don't see that 'x://' and 'x:///y'
qualifies as valid URLS as per RFC 3986. (Well, urlparse has been not strictly
conforming to it, but that is a different issue)
If you
Senthil Kumaran added the comment:
What is referred to as URL-encoded or URL encoded is technically
'percent-encoding'. Consistency would desirable and I think 'URL encoded' is
okay. It involves a minor change in removing '-' in some places. Once trunk
opens,
Senthil Kumaran added the comment:
With respect to msg98314 (http://bugs.python.org/msg98314) referenced in this
bug, which I thought is easy to handle, does not appear so. It is bit tricky.
The problem is the relative url is given of the format
'07.11.2009-9:54:12-1.jpg' an
Senthil Kumaran added the comment:
After spending a sufficient amount of time looking at patches and the RFC 2732,
I tend to agree with the patch provided by tlocke. It does cover the behavior
for parsing IPv6 URL with '[' hostname ']'. RFC 2732 is very short and just
s
Senthil Kumaran added the comment:
I am unable to reproduce this issue in the trunk/py3k. Buildbots have not
complained either. I am closing this bug.
srid: If you have steps to reproduce, feel free to reopen it.
--
status: open -> clo
Senthil Kumaran added the comment:
Added additional examples of valid urls in r79988 and branches under the
roundtrip test cases.
Michael, RDM: If you have any comments on msg102737, let me know. Otherwise we
can close this issue as wont-fix
Senthil Kumaran added the comment:
On Mon, Apr 12, 2010 at 11:50:57AM +, Michael Glassford wrote:
> 1) Although the urlparse documentation does mention the relevant RFCs, on a
> quick read-through I don't see that it actually requires its input to be a
> valid URL.
> 2
Senthil Kumaran added the comment:
On Sun, Apr 11, 2010 at 07:43:56PM +, Éric Araujo wrote:
> httplib.Client, ftplib.Client, ftplib.SecureClient would be much more
> descriptive than httplib.HTTP and ftplib.FTP. Any interest about adding
> aliases?
Aliases would be a bad idea.
Senthil Kumaran added the comment:
Actually, this bug is just for parsing the IPv6 url. We are having the
right set of patches in the bug. I shall commit it soon.
The RFC part is separate and we will slowly achieve a good compliance
with STD 66
Senthil Kumaran added the comment:
It looks like any change for this specific case would make tests like handling
anyscheme fail. I am less inclined to do that as opposed to handling this case
for invalid url,
I suggest this be handled at user end to fix the proper parsing and
constructing
Changes by Senthil Kumaran :
--
assignee: georg.brandl -> orsenthil
nosy: +orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Yeah, there a example in the tutorial that was changed recently along similar
lines suggested.
(http://docs.python.org/dev/py3k/tutorial/stdlib.html#internet-access)
The other examples got to be changed too
Senthil Kumaran added the comment:
Final patch with inclusion of detecting invalid urls at netloc and hostname
level, tests and NEWS entry.
--
Added file: http://bugs.python.org/file16931/issue2987-final.patch
___
Python tracker
<h
Senthil Kumaran added the comment:
Fixed in revision 80092 and merged into release31-maint in revision 80093. I am
marking this as fixed and closed. If there are any similar issues at other
places, we will address them as separate bugs.
--
resolution: accepted -> fixed
status: o
Senthil Kumaran added the comment:
Committed into trunk in revision 80101
--
___
Python tracker
<http://bugs.python.org/issue2987>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
merged into py3k in revision 80102 and release31-maint in revision 80103.
Thanks for the patches, Tony and Hans. I have acknowledged it in NEWS file too.
--
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status
Senthil Kumaran added the comment:
Reverted the check-in made to 3.1 maint (in r80104). Features should not go in
there.
--
___
Python tracker
<http://bugs.python.org/issue2
Senthil Kumaran added the comment:
Fixed in revision 80146 and merged into other branches
release26-maint: r80147
py3k: r80148
release31-maint: r80149
--
assignee: georg.brandl -> orsenthil
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open
Senthil Kumaran added the comment:
Moving the Bad URL check to a higher level can be detect the bad urls much
better. Once I the netloc is parsed and obtained, invalid URL can be checked. I
am attaching an update with the new test included.
If you have any comments, please let me know
Senthil Kumaran added the comment:
Hello Victor,
The patch looks for fine for a timeout enforcement.
A couple of changes required.
-if isinstance(err[0], timeout):
+if isinstance(err[0], socket.timeout):
And, in this portion:
+try
Senthil Kumaran added the comment:
Committed revision 80236 in the trunk. The build-bots should not hang now.
Shall merge to other branches too.
--
assignee: -> orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.p
Senthil Kumaran added the comment:
Yes, definitely it needs to be ported. I realized that, py3k was in a bad shape
at moment.
File "Lib/test/test_urllib2net.py", line 151, in _test_urls
import logging
File "/home/senthil/python/py3k/Lib/logging/__init__.py", lin
Senthil Kumaran added the comment:
make distclean erased the problem. :) merged to py3k in r80256 and
release31-maint in r80257. Had merged to release26-maint in r80237
--
resolution: accepted -> fixed
stage: -> committed/rejected
status: open -&g
Senthil Kumaran added the comment:
I added an additional invalid test which David pointed out and made changes to
invalid url checking code. I moved it more higher level.
- The reason for doing this is, invalid url test code (which is very specific
for '[' enclosed '
Senthil Kumaran added the comment:
Updated in the r80336 through r80339. Thanks for the note, Ezio.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
It was intentional as not to remove the old RFC references because
certain parsing behaviours follow them compatibility purposes. If you
look at test_urlparse.py you might get the specifics of parsing
corresponding a RFC
Senthil Kumaran added the comment:
On Thu, Apr 22, 2010 at 11:08:01AM +, Éric Araujo wrote:
> Thanks for the explanation. Would it make sense to have either different
> functions or a switch to existing ones to tell if we want legacy or
> modern parsing?
Hard at the moment, o
Senthil Kumaran added the comment:
Thanks. Closing on submitter's note.
--
resolution: -> invalid
stage: unit test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyt
Senthil Kumaran added the comment:
And for this specific request, it fdqn is looked up only for "logging" to
sys.stderr. Either removing the fqdn call or just caching per connection it as
the patch does is both fine. I doubt if someone is relying this logging
anywhere in the cod
Senthil Kumaran added the comment:
On Mon, Apr 26, 2010 at 10:45:56AM +, Antoine Pitrou wrote:
> What do you mean? BaseHTTPRequestHandler is tested in test_httpservers.
I meant specifically for that function which is logging to sys.stderr.
No return values, state changes and no te
Senthil Kumaran added the comment:
Please use python-h...@python.org or comp.lang.python, not the tracker.
Also check the collections module.
--
nosy: +orsenthil
resolution: -> invalid
status: open -> closed
___
Python tracker
Senthil Kumaran added the comment:
I can take this up. The HEAD requests does not contain any data, so when the
data is None and transfer encoding is chunked, we can return empty value for
the next step. No need of attempting to read the chuncked amt. The patch is
fine and tests need to be
Senthil Kumaran added the comment:
>From your prompt, it seems you are on Unix based system. make would have
>informed you about _tkinter not built.
If you are on ubuntu, do a sudo apt-get install tk-dev and install tk-dev
package and its dependencies.
And then do the ./configure;mak
Senthil Kumaran added the comment:
Hi David,
The attached patch for this issue:
+if isinstance(payload, unicode):
+payload = payload.encode(msg.get_charset().output_charset or
'us-ascii')
looks fine enough to me. Are you worried about the /or 'us-ascii
Senthil Kumaran added the comment:
Whenever the HEAD method is queried, the httplib recognizes it read method and
returns an '' empty string as expected.
Fixed in revision 80583, release26-maint: r80584, py3k: r80587 and
release31-maint in 80588.
--
resolution: accepte
Senthil Kumaran added the comment:
Should we close this as out-of-date? I was inclined to see it as fixed as
urlparse has gone changes in direction as suggested by the issue.
Sorry Paul, for no response.
Regarding this issue, I plan to use the testcases provided in the patch in the
stdlib
Senthil Kumaran added the comment:
Walter, have a look at http://www.python.org/dev/ document. It is really easy
and attach it when its ready.
1) Create a patch against trunk (or py3k).
2) Patch against trunk/ or (py3k/ if its py3k only)
3) Lib/test/test_httplib.py might have similar tests, so
Senthil Kumaran added the comment:
And also, the code which is using getheader of HTTPResponse object would mostly
(but incorrectly in py3k) be passing a string as default. The HTTP headers have
been a dict with key,values as strings. Counchdb-python - does this make HTTP
reqs? I am not sure
Senthil Kumaran added the comment:
On Fri, Apr 30, 2010 at 01:56:01AM +, R. David Murray wrote:
>
> I seem to have been missing some context here.
I was referring to Walter's comment on default being an int, like
HTTPResponse.getheader('Fake-Content-Length',default=4
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8582>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
I guess the problem with specific to Windows. I don't see any problem with
urlretrieve of a image/png url on Linux.
And surprisingly, %T of time.strftime is undocumented:
http://docs.python.org/library/time.html
I wanted to check if that format specifie
Senthil Kumaran added the comment:
Here is the patch and the unittest for this issue.
David: The tests does ensure coverage of urlretrieve method.
- Changes %T to %H:%M:%S in strftime usage in retrieve.
- Coverage of Date header of retrieved file according to format specified.
David, any
Senthil Kumaran added the comment:
Fixed in trunk: r80675
release26-maint: r80676
py3K: r80677
release31-maint:r80678
--
resolution: -> fixed
stage: unit test needed -> committed/rejected
status: open -> closed
___
Python track
Senthil Kumaran added the comment:
It seems that 3.x behavior is correct. I am quoting a relevant section from rfc
2616.
"""
It MUST be possible to combine the multiple header fields into one "field-name:
field-value" pair, without changing the semantics of the me
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file17165/issue8572.diff
___
Python tracker
<http://bugs.python.org/issue8572>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
previous patch had a typo and a mistake. uploading the correct one.
--
Added file: http://bugs.python.org/file17166/issue8572.diff
___
Python tracker
<http://bugs.python.org/issue8
Senthil Kumaran added the comment:
I am not sure, there can be a default timeout value for client libraries like
httplib and urllib2.
Socket connection do have timeout and as you may have figured out already, the
option in httplib and urllib methods is to set/override the
socket
Senthil Kumaran added the comment:
On Sun, May 02, 2010 at 03:45:09AM +, Julian wrote:
> Note: I am not arguing here that this SHOULD be done - it would
> break existing applications, especially those that were written
> before Python 2.6 - merely that it COULD be done.
I get y
Senthil Kumaran added the comment:
Fixed in r80773 and r80774.
Thanks.
--
assignee: d...@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://
Senthil Kumaran added the comment:
Fixed in r80775 and r80776
--
___
Python tracker
<http://bugs.python.org/issue8619>
___
___
Python-bugs-list mailing list
Unsub
Senthil Kumaran added the comment:
That is actually a private attribute of urllib (not urllib2) module
present from the very first version. It is intended strictly for
overriding purposes not for anything else. During the merge in py3k,
it has taken its place in urllib.request. I see no harm in
Senthil Kumaran added the comment:
Walter, just to address one of your point:
+if failobj and not isinstance(failobj, list):
+if isinstance(failobj, str):
+failobj = [failobj]
+else:
+failobj = list(failobj
Senthil Kumaran added the comment:
I reviewed the patch and the speed test attached.
Well, yes, the patch does achieve a certain level of speed improvement but I
also saw that in cases when the quoting is really required (special characters,
the current stdlib is faster).
The speed
Senthil Kumaran added the comment:
Committed the tests in the r80908, r80909, r80910 and r80911.
The backward incompatible test cases, as in whose parsing requirements have
changed since the previous RFC has been commented out. There were 4 abnormal
scenarios and one strict parsing
Senthil Kumaran added the comment:
I don't see anything that is missing. Its here in the docs
http://docs.python.org/library/urlparse.html#urlparse-result-object
And also docstrings has the information too.
Could you explain a bit more as what you were expecting and found mi
Senthil Kumaran added the comment:
Fixed in r80953, r80954 , r80955 and r80956.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python
New submission from Senthil Kumaran :
>>> from urlparse import *
>>> urlsplit('git+file:///foo/bar/baz')
SplitResult(scheme='git+file', netloc='', path='/foo/bar/baz', query='',
fragment='')
>>> urlunspli
Changes by Senthil Kumaran :
--
nosy: +dabrahams
___
Python tracker
<http://bugs.python.org/issue8658>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
keywords: +patch
nosy: +orsenthil
resolution: -> accepted
stage: -> patch review
type: -> behavior
Added file: http://bugs.python.org/file17258/urlparse_giturl.patch
___
Python tr
Senthil Kumaran added the comment:
Duplicate of Issue8657
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
On Sat, May 8, 2010 at 10:04 AM, Jean-Paul Calderone
wrote:
> TypeError: cannot concatenate 'str' and 'NoneType' objects
Okay, I see where the problem is. I shall quickly fix it.
--
__
Senthil Kumaran added the comment:
Fixed the change which resulted in Buildbots failure. Those should
turn green now.
--
___
Python tracker
<http://bugs.python.org/issue8
Senthil Kumaran added the comment:
I would also suggest a re-ordering of FAQ entries in this manner:
1st What tools do I need to merge between branches?
2nd How do I merge between branches?
And then,
How do I prepare a new branch for merging?
With the explanation/clarification
Senthil Kumaran added the comment:
This is addressed and tests included as part of issue1462525.
--
resolution: -> fixed
stage: unit test needed -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Lets also see how this fares in py3k (where quote function takes an encoding )
and possibly push it in.
If there is any hesitation we can consult python-dev or wsgi groups where
frameworks developers might review and voice concerns, if they have any
Senthil Kumaran added the comment:
I have added 'git' and 'git+ssh' under known schemes which will recognize
authority/netloc and follow consistent round trip parsing behaviors.
For any unknown scheme(x or git+file), it might required to update the
uses_netloc in the ap
Senthil Kumaran added the comment:
New changeset e808c9d5c78e5a7a9d804eced013a02c0c7df1a5 by Jelle Zijlstra in
branch '3.9':
[3.9] bpo-42782: fix broken shutil test (GH-31971)
https://github.com/python/cpython/commit/e808c9d5c78e5a7a9d804eced013a0
Senthil Kumaran added the comment:
I will review this in a day.
I had been following the conversation, but couldn't look deeper into the code.
Thank you for engaging and contributions.
--
___
Python tracker
<https://bugs.python.org/is
Senthil Kumaran added the comment:
Hi all, I was looking at it. Introducing an enum at the last parameter is going
to add cost of understanding the behavior to this function. I am doing further
reading on the previous discussions and PR(s) now
Senthil Kumaran added the comment:
New changeset 38c7199beb30ae9a5005c0f0d9df9fae0da3680a by Senthil Kumaran
(Ngalim Siregar) in branch 'master':
bpo-37256: Wording in Request class docs (#14792)
https://github.com/python/cpython/commit/38c7199beb30ae9a5005c0f0d9df9f
Senthil Kumaran added the comment:
Thank you for the patch, CuriousLearner.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim
Graham) in branch 'master':
bpo-27657: Fix urlparse() with numeric paths (#661)
https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c8764
Senthil Kumaran added the comment:
New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim
Graham) in branch 'master':
bpo-27657: Fix urlparse() with numeric paths (#661)
https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c8764
Senthil Kumaran added the comment:
New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim
Graham) in branch 'master':
bpo-27657: Fix urlparse() with numeric paths (#661)
https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c8764
Senthil Kumaran added the comment:
New changeset 5a88d50ff013a64fbdb25b877c87644a9034c969 by Senthil Kumaran (Tim
Graham) in branch 'master':
bpo-27657: Fix urlparse() with numeric paths (#661)
https://github.com/python/cpython/commit/5a88d50ff013a64fbdb25b877c8764
Change by Senthil Kumaran :
--
pull_requests: +16388
pull_request: https://github.com/python/cpython/pull/16839
___
Python tracker
<https://bugs.python.org/issue27
Change by Senthil Kumaran :
--
pull_requests: +16389
pull_request: https://github.com/python/cpython/pull/16839
___
Python tracker
<https://bugs.python.org/issue754
Change by Senthil Kumaran :
--
pull_requests: +16391
pull_request: https://github.com/python/cpython/pull/16839
___
Python tracker
<https://bugs.python.org/issue22
Change by Senthil Kumaran :
--
pull_requests: +16390
pull_request: https://github.com/python/cpython/pull/16839
___
Python tracker
<https://bugs.python.org/issue16
Senthil Kumaran added the comment:
New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in
branch '3.8':
[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)
https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d
Senthil Kumaran added the comment:
New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in
branch '3.8':
[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)
https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d
Senthil Kumaran added the comment:
New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in
branch '3.8':
[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)
https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d
Senthil Kumaran added the comment:
New changeset 0f3187c1ce3b3ace60f6c1691dfa3d4e744f0384 by Senthil Kumaran in
branch '3.8':
[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)
https://github.com/python/cpython/commit/0f3187c1ce3b3ace60f6c1691dfa3d
Senthil Kumaran added the comment:
New changeset 7591d9455eb37525c832da3d65e1a7b3e6dbf613 by Pandu E POLUAN in
branch 'master':
bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118)
https://github.com/python/cpython/commit/7591d9455eb37525c832da3d65e1a7
Change by Senthil Kumaran :
--
pull_requests: +23599
pull_request: https://github.com/python/cpython/pull/24833
___
Python tracker
<https://bugs.python.org/issue27
Senthil Kumaran added the comment:
New changeset 32717b982d3347e30ae53eb434e2a32e0d03d51e by Miss Islington (bot)
in branch '3.9':
bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) (#24832)
https://github.com/python/cpython/commit/32717b982d3347e30ae53eb434e2a3
Senthil Kumaran added the comment:
Petr,
On
> the `separator` argument now allows multi-character strings, so you can parse
> 'a=1b=2' with separator=''. Was this intentional?
No, this was not intentional. The separator arg was just coice, for
compatibil
Senthil Kumaran added the comment:
New changeset 8cadc2c9cacfa1710cb5ca28a70f7782cacf09aa by Senthil Kumaran in
branch '3.8':
[3.8] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) (#24833)
https://github.com/python/cpython/commit/8cadc2c9cacfa1710cb5ca28a70f77
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
versions: -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issu
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Senthil Kumaran :
--
stage: resolved ->
___
Python tracker
<https://bugs.python.org/issue43479>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Senthil Kumaran :
--
stage: -> resolved
___
Python tracker
<https://bugs.python.org/issue43479>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
New changeset b38601d49675d90e1ee6faa47f7adaeca992d02d by Ken Jin in branch
'master':
bpo-42967: coerce bytes separator to string in urllib.parse_qs(l) (#24818)
https://github.com/python/cpython/commit/b38601d49675d90e1ee6faa47f7ada
Senthil Kumaran added the comment:
New changeset d5b80eb11b4812b4a579ce129ba4a10c5f5d27f6 by Miss Islington (bot)
in branch '3.8':
bpo-42967: coerce bytes separator to string in urllib.parse_qs(l) (GH-24818)
(#25345)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
Treating this as bug in itself might be a better idea than waiting for a ipv6
scope introduction, which had few caveats.
> Would it be an improvement if _checknetloc[2] validates the value of port
> properly?
Yes, we could check if it is an int
Change by Senthil Kumaran :
--
assignee: -> orsenthil
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue43871>
___
___
Python-bugs-lis
New submission from Senthil Kumaran :
A security issue was reported by Mike Lissner wherein an attacker was able to
use `\r\n` in the url path, the urlparse method didn't sanitize and allowed
those characters be present in the request.
> In [9]: from urllib.parse import urlsplit
New submission from Senthil Kumaran :
Mike Lissner reported that a set test suites that exercise extreme conditions
with URLs, but in conformance with url.spec.whatwg.org
was maintained here:
https://github.com/web-platform-tests/wpt/tree/77da471a234e03e65a22ee6df8ceff7aaba391f8/url
These
Change by Senthil Kumaran :
--
keywords: +patch
pull_requests: +24315
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/25595
___
Python tracker
<https://bugs.python.org/issu
801 - 900 of 2044 matches
Mail list logo
