Senthil Kumaran added the comment:
Fixed in r87329, r87330 and r87331. Thanks for the patch Wes, that was proper.
--
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Senthil Kumaran added the comment:
If a client sends a request without specifying the version, GET /, then the
Python server should behave like other common servers are behaving, namely
support rfc 1945 for HTTP 1.0 spec and return the response without headers.
Removing the HTTP 0.9 from the
Senthil Kumaran added the comment:
Wes, I forgot to address your last comment.
HTTPClient follows HTTP Spec for requests and responses. When it is used, the
request is on the PATH and the code there checks if the path does not exist
does a request on '/'. It is not appropria
Senthil Kumaran added the comment:
In the morning, I had a comment on the patch wondering why read _MAXLENGH + 1
and then check for len of header > _MAXLENGH. Instead of just reading _MAXLENGH
(and if the length matched rejecting). ( Looks like it did not go through).
I think that either
Senthil Kumaran added the comment:
This is committed in r87399. Documentation and NEWS is added. Thanks for the
patch and review comments.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Pytho
Senthil Kumaran added the comment:
Xuanji, Thanks for the comments on 'data' being bytes. I had just cared to add
the feature information. I think that data detail should have been updated too.
I think for your other two questions, we discussed it msg123051 - socket in
py3k ha
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue3566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I think, we need to move forward with this. It is one of the earliest i worked
on. I shall look at John's patch and look through it's inclusion in the code.
--
assignee: facundobatista -> orsenthil
_
On Tue, Dec 14, 2010 at 03:42:17PM +, Alexander Belopolsky wrote:
> I am attaching a patch that expands the documentation of isalnum,
> isalpha, isdecimal, isdigit, isnumeric, islower, isupper, and
> isspace. I did not change isidentifier or isprintable because their
...
> redundant checks for
Senthil Kumaran added the comment:
Yes, I too agree that HTMLParser.unescape() should split-out malformed char-ref
just as other browsers do.
But, as unescape function has undocumented/unexposed for releases, I am not
sure making it exposed is a good idea. HTMLParser is more for event based
On Thu, Dec 23, 2010 at 07:53:01PM +, R. David Murray wrote:
> The sorting is based on a 'handler_order' attribute, by the way, and
> presumably does control the order in which they are applied.
Yes. Exactly.
___
Python-bugs-list mailing list
Unsubs
Senthil Kumaran added the comment:
On Wed, Dec 22, 2010 at 12:20:24AM +, R. David Murray wrote:
> Presumably all that is needed is to add ';' to 'safe' in the call
> that encodes PATH_INFO?
Well, that is what is required in order for the quote function call to
ig
Senthil Kumaran added the comment:
A mistake with Content-Length in the previous commit resolved in revision 87469.
--
___
Python tracker
<http://bugs.python.org/issue3
Senthil Kumaran added the comment:
Closing this as Invalid, because in the latest code, if the Host header is not
explicitly specified by the request, then it is added to unredirected headers
and if it explicitly specified by the request, then it is taken into account
when the redirection
On Sun, Dec 12, 2010 at 09:52:27PM +, Brett Cannon wrote:
> At this point I'm willing to either hand maintenance of the files
> over to someone else or to delete the files and shift what we point
> people at.
I think, just pointing to the script at vim.org location is a good
idea. It is mainta
Senthil Kumaran added the comment:
I agree that semi-colon separated segments (params) can be in PATH portion of
the url. I was trying to find out, how a path;params would be useful in wsgiref
request_uri's PATH_INFO variable , wherein I assumed PATH_INFO should be a
file-system path
Senthil Kumaran added the comment:
Fixed this in r87542 in (py3k). unescape is undocumented helper method, so no
docs are added.
There was already an issue ( Issue6662) on malformed charref handling and it is
fixed.
--
resolution: -> fixed
stage: patch review -> committed/re
Senthil Kumaran added the comment:
r87544 (release27-maint) and r87545 (release31-maint).
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
r87564 (py3k), r87565 (release31-maint) and r87566 (release27-maint).
Just a Note.
These kind of minor changes have many a times resulted in regression for
developers who relied upon previous bad behavior. I have added NEWS to explain
this change clearly
Senthil Kumaran added the comment:
On Mon, Dec 27, 2010 at 07:59:46PM +, Brett Cannon wrote:
> But if you have a local copy of the Vim files from the community
> what is preventing you from editing them for new keywords and
> sending a patch to the maintainer so that the re
Senthil Kumaran added the comment:
Fixed in r87573 and r87574
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
If you provide some tests augumenting the currently existing tests
test_htmlparser.py and also ensure that no existing test breaks, it
would be help better to review the patch. I do see some changes made
to the regex and parsing. So tests would definitely help.
___
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10817>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
On Fri, Jan 07, 2011 at 07:14:30PM +, Shawn Ligocki wrote:
>
> I think the problem is that "http://118114.cn"; says it redirects to
> "http://www.118114.cn:";, but it seems like urllib2 should be able to
> deal with tha
Senthil Kumaran added the comment:
The title got reset by my previous response. Changing it again.
I vote for closing this report as Invalid as I see that the error message which
is raised is proper and meaningful.
httplib.InvalidURL: nonnumeric port: ''
--
priority: nor
Senthil Kumaran added the comment:
Hi Georg,
In the previous comment, I had written that
'let me see if we have to accommodate those "very special case"
where data can be a zero length string just to accommodate the mistake
it was present in the earlier version.'
More, I
Senthil Kumaran added the comment:
Thanks for the note. I shall some details to the NEWS entry before the release.
Closing this report.
--
priority: critical -> low
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Senthil Kumaran :
--
priority: low -> normal
___
Python tracker
<http://bugs.python.org/issue3243>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10926>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Why is reindent.py translating the whole file to platform default newline such
a bad thing? Could not it be considered as helpful behavior, especially in the
case where the user has mixed EOLs by mistake?
--
nosy: +orsenthil
Senthil Kumaran added the comment:
I find this problem with 3.x and not with 2.x codeline
--
nosy: +orsenthil
versions: +Python 3.1, Python 3.2 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue1075
On Wed, Jan 12, 2011 at 12:23:31AM +, Éric Araujo wrote:
> > I thought of adding 'http://' if not present but that would
> > disable opening files in a file browser.
>
> I think that’s a Windows-specific behavior, not a promise of the
> *web*browser module.
If being lenient with URLs which do
Senthil Kumaran added the comment:
Can you provide a test case which actually illustrates that zombie socket
connections present after the HTTPS Connection and Close?
I see the logic in your patch. But I don't see no left over unclosed
connections upon ssl.close either.
--
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file20502/unnamed
___
Python tracker
<http://bugs.python.org/issue10993>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
I think, we are facing a platform specific bug here. I had tried
similar program earlier and I tried your attached snippet with python
2.6.6 and release27-maint branch and I dont see the zombie sockets on
Ubuntu 10.10
Senthil Kumaran added the comment:
Here is a patch (against release27-maint) for to fix this issue. BTW,what is
the best way to check for case insensitive file-system? The test here merely
checks if sys.platform returns mac, darwin or win32.
--
keywords: +patch
nosy: +orsenthil
Added
Senthil Kumaran added the comment:
I would also add 'cygwin' to the list. I am not sure about the behavior of
OpenVMS or other less prevalent file systems.
--
___
Python tracker
<http://bugs.python.o
On Thu, Jan 06, 2011 at 12:15:26AM +, Antoine Pitrou wrote:
> IMO they should all be prefixed with an underscore. Greg?
>
+1 to this suggestion. It would make it consistent with expectations.
But yeah, I also think that all public methods should be in __all__ is
not a guarantee.
_
Senthil Kumaran added the comment:
The POST data should be bytes. So in the attached test case, instead of
request = urllib.request.Request('http://does.not.matter', 'foo=bar')
it should be:
request = urllib.request.Request('http://does.not.matter', b'foo
Senthil Kumaran added the comment:
For this particular issue, I think, it is good idea to disallow str
explicitly, instead of letting it go through the Iterable and raise a
ValueError with a different message.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Kenny, I don't see a problem with uuid is *imported*, it just creates a couple
of STANDARD UUID class objects for use later. And this seems to just set the
number and validates it. I don't see any subprocess calls performed. Perhaps
you were re
Senthil Kumaran added the comment:
Unable to determine the bug here. If you have questions with using python,
please ask python-l...@python.org
--
nosy: +orsenthil
stage: -> committed/rejected
status: open -> closed
type: -> behavior
_
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11153>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
On Sat, Feb 5, 2011 at 12:33 AM, Georg Brandl wrote:
>
> Then let us do that.
>
> Senthil, what about urlencode of bytes values returning a str?
>
Sorry, the late response. I needed some time to look at this one and I
could only do it toda
Senthil Kumaran added the comment:
Here is a patch to resolve this issue. Let me know if it okay to commit.(Or
feel free to commit too).
--
stage: -> patch review
Added file: http://bugs.python.org/file20732/issue11082.diff
___
Python trac
Senthil Kumaran added the comment:
Victor - It does not change the API. Only that the ValueError message which had
a confusing message that "for iterable data of type " is made
clear that POST should not be a str.
Yes, a TypeError instead of ValueError would be more approp
Senthil Kumaran added the comment:
Here is the patch with addressing the comments.
1. It should be TypeError instead of ValueError when str is rejected. We
introduced ValueError for this release only, so there is no breakage here.
2. Informed the user that string should be encoded to bytes
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file20740/Issue11082-2.patch
___
Python tracker
<http://bugs.python.org/issue11082>
___
___
Python-bug
Senthil Kumaran added the comment:
patch with Docs :ref: to proper section.
--
Added file: http://bugs.python.org/file20741/issue11082-2.diff
___
Python tracker
<http://bugs.python.org/issue11
Senthil Kumaran added the comment:
Thanks. Committed in r88394.
Regarding the encoding information. An explanation of this sort might be
helpful.
The string can be encoded using ISO-8859-1 which is the default encoding for
POST data or the user can also encode using a custom encoding , in
Senthil Kumaran added the comment:
Thanks for the update on this issue.
--
nosy: +orsenthil
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
keywords: -after moratorium
resolution: -> wont fix
___
Python tracker
<http://bugs.python.org/issue1173475>
___
___
Python-
Changes by Senthil Kumaran :
--
keywords: -after moratorium
___
Python tracker
<http://bugs.python.org/issue1498363>
___
___
Python-bugs-list mailing list
Unsub
Senthil Kumaran added the comment:
curl (7.21.0) fails with the same error message too for the target website. (Is
the server doing anything different. For other HTTPS sites (which also use
redirection) urllib.request works fine )
senthil@ubuntu:~/python/py3k$ curl -v
https://ui2web1
Senthil Kumaran added the comment:
The problem is the server strictly accepts SSLv3 only and urllib and
http.client send SSLv23 protocol.
(In http/client.py, line 1077)
if context is None:
# Some reasonable defaults
context = ssl.SSLContext
Senthil Kumaran added the comment:
Here are couple of Review Comments on What's new document.
1. The logging dictConfig example fails if you try directly out-of-text.
The conf file is opened as a 'rb' and json module throws an error as
"TypeError: can't use a strin
7461 and I saw that checkin had changes for os.popen only.
Thanks for pointing this out. I think #10554 should be referenced
where the claim for subprocess.Popen Context Manager support is
mentioned.
Other comments have been care of.
--
Senthil
___
Pytho
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11242>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
On Sun, Feb 20, 2011 at 10:07:31PM +, David Phillips wrote:
> The following code works on python 3.1.3 but fails on Python 3.2rc2
> (r32rc2:88269, Jan 30 2011, 14:30:28). (I run Mac OS X, version
> 10.6.6.)
Is that a real world code? (As i
Senthil Kumaran added the comment:
Andres, the HTTP Response is sent the xxx_error_xxx method when it is handled
by RedirectHandler. Does the below code not work for you in case? I am unable
to see the problem here (and also this piece of code is present from 2004!) I
am inclined to mark
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7776>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
As you noticed, the _set_tunnel method is a private method not intended to be
used directly. Its being used by urllib2 when https through proxy is required.
urllib2 works like this, it reads HTTPS_PROXY environment variable (in turn
includes
Senthil Kumaran added the comment:
okay, this should be easy to address. But the more important part is RFC
compliance so that this simple change does not break many other things in the
wild.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Pyt
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue5673>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Here is another -1 for this proposed feature. Having a comments in the csv
fields and providing a way to deal will complicate matters more than required.
Different suggestions of how to accomplish it has been suggested here. As
others, I too recommend
Senthil Kumaran added the comment:
Ok, in order to fix this bug, urllib2 should only send the cookies and not send
the auth info across the the redirects. Yup, let me take this up.
--
assignee: -> orsenthil
resolution: -> accepted
___
Senthil Kumaran added the comment:
Does s3 stand for the amazon s3 services? urlparse does not have it under its
list of known schemes yet. Does s3 have any specifications as such or is
aligned towards any of the known schemes (like http or ftp)?
s3 is valid scheme name according to rfc 3986
Senthil Kumaran added the comment:
Hello Mark,
Thanks for the patch.
However there are reasons why the check is:
"if scheme in uses_netloc and url[:2] == '//':"
It cannot be replaced by just url[:2] == '//' as in your patch.
Different protocols have different
Senthil Kumaran added the comment:
>From the bug report, it look likes its specific to windows, not OS X.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
What is the (Apple Inc. build 5646) (dot 1) vs normal (Apple Inc. build 5646). ?
While, ronald.oussoren did make a lot some changes recently (r78149 to
r78152).This fix could have been a side-effect of one of it, thought I could
not find the direct
Senthil Kumaran added the comment:
please not remove the nosy list. ( I guess, you did it by accident).
let's wait for ronald's response.
--
nosy: +loewis, michael.foord, orsenthil, ronaldoussoren
___
Python tracker
<http://bu
Senthil Kumaran added the comment:
Fixed in the r78234 and merged back to other branches.
I fell back to RFC's definition of scheme, as anything before the ://.
I did not see the need to add s3 specifically as a valid scheme type, because
s3 itself is not registered a schemetype.
So, th
Senthil Kumaran added the comment:
cgohlke, thanks for the patches and sorry for the delay. The fix however is not
to replace the %HH character of '|' with '|', in the nturl2path, but the keep
the '|' as safe character in the urllib.urlopen.
-
Senthil Kumaran added the comment:
The reason the problem was appearing in windows was, it is where, the | is
normally observed in URLS, Without | being a safe character, that is it can
appear literally in the url, the open method was translating it to %7C.
Christopher's patch w
Senthil Kumaran added the comment:
Fixed in r78325, r78326.
--
assignee: georg.brandl -> orsenthil
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
I disagree with this bug report.
First the responsibility of checking if something is not malicious URL lies at
the application/client end, urllib in its redirection never urlopen()'s the
redirected url, so you are not harmed in anyway.
If you wanted
Senthil Kumaran added the comment:
There is a OLD Known issue that base64.encodestring will insert in a line-break
in the authorization header. See Issue1574068
I fear, you might have done something like this.
base64string = base64.encodestring('%s:%s' %(username,pa
Senthil Kumaran added the comment:
urllib.getproxies() might be helpful to be documented too. I have added
documentaion to this helper function in the r78457 (trunk), r78458, r78459,
r78460.
--
resolution: -> fixed
status: open ->
Senthil Kumaran added the comment:
The bug here seems to me that urllib.urlopen() should not allow a relative file
path like the one specified. f='./rel/path/to/file.html
urllib2's behavior seems proper that it is raising an Exception.
According to the RFCs the local files are to be
Senthil Kumaran added the comment:
Change is reverted from other branches too. Discussed in IRC, that changes made
to an existing API like add_data,may break some existing applications, even if
its done to prevent unsupported usage.
Specifically, in mechanize's case, it was not reusin
Senthil Kumaran added the comment:
In this ticket, setting the authentication using a ProxyBasicAuthHandler is not
yet addressed yet. (this was informed in the last note). Reopening this one to
track it.
--
resolution: fixed -> accepted
status: closed ->
Senthil Kumaran added the comment:
Yes, that seems to be case. When username:password is present in the url
string, opener bytes string not being passed to the base64encode function.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> ac
Senthil Kumaran added the comment:
Yes, the reason for having the unquote verbatim was it created a circular
reference otherwise. This was done when parse_qsl was moved from cgi module to
the urlparse module. I would also like to know more on what RDM points out,
tough I have seem some
Senthil Kumaran added the comment:
I reviewed the patch:
+_hexdig = '0123456789ABCDEFabcdef'
+_hextochr = dict((a+b, chr(int(a+b,16))) for a in _hexdig for b in _hexdig)
is really a neat way to generate the dict of mixed-case percent escape to use
with to unquote. I shall commit th
Senthil Kumaran added the comment:
This module is not part of Python stdlib. MacOSX might have bundled it by
default. Reporting it to Apple might help.
--
nosy: +orsenthil
resolution: -> invalid
status: open -> closed
___
Python tracker
Senthil Kumaran added the comment:
Fixed this in r79047. If we are to backport this to release26-maint, we need
barry's approval. Barry, any thoughts? The change is a minor improvement, we
have lived with normal case percent escape for long, mixed case would be bonus
in rele
New submission from Senthil Kumaran :
I was looking for some option in optparse module which will allow me to add
custom help text after the generated help. Realized that OptionParser class has
a keyword argument 'epilog' for the same purpose.
But this is not been explai
Senthil Kumaran added the comment:
Fixed in revision 79329.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue8209>
___
___
Python-
Senthil Kumaran added the comment:
merged into release26-maint branch - 79331
--
___
Python tracker
<http://bugs.python.org/issue8209>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
How are setting up and using your proxy? It would also help you discuss your
approach at python-h...@python.org and if you see any specific issues, raise it
in the bug report.
--
nosy: +orsenthil
___
Python
Senthil Kumaran added the comment:
merged into py3k in r79333 and release31-maint revision 79490.
This specific issue can be closed.
But yes, I agree with issue 8158, there is a lot in OptParse Module
documentation that could be improved and be made more helpful. If I have any
thing more, I
Senthil Kumaran added the comment:
merged into release26-maint as r79492. This issue can be closed.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8158>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Okay, This vaguely got out of my mind. Shall come with the tests for
HTTPAuthDigest.
--
___
Python tracker
<http://bugs.python.org/issue4
Senthil Kumaran added the comment:
Sridhar, I am unable to reproduce this bug in the 3.x (py3k and
release31-maint) on 64 bit linux. I glance at the code to see any underpinnings
for this RuntimeError and could not find any at the place the exception
occurred.
Is it anyway related to other
Senthil Kumaran added the comment:
Yes, the proposed wording is more suitable in the scenarios when the error is
encountered. Also saw there is already a test (test_start_thread_again), which
covers this. There is no harm in changing the wording.
--
assignee: -> orsenthil
n
Senthil Kumaran added the comment:
Fixed in r79817, r79819 and r79821.
Thanks for the report and the patch, Gabriel.
--
resolution: accepted -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
But changing the HTMLParser.goahead's way to treating tags from
if i < j: self.handle_data(rawdata[i:j]) TO
if i <= j: self.handle_data(rawdata[i:j]
is not the correct way to deal with this problem. Theoretically, whatever it is
doing seems correc
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue8280>
___
___
Python-bugs-
Senthil Kumaran added the comment:
No, that is not bpython interpreter. The a crash report on "python interpreter"
observed with imp module when a directory ends with .py.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.
701 - 800 of 2044 matches
Mail list logo
