[issue9003] urllib about https behavior

2010-06-15 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil resolution: -> accepted ___ Python tracker <http://bugs.python.org/issue9003> ___ __

[issue8943] Bug in InteractiveConsole

2010-06-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, the problem is observed in py3k. Pickle module when used via Interactive console is trying to import the class as __console__.ClassName and it is failing to see the __console__ module. _pickle.PicklingError: Can't pickle : import of m

[issue9008] CGIHTTPServer support for arbitrary CGI scripts

2010-06-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Wed, Jun 16, 2010 at 12:16:38PM +, Éric Araujo wrote: > Forgot the conclusion: I suspect noone will want to work on that. Nope, please don't come to that conclusion soon. It is a valid request. It is not that only maintainers listed will work

[issue8937] SimpleHTTPServer should contain usage example

2010-06-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r82018. -- nosy: +orsenthil resolution: -> fixed stage: -> committed/rejected ___ Python tracker <http://bugs.python.org/

[issue8937] SimpleHTTPServer should contain usage example

2010-06-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Merged into other branches in r82020, r82022 and r82023. -- status: open -> closed ___ Python tracker <http://bugs.python.org/iss

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

2010-06-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, it is applicable to 3.1 and 3.2 as well. This is definitely a good to have performance improvement. -- nosy: +orsenthil versions: +Python 3.1, Python 3.2 ___ Python tracker <http://bugs.python.org/issue3

[issue8937] SimpleHTTPServer should contain usage example

2010-06-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, I felt the same way and that is the reason for providing extra example snippets in the same Documentation. I hope you checked that one. -- ___ Python tracker <http://bugs.python.org/issue8

[issue4452] Incorrect docstring of os.setpgrp

2010-06-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, its valid doc change request. Thought it means the same, the minor docstring improvement can be done. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue4

[issue4452] Incorrect docstring of os.setpgrp

2010-06-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: The docstring "Make this process the process group leader" is proper for setpgrp. Fixed in r82047, r82048, r82049 and r82050. -- resolution: -> fixed stage: -> committed/rejected status

[issue1368368] prompt_user_passwd() in FancyURLopener masks 401 Unauthorized error page

2010-06-18 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r82068 and r82069. As mentioned in msg107883, this functionality is should not be relied upon. It is present for legacy apps. I have added a NEWS note mentioning that there is a change in behavior (if legacy apps owners can catch it

[issue9018] os.path.normcase(None) does not raise an error on linux and should

2010-06-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Sat, Jun 19, 2010 at 08:00:55PM +, Shashwat Anand wrote: > Why on Mac OS X, it should return s.lower() ? That is is because some file systems on Mac OS X are case-sensitive. > def normcase(s): > """Normalize case of pathna

[issue3439] create a numbits() method for int and long types

2010-06-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: > There is a small mistake in the docs: Yes there was. Fixed in 82146. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/iss

[issue9018] os.path.normcase(None) does not raise an error on linux and should

2010-06-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: Nice patch. I like the use of new string formating. It can be applied. BTW, do you think that TODO of s.lower() for MAC OS X should be addressed along with this. It might require some research as how much of a desirable behavior it would be

[issue8455] buildbot: test_urllib2_localnet failures (Connection refused) on Tiger buildbot

2010-06-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: Replacing 'http://localhost' with 'http://127.0.0.1' for this test is fine. But, urllib.proxy_bypass returning for True for any string, is not correct. In the code, I see that Proxy Settings from Mac OSX system configuration is

[issue9021] no copy.copy problem description

2010-06-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: I am +0 on this change. The existing introduction is fine and the discussion where shallow and deep copy is discussed is more important. It is okay to assume that the reader is aware of the assignment operation nature, i.e. it does not create a copy and you

[issue9035] os.path.ismount on windows doesn't support windows mount points

2010-06-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: I see that ismount like function on windows is provide by the various Win32 extensions. If Windows supported is added to ismount function itself, then it might be a good idea to have attributes or list_attributes function as well. But for posix, how will it

[issue9056] Adding additional level of bookmarks and section numbers in python pdf documents.

2010-06-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: You mean "Table of Contents"? The index at the end serves as a bookmark, right? Also, Table of Contents might add up couple of more pages to traverse. -- nosy: +orsenthil ___ Python trac

[issue9021] no copy.copy problem description

2010-06-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: > Can you post a link to this tutorial here? Section 9.1 and 9.2 of the docs.python.org/tutorial It may not be as explicit as you might want it to be, but it does sets up background that assignments do not copy the obj

[issue9025] Non-uniformity in randrange for large arguments.

2010-06-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: I guess, Antoine wanted to point out this: "Changed in version 2.3: MersenneTwister replaced Wichmann-Hill as the default generator." But as the paragraph points out Python did provide non default WichmanHill class for generating repeatable sequ

[issue9062] urllib.urlopen crashes when launched from a thread

2010-06-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: There isn't a problem with urllib with respect to threading as such. There are programs and examples which use this module in multi-threading environment. I could not run your app, I am not on Mac, but some of the changes you could try is: - N

[issue9061] cgi.escape Can Lead To XSS Vulnerabilities

2010-06-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Wed, Jun 23, 2010 at 03:46:35PM +, Craig Younkins wrote: > cgi.escape never escapes single quote characters, which can easily > lead to a Cross-Site Scripting (XSS) vulnerability. This seems to be > known by many, but a quick search reveals

[issue1172711] long long support for array module

2010-06-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- versions: +Python 3.2 -Python 2.7 ___ Python tracker <http://bugs.python.org/issue1172711> ___ ___ Python-bugs-list mailin

[issue9085] Version number inconsistency in email package

2010-06-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: I doubt we would care about changing the version number in Python 2.5. Python 2.5 *might be* only in Security Fix mode and this does not qualify for a change in Python 2.5. So, just leave it as it is and don't rely on the version number is in the a

[issue9085] Version number inconsistency in email package

2010-06-26 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> wont fix stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.o

[issue9091] str.capitalize() should not lower the rest of the string

2010-06-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Capitalization is a language property, it is not Python specific. By Definition, except for first letter every thing else is lower cased. http://en.wikipedia.org/wiki/Capitalization So, Python documentation assumes that it is understood (or can referred to

[issue3428] httplib.HTTPMessage undocumented

2010-06-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r82322 and r82323. Actually urllib.urlopen.info method return a mimetools.Message instance and a HTTPMessage instance is used within httplib only. It is more internal purposes to deal with headers with add_continue like methods is required

[issue8653] urlparse.urlparse/urlsplit doc missing

2010-06-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r82324, r82325, r82326, r82327. Only the urlunsplit need the docstrings, I added that. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python track

[issue9097] os.chdir(path) to return current dir

2010-06-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: -1 on chdir returning a the directory name. -1 on having it as context manager. Both are non-intuitive and may not serve any utility value. This can be verified by looking the code at the places where these functions are currently used. Brian also mentions

[issue3428] httplib.HTTPMessage undocumented

2010-06-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: That was a Documentation mistake. Thanks for pointing out. Corrected it in revision 82334 and merged to other branches. -- ___ Python tracker <http://bugs.python.org/issue3

[issue9097] os.chdir(path) to return current dir

2010-06-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Mon, Jun 28, 2010 at 04:50:12PM +, anatoly techtonik wrote: >I also can't see how can I verify you assumptions by looking at the code. In the python source: find -name "*.py" | xargs grep 'os.chdir' gives 143 instance

[issue3430] httplib.HTTPResponse documentations inconsistent

2010-06-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, I know httplib documentation needs improvement. There is a great deal of documentation in the module itself. A lot can be .rst'ifed. -- assignee: georg.brandl -> orsenthil nosy: +orsenthil resolution: -> accepted stage: -> needs

[issue3428] httplib.HTTPMessage undocumented

2010-06-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Mon, Jun 28, 2010 at 08:51:58PM +, ThomasH wrote: > But the urllib.rst documentation is still flawed: Fixed now in the r82363. Did a find and grep on all instances of HTTPMessage and verified that it is only at proper places now. Thanks for point

[issue1643370] recursive urlparse

2010-06-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is already handled via namedtuple in the urlparse. All the parts of the url are available by parsing. -- resolution: -> out of date stage: unit test needed -> committed/rejected status: open -&g

[issue1643370] recursive urlparse

2010-07-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: David, Is the stage "unit test needed" proper for this or was it by mistake? Anatoly, I thought closing this feature request was fine, because I considered that with namedtuple the desired attributes of url's were obtained as ParsedTupl

[issue5468] urlencode does not handle "bytes", and could easily handle alternate encodings

2010-07-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: I see no problem in going ahead with the suggestion proposed and the patch. - I checked with RFC3986 Section 2.5 http://labs.apache.org/webarch/uri/rfc/rfc3986.html#identifying-data Relevant line: When a new URI scheme defines a component that represents

[issue5468] urlencode does not handle "bytes" and could easily handle alternate encodings

2010-07-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed and Committed revision 82510 (py3k) and revision 82511 (release31-maint). This fixes urlencode issue. parse_qs and parse_qsl can have the same capabilities. It will be done subsequently (in another commit or issue) Thanks Dan for the bug report and

[issue9091] str.capitalize() should not lower the rest of the string

2010-07-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed it in r82570. Hyper linking lowered was leading to something like str.lower ed. So, I simply left it. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed _

[issue9091] str.capitalize() should not lower the rest of the string

2010-07-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Updated the docstrings in r82573. -- ___ Python tracker <http://bugs.python.org/issue9091> ___ ___ Python-bugs-list mailin

[issue9208] SMTPHandler in the logging module does not handle unicode strings

2010-07-09 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- title: SMTPHandler does not handle unicode strings -> SMTPHandler in the logging module does not handle unicode strings ___ Python tracker <http://bugs.python.org/iss

[issue5286] urrlib2 digest authentication problems

2010-07-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue5286> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8801] Inconsistency in behaviour of urllib and urllib2 with file:// URLs

2010-07-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: There were differing behaviors in the way urllib and urllib2 was handling certain kind of file:// urls which led to this error. I just made them consistent with the fix in r82780 and merged into branches. Now, this Exception won't be thrown at the

[issue2007] cookielib lacks FileCookieJar class for Internet Explorer

2010-07-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: I removed the documentation comment in r82785. But the report still holds till we have a class for handling MSIE Cookies. -- nosy: +orsenthil stage: -> needs patch ___ Python tracker <http://bugs.pyth

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2010-07-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: georg.brandl -> orsenthil resolution: -> accepted ___ Python tracker <http://bugs.python.org/issue2202> ___ ___

[issue3647] urlparse - relative url parsing and joins to be RFC3986 compliance

2010-07-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: Several changes were already made to urlparse to make it more rfc3986 compliant. Let me recollect what else these patches offer. -- assignee: gregory.p.smith -> orsenthil ___ Python tracker &l

[issue1500504] Alternate RFC 3986 compliant URI parsing module

2010-07-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: A new way for parsing URI. I have not reviewed it even after saying I would like to, but having the dependency issue resolved, I think it is good to look at it again, especially if it leads some helpful approaches to parsing IRI. -- assignee

[issue4140] urllib2: request with digest auth through proxy fail

2010-07-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: This might be related to issue2202 as well. -- assignee: gregory.p.smith -> orsenthil dependencies: +urllib2 fails against IIS 6.0 (No support for MD5-sess auth) nosy: +orsenthil resolution: -> accepted ___

[issue4493] urllib2 doesn't always supply / where URI path component is empty

2010-07-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue4493> ___ ___ Python-bugs-list mailing list Unsubscri

[issue7752] Add support for Digest authentication session (reuse nonces)

2010-07-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil resolution: -> accepted stage: unit test needed -> patch review ___ Python tracker <http://bugs.python.o

[issue900112] cgi.fieldStorage doesn't grok standards env. variables

2010-07-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue900112> ___ ___ Python-bugs-list mai

[issue4932] Little improvement on urlparse module, urlparse function.

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: I reviewed the patch and we may not go with it. - There is recent improvements in parsing and the patch does not go well with it, especially the clear_cache removal. Also there is a mistake in the patch: -scheme, url = url[:i].lower(), url[i+1

[issue1349732] urllib.urlencode provides two features in one param

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: This was fixed as part of Issue8788. Closing this. -- resolution: -> duplicate stage: unit test needed -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue5843] Possible normalization error in urlparse.urlunparse

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Currently this claim will fail: >>> obj = urlparse.urlparse('http://a/b/c?') >>> urlparse.urlunparse(obj) 'http://a/b/c' >>> obj = urlparse.urlparse('http://a/b/c#') >>> urlparse.urlunparse(obj

[issue6853] system proxy not used for https (on windows)

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r82890 and branches. Thanks Mark for bringing these issues out. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bug

[issue6960] test_telnetlib gives spurious output

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: No problems observed now. I randomized and ran the tests a couple of times. I don't know what the scenario was when this was observed, so I will let __ap__ close the issue. -- nosy: +orsenthil ___ Python tr

[issue7965] Problem with urlparse in Windows XP after a drag and drop

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: The resultant url you get after doing a urlparse is not a Windows PATH, but url path component. So, when you use in relative manner by doing urljoin, you will see that the original will get constructed properly. So, there is really no a problem here

[issue9132] Documentation for comparing dictionaries is out of date

2010-07-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch was pretty good. Committed it in r82899 and r82900. Thanks Eli for the patch & Terry for the review. -- nosy: +orsenthil resolution: -> fixed stage: commit review -> committed/rejected status: open

[issue1475523] gettext breaks on plural-forms header

2010-07-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: Minor change request. +class Bug1448060(GettextBaseTest): Can you name the test class something more meaningful like PluralFormsTest or something like that. It is helpful when looking at it later. (Btw, this can be done by the committer during checkin too

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: Incidentally, I was working on this yeserterday. Some minor changes were required in the patch as quote had undergone changes. Fixed and committed in revision 82940. Thanks to Matt Giuca for this. -- resolution: accepted -> fixed stage: pa

[issue9301] urllib.quote(None) returns None in 2.7 (raised TypeError before)

2010-07-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: The fast path was intended to return the empty string. When s is None, it should return a TypeError. -- assignee: -> orsenthil resolution: -> accepted ___ Python tracker <http://bugs.python.org/

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: I just checked your comment in the checkins list. I saw this is as bug-fix, which was leading to change in the signature of the quote function, still in backward compatible way. Should we still not do it? I understood only feature requests and behavior

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Well, my understanding was Type:behavior was a bug fix and Type: feature request was a new feature request, which may change some underlying behavior. I thought this issue was on the border. The robotparser using this might be just one usage indicator, but

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Mon, Jul 19, 2010 at 11:25:30AM +, Antoine Pitrou wrote: > If we were following you, we would add "encoding" and "errors" > arguments to any str-accepting 2.x function, so that it can also > accept unicode strings. That

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: There are two points here: First, is it a desired behavior of quote function in 2.7? IMO, it is. In the discussions of issue3300, I think, it was decided that quote handling of unicode strings may be backported. Behaviour wise the modified version still

[issue9301] urllib.quote(None) returns None in 2.7 (raised TypeError before)

2010-07-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed and committed in revision 82977. And similar changes for py3k in revision 82983. -- resolution: accepted -> fixed stage: -> committed/rejected status: open -> closed ___ Python track

[issue2244] urllib and urllib2 decode userinfo multiple times

2010-07-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks Ray Allen. Usually the patch against the py3k branch is enough, it will be ported to other branches. -- ___ Python tracker <http://bugs.python.org/issue2

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: I agree to the points raised by Antoine. Also yesterday in IRC, Eric Smith mentioned that If someone uses these new parameters in 2.7.1 his code may not work with 2.7 (That would obviously be an undesirable behavior). So, it is better to leave at Exception

[issue6791] httplib read status memory usage

2010-07-20 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue6791> ___ ___ Python-bugs-list mai

[issue7464] circular reference in HTTPResponse by urllib2

2010-07-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: Lets just investigate the circular reference part here for this ticket. -- assignee: -> orsenthil versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.5, Python 2.6 ___ Python tracker <http://bugs.pyth

[issue9272] CGIHTTPServer poisons os.environ

2010-07-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch and the tests look good. I could verify it too. I shall commit it. -- assignee: -> orsenthil resolution: -> accepted ___ Python tracker <http://bugs.python.org/

[issue1712522] urllib.quote throws exception on Unicode URL

2010-07-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: Reverted the checkin in revision 83045. For the robotparser issue, one of the these two can be adopted. 1. Fix it by decoding the unicode url using utf-8, strict. 2. Catch the KeyError exception and raise a TypeError exception from the robotparser module

[issue6325] robotparser doesn't handle URL's with query strings

2010-07-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: I modified the patch slightly (so that it takes care of path, query, params and fragments). Fixed in r83209,r83210 and r83211. I also think that we need to move the robotparser to allow regexs in the allow and disallow patterns. ( Shall open an issue in

[issue9423] Error in urllib2.do_open(self, http_class, req)

2010-07-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: urllib2 currently supports the HTTPS over Proxy, you might want to use that Handler (HTTPSProxyHandler) instead of using the recipe that you attached. -- nosy: +orsenthil ___ Python tracker <h

[issue9301] urllib.quote(None) returns None in 2.7 (raised TypeError before)

2010-07-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: Flox, agree to your patch on checking for unquote({}) and unquote(()). AttributeError on unquote(None) was a mistake in previous releases and it was not intentional. We stand at a chance of correcting that when we are explicitly raising an Exception

[issue9432] unquote(None) raises AttributeError - Instead of TypeError

2010-07-30 Thread Senthil Kumaran
New submission from Senthil Kumaran : >>> from urllib.parse import unquote >>> unquote(None) Traceback (most recent call last): File "", line 1, in File "/home/senthil/python/release31-maint/Lib/urllib/parse.py", line 331, in unquote res = strin

[issue9301] urllib.quote(None) returns None in 2.7 (raised TypeError before)

2010-07-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 83294. Opened Issue9432 just to track that change in Exception behavior. -- status: open -> closed ___ Python tracker <http://bugs.python.org/iss

[issue9432] unquote(None) raises AttributeError - Instead of TypeError

2010-07-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: The previous hyperlink should have been: Issue9301 Fixed in revision 83294. As this a change in Exception value, I am not sure, if backport is a good idea. If someone find change this breaks their existing setup, please comment here. -- stage

[issue8123] TypeError in urllib when trying to use HTTP authentication

2010-08-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r83415 and r83416. -- resolution: accepted -> fixed stage: unit test needed -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.o

[issue8572] httplib getheader() throws error instead of default

2010-08-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 83521 (py3k) and 83522 (release31-maint). I made slight modifications to the patch to include non-iterable values,like int, for default too. If you feel the documentation could be made better, please suggest the wordings for the sentence

[issue8572] httplib getheader() throws error instead of default

2010-08-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: David, your suggested description was much better. Modified the documentation in r83529 and r83530. -- status: open -> closed ___ Python tracker <http://bugs.python.org/iss

[issue754016] urlparse goes wrong with IP:port without scheme

2010-08-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 83700 (release27-maint). r83701(py3k) and r83702(release31-maint). David, thanks for reworking on the patch. Couple of comments - I made change to the original patch where I checked 'https:' and 'http:' kind of u

[issue8123] TypeError in urllib when trying to use HTTP authentication

2010-08-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Surprising that it was not observed in my system (Ubuntu). There was mistake where in the bytes value was being coerced to a string. bauth = "Basic: %s" % auth // with auth was bytes. Fixed it in r83729 and r83730. -- status: open

[issue8280] urllib2 passes fragment identifier to server

2010-08-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 83818(py3k), 83819 (release31-maint) and 83820 (release27-maint). David, a couple of comments on your patch. - Request method was from urllib2, so the proper place of tests were test_urllib2. This already had Requests test so some

[issue8280] urllib2 passes fragment identifier to server

2010-08-08 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: accepted -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.o

[issue9545] Adding _collections to static build

2010-08-09 Thread Senthil Kumaran
New submission from Senthil Kumaran : As a fix for issue9396 in r83874, functools was included in re module and this caused a build failure. This was reverted in r83875, with the following message by Raymond: The problem is that the re module is imported by sysconfig and re needs functools

[issue9545] Adding _collections to static build

2010-08-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 83876. The reverted commit r83875 is re-applied in r83877. -- assignee: -> orsenthil components: +Build nosy: +rhettinger resolution: -> fixed stage: -> committed/rejected status: open -> closed versions:

[issue5416] str.replace does strange things when given a negative count

2010-08-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed the doc string for release27-maint in revision r83879. py3k (r83880) and release31-maint in r83881. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed type: feature request -&

[issue9545] Adding _collections to static build

2010-08-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is the message from the buildbot failure: Modules/Setup.dist is newer than Modules/Setup; check to make sure you have all the updates you need in your Modules/Setup file. Usually, copying Modules/Setup.dist to Modules/Setup will work. I am not sure, if

[issue7007] Tiny inconsistency in the orthography of "url encoded" in the doc of urllib.parse

2010-08-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Docs updated in r83900 (py3k), r83903 (release31-maint), r83905 (release27-maint) Modules updated in revision 83901 (py3k), r83904 (release31-maint), r83906 (release27-maint). -- resolution: -> fixed stage: needs patch -> committed/re

[issue9546] buildbot: if a compile error occurs, the "clean" step is skipped

2010-08-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Mon, Aug 09, 2010 at 08:57:31PM +, Martin v. Löwis wrote: > I still fail to see the bug - it's by design that later build steps are > not executed if earlier build steps failed. It would be possible to let > the slaves start over with a

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2016-12-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: Just an update. We missed the last 2.7.13 release train. Sorry for that. It's worth to fix this bug still ASAP. It's intricately related to some other bugs like (issue25458, issue26960). I got to this and realized the dependency and other bugs.

[issue29134] contextlib doc bug

2017-01-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: I am going to vote for "not a bug" here. From the context is it understood that the `ContextBaseClass` is to be provided by the user. > Existing context managers that already have a base class can be extended by > using ContextDecorator

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-06 Thread Senthil Kumaran
New submission from Senthil Kumaran: It started as a discussion in this issue: http://bugs.python.org/issue22417#msg284604 I think, that warning can be removed. If no one has any objections, I will commit this attached patch. -- assignee: orsenthil components: Documentation files

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch looks good to me, and can committed. Thanks! -- ___ Python tracker <http://bugs.python.org/issue29189> ___ ___ Pytho

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: @Martin, that's a sound advice. I agree to it. I'll change it to a note (instead of warning) which mentions about certificate verification since 2.7.9. -- ___ Python tracker <http://bugs.python.o

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2017-01-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: I spent time digging for a proper fix for this issue. I've come to a conclusion that this commit, https://hg.python.org/cpython/rev/44d02a5d59fb (10 May 2016) in 2.7.12, was a mistake and needs to be reverted. The reason this change was made was appar

[issue16270] urllib hangs when closing connection

2017-01-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: The original problem here was retrieving files failed (hung) when it was tried via context-manager 1. For e.g after "reverting" the changes, if you use the original file without the context manager, it will succeed. fobj = urllib.request.ur

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Here is the updated patch that addresses the comment. -- Added file: http://bugs.python.org/file46401/issue29182_docs_fix.patch ___ Python tracker <http://bugs.python.org/issue29

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2017-01-25 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thank you, Mariatta. -- nosy: +orsenthil resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi Julian, here is the patch that addresses you comments. Thanks -- Added file: http://bugs.python.org/file46430/issue29182-patch3.diff ___ Python tracker <http://bugs.python.org/issue29

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thank you for the review, Julian. Addressed it and the change is committed at changeset b5125e971fdd -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python track

<    13   14   15   16   17   18   19   20   21   >