[issue16300] Windows raises ValueError for file:///file/not/exists instead of URLError

2012-10-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: The problem is here: if url[:2] == '//' and url[2:3] != '/' and url[2:12].lower() != 'localhost/': raise ValueError("file:// scheme is supported only on localhost") On Unix like systems url[2:3] == '/', th

[issue16301] localhost() and thishost() in urllib/request.py

2012-10-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: Serhiy: Yes. I stand corrected. That snippet suggestion was my mistake. I think, wrapping the test is better than changing the return of localhost. It would always return a single value. Thanks. -- ___ Python

[issue16302] Fix ResourceWarning in Lib/test/test_urllib.py

2012-10-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in 478cda291bbc Berker - with urlopen(tmp_fileurl) as fobj: self.assertTrue(fobj) is enough when using context manager as the fobj gets closed automatically at exiting of context. Thanks. -- resolution: -> fixed status: o

[issue16250] URLError invoked with reason as filename

2012-10-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: The change in 49de26395d1a addresses the buildbot failure. I have given a run again. -- ___ Python tracker <http://bugs.python.org/issue16

[issue16250] URLError invoked with reason as filename

2012-10-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: The change I had made for fixing the windows buildbot had not fixed it. I am skipped (1f92315d9568) the test on windows, investigating the reason for windows behavior and I shall remove the skiptest on windows after fix

[issue10836] urllib.request.urlretrieve calls URLError with 3 args

2012-10-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Nope, I have backport it to other versions. I shall close it then. -- ___ Python tracker <http://bugs.python.org/issue10

[issue16301] localhost() and thishost() in urllib/request.py

2012-10-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: > Serhiy Storchaka added the comment: > >> +tmp_fileurl = 'file://localhost' + tmp_file > > tmp_fileurl = 'file://localhost/' + tmp_file.replace(os.path.sep, '/') Ok, I realized the mistake. &#x

[issue16301] localhost() and thishost() in urllib/request.py

2012-10-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Buildbot still failing, but due to different reason. PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'c:\\users\\buildbot\\appdata\\local\\temp\\tmpwwvqao' http://buildbot.pyth

[issue16301] localhost() and thishost() in urllib/request.py

2012-10-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is fixed in 3.3 and 3.2 3.2 5e71f2712076 3.3 30547e2cd04d -- resolution: -> fixed status: open -> closed versions: -Python 2.7 ___ Python tracker <http://bugs.python.org/i

[issue16250] URLError invoked with reason as filename

2012-10-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is fixed in all versions now. -- assignee: -> orsenthil resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue16300] Windows raises ValueError for file:///file/not/exists instead of URLError

2012-10-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: Buildbot issues are taken care. They are green for while. Tests have been backported 3.3 and 3.2 as well. 3.2 5e71f2712076 3.3 30547e2cd04d -- resolution: -> fixed stage: -> committed/rejected status: open -&g

[issue10836] urllib.request.urlretrieve calls URLError with 3 args

2012-10-27 Thread Senthil Kumaran
Senthil Kumaran added the comment: This has been backported. 3.2 5e71f2712076 3.3 30547e2cd04d -- assignee: -> orsenthil resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tr

[issue20939] test_geturl of test_urllibnet fails with 'https://www.python.org/' != 'http://www.python.org/'

2014-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: The suggested patch(s) looks good to me. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue20939> ___ ___

[issue21190] Broken download link on README for CPython docs

2014-04-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed this all active versions. Thanks for the report. -- nosy: +orsenthil resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue7776] http.client.HTTPConnection tunneling is broken

2014-04-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: I am reviewing this patch right now and you will see my action soon. It is completely and I am reviewing to validating the technical details/fix. Thanks for patch, Nikolaus. -- ___ Python tracker <h

[issue7776] http.client.HTTPConnection tunneling is broken

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: I verified the patch and this indeed corrects a nasty bug in sending a wrong header when doing it a lower level HTTPSConnection to proxy and set_tunnel (bad term) to the end host..I was worried as why we did not observe this earlier and it seems to me that

[issue7776] http.client.HTTPConnection tunneling is broken

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is fixed in 3.4 and 3.5 (finally). I will port it to 2.7 as well. -- ___ Python tracker <http://bugs.python.org/issue7

[issue7776] http.client.HTTPConnection tunneling is broken

2014-04-14 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> fixed stage: test needed -> committed/rejected versions: +Python 3.5 -Python 2.7, Python 3.3 ___ Python tracker <http://bugs.python.org/

[issue21219] WARNING: Inline literal start-string without end-string.

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Oops did not notice. Thanks for catching. -- ___ Python tracker <http://bugs.python.org/issue21219> ___ ___ Python-bugs-list m

[issue21219] WARNING: Inline literal start-string without end-string.

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed: 3.5 a85606b6de32 3.4 fb5516cbc522 -- resolution: -> fixed stage: -> committed/rejected status: open -> closed type: compile error -> behavior ___ Python tracker <http://bugs.python

[issue21224] BaseHTTPRequestHandler, update the protocol version to http 1.1 by default?

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: It may not just the be the version, but the capabilities. We have ensure that capabilities are met/added before updated the version. Thanks for filing the issue. -- nosy: +orsenthil ___ Python tracker <h

[issue10318] "make altinstall" installs many files with incorrect shebangs

2014-04-14 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: -orsenthil ___ Python tracker <http://bugs.python.org/issue10318> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16278] Improve os.rename documentation and tests

2014-04-14 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: -orsenthil ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13244] WebSocket schemes in urllib.parse

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Reading both the RFCs and requirements, I see that this is already taken care. Note: we are actually have unencoded fragment like # and RFCs talk about fragments with # character only. If you want the behavior of parse with urlencoded to match un-urlencoded

[issue9374] urlparse should parse query and fragment for arbitrary schemes

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Reviewed the issue and correct rollbacks and commits were applied. This ticket should be closed. Thanks! -- status: open -> closed ___ Python tracker <http://bugs.python.org/iss

[issue10983] Errors in http.client.HTTPConnection class (python3)

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, they indeed are. Thank you! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue21228] Missing enumeration of HTTPResponse Objects methods of urllib.request.urlopen's http.client.HTTPResponse?

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hello Evens, If you can, then please attach a doc to this and we and fix this soon. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue21

[issue21229] Path used for HTTP PUT request doesn't match the description

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: A simple docs patch would definitely help here. Thanks for the bug report. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue21

[issue21229] Path used for HTTP PUT request doesn't match the description

2014-04-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Sure, here is the information on how to create a patch - https://docs.python.org/devguide/ It could feel that there are multiple steps, but the process is easy. -- ___ Python tracker <http://bugs.python.

[issue21248] BROWSER env var described inaccurately in webbrowser docs

2014-04-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: Which may be sane thing thing do. So the docs could be made better. Like - the list of browsers specified in env var BROWSER is tried first before looking at the platform defaults. -- nosy: +orsenthil ___ Python

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

2014-04-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: I am getting to this late. >> I don't know whether the file descriptor read is expected to be meaningful >> for urllib2/urllib.request. >> Senthil, what do you think? It should be meaningful no matter what the length is. I am looking

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

2014-04-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is the best way I found to reproduce the failure. I changed the resource to www.example.com and then ran this. $ ./python.exe -m test -m "*fileno*" -u all -v -F test_urllibnet -- ___ Python trac

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

2014-04-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is turning out be trickier than I ever thought. fileno() returning b'' is just random error. The underlying issue is, *directly* reading from the fp of the socket() is returning a incomplete output at all times. The correct way to read the ou

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

2014-04-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: Ned Deily had done the correct analysis in the msg214947 and has this question - > I don't know whether the file descriptor read is expected to be meaningful > for urllib2/urllib.request. I can see that this test case was for the old behavi

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: > I'll make another wireshark recording to get more details for me to analyze. Thank you! That will be useful. Please test it against 3.x version as it has seen cleanups recently. -- ___ Python tracke

[issue21257] Document parse_headers function of http.client

2014-04-16 Thread Senthil Kumaran
New submission from Senthil Kumaran: It is undocumented. While fixing a doc issue issue18229 for http.server I noticed that I referenced that function and when I looked up for the documentation, it was lacking. -- assignee: orsenthil messages: 216494 nosy: orsenthil priority: normal

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Christian , with respect to patch, I agree with the logic (using something similar to #18879). Does all current unittests succeed with this? (I suspect not) A unittest for coverage would be helpful. -- ___ Python

[issue18229] attribute headers of http.server.BaseHTTPRequestHandler sometimes does not exists

2014-04-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.5 -Python 2.7, Python 3.3 ___ Python tracker <http://bugs.python.or

[issue21190] Broken download link on README for CPython docs

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Éric, no preference. I thought this was explicit and if you would like to change it back to /3/, fine, no problem with me. Just think of any redirection issue, if we may accidentally stumble upon, that'

[issue21229] Path used for HTTP PUT request doesn't match the description

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes. And thanks for the patch. I applied a slight variation of it. -- ___ Python tracker <http://bugs.python.org/issue21

[issue21248] BROWSER env var described inaccurately in webbrowser docs

2014-04-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the bug report. The documentation has been fixed in the active versions. -- versions: +Python 3.4, Python 3.5 -Python 2.7 ___ Python tracker <http://bugs.python.org/issue21

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Christian's patch is good.It helps in setting the socket.makefile file descriptor to a well behaving well file close wrapper and thus will help us prevent some tricky fd close issues. I added tests for coverage to ensure that we are asserting the typ

[issue10362] AttributeError: addinfourl instance has no attribute 'tell'

2014-04-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: I agree. Having tell on a file descriptor of a URL request is not going to be of help. You can easily write to a local file and use all the local file features, if it is things like .tell is desired. -- resolution: -> not a bug stage: needs pa

[issue18967] Find a less conflict prone approach to Misc/NEWS

2014-04-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: -orsenthil ___ Python tracker <http://bugs.python.org/issue18967> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16827] Remove the relatively advanced content from section 2 in tutorial

2014-04-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: For this bug, I think, section 2.2.4 and section 2.2.5 can be moved to section 13 and inserted between section 13.1 and 13.2 as it seem to be fit in naturally there. -- ___ Python tracker <http://bugs.python.

[issue2052] Allow changing difflib._file_template character encoding.

2014-04-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: -orsenthil ___ Python tracker <http://bugs.python.org/issue2052> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15002] urllib2 does not download 4 MB file completely using ftp

2014-04-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is fixed in 3.4 and 3.5. I will backport to 2.7 ( I think, it is worth it). -- resolution: -> fixed stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/i

[issue7776] http.client.HTTPConnection tunneling is broken

2014-05-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: I am glad that issues with 3rdparty libs which dependent on the previous wrong behavior has been resolved. As indicated previously, I think, it makes sense to have this in 2.7 as well. I created a patch and tested it 2.7 and it is all good. I plan to commit

[issue7776] http.client.HTTPConnection tunneling is broken

2014-05-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is fixed in 2.7 as well here (changeset 568041fd8090). We shall close this ticket after @dstufft pulls in the updated pip for 3.4 Thanks! -- priority: high -> release blocker versions: +Python 2.7 ___ Pyt

[issue7776] http.client.HTTPConnection tunneling is broken

2014-05-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: I prefer we update the ensurepip in 3.4.1 That will be helpful too since 3.5 has the fix. -- ___ Python tracker <http://bugs.python.org/issue7

[issue7776] http.client.HTTPConnection tunneling is broken

2014-05-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: @dstufft - should you commit it in 3.4 branch (since the change is already in 3.5) and then wait for larry's approval or rejection? -- ___ Python tracker <http://bugs.python.org/i

[issue7776] http.client.HTTPConnection tunneling is broken

2014-05-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- versions: +Python 2.7 ___ Python tracker <http://bugs.python.org/issue7776> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21640] References to other Python version in sidebar of documentation index is not up to date

2014-06-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: I see that all the patches are correct. My only worry is since 3.1,3.2 and 3.3 are in security fix only mode, we may not apply it to those. 2.7, 3.4 and 3.5 ones are okay. -- nosy: +orsenthil ___ Python tracker

[issue21640] References to other Python version in sidebar of documentation index is not up to date

2014-06-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed the follwing changesets. 2.7 b8655be522d4 3.4 e6dce5611dae 3.5 50c9df76bb77 -- resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker <http://

[issue21643] "File exists" error during venv --upgrade

2014-06-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: I could not reproduce this in 3.4 / 3.5 [localhost 21643]$ ./python.exe Tools/scripts/pyvenv --upgrade usage: venv [-h] [--system-site-packages] [--symlinks | --copies] [--clear] [--upgrade] [--without-pip] ENV_DIR [ENV_DIR ...] venv

[issue21648] urllib urlopener leaves open sockets for FTP connection

2014-06-03 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue21648> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21641] smtplib leaves open sockets around if SMTPResponseException is raised in __init__

2014-06-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: The first patch was correct and consistent with how other Exceptions were closing the socket. Fixed this and thanks for the patch. -- assignee: -> orsenthil nosy: +orsenthil resolution: -> fixed stage: -> resolved status: open -> clo

[issue21693] Broken link to Pylons in the HOWTO TurboGears documentation

2014-06-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed these. Thanks for the report. -- nosy: +orsenthil resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue19917] [httplib] logging information for request is not pretty printed

2014-06-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: I believe, repr() is the correct call here. You should know the proper end of line characters like \n, \r\n which were sent in the request while debugging. A pretty print here, while look good, might remove that capability and thus may not add any value in

[issue16423] urllib data URL recipe

2012-11-06 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: docs@python -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue16423> ___ ___ Python-

[issue16388] Urllib screws up capitalization in "User-Agent" HTTP Header

2012-11-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: Calvin. - I shall act upon old bug. The tricky nature of backwards compatibility sometimes let's it stale because we can not come t a good conclusion. -- nosy: +orsenthil ___ Python tracker

[issue16450] test_missing_localfile masks problems in urlopen

2012-11-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue16450> ___ ___ Python-bugs-list mai

[issue12614] Allow to explicitly set the method of urllib.request.Request

2012-11-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hello Miki Tebeka, The change requested by this issue (and provided by the patch) is already in place in 3.3. This was committed as part of issue1673007 has the same behavior too. I am closing this as duplicate. Thank you, Senthil -- resolution

[issue16634] urllib.error.HTTPError.reason is not documented

2012-12-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for raising the bug and patch, Berker Peksag. Fixed in all versions. -- nosy: +orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue15701] AttributeError from HTTPError when using digest auth

2012-12-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: Even though 2.x is in security fix mode, this can be fixed by a overriding the base class's info method in the HTTPError class and returning the .hdrs attribute instead of .headers. -- Added file: http://bugs.python.org/file28273/Issue1571.

[issue15701] AttributeError from HTTPError when using digest auth

2012-12-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Okay. this is fixed in all versions of python. Sorry for the delay. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue16713] "tel" URIs should support params

2012-12-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in all codelines. Thank you! -- assignee: -> orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.or

[issue9022] TypeError in wsgiref.handlers when using CGIHandler

2012-12-25 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Add fixups for encoding problems to wsgiref ___ Python tracker <http://bugs.pytho

[issue16702] Force urllib2_localnet test not to use http proxies

2012-12-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Jeff, Thanks for raising this issue. The aspect of skipping localhost for proxies in urllib2_localnet tests can be handled in a different way as well, namely by setting the environment varible NO_PROXY to "*". By this the skip_proxies in urllib2 re

[issue16702] Force urllib2_localnet test not to use http proxies

2012-12-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in all branches of CPython. Thanks. -- assignee: -> orsenthil resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue1674555] sys.path in tests contains system directories

2012-12-31 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue1674555> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16827] Remove the relatively advanced content from section 2 in tutorial

2012-12-31 Thread Senthil Kumaran
Senthil Kumaran added the comment: +1 from me as well. I am also adding Eric who might have views on the customization part which added by him. -- nosy: +eric.araujo, orsenthil ___ Python tracker <http://bugs.python.org/issue16

[issue16434] SocketServer call shutdown in the wrong way

2012-12-31 Thread Senthil Kumaran
Senthil Kumaran added the comment: Looks an invalid bug to me as well. request is a socket.socket object and has shutdown method taking a single argument. The error pasted in the report leads me to believe if the shutdown_request call is not thread-safe and it is ending up called shutdown

[issue16819] IDLE b"" method completion incorrect

2013-01-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch seems good to me. Please commit it. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue16

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hello Zachary, What'wrong with referencing :class:`file` for iterable? I find it as OK. Also if it needs to be corrected, the reference could be made for :ref:`bltin-file-objects` Re grammatical fixes, you could point out which were made as with the r

[issue16814] use --directory option of make in describing how to build the docs

2013-01-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: I find, cd Doc easy to remember as well. If make tricks can be used then I hope readers note it rather than be exposed via Documentation. Chris's patch is helpful to me, but still I may not vote a +1 for it to be in Documentation. thanks. On Sun, Dec 30,

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: Oh Okay, Thanks! I was checking it against 2.7! On Tue, Jan 1, 2013 at 11:48 AM, R. David Murray wrote: > > R. David Murray added the comment: > > senthil: the file type doesn't exist any more in python3. > > --

[issue16747] Remove 'file' type reference from 'iterable' glossary entry

2013-01-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: I reviewed the patch. Changes LGTM. -- ___ Python tracker <http://bugs.python.org/issue16747> ___ ___ Python-bugs-list mailin

Re: [issue13810] refer people to Doc/Makefile when not using 'make' to build main documentation

2013-01-01 Thread Senthil Kumaran
___ > Python tracker > <http://bugs.python.org/issue13810> > ___ > ___ > Python-bugs-list mailing list > Unsubscribe: > http://mail.python.org/mailman/options/python-bugs-list/senthil%40uthcode.com &g

Re: [issue16871] Cleanup a few minor things

2013-01-05 Thread Senthil Kumaran
ython tracker > <http://bugs.python.org/issue16871> > ___ > ___ > Python-bugs-list mailing list > Unsubscribe: > http://mail.python.org/mailman/options/python-bugs-list/senthil%40uthcode.com > &

[issue16869] makesetup should support .S source files

2013-01-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Should not this be? *.S) obj=`basename $src .S`.o; cc='$(CC)';; # The filetype extension .S instead .cpp. And, I have less know-how on these, but for my understanding how would non-preprocessed asm files (.s) will be handled? And doc reference t

[issue16866] libainstall doesn't create $(BINDIR) directory

2013-01-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the fix. The patches fixes it. Since this is a bug fix, it should be backported all the way till 2.7. -- assignee: -> orsenthil nosy: +orsenthil stage: -> commit review versions: +Python 2.7, Python 3.2, Pyth

[issue16866] libainstall doesn't create $(BINDIR) directory

2013-01-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Digging a little deeper, make libainstall needs $(BINDIR) because of this $(INSTALL_SCRIPT) python-config $(DESTDIR)$(BINDIR)/python$(VERSION)-config *And* that python$(VERSION)-config file refers to the python exe which is available only after bininstall or

[issue16866] libainstall doesn't create $(BINDIR) directory

2013-01-05 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks Benno. I think that making libainstall depend on bininstall is a right solution too. A nod from devs who have committed changes in that area may help. Also, I believe that this is a bug fix and should be ported back upto 2.7. If there are any concerns

[issue5066] IDLE documentation for Unix obsolete/incorrect

2013-01-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: Regardless of the topic of merge, the suggested improvements for both idle.rst and help.txt are great! Thanks for working the patch, Todd. I am +1 with the changes. If no else has any comments, I can go ahead with committing this. -- nosy: +orsenthil

[issue16909] urlparse: add userinfo attribute

2013-01-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: If it does go in, due the RFC requirement, then it would be only in 3.4 (default branch) and the feature may not be backported. Without reading the RFC section, I have an intuitive -1 for this proposal because the suggestion may be a corner case rather than

[issue16904] Avoid unnecessary and possibly unsafe code from http.client.HTTPConnection.send

2013-01-09 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue16904> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12411] cgi.parse_multipart is broken on 3.x

2013-01-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: I personally think, that the "grey area" of multipart form encoding and trying to use email's updated features for parsing was holding it, not the tests. This can be submitted IMO after looking at the "related bugs", I shall do a

[issue12411] cgi.parse_multipart is broken on 3.x

2013-01-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: I updated the patch addressing Ezio's comments in the review system and also condensed the tests. This fixes the parse_multipart's byte handling at "some" level. The docstring of parse_multipart say that, this should be deprecated in fa

[issue17069] HTTP result code in urllib2.urlopen() file object undocumented

2013-02-01 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue17069> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17069] HTTP result code in urllib2.urlopen() file object undocumented

2013-02-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Here is he patch against the default that would address this reported issue. Same would go for other 3.x branches. The 2.7 only can just see the addition of getcode() documented. -- assignee: -> orsenthil keywords: +patch stage: -> patch

[issue17069] HTTP result code in urllib2.urlopen() file object undocumented

2013-02-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Éric, thanks for the comment. URLopener and FancyURLopener is deprecated, so that reference to that can be removed from 3.4 (after removing the URLopener and FancyURLopener class). Rest of the patch can stay the same

[issue17069] HTTP result code in urllib2.urlopen() file object undocumented

2013-02-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: I shall go ahead with this change. And when the URLopener and FancyURLopener removed, all their references in the docs (including this change) will be removed. -- ___ Python tracker <http://bugs.python.

[issue17069] HTTP result code in urllib2.urlopen() file object undocumented

2013-02-07 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue17069> ___ ___ Python-bugs-list

[issue17169] Restore errno in tempfile exceptions

2013-02-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch looks good and it is correct thing to do IMO. thanks. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue17

[issue17172] Add turtledemo to IDLE menu

2013-02-09 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue17172> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10852] SSL/TLS sni use in smtp, pop, imap, nntp, ftp client libs by default

2013-02-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue10852> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17167] python man page contains $Date$ in page footer

2013-02-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: There is another option. To have the same behavior like svn keywords through hg. Having this setting at server hgrc can help. This will be useful if we have more than one instance of keyword expansion. [extensions] keyword= [keyword] **/*.man = [keywordmaps

[issue17164] MozillaCookieJar does not handle session cookies

2013-02-10 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue17164> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17158] help() module searcher text improvement

2013-02-10 Thread Senthil Kumaran
Senthil Kumaran added the comment: You will stumble on that message, only if you give help("module ") and note that could be any module in the PYTHONPATH. We can change to show the text only if the module is a valid module, but I think, it is costly do that computation for help text

<    10   11   12   13   14   15   16   17   18   19   >