Change by Sanyam Khurana :
--
keywords: +patch
pull_requests: +4931
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Sanyam Khurana :
--
pull_requests: +4932
___
Python tracker
<https://bugs.python.org/issue15045>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Sanyam Khurana :
--
pull_requests: +4940
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue8525>
___
___
Python-
Sanyam Khurana added the comment:
I've changed the version to 3.7. Not sure if this would need a backport since
this is a new feature. So, I'll defer this call to a core developer. I've
created a PR for the new feature.
--
versions: +Python
New submission from Sanyam Khurana :
The step for configuration works correctly and gives a makefile.
On running `./make` the following traceback is produced:
```
$ make
Sanyam Khurana added the comment:
This is strange.
I cloned the repo again at some other location, and I can build it successfully.
In my older clone, however, it shows me this error, despite running a `make
clean`.
Any idea on what is the problem here?
--
nosy: +vstinner
priority
Sanyam Khurana added the comment:
Seems good to me. I've made the changes in the PR.
--
___
Python tracker
<https://bugs.python.org/issue29710>
___
___
Sanyam Khurana added the comment:
Hi,
My perception with all the discussion and WIP patch is that we can ideally
limit the no. of subclasses shown only for object, and not for any other class.
>From that list, the only unhelpful ones with > 4 items, in my opinion, appear
>to b
Sanyam Khurana added the comment:
Hey Tim,
> @CuriousLearner, does the PR also include Nick's first suggested change?
> Here:
"""
=
Bitwise operations only make sense for integers. The result of bitwise
operations is calculated as though carri
Sanyam Khurana added the comment:
On, yes, I think I missed the first point, earlier. Thank You! I did the
changes.
--
___
Python tracker
<https://bugs.python.org/issue29
Sanyam Khurana added the comment:
That's okay Eryn. We really appreciate all your help.
I will take this patch forward :)
--
___
Python tracker
<https://bugs.python.org/is
Change by Sanyam Khurana :
--
pull_requests: +8138
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue24255>
___
___
Python-
Sanyam Khurana added the comment:
Sure Conrad,
Yeah, indeed. The patch didn't apply cleanly, so I"ve done it manually.
I've raised the PR here: https://github.com/python/cpython/pull/8633
I'll check your patch and merge :)
Thanks for your help too!
I'm adding Pyth
Sanyam Khurana added the comment:
Hey Rajalakshmi,
Are you still working on this issue? Is there anything we can help you with?
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue21
Sanyam Khurana added the comment:
Hello Anjali,
As far as I remember, you started this in a PyDelhi Dev Sprint. So, just wanted
to check around, if you're looking for any help :)
--
nosy: +CuriousLearner
___
Python tracker
&
Sanyam Khurana added the comment:
+1 to Terry's suggestion.
I've reviewed xtreak's PR and it looks good to me.
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.pyt
Sanyam Khurana added the comment:
Hey Conrad,
I've merged your fixes as well. They are in the PR now. Also added your name in
the NEWS entry :)
@Vinay, I noticed that there are linting errors in `test_logging.py`. Does it
make sense to issue a separate Pull Request to fix those? Curr
Sanyam Khurana added the comment:
Yeah, that is understandable. I've reverted major chunk of it. Just in the http
client file, I've added blank lines where ever necessary (which I think won't
change the blame information for any of the code :))
Would that be okay?
Also, I
New submission from Sanyam Khurana :
I noticed this while reviewing the code.
The print function works like:
```
print (5)
```
This works with user-defined function too.
Ideally, this is a function call and we should return an error stating that
there shouldn't be any spaces be
Sanyam Khurana added the comment:
Hi,
I agree that it can break backward compatibility. But maybe we can add some
sort of warning message?
The entire motive of this is to get new folks to understand how a function is
ideally defined and called
Sanyam Khurana added the comment:
Hey Nick, Serhiy
The patch is up for your review. Any updates on this?
--
___
Python tracker
<https://bugs.python.org/issue15
Sanyam Khurana added the comment:
Marking this bug as fixed via https://github.com/python/cpython/pull/8645
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Sanyam Khurana added the comment:
Marking this fixed via
https://github.com/python/cpython/commit/ffc5a14d00db984c8e72c7b67da8a493e17e2c14
and
https://github.com/python/cpython/commit/fc8205cb4b87edd1c19e1bcc26deaa1570f87988
Thanks, everyone!
--
resolution: -> fixed
stage: pa
Sanyam Khurana added the comment:
The change in current PR is very minor and looks good enough that aligns the
docs with the docstring and functionality of `ZipFile.writestr` as described.
Can a core-contributor, please look at this?
Also, I'm adding 3.8 for this change.
--
Change by Sanyam Khurana :
--
pull_requests: +9837
___
Python tracker
<https://bugs.python.org/issue18859>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanyam Khurana added the comment:
Patch added in PR: https://github.com/python/cpython/pull/10591
--
nosy: +CuriousLearner
___
Python tracker
<https://bugs.python.org/issue18
Changes by Sanyam Khurana :
--
pull_requests: +107
___
Python tracker
<http://bugs.python.org/issue29549>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Sanyam Khurana :
--
pull_requests: +114
___
Python tracker
<http://bugs.python.org/issue29506>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Sanyam Khurana :
--
pull_requests: +120
___
Python tracker
<http://bugs.python.org/issue22702>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Sanyam Khurana :
--
pull_requests: +122
___
Python tracker
<http://bugs.python.org/issue18423>
___
___
Python-bugs-list mailing list
Unsubscribe:
Sanyam Khurana added the comment:
Hi, I'm working on fixing this issue.
--
nosy: +CuriousLearner
___
Python tracker
<http://bugs.python.org/issue13691>
___
___
Changes by Sanyam Khurana :
--
pull_requests: +138
___
Python tracker
<http://bugs.python.org/issue13691>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Sanyam Khurana:
On visiting link: https://docs.python.org/devguide/coredev.html#github
The first sentence is "You will be added to the Python core team on GitHub."
The ``Python core team`` refers to a link to Github which is not accessible to
anyone except for
Sanyam Khurana added the comment:
Thanks a lot Berker! I've reported the issue there at
https://github.com/python/devguide/issues/124
--
___
Python tracker
<http://bugs.python.org/is
Sanyam Khurana added the comment:
Hi,
It seems that it hasn't been worked upon from quite a long time and the patch
would also need changes. May I work on this?
--
nosy: +CuriousLearner
___
Python tracker
<http://bugs.python.org/i
Sanyam Khurana added the comment:
Mariatta, I apologize for this. I completely missed to see that this was
already assigned to someone else.
I've withdrawn my PR.
Thanks.
--
nosy: +CuriousLearner
___
Python tracker
<http://bugs.py
101 - 136 of 136 matches
Mail list logo
