Ryan Smith-Roberts added the comment:
Here's the socketmodule patch. I aggressively imported text from the docs for
the docstrings, along with matching parameter names, given how far the old
docstrings have drifted over time. The Windows-specific code is untested, but
otherwise the tests
Ryan Smith-Roberts added the comment:
Forgot to linewrap a paragraph.
--
Added file:
http://bugs.python.org/file33489/argument_clinic_socketmodule_v2.patch
___
Python tracker
<http://bugs.python.org/issue20
Ryan Smith-Roberts added the comment:
I've realized this is basically insoluble without PEP 457, because any other
solution involves changing behavior (None being silently accepted where it
would previously raise an exception). If that's OK, then per-function defensive
programming i
Ryan Smith-Roberts added the comment:
sha1 is Vajrasky's module. I have a much more complicated example (and Vajrasky
and I just both posted on python-dev separately about this issue):
sockobj.sendmsg(buffers[, ancdata[, flags[, address]]])
->
sockobj.sendmsg(buffers, ancdata=None,
Ryan Smith-Roberts added the comment:
No, that still leaves address broken since neither None nor an empty tuple are
acceptable.
--
___
Python tracker
<http://bugs.python.org/issue20
Ryan Smith-Roberts added the comment:
Tweaked the argument list for functions using a NULL default. Kludgy but
doesn't lie to the user.
--
Added file:
http://bugs.python.org/file33490/argument_clinic_socketmodule_v3.patch
___
Python tracker
Ryan Smith-Roberts added the comment:
The use case is primarily to minimize code churn for the derby, but since
you're the one (heroically) doing the code review it's really your call. I
whipped up a quick patch for this feature, and even if you remove c_name from
__init__ I think
Changes by Ryan Smith-Roberts :
Added file:
http://bugs.python.org/file33494/argument_clinic_ensure_legal_cleanup.patch
___
Python tracker
<http://bugs.python.org/issue20
Ryan Smith-Roberts added the comment:
Here's sendmsg with only nested bracket optional args. If Rietveld doesn't like
this patch I may cry.
--
Added file:
http://bugs.python.org/file33496/argument_clinic_socketmodule_v4.patch
___
Pyth
Ryan Smith-Roberts added the comment:
After all our discussions I'm closing this with resolution "don't do that then".
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http
Ryan Smith-Roberts added the comment:
socketmodule has three builtins which use PyLong_AsUnsignedLong on their
arguments and would benefit from these converters, but only if they raise
OverflowError. So I vote for #2.
I don't think it's unreasonable to continue to have local
New submission from Ryan Smith-Roberts:
Find test file attached. The exception:
Exception raised during parsing:
Traceback (most recent call last):
...
File "proj/python/trunk.hg/Tools/clinic/clinic.py", line 1535, in render
self.parse_argument(data.parse_arguments)
File &q
Ryan Smith-Roberts added the comment:
I believe the feature you starred resolves this enhancement issue, in which
case my patches are obsolete. And yes, the 'as' syntax makes a lot more sense.
Here's how I hope it works (the arg parsing wrapper remains unchanged):
foo
Ryan Smith-Roberts added the comment:
Yes, that makes more sense. The specific syntax is nearly irrelevant compared
to the feature existing at all. You still haven't indicated whether your
starred feature matches the *result* that I outlined. Do
Ryan Smith-Roberts added the comment:
I saw the fix for this in the commit stream. Closing.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issu
Changes by Ryan Smith-Roberts :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20252>
___
___
Python-bugs-list mailing list
Un
Ryan Smith-Roberts added the comment:
Perhaps the test is sending an infeasibly large message. If you remove the
'*2048' does it pass? (I set up a FreeBSD 9.2 amd64 VM but all tests are
passing here).
--
___
Python tracker
<http://bu
New submission from Ryan Smith-Roberts:
The docs indicate that you can do:
class foo_converter(CConverter):
...
c_default = 'bar()'
py_default = 'Bar'
except that CConverter.__init__() unconditionally overwrites these values.
Patch attached.
--
com
New submission from Ryan Smith-Roberts:
If a custom converter declares both default and converter class attributes, you
get this exception (test file attached):
Exception raised during parsing:
Traceback (most recent call last):
File "Tools/clinic/clinic.py", line 1445
Changes by Ryan Smith-Roberts :
--
components: +Build
type: -> crash
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue20300>
___
___
Py
Changes by Ryan Smith-Roberts :
--
nosy: +Nikratio
___
Python tracker
<http://bugs.python.org/issue20299>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ryan Smith-Roberts added the comment:
No, I'm happy. It isn't really news anyway, since the patch just brings reality
inline with the docs :).
--
___
Python tracker
<http://bugs.python.o
Ryan Smith-Roberts added the comment:
I have reviewed this as best I am able. I'll be honest that a lot of clinic.py
makes my eyes cross; I'm used to webdev templating, which is inverted from AC
(flow control inside the template). Not complaining, it's a complicated
subject
Ryan Smith-Roberts added the comment:
The send part of the test doesn't matter, since what's being tested happens
before any reads. The MSG multiplier should be removed completely, since none
of the other tests do that.
Patch attached.
--
Added file:
http://bugs.python.org
Ryan Smith-Roberts added the comment:
I notified secur...@python.org and waited for the go-ahead (from Guido I think)
before opening this bug. If today is the first that the PSRT is hearing about
this, then the issue is broader than just the bugtracker
401 - 425 of 425 matches
Mail list logo
