R. David Murray added the comment:
It seems to me that having import this work more than once would teach a
beginner the *wrong* lesson about how python import works. So I agree that it
should be a teaching moment, not a bug to be fixed.
--
nosy: +r.david.murray
Changes by R. David Murray :
--
nosy: +belopolsky, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19502>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
What do you mean by the whole test routine failing? The test suite is
currently passing on the buildbots, so are you speaking of the new test you are
trying to write?
--
___
Python tracker
<h
R. David Murray added the comment:
Hmm. Looking at this again, it appears as though there's no way to interrupt
IDLE if you want to, say, send an email. If you are actually using this in
code, how are you handling that situation?
--
___
P
R. David Murray added the comment:
Thanks, Vajrasky (and Victor :)
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Added some review comments.
Because it could cause possibly buggy doctest fragments to run that previously
did not run, I don't think it should be backported as a bug fix.
--
nosy: +r.david.murray
___
P
R. David Murray added the comment:
test_compileall has fairly extensive tests of the command line behavior, added
when we refactored from optparse to argparse. So a test should be added for
this case.
--
nosy: +r.david.murray
___
Python tracker
R. David Murray added the comment:
So the question is, if there is no longer a reference to the docstring, why
isn't it garbage collected? (I tested adding a gc.collect(), and it didn't
make any difference.)
--
nosy: +r.david.murray
R. David Murray added the comment:
Hmm. If I turn on gc debugging before the def, I don't see anything get
collected. If I allocate a series of new 10K strings, the memory keeps
growing. Of course, that could still be down to the vagaries of OS memory
management. Time to brea
R. David Murray added the comment:
I'd vote -1 on this one. The extra context in this case is not confusing, and
might be helpful to someone.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
I think both of you could stand to turn down the rhetoric :)
Laurent: we're not saying there's no issue, we're saying we don't see an
acceptable fix for the issue.
So the bottom line is that for this situation to improve someone is
R. David Murray added the comment:
We have an OpenIndian buildbot that compiles from our source, so no distro
changes. Can you sort out why this isn't a problem on the buildbut but is for
you? Your patch files says 2.6, so is it possible it is fixed in 2.7?
--
nosy: +r.david.m
R. David Murray added the comment:
Libreoffice is a big thing to compile as a test...do you know of any smaller
packages that exhibit the bug?
I've added jcea to nosy, he set up the OpenIndiana buildbots and may be able to
help clarify the issue. I'm not willing to opine on it sin
Changes by R. David Murray :
--
assignee: jcea ->
___
Python tracker
<http://bugs.python.org/issue19561>
___
___
Python-bugs-list mailing list
Unsubscrib
R. David Murray added the comment:
This is a duplicate of issue 9291. Can you answer Victor's question over there
for us?
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> mimetypes initialization
Changes by R. David Murray :
--
nosy: +adamhj
___
Python tracker
<http://bugs.python.org/issue9291>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
It is not a bug:
>>> parse_qs('a=&b=1', keep_blank_values=True)
{'a': [''], 'b': ['1']}
--
nosy: +r.david.murray
resolution: -> invalid
stage
R. David Murray added the comment:
This is not an aspect of Python that can possibly change, I'm afraid, for
backward compatibility reasons.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> Int
R. David Murray added the comment:
It doesn't look like you are waiting for the subprocess to complete (and
therefore close the files) before doing the rmtree. What happens if you do
that?
--
nosy: +r.david.murray
___
Python tracker
R. David Murray added the comment:
Nevermind, I forgot that the context manager also does the wait.
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Most likely this is a case of a virus scanner or file indexer having the file
open when rmtree runs. See issue 7443, which was about solving this for our
test suite. My last message there asks about exposing the workaround in
shutil, but no one appears to
R. David Murray added the comment:
Unfortunately I currently lack a windows environment on which to test this.
I've added some people to nosy who might be able to help out with this.
--
nosy: +gps, tim.golden
___
Python tracker
R. David Murray added the comment:
That was my initial thought, too, but the subprocess context manager waits for
the subprocess to end, so those file descriptors should be closed by the time
the deletion attempt happens, shouldn't
R. David Murray added the comment:
neologix noted that *when redirection is used* the way that *all* windows file
handles are inherited changes. But that's about the end of *my* understanding
of the issue :)
--
___
Python tracker
R. David Murray added the comment:
I believe that expected failure will give an error report if the test succeeds.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Looks fine to me.
--
___
Python tracker
<http://bugs.python.org/issue19590>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Any chance of getting a patch with the just the added changes? I'd rather not
fish through the stuff I've already looked at looking for the new stuff.
I'm of two minds about the advisability of b
R. David Murray added the comment:
Additional changes look good to me.
Unless (pun intended) Barry objects, I think I'll come down in favor of
backporting all of these changes. The tipping point is that I've always found
myself experiencing cognitive dissonance reading the
New submission from R. David Murray:
Based on this error on one of the buildbots, it is clear that support.temp_cwd
should be calling support.rmtree, and not shutil.rmtree, during cleanup:
[...]
During handling of the above exception, another exception occurred:
Traceback (most recent call
R. David Murray added the comment:
Jason: yes, if it is broken down into small enough pieces for the module
maintainer to be comfortable with the review :). I approved Serhiy's separate
patch for test_email. I still wasn't sure about backporting, but I really
don't l
R. David Murray added the comment:
See also issue 13229.
You can replicate 'rm -f' like this:
for p in glob.glob('/dir/*'):
os.remove(p)
That doesn't seem worth an extra function.
The annoying one to emulate is 'rm -rf /dir/*', because with th
R. David Murray added the comment:
You are essentially asking that we have an option to make the windows behavior
mirror the posix behavior? (A read only file in a writable directory can be
deleted in posix, since only the directory entry, not the file, is being
deleted.)
That makes some
R. David Murray added the comment:
Well, it would *definitely* need to be a new explicit option whose default
value was the current behavior.
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
You should probably start by summarizing the assertThat proposal from issue
18054, which suggested making a separate issue for assertThat.
--
nosy: +r.david.murray
title: Improving unittest assertions -> decouple unittest assertions from the
TestC
R. David Murray added the comment:
That's not a good name for the flag. The problem is that 'read-only' means
different things on Windows than it does on Unix. Which is why I suggested
that the flag control whether or not it acts "posix like" on Windows. So
perh
R. David Murray added the comment:
This is presumably a consequence of issue 11798. How did you run into it in
actual code?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
I can't get this to fail. The code handles None docstrings correctly
(_append_doc is not called if the __doc__ attribute is None).
The only way I can see this error arising would be if the _policybase.pyo file
had docstrings stripped, but the polic
Changes by R. David Murray :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue19626>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by R. David Murray :
--
status: pending -> open
superseder: -> pyo's are not overwritten by different optimization levels
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
Thanks, Tomas and Vajrasky. I tweaked the patch slightly: Thomas's fix was
better, since it doesn't incur the overhead of the repr unless an an error is
detected (a micro-optimization, true, but an easy one). I also chose to only
check that '
Changes by R. David Murray :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
R. David Murray added the comment:
This bug was apparently introduced as part of the work from issue 4184 in
python 3.2. My guess, looking at the code, is that the module simply didn't
work before that patch, since it would have been attempting to join binary data
using a string
R. David Murray added the comment:
Benjamin: the patch looks pretty good to me, for fixing the problem of
docstrings that are explicitly unicode. But before I go to the trouble of a
full review and test, is this a level of change you think is acceptable in 2.7
at this point it its lifecycle
R. David Murray added the comment:
I think the only backward compatible solution is to add a switch of *some* sort
(exact API TBD), whose default is to continue to decode using utf-8, and
document it as wrong.
Conversion of an email to unicode should be handled by the email package, not
by
R. David Murray added the comment:
Oh, and to clarify: the backward compatibility is that if code works with
X.Y.Z, it should work with X.Y.Z+1. So even though correctly handling binary
mail would indeed require someone to reexamine their code, if things happen to
be working OK for them (eg
R. David Murray added the comment:
Vajrasky: thanks for taking a crack at this, but, well, there are a lot of
subtleties involved here, due to the way the organic growth of the email
package over many years has led to some really bad design issues.
It took me a lot of time to boot back up my
Changes by R. David Murray :
Removed file: http://bugs.python.org/file32730/support_8bit_charset_cte.patch
___
Python tracker
<http://bugs.python.org/issue19063>
___
___
Changes by R. David Murray :
Added file: http://bugs.python.org/file32732/support_8bit_charset_cte.patch
___
Python tracker
<http://bugs.python.org/issue19063>
___
___
R. David Murray added the comment:
This is not something we are going to do. We don't know what every exception
is that every function can raise.
Adding mentions of unusual special cases that aren't currently documented would
be OK, though. You should open specific issues for
R. David Murray added the comment:
If switching to error codes would solve your problem, then catching Exception
at appropriate places should also solve your problem.
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Looking at the current buildbot history I don't see these errors any more. I'm
not sure how frequent they were, but I think I'll mark this as resolved and we
can reopen it if we see it again.
--
resolution: -> invalid
R. David Murray added the comment:
Ah, I posted a git-diff 3.3 patch. Let me repost it.
--
Added file: http://bugs.python.org/file32757/support_8bit_charset_cte.patch
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Well, we generally don't backport tests unless we are fixing related bugs. I
think this should be left alone.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
Changes by R. David Murray :
Removed file: http://bugs.python.org/file32732/support_8bit_charset_cte.patch
___
Python tracker
<http://bugs.python.org/issue19063>
___
___
R. David Murray added the comment:
I believe a new memoryview object is created, but the data is not copied.
That's the whole point of memoryview, I think :)
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Yes, I discovered this in testing, but I forgot to file a bug report for it.
It should be dealt with in a separate issue. And yes, it should be fixed,
since except for the documented on-demand filling out of missing pieces such as
MIME borders, the model
R. David Murray added the comment:
We've tried improving the locals docs several times. Modifying it is not
"safe", in the sense that what happens when you do is not defined by the
language. Which locals docs were you looking at?
I agree that 'representing' is
R. David Murray added the comment:
This is a tricky one. I can see the arguments either way, but it just feels
wrong to have future imports in stdlib code.
I personally don't see anything wrong with the import and doctest changes,
though. Sure, someone may come along later and unknow
R. David Murray added the comment:
Beta is out, so this issue must be targeted for 3.5.
--
nosy: +r.david.murray
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Can you show an example of the failure, including the traceback? I would think
that nttplib would be mostly operating on byte objects, and I'm sure Antoine
tested posting.
--
nosy: +pitrou, r.david.m
R. David Murray added the comment:
as_bytes was added in 3.4. For earlier python versions, you'll have to create
a BytesGenerator object and flatten the message using it to get a bytes object
you can past to post.
--
___
Python tracker
R. David Murray added the comment:
It might be worth adding a post_message method, analogous to the send_message
method I added to smtplib.
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Updated patch for 3.3, and a new patch for 3.4. In 3.4, set_payload raises an
error if non-ascii-surrogateescape text is passed in as the argument (ie: there
are non-ascii unicode characters in the string) and no charset is specified
with which to encode
Changes by R. David Murray :
Added file: http://bugs.python.org/file32838/support_8bit_charset_cte.patch
___
Python tracker
<http://bugs.python.org/issue19063>
___
___
New submission from R. David Murray:
Currently the string generator will downcast 8bit body parts to 7bit by
encoding them using a 7bit CTE. This is good. However, the way it does it is
to modify the Message object accordingly. This is not good. Except for
filling in required missing bits
R. David Murray added the comment:
Are you referring to implementing rfc 3463 and rfc 5248 insofar as they are
applicable? That seems useful. I don't see anything in the RFC about the 'xab
x.y.z text' form of the message, though. Where is that documented? IMO these
messages
R. David Murray added the comment:
I think this is reasonable. A patch would be welcome.
You could use inspect. When I had to do something similar I just did the call
inside a try/except, caught TypeError and retried without the extra argument.
See the __init__ of
R. David Murray added the comment:
Lacking feedback in the negative, I'm closing this.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
R. David Murray added the comment:
"Should" and "do" are different, though. I wouldn't be at all surprised to
find legacy code that did look at the text string part of the message.
Particularly test code, which is a place that smtpd gets used commonly.
Which pr
R. David Murray added the comment:
from the man page for strptime:
%w The weekday number (0-6) with Sunday = 0.
%W The week number with Monday the first day of the week (0-53).
The first Monday of January is the first day of week 1.
Python&#
Changes by R. David Murray :
--
nosy: +georg.brandl
priority: normal -> release blocker
stage: -> needs patch
type: crash -> behavior
___
Python tracker
<http://bugs.python.or
Changes by R. David Murray :
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue19729>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
components: +email
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19782>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
components: +email
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19784>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
components: +email
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19785>
___
___
Python-bugs-list m
R. David Murray added the comment:
It is definitely not a good idea to rely on that optimization of += for string.
Obviously bytes doesn't have the same optimization. (String didn't either for
a while in Python3, and there was some controversy around adding it back
exactly b
Changes by R. David Murray :
--
type: behavior -> performance
___
Python tracker
<http://bugs.python.org/issue19801>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
For the record, a little googling indicates this may be a linux-only option
(FreeBSD 6.4, for example, does not support it, nor does OS X 10.8, which are
two systems to which I currently have access). That doesn't mean it shouldn't
R. David Murray added the comment:
Yeah, I'm not sure how you'd write a test in such a way that it would test
anything meaningful. Parse the .h file in the test? Seems like overkill.
--
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
As I said, the decoding needs to be controlled by a switch (presumably a
keyword argument to SMTPServer) that defaults to the present (incorrect)
behavior.
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by R. David Murray :
--
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue19662>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
It occurs to me to wonder why smtpd is receiving 8bit data at all. It isn't
advertising the 8BITMIME capability, so the client should be sending only 7bit
data. See also issue 19662. I'm not sure that making utf-8 decoding work
better is a good
Changes by R. David Murray :
--
title: Adding a feature to python interpreter -> Display function signature in
TypeErrors resulting from argument mismatches
type: -> enhancement
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
That's much less readable than the output from pfydoc, which the user can
access easily (via either help at the interpreter prompt or pydoc at the shell
prompt). So I'm -1 on this proposed change.
--
nosy: +r.da
R. David Murray added the comment:
3.4 patch updated to address Vajrasky's review comment.
I'll probably apply this tomorrow.
--
Added file: http://bugs.python.org/file32898/support_8bit_charset_cte.patch
___
Python tracker
<http://bu
R. David Murray added the comment:
See also issue 1674555, which aims to make test_site run without -S and
everything else run with -S. I think this issue is invalid, if I understand
what you wrote correctly, since test_site *should* be reported as a skipped
test if -S is specified
Changes by R. David Murray :
--
components: +email
nosy: +barry, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19830>
___
___
Python-bugs-list m
R. David Murray added the comment:
On tip it would indeed be better to implement them. The deletion is only for
the released branches.
--
___
Python tracker
<http://bugs.python.org/issue19
R. David Murray added the comment:
Note that the equivalent linux command generates a warning message but does the
move anyway. In other words, this seems like a very reasonable request ;)
--
nosy: +r.david.murray
___
Python tracker
<h
Changes by R. David Murray :
--
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue19840>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
Can you explain what the source of the problem is that you are trying to solve?
It sounds like a bug in Nuitka, whatever that is.
It is doubtful that this patch would be applied, for the backward compatibility
reasons you cite.
--
nosy
R. David Murray added the comment:
Oh, and even if we decided there was enough reason to want to change the
parameter names (which so far it doesn't look like there is), it could never be
applied to 2.7, since the 2.7 API is frozen.
--
___
P
R. David Murray added the comment:
It's not, the beta is already out.
--
nosy: +r.david.murray
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
If it is an existing string, the backslashes are already in the string. The r
prefix or the escaping is only required to get the backslashes into a string
when you are coding them into a source file.
--
nosy: +r.david.murray
R. David Murray added the comment:
Victor can correct me if I'm wrong, but I believe that stdin/stdout/stderr all
use the filesystem encoding because filenames are the most likely source of
non-ascii characters on those streams. (Not a perfect solution, but the best
we c
R. David Murray added the comment:
That's not relevant, though. In fact, the existing error message for running
the module directly is exactly correct: the entire test module fails to run,
which is a more accurate reflection of the reality than showing all of the
individual tests as sk
R. David Murray added the comment:
Please take these observations and questions to python-list. They aren't
really appropriate for the bug tracker. We aren't going to add the
optimization shortcut for bytes unless someone does a bunch of convincing on
python-ideas, which seems unl
R. David Murray added the comment:
RFCs and cookies don't have much to do with each other in real life.
The 'httponly' flag bug was fixed in issue 16611.
For backward compatibility reasons we can't start raising errors where we
didn't raise them before, so if anythi
R. David Murray added the comment:
I'm not sure why that fix was not backported, so I think it should be OK to do
so.
3.2 is in security fix only mode. No one argued that it was a securty issue
when it was fixed in 3.3.
--
nosy: +r.david.m
R. David Murray added the comment:
This is presumably due to the new default enabling of readline, where it is
trying to save the history file when it exits.
--
nosy: +pitrou, r.david.murray
___
Python tracker
<http://bugs.python.org/issue19
5701 - 5800 of 10554 matches
Mail list logo
